tions(-)
Reviewed-by: Chris Lew
| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Chris Lew
of the various messages.
Signed-off-by: Bjorn Andersson
---
drivers/rpmsg/qcom_glink_native.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Chris Lew
@@ config QCOM_PIL_INFO
config QCOM_RPROC_COMMON
tristate
+ select AUXILIARY_BUS
config QCOM_Q6V5_COMMON
tristate
Reviewed-by: Chris Lew
_OCMEM
config QCOM_PD_MAPPER
tristate "Qualcomm Protection Domain Mapper"
select QCOM_QMI_HELPERS
+ select QCOM_PDR_MSG
+ select AUXILIARY_BUS
depends on NET && QRTR
default QCOM_RPROC_COMMON
help
Reviewed-by: Chris Lew
otection Domain Restart helpers")
Tested-by: Neil Armstrong # on SM8550-QRD
Tested-by: Steev Klimaszewski
Tested-by: Alexey Minnekhanov
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Chris Lew
On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote:
This commit introduces tracepoint support for smp2p,
enabling logging of communication between local and remote processors.
The tracepoints include information about the remote processor ID,
remote subsystem name, negotiation details, supported fea
On 6/11/2024 9:06 AM, Bjorn Andersson wrote:
On Tue, Jun 11, 2024 at 06:03:50PM +0530, Sudeepgoud Patil wrote:
Add smp2p irq devname which fetches remote name from respective
smp2p dtsi node, which makes the wakeup source distinguishable
in irq wakeup prints.
Signed-off-by: Sudeepgoud Patil
changed, 109 insertions(+)
Thanks for looking into whether this could be implemented as a
remoteproc subdevice.
Reviewed-by: Chris Lew
-
drivers/soc/qcom/Kconfig | 11 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/pdr_internal.h | 14 +
drivers/soc/qcom/qcom_pd_mapper.c | 676 ++
drivers/soc/qcom/qcom_pdr_msg.c | 34 ++
5 files changed, 736 insertions(+)
Reviewed-by: Chris Lew
goto out;
- for (i = domains_read; i < resp->domain_list_len; i++) {
+ for (i = 0; i < resp->domain_list_len; i++) {
entry = &resp->domain_list[i];
if (strnlen(entry->name, sizeof(entry->name)) == sizeof(entry->name))
Reviewed-by: Chris Lew
Hi Dmitry,
On 5/11/2024 2:56 PM, Dmitry Baryshkov wrote:
...
@@ -76,12 +76,12 @@ static int pdr_locator_new_server(struct qmi_handle *qmi,
locator_hdl);
struct pdr_service *pds;
+ mutex_lock(&pdr->lock);
/* Create a local client p
On 6/3/2024 2:37 AM, Caleb Connolly wrote:
Hi Deepak,
On 03/06/2024 09:36, Deepak Kumar Singh wrote:
There are certain usecases which require glink interrupt to be
wakeup capable. For example if handset is in sleep state and
usb charger is plugged in, dsp wakes up and sends glink interrupt
t
On 4/29/2024 12:55 AM, Sudeepgoud Patil wrote:
Introduce tracepoint support for smp2p providing useful logging
for communication between clients.
Let's add some more description as to why these tracepoint are useful.
Do they help us track latency? debugging information for us? for clients?
On 4/26/2024 6:36 PM, Dmitry Baryshkov wrote:
On Sat, 27 Apr 2024 at 04:03, Chris Lew wrote:
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
b/drivers/remoteproc/qcom_q6v5_adsp.c
index 1d24c9b656a8..02d0c626b03b 100644
--- a/drivers
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c
b/drivers/remoteproc/qcom_q6v5_adsp.c
index 1d24c9b656a8..02d0c626b03b 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -23,6 +23,7 @@
#include
#inc
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
+static int qcom_pdm_start(void)
+{
+ const struct of_device_id *match;
+ const struct qcom_pdm_domain_data * const *domains;
+ struct device_node *root;
+ int ret, i;
+
+ root = of_find_node_by_path("/");
+ if
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:
Add qmi_del_server(), a pair to qmi_add_server(), a way to remove
running server from the QMI socket. This is e.g. necessary for
pd-mapper, which needs to readd a server each time the DSP is started or
s/readd/read/
stopped.
Tested-by: Neil Ar
On 4/24/2024 2:27 AM, Dmitry Baryshkov wrote:
If the service locator server is restarted fast enough, the PDR can
rewrite locator_addr fields concurrently. Protect them by placing
modification of those fields under the main pdr->lock.
Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domai
wrote:
From: Chris Lew
Ignore the ENODEV failures returned by kernel_sendmsg(). These errors
indicate that either the local port has been closed or the remote has
gone down. Neither of these scenarios are fatal and will eventually be
handled through packets that are later queued on the control port
On 11/11/2020 10:33 AM, Sibi Sankar wrote:
Hey Chris,
Thanks for the patch.
On 2020-11-03 08:49, Chris Lew wrote:
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own
It can be useful to control the different power states of various
parts of hardware for device testing. Add a debugfs node to send
messages through qmp to aoss for debugging and testing purposes.
Signed-off-by: Chris Lew
---
drivers/soc/qcom/qcom_aoss.c | 36
Not all upcoming usecases will have an interface to allow the aoss
driver to hook onto. Expose the send api and create a get function to
enable drivers to send their own messages to aoss.
Signed-off-by: Chris Lew
---
drivers/soc/qcom/qcom_aoss.c | 28 +++-
include
Hi Greg,
On 8/7/2020 12:59 AM, Greg KH wrote:
On Wed, Jun 24, 2020 at 10:15:19PM +0530, Deepak Kumar Singh wrote:
From: Chris Lew
In RPMSG GLINK the chrdev device will allocate an ept as part of the
rpdev creation. This device will not register endpoint ops even though
it has an allocated
: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
Signed-off-by: Chris Lew
---
net/qrtr/ns.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
index e7d0fe3f4330..c5b3202a14ca 100644
--- a/net/qrtr/ns.c
On 10/9/2019 10:04 PM, Stephen Boyd wrote:
Quoting Chris Lew (2019-10-08 18:33:45)
If a channel is being rapidly restarted and the kobj release worker is
busy, there is a chance the the rpdev_release function will run after
the channel struct itself has been released.
There should not be a
happen from the channel close
commands.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index 621f1afd4d6b..836a0bd99d11 100644
--- a/drivers/rpmsg
: Srinivas Kandagatla
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Tested-by: Srinivas Kandagatla
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Cc: sta...@vger.kernel.org
Tested-by: Srinivas Kandagatla
Signed-off-by: Arun Kumar Neelakantam
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Foru
: Add support for TX intents")
Cc: sta...@vger.kernel.org
Tested-by: Srinivas Kandagatla
Signed-off-by: Arun Kumar Neelakantam
Reported-by: Srinivas Kandagatla
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux
Current QMI clients are not userspace facing, if their threads are
signaled, they do not do any signal checking or propagate the
ERESTARTSYS return code up. Remove the interruptible option so clients
can finish their QMI transactions even if the thread is signaled.
Signed-off-by: Chris Lew
When wrapping around the FIFO, the remote expects the tail pointer to
be reset to 0 on the edge case where the tail equals the FIFO length.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg
The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
drivers/rpmsg/qcom_glink_native.c | 4 ++--
1
complete_all the open_req/ack variables
- Add patch to prevent null pointer dereference in chrdev channel release
- Change chrdev allocation to use glink channel allocation
- Change glink attr struct to const
Chris Lew (6):
dt-bindings: soc: qcom: Add label for GLINK bindings
rpmsg: glink: Store
In RPMSG GLINK the chrdev device will allocate an ept as part of the
rpdev creation. This device will not register endpoint ops even though
it has an allocated ept. Protect against the case where the device is
being destroyed.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
Channels may need to identify the edge their channel was probed for.
Store the edge name by reading the label property from device tree or
default to the node name.
Signed-off-by: Chris Lew
---
Changes since v1:
- None
drivers/rpmsg/qcom_glink_native.c | 6 ++
1 file changed, 6 insertions
There are GLINK clients who open the same channel on multiple GLINK
links. These clients need a way to distinguish which remoteproc they
are communicating to. Add a label property to identify the edge this
node represents.
Signed-off-by: Chris Lew
---
Changes since v1:
- Add explanation for
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew
---
Changes since v2:
- Remove const on attribute struct
Changes since v1:
- Add const to attribute struct
- Get name from glink channel
drivers
RPMSG provides a char device interface to userspace. Probe the rpmsg
chrdev channel to enable the rpmsg_ctrl device creation on glink
transports.
Signed-off-by: Chris Lew
---
Changes since v1:
- Use qcom_glink_alloc_channel to create the chrdev rpmsg device
drivers/rpmsg/qcom_glink_native.c
ens up the ability of tunneling qrtr over a network or USB link.
Signed-off-by: Bjorn Andersson
Acked-by: Chris Lew
+static ssize_t qrtr_tun_read_iter(struct kiocb *iocb, struct iov_iter *to)
+{
+ struct file *filp = iocb->ki_filp;
+ struct qrtr_tun *tun = filp->private_data
RPMSG provides a char device interface to userspace. Probe the rpmsg
chrdev channel to enable the rpmsg_ctrl device creation on glink
transports.
Signed-off-by: Chris Lew
---
Changes since v1:
- Use qcom_glink_alloc_channel to create the chrdev rpmsg device
drivers/rpmsg/qcom_glink_native.c
pointer dereference in chrdev channel release
- Change chrdev allocation to use glink channel allocation
- Change glink attr struct to const
Chris Lew (6):
dt-bindings: soc: qcom: Add label for GLINK bindings
rpmsg: glink: Store edge name for glink device
rpmsg: glink: Use complete_all for open
In RPMSG GLINK the chrdev device will allocate an ept as part of the
rpdev creation. This device will not register endpoint ops even though
it has an allocated ept. Protect against the case where the device is
being destroyed.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
Channels may need to identify the edge their channel was probed for.
Store the edge name by reading the label property from device tree or
default to the node name.
Signed-off-by: Chris Lew
---
Changes since v1:
- None
drivers/rpmsg/qcom_glink_native.c | 6 ++
1 file changed, 6 insertions
There are GLINK clients who open the same channel on multiple GLINK
links. These clients need a way to distinguish which remoteproc they
are communicating to. Add a label property to identify the edge this
node represents.
Signed-off-by: Chris Lew
---
Changes since v1:
- Add explanation for
The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
drivers/rpmsg/qcom_glink_native.c | 4 ++--
1
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew
---
Changes since v1:
- Add const to attribute struct
- Get name from glink channel
drivers/rpmsg/qcom_glink_native.c | 18 ++
1
Hi Alex,
Minor comment.
On 4/25/2018 8:18 AM, Alex Elder wrote:
Create function qcom_smem_virt_to_phys(), which returns the physical
address corresponding to a given SMEM item's virtual address. This
feature is required for a driver that will soon be out for review.
Signed-off-by: Alex Elder
Hey Bjorn,
Minor issue with the glink patch.
Thanks,
Chris
On 2/13/2018 11:04 AM, Bjorn Andersson wrote:
[..]
@@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink,
const void *data, size_t dlen, bool wait)
{
unsigned int tlen = hlen + dlen
On 12/21/2017 11:36 AM, Stephen Boyd wrote:
On 12/20/2017 05:35 PM, Bjorn Andersson wrote:
On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote:
On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote:
Add a label property to identify the edge this node represents.
Why does a user need to
On 12/19/2017 9:52 AM, Bjorn Andersson wrote:
On Mon 18 Dec 14:02 PST 2017, Chris Lew wrote:
Add support for client's to query the edge name their channel is
registered for. This is useful for clients who share the same channel
identifier across different remote procs.
I presume this
On 12/18/2017 2:48 PM, Stephen Boyd wrote:
On 12/18/2017 02:02 PM, Chris Lew wrote:
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 18
On 12/14/2017 12:15 PM, Bjorn Andersson wrote:
Ensure the ordering of the fifo write and the update of the write index,
so that the index is not updated before the data has landed in the fifo.
Reported-by: Arun Kumar Neelakantam
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg
chrdev channel to enable the rpmsg_ctrl device creation on glink
transports.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 39 +++
1 file changed, 39 insertions(+)
diff
Expose the name field as an attr so clients listening to uevents for
rpmsg can identify the edge the events correspond to.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b
Add support for clients to query the edge name for the glink device
their channel is registered for.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
Add support for client's to query the edge name their channel is
registered for. This is useful for clients who share the same channel
identifier across different remote procs.
Signed-off-by: Chris Lew
---
drivers/rpmsg/rpmsg_core.c | 21 +
drivers/rpmsg/rpmsg_inter
Channels may need to identify the edge their channel was probed for.
Store the edge name by reading the label property from device tree or
default to the node name.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
- rpmsg_get_rproc_name() for kernel clients.
Chris Lew (6):
dt-bindings: soc: qcom: Add label for GLINK bindings
rpmsg: glink: Store edge name for glink device
rpmsg: glink: Add support for rpmsg glink chrdev
rpmsg: glink: Expose rpmsg name attr for glink
rpmsg: Introduce rpmsg_get_rproc_name
Add a label property to identify the edge this node represents.
Signed-off-by: Chris Lew
---
Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
b/Documentation/devicetree
: Bjorn Andersson
---
Acked-By: Chris Lew
Looked into who is listening to the other notifications besides
BEFORE_SHUTDOWN and I think subsequent patches will need to add support
for at least AFTER_POWERUP.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation
e responses from the remote.
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
this information to the subdev remove functions.
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
, reducing most of the duplication in such cases.
Tested-By: Srinivas Kandagatla
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
debug-logging part was omitted, for now.
Tested-By: Chris Lew
Tested-By: Srinivas Kandagatla
Signed-off-by: Bjorn Andersson
---
Acked-By: Chris Lew
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
On 11/15/2017 12:10 PM, Bjorn Andersson wrote:
[..]> +static void qmi_handle_message(struct qmi_handle *qmi,
+ struct sockaddr_qrtr *sq,
+ const void *buf, size_t len)
+{
+ const struct qmi_header *hdr;
+ struct qmi_txn tmp_tx
On 11/16/2017 9:58 PM, Bjorn Andersson wrote:
On Thu 16 Nov 12:05 PST 2017, Chris Lew wrote:
+ req.event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN;
Are there plans to add the other SSR events to sysmon notifiers? I think the
SSCTL service expects to receive events about remote procs starting
Hi Bjorn,
Question about the SSR events for sysmon.
Thanks,
Chris
On 11/15/2017 12:10 PM, Bjorn Andersson wrote:
[..]
+/**
+ * ssctl_send_event() - send notification of other remote's SSR event
+ * @sysmon:sysmon context
+ * @name: other remote's name
+ */
+static void ssctl_send_eve
dr) + *len, GFP_KERNEL);
+ if (!msg)
+ return ERR_PTR(-ENOMEM);
+
+ msglen = qmi_encode(ei, msg + sizeof(*hdr), c_struct, *len, 1);
+ if (msglen < 0) {
+ kfree(msg);
+ return ERR_PTR(msglen);
+ }
Talked to Chris Lew about this earlier toda
Hi Bjorn,
Found a minor typo.
On 11/6/2017 9:20 PM, Bjorn Andersson wrote:
[..]
+ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq,
+ int msg_id, size_t len, struct qmi_elem_info *ei,
+ const void *c_struct)
+{
+
On 10/27/2017 3:45 AM, Arun Kumar Neelakantam wrote:
The "intent_req_comp" variable is used without initialization which
results in NULL pointer derefernce in qcom_glink_request_intent().
Typo on dereference.
Thanks,
Chris
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
Intents can vary in size, try to find the best fitting remote intent
instead of first fit when sending a message to the remote proc.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg
The base intents prequeued during channel creation may not satisfy a
channel's throughput requirement. Add support for intents dt-binding to
allow channels to specify the size and amount of intents to prequeue
during endpoint announcement.
Signed-off-by: Chris Lew
---
Changes since v1:
- C
instead
of allocating on demand.
Chris Lew (3):
dt-bindings: soc: qcom: Support GLINK intents
rpmsg: glink: Add support to preallocate intents
rpmsg: glink: Use best fit intent during tx
.../devicetree/bindings/soc/qcom/qcom,glink.txt| 10 +
drivers/rpmsg/qcom_glink_native.c
Virtual GLINK channels may know what throughput to expect from a
remoteproc. An intent advertises to the remoteproc this channel is
ready to receive data. Allow a channel to define the size and amount of
intents to be prequeued.
Signed-off-by: Chris Lew
---
Changes since v1:
- Change intents
On 10/19/2017 10:00 PM, Bjorn Andersson wrote:
On Wed 18 Oct 18:10 PDT 2017, Chris Lew wrote:
Virtual GLINK channels may know what throughput to expect from a
remoteproc. An intent advertises to the remoteproc this channel is
ready to receive data. Allow a channel to define the size and
Intents can vary in size, try to find the best fitting remote intent
instead of first fit when sending a message to the remote proc.
Signed-off-by: Chris Lew
---
drivers/rpmsg/qcom_glink_native.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg
Virtual GLINK channels may know what throughput to expect from a
remoteproc. An intent advertises to the remoteproc this channel is
ready to receive data. Allow a channel to define the size and amount of
intents to be prequeued.
Signed-off-by: Chris Lew
---
Documentation/devicetree/bindings/soc
instead
of allocating on demand.
Chris Lew (3):
dt-bindings: soc: qcom: Support GLINK intents
rpmsg: glink: Add support to preallocate intents
rpmsg: glink: Use best fit intent during tx
.../devicetree/bindings/soc/qcom/qcom,glink.txt| 10 +
drivers/rpmsg/qcom_glink_native.c
The base intents prequeued during channel creation may not satisfy a
channel's throughput requirement. Add support for intents dt-binding to
allow channels to specify the size and amount of intents to prequeue
during endpoint announcement.
Signed-off-by: Chris Lew
---
drivers/
From: Chris Lew
SMEM V12 creates a global partition to allocate global smem items from
instead of a global heap. The global partition has the same structure as
a private partition.
Signed-off-by: Chris Lew
---
Changes since v1:
- Move V12 descriptions to top comment
- Add cacheline support to
From: Chris Lew
In V12 SMEM, SBL writes SMEM parameter information after the TOC. Use
the SBL provided item count as the max item number.
Signed-off-by: Chris Lew
---
Changes since v1:
- Change num_items to __le16 from __le32
- Move max smem item warning to generic get/alloc functions
- Use
From: Chris Lew
Increase the maximum number of hosts in a system to 10.
Signed-off-by: Chris Lew
---
Changes since v1:
- None
Changes since v2:
- None
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom
From: Chris Lew
Endianness can vary in the system, add le32_to_cpu when comparing
partition sizes from smem.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
Changes since v2:
- Reduce subject to 50 chars and wrap summary to 72 chars
drivers/soc/qcom/smem.c | 2 +-
1 file
number of hosts are increased for later chipsets.
This patchset depends on patch: Qualcomm SMEM cached item support.
Chris Lew (5):
soc: qcom: smem: Use le32_to_cpu for comparison
soc: qcom: smem: Read version from the smem header
soc: qcom: smem: Support global partition
soc: qcom: smem
From: Chris Lew
The SMEM header structure includes the version information. Read the
version directly from the header instead of getting an item from the
global heap.
Signed-off-by: Chris Lew
---
Changes since v1:
- Remove unused smem item version macro
- Move smem get version change to
On 9/6/2017 11:03 PM, Bjorn Andersson wrote:
Rather than manually waking up any context sleeping on the sock to
signal an error we should call sk_error_report(). This has the added
benefit that in-kernel consumers can override this notificatino with
its own callback.
Typo with notification.
On 9/15/2017 11:33 AM, Bjorn Andersson wrote:
On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:
[..]
+static struct smem_ptable *qcom_smem_get_ptable(struct qcom_smem *smem)
{
- struct smem_partition_header *header;
- struct smem_ptable_entry *entry;
struct smem_ptable
On 9/15/2017 11:39 AM, Stephen Boyd wrote:
On 09/14, Chris Lew wrote:
Endianness can vary in the system, add le32_to_cpu when comparing
size values from smem.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1
The SMEM header structure includes the version information.
Read the version directly from the header instead of getting
an item from the global heap.
Signed-off-by: Chris Lew
---
Changes since v1:
- Remove unused smem item version macro
- Move smem get version change to separate commit
SMEM V12 creates a global partition to allocate global
smem items from instead of a global heap. The global
partition has the same structure as a private partition.
Signed-off-by: Chris Lew
---
Changes since v1:
- Move V12 descriptions to top comment
- Add cacheline support to global partition
Increase the maximum number of hosts in a system to 10.
Signed-off-by: Chris Lew
---
Changes since v1:
- None
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 2f3b1e1a8904..086f31b6c584 100644
number of hosts are increased for later chipsets.
This patchset depends on patch: Qualcomm SMEM cached item support
Chris Lew (5):
soc: qcom: smem: Use le32_to_cpu for partition size comparison
soc: qcom: smem: Read version by using the smem header
soc: qcom: smem: Support global partition
Endianness can vary in the system, add le32_to_cpu when comparing
size values from smem.
Signed-off-by: Chris Lew
---
Changes since v1:
- New change
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
In V12 SMEM, SBL writes SMEM parameter information
after the TOC. Use the SBL provided item count
as the max item number.
Signed-off-by: Chris Lew
---
Changes since v1:
- Change num_items to __le16 from __le32
- Move max smem item warning to generic get/alloc functions
- Use get ptable helper
Hi Sricharan,
Minor bug in this patch.
On 8/24/2017 12:21 AM, Sricharan R wrote:
[..]
@@ -829,11 +839,14 @@ static int qcom_glink_rx_open(struct qcom_glink *glink,
unsigned int rcid,
struct device_node *node;
int lcid;
int ret;
+ unsigned long flags;
+ spin_loc
Hi Bjorn,
Thanks for the review.
On 8/21/2017 10:17 AM, Bjorn Andersson wrote:
#define SMEM_MASTER_SBL_VERSION_INDEX7
-#define SMEM_EXPECTED_VERSION 11
+#define SMEM_GLOBAL_HEAP_VERSION 11
+
+/*
+ * Version 12 (SMEM_GLOBAL_PART_VERSION) changes the item alloc/get proce
In V12 SMEM, SBL writes SMEM parameter information
after the TOC. Use the SBL provided item count
as the max item number.
Signed-off-by: Chris Lew
---
drivers/soc/qcom/smem.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/drivers
SMEM V12 creates a global partition to allocate global
smem items from instead of a global heap. The global
partition has the same structure as a private partition.
Signed-off-by: Chris Lew
---
drivers/soc/qcom/smem.c | 134 +---
1 file changed, 105
1 - 100 of 102 matches
Mail list logo
