Re: [PATCH v8 2/5] soc: qcom: pdr: fix parsing of domains lists

2024-06-05 Thread Chris Lew
goto out; - for (i = domains_read; i < resp->domain_list_len; i++) { + for (i = 0; i < resp->domain_list_len; i++) { entry = >domain_list[i]; if (strnlen(entry->name, sizeof(entry->name)) == sizeof(entry->name)) Reviewed-by: Chris Lew

Re: [PATCH v8 1/5] soc: qcom: pdr: protect locator_addr with the main mutex

2024-06-05 Thread Chris Lew
Hi Dmitry, On 5/11/2024 2:56 PM, Dmitry Baryshkov wrote: ... @@ -76,12 +76,12 @@ static int pdr_locator_new_server(struct qmi_handle *qmi, locator_hdl); struct pdr_service *pds; + mutex_lock(>lock); /* Create a local client port

Re: [PATCH V1] rpmsg: glink: Make glink smem interrupt wakeup capable

2024-06-04 Thread Chris Lew
On 6/3/2024 2:37 AM, Caleb Connolly wrote: Hi Deepak, On 03/06/2024 09:36, Deepak Kumar Singh wrote: There are certain usecases which require glink interrupt to be wakeup capable. For example if handset is in sleep state and usb charger is plugged in, dsp wakes up and sends glink interrupt

Re: [PATCH V1] soc: qcom: smp2p: Introduce tracepoint support

2024-04-30 Thread Chris Lew
On 4/29/2024 12:55 AM, Sudeepgoud Patil wrote: Introduce tracepoint support for smp2p providing useful logging for communication between clients. Let's add some more description as to why these tracepoint are useful. Do they help us track latency? debugging information for us? for

Re: [PATCH v7 6/6] remoteproc: qcom: enable in-kernel PD mapper

2024-04-30 Thread Chris Lew
On 4/26/2024 6:36 PM, Dmitry Baryshkov wrote: On Sat, 27 Apr 2024 at 04:03, Chris Lew wrote: On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index 1d24c9b656a8..02d0c626b03b 100644 --- a/drivers

Re: [PATCH v7 6/6] remoteproc: qcom: enable in-kernel PD mapper

2024-04-26 Thread Chris Lew
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index 1d24c9b656a8..02d0c626b03b 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -23,6 +23,7 @@ #include

Re: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation

2024-04-26 Thread Chris Lew
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: +static int qcom_pdm_start(void) +{ + const struct of_device_id *match; + const struct qcom_pdm_domain_data * const *domains; + struct device_node *root; + int ret, i; + + root = of_find_node_by_path("/"); + if

Re: [PATCH v7 4/6] soc: qcom: qmi: add a way to remove running service

2024-04-25 Thread Chris Lew
On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote: Add qmi_del_server(), a pair to qmi_add_server(), a way to remove running server from the QMI socket. This is e.g. necessary for pd-mapper, which needs to readd a server each time the DSP is started or s/readd/read/ stopped. Tested-by: Neil

Re: [PATCH v7 1/6] soc: qcom: pdr: protect locator_addr with the main mutex

2024-04-25 Thread Chris Lew
On 4/24/2024 2:27 AM, Dmitry Baryshkov wrote: If the service locator server is restarted fast enough, the PDR can rewrite locator_addr fields concurrently. Protect them by placing modification of those fields under the main pdr->lock. Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection

Re: [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns

2023-12-26 Thread Chris Lew
wrote: From: Chris Lew Ignore the ENODEV failures returned by kernel_sendmsg(). These errors indicate that either the local port has been closed or the remote has gone down. Neither of these scenarios are fatal and will eventually be handled through packets that are later queued on the control port

Re: [PATCH 1/2] soc: qcom: aoss: Expose send for generic usecase

2020-11-17 Thread Chris Lew
On 11/11/2020 10:33 AM, Sibi Sankar wrote: Hey Chris, Thanks for the patch. On 2020-11-03 08:49, Chris Lew wrote: Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own

[PATCH 2/2] soc: qcom: aoss: Add debugfs send entry

2020-11-03 Thread Chris Lew
It can be useful to control the different power states of various parts of hardware for device testing. Add a debugfs node to send messages through qmp to aoss for debugging and testing purposes. Signed-off-by: Chris Lew --- drivers/soc/qcom/qcom_aoss.c | 36

[PATCH 1/2] soc: qcom: aoss: Expose send for generic usecase

2020-11-03 Thread Chris Lew
Not all upcoming usecases will have an interface to allow the aoss driver to hook onto. Expose the send api and create a get function to enable drivers to send their own messages to aoss. Signed-off-by: Chris Lew --- drivers/soc/qcom/qcom_aoss.c | 28 +++- include

Re: [PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy

2020-08-07 Thread Chris Lew
Hi Greg, On 8/7/2020 12:59 AM, Greg KH wrote: On Wed, Jun 24, 2020 at 10:15:19PM +0530, Deepak Kumar Singh wrote: From: Chris Lew In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated

[PATCH] net: qrtr: Allocate workqueue before kernel_bind

2020-05-28 Thread Chris Lew
: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace") Signed-off-by: Chris Lew --- net/qrtr/ns.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c index e7d0fe3f4330..c5b3202a14ca 100644 --- a/net/qrtr/ns.c

Re: [PATCH] rpmsg: glink: Remove channel decouple from rpdev release

2019-10-11 Thread Chris Lew
On 10/9/2019 10:04 PM, Stephen Boyd wrote: Quoting Chris Lew (2019-10-08 18:33:45) If a channel is being rapidly restarted and the kobj release worker is busy, there is a chance the the rpdev_release function will run after the channel struct itself has been released. There should

[PATCH] rpmsg: glink: Remove channel decouple from rpdev release

2019-10-08 Thread Chris Lew
happen from the channel close commands. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 621f1afd4d6b..836a0bd99d11 100644 --- a/drivers/rpmsg

Re: [PATCH v2 6/6] rpmsg: glink: Free pending deferred work on remove

2019-10-08 Thread Chris Lew
: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 5/6] rpmsg: glink: Don't send pending rx_done during remove

2019-10-08 Thread Chris Lew
org Tested-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 2/6] rpmsg: glink: Fix use after free in open_ack TIMEOUT case

2019-10-08 Thread Chris Lew
: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver") Cc: sta...@vger.kernel.org Tested-by: Srinivas Kandagatla Signed-off-by: Arun Kumar Neelakantam Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Foru

Re: [PATCH v2 1/6] rpmsg: glink: Fix reuse intents memory leak issue

2019-10-08 Thread Chris Lew
: Add support for TX intents") Cc: sta...@vger.kernel.org Tested-by: Srinivas Kandagatla Signed-off-by: Arun Kumar Neelakantam Reported-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux

[PATCH] soc: qcom: qmi: Change txn wait to non-interruptible

2019-02-21 Thread Chris Lew
Current QMI clients are not userspace facing, if their threads are signaled, they do not do any signal checking or propagate the ERESTARTSYS return code up. Remove the interruptible option so clients can finish their QMI transactions even if the thread is signaled. Signed-off-by: Chris Lew

[PATCH] rpmsg: glink: Set tail pointer to 0 at end of FIFO

2018-06-27 Thread Chris Lew
When wrapping around the FIFO, the remote expects the tail pointer to be reset to 0 on the edge case where the tail equals the FIFO length. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg

[PATCH] rpmsg: glink: Set tail pointer to 0 at end of FIFO

2018-06-27 Thread Chris Lew
When wrapping around the FIFO, the remote expects the tail pointer to be reset to 0 on the edge case where the tail equals the FIFO length. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_smem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg

[PATCH v3 0/6] Add chrdev and name query support for GLINK

2018-04-26 Thread Chris Lew
complete_all the open_req/ack variables - Add patch to prevent null pointer dereference in chrdev channel release - Change chrdev allocation to use glink channel allocation - Change glink attr struct to const Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store

[PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

2018-04-26 Thread Chris Lew
In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes si

[PATCH v3 3/6] rpmsg: glink: Use complete_all for open states

2018-04-26 Thread Chris Lew
The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - New change drivers

[PATCH v3 3/6] rpmsg: glink: Use complete_all for open states

2018-04-26 Thread Chris Lew
The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew --- Changes since v1: - New change drivers/rpmsg/qcom_glink_native.c | 4 ++-- 1

[PATCH v3 0/6] Add chrdev and name query support for GLINK

2018-04-26 Thread Chris Lew
complete_all the open_req/ack variables - Add patch to prevent null pointer dereference in chrdev channel release - Change chrdev allocation to use glink channel allocation - Change glink attr struct to const Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store

[PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy

2018-04-26 Thread Chris Lew
In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew --- Changes since v1: - New change

[PATCH v3 2/6] rpmsg: glink: Store edge name for glink device

2018-04-26 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - None drivers/rpmsg/qcom_glink_native.c | 6 ++

[PATCH v3 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-04-26 Thread Chris Lew
There are GLINK clients who open the same channel on multiple GLINK links. These clients need a way to distinguish which remoteproc they are communicating to. Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes si

[PATCH v3 2/6] rpmsg: glink: Store edge name for glink device

2018-04-26 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew --- Changes since v1: - None drivers/rpmsg/qcom_glink_native.c | 6 ++ 1 file changed, 6 insertions

[PATCH v3 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-04-26 Thread Chris Lew
There are GLINK clients who open the same channel on multiple GLINK links. These clients need a way to distinguish which remoteproc they are communicating to. Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew --- Changes since v1: - Add explanation

[PATCH v3 6/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-04-26 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v2: - Remove const on attribute struct Changes since v1: - Add const to attribute struct - Get nam

[PATCH v3 5/6] rpmsg: glink: Add support for rpmsg glink chrdev

2018-04-26 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - Use qcom_glink_alloc_channel to create the chrdev rpmsg device drivers

[PATCH v3 6/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-04-26 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew --- Changes since v2: - Remove const on attribute struct Changes since v1: - Add const to attribute struct - Get name from glink channel drivers

[PATCH v3 5/6] rpmsg: glink: Add support for rpmsg glink chrdev

2018-04-26 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew --- Changes since v1: - Use qcom_glink_alloc_channel to create the chrdev rpmsg device drivers/rpmsg/qcom_glink_native.c

Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space

2018-04-26 Thread Chris Lew
s opens up the ability of tunneling qrtr over a network or USB link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Acked-by: Chris Lew <c...@codeaurora.org> +static ssize_t qrtr_tun_read_iter(struct kiocb *iocb, struct iov_iter *to) +{ + struct file *filp = iocb->ki_filp

Re: [PATCH v2] net: qrtr: Expose tunneling endpoint to user space

2018-04-26 Thread Chris Lew
s opens up the ability of tunneling qrtr over a network or USB link. Signed-off-by: Bjorn Andersson Acked-by: Chris Lew +static ssize_t qrtr_tun_read_iter(struct kiocb *iocb, struct iov_iter *to) +{ + struct file *filp = iocb->ki_filp; + struct qrtr_tun *tun = filp->private_data

[PATCH v2 5/6] rpmsg: glink: Add support for rpmsg glink chrdev

2018-04-25 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - Use qcom_glink_alloc_channel to create the chrdev rpmsg device drivers

[PATCH v2 5/6] rpmsg: glink: Add support for rpmsg glink chrdev

2018-04-25 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew --- Changes since v1: - Use qcom_glink_alloc_channel to create the chrdev rpmsg device drivers/rpmsg/qcom_glink_native.c

[PATCH v2 0/6] Add chrdev and name query support for GLINK

2018-04-25 Thread Chris Lew
pointer dereference in chrdev channel release - Change chrdev allocation to use glink channel allocation - Change glink attr struct to const Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store edge name for glink device rpmsg: glink: Use complete_all for open

[PATCH v2 0/6] Add chrdev and name query support for GLINK

2018-04-25 Thread Chris Lew
pointer dereference in chrdev channel release - Change chrdev allocation to use glink channel allocation - Change glink attr struct to const Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store edge name for glink device rpmsg: glink: Use complete_all for open

[PATCH v2 4/6] rpmsg: Guard against null endpoint ops in destroy

2018-04-25 Thread Chris Lew
In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes si

[PATCH v2 4/6] rpmsg: Guard against null endpoint ops in destroy

2018-04-25 Thread Chris Lew
In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew --- Changes since v1: - New change

[PATCH v2 2/6] rpmsg: glink: Store edge name for glink device

2018-04-25 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - None drivers/rpmsg/qcom_glink_native.c | 6 ++

[PATCH v2 2/6] rpmsg: glink: Store edge name for glink device

2018-04-25 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew --- Changes since v1: - None drivers/rpmsg/qcom_glink_native.c | 6 ++ 1 file changed, 6 insertions

[PATCH v2 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-04-25 Thread Chris Lew
There are GLINK clients who open the same channel on multiple GLINK links. These clients need a way to distinguish which remoteproc they are communicating to. Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes si

[PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-04-25 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - Add const to attribute struct - Get name from glink channel drivers/rpmsg/qcom_glink_native.

[PATCH v2 3/6] rpmsg: glink: Use complete_all for open states

2018-04-25 Thread Chris Lew
The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Changes since v1: - New change drivers

[PATCH v2 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-04-25 Thread Chris Lew
There are GLINK clients who open the same channel on multiple GLINK links. These clients need a way to distinguish which remoteproc they are communicating to. Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew --- Changes since v1: - Add explanation

[PATCH v2 3/6] rpmsg: glink: Use complete_all for open states

2018-04-25 Thread Chris Lew
The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew --- Changes since v1: - New change drivers/rpmsg/qcom_glink_native.c | 4 ++-- 1

[PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-04-25 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew --- Changes since v1: - Add const to attribute struct - Get name from glink channel drivers/rpmsg/qcom_glink_native.c | 18 ++ 1

Re: [PATCH] soc: qcom: smem: introduce qcom_smem_virt_to_phys()

2018-04-25 Thread Chris Lew
Hi Alex, Minor comment. On 4/25/2018 8:18 AM, Alex Elder wrote: Create function qcom_smem_virt_to_phys(), which returns the physical address corresponding to a given SMEM item's virtual address. This feature is required for a driver that will soon be out for review. Signed-off-by: Alex Elder

Re: [PATCH] soc: qcom: smem: introduce qcom_smem_virt_to_phys()

2018-04-25 Thread Chris Lew
Hi Alex, Minor comment. On 4/25/2018 8:18 AM, Alex Elder wrote: Create function qcom_smem_virt_to_phys(), which returns the physical address corresponding to a given SMEM item's virtual address. This feature is required for a driver that will soon be out for review. Signed-off-by: Alex Elder

Re: [PATCH] rpmsg: glink: Use spinlock in tx path

2018-02-21 Thread Chris Lew
Hey Bjorn, Minor issue with the glink patch. Thanks, Chris On 2/13/2018 11:04 AM, Bjorn Andersson wrote: [..] @@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink, const void *data, size_t dlen, bool wait) { unsigned int tlen = hlen +

Re: [PATCH] rpmsg: glink: Use spinlock in tx path

2018-02-21 Thread Chris Lew
Hey Bjorn, Minor issue with the glink patch. Thanks, Chris On 2/13/2018 11:04 AM, Bjorn Andersson wrote: [..] @@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink, const void *data, size_t dlen, bool wait) { unsigned int tlen = hlen +

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-01-09 Thread Chris Lew
On 12/21/2017 11:36 AM, Stephen Boyd wrote: On 12/20/2017 05:35 PM, Bjorn Andersson wrote: On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote: On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote: Add a label property to identify the edge this node represents. Why does a user need

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-01-09 Thread Chris Lew
On 12/21/2017 11:36 AM, Stephen Boyd wrote: On 12/20/2017 05:35 PM, Bjorn Andersson wrote: On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote: On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote: Add a label property to identify the edge this node represents. Why does a user need

Re: [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name

2018-01-09 Thread Chris Lew
On 12/19/2017 9:52 AM, Bjorn Andersson wrote: On Mon 18 Dec 14:02 PST 2017, Chris Lew wrote: Add support for client's to query the edge name their channel is registered for. This is useful for clients who share the same channel identifier across different remote procs. I presume

Re: [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name

2018-01-09 Thread Chris Lew
On 12/19/2017 9:52 AM, Bjorn Andersson wrote: On Mon 18 Dec 14:02 PST 2017, Chris Lew wrote: Add support for client's to query the edge name their channel is registered for. This is useful for clients who share the same channel identifier across different remote procs. I presume

Re: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-01-09 Thread Chris Lew
On 12/18/2017 2:48 PM, Stephen Boyd wrote: On 12/18/2017 02:02 PM, Chris Lew wrote: Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers

Re: [PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink

2018-01-09 Thread Chris Lew
On 12/18/2017 2:48 PM, Stephen Boyd wrote: On 12/18/2017 02:02 PM, Chris Lew wrote: Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 18

Re: [PATCH] rpmsg: glink: smem: Ensure ordering during tx

2017-12-18 Thread Chris Lew
ersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] rpmsg: glink: smem: Ensure ordering during tx

2017-12-18 Thread Chris Lew
On 12/14/2017 12:15 PM, Bjorn Andersson wrote: Ensure the ordering of the fifo write and the update of the write index, so that the index is not updated before the data has landed in the fifo. Reported-by: Arun Kumar Neelakantam Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew

[PATCH 3/6] rpmsg: glink: Add support for rpmsg glink chrdev

2017-12-18 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers/rpmsg/qcom_glink_native.c | 39 +++ 1 file chang

[PATCH 3/6] rpmsg: glink: Add support for rpmsg glink chrdev

2017-12-18 Thread Chris Lew
RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 39 +++ 1 file changed, 39 insertions(+) diff

[PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink

2017-12-18 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers/rpmsg/qcom_glink_native.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers

[PATCH 6/6] rpmsg: glink: Add get_rproc_name device op

2017-12-18 Thread Chris Lew
Add support for clients to query the edge name for the glink device their channel is registered for. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers/rpmsg/qcom_glink_native.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/d

[PATCH 4/6] rpmsg: glink: Expose rpmsg name attr for glink

2017-12-18 Thread Chris Lew
Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b

[PATCH 6/6] rpmsg: glink: Add get_rproc_name device op

2017-12-18 Thread Chris Lew
Add support for clients to query the edge name for the glink device their channel is registered for. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c

[PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name

2017-12-18 Thread Chris Lew
Add support for client's to query the edge name their channel is registered for. This is useful for clients who share the same channel identifier across different remote procs. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers/rpmsg/rpmsg_core.c | 21 + d

[PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name

2017-12-18 Thread Chris Lew
Add support for client's to query the edge name their channel is registered for. This is useful for clients who share the same channel identifier across different remote procs. Signed-off-by: Chris Lew --- drivers/rpmsg/rpmsg_core.c | 21 + drivers/rpmsg/rpmsg_internal.h

[PATCH 2/6] rpmsg: glink: Store edge name for glink device

2017-12-18 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew <c...@codeaurora.org> --- drivers/rpmsg/qcom_glink_native.c | 6 ++ 1 file changed, 6 inse

[PATCH 2/6] rpmsg: glink: Store edge name for glink device

2017-12-18 Thread Chris Lew
Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew --- drivers/rpmsg/qcom_glink_native.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers

[PATCH 0/6] Add chrdev and name query support for GLINK

2017-12-18 Thread Chris Lew
- rpmsg_get_rproc_name() for kernel clients. Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store edge name for glink device rpmsg: glink: Add support for rpmsg glink chrdev rpmsg: glink: Expose rpmsg name attr for glink rpmsg: Introduce rpmsg_get_rproc_name

[PATCH 0/6] Add chrdev and name query support for GLINK

2017-12-18 Thread Chris Lew
- rpmsg_get_rproc_name() for kernel clients. Chris Lew (6): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg: glink: Store edge name for glink device rpmsg: glink: Add support for rpmsg glink chrdev rpmsg: glink: Expose rpmsg name attr for glink rpmsg: Introduce rpmsg_get_rproc_name

[PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2017-12-18 Thread Chris Lew
Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew <c...@codeaurora.org> --- Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.

[PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings

2017-12-18 Thread Chris Lew
Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew --- Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree

Re: [PATCH v4 4/5] remoteproc: qcom: Introduce sysmon

2017-11-30 Thread Chris Lew
-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> Looked into who is listening to the other notifications besides BEFORE_SHUTDOWN and I think subsequent patches will need to add support for at least AFTER_POWERUP. -- Qualcomm Innovation

Re: [PATCH v4 4/5] remoteproc: qcom: Introduce sysmon

2017-11-30 Thread Chris Lew
-by: Bjorn Andersson --- Acked-By: Chris Lew Looked into who is listening to the other notifications besides BEFORE_SHUTDOWN and I think subsequent patches will need to add support for at least AFTER_POWERUP. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation

Re: [PATCH v4 5/5] samples: Introduce Qualcomm QMI sample client

2017-11-30 Thread Chris Lew
e the responses from the remote. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v4 5/5] samples: Introduce Qualcomm QMI sample client

2017-11-30 Thread Chris Lew
e the responses from the remote. Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

2017-11-30 Thread Chris Lew
this information to the subdev remove functions. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v4 3/5] remoteproc: Pass type of shutdown to subdev remove

2017-11-30 Thread Chris Lew
this information to the subdev remove functions. Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Chris Lew
, reducing most of the duplication in such cases. Tested-By: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aur

Re: [PATCH v4 2/5] soc: qcom: Introduce QMI helpers

2017-11-30 Thread Chris Lew
, reducing most of the duplication in such cases. Tested-By: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-30 Thread Chris Lew
and the debug-logging part was omitted, for now. Tested-By: Chris Lew <c...@codeaurora.org> Tested-By: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Acked-By: Chris Lew <c...@codeaurora.org> -- Qualcom

Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-30 Thread Chris Lew
and the debug-logging part was omitted, for now. Tested-By: Chris Lew Tested-By: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-17 Thread Chris Lew
On 11/15/2017 12:10 PM, Bjorn Andersson wrote: [..]> +static void qmi_handle_message(struct qmi_handle *qmi, + struct sockaddr_qrtr *sq, + const void *buf, size_t len) +{ + const struct qmi_header *hdr; + struct qmi_txn

Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-17 Thread Chris Lew
On 11/15/2017 12:10 PM, Bjorn Andersson wrote: [..]> +static void qmi_handle_message(struct qmi_handle *qmi, + struct sockaddr_qrtr *sq, + const void *buf, size_t len) +{ + const struct qmi_header *hdr; + struct qmi_txn

Re: [PATCH v3 4/5] remoteproc: qcom: Introduce sysmon

2017-11-17 Thread Chris Lew
On 11/16/2017 9:58 PM, Bjorn Andersson wrote: On Thu 16 Nov 12:05 PST 2017, Chris Lew wrote: + req.event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN; Are there plans to add the other SSR events to sysmon notifiers? I think the SSCTL service expects to receive events about remote procs starting

Re: [PATCH v3 4/5] remoteproc: qcom: Introduce sysmon

2017-11-17 Thread Chris Lew
On 11/16/2017 9:58 PM, Bjorn Andersson wrote: On Thu 16 Nov 12:05 PST 2017, Chris Lew wrote: + req.event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN; Are there plans to add the other SSR events to sysmon notifiers? I think the SSCTL service expects to receive events about remote procs starting

Re: [PATCH v3 4/5] remoteproc: qcom: Introduce sysmon

2017-11-16 Thread Chris Lew
Hi Bjorn, Question about the SSR events for sysmon. Thanks, Chris On 11/15/2017 12:10 PM, Bjorn Andersson wrote: [..] +/** + * ssctl_send_event() - send notification of other remote's SSR event + * @sysmon:sysmon context + * @name: other remote's name + */ +static void

Re: [PATCH v3 4/5] remoteproc: qcom: Introduce sysmon

2017-11-16 Thread Chris Lew
Hi Bjorn, Question about the SSR events for sysmon. Thanks, Chris On 11/15/2017 12:10 PM, Bjorn Andersson wrote: [..] +/** + * ssctl_send_event() - send notification of other remote's SSR event + * @sysmon:sysmon context + * @name: other remote's name + */ +static void

Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-16 Thread Chris Lew
dr) + *len, GFP_KERNEL); + if (!msg) + return ERR_PTR(-ENOMEM); + + msglen = qmi_encode(ei, msg + sizeof(*hdr), c_struct, *len, 1); + if (msglen < 0) { + kfree(msg); + return ERR_PTR(msglen); + } Talked to Chris Lew about this earlier toda

Re: [PATCH v3 1/5] soc: qcom: Introduce QMI encoder/decoder

2017-11-16 Thread Chris Lew
dr) + *len, GFP_KERNEL); + if (!msg) + return ERR_PTR(-ENOMEM); + + msglen = qmi_encode(ei, msg + sizeof(*hdr), c_struct, *len, 1); + if (msglen < 0) { + kfree(msg); + return ERR_PTR(msglen); + } Talked to Chris Lew about this earlier toda

Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-08 Thread Chris Lew
Hi Bjorn, Found a minor typo. On 11/6/2017 9:20 PM, Bjorn Andersson wrote: [..] +ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq, + int msg_id, size_t len, struct qmi_elem_info *ei, + const void *c_struct) +{ +

Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-08 Thread Chris Lew
Hi Bjorn, Found a minor typo. On 11/6/2017 9:20 PM, Bjorn Andersson wrote: [..] +ssize_t qmi_send_indication(struct qmi_handle *qmi, struct sockaddr_qrtr *sq, + int msg_id, size_t len, struct qmi_elem_info *ei, + const void *c_struct) +{ +

  1   2   >