Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick <ch...@rorvick.com> I think the debug output looks as expe

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick I think the debug output looks as expected, see below for the first

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Wed, Oct 12, 2016 at 1:05 PM, Paul Bolle <pebo...@tiscali.nl> wrote: > On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: >> This may already be apparent, but Dell sells two versions of the 9350: >> one with the Broadcom adapter and one with the AC 8260. > > Off

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Wed, Oct 12, 2016 at 1:05 PM, Paul Bolle wrote: > On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: >> This may already be apparent, but Dell sells two versions of the 9350: >> one with the Broadcom adapter and one with the AC 8260. > > Off topic, for mos

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Luca, FYI, It seems that Google does not like your email as I'm not receiving any of your messages in gmail. Some responses below: On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Hi Chris, > On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > > On Tue, Oct 11, 201

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Luca, FYI, It seems that Google does not like your email as I'm not receiving any of your messages in gmail. Some responses below: On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote: > Hi Chris, > On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > > On Tue, Oct 11, 201

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > For what it's worth, on my machine I have twenty (!) SPLX entries, all > reading: > Name (SPLX, Package (0x04) > { > Zero, > Package (0x03) > { > 0x8000, >

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > For what it's worth, on my machine I have twenty (!) SPLX entries, all > reading: > Name (SPLX, Package (0x04) > { > Zero, > Package (0x03) > { > 0x8000, > 0x8000, >

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Tue, Oct 11, 2016 at 9:09 AM, Chris Rorvick <ch...@rorvick.com> wrote: > I didn't receive your email so I'll try to respond via Paul's. >>> If this is really bothering you, I guess I could apply this patch for >>> now. But as I said, this is not solving the actual

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

On Tue, Oct 11, 2016 at 9:09 AM, Chris Rorvick wrote: > I didn't receive your email so I'll try to respond via Paul's. >>> If this is really bothering you, I guess I could apply this patch for >>> now. But as I said, this is not solving the actual problem. >> >&g

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Luca, I didn't receive your email so I'll try to respond via Paul's. On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: >> This is not coming from the NIC itself, but from the platform's ACPI >> tables. Can you tell us which platform you are using? Interesting. I'm

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

Hi Luca, I didn't receive your email so I'll try to respond via Paul's. On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: >> This is not coming from the NIC itself, but from the platform's ACPI >> tables. Can you tell us which platform you are using? Interesting. I'm running a Dell XPS 13

[PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

eing fully functional after initialization, the above condition is reported as an error. Knock the message down to a warning and provide better context for understanding its consequence. Signed-off-by: Chris Rorvick <ch...@rorvick.com> --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +- 1

[PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

eing fully functional after initialization, the above condition is reported as an error. Knock the message down to a warning and provide better context for understanding its consequence. Signed-off-by: Chris Rorvick --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] un-improve strrchr()

[ resending w/o HTML formatting ] On Sun, Jun 28, 2015 at 11:44 AM, Alexey Dobriyan wrote: > Previous code did 1 branch per character + 1 branch for every character > in the last path component. Current code does 2 branches per characher > regardless. Shouldn't that be "+ 2 branches for every

Re: [PATCH] un-improve strrchr()

[ resending w/o HTML formatting ] On Sun, Jun 28, 2015 at 11:44 AM, Alexey Dobriyan adobri...@gmail.com wrote: Previous code did 1 branch per character + 1 branch for every character in the last path component. Current code does 2 branches per characher regardless. Shouldn't that be + 2

Re: [PATCH] fib_trie: Add proc entry for next-hop exceptions

On Tue, Feb 24, 2015 at 11:33 PM, David Miller wrote: > From: Chris Rorvick > Date: Tue, 24 Feb 2015 23:27:12 -0600 > >> Exceptions are added to the FIB in response to ICMP redirects and to >> account for PMTU, but there is little visibility into what the current >>

[PATCH] fib_trie: Add proc entry for next-hop exceptions

Exceptions are added to the FIB in response to ICMP redirects and to account for PMTU, but there is little visibility into what the current exceptions are. Add a proc entry for listing the current next-hop exceptions Signed-off-by: Chris Rorvick --- I wrote this patch while looking into some

Re: [PATCH] fib_trie: Add proc entry for next-hop exceptions

On Tue, Feb 24, 2015 at 11:33 PM, David Miller da...@davemloft.net wrote: From: Chris Rorvick ch...@rorvick.com Date: Tue, 24 Feb 2015 23:27:12 -0600 Exceptions are added to the FIB in response to ICMP redirects and to account for PMTU, but there is little visibility into what the current

[PATCH] fib_trie: Add proc entry for next-hop exceptions

Exceptions are added to the FIB in response to ICMP redirects and to account for PMTU, but there is little visibility into what the current exceptions are. Add a proc entry for listing the current next-hop exceptions Signed-off-by: Chris Rorvick ch...@rorvick.com --- I wrote this patch while

[BUG] b893e80e3147 breaks touchpad on Dell XPS13

Hi, Commit b893e80e3147 ("ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C") is causing my touchpad to not load on my Dell XPS13. I do not see any errors in the Xorg log, just 20 or so lines missing where it would normally be loading the synaptics driver. Reverting this

[BUG] b893e80e3147 breaks touchpad on Dell XPS13

Hi, Commit b893e80e3147 (ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C) is causing my touchpad to not load on my Dell XPS13. I do not see any errors in the Xorg log, just 20 or so lines missing where it would normally be loading the synaptics driver. Reverting this

[PATCH v2] ALSA: line6: Improve line6_read/write_data() interfaces

The address cannot be negative so make it unsigned. Also, an unsigned int is always sufficient for the length, so no need to overdo it with a size_t. Finally, add in range checks to see if the values passed in actually fit where they are used. Signed-off-by: Chris Rorvick --- This was dropped

Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai wrote: > At Tue, 10 Feb 2015 23:03:12 -0600, > Chris Rorvick wrote: >> >> Use explicit types to reflect the range of valid values. > > Well, this isn't necessarily to be changed at these places. If we > want to be safer, t

[PATCH v2] ALSA: line6: Improve line6_read/write_data() interfaces

The address cannot be negative so make it unsigned. Also, an unsigned int is always sufficient for the length, so no need to overdo it with a size_t. Finally, add in range checks to see if the values passed in actually fit where they are used. Signed-off-by: Chris Rorvick ch...@rorvick.com

Re: [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai ti...@suse.de wrote: At Tue, 10 Feb 2015 23:03:12 -0600, Chris Rorvick wrote: Use explicit types to reflect the range of valid values. Well, this isn't necessarily to be changed at these places. If we want to be safer, there should be proper

[PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

Use explicit types to reflect the range of valid values. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 10 +- sound/usb/line6/driver.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index

[PATCH 4/6] ALSA: line6: Return EIO if read/write not successful

Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index 2a33f3e..f8e2eb0 100644 --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -349,7 +349,7

[PATCH 0/6] Cleanup reads/writes to Line 6 device memory

with the possible exception of changing the returned error from EINVAL to EIO. The EINVAL seems wrong to me but maybe not? Regards, Chris Chris Rorvick (6): ALSA: line6: Improve line6_read/write_data() interfaces ALSA: line6: Add delay before reading status ALSA: line6: Return error if device

[PATCH 2/6] ALSA: line6: Add delay before reading status

a two millisecond delay before each attempt. This is approximately the behavior observed with version 4.2.7.1 of the Windows driver. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6

[PATCH 5/6] ALSA: line6: Use explicit type for serial number

The serial number (aka ESN) is a 32-bit value. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 2 +- sound/usb/line6/driver.h | 2 +- sound/usb/line6/pod.c | 4 ++-- sound/usb/line6/toneport.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/usb

[PATCH 3/6] ALSA: line6: Return error if device not responding

Put an upper bound on how long we will wait for the device to respond to a read/write request (i.e., 100 milliseconds) and return an error if this is reached. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 29 +++-- 1 file changed, 23 insertions(+), 6

[PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version

The firmware version is a single byte so have the variable type agree. Since the address to this member is passed to the read function, using an int is not even portable. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 3/6] ALSA: line6: Return error if device not responding

Put an upper bound on how long we will wait for the device to respond to a read/write request (i.e., 100 milliseconds) and return an error if this is reached. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 29 +++-- 1 file changed, 23

[PATCH 5/6] ALSA: line6: Use explicit type for serial number

The serial number (aka ESN) is a 32-bit value. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 2 +- sound/usb/line6/driver.h | 2 +- sound/usb/line6/pod.c | 4 ++-- sound/usb/line6/toneport.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff

[PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version

The firmware version is a single byte so have the variable type agree. Since the address to this member is passed to the read function, using an int is not even portable. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/toneport.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/6] Cleanup reads/writes to Line 6 device memory

with the possible exception of changing the returned error from EINVAL to EIO. The EINVAL seems wrong to me but maybe not? Regards, Chris Chris Rorvick (6): ALSA: line6: Improve line6_read/write_data() interfaces ALSA: line6: Add delay before reading status ALSA: line6: Return error if device

[PATCH 2/6] ALSA: line6: Add delay before reading status

a two millisecond delay before each attempt. This is approximately the behavior observed with version 4.2.7.1 of the Windows driver. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/usb/line6/driver.c b/sound

[PATCH 4/6] ALSA: line6: Return EIO if read/write not successful

Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c index 2a33f3e..f8e2eb0 100644 --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c

[PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

Use explicit types to reflect the range of valid values. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 10 +- sound/usb/line6/driver.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/sound/usb/line6/driver.c b/sound/usb/line6

[PATCH v2 1/3] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound

[PATCH v2 2/3] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 19 --- 1 file changed, 12

[PATCH v2 3/3] ALSA: line6: Pass driver name to line6_probe()

Provide a unique name for each driver instead of using "line6usb" for all of them. This will allow for different configurations based on the driver type. Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6/pod.

[PATCH v2 0/3] More Line 6 cleanup

Changes in v2: * return true/false instead of 1/0 * do not include spaces in driver name * drop patch altering struct names (unnecessary) Chris Rorvick (3): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver

Re: [PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

On Fri, Feb 6, 2015 at 11:23 AM, Takashi Iwai wrote: > At Fri, 06 Feb 2015 16:04:42 +0100, Takashi Iwai wrote: >> >> At Fri, 6 Feb 2015 08:51:11 -0600, Chris Rorvick wrote: >> > >> > Provide a descriptive name for each driver instead of calling all of >&

[PATCH v2 1/3] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions

Re: [PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

On Fri, Feb 6, 2015 at 11:23 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 06 Feb 2015 16:04:42 +0100, Takashi Iwai wrote: At Fri, 6 Feb 2015 08:51:11 -0600, Chris Rorvick wrote: Provide a descriptive name for each driver instead of calling all of them line6usb. This needs to be done

[PATCH v2 3/3] ALSA: line6: Pass driver name to line6_probe()

Provide a unique name for each driver instead of using line6usb for all of them. This will allow for different configurations based on the driver type. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6

[PATCH v2 2/3] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/toneport.c | 19 --- 1 file

[PATCH v2 0/3] More Line 6 cleanup

Changes in v2: * return true/false instead of 1/0 * do not include spaces in driver name * drop patch altering struct names (unnecessary) Chris Rorvick (3): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver

Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

On Fri, Feb 6, 2015 at 8:56 AM, Takashi Iwai wrote: > At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote: >> --- a/sound/usb/line6/toneport.c >> +++ b/sound/usb/line6/toneport.c >> @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct >> u

[PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound

[PATCH 2/4] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick --- sound/usb/line6/toneport.c | 19 --- 1 file changed, 12

[PATCH 4/4] ALSA: line6: Remove `usb_' prefix from structs

It is just noise that makes lines longer. Signed-off-by: Chris Rorvick --- sound/usb/line6/capture.c | 2 +- sound/usb/line6/driver.c | 42 +++--- sound/usb/line6/driver.h | 22 ++-- sound/usb/line6/midi.c | 24

[PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

Provide a descriptive name for each driver instead of calling all of them "line6usb". Signed-off-by: Chris Rorvick --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6/pod.c | 2 +- sound/usb/line6/podhd.c| 2 +- sound/usb/line6/tone

[PATCH 0/4] More Line 6 cleanup

. :-) Regards, Chris Chris Rorvick (4): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver name to line6_probe() ALSA: line6: Remove `usb_' prefix from structs sound/usb/line6/capture.c | 2 +- sound/usb

[PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

Add a predicate for testing if the device supports source selection to make the conditional logic around this a bit cleaner. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/toneport.c | 32 1 file changed, 16 insertions(+), 16 deletions

[PATCH 2/4] ALSA: line6: Pass toneport pointer to toneport_has_led()

It is unlikely this function would ever be used in a context without a pointer to a `struct usb_line6_toneport', so grab the device type from it rather than having the caller do it. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/toneport.c | 19 --- 1 file

Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

On Fri, Feb 6, 2015 at 8:56 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote: --- a/sound/usb/line6/toneport.c +++ b/sound/usb/line6/toneport.c @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct usb_line6_toneport *toneport

[PATCH 3/4] ALSA: line6: Pass driver name to line6_probe()

Provide a descriptive name for each driver instead of calling all of them line6usb. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/driver.c | 3 ++- sound/usb/line6/driver.h | 3 +-- sound/usb/line6/pod.c | 2 +- sound/usb/line6/podhd.c| 2 +- sound/usb/line6

[PATCH 4/4] ALSA: line6: Remove `usb_' prefix from structs

It is just noise that makes lines longer. Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/capture.c | 2 +- sound/usb/line6/driver.c | 42 +++--- sound/usb/line6/driver.h | 22 ++-- sound/usb/line6/midi.c | 24

[PATCH 0/4] More Line 6 cleanup

. :-) Regards, Chris Chris Rorvick (4): ALSA: line6: Add toneport_has_source_select() ALSA: line6: Pass toneport pointer to toneport_has_led() ALSA: line6: Pass driver name to line6_probe() ALSA: line6: Remove `usb_' prefix from structs sound/usb/line6/capture.c | 2 +- sound/usb

Re: [PATCH 0/2] Remove unused functions

On Sun, Feb 1, 2015 at 2:37 AM, Takashi Iwai wrote: > At Sun, 1 Feb 2015 01:01:07 -0600, Chris Rorvick wrote: >> >> Found a couple more things to rip out. > > Thanks, applied both (with removals of the declarations in midibuf.h, > too). Oops, thanks for fix

Re: [PATCH 0/2] Remove unused functions

On Sun, Feb 1, 2015 at 2:37 AM, Takashi Iwai ti...@suse.de wrote: At Sun, 1 Feb 2015 01:01:07 -0600, Chris Rorvick wrote: Found a couple more things to rip out. Thanks, applied both (with removals of the declarations in midibuf.h, too). Oops, thanks for fixing up. Regards, Chris

[PATCH 0/2] Remove unused functions

Found a couple more things to rip out. Regards, Chris Chris Rorvick (2): ALSA: line6: Remove unused line6_midibuf_status() ALSA: line6: Remove unused line6_midibuf_skip_message() sound/usb/line6/midibuf.c | 18 -- 1 file changed, 18 deletions(-) -- 2.1.0

[PATCH 2/2] ALSA: line6: Remove unused line6_midibuf_skip_message()

Use of this function ended with commits 3e58c868db1d ("staging: line6: drop midi_mask_receive") and af89d2897a71 ("staging: line6: drop midi_mask_transmit".) Signed-off-by: Chris Rorvick --- sound/usb/line6/midibuf.c | 11 --- 1 file changed, 11 deletions(-) di

[PATCH 1/2] ALSA: line6: Remove unused line6_midibuf_status()

This function has not been used since merging the driver into the kernel (and a good while before that.) Signed-off-by: Chris Rorvick --- sound/usb/line6/midibuf.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/sound/usb/line6/midibuf.c b/sound/usb/line6/midibuf.c index b5c4d79

[PATCH 0/2] Remove unused functions

Found a couple more things to rip out. Regards, Chris Chris Rorvick (2): ALSA: line6: Remove unused line6_midibuf_status() ALSA: line6: Remove unused line6_midibuf_skip_message() sound/usb/line6/midibuf.c | 18 -- 1 file changed, 18 deletions(-) -- 2.1.0

[PATCH 2/2] ALSA: line6: Remove unused line6_midibuf_skip_message()

Use of this function ended with commits 3e58c868db1d (staging: line6: drop midi_mask_receive) and af89d2897a71 (staging: line6: drop midi_mask_transmit.) Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/midibuf.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 1/2] ALSA: line6: Remove unused line6_midibuf_status()

This function has not been used since merging the driver into the kernel (and a good while before that.) Signed-off-by: Chris Rorvick ch...@rorvick.com --- sound/usb/line6/midibuf.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/sound/usb/line6/midibuf.c b/sound/usb/line6/midibuf.c

[PATCH v2] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

is much easier to understand and the resulting function is still viewable within a single screen. Signed-off-by: Chris Rorvick --- As made obvious by the previous version of this patch: compile tested only. Regards, Chris drivers/staging/emxx_udc/emxx_udc.c | 52

Re: [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick wrote: > + > + ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE); > + Damn. I looked this over twice before sending this and still only noticed this stupid typo after sending it. Will send a v2 sho

[PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

is much easier to understand and the resulting function is still viewable within a single screen. Signed-off-by: Chris Rorvick --- drivers/staging/emxx_udc/emxx_udc.c | 52 ++--- 1 file changed, 14 insertions(+), 38 deletions(-) diff --git a/drivers/staging/emxx_udc

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Fri, Jan 30, 2015 at 11:35 AM, Rickard Strandqvist wrote: > 2015-01-30 15:20 GMT+01:00 Dan Carpenter : >> Yes. Please send that as a patch which can be applied. >> >> regards, >> dan carpenter >> > > > Hi > > Okay, I'll do it this weekend. > Or do you do it Chris? I'll send out a patch

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Fri, Jan 30, 2015 at 11:35 AM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-30 15:20 GMT+01:00 Dan Carpenter dan.carpen...@oracle.com: Yes. Please send that as a patch which can be applied. regards, dan carpenter Hi Okay, I'll do it this weekend. Or do

[PATCH v2] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

is much easier to understand and the resulting function is still viewable within a single screen. Signed-off-by: Chris Rorvick ch...@rorvick.com --- As made obvious by the previous version of this patch: compile tested only. Regards, Chris drivers/staging/emxx_udc/emxx_udc.c | 52

[PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

is much easier to understand and the resulting function is still viewable within a single screen. Signed-off-by: Chris Rorvick ch...@rorvick.com --- drivers/staging/emxx_udc/emxx_udc.c | 52 ++--- 1 file changed, 14 insertions(+), 38 deletions(-) diff --git a/drivers

Re: [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()

On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick ch...@rorvick.com wrote: + + ep-ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE); + Damn. I looked this over twice before sending this and still only noticed this stupid typo after sending it. Will send a v2 shortly

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Thu, Jan 29, 2015 at 5:46 PM, Chris Rorvick wrote: > That whole chunk of code looks odd. Why the base 16 conversion when > we already know it's a decimal digit? Seems like this would work > without the hassle of the string conversion: Hmm, or probably even better to do this wher

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist wrote: > The last one was more interesting, se below. > But I can not really see how any error should be handled here? > Proposal to change to: > > if (kstrtol(tempbuf, 16, ) == 0 && num == 0) That whole chunk of code looks odd. Why the

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Thu, Jan 29, 2015 at 5:46 PM, Chris Rorvick ch...@rorvick.com wrote: That whole chunk of code looks odd. Why the base 16 conversion when we already know it's a decimal digit? Seems like this would work without the hassle of the string conversion: Hmm, or probably even better to do

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Thu, Jan 29, 2015 at 3:52 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: The last one was more interesting, se below. But I can not really see how any error should be handled here? Proposal to change to: if (kstrtol(tempbuf, 16, num) == 0 num == 0) That whole

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. Each of these changes adds a warning ... > diff --git a/drivers/staging/emxx_udc/emxx_udc.c >

Re: [PATCH] staging: emxx_udc: emxx_udc: Removed variables that is never used

On Wed, Jan 28, 2015 at 4:42 PM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. Each of these changes adds a warning ... diff --git

Re: [PATCH] tipc: link: Remove unused function

On Sat, Jan 17, 2015 at 10:13 AM, Rickard Strandqvist wrote: > Remove the function tipc_link_get_max_pkt() that is not used anywhere. This is already in the next tree: commit 54fef04ad05f15984082c225fe47ce6af8ea1c5c Author: Ying Xue Date: Fri Jan 9 15:27:03 2015 +0800 tipc: remove

Re: [PATCH] tipc: link: Remove unused function

On Sat, Jan 17, 2015 at 10:13 AM, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function tipc_link_get_max_pkt() that is not used anywhere. This is already in the next tree: commit 54fef04ad05f15984082c225fe47ce6af8ea1c5c Author: Ying Xue ying@windriver.com

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 6:54 AM, Chris Rorvick wrote: > On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: >> On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >>> The descriptor member `bNumEndpoints' is plural. >> >> I am afraid that is not a good

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum wrote: > On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: >> The descriptor member `bNumEndpoints' is plural. > > I am afraid that is not a good idea. The name of a > member of a structure mentioned in the specificati

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 6:54 AM, Chris Rorvick ch...@rorvick.com wrote: On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum oneu...@suse.de wrote: On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name

Re: [PATCH] usb: Fix typo in `struct usb_host_interface' comment

On Thu, Jan 15, 2015 at 5:03 AM, Oliver Neukum oneu...@suse.de wrote: On Wed, 2015-01-14 at 21:52 -0600, Chris Rorvick wrote: The descriptor member `bNumEndpoints' is plural. I am afraid that is not a good idea. The name of a member of a structure mentioned in the specification should appear

[PATCH] usb: Fix typo in `struct usb_host_interface' comment

The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h

[PATCH] usb: Fix typo in `struct usb_host_interface' comment

The descriptor member `bNumEndpoints' is plural. Signed-off-by: Chris Rorvick ch...@rorvick.com --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index f89c24a..4add566 100644 --- a/include/linux/usb.h +++ b

[PATCH v4 2/2] staging: lustre: Track sign separately

the effect of taking the absolute value of the user-provided data. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocf

[PATCH v4 1/2] staging: lustre: Use mult if units not specified

hat it only applies when units are specified. Signed-off-by: Chris Rorvick Reviewed-by: Andreas Dilger --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

. Compile tested only. Chris Rorvick (2): staging: lustre: Use mult if units not specified staging: lustre: Track sign separately drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.1.0 -- To unsubscribe from this

Re: [PATCH 00/25] line6usb cleanup

> At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> I have a TonePort UX2 that I've used for testing, meaning that some of >> this is really only compile-tested. > > If anyone is responsible for testing with real hardware, I'll happily > revie

Re: [PATCH 00/25] line6usb cleanup

At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: I have a TonePort UX2 that I've used for testing, meaning that some of this is really only compile-tested. If anyone is responsible for testing with real hardware, I'll happily review. To be clear, the TonePort UX2 is real hardware

[PATCH v4 0/2] lprocfs_write_frac_u64_helper cleanup

only. Chris Rorvick (2): staging: lustre: Use mult if units not specified staging: lustre: Track sign separately drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line

[PATCH v4 1/2] staging: lustre: Use mult if units not specified

are specified. Signed-off-by: Chris Rorvick ch...@rorvick.com Reviewed-by: Andreas Dilger andreas.dil...@intel.com --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b

[PATCH v4 2/2] staging: lustre: Track sign separately

the absolute value of the user-provided data. Signed-off-by: Chris Rorvick ch...@rorvick.com Reviewed-by: Andreas Dilger andreas.dil...@intel.com --- drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging

  1   2   3   >