Re: [GIT PULL] Btrfs part two

2014-04-11 Thread Chris Samuel
rs, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC signature.asc Description: This is a digitally signed message part.

Re: [GIT PULL] Btrfs part two

2014-04-11 Thread Chris Samuel
-- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC signature.asc Description: This is a digitally signed message part.

Re: [GIT PULL] Btrfs

2014-02-02 Thread Chris Samuel
e bug for me (with a different config than my usual to trigger the bug) at v3.13-11307-g5cb480f. Much obliged! Tested-by: Chris Samuel All the best, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC This email may come with a PGP signature as a file. Do not panic. For more in

Re: [GIT PULL] Btrfs

2014-02-02 Thread Chris Samuel
(with a different config than my usual to trigger the bug) at v3.13-11307-g5cb480f. Much obliged! Tested-by: Chris Samuel ch...@csamuel.org All the best, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC This email may come with a PGP signature as a file. Do not panic. For more info see

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-21 Thread Chris Samuel
ks fine, modulo the lack of mod->name as Stephen mentioned. cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH] MODSIGN: Warn when module signature checking fails

2013-01-21 Thread Chris Samuel
of mod-name as Stephen mentioned. cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] MODSIGN: Warn when module signature checking fails

2013-01-16 Thread Chris Samuel
/* Please CC me, I'm not on LKML */ * Reworked from the original patch based on feedback from Josh Boyer * (putting the code in load_module()) and Rusty Russel (use * KERN_NOTICE). Extended to cover the other failure modes. Currently if a signature check fails on module load for any reason no

[PATCH] MODSIGN: Warn when module signature checking fails

2013-01-16 Thread Chris Samuel
/* Please CC me, I'm not on LKML */ * Reworked from the original patch based on feedback from Josh Boyer * (putting the code in load_module()) and Rusty Russel (use * KERN_NOTICE). Extended to cover the other failure modes. Currently if a signature check fails on module load for any reason no

Re: [RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set

2013-01-15 Thread Chris Samuel
/* Please CC, not on LKML */ On 15/01/13 07:36, Chris Samuel wrote: > So we set mod_strip_cmd to be true to prevent it stripping kernel > modules, just as happens if INSTALL_MOD_STRIP is not passed. Ignore this patch, sorry for the noise. I'd tested by comparing the modules pr

Re: [RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set

2013-01-15 Thread Chris Samuel
/* Please CC, not on LKML */ On 15/01/13 07:36, Chris Samuel wrote: So we set mod_strip_cmd to be true to prevent it stripping kernel modules, just as happens if INSTALL_MOD_STRIP is not passed. Ignore this patch, sorry for the noise. I'd tested by comparing the modules produced by the build

[RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set

2013-01-14 Thread Chris Samuel
/* Please CC as I am not on LKML */ Allowing the build system to strip modules when CONFIG_MODULE_SIG is set makes no sense as the modules will fail signature checks and at best taint the kernel (and appear as if force loaded), and at worst cause a kernel panic if fips_enabled is set. So we set

[RFC] [PATCH] Disable INSTALL_MOD_STRIP when CONFIG_MODULE_SIG set

2013-01-14 Thread Chris Samuel
/* Please CC as I am not on LKML */ Allowing the build system to strip modules when CONFIG_MODULE_SIG is set makes no sense as the modules will fail signature checks and at best taint the kernel (and appear as if force loaded), and at worst cause a kernel panic if fips_enabled is set. So we set

Re: MODSIGN: Modules fail signature verification with -ENOKEY

2013-01-12 Thread Chris Samuel
/* Please CC, not on LKML */ On 13/01/13 00:08, Josh Boyer wrote: On Sat, Jan 12, 2013 at 1:28 AM, Chris Samuel wrote: > >> [...Debian kernel-build...] I'll file a bug against it asking for the it to not strip if CONFIG_MODULE_SIG is set. Thanks for the pointer! Great. Glad yo

Re: MODSIGN: Modules fail signature verification with -ENOKEY

2013-01-12 Thread Chris Samuel
/* Please CC, not on LKML */ On 13/01/13 00:08, Josh Boyer wrote: On Sat, Jan 12, 2013 at 1:28 AM, Chris Samuel ch...@csamuel.org wrote: [...Debian kernel-build...] I'll file a bug against it asking for the it to not strip if CONFIG_MODULE_SIG is set. Thanks for the pointer! Great

Re: [PATCH] MODSIGN: Warn when sign check fails due to -ENOKEY

2013-01-11 Thread Chris Samuel
On 12/01/13 00:49, Josh Boyer wrote: On Fri, Jan 11, 2013 at 4:44 AM, Chris Samuel wrote: > /* Please CC me in responses, I am not subscribed to LKML */ diff --git a/kernel/module.c b/kernel/module.c index 250092c..27de534 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -244

Re: MODSIGN: Modules fail signature verification with -ENOKEY

2013-01-11 Thread Chris Samuel
tp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=517290 I'll file a bug against it asking for the it to not strip if CONFIG_MODULE_SIG is set. Thanks for the pointer! Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line "

[PATCH] MODSIGN: Warn when sign check fails due to -ENOKEY

2013-01-11 Thread Chris Samuel
/* Please CC me in responses, I am not subscribed to LKML */ Currently if a signature check fails on module load due to not having the appropriate key (-ENOKEY) and we are not doing strict checking there is no information provided to the user other than the lock debug taint warning: Disabling

[PATCH] MODSIGN: Warn when sign check fails due to -ENOKEY

2013-01-11 Thread Chris Samuel
/* Please CC me in responses, I am not subscribed to LKML */ Currently if a signature check fails on module load due to not having the appropriate key (-ENOKEY) and we are not doing strict checking there is no information provided to the user other than the lock debug taint warning: Disabling

Re: MODSIGN: Modules fail signature verification with -ENOKEY

2013-01-11 Thread Chris Samuel
://bugs.debian.org/cgi-bin/bugreport.cgi?bug=517290 I'll file a bug against it asking for the it to not strip if CONFIG_MODULE_SIG is set. Thanks for the pointer! Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] MODSIGN: Warn when sign check fails due to -ENOKEY

2013-01-11 Thread Chris Samuel
On 12/01/13 00:49, Josh Boyer wrote: On Fri, Jan 11, 2013 at 4:44 AM, Chris Samuel ch...@csamuel.org wrote: /* Please CC me in responses, I am not subscribed to LKML */ diff --git a/kernel/module.c b/kernel/module.c index 250092c..27de534 100644 --- a/kernel/module.c +++ b/kernel/module.c

Re: [GIT PULL 1/2] Btrfs fixes

2012-08-20 Thread Chris Samuel
se instead. All the best, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [GIT PULL 1/2] Btrfs fixes

2012-08-20 Thread Chris Samuel
. [...] This pull request with a whole heap of btrfs fixes (46 commits) appears not to have been merged yet, does anyone know if it was rejected or just missed ? cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line "u

Re: [GIT PULL 1/2] Btrfs fixes

2012-08-20 Thread Chris Samuel
request with a whole heap of btrfs fixes (46 commits) appears not to have been merged yet, does anyone know if it was rejected or just missed ? cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [GIT PULL 1/2] Btrfs fixes

2012-08-20 Thread Chris Samuel
-- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org