adjtimex broken in 3.12.37 - 3.12.39

2015-04-02 Thread Christian Riesch
Hello Jiri, Commit f09c62a1c27dcc43a06e5ebb27ae67306146277b ("time: adjtimex: Validate the ADJ_FREQUENCY values", appeared first in 3.12.37, upstream is 5e5aeb4367b450a28f447f6d5ab57d8f2ab16a5f) breaks the adjtimex call on 32 bit systems. This was fixed upstream by commit 29183a70b0b828500816bd794

Re: [PATCH] pps: Add support for read operations and return a useful value in poll

2015-04-01 Thread Christian Riesch
[sent again with Rodolfo in the list of recipients, something went wrong, sorry!] Hi Rodolfo, Thanks for your reply! On Wed, Apr 1, 2015 at 10:11 AM, Rodolfo Giometti wrote: > On Tue, Mar 31, 2015 at 11:31:22PM +0200, Christian Riesch wrote: >> The PPS_FETCH ioctl in drivers/pps/pps

Re: [PATCH] pps: Add support for read operations and return a useful value in poll

2015-04-01 Thread Christian Riesch
Hi Rodolfo, Thanks for your reply! On Wed, Apr 1, 2015 at 10:11 AM, Rodolfo Giometti wrote: > On Tue, Mar 31, 2015 at 11:31:22PM +0200, Christian Riesch wrote: >> The PPS_FETCH ioctl in drivers/pps/pps.c blocks until a new PPS event >> occurs, then returns the time stamp data

[PATCH] pps: Add support for read operations and return a useful value in poll

2015-03-31 Thread Christian Riesch
read operations. Furthermore pps_cdev_poll is modified to return POLLIN | POLLRDNORM only when new PPS data is available. Signed-off-by: Christian Riesch --- drivers/pps/pps.c | 32 +++- include/linux/pps_kernel.h |1 + 2 files changed, 32 insertions

Re: [PATCH] n_tty: Fix unordered accesses to lockless read buffer

2015-01-01 Thread Christian Riesch
On Thu, Jan 1, 2015 at 12:00 PM, Christian Riesch >> @@ -164,15 +160,17 @@ static inline int tty_put_user(struct tty_struct *tty, unsigned char x, >> static int receive_room(struct tty_struct *tty) >> { >> struct n_tty_data *ldata = tty->disc_data; >>

Re: [PATCH] n_tty: Fix unordered accesses to lockless read buffer

2015-01-01 Thread Christian Riesch
the producer-side > and canon_head/commit_head from the consumer-side, or both in shared > paths such as receive_room(). > > Based on work by Christian Riesch > > NB: Exclusive access is still guaranteed with termios_rwsem write > lock, eg. by n_tty_set_termios() and in n_tty_ioctl(

Re: [RFC PATCH] n_tty: Add memory barriers where required for lock-less circular buffer

2014-11-17 Thread Christian Riesch
On Mon, Nov 17, 2014 at 1:27 PM, Christian Riesch wrote: > Signed-off-by: Christian Riesch > Cc: Peter Hurley [...] > [2] https://lkml.org/lkml/2014/11/11/77 Uupps, [2] should point to https://lkml.org/lkml/2014/11/13/1 instead. v3 instead of v2. Sorry. > > drivers/tty

[RFC PATCH] n_tty: Add memory barriers where required for lock-less circular buffer

2014-11-17 Thread Christian Riesch
Signed-off-by: Christian Riesch Cc: Peter Hurley --- Hi all, This patch adds memory barriers to the lock-less circular buffer in the n_tty driver to fix the race condition described in [1] and [2] for SMP machines. The patch is based on the instructions in Documentation/circular-buffers.txt

[PATCH v3] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-12 Thread Christian Riesch
nt read_head _after_ the data is placed in the buffer and thus fixes the race for non-SMP machines. To fix the problem for SMP machines, memory barriers must be added in a separate patch. Signed-off-by: Christian Riesch Cc: --- Changes for v3: - Removed unnecessary comment. Changes for v2: - Re

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-12 Thread Christian Riesch
On Wed, Nov 12, 2014 at 12:53 PM, Måns Rullgård wrote: > Christian Riesch writes: > >> On Tue, Nov 11, 2014 at 2:04 PM, Måns Rullgård wrote: >>> Christian Riesch writes: >> [...]>> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c >>>> index 2

Re: [PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-11 Thread Christian Riesch
On Tue, Nov 11, 2014 at 2:04 PM, Måns Rullgård wrote: > Christian Riesch writes: [...]>> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c >> index 2e900a9..b09f326 100644 >> --- a/drivers/tty/n_tty.c >> +++ b/drivers/tty/n_tty.c >> @@ -321,7 +321,9 @@ s

[PATCH v2] n_tty: Fix read_buf race condition, increment read_head after pushing data

2014-11-10 Thread Christian Riesch
nt read_head _after_ the data is placed in the buffer and thus fixes the race for non-SMP machines. To fix the problem for SMP machines, memory barriers must be added in a separate patch. Signed-off-by: Christian Riesch Cc: --- This is version 2 of the patch in [1]. Changes for v2: - Rewrote com

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-10 Thread Christian Riesch
Hi Måns, On Mon, Nov 10, 2014 at 10:25 AM, Måns Rullgård wrote: > Christian Riesch writes: > >> On Thu, Nov 6, 2014 at 9:56 PM, Greg Kroah-Hartman >> wrote: >>> On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >>>> Greg Kroah-Hartman writ

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-09 Thread Christian Riesch
On Thu, Nov 6, 2014 at 9:56 PM, Greg Kroah-Hartman wrote: > On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 12:39:59PM +0100, Christian Riesch wrote: >> >> The current implementat

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Christian Riesch
>> >> >>> >> >> > On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >>> >> >> >> Greg Kroah-Hartman writes: >>> >> >> >> >>> >> >> >> > On Thu, Nov 06, 2014 at 12:39:59PM +0

Re: [PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Christian Riesch
On Thu, Nov 6, 2014 at 9:56 PM, Greg Kroah-Hartman wrote: > On Thu, Nov 06, 2014 at 08:49:01PM +, Måns Rullgård wrote: >> Greg Kroah-Hartman writes: >> >> > On Thu, Nov 06, 2014 at 12:39:59PM +0100, Christian Riesch wrote: >> >> The current implementat

[PATCH] n_tty: Add memory barrier to fix race condition in receive path

2014-11-06 Thread Christian Riesch
ty: Make N_TTY ldisc receive path lockless"). This patch adds memory barriers to resolve this race condition. Signed-off-by: Christian Riesch Cc: Peter Hurley Cc: --- Hi all, I noticed that since an upgrade to kernel 3.12 my ARM device communicating via serial port with a GPS receiver modu

Re: [PATCH 1/1] mtd: cfi_cmdset_0002:add fixup for Micron M29EW after erase operation

2014-09-01 Thread Christian Riesch
On Mon, Sep 1, 2014 at 4:20 AM, bpqw wrote: > For Micron M29EW,20ms delay is needed after erase operation. > > Signed-off-by: BeanHuo > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c > b/drive

Re: [PATCH 1/1] mtd: cfi_cmdset_0002:add fixup for Micron M29EW after erase operation

2014-09-01 Thread Christian Riesch
On Mon, Sep 1, 2014 at 4:20 AM, bpqw wrote: > For Micron M29EW,20ms delay is needed after erase operation. > > Signed-off-by: BeanHuo > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c > b/drive

Re: [PATCH 1/1] mtd: cfi_cmdset_0002:add fixup for Micron M29EW after erase operation

2014-09-01 Thread Christian Riesch
Hi, On Mon, Sep 1, 2014 at 4:20 AM, bpqw wrote: > For Micron M29EW,20ms delay is needed after erase operation. Is there a datasheet/application note/technical note from Micron describing this issue? Like the TN-13-07 for the other M29EW fixes? Are all M29EW types affected? Thanks, Christian >

Re: USB_MUSB_DA8XX with g_multi.ko

2014-06-25 Thread Christian Riesch
Hi Jon, On Thu, Jun 26, 2014 at 4:46 AM, Jon Ringle wrote: > The only thing I needed to do was to remove the > BROKEN dependency on USB_MUSB_DA8XX. Is there anything else I would > have to do besides just removing BROKEN to get this accepted back into > the kernel source tree? I tried to remove

Re: [PATCH RFC net-next v1 0/9] ptp: dynamic pin control

2014-03-12 Thread Christian Riesch
Hi Richard, --On March 08, 2014 20:42 +0100 Richard Cochran wrote: This patch series introduces a way of changing the auxiliary PTP Hardware Clock functions (periodic output signals and time stamping external signals) at run time. In the past on the netdev list, we have discussed other ways

Re: [PATCH RFC net-next v1 0/9] ptp: dynamic pin control

2014-03-11 Thread Christian Riesch
Hi Richard, --On March 10, 2014 14:42 +0100 Richard Cochran wrote: On Mon, Mar 10, 2014 at 12:52:57PM +, Sørensen, Stefan wrote: What are the n_ext_ts and n_per_out supposed to be set to now? The number of pins configured for the relevant function or the number of channels that are ava

Re: [PATCH RFC net-next v1 1/9] ptp: introduce programmable pins.

2014-03-11 Thread Christian Riesch
Hi Richard, --On March 08, 2014 20:42 +0100 Richard Cochran wrote: This patch adds a pair of new ioctls to the PTP Hardware Clock device interface. Using the ioctls, user space programs can query each pin to find out its current function and also reprogram a different function if desired. S

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-06 Thread Christian Riesch
Hi Brian, --On March 06, 2014 00:49 -0800 Brian Norris wrote: Hi, On Wed, Mar 05, 2014 at 09:50:35AM +0100, Christian Riesch wrote: On March 04, 2014 23:20 -0800 Brian Norris wrote: > On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: >> An OTP write shall writ

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-05 Thread Christian Riesch
Hi Brian, Thank you very much for your comments on the patch! --On March 04, 2014 23:20 -0800 Brian Norris wrote: Hi Christian, A few comments below. On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: An OTP write shall write as much data as possible to the OTP memory and

Re: Fwd: Ethernet controller not starting

2014-03-04 Thread Christian Riesch
Hi Jon, [Now also cc'ed Prabhakar Lad] --On March 04, 2014 07:34 -0500 Jon Ringle wrote: On Tue, Mar 4, 2014 at 4:06 AM, Christian Riesch wrote: [cc'ed netdev and davinci-linux-open-source] --On March 03, 2014 19:39 -0500 Jon Ringle wrote: On Mon, Mar 3, 2014 at 6:43 PM

Re: [PATCH v2 RESEND 0/2] mtd: Harmonize implementations of OTP write and _get_{fact, user}_prot_info

2014-03-04 Thread Christian Riesch
Hi, --On January 28, 2014 09:29 +0100 Christian Riesch wrote: Hi all, In the discussion on my patchset for the OTP support for drivers/mtd/chips/cfi_cmdset_0002.c [1-5], Artem requested two changes in the current code of the OTP write functions and the _get_{fact,user}_prot_info code

Re: Ethernet controller not starting

2014-03-04 Thread Christian Riesch
[cc'ed netdev and davinci-linux-open-source] --On March 03, 2014 19:39 -0500 Jon Ringle wrote: On Mon, Mar 3, 2014 at 6:43 PM, Rafael J. Wysocki wrote: On Monday, March 03, 2014 02:41:01 PM Jon Ringle wrote: I'm working on porting an ARM board from linux-3.10 to linux-3.12 (now the latest L

[PATCH v2 RESEND 1/2] mtd: Add a retlen parameter to _get_{fact,user}_prot_info

2014-01-28 Thread Christian Riesch
Signed-off-by: Christian Riesch Cc: Artem Bityutskiy Cc: Brian Norris --- drivers/mtd/chips/cfi_cmdset_0001.c | 31 +-- drivers/mtd/devices/mtd_dataflash.c |7 --- drivers/mtd/mtdchar.c | 11 ++- drivers/mtd/mtdcore.c

[PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-01-28 Thread Christian Riesch
An OTP write shall write as much data as possible to the OTP memory and return the number of bytes that have actually been written. If no data could be written at all due to lack of OTP memory, return -ENOSPC. Signed-off-by: Christian Riesch Cc: Artem Bityutskiy Cc: Kyungmin Park Cc: Amul

[PATCH v2 RESEND 0/2] mtd: Harmonize implementations of OTP write and _get_{fact,user}_prot_info

2014-01-28 Thread Christian Riesch
://patchwork.ozlabs.org/patch/240009/ [6] http://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html Cc: Artem Bityutskiy Cc: Kyungmin Park Cc: Amul Kumar Saha Cc: Brian Norris Christian Riesch (2): mtd: Add a retlen parameter to _get_{fact,user}_prot_info mtd: Fix the behavior of otp

[PATCH v2 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2013-12-19 Thread Christian Riesch
An OTP write shall write as much data as possible to the OTP memory and return the number of bytes that have actually been written. If no data could be written at all due to lack of OTP memory, return -ENOSPC. Signed-off-by: Christian Riesch Cc: Artem Bityutskiy Cc: Kyungmin Park Cc: Amul

[PATCH v2 0/2] mtd: Harmonize implementations of OTP write and _get_{fact,user}_prot_info

2013-12-19 Thread Christian Riesch
://patchwork.ozlabs.org/patch/240009/ [6] http://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html Cc: Artem Bityutskiy Cc: Kyungmin Park Cc: Amul Kumar Saha Cc: Brian Norris Christian Riesch (2): mtd: Add a retlen parameter to _get_{fact,user}_prot_info mtd: Fix the behavior of otp

[PATCH v2 1/2] mtd: Add a retlen parameter to _get_{fact,user}_prot_info

2013-12-19 Thread Christian Riesch
Signed-off-by: Christian Riesch Cc: Artem Bityutskiy Cc: Brian Norris --- drivers/mtd/chips/cfi_cmdset_0001.c | 31 +-- drivers/mtd/devices/mtd_dataflash.c |7 --- drivers/mtd/mtdchar.c | 11 ++- drivers/mtd/mtdcore.c

Re: [PATCH] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-11 Thread Christian Riesch
Hi, On 2013-01-11 03:45, Ming Lei wrote: Cc netdev and usb lists. On Fri, Jan 11, 2013 at 9:17 AM, wrote: From: Freddy Xin This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0 to gigabit ethernet adapters. It's based on the AX88xxx driver but the usb commands used to access r

Re: linux-next: build failure after merge of the net-next tree

2012-07-19 Thread Christian Riesch
[Sent again due to problems with email client] Hi, On 07/20/2012 04:01 AM, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (powerpc pmac32_defconfig) failed like this: ERROR: "phy_disconnect" [drivers/net/usb/asix.ko] undefined! ERROR: "phy_stop" [dri