Re: [Drbd-dev] [PATCH] drbd: Fix a use after free in get_initial_state

kb_len, skb is not initialized yet. Maybe it makes more sense to not return a length in the first place here, but an error code instead. -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage

Re: [PATCH] crypto: expose needs_key in procfs

On 01.03.21 19:47, Eric Biggers wrote: On Mon, Mar 01, 2021 at 05:59:17PM +0100, Christoph Böhmwalder wrote: Currently, it is not apparent for userspace users which hash algorithms require a key and which don't. We have /proc/crypto, so add a field with this information there. Signed-off

[PATCH] crypto: expose needs_key in procfs

Currently, it is not apparent for userspace users which hash algorithms require a key and which don't. We have /proc/crypto, so add a field with this information there. Signed-off-by: Christoph Böhmwalder --- crypto/shash.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crypto/shash.c

Re: [PATCH] signal: Allow cifs and drbd to receive their terminating signals

ired by similar cifs and drbd patches that > added allow_signal. > > Reported-by: ronnie sahlberg > Reported-by: Christoph Böhmwalder > Cc: Steve French > Cc: Philipp Reisner > Cc: David Laight > Fixes: 247bc9470b1e ("cifs: fix rmmod regression in cifs.ko caused by >

Re: [PATCH] drbd: do not ignore signals in threads

gt; > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 > 1PT, UK > Registration No: 1397386 (Wales) -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage

[PATCH] drbd: do not ignore signals in threads

are now becoming visible. Thus, issue an allow_signal() at the start of the thread to explicitly allow the desired signals. Signed-off-by: Christoph Böhmwalder Signed-off-by: Philipp Reisner Fixes: fee109901f39 ("signal/drbd: Use send_sig not force_sig") Cc: sta...@vger.kernel.org --

Re: [PATCH 2/3] dt-bindings: interrupt-controller: RISC-V local interrupt controller docs

On Fri, Jun 22, 2018 at 04:20:05PM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > This patch adds documentation on the RISC-V local interrupt controller, > which is a per-hart interrupt controller that manages all interrupts > entering a RISC-V hart. This interrupt controller is

Re: [PATCH 2/3] dt-bindings: interrupt-controller: RISC-V local interrupt controller docs

On Fri, Jun 22, 2018 at 04:20:05PM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > This patch adds documentation on the RISC-V local interrupt controller, > which is a per-hart interrupt controller that manages all interrupts > entering a RISC-V hart. This interrupt controller is

Re: [PATCH 3/3] hid: logitech-dj: delete unnecessary error messages

On Thu, Feb 08, 2018 at 08:56:28AM +0100, Marcus Folkesson wrote: > > Thank you, but Markus Elfring already has a submitted a patch for this one. > > /Marcus Ah sorry, I must've missed that one. Feel free to dismiss it then (it's obviously independent of the other two anyways). -- Regards,

Re: [PATCH 3/3] hid: logitech-dj: delete unnecessary error messages

On Thu, Feb 08, 2018 at 08:56:28AM +0100, Marcus Folkesson wrote: > > Thank you, but Markus Elfring already has a submitted a patch for this one. > > /Marcus Ah sorry, I must've missed that one. Feel free to dismiss it then (it's obviously independent of the other two anyways). -- Regards,

[PATCH 2/3] hid: logitech-dj: fix checkpatch issues

Fix some code style issues, mostly related to making sure quoted strings aren't split over multiple lines. Other fixes: * Drop != NULL from some null pointer checks * Use sizeof(*ptr) instead of sizeof(ptr_type) * Combine some if statements to reduce indentation Signed-off-by: Christoph

[PATCH 2/3] hid: logitech-dj: fix checkpatch issues

Fix some code style issues, mostly related to making sure quoted strings aren't split over multiple lines. Other fixes: * Drop != NULL from some null pointer checks * Use sizeof(*ptr) instead of sizeof(ptr_type) * Combine some if statements to reduce indentation Signed-off-by: Christoph

[PATCH 1/3] hid: logitech-dj: fix various style issues

comment style to fit the kernel coding standard Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/hid/hid-logitech-dj.c | 240 ++ 1 file changed, 124 insertions(+), 116 deletions(-) diff --git a/drivers/hid/hid-logitech-

[PATCH 1/3] hid: logitech-dj: fix various style issues

comment style to fit the kernel coding standard Signed-off-by: Christoph Böhmwalder --- drivers/hid/hid-logitech-dj.c | 240 ++ 1 file changed, 124 insertions(+), 116 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c

[PATCH 0/3] hid: logitech-dj: code style improvements

Fix several rather trivial code style issues in the Logitech DJ HID driver. Most of these were reported by checkpatch, others are just attempts to make the code adhere more to the kernel coding guidelines. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> Christoph Böhmwal

[PATCH 0/3] hid: logitech-dj: code style improvements

Fix several rather trivial code style issues in the Logitech DJ HID driver. Most of these were reported by checkpatch, others are just attempts to make the code adhere more to the kernel coding guidelines. Signed-off-by: Christoph Böhmwalder Christoph Böhmwalder (3): hid: logitech-dj: fix

[PATCH 3/3] hid: logitech-dj: delete unnecessary error messages

Remove some "out of memory" messages that are considered useless. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/hid/hid-logitech-dj.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b

[PATCH 3/3] hid: logitech-dj: delete unnecessary error messages

Remove some "out of memory" messages that are considered useless. Signed-off-by: Christoph Böhmwalder --- drivers/hid/hid-logitech-dj.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

On Thu, Dec 07, 2017 at 02:39:14PM +0100, Bartosz Golaszewski wrote: > -#define AT24_DEVICE_MAGIC(_len, _flags) \ > - ((1 << AT24_SIZE_FLAGS | (_flags)) \ > +#define AT24_DEVICE_MAGIC(_len, _flags) \ > + ((1 << AT24_SIZE_FLAGS | (_flags))

Re: [PATCH v3 1/2] eeprom: at24: fix coding style issues

On Thu, Dec 07, 2017 at 02:39:14PM +0100, Bartosz Golaszewski wrote: > -#define AT24_DEVICE_MAGIC(_len, _flags) \ > - ((1 << AT24_SIZE_FLAGS | (_flags)) \ > +#define AT24_DEVICE_MAGIC(_len, _flags) \ > + ((1 << AT24_SIZE_FLAGS | (_flags))

Re: [PATCH 2/3] battery: Add the ThinkPad "Not Charging" quirk

On Wed, Dec 06, 2017 at 11:53:01PM +0100, Ognjen Galic wrote: > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > of "Unknown" when the battery is between the charge start and > charge stop thresholds. On Windows, it reports "Not Charging" > so the quirk has been added to also

Re: [PATCH 2/3] battery: Add the ThinkPad "Not Charging" quirk

On Wed, Dec 06, 2017 at 11:53:01PM +0100, Ognjen Galic wrote: > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > of "Unknown" when the battery is between the charge start and > charge stop thresholds. On Windows, it reports "Not Charging" > so the quirk has been added to also

Re: [PATCH v2] thinkad_acpi: Support the battery wear control

On Sun, Dec 03, 2017 at 11:56:40PM +0100, Ognjen Galic wrote: > Add support for the ACPI batteries on newer thinkpad models > (>Sandy Bridge) that support the setting of start and stop > thresholds. > > The actual interface to the driver is a extension for the > existing ACPI battery driver. This

Re: [PATCH v2] thinkad_acpi: Support the battery wear control

On Sun, Dec 03, 2017 at 11:56:40PM +0100, Ognjen Galic wrote: > Add support for the ACPI batteries on newer thinkpad models > (>Sandy Bridge) that support the setting of start and stop > thresholds. > > The actual interface to the driver is a extension for the > existing ACPI battery driver. This

[PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

nicer. Link: https://lists.freedesktop.org/archives/nouveau/2017-November/029242.html Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drm/nouveau/nvkm/subdev/mmu/uvmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nvkm/subdev/mmu/uvm

[PATCH] drm/nouveau/mmu: fix odd_ptr_err.cocci warnings

nicer. Link: https://lists.freedesktop.org/archives/nouveau/2017-November/029242.html Signed-off-by: Christoph Böhmwalder --- drm/nouveau/nvkm/subdev/mmu/uvmm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drm/nouveau/nvkm/subdev/mmu

[PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

Separate the function from the previous definition with a newline and put the `static` keyword on the same line, as it just looks nicer. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 2/3] wireless: iwlwifi: function definition cosmetic fix

Separate the function from the previous definition with a newline and put the `static` keyword on the same line, as it just looks nicer. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] wireless: iwlwifi: use bool instead of int

Change a usage of int in a boolean context to use the bool type instead, as it makes the intent of the function clearer and helps clarify its semantics. Also eliminate the if/else and just return the boolean result directly, making the code more readable. Signed-off-by: Christoph Böhmwalder

[PATCH 1/3] wireless: iwlwifi: use bool instead of int

Change a usage of int in a boolean context to use the bool type instead, as it makes the intent of the function clearer and helps clarify its semantics. Also eliminate the if/else and just return the boolean result directly, making the code more readable. Signed-off-by: Christoph Böhmwalder

[PATCH 3/3] wireless: iwlwifi: wrap macro into braces

Macros should always be wrapped in braces, so fix this instance. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-i

[PATCH 3/3] wireless: iwlwifi: wrap macro into braces

Macros should always be wrapped in braces, so fix this instance. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-io.c b/drivers/net/wireless/intel

[PATCH 0/3] iwlwifi: cosmetic fixes

associated `static` keyword * One fix wrapping a macro in curly braces Christoph Böhmwalder (3): wireless: iwlwifi: use bool instead of int wireless: iwlwifi: function definition cosmetic fix wireless: iwlwifi: wrap macro into braces drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2

[PATCH 0/3] iwlwifi: cosmetic fixes

associated `static` keyword * One fix wrapping a macro in curly braces Christoph Böhmwalder (3): wireless: iwlwifi: use bool instead of int wireless: iwlwifi: function definition cosmetic fix wireless: iwlwifi: wrap macro into braces drivers/net/wireless/intel/iwlwifi/iwl-io.c | 2

Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

On 26.09.2017 13:27, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Sep 2017 11:01:44 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using

Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

On 26.09.2017 13:27, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Sep 2017 11:01:44 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the Coccinelle software. > > *

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot triv...@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot triv...@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph

[PATCH RESEND] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file chan

[PATCH RESEND] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

Re: [PATCH] [trivial] Fix typos in printk

> if ((stream_fs != 8000) && (stream_fs != 16000)) { > - dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n", > + dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n", I might be mistaken, but shouldn't it be "[...] btmgr *does* not support this

Re: [PATCH] [trivial] Fix typos in printk

> if ((stream_fs != 8000) && (stream_fs != 16000)) { > - dev_err(afe->dev, "%s() btmgr not supprt this stream_fs %d\n", > + dev_err(afe->dev, "%s() btmgr not support this stream_fs %d\n", I might be mistaken, but shouldn't it be "[...] btmgr *does* not support this

[PATCH] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder <christ...@boehmwalder.at> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file chan

[PATCH] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions