Re: [PATCH-next] sched/headers: Clean up

2018-02-16 Thread Christopher Díaz Riveros
dl_bw; > > > + /* dl_runtime / dl_deadline */ > > > + u64 dl_density; > > > > That's a whole lot less readable :/ > > Yep. :( Thank you all for the feedback, I'll consider this patch as NACK. Sorry for wasting time in a low quality patch. I'll prepare a better one next time :) Regards, -- Christopher Díaz Riveros Gentoo Linux Developer GPG Fingerprint: E517 5ECB 8152 98E4 FEBC 2BAA 4DBB D10F 0FDD 2547

Re: [PATCH-next] sched/headers: Clean up

2018-02-15 Thread Christopher Díaz Riveros
atic inline char task_state_to_char(struct > > task_struct *tsk) > > return task_index_to_char(task_state_index(tsk)); > > } > > > > -/** > > +/* > > * is_global_init - check if a task structure is init. Since init > > * is free to have sub-threads we need to check tgid. > > * @tsk: Task structure to be checked. > > @@ -1422,7 +1438,7 @@ extern int yield_to(struct task_struct *p, > > bool preempt); > > extern void set_user_nice(struct task_struct *p, long nice); > > extern int task_prio(const struct task_struct *p); > > > > -/** > > +/* > > * task_nice - return the nice value of a given task. > > * @p: the task in question. > > * > > @@ -1442,7 +1458,7 @@ extern int sched_setattr(struct task_struct > > *, const struct sched_attr *); > > extern int sched_setattr_nocheck(struct task_struct *, const > > struct sched_attr *); > > extern struct task_struct *idle_task(int cpu); > > > > -/** > > +/* > > * is_idle_task - is the specified task an idle task? > > * @p: the task in question. > > * > > > > -- Christopher Díaz Riveros Gentoo Linux Developer GPG Fingerprint: E517 5ECB 8152 98E4 FEBC 2BAA 4DBB D10F 0FDD 2547

Re: [PATCH-next] sched/headers: Clean up

2018-02-15 Thread Christopher Díaz Riveros
+ /* dl_runtime / dl_deadline */ > > + u64 dl_density; > > That's a whole lot less readable :/ Well, while reading the file on a 80 columns width terminal, it breaks lines producing results like: /* Maximum runtime for e ach instance *

[PATCH-next] media: s2255drv: Remove unneeded if else blocks

2018-01-24 Thread Christopher Díaz Riveros
dth possible values can be reduced to LINE_SZ_4CIFS_NTSC or LINE_SZ_1CIFS_NTSC. This patch removes unneeded if else blocks in vidioc_try_fmt_vid_cap function. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/media/usb/s2255/s2255drv.c

[PATCH-next] powerpc/fsl_pci: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- arch/powerpc/sysdev/fsl_pci.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_pci.c b

[PATCH-next] drm/tegra: gem: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/gpu/drm/tegra/gem.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/gem.c b

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/mic/scif

[PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-23 Thread Christopher Díaz Riveros
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/misc/mic/scif/scif_epd.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/mic/scif

Re: [PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
El jue, 18-01-2018 a las 16:31 -0600, Tom Lendacky escribió: > On 1/18/2018 4:09 PM, Randy Dunlap wrote: > > On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote: > > > Fixes the following sparse warning: > > > > > > init/main.c:167:12: warning: > &g

[PATCH-next] init/main.c: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: init/main.c:167:12: warning: symbol 'envp_init' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index a8

[PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: mm/memcontrol.c:1097:14: warning: symbol 'memcg1_stats' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/me

[PATCH-next] MEMCG: memcontrol: make local symbol static

2018-01-18 Thread Christopher Díaz Riveros
Fixes the following sparse warning: mm/memcontrol.c:1097:14: warning: symbol 'memcg1_stats' was not declared. Should it be static? Signed-off-by: Christopher Díaz Riveros --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/me