Re: [PATCH] RFC : mikroBUS driver for add-on boards

2020-07-24 Thread Christopher Friedt
Hi Vaishnav! On Fri, Jul 24, 2020 at 8:06 AM Vaishnav M A wrote: > +enum mikrobus_protocol { > + MIKROBUS_PROTOCOL_SPI = 0x01, > + MIKROBUS_PROTOCOL_I2C = 0x02, > + MIKROBUS_PROTOCOL_UART = 0x03, > + MIKROBUS_PROTOCOL_SPI_GPIOCS = 0x04, > + MIKROBUS_PROTOCOL_I2C_MUX

RFC vmwgfx_fb.c: enable double buffering

2015-01-29 Thread Christopher Friedt
Hi Thomas, Dave, Further to my first patch [1] for the vmware framebuffer driver, I have created a patch that enables double buffering [2]. There is also some code that demonstrates proper working functionality as well [3] and a video that demonstrates proof of concept [4]. I'm actually headed to

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-07-02 Thread Christopher Friedt
At least one source has reported that vmwgfx_fb.c::vmw_fb_check_var() is not even a code path that is traversed when the bug occurs (i.e. inserted unique log message -> never seen in logs). Also, everyone encountering the bug seems to be on a slightly older version of VMWare Player. It does not se

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-07-01 Thread Christopher Friedt
I have been unable to reproduce this issue in a plethora of test cases, although granted, I do not have access to a Win7 machine. For that, I have asked an Ubuntu tester to run through some tests for me. https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-vmware/+bug/1328898/comments/8 W

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 8:49 AM, Christopher Friedt wrote: > That sounds a bit more accurate. Should kms and fbdev be setting both > registers then? I wonder if fbdev can use PITCHLOCK as well, rather than BYTES_PER_LINE. I will only be able to run both kms and fbdev functional tests a

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 8:39 AM, Thomas Hellstrom wrote: > xf86-video-vmware in kms mode uses the kernel driver to set these registers. > FWIW, the modesetting part of the kernel driver uses SVGA_REG_PITCHLOCK > instead of > SVGA_REG_BYTES_PER_LINE to set the pitch. That's probably where the > cla

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-06-30 Thread Christopher Friedt
On Mon, Jun 30, 2014 at 7:48 AM, Thomas Hellstrom wrote: > I don't think we can blame video-vmware for this. A kernel driver change > that breaks existing user-space is by definition a kernel driver bug, > regardless whether exisiting user-space is doing something horrendously > stupid. I wouldn'

Re: [PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-03-27 Thread Christopher Friedt
This is the 2nd time I've posted the patch. Please have a look Dave. Gregkh suggested I resend this a while back after not hearing any feedback. It's a fairly simple patch. Don't forget to look at https://bugs.gentoo.org/show_bug.cgi?id=494794 because that kind of describes it all. -- To unsubsc

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-03-27 Thread Christopher Friedt
Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but it would not adjust the FINFO properly, resulting in distorted screen rendering. The patch corrects that behaviour. See https://bugs.gentoo.org/show_bug.cgi?id=494794 for examples. Signed-off-by: Christopher Friedt

[PATCH 1/1] drm/vmwgfx: correct fb_fix_screeninfo.line_length

2014-02-01 Thread Christopher Friedt
Previously, the vmwgfx_fb driver would allow users to call FBIOSET_VINFO, but it would not adjust the FINFO properly, resulting in distorted screen rendering. The patch corrects that behaviour. See https://bugs.gentoo.org/show_bug.cgi?id=494794 for examples. Signed-off-by: Christopher Friedt