Re: [PATCH] gpio: don't WARN() on NULL descs if gpiolib is disabled

2019-07-10 Thread Claus H. Stovgaard
Hi Linus On tir, 2019-07-09 at 15:30 +0200, Linus Walleij wrote: > > I remember I had this discussion in the past, and I made a large > refactoring to make it possible for drivers that need gpiod_* > calls to simply do: > > select GPIOLIB > > in Kconfig. > > This should solve also this problem

Re: [PATCH] gpio: don't WARN() on NULL descs if gpiolib is disabled

2019-07-08 Thread Claus H. Stovgaard
(1)) and is emitted even if the > passed > descriptor pointer is NULL. > > We don't want to force the users of 'optional' gpio_get to check the > returned pointer before calling e.g. gpiod_set_value() so let's only > WARN on non-NULL descriptors. > > R

Re: [PATCH 3/3] usb: dwc3: gadget: Add support for disabling U1 and U2 entries

2019-05-07 Thread Claus H. Stovgaard
Hi Anurag > > > Please use "-" rather than "_" in the property names. > > I have thought about this feature over the weekend, and think the > > naming should be > > changed to something like "snps,bos-u1-exit-lat-in-us" > > and named the same in the code. And then be the value used by the > > get_

[PATCH] usb: gadget: configfs: Add lpm_Ux_disable

2019-05-07 Thread Claus H. Stovgaard
. Signed-off-by: Claus H. Stovgaard --- drivers/usb/dwc3/ep0.c| 9 ++- drivers/usb/gadget/configfs.c | 56 +++ include/linux/usb/gadget.h| 6 - 3 files changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/ep0.c b/drivers