[PATCH 08/10] nanosleep: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a nanosleep call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross --- kernel/hrtimer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 14be27f

[PATCH 01/10] freezer: shorten freezer sleep time using exponential backoff

2013-04-29 Thread Colin Cross
All tasks can easily be frozen in under 10 ms, switch to using an initial 1 ms sleep followed by exponential backoff until 8 ms. Also convert the printed time to ms instead of centiseconds. Signed-off-by: Colin Cross --- kernel/power/process.c | 23 +-- 1 file changed, 13

[PATCH 05/10] epoll: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in an epoll_wait call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross --- fs/eventpoll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 9fec183..65245e7

[PATCH 09/10] sigtimedwait: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a sigtimedwait call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c index 598dc06

[PATCH 06/10] select: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a select call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross --- fs/select.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/select.c b/fs/select.c index 8c1c96c..6b14dc7 100644

[PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set

2013-04-29 Thread Colin Cross
If a task has called freezer_do_not_count(), don't bother waking it up. If it happens to wake up later it will call freezer_count() and immediately enter the refrigerator. Signed-off-by: Colin Cross --- kernel/cgroup_freezer.c | 5 - kernel/power/process.c | 4 ++-- 2 files changed, 6

[PATCH 00/10] optimize freezing tasks by reducing task wakeups

2013-04-29 Thread Colin Cross
On slow cpus the large number of task wakeups and context switches triggered by freezing and thawing tasks can take a significant amount of cpu time. This patch series reduces the amount of work done during freezing tasks by avoiding waking up tasks that are already in a freezable state. The

[PATCH 03/10] freezer: add new freezable helpers using freezer_do_not_count()

2013-04-29 Thread Colin Cross
(). Additional patches will convert the most common locations that userspace blocks in to use freezable helpers. Signed-off-by: Colin Cross --- include/linux/freezer.h | 72 +++-- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git a/include/linux

[PATCH 03/10] freezer: add new freezable helpers using freezer_do_not_count()

2013-04-29 Thread Colin Cross
(). Additional patches will convert the most common locations that userspace blocks in to use freezable helpers. Signed-off-by: Colin Cross ccr...@android.com --- include/linux/freezer.h | 72 +++-- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git

[PATCH 00/10] optimize freezing tasks by reducing task wakeups

2013-04-29 Thread Colin Cross
On slow cpus the large number of task wakeups and context switches triggered by freezing and thawing tasks can take a significant amount of cpu time. This patch series reduces the amount of work done during freezing tasks by avoiding waking up tasks that are already in a freezable state. The

[PATCH 06/10] select: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a select call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- fs/select.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/select.c b/fs/select.c index 8c1c96c

[PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set

2013-04-29 Thread Colin Cross
If a task has called freezer_do_not_count(), don't bother waking it up. If it happens to wake up later it will call freezer_count() and immediately enter the refrigerator. Signed-off-by: Colin Cross ccr...@android.com --- kernel/cgroup_freezer.c | 5 - kernel/power/process.c | 4 ++-- 2

[PATCH 09/10] sigtimedwait: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a sigtimedwait call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c

[PATCH 05/10] epoll: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in an epoll_wait call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- fs/eventpoll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c

[PATCH 01/10] freezer: shorten freezer sleep time using exponential backoff

2013-04-29 Thread Colin Cross
All tasks can easily be frozen in under 10 ms, switch to using an initial 1 ms sleep followed by exponential backoff until 8 ms. Also convert the printed time to ms instead of centiseconds. Signed-off-by: Colin Cross ccr...@android.com --- kernel/power/process.c | 23 +-- 1

[PATCH 08/10] nanosleep: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a nanosleep call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- kernel/hrtimer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c

[PATCH 10/10] af_unix: use freezable blocking calls in read

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in read call on an AF_UNIX socket during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- net/unix/af_unix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/unix/af_unix.c b

[PATCH 04/10] binder: use freezable blocking calls

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a binder call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- drivers/staging/android/binder.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging

Re: [PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set

2013-04-29 Thread Colin Cross
On Mon, Apr 29, 2013 at 2:57 PM, Tejun Heo t...@kernel.org wrote: On Mon, Apr 29, 2013 at 02:51:57PM -0700, Tejun Heo wrote: I feel a bit weary of changes which try to optimize state checks for freezer because the synchronization rules are kinda fragile and things may not work reliably

[PATCH 07/10] futex: use freezable blocking call

2013-04-29 Thread Colin Cross
Avoid waking up every thread sleeping in a futex_wait call during suspend and resume by calling a freezable blocking call. Signed-off-by: Colin Cross ccr...@android.com --- kernel/futex.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/futex.c b/kernel/futex.c index

Re: [PATCH 07/10] futex: use freezable blocking call

2013-04-29 Thread Colin Cross
On Mon, Apr 29, 2013 at 3:52 PM, Darren Hart dvh...@linux.intel.com wrote: Colin, I don't know anything about when or when not to use freezable*, and I suspect that may be true for others as well. A more complete description of why it's acceptable here in the commit log might help expedite

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-17 Thread Colin Cross
On Wed, Apr 17, 2013 at 2:57 AM, Miklos Szeredi wrote: > On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote: > >> Every other uapi header includes linux/types.h to get its type >> definitions, and fuse.h should do the same when compiling for >> u

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-17 Thread Colin Cross
On Wed, Apr 17, 2013 at 2:57 AM, Miklos Szeredi mik...@szeredi.hu wrote: On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote: Every other uapi header includes linux/types.h to get its type definitions, and fuse.h should do the same when compiling for userspace targeting linux

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 12:11 PM, Miklos Szeredi wrote: > On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross wrote: >> Dropping __linux__ causes a make headers_check warning, which the >> kbuild test robot reported this morning: >> usr/include/linux/fuse.h:99: found __[us]{8,1

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds wrote: >> What I meant is IF is included by userspace (it sure is >> meant to be included and *is* included by libfuse and other stuff) >> THEN using instead of is fine regardless of >> whether __linux__ is defined or not. > > That's probably

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds torva...@linux-foundation.org wrote: What I meant is IF linux/fuse.h is included by userspace (it sure is meant to be included and *is* included by libfuse and other stuff) THEN using stdint.h instead of linux/types.h is fine regardless of

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 12:11 PM, Miklos Szeredi mik...@szeredi.hu wrote: On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross ccr...@android.com wrote: Dropping __linux__ causes a make headers_check warning, which the kbuild test robot reported this morning: usr/include/linux/fuse.h:99: found __[us

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-15 Thread Colin Cross
On Mon, Apr 15, 2013 at 4:59 PM, Rob Herring wrote: > On 04/15/2013 05:21 PM, Colin Cross wrote: >> On Wed, Apr 10, 2013 at 6:30 AM, Rob Herring wrote: >>> On 04/09/2013 10:53 PM, Colin Cross wrote: >>>> On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-15 Thread Colin Cross
On Wed, Apr 10, 2013 at 6:30 AM, Rob Herring wrote: > On 04/09/2013 10:53 PM, Colin Cross wrote: >> On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring wrote: >>> From: Rob Herring >>> >>> Atomic operations are undefined behavior on ARM for device or strongly &g

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-15 Thread Colin Cross
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross wrote: > Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse > header with one used in library) added #ifdef __linux__ around > defines if it is not set. The kernel build is self-contained and > can be built on non-Linu

[PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-15 Thread Colin Cross
will try to include stdint.h and fail due to -nostdinc, and then fail with a bunch of undefined type errors. Change the #ifdef to check for __linux__ or __KERNEL__ so that it uses the kernel typedefs if __KERNEL__ is set. Signed-off-by: Colin Cross --- I think this should go in v3.9, without it bare

[PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-15 Thread Colin Cross
will try to include stdint.h and fail due to -nostdinc, and then fail with a bunch of undefined type errors. Change the #ifdef to check for __linux__ or __KERNEL__ so that it uses the kernel typedefs if __KERNEL__ is set. Signed-off-by: Colin Cross ccr...@android.com --- I think this should go in v3.9

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-15 Thread Colin Cross
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross ccr...@android.com wrote: Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse header with one used in library) added #ifdef __linux__ around defines if it is not set. The kernel build is self-contained and can be built on non-Linux

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-15 Thread Colin Cross
On Wed, Apr 10, 2013 at 6:30 AM, Rob Herring robherri...@gmail.com wrote: On 04/09/2013 10:53 PM, Colin Cross wrote: On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com Atomic operations are undefined behavior on ARM for device

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-15 Thread Colin Cross
On Mon, Apr 15, 2013 at 4:59 PM, Rob Herring robherri...@gmail.com wrote: On 04/15/2013 05:21 PM, Colin Cross wrote: On Wed, Apr 10, 2013 at 6:30 AM, Rob Herring robherri...@gmail.com wrote: On 04/09/2013 10:53 PM, Colin Cross wrote: On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring robherri

Re: [RFC PATCH 3/3] pstore/ram: avoid atomic accesses for ioremapped regions

2013-04-09 Thread Colin Cross
On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring wrote: > From: Rob Herring > > For persistent RAM outside of main memory, the memory may have limitations > on supported accesses. For internal RAM on highbank platform exclusive > accesses are not supported and will hang the system. So atomic_cmpxchg

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-09 Thread Colin Cross
fers. Also, isn't this patch unnecessary after patch 3 in this set? > Signed-off-by: Rob Herring > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: linux-kernel@vger.kernel.org > --- > fs/pstore/ram_core.c |4 ++-- > 1 file changed, 2 inse

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-09 Thread Colin Cross
, in the write buffers. Also, isn't this patch unnecessary after patch 3 in this set? Signed-off-by: Rob Herring rob.herr...@calxeda.com Cc: Anton Vorontsov cbouatmai...@gmail.com Cc: Colin Cross ccr...@android.com Cc: Kees Cook keesc...@chromium.org Cc: Tony Luck tony.l...@intel.com Cc: linux

Re: [RFC PATCH 3/3] pstore/ram: avoid atomic accesses for ioremapped regions

2013-04-09 Thread Colin Cross
On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@calxeda.com For persistent RAM outside of main memory, the memory may have limitations on supported accesses. For internal RAM on highbank platform exclusive accesses are not supported and

Re: [PATCH 1/1] clk: Add notifier support in clk_prepare/clk_unprepare

2013-03-21 Thread Colin Cross
On Thu, Mar 21, 2013 at 3:36 PM, Mike Turquette wrote: > To my knowledge, devfreq performs one task: implements an algorithm > (typically one that loops/polls) and applies this heuristic towards a > dvfs transition. > > It is a policy layer, a high level layer. It should not be used as a >

Re: [PATCH 1/1] clk: Add notifier support in clk_prepare/clk_unprepare

2013-03-21 Thread Colin Cross
On Thu, Mar 21, 2013 at 3:36 PM, Mike Turquette mturque...@linaro.org wrote: To my knowledge, devfreq performs one task: implements an algorithm (typically one that loops/polls) and applies this heuristic towards a dvfs transition. It is a policy layer, a high level layer. It should not be

Re: Fix memory leak in cpufreq stats.

2013-03-11 Thread Colin Cross
On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki wrote: > On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote: >> >> Fix memory leak in cpufreq stats. >> >> When system enter sleep, non-boot CPUs will be disable. >> Cpufreq stats sysfs is created when the CPU is up, but it is not freed

Re: Fix memory leak in cpufreq stats.

2013-03-11 Thread Colin Cross
On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote: Fix memory leak in cpufreq stats. When system enter sleep, non-boot CPUs will be disable. Cpufreq stats sysfs is created when the CPU is up, but it is not freed

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-23 Thread Colin Cross
On Wed, Jan 23, 2013 at 3:06 PM, Tejun Heo wrote: > Hello, Collin. > > On Wed, Jan 23, 2013 at 02:41:46PM -0800, Colin Cross wrote: >> I think some of it is just historic, we previously did not group >> application threads in the scheduler, so it would cause a change in >

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-23 Thread Colin Cross
On Wed, Jan 23, 2013 at 8:56 AM, Tejun Heo wrote: > Hello, Collin. > > On Tue, Jan 22, 2013 at 05:53:59PM -0800, Colin Cross wrote: >> I understand why it makes sense from a code perspective to combine cpu >> and cpuacct, but by combining them you are enforcing a s

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-23 Thread Colin Cross
On Wed, Jan 23, 2013 at 8:56 AM, Tejun Heo t...@kernel.org wrote: Hello, Collin. On Tue, Jan 22, 2013 at 05:53:59PM -0800, Colin Cross wrote: I understand why it makes sense from a code perspective to combine cpu and cpuacct, but by combining them you are enforcing a strange requirement

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-23 Thread Colin Cross
On Wed, Jan 23, 2013 at 3:06 PM, Tejun Heo t...@kernel.org wrote: Hello, Collin. On Wed, Jan 23, 2013 at 02:41:46PM -0800, Colin Cross wrote: I think some of it is just historic, we previously did not group application threads in the scheduler, so it would cause a change in behavior if we

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-22 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:30 PM, Colin Cross wrote: > On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton > wrote: >> On Mon, 14 Jan 2013 16:19:23 -0800 >> Colin Cross wrote: >> >>> >> +static void watchdog_check_hardlockup_other_cpu(void) >&

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-22 Thread Colin Cross
On Tue, Jan 22, 2013 at 5:02 PM, Tejun Heo wrote: > Hello, > > On Mon, Jan 21, 2013 at 04:14:27PM +0400, Glauber Costa wrote: >> > Android userspace is currently using both cpu and cpuacct, and not >> > co-mounting them. They are used for fundamentally different uses such >> > that creating a

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-22 Thread Colin Cross
On Tue, Jan 22, 2013 at 5:02 PM, Tejun Heo t...@kernel.org wrote: Hello, On Mon, Jan 21, 2013 at 04:14:27PM +0400, Glauber Costa wrote: Android userspace is currently using both cpu and cpuacct, and not co-mounting them. They are used for fundamentally different uses such that creating a

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-22 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:30 PM, Colin Cross ccr...@android.com wrote: On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross ccr...@android.com wrote: +static void watchdog_check_hardlockup_other_cpu(void

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-15 Thread Colin Cross
On Wed, Jan 9, 2013 at 3:45 AM, Glauber Costa wrote: > [ update: I thought I posted this already before leaving for holidays. > However, > now that I am checking for replies, I can't find nor replies nor the > original > mail in my boxes or archives. I am posting again for safety sake, but

Re: [PATCH v5 00/11] per-cgroup cpu-stat

2013-01-15 Thread Colin Cross
On Wed, Jan 9, 2013 at 3:45 AM, Glauber Costa glom...@parallels.com wrote: [ update: I thought I posted this already before leaving for holidays. However, now that I am checking for replies, I can't find nor replies nor the original mail in my boxes or archives. I am posting again for

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 6:48 PM, Frederic Weisbecker wrote: > 2013/1/15 Colin Cross : >> On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker >> wrote: >>> 2013/1/15 Colin Cross : >>>> On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker >>>>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker wrote: > 2013/1/15 Colin Cross : >> On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker >> wrote: >>> I believe this is pretty much what the RCU stall detector does >>> already: checks for other CPUs bein

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:19 PM, Colin Cross wrote: > On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton > wrote: >> On Fri, 11 Jan 2013 13:51:48 -0800 >> Colin Cross wrote: >> >>> Emulate NMIs on systems where they are not available by using timer >>> in

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton wrote: > On Mon, 14 Jan 2013 16:19:23 -0800 > Colin Cross wrote: > >> >> +static void watchdog_check_hardlockup_other_cpu(void) >> >> +{ >> >> + unsigned int next_cpu; >> >> + >>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker wrote: > 2013/1/11 Colin Cross : >> Emulate NMIs on systems where they are not available by using timer >> interrupts on other cpus. Each cpu will use its softlockup hrtimer >> to check that the next cpu is processi

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton wrote: > On Fri, 11 Jan 2013 13:51:48 -0800 > Colin Cross wrote: > >> Emulate NMIs on systems where they are not available by using timer >> interrupts on other cpus. Each cpu will use its softlockup hrtimer >>

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross ccr...@android.com wrote: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/11 Colin Cross ccr...@android.com: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 14 Jan 2013 16:19:23 -0800 Colin Cross ccr...@android.com wrote: +static void watchdog_check_hardlockup_other_cpu(void) +{ + unsigned int next_cpu; + + /* + * Test for hardlockups

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:19 PM, Colin Cross ccr...@android.com wrote: On Mon, Jan 14, 2013 at 3:49 PM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 11 Jan 2013 13:51:48 -0800 Colin Cross ccr...@android.com wrote: Emulate NMIs on systems where they are not available by using timer

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic Weisbecker fweis...@gmail.com wrote: I believe this is pretty much what the RCU stall detector does already: checks for other

Re: [PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-14 Thread Colin Cross
On Mon, Jan 14, 2013 at 6:48 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:25 PM, Frederic Weisbecker fweis...@gmail.com wrote: 2013/1/15 Colin Cross ccr...@android.com: On Mon, Jan 14, 2013 at 4:13 PM, Frederic

Re: [RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support

2013-01-11 Thread Colin Cross
On Fri, Jan 11, 2013 at 1:48 PM, John Stultz wrote: > This is a first-pass at implementing compat_ioctl support for > Android's alarm-dev driver in staging. > > The first patch is some refactoring to cleanup and separate the > copying of user data from the logic, and the second patch adds > the

[PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-11 Thread Colin Cross
info. Signed-off-by: Colin Cross --- include/linux/nmi.h |5 ++- kernel/watchdog.c | 123 -- lib/Kconfig.debug | 14 +- 3 files changed, 135 insertions(+), 7 deletions(-) Changes since v1: renamed variables to clarify when referring

[PATCH v2] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-11 Thread Colin Cross
info. Signed-off-by: Colin Cross ccr...@android.com --- include/linux/nmi.h |5 ++- kernel/watchdog.c | 123 -- lib/Kconfig.debug | 14 +- 3 files changed, 135 insertions(+), 7 deletions(-) Changes since v1: renamed variables

Re: [RFC][PATCH 0/2] staging: alarm-dev: compat_ioctl support

2013-01-11 Thread Colin Cross
On Fri, Jan 11, 2013 at 1:48 PM, John Stultz john.stu...@linaro.org wrote: This is a first-pass at implementing compat_ioctl support for Android's alarm-dev driver in staging. The first patch is some refactoring to cleanup and separate the copying of user data from the logic, and the second

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 9:57 PM, Liu, Chuansheng wrote: > > >> -Original Message- >> From: ccr...@google.com [mailto:ccr...@google.com] On Behalf Of Colin >> Cross >> Sent: Friday, January 11, 2013 1:34 PM >> To: Liu, Chuansheng >> Cc: linux-

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 5:39 PM, Liu, Chuansheng wrote: > > >> -Original Message----- >> From: Colin Cross [mailto:ccr...@android.com] >> Sent: Thursday, January 10, 2013 9:58 AM >> To: linux-kernel@vger.kernel.org >> Cc: Andrew Morton; Don Zicku

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 12:38 PM, Tony Lindgren wrote: > > * Colin Cross [130109 18:05]: > > +static void watchdog_check_hardlockup_other_cpu(void) > > +{ > > + int cpu; > > + cpumask_t cpus = watchdog_cpus; > > + > > + /* > &g

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 6:02 AM, Don Zickus wrote: > On Wed, Jan 09, 2013 at 05:57:39PM -0800, Colin Cross wrote: >> Emulate NMIs on systems where they are not available by using timer >> interrupts on other cpus. Each cpu will use its softlockup hrtimer >> to ch

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 6:02 AM, Don Zickus dzic...@redhat.com wrote: On Wed, Jan 09, 2013 at 05:57:39PM -0800, Colin Cross wrote: Emulate NMIs on systems where they are not available by using timer interrupts on other cpus. Each cpu will use its softlockup hrtimer to check that the next cpu

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 12:38 PM, Tony Lindgren t...@atomide.com wrote: * Colin Cross ccr...@android.com [130109 18:05]: +static void watchdog_check_hardlockup_other_cpu(void) +{ + int cpu; + cpumask_t cpus = watchdog_cpus; + + /* + * Test for hardlockups every 3

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 5:39 PM, Liu, Chuansheng chuansheng@intel.com wrote: -Original Message- From: Colin Cross [mailto:ccr...@android.com] Sent: Thursday, January 10, 2013 9:58 AM To: linux-kernel@vger.kernel.org Cc: Andrew Morton; Don Zickus; Ingo Molnar; Thomas Gleixner

Re: [PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-10 Thread Colin Cross
On Thu, Jan 10, 2013 at 9:57 PM, Liu, Chuansheng chuansheng@intel.com wrote: -Original Message- From: ccr...@google.com [mailto:ccr...@google.com] On Behalf Of Colin Cross Sent: Friday, January 11, 2013 1:34 PM To: Liu, Chuansheng Cc: linux-kernel@vger.kernel.org; Andrew Morton

[PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-09 Thread Colin Cross
info. Signed-off-by: Colin Cross --- include/linux/nmi.h |5 ++- kernel/watchdog.c | 98 --- lib/Kconfig.debug | 14 +++- 3 files changed, 110 insertions(+), 7 deletions(-) diff --git a/include/linux/nmi.h b/include/linux/nmi.h index

[PATCH] hardlockup: detect hard lockups without NMIs using secondary cpus

2013-01-09 Thread Colin Cross
info. Signed-off-by: Colin Cross ccr...@android.com --- include/linux/nmi.h |5 ++- kernel/watchdog.c | 98 --- lib/Kconfig.debug | 14 +++- 3 files changed, 110 insertions(+), 7 deletions(-) diff --git a/include/linux/nmi.h b/include

Re: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement

2012-12-14 Thread Colin Cross
t;> instead of bit-OR. This patch fixes that. > > I'm queuing this up for submission as v3.8 material. > > I suppose it should be marked for -stable too? > > Rafael Acked-by: Colin Cross Looks suitable for stable. >> Signed-off-by: Sivaram Nair >> --- >> drivers/cp

Re: [PATCH] cpuidle: coupled: fix the potensial race condition and deadlock

2012-12-14 Thread Colin Cross
On Sun, Dec 2, 2012 at 6:59 PM, Joseph Lo wrote: > Considering the chance that two CPU come into cpuidle_enter_state_coupled at > very close time. The 1st CPU increases the waiting count and the 2nd CPU do > the > same thing right away. The 2nd CPU found the 1st CPU already in waiting then >

Re: [PATCH] cpuidle: coupled: fix the potensial race condition and deadlock

2012-12-14 Thread Colin Cross
On Sun, Dec 2, 2012 at 6:59 PM, Joseph Lo jose...@nvidia.com wrote: Considering the chance that two CPU come into cpuidle_enter_state_coupled at very close time. The 1st CPU increases the waiting count and the 2nd CPU do the same thing right away. The 2nd CPU found the 1st CPU already in

Re: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement

2012-12-14 Thread Colin Cross
-OR. This patch fixes that. I'm queuing this up for submission as v3.8 material. I suppose it should be marked for -stable too? Rafael Acked-by: Colin Cross ccr...@android.com Looks suitable for stable. Signed-off-by: Sivaram Nair sivar...@nvidia.com --- drivers/cpuidle/coupled.c |2 +- 1

[PATCH] Revert "Staging: Android alarm: IOCTL command encoding fix"

2012-11-07 Thread Colin Cross
it. Cc: stable Cc: Dae S. Kim Signed-off-by: Colin Cross --- drivers/staging/android/android_alarm.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/android_alarm.h b/drivers/staging/android/android_alarm.h index f2ffd96..d0cafd6 100644

[PATCH] Revert Staging: Android alarm: IOCTL command encoding fix

2012-11-07 Thread Colin Cross
it. Cc: stable sta...@vger.kernel.org Cc: Dae S. Kim d...@velatum.com Signed-off-by: Colin Cross ccr...@android.com --- drivers/staging/android/android_alarm.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/android_alarm.h b/drivers/staging/android

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-05 Thread Colin Cross
On Mon, Nov 5, 2012 at 12:22 AM, Greg Kroah-Hartman wrote: > On Sat, Nov 03, 2012 at 12:33:07AM -0700, Colin Cross wrote: >> On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman >> wrote: >> > 3.4-stable review patch. If anyone has any object

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-05 Thread Colin Cross
On Mon, Nov 5, 2012 at 12:22 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Nov 03, 2012 at 12:33:07AM -0700, Colin Cross wrote: On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: 3.4-stable review patch. If anyone has any objections

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-04 Thread Colin Cross
On Sun, Nov 4, 2012 at 11:51 PM, Greg Kroah-Hartman wrote: > On Sat, Nov 03, 2012 at 11:17:57PM -0700, Colin Cross wrote: >> On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman >> wrote: >> > 3.4-stable review patch. If anyone has any object

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-04 Thread Colin Cross
On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman wrote: > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Heiko Stuebner > > commit 308b3afb97dc342e9c4f958d8b4c459ae0e22bd7 upstream. > > Commit a5238e360b71 (spi: s3c64xx: move

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-04 Thread Colin Cross
On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: 3.4-stable review patch. If anyone has any objections, please let me know. -- From: Heiko Stuebner he...@sntech.de commit 308b3afb97dc342e9c4f958d8b4c459ae0e22bd7 upstream. Commit

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-04 Thread Colin Cross
On Sun, Nov 4, 2012 at 11:51 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Nov 03, 2012 at 11:17:57PM -0700, Colin Cross wrote: On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: 3.4-stable review patch. If anyone has any objections

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-03 Thread Colin Cross
On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman wrote: > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: "Dae S. Kim" > > commit 6bd4a5d96c08dc2380f8053b1bd4f879f55cd3c9 upstream. > > Fixed a bug. Data was being written to user

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-03 Thread Colin Cross
On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: 3.4-stable review patch. If anyone has any objections, please let me know. -- From: Dae S. Kim d...@velatum.com commit 6bd4a5d96c08dc2380f8053b1bd4f879f55cd3c9 upstream. Fixed a bug.

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-14 Thread Colin Cross
On Thu, Jul 19, 2012 at 2:15 PM, Tejun Heo wrote: > Hello, > > kthread_worker was introduced together with concurrency managed > workqueue to serve workqueue users which need a special dedicated > worker - e.g. RT scheduling. This is minimal queue / flush / flush > all iterface on top of kthread

Re: [PATCH] pinctrl: use kasprintf() in pinmux_request_gpio()

2012-09-14 Thread Colin Cross
On Thu, Sep 13, 2012 at 10:19 PM, Joe Perches wrote: > On Thu, 2012-09-13 at 21:49 +0200, Thomas Petazzoni wrote: >> Instead of using a temporary buffer, snprintf() and kstrdup(), just >> use kasprintf() that does the same thing in just oneline. >> >> Signed-off-by: Thomas Petazzoni >> --- >>

Re: [PATCH] pinctrl: use kasprintf() in pinmux_request_gpio()

2012-09-14 Thread Colin Cross
On Thu, Sep 13, 2012 at 10:19 PM, Joe Perches j...@perches.com wrote: On Thu, 2012-09-13 at 21:49 +0200, Thomas Petazzoni wrote: Instead of using a temporary buffer, snprintf() and kstrdup(), just use kasprintf() that does the same thing in just oneline. Signed-off-by: Thomas Petazzoni

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-14 Thread Colin Cross
On Thu, Jul 19, 2012 at 2:15 PM, Tejun Heo t...@kernel.org wrote: Hello, kthread_worker was introduced together with concurrency managed workqueue to serve workqueue users which need a special dedicated worker - e.g. RT scheduling. This is minimal queue / flush / flush all iterface on top

Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback

2012-09-11 Thread Colin Cross
On Tue, Sep 11, 2012 at 9:06 PM, Anton Vorontsov wrote: > On Tue, Sep 11, 2012 at 08:42:46PM -0700, Colin Cross wrote: > [...] >> > The "problem" is in the last step. If we exit NMI without making UART >> > know that we're done with the interrupt, we will reen

Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback

2012-09-11 Thread Colin Cross
On Tue, Sep 11, 2012 at 8:32 PM, Anton Vorontsov wrote: > On Tue, Sep 11, 2012 at 03:15:40PM +0100, Alan Cox wrote: >> Anton Vorontsov wrote: >> > This patch implements a new callback: clear_irqs. It is used for the >> >> This bit I still really don't like. I would like to know what the generic

Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback

2012-09-11 Thread Colin Cross
On Tue, Sep 11, 2012 at 8:32 PM, Anton Vorontsov anton.voront...@linaro.org wrote: On Tue, Sep 11, 2012 at 03:15:40PM +0100, Alan Cox wrote: Anton Vorontsov anton.voront...@linaro.org wrote: This patch implements a new callback: clear_irqs. It is used for the This bit I still really don't

<    1   2   3   4   5   >