t; The driver looks very good to me though, a few nested comments:
>> >>
>> >> Thanks for the review Mario. I'm afraid I won't have much more time in
>> >> the near future to make changes to this driver. What do you think
>> >> would be the minimal set of changes to make this good enough to be
>> >> merged ?
>> >
>> > I'm just a contributor myself who has recently worked on a WMI driver
>> > series.
>> > I would defer to Andy and Darren to decide what they would like to accept.
>>
>
> Holding off here until Corentin has a chance to respond to my inquiries
> above.
>
>> ...
>>
>> > it would be difficult to update to the
>> > newer model we're working towards when we have the kernel learning how to
>> > parse MOF and programmatically producing sysfs attributes for interacting
>> > with
>> > character devices.
>>
>> ...and since your stuff is scheduled for v4.15 the possibility to
>> (re-)use as much as possible from it is a plus.
>>
>> > Since the kernel has to keep a stable interface to userspace you may run
>> > into a
>> > situation that one day you want to update to the new interfaces and might
>> > have a
>> > difficult time since you have to continue to offer a configuration option
>> > to offer these
>> > old interfaces too.
>>
>> This is a good point.
>
> And one which debugfs helps skirt a bit. If this was done with sysfs and
> merged, we would basically have to create a new thinkpad-wmi-2 driver
> providing the new bus/driver/mof model.
>
> Let's talk about intel and vendor involvement above, and revisit next
> steps after that.
>
> --
> Darren Hart
> VMware Open Source Technology Center
--
Corentin Chary
http://xf.iksaif.net
t is
> exposed by Lenovo's design). I think this is a good thing, and you should
> find a way to programattically expose your attributes to sysfs instead of
> debugfs if possible.
>
> The driver looks very good to me though, a few nested comments:
Thanks for the review Mario. I&#
BIOS/Firmware settings.
Signed-off-by: Corentin Chary
---
.../ABI/testing/sysfs-platform-thinkpad-wmi| 50 +
Documentation/platform/thinkpad-wmi.txt| 92 ++
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile
Yes, I'm just having trouble finding time to write it :)
I'll try to make that happen next week.
On Thu, Oct 5, 2017 at 4:49 AM, Darren Hart wrote:
> On Tue, Sep 05, 2017 at 09:07:27AM +0200, Corentin Chary wrote:
>> [re-send for the mailing list, I forgot that gmail was s
[re-send for the mailing list, I forgot that gmail was stupid]
On Tue, Sep 5, 2017 at 9:05 AM, Corentin Chary wrote:
>
>
> On Mon, Sep 4, 2017 at 7:15 PM, Andy Shevchenko
> wrote:
>>
>> On Mon, Sep 4, 2017 at 11:21 AM, Corentin Chary
>> wrote:
>> >
BIOS/Firmware settings.
Signed-off-by: Corentin Chary
---
.../ABI/testing/sysfs-platform-thinkpad-wmi| 50 +
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile |1 +
drivers/platform/x86/thinkpad-wmi.c
+
> 5 files changed, 145 insertions(+), 6 deletions(-)
>
> --
> 2.5.0
>
Looks good to me. I hope that we can get rid of all these quirks in
the near future.
Reviewed-by: Corentin Chary
--
Corentin Chary
http://xf.iksaif.net
rom showing up */
> diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wmi.h
> index 4da4c8b..5de1df5 100644
> --- a/drivers/platform/x86/asus-wmi.h
> +++ b/drivers/platform/x86/asus-wmi.h
> @@ -38,6 +38,7 @@ struct key_entry;
> struct asus_wmi;
>
> struct quirk_entry {
> + bool no_rfkill;
> bool hotplug_wireless;
> bool scalar_panel_brightness;
> bool store_backlight_power;
> --
> 2.5.0
>
--
Corentin Chary
http://xf.iksaif.net
rm/x86/asus-wmi.h
> index 4da4c8b..5de1df5 100644
> --- a/drivers/platform/x86/asus-wmi.h
> +++ b/drivers/platform/x86/asus-wmi.h
> @@ -38,6 +38,7 @@ struct key_entry;
> struct asus_wmi;
>
> struct quirk_entry {
> + bool no_rfkill;
> bool hotplug_wireless;
> bool scalar_panel_brightness;
> bool store_backlight_power;
> --
> 2.5.0
>
--
Corentin Chary
http://xf.iksaif.net
t;
>> I have not tested this mapping on any other Asus laptop.
>>
>> Signed-off-by: Łukasz Stelmach
>
> Thanks Łukasz.
>
> Corentin, any concerns?
Acked-by: Corentin Chary
Sorry for the delay, I won't really have a stable internet connection
until October.
>
>&g
aptop
>> driver or not.
>>
>> (I intended to do that review myself, but I haven't found the time in 48
>> hours,
>> so I'm just going to send this out and ask that Alex have a look and provide
>> his
>> thoughts on asus-laptop)
>>
>
.callback = dmi_matched,
> .ident = "ASUSTeK COMPUTER INC. X401U",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> --
> 1.9.1
>
Acked-by: Corentin Chary http://xf.iksaif.net
-
contained some code to try to control the second fan also, was
> reported to work on an UX32VD, at least for the first fan.
>
> As Felipe already mentioned the low-level functions are described here:
> http://forum.notebookreview.com/threads/fan-control-on-asus-prime-ux31-ux31a-ux32a-ux32vd.
if (value == 0)
> + if (!value)
> ok = false;
> + } else if (fan_attr <= asus->asus_hwmon_num_fans && fan_attr != -1) {
> + ok = true;
> + } else {
> + ok = false;
> }
>
0);
>> if (attr == &dev_attr_usb_charge.attr)
>> ok = !!(read_usb_charge(samsung) >= 0);
>> + if (attr == &dev_attr_lid_handling.attr)
>> + ok = !!(read_lid_handling(samsung) >= 0);
>>
>> return ok ? attr->mode
);
> - } else {
> - supported = true;
> + } else if (index == 9) {
> + ret = asus->is_pega_lucid ||
> + (!acpi_check_handle(handle, METHOD_ALS_CONTROL, NULL)
> &&
> +!acpi_check_handle(handle, METHOD_ALS_LE
side the merge
> window.
Was this re-sent for 3.9 ? Or will this hit 3.10 instead ?
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
sus-wmi.c
> @@ -1353,11 +1353,6 @@ static int is_display_toggle(int code)
> return 0;
> }
>
> -static void do_nothing(void)
> -{
> - return;
> -}
> -
> static void asus_wmi_notify(u32 value, void *context)
> {
> struct asus_wmi *asus = c
Sorry for the lag...
On Mon, Dec 24, 2012 at 12:55 PM, Roland Stigge wrote:
> On 24/12/12 09:41, Corentin Chary wrote:
>> On Sun, Dec 23, 2012 at 6:21 PM, Roland Stigge wrote:
>>> After boot,
>>> /sys/devices/platform/samsung/leds/samsung::kbd_backlight/brightness
f the led is set to 0, what's the value after reboot ? 0 or 8 ?
What's the behavior on windows ?
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
Maybe this should be shared in another module...
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c | 36 ++--
drivers/platform/x86/asus-nb-wmi.c | 24
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a
-by: AceLan Kao
Signed-off-by: Corentin Chary
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c | 31 ++-
drivers/platform/x86/asus-wmi.c| 26 +++---
drivers/platform/x86/asus-wmi.h|7 +++
3 files changed, 60 i
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b/drivers/platform/x86/asus-laptop.c
index 0fc4e30..a8a7755 100644
--- a/drivers/platform/x86
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c |2 ++
drivers/platform/x86/asus-wmi.c|8
drivers/platform/x86/asus-wmi.h|2 ++
drivers/platform/x86/eeepc-wmi.c |2 ++
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers
t, don't bother
calling it on init. Those who are curious can still get the result
through the 'infos' device attribute.
Update the comment about HWRS in show_infos().
Reported-by: ryan
References: http://bugs.debian.org/692436
Signed-off-by: Ben Hutchings
Signed-off-by: Corentin Ch
From: AceLan Kao
Fill up all the video switch keys in the map.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c | 22 +++---
1 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b
From: AceLan Kao
0x60 is touchpad enable key, but is misdefined in the keymap.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b
From: AceLan Kao
0x60 is touchpad enable key, but is misdefined in the keymap.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b
From: AceLan Kao
Fill up all the video switch keys in the map.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |3 +++
drivers/platform/x86/asus-nb-wmi.c |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b/drivers/platform/x86/asus-laptop.c
index 4b568df..68257ed 100644
Signed-off-by: Corentin Chary
---
MAINTAINERS|4 ++--
drivers/platform/x86/asus-nb-wmi.c |2 +-
drivers/platform/x86/asus-wmi.c|2 +-
drivers/platform/x86/eeepc-wmi.c |2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b
On Sun, Nov 4, 2012 at 7:37 PM, Alan Cox wrote:
>> Acked-by: Corentin Chary
>
> This is totally bogus and prevents users build a kernel which can work in
> either mode. As such its a regression.
Arg.. Sorry for that, I didn't realized that CONFIG_EFI=y was not
something ra
; This module seems to be the culprit as it's grovelling around in the
> 0xf region which has no mapping in either the e820 or EFI memory
> maps on the affected machines.
>
> Reported-by: Alessandro Crismani
> Reported-by: Mikhail Bakhterev
> Tested-by: Patrick H
> Cc: H. P
On Fri, Nov 2, 2012 at 1:09 PM, Olof Johansson wrote:
> On Fri, Nov 2, 2012 at 2:03 PM, Corentin Chary
> wrote:
>> On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson wrote:
>>> On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary
>>> wrote:
>>>
>>>&g
On Fri, Nov 2, 2012 at 12:45 PM, Olof Johansson wrote:
> On Fri, Oct 26, 2012 at 10:30 AM, Corentin Chary
> wrote:
>
>> Looks better, but I'm curious, what is the final purpose of this driver ?
>> What ABI will be exposed, who will use it ?
>>
>> If it i
DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Lumpy"),
> + },
> + .callback = setup_isl29018_als,
> + },
> + { }
> +};
> +MODULE_DEVICE_TABLE(dmi, chromeos_laptop_
+ {
> + .ident = "Samsung Series 5 550 - Light Sensor",
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "Lumpy"),
> + },
> + .callback = setup_isl29018_als,
Maybe you should matc
From: AceLan Kao
Fill up all the video switch keys in the map.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c | 22 +++---
1 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b
-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c | 31 ++-
drivers/platform/x86/asus-wmi.c| 31 ---
drivers/platform/x86/asus-wmi.h|7 +++
3 files changed, 65 insertions(+), 4 deletions(-
From: AceLan Kao
0x60 is touchpad enable key, but is misdefined in the keymap.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b
From: AceLan Kao
Fill up all the video switch keys in the map.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
From: AceLan Kao
0x60 is touchpad enable key, but is misdefined in the keymap.
Signed-off-by: AceLan Kao
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-nb-wmi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c
b
Maybe this should be shared in another module...
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c | 36 ++--
drivers/platform/x86/asus-nb-wmi.c | 24
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a
Signed-off-by: Corentin Chary
---
MAINTAINERS|4 ++--
drivers/platform/x86/asus-nb-wmi.c |2 +-
drivers/platform/x86/asus-wmi.c|2 +-
drivers/platform/x86/eeepc-wmi.c |2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |3 +++
drivers/platform/x86/asus-nb-wmi.c |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b/drivers/platform/x86/asus-laptop.c
index 4b568df..68257ed 100644
>
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.12 (GNU/Linux)
>
> iEYEARECAAYFAlBYSzUACgkQjUF4jpCSQBQpbgCfSUUvaZbs1krkcRKa8iTcyKxA
> 7AQAn1NfXugZ5553+Z9LOB46lJqFcXt8
> =avwS
> -END PGP SIGNATURE-
>
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: se
On Mon, Aug 20, 2012 at 10:01 PM, Corentin Chary
wrote:
> Signed-off-by: Corentin Chary
> ---
> drivers/platform/x86/acer-wmi.c |2 --
> drivers/platform/x86/apple-gmux.c |4
> drivers/platform/x86/asus-wmi.c |4
> drivers/platform/x8
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b/drivers/platform/x86/asus-laptop.c
index e38f91b..110c777 100644
--- a/drivers/platform/x86/asus-laptop.c
From: Maxim Nikulin
MODULE_PARM_DESC for wlan_status is further in the same file
Signed-off-by: Maxim A. Nikulin
Signed-off-by: Corentin Chary
---
drivers/platform/x86/asus-laptop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-laptop.c
b
Signed-off-by: Corentin Chary
---
drivers/platform/x86/acer-wmi.c |2 --
drivers/platform/x86/apple-gmux.c |4
drivers/platform/x86/asus-wmi.c |4
drivers/platform/x86/samsung-laptop.c |4
4 files changed, 14 deletions(-)
diff --git a/drivers
har *bled_type = "unknown";
>
> module_param(wled_type, charp, 0444);
> -MODULE_PARM_DESC(wlan_status, "Set the wled type on boot "
> +MODULE_PARM_DESC(wled_type, "Set the wled type on boot "
> "(unknown, led or rfkill). "
>
};
> +
> +static int __init chromeos_laptop_init(void)
> +{
> + if (!dmi_check_system(chromeos_laptop_dmi_table)) {
> + pr_debug("%s unsupported system.\n", __func__);
> + return -ENODEV;
> + }
> + return 0;
> +}
> +
> +
Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit :
> asus_acpi, support F2JE model
Just use the new asus-laptop driver =)
(see acpi4asus-0.40)
--
CHARY 'Iksaif' Corentin
http://xf.iksaif.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
53 matches
Mail list logo
