Previously, checking memset declarations would generate
a lot of errors saying that $ms_size was not defined.
This commit fixes that.
Signed-off-by: Cruz Julian Bishop
---
scripts/checkpatch.pl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b
nt on line 230ish in slic.h
that appears to have lost it's formatting. It was fine when I was working
in Geany, but it caught my eye in the below diff. Sorry if it actually happened!
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/slicoss/slic.h| 504 ++---
The errors fixed are all instances of
"ERROR: do not use assignment in if condition"
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/slicoss/slicoss.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drive
I'm assuming that "CRC shit reg" is referencing the CRC register/registry.
Please ignore this patch if "shit" is actually in context
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/slicoss/slicoss.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
could have
any change in functionality, but you never know.
Thanks for looking at these.
~Cruz
Cruz Julian Bishop (3):
staging: slicoss: Stop swearing in slicoss.c
staging: slicoss: Fix three checkpatch.pl errors in slicoss.c
staging: slicoss: Fix space-related checkpatch.pl warnings
This fixes two instances of
"static const char * array should probably be static const char * const"
I have seen other commits doing this in other files, so I am
assuming it should be done here as well.
Please tell me if this is wrong :)
Signed-off-by: Cruz Julian Bishop
---
drive
Hi, Greg and others.
This is a small patch series to fix some checkpatch issues and add
some help documentation to Kconfig.
Sorry if I messed up - I haven't written Kconfig documentation before,
so I'm not quite sure if it has to be in a certain style.
Cruz Julian Bishop (3):
stagin
This changes the following:
1: BinderDriverReturnProtocol -> binder_driver_return_protocol
2: BinderDriverCommandProtocol -> binder_driver_return_protocol
These enums are not currently used, but still generate noise in checkpatch.
Well, did. They don't now :)
Signed-off-by: Cruz Ju
quot;---help---",
as recommended by kconfig-language.txt in order to visually
aid developers.
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/Kconfig | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/Kconfig
On 08/11/12 10:26, David Solda wrote:
Dmitry, all,
To clarify my comment. Our protocol utilizes 8 bytes which are needed in our
driver. In order for the Linux system to accept 8 bytes of data, the Linux
psmouse system driver is required to be modified. Without this modification,
the driver
Hi everyone,
I was just wondering - Since (last time I looked, anyway),
/scripts/* has no maintainer, who would I send patches to?
Would I just send them to the mailing list, or is there a
sort of catch-all maintainer for things like this?
Thanks in advance, and sorry if this is already answered
On Sat, 2012-10-20 at 18:05 -0700, Joe Perches wrote:
> On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> > Fixed all instances of strings spanning multiple lines from checkpatch.pl.
> []
> > diff --git a/drivers/staging/android/binder.c
> > b/drivers/staging/android/binder.c
> []
> > @@ -55
Don't forget to drop support for Wifi and enforce
Coaxial cable connections!
On Thu, 2012-09-13 at 15:46 -0400, Rich Lawlman wrote:
> Linux needs to drop USB support, as it's old, troublesome, useless and
> superseded by wireless technologies. We need to drive people's
> attention away from such r
On 13/09/12 10:18, Rich Lawlman wrote:
It is by fine, unbiased analysis I propose the following:
For one, drop all support for cpu archs except ARM. Dropping support
will reduce development strain, and x86 has no foreseeable future
anyways. This will allow Linux to accelerate its development
My bad, misread the documentation files.
I'll resubmit without this
On Tue, 2012-09-04 at 08:20 +1000, Cruz Julian Bishop wrote:
> This is required by the CodingStyle kernel documentation file
>
> Signed-off-by: Cruz Julian Bishop
> ---
> scripts/ch
In my last submission, Joe Perches (is that right?)
suggested using a function that is built in to Perl.
I haven't had a chance to test it yet, but if it turns
out to be okay, I'll make a separate merge request at
a later date.
On Tue, 2012-09-04 at 08:20 +1000, Cruz Julian Bishop wro
On 01/09/12 04:09, Jesper Juhl wrote:
> On Fri, 31 Aug 2012, Cruz Julian Bishop wrote:
>
>> ...and a big step for learning more Perl.
>>
>> Hi!
>>
>> This patch set started off as an experiment, but as I continued, I
>> realised that I should submit
On 01/09/12 01:42, Joe Perches wrote:
> On Fri, 2012-08-31 at 23:18 +1000, Cruz Julian Bishop wrote:
>> This patch allows for much easier implementation of arguments
>> when modifying checkincludes.pl
>>
>> The variable $file is also initially named $arg - I wasn
Ah, the wonders of having no coffee. I only just realized that
I wrote checkpatch instead of checkincludes!
Should I resubmit this patch series, or just leave it since it's
already on the mailing list?
On 31/08/12 23:18, Cruz Julian Bishop wrote:
> ...and a big step for learning m
sometimes annoying when performing checks on a single file
or directory without problems - "No output, does that mean it's
all good or I wrote the wrong command?"
Signed-off-by: Cruz Julian Bishop
---
scripts/checkincludes.pl | 12
1 file changed, 12 insertions
: Cruz Julian Bishop
---
scripts/checkincludes.pl |8
1 file changed, 8 insertions(+)
diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
index 7d713c2..cde7ce1 100755
--- a/scripts/checkincludes.pl
+++ b/scripts/checkincludes.pl
@@ -30,12 +30,16 @@ if ($#ARGV <
just left it.
Overall, this still works nicely. There are some more
potential simplifications, but I will cover those in another
patch if I decide to implement them tonight.
Signed-off-by: Cruz Julian Bishop
---
scripts/checkincludes.pl | 85 +-
1
This is already used in checkpatch.pl, and is easier to
read, so I am changing it in checkincludes as well.
Additionally, this makes the usage output theoretically
easier to edit. In practise, there's almost no difference
Signed-off-by: Cruz Julian Bishop
---
scripts/checkincludes.pl |
duplicated includes by default
Sorry if I did anything wrong - It's my first time really
experimenting with Perl.
Thanks in advance.
~Cruz
Cruz Julian Bishop (4):
scripts/checkincludes.pl: Print usage with heredoc
scripts/checkincludes.pl: Simplify and shorten argument logic
On 29/08/12 05:52, Franklin Teaburry wrote:
> Wow, the internets have been flooded lately with brilliant suggestions along
> the theme of dropping things. Clearly this is a sign that something need be
> dropped! While I can certainly see a glimmer of wisdom among each of these
> fine gentleman
On 26/08/12 12:18, Henrique de Moraes Holschuh wrote:
> On Sat, 25 Aug 2012, wbrana wrote:
>> On 8/25/12, Pekka Enberg wrote:
>>> So despite my humble suggestion, you've filled up my inbox with
>>> pointless rambling. Would it be at all possible you just got the f*ck
>>> off LKML? I know it's diff
On 25/08/12 02:36, Alan Cox wrote:
>> almost all x86-32 boxes will be trash in 2017, remaining boxes will
>> use long term tree
> People will still be manufacturing 32bit x86 processors in 2017 I'm quite
> sure. You appear entirely out of touch. There are already serious
> discussions going on abou
On 25/08/12 03:05, wbrana wrote:
> On 8/24/12, Martin Nybo Andersen wrote:
>> What I'd hate even more is rendering my old working hardware useless by
>> removing x86-32 support from the kernel. To reason the removal by saying
>> "Microsoft plans to do it" just makes me go bonkers...
> Your old har
On Mon, 2012-08-13 at 19:01 -0700, Greg KH wrote:
> On Thu, Aug 02, 2012 at 09:50:44AM +1000, Ryan Mallon wrote:
> > On 01/08/12 14:54, Cruz Julian Bishop wrote:
> > > Previously, when calling is_between(a, b, c), the calculation was wrong.
> > > It counted C as between
On 12/08/12 20:18, OGAWA Hirofumi wrote:
> Cruz Julian Bishop writes:
>
>> Hi (and to the mailing list, again).
>>
>> This is a patch series that fixes checkpatch issues in fs/fat.
>>
>> I didn't get to do all of the files, but I'll be sure to come
Added a space before an equals sign/operator in line 410.
Yeah, I know. It's a lame commit, but at least it works!
Signed-off-by: Cruz Julian Bishop
---
fs/fat/namei_msdos.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fat/namei_msdos.c b/fs/fat/namei_msdos.c
This patch does the following:
1: Stops any lines going over 80 characters
2: Removes a blank line before EXPORT_SYMBOL_GPL
Signed-off-by: Cruz Julian Bishop
---
fs/fat/fatent.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/fat/fatent.c b
Julian Bishop
---
fs/fat/dir.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 4b04d5e..79fdec6 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -18,7 +18,7 @@
#include
#include
#include
-#include
+#include
This commit simply removes the spacing between function
definitions and EXPORT_SYMBOL_GPL calls, which were
previously generating warnings.
Signed-off-by: Cruz Julian Bishop
---
fs/fat/dir.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7b1b9c1
This does the following:
1: Splits the arguments of a function call to stop it
from exceeding 80 characters
2: Re-indents the arguments of another function call
to prevent the splitting of a quoted string.
Signed-off-by: Cruz Julian Bishop
---
fs
The comments were not lined up properly, so I just
re-indented them.
This also fixes a stupid checkpatch issue unknowingly
Signed-off-by: Cruz Julian Bishop
---
fs/fat/fat.h | 72 +-
1 file changed, 36 insertions(+), 36 deletions
Mainly fixed spacing issues such as "foo * bar" and "foo= bar"
Signed-off-by: Cruz Julian Bishop
---
fs/fat/fat.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/fat/fat.h b/fs/fat/fat.h
index 88b6c29..2ef82cf 100644
--- a/fs/fat/fat.h
+++ b/f
hes.
Thanks in advance
~Cruz
Cruz Julian Bishop (7):
fs/fat: Fix a checkpatch issue in namei_msdos.c
fs/fat: Fix some checkpatch issues in fat.h
fs/fat: Changed indentation of some comments in fat.h
fs/fat: Fix two checkstyle issues in cache.c
fs/fat: Fixes some small checkpatch issues is dir.
Sorry, had to send this again so it could go to the mailing list. I
accidentally replied to you personally :\
On 04/08/12 08:12, Chris Jones wrote:
There's a lot of attention at the moment focused toward Linux and the
future of gaming support on the platform. And it got me thinking, is
there a
Sorry, I didn't realize that text would look so ugly in LKML.
I'll be sure to keep the lines nice and short next time.
~Cruz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
I will document the rest later if they remain unchanged
Normally, I would do them all at once, but I don't have the chance to do them
all at the moment
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/logger.c | 90 +-
1 file change
Previously, there were simply comments after each part - Now, it is completed
properly according to "Kernel doc"
Sorry in advance if I made any mistakes.
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/logger.h | 24 +---
1 file changed, 17 insert
forth.
Obviously, ten is not a number between one and ten - only two to eight are, so
I made this patch :)
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/logger.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/logger.c b/drivers
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/logger.c | 40 +-
1 file changed, 26 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index f7b8237..1d5ed47 100644
--- a/drivers
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/android/ashmem.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 69cf2db..94a740d 100644
--- a/drivers/staging
. :)
Cruz Julian Bishop (5):
Fix comment/license formatting in android/ashmem.c
Complete documentation of logger_entry in android/logger.h
Finish documentation of two structs in android/logger.c
Redocument some functions in android/logger.c
Fixes a potential bug in android/logger.c
drive
From: Cruz Julian Bishop
This commit changes printk calls to pr_info, _err, and _debug
Signed-off-by: Cruz Julian Bishop
---
drivers/staging/panel/panel.c | 27 +++
1 file changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/panel/panel.c b
47 matches
Mail list logo
