[PATCH] SUN3/3X Lance trivial fix improved

2007-03-15 Thread Cyrill V. Gorcunov
This patch adds checking for allocated DVMA memory and granted IRQ line. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- Andrew, I've sent the patch almost the month ago... It seems the patch was lost :( drivers/net/sun3lance.c | 16 +++- 1 files changed, 15

Re: [patch 05/11] syslets: core code

2007-02-17 Thread Cyrill V. Gorcunov
On Sat, Feb 17, 2007 at 01:02:00PM +0300, Evgeniy Polyakov wrote: [... snipped ...] | Yes, I only proposed to change what Ingo has right now - although it is | usable, but it does suck, but since overall syslet design is indeed good | it does not suffer from possible interface changes - so I said

[PATCH] DS1374: check for workqueue creation

2007-02-16 Thread Cyrill V. Gorcunov
This patch checks if workqueue creation failed. Further usage of NULL pointed workqueue is not good I guess ;) Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- drivers/i2c/chips/ds1374.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/i2c

Re: [patch 05/11] syslets: core code

2007-02-16 Thread Cyrill V. Gorcunov
On Fri, Feb 16, 2007 at 07:58:54PM +0300, Evgeniy Polyakov wrote: | Absolutely. | And if overall system design is good, there is no problem to change | (well, for those who fail to read to the end and understand my english | replace 'to change' with 'to create and commit') interface to the state |

[PATCH] HIL: fix improper call of release_region v2

2007-02-15 Thread Cyrill V. Gorcunov
Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- An improved version (v2). Helge, please check it and Ack then. drivers/input/keyboard/hilkbd.c |2 ++ 1

Re: [PATCH] HIL: fix improper call of release_region

2007-02-15 Thread Cyrill V. Gorcunov
n Thursday 15 February 2007, Cyrill V. Gorcunov wrote: | > Thist patch prevents from improper call of release_region | > if the code has been compiled without CONFIG_HP300 support. | > | > Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> | > | > --- | > | >

[PATCH] HIL: fix improper call of release_region

2007-02-15 Thread Cyrill V. Gorcunov
Thist patch prevents from improper call of release_region if the code has been compiled without CONFIG_HP300 support. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- drivers/input/keyboard/hilkbd.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/d

[PATCH] qconf: hide empty list items

2007-02-10 Thread Cyrill V. Gorcunov
This patch fixes showing empty config list items if "Option/Show All Options" is turned on. For example empty items appears on list of 'Block Layer' menu. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- Roman, this patch is temporary solution only. The proble

[PATCH] SUN3/3X Lance trivial fix improved

2007-02-06 Thread Cyrill V. Gorcunov
This patch adds checking for allocated DVMA memory and granted IRQ line. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- Sam, this patch is almost the same I've already sent you except of some improvements (thanks to Jiri Slaby) like iounmap(), dvma_free() calls.

Re: [PATCH] SUN3/3X Lance trivial fix

2007-02-06 Thread Cyrill V. Gorcunov
On Tue, Feb 06, 2007 at 12:47:36PM +0100, Jiri Slaby wrote: | Jiri Slaby napsal(a): | >Jiri Slaby napsal(a): | >>Cyrill V. Gorcunov napsal(a): | >>>This patch adds checking for allocated DVMA | >>>memory and granted IRQ line. | >>> | >>>Signed

[PATCH] SUN3/3X Lance trivial fix

2007-02-05 Thread Cyrill V. Gorcunov
This patch adds checking for allocated DVMA memory and granted IRQ line. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- drivers/net/sun3lance.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/net/sun3lance.c b/drivers/net/sun3lance.c

Re: [PATCH] HIL small fix

2007-02-04 Thread Cyrill V. Gorcunov
of an unitialized spinlock in the code as well: | http://lists.parisc-linux.org/pipermail/parisc-linux-cvs/2007-February/037203.html | | Regards, | Helge | | On Sunday 04 February 2007, Cyrill V. Gorcunov wrote: | > This patch adds a checking for errors in hil_keyb_init. | > Also some extra

[PATCH] HIL small fix

2007-02-03 Thread Cyrill V. Gorcunov
This patch adds a checking for errors in hil_keyb_init. Also some extra spaces are removed. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- dvers/input/keyboard/hilkbd.c | 106 +++ 1 files changed, 62 insertions(+), 44 deletions(-) diff -

[PATCH] qconf: Back button behaviour normalization

2007-01-13 Thread Cyrill V. Gorcunov
This patch does "Back" button behaviour normalization so it is enabled starting from second-level menu only. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- Roman, please check it... may be a better way does exist to do it. The diff is produced over pure Linux v2.6.

[PATCH] qconf: fix showing help info on failed search

2007-01-12 Thread Cyrill V. Gorcunov
qconf does not clear help text in search window if previous search has been failed. Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index c0ae0a7..f9a63a4 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/k

qconf handling NULL pointers

2007-01-06 Thread Cyrill V. Gorcunov
Hi, Roman I found qconf have a few malloc(), strdup() without any check for NULL returned code. May be it should be fixed? Am I wrong? -- - Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH] qconf: fix SIGSEGV on empty menu items

2007-01-04 Thread Cyrill V. Gorcunov
qconf may cause SIGSEGV by trying to show debug information on empty menu items Signed-off-by: Cyrill V. Gorcunov <[EMAIL PROTECTED]> --- diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 0b2fcc4..0694d1d 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qc

Re: qconf: reproducible segfault

2007-01-04 Thread Cyrill V. Gorcunov
Please try patch I've enveloped. And write me does it fix your problem? -- - Cyrill diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 0b2fcc4..0694d1d 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -925,6 +925,8 @@ ConfigInfoView::ConfigInfoVi

Re: qconf: reproducible segfault

2007-01-04 Thread Cyrill V. Gorcunov
Hi, there is SIGSEGV happens in qconf.cc:995 str += print_filter(sym->name); but sym points to 0x1. To reproduce the error just do: 1) make xconfig (with Options->Show Debug Info unchecked) 2) go to Networking->Networking Options->Network packet filtering framework (Netfilter)-> Netw