tty's flags can be set by calling tty_alloc_driver().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index aa393d2..6418cc5 100644
tty's flags can be set by calling tty_alloc_driver().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index aa393d2
The tty_struct of serial_driver and print_driver were getting
allocated twice. One is allocated in tty_alloc_driver(), the other
is in dgap_tty_register(). So remove these in dgap_tty_register().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 16
The board_t has a tty_struct(serial_driver and print_driver)
that has a major number. When major number is compared in
dgap_tty_open(), just use brd-serial_driver{print_driver}-major.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |9 ++---
drivers
use find_board_by_major function instead of getting a brd from static
arrary. Becasue tty's major number doesn't start zero and we can
find a brd from dgap_board[].
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 28 +---
1 files
The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 23
The dgap_init_global() initialize the dgap_board
that is a global variable as static and dgap_poll_timer.
But init_timer() is called twice in dgap_start() and dgap_board
doesn't need to be initialized to NULL.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c
Hi,
2014-10-31 5:33 GMT+09:00 Greg KH :
> On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
>> Re-arrange the functions for removing forward declarations.
>>
>> Tested-by: Mark Hounschell
>> Signed-off-by: Daeseok Youn
>> Tested-by: Mark Hou
Hi,
2014-10-31 5:33 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Thu, Oct 30, 2014 at 12:14:00PM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Tested
Hi,
2014-10-29 18:22 GMT+09:00 Greg KH :
> On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
>> Re-arrange the functions for removing forward declarations.
>>
>> Tested-by: Mark Hounschell
>> Signed-off-by: Daeseok Youn
>> ---
>> R
Hi,
2014-10-29 18:22 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Sun, Oct 26, 2014 at 11:08:54AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Tested-by: Mark Hounschell ma...@compro.net
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Hi,
2014-10-14 11:19 GMT+09:00 Joe Perches :
> On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote:
>> On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
>> > On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>> > > 2014-10-13 12:25 GMT+09:00 Greg KH :
Hi,
2014-10-14 11:19 GMT+09:00 Joe Perches j...@perches.com:
On Tue, 2014-10-14 at 04:04 +0200, Greg KH wrote:
On Mon, Oct 13, 2014 at 07:56:38AM -0700, Joe Perches wrote:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org
Hi,
2014-10-13 23:56 GMT+09:00 Joe Perches :
> On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> 2014-10-13 12:25 GMT+09:00 Greg KH :
>> > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
>> >> Re-arrange the f
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH :
> On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
>> Re-arrange the functions for removing forward declarations.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> This patch has too many changes for re-arrang
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing forward declarations.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch has too many changes for re
Hi,
2014-10-13 23:56 GMT+09:00 Joe Perches j...@perches.com:
On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
Hi,
2014-10-13 12:25 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
Re-arrange the functions for removing
Hi,
2014-10-09 19:23 GMT+09:00 Dan Carpenter :
> On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote:
>> On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
>> > The dgap_init_module() need to unwind for cleanup variables properly.
>> > Becau
Hi,
2014-10-09 19:23 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote:
On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
The dgap_init_module() need to unwind for cleanup variables properly.
Because
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn
---
V2: change ulong which is non-standard
Hi, Dan
2014-10-08 20:37 GMT+09:00 Dan Carpenter :
> All three of these patches are good and a nice improvement. This one is
> a good bugfix. I have some notes for later, though below.
>
> On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
>> diff --git a/drivers/s
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 27
dgap_release_remap() function is only called after the memory
has been remapped so if statement for checking NULL doesn't
need.
And also release_mem_region() calls are moved after iounmap() calls.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 13 -
1 files changed
dgap_do_remap() and dgap_release_remap() names could be
changed to dgap_remap() and dgap_unmap().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
dgap_do_remap() and dgap_release_remap() names could be
changed to dgap_remap() and dgap_unmap().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
dgap_release_remap() function is only called after the memory
has been remapped so if statement for checking NULL doesn't
need.
And also release_mem_region() calls are moved after iounmap() calls.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 13
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap
Hi, Dan
2014-10-08 20:37 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
All three of these patches are good and a nice improvement. This one is
a good bugfix. I have some notes for later, though below.
On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
diff --git a/drivers
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: change ulong which
2014-09-25 16:50 GMT+09:00 Dan Carpenter :
> On Thu, Sep 25, 2014 at 09:26:47AM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> 2014-09-24 18:45 GMT+09:00 Dan Carpenter :
>> > On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
>> >> static v
2014-09-25 16:50 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Thu, Sep 25, 2014 at 09:26:47AM +0900, DaeSeok Youn wrote:
Hi,
2014-09-24 18:45 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
static void
Hi,
2014-09-24 18:45 GMT+09:00 Dan Carpenter :
> On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
>> static void dgap_release_remap(struct board_t *brd)
>> {
>> - release_mem_region(brd->membase, 0x20);
>> - release_mem_region(brd->
Hi,
2014-09-24 18:42 GMT+09:00 Dan Carpenter :
> On Wed, Sep 24, 2014 at 12:36:48PM +0300, Dan Carpenter wrote:
>> On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote:
>> > Signed-off-by: Daeseok Youn
>> > ---
>> > drivers/staging/dgap/dgap
Hi,
2014-09-24 18:42 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, Sep 24, 2014 at 12:36:48PM +0300, Dan Carpenter wrote:
On Tue, Sep 23, 2014 at 09:22:08AM +0900, Daeseok Youn wrote:
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1
Hi,
2014-09-24 18:45 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Sep 23, 2014 at 09:22:36AM +0900, Daeseok Youn wrote:
static void dgap_release_remap(struct board_t *brd)
{
- release_mem_region(brd-membase, 0x20);
- release_mem_region(brd-membase + PCI_IO_OFFSET
Just simply use dgap_release_remap() in dgap_cleanup_board() for
releasing map memory.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 779d144..637ea8a 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |1 -
drivers/staging/dgap/dgap.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index db8ccd1..779d144 100644
--- a/drivers/staging/dgap/dgap.c
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1 -
drivers/staging/dgap/dgap.h |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index db8ccd1..779d144 100644
--- a/drivers
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 779d144..637ea8a 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers
Just simply use dgap_release_remap() in dgap_cleanup_board() for
releasing map memory.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
on dgap_tty_init().
Signed-off-by: Daeseok Youn
---
V2: remove singal_pending().
drivers/staging/dgap/dgap.c | 37 +++--
drivers/staging/dgap/dgap.h |3 ---
2 files changed, 7 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
Hi,
2014-09-16 15:31 GMT+09:00 Dan Carpenter :
>
> On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote:
> > @@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty,
> > struct file *file)
> >* Go to
Hi,
2014-09-16 15:31 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Sep 16, 2014 at 12:33:33PM +0900, Daeseok Youn wrote:
@@ -2297,12 +2273,12 @@ static void dgap_tty_close(struct tty_struct *tty,
struct file *file)
* Go to sleep to ensure RTS/DTR
on dgap_tty_init().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: remove singal_pending().
drivers/staging/dgap/dgap.c | 37 +++--
drivers/staging/dgap/dgap.h |3 ---
2 files changed, 7 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/dgap
on dgap_tty_init().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 36 ++--
drivers/staging/dgap/dgap.h |3 ---
2 files changed, 6 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 67da1d5
on dgap_tty_init().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 36 ++--
drivers/staging/dgap/dgap.h |3 ---
2 files changed, 6 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
Hi,
2014-08-26 19:34 GMT+09:00 Tomi Valkeinen :
> On 16/05/14 12:31, Daeseok Youn wrote:
>> It doesn't need to check "err" for printing info.
>> And also use pr_info instead of printk.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> V2: removes unneed
Hi,
2014-08-26 19:34 GMT+09:00 Tomi Valkeinen tomi.valkei...@ti.com:
On 16/05/14 12:31, Daeseok Youn wrote:
It doesn't need to check err for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: removes unneeded lines for sending
The use_interrupts is used only in dagp_request_irq() for checking
a value from user config file. It doesn't need in board_t struct.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |4 +---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 1 insertions(+), 4 deletions
The brd(board_t) is initialized with zero, so "intr_used"
is not needed to set zero when request_irq() is failed.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c
The brd(board_t) is initialized with zero, so intr_used
is not needed to set zero when request_irq() is failed.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap
The use_interrupts is used only in dagp_request_irq() for checking
a value from user config file. It doesn't need in board_t struct.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |4 +---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 1 insertions
, various allocated
variables in a board will free properly.
Signed-off-by: Daeseok Youn
---
V2: update change log.
drivers/staging/dgap/dgap.c | 48 +-
drivers/staging/dgap/dgap.h |3 --
2 files changed, 20 insertions(+), 31 deletions(-)
diff --git
, various allocated
variables in a board will free properly.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: update change log.
drivers/staging/dgap/dgap.c | 48 +-
drivers/staging/dgap/dgap.h |3 --
2 files changed, 20 insertions(+), 31
Hi, Dan
2014-08-11 19:56 GMT+09:00 Dan Carpenter :
> On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
>> dgap_major_serial_registered and dgap_major_transparent_print_registered
>> could be checked whether a board is initialized.
>> But it doesn't need to check t
Hi, Dan
2014-08-11 19:56 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check
2014-08-11 12:25 GMT+09:00 Eric W. Biederman :
> Daeseok Youn writes:
>
>> The d_hash_and_lookup() returns NULL or ERR_PTR on lookup
>> failure.
>
> Given that the only error condition can come from .d_hash and that proc
> does not implement .d_hash if we want to do s
Fixed coding style in dcache.c
Signed-off-by: Daeseok Youn
---
fs/dcache.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index b7e8b20..7252cac 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2104,10 +2104,10 @@ struct dentry *d_lookup
The d_hash_and_lookup() returns NULL or ERR_PTR on lookup
failure.
Signed-off-by: Daeseok Youn
---
fs/proc/base.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index f50d4be..49bc09c 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
Fixed coding style in dcache.c
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
fs/dcache.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index b7e8b20..7252cac 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2104,10 +2104,10
The d_hash_and_lookup() returns NULL or ERR_PTR on lookup
failure.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
fs/proc/base.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index f50d4be..49bc09c 100644
--- a/fs/proc/base.c
2014-08-11 12:25 GMT+09:00 Eric W. Biederman ebied...@xmission.com:
Daeseok Youn daeseok.y...@gmail.com writes:
The d_hash_and_lookup() returns NULL or ERR_PTR on lookup
failure.
Given that the only error condition can come from .d_hash and that proc
does not implement .d_hash if we want
* use dev_{warn,err} instead of pr_{warn,err}
* removes dgap_err() and just use pr_err(). pr_err() used in
dgap_parsefile() not dev_err() because if dgap_parsefile() is
failed, just one message is printed.
* removes "out of memory" messages.
Signed-off-by: Daeseok Youn
---
drivers/st
d set to "conc.type". And also it doesn't need to "conc.v_type".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 26 +++---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 7 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/dgap/
It is same manner with setting a board type.
After allocating a type of "MNODE", get a token value
set to "module.type".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 26 +++---
drivers/staging/dgap/dgap.h |1 -
2 files changed,
If true_count is not same with brd->nasync, warning messages are
printed. But it has duplicated messages within if statement.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/stag
quot;board.type". The dgap_gettok() returns that number so
just set to "board.type" and also "v_type" can be removed.
In case of boards of PCI type are set variables to zero. These can
be removed because "p" as cnode get memory from kzalloc so already
set to zero.
These are already defined in dgap.h.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 55c06c9..b1253c0 100644
--- a/drivers/staging/dgap
dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check that variables becasue dgap module
isn't calling the dgap_cleanup_tty() without initializing
for a board completely.
Signed-off-by: Daeseok Youn
dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check that variables becasue dgap module
isn't calling the dgap_cleanup_tty() without initializing
for a board completely.
Signed-off-by: Daeseok Youn
These are already defined in dgap.h.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 55c06c9..b1253c0 100644
. The dgap_gettok() returns that number so
just set to board.type and also v_type can be removed.
In case of boards of PCI type are set variables to zero. These can
be removed because p as cnode get memory from kzalloc so already
set to zero.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
If true_count is not same with brd-nasync, warning messages are
printed. But it has duplicated messages within if statement.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git
need to conc.v_type.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 26 +++---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 7 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
It is same manner with setting a board type.
After allocating a type of MNODE, get a token value
set to module.type.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 26 +++---
drivers/staging/dgap/dgap.h |1 -
2 files changed, 7
* use dev_{warn,err} instead of pr_{warn,err}
* removes dgap_err() and just use pr_err(). pr_err() used in
dgap_parsefile() not dev_err() because if dgap_parsefile() is
failed, just one message is printed.
* removes out of memory messages.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
2014-08-05 8:38 GMT+09:00 Greg KH :
> On Tue, Aug 05, 2014 at 08:33:16AM +0900, DaeSeok Youn wrote:
>> Hi, Mark and Greg.
>>
>> Thanks for testing. :-)
>>
>> Greg, is this patch possible to merge to your staging tree?
>> Please check for me.
>> patch
Hi, Mark and Greg.
Thanks for testing. :-)
Greg, is this patch possible to merge to your staging tree?
Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2
Thanks.
regards,
Daeseok Youn.
2014-08-04 21:40 GMT+09:00 Mark Hounschell :
> On 07/31/2014 07:14 PM, DaeSeok Youn wr
Hi, Mark and Greg.
Thanks for testing. :-)
Greg, is this patch possible to merge to your staging tree?
Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2
Thanks.
regards,
Daeseok Youn.
2014-08-04 21:40 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/31/2014 07:14 PM, DaeSeok
2014-08-05 8:38 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Aug 05, 2014 at 08:33:16AM +0900, DaeSeok Youn wrote:
Hi, Mark and Greg.
Thanks for testing. :-)
Greg, is this patch possible to merge to your staging tree?
Please check for me.
patch : https://lkml.org/lkml/2014/7/31/2
Hi, Mark
2014-07-31 21:44 GMT+09:00 Mark Hounschell :
> On 07/31/2014 12:02 AM, Daeseok Youn wrote:
>>
>> When a configration file is parsed with dgap_parsefile(),
>> makes nodes for saving configrations for board.
>>
>> Making a node will allocate n
Hi, Mark
2014-07-31 21:44 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/31/2014 12:02 AM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
Hi, Mark.
Thanks for testing.
I am trying to solve this problem with config sample which is sent by you.
regards,
Daeseok Youn.
2014-07-17 22:27 GMT+09:00 Mark Hounschell :
> On 07/16/2014 09:35 PM, Daeseok Youn wrote:
>> When a configration file is parsed with dgap_parsefile(),
>&
Hi, Mark.
Thanks for testing.
I am trying to solve this problem with config sample which is sent by you.
regards,
Daeseok Youn.
2014-07-17 22:27 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/16/2014 09:35 PM, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
2014-07-17 3:47 GMT+09:00 Greg KH :
> On Wed, Jul 16, 2014 at 06:26:17PM +0900, DaeSeok Youn wrote:
>> 2014-07-16 8:50 GMT+09:00 Greg KH :
>> > On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
>> >> Hi,
>> >>
>> >> 2014-07-16 0:29
2014-07-16 23:17 GMT+09:00 Mark Hounschell :
> On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
>>
>> 2014-07-16 8:50 GMT+09:00 Greg KH :
>>
>>> On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
>>>>
>>>> Hi,
>>>>
>>
Hi, Mark
Thanks for reply.
2014-07-16 21:39 GMT+09:00 Mark Hounschell :
> On 07/15/2014 11:30 AM, Greg KH wrote:
>>
>> On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote:
>>>
>>> When a configration file is parsed with dgap_parsefile(),
>>
2014-07-16 8:50 GMT+09:00 Greg KH :
> On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> 2014-07-16 0:29 GMT+09:00 Greg KH :
>> > On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
>> >> The dgap_err() is printing a
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message
Hi, Mark
Thanks for reply.
2014-07-16 21:39 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/15/2014 11:30 AM, Greg KH wrote:
On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations
2014-07-16 23:17 GMT+09:00 Mark Hounschell ma...@compro.net:
On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre
2014-07-17 3:47 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 06:26:17PM +0900, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH :
> On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
>> The dgap_err() is printing a message with pr_err(),
>> so all those are replaced.
>>
>> Use definition "pr_fmt" and then all of "dgap:" in
The dgap_newnode() is useless for creating new node.
So just use kzalloc and set a type in case statement.
Signed-off-by: Daeseok Youn
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c | 104
The "p" as parameter is unused.
Signed-off-by: Daeseok Youn
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dga
401 - 500 of 1119 matches
Mail list logo
