The "boar" should be "board".
Signed-off-by: Daeseok Youn
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/d
If rc is zero, this function will returns with an error and
cannot reach switch-case statement.
Signed-off-by: Daeseok Youn
---
RESEND : Adds Mark to TO list and CC list for checking
send this email properly to him.
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4
The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check "retval" itself.
Signed-off-by: Daeseok Youn
---
RESEND: Adds Mark to TO list and CC list for checking
send this email prope
2014-07-15 18:21 GMT+09:00 Dan Carpenter :
> On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote:
>> 2014-07-15 15:51 GMT+09:00 Dan Carpenter :
>> > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote:
>> >> The p->u.board.status is allocated an
The p->u.board.status is allocated and set a string as
"No" once within allocating a node of BNODE type.
But it also set again with kstrdup() in case of "STATUS"
or "ID". So just free this buffer and allocate again with
kstrdup().
Signed-off-by: Daeseok Youn
-
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Use definition "pr_fmt" and then all of "dgap:" in
the beginning of print messages are removed.
And also removed "out of memory" message because
the kernel has own message for that
2014-07-15 15:51 GMT+09:00 Dan Carpenter :
> On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote:
>> The p->u.board.status is allocated and set a string as
>> "No" once within allocating a node of BNODE type.
>> But it also set again with kstrd
2014-07-15 15:41 GMT+09:00 Dan Carpenter :
> On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote:
>> When a configration file is parsed with dgap_parsefile(),
>> makes nodes for saving configrations for board.
>>
>> Making a node will allocate node me
Hi, Dan.
2014-07-15 15:47 GMT+09:00 Dan Carpenter :
> On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote:
>> The dgap_err() is printing a message with pr_err(),
>> so all those are replaced.
>>
>
> Take a look at how pr_fmt works.
>
> #define pr_fmt(f
Hi, Dan.
2014-07-15 15:47 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Take a look at how pr_fmt works.
#define pr_fmt(fmt) dgap: fmt
2014-07-15 15:41 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote:
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings
2014-07-15 15:51 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote:
The p-u.board.status is allocated and set a string as
No once within allocating a node of BNODE type.
But it also set again with kstrdup() in case of STATUS
or ID
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Use definition pr_fmt and then all of dgap: in
the beginning of print messages are removed.
And also removed out of memory message because
the kernel has own message for that.
Signed-off-by: Daeseok Youn daeseok.y
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
The p-u.board.status is allocated and set a string as
No once within allocating a node of BNODE type.
But it also set again with kstrdup() in case of STATUS
or ID. So just free this buffer and allocate again with
kstrdup().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: just use kfree
2014-07-15 18:21 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote:
2014-07-15 15:51 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote:
The p-u.board.status is allocated
The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check retval itself.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND: Adds Mark to TO list and CC list for checking
send
If rc is zero, this function will returns with an error and
cannot reach switch-case statement.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND : Adds Mark to TO list and CC list for checking
send this email properly to him.
drivers/staging/dgap/dgap.c |4
1 files changed
The boar should be board.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgap
The p as parameter is unused.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
The dgap_newnode() is useless for creating new node.
So just use kzalloc and set a type in case statement.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
RESEND : Adds Mark to TO list and CC list for checking send this email
properly to him.
drivers/staging/dgap/dgap.c | 104
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote:
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Use definition pr_fmt and then all of dgap: in
the beginning of print messages
The p->u.board.status is allocated and set a string as
"No" once within allocating a node of BNODE type.
But it also set again with kstrdup() in case of "STATUS"
or "ID". If it is not allocated yet, use kstrdup().
If not, use just memcpy().
Signed-off-by: Daeseo
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 226 --
1 files changed, 108 insertions(+), 118 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
The dgap_newnode() is useless for creating new node.
So just use kzalloc and set a type in case statement.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 104 ++
1 files changed, 74 insertions(+), 30 deletions(-)
diff --git a/drivers
The "p" as parameter is unused.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 17514c8..1e52092 100644
--- a/drivers/staging/d
The "boar" should be "board".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 470ae7b..17514c8 100644
--- a/drivers/stagi
If rc is zero, this function will returns with an error and
cannot reach switch-case statement.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check "retval" itself.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |5 +
1 files changed, 1 insertions(+), 4
The retval in dgap_block_til_ready() is initialized to zero,
and if no error has occurred in this function, the retval has a zero.
So it doesn't need to check retval itself.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |5 +
1 files changed, 1
If rc is zero, this function will returns with an error and
cannot reach switch-case statement.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
The boar should be board.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 470ae7b..17514c8 100644
--- a/drivers/staging
The dgap_newnode() is useless for creating new node.
So just use kzalloc and set a type in case statement.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 104 ++
1 files changed, 74 insertions(+), 30 deletions
The p as parameter is unused.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 17514c8..1e52092 100644
--- a/drivers
The dgap_err() is printing a message with pr_err(),
so all those are replaced.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 226 --
1 files changed, 108 insertions(+), 118 deletions(-)
diff --git a/drivers/staging
When a configration file is parsed with dgap_parsefile(),
makes nodes for saving configrations for board.
Making a node will allocate node memory and strings for saving
configrations with kstrdup().
So these are freed when dgap is unloaded or failed to initialize.
Signed-off-by: Daeseok Youn
The p-u.board.status is allocated and set a string as
No once within allocating a node of BNODE type.
But it also set again with kstrdup() in case of STATUS
or ID. If it is not allocated yet, use kstrdup().
If not, use just memcpy().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers
Adds "Daeseok Youn" to maintainers list for dgap driver.
Signed-off-by: Daeseok Youn
Suggested-by: Dan Carpenter
Cc: Greg Kroah-Hartman
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e3a5176..053a
2014-07-12 0:37 GMT+09:00, Dan Carpenter :
> On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote:
>> Can I modify the MAINTAINERS file for adding myself?
>
> Yes. Just send a patch to add yourself.
OK. I will.
Thanks.
Regards,
Daeseok Youn.
>
> git log -p MAINTAINE
ng myself?
Thank you very much!!
Regards,
Daeseok Youn.
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/major
Null checks in dgap_tty_digisetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 29 +
1
Null checks in dgap_tty_digigetcustombaud() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insert
Null checks in dgap_tty_digisetedelay() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 26 +-
1 files cha
Null checks in dgap_tty_digigeta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insertions(+
Null checks in dgap_set_modem_info() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch", "bd" and "un".
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 36 --
it is possible to let someone know what paramters
are needed for this function.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 49 +++---
1 files changed, 13 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/d
Null checks in dgap_tty_digiseta() are already done by
dgap_tty_ioctl() and change "tty" as a paramter of this function
to "ch" and "bd" which are used in dgap_tty_digiseta().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 28 +-
The "ts" is not used in dgap_param().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 79ea116..ad7b462 100644
--- a/drivers/staging/d
The "ch" is already checking in caller.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9affc5b..79ea116 100644
--- a/drivers/st
The ch is already checking in caller.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 9affc5b..79ea116 100644
are needed for this function.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 49 +++---
1 files changed, 13 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ad7b462
Null checks in dgap_tty_digiseta() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch and bd which are used in dgap_tty_digiseta().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 28 +---
1
The ts is not used in dgap_param().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 79ea116..ad7b462 100644
--- a/drivers
Null checks in dgap_tty_digigeta() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insertions(+), 18 deletions
Null checks in dgap_set_modem_info() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch, bd and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 36
1 files changed, 8 insertions
Null checks in dgap_tty_digisetedelay() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch, bd and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 26 +-
1 files changed, 5 insertions(+), 21
Null checks in dgap_tty_digigetcustombaud() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 23 +--
1 files changed, 5 insertions(+), 18
Null checks in dgap_tty_digisetcustombaud() are already done by
dgap_tty_ioctl() and change tty as a paramter of this function
to ch, bd and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 29 +
1 files changed, 5 insertions
myself?
Thank you very much!!
Regards,
Daeseok Youn.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
2014-07-12 0:37 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote:
Can I modify the MAINTAINERS file for adding myself?
Yes. Just send a patch to add yourself.
OK. I will.
Thanks.
Regards,
Daeseok Youn.
git log -p MAINTAINERS
Adds Daeseok Youn to maintainers list for dgap driver.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Suggested-by: Dan Carpenter dan.carpen...@oracle.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
MAINTAINERS |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
Null checks for tty, un and ch are already done by caller,
so replace parameter "tty" with "ch" and "un".
Signed-off-by: Daeseok Youn
---
V2: revert return type from int to void.
leave it originally.
drivers/staging/dgap/dgap.c | 21 -
1 file
Hi,
2014-07-10 4:02 GMT+09:00 Greg KH :
> On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote:
>> Null checks for tty, un and ch are already done by caller,
>> so replace parameter "tty" with "ch" and "un".
>>
>> And als
The brd is already checked by earlier function in dgap_init_one().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 8e3fd87..b60995e 100644
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index da11dfb..8e3fd87 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
Hi,
2014-07-10 4:02 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote:
Null checks for tty, un and ch are already done by caller,
so replace parameter tty with ch and un.
And also use a pointer for returning new bytes_available instead
Null checks for tty, un and ch are already done by caller,
so replace parameter tty with ch and un.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: revert return type from int to void.
leave it originally.
drivers/staging/dgap/dgap.c | 21 -
1 files changed, 4
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index da11dfb..8e3fd87 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers
The brd is already checked by earlier function in dgap_init_one().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 8e3fd87
Null checks for tty, un and ch are already done by caller,
so replace parameter "tty" with "ch" and "un".
And also use a pointer for returning new bytes_available instead of
return variable.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 29 ++
Null checks for tty, un and ch are already done by caller,
so replace parameter tty with ch and un.
And also use a pointer for returning new bytes_available instead of
return variable.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 29
dgap_dl_wait and kme_wait are not used in dgap.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |8
drivers/staging/dgap/dgap.h |1 -
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
The dgap_init_pci() calls only pci_register_driver().
It doesn't need to make a function for that.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
The dgap_init_pci() calls only pci_register_driver().
It doesn't need to make a function for that.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b
dgap_dl_wait and kme_wait are not used in dgap.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |8
drivers/staging/dgap/dgap.h |1 -
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging
dgnc_tty_ioctl() cannot reach the end of function.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f7409d9..c07ec74 100644
The brd is allocated by kzalloc() in dgnc_found_board()
so do not need to set 0 to member variable.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 4135cb0..8081621 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b
The "un->un_open_count" is unsigned variable, so it cannot
be less than zero.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgn
The un-un_open_count is unsigned variable, so it cannot
be less than zero.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 4135cb0..8081621 100644
--- a/drivers/staging
dgnc_tty_ioctl() cannot reach the end of function.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f7409d9
The brd is allocated by kzalloc() in dgnc_found_board()
so do not need to set 0 to member variable.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgnc/dgnc_tty.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b
clean up checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b5ea9ff
clean up checkpatch warning:
WARNING: void function return statements are not generally useful
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
clean up checkpatch.pl error:
ERROR: "foo* bar" should be "foo *bar"
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index d4f
clean up checkpatch.pl error:
ERROR: foo* bar should be foo *bar
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
clean up checkpatch warning:
WARNING: void function return statements are not generally useful
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
clean up checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
OS_mem_token_ interfaces are useless, so just replaced with
sk_buff related fuctions.
Signed-off-by: Daeseok Youn
---
V2: rebased on changes in the first one.
drivers/staging/cxt1e1/musycc.c | 45 +-
drivers/staging/cxt1e1/pmcc4_drv.c | 10
.
And OS_mem_token_next() returns NULL, it will be dereferencing
a NULL pointer. So it must return next fragmented packet buffer as
sk_buff.
Signed-off-by: Daeseok Youn
---
V2: rebased on changes in the first one.
drivers/staging/cxt1e1/musycc.c | 52 +++---
drivers/staging/cxt1e1
OS_phystov()/OS_vtophys() are replaced with
phys_to_virt()/virt_to_phys().
Signed-off-by: Daeseok Youn
---
V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va().
drivers/staging/cxt1e1/musycc.c | 16
drivers/staging/cxt1e1/pmcc4_drv.c | 12
OS_phystov()/OS_vtophys() are replaced with
phys_to_virt()/virt_to_phys().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va().
drivers/staging/cxt1e1/musycc.c | 16
drivers/staging/cxt1e1
.
And OS_mem_token_next() returns NULL, it will be dereferencing
a NULL pointer. So it must return next fragmented packet buffer as
sk_buff.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: rebased on changes in the first one.
drivers/staging/cxt1e1/musycc.c | 52
OS_mem_token_ interfaces are useless, so just replaced with
sk_buff related fuctions.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: rebased on changes in the first one.
drivers/staging/cxt1e1/musycc.c | 45 +-
drivers/staging/cxt1e1/pmcc4_drv.c
2014-06-30 6:22 GMT+09:00 Greg KH :
> On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote:
>> OS_mem_token_tlen() is same return value as OS_mem_token_len().
>> That means packet count is always 1. So OS_mem_token_tlen()
>> must be total length of packet and O
Hi, Greg.
2014-06-30 6:21 GMT+09:00 Greg KH :
> On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
>> OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
>
> No, you should use virt_to_phys() and phys_to_virt() instead of these
> internal macros which mi
Hi, Greg.
2014-06-30 6:21 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
No, you should use virt_to_phys() and phys_to_virt() instead of these
internal macros which might
501 - 600 of 1119 matches
Mail list logo
