[PATCH 3/8 RESEND] staging: dgap: fix a typo in dgap_gettok()

2014-07-15 Thread Daeseok Youn
The "boar" should be "board". Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/d

[PATCH 2/8 RESEND] staging: dgap: remove unused case value in dgap_parsefile()

2014-07-15 Thread Daeseok Youn
If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |4 1 files changed, 0 insertions(+), 4

[PATCH 1/8 RESEND] staging: dgap: remove redundant error value check

2014-07-15 Thread Daeseok Youn
The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself. Signed-off-by: Daeseok Youn --- RESEND: Adds Mark to TO list and CC list for checking send this email prope

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread DaeSeok Youn
2014-07-15 18:21 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote: >> 2014-07-15 15:51 GMT+09:00 Dan Carpenter : >> > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> >> The p->u.board.status is allocated an

[PATCH 8/8 V2] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread Daeseok Youn
The p->u.board.status is allocated and set a string as "No" once within allocating a node of BNODE type. But it also set again with kstrdup() in case of "STATUS" or "ID". So just free this buffer and allocate again with kstrdup(). Signed-off-by: Daeseok Youn -

[PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread Daeseok Youn
When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

[PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-15 Thread Daeseok Youn
The dgap_err() is printing a message with pr_err(), so all those are replaced. Use definition "pr_fmt" and then all of "dgap:" in the beginning of print messages are removed. And also removed "out of memory" message because the kernel has own message for that

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread DaeSeok Youn
2014-07-15 15:51 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> The p->u.board.status is allocated and set a string as >> "No" once within allocating a node of BNODE type. >> But it also set again with kstrd

Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread DaeSeok Youn
2014-07-15 15:41 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote: >> When a configration file is parsed with dgap_parsefile(), >> makes nodes for saving configrations for board. >> >> Making a node will allocate node me

Re: [PATCH 6/8] staging: dgap: remove unneeded dgap_err()

2014-07-15 Thread DaeSeok Youn
Hi, Dan. 2014-07-15 15:47 GMT+09:00 Dan Carpenter : > On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote: >> The dgap_err() is printing a message with pr_err(), >> so all those are replaced. >> > > Take a look at how pr_fmt works. > > #define pr_fmt(f

Re: [PATCH 6/8] staging: dgap: remove unneeded dgap_err()

2014-07-15 Thread DaeSeok Youn
Hi, Dan. 2014-07-15 15:47 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jul 15, 2014 at 12:02:23PM +0900, Daeseok Youn wrote: The dgap_err() is printing a message with pr_err(), so all those are replaced. Take a look at how pr_fmt works. #define pr_fmt(fmt) dgap: fmt

Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread DaeSeok Youn
2014-07-15 15:41 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread DaeSeok Youn
2014-07-15 15:51 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: The p-u.board.status is allocated and set a string as No once within allocating a node of BNODE type. But it also set again with kstrdup() in case of STATUS or ID

[PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-15 Thread Daeseok Youn
The dgap_err() is printing a message with pr_err(), so all those are replaced. Use definition pr_fmt and then all of dgap: in the beginning of print messages are removed. And also removed out of memory message because the kernel has own message for that. Signed-off-by: Daeseok Youn daeseok.y

[PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread Daeseok Youn
When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

[PATCH 8/8 V2] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread Daeseok Youn
The p-u.board.status is allocated and set a string as No once within allocating a node of BNODE type. But it also set again with kstrdup() in case of STATUS or ID. So just free this buffer and allocate again with kstrdup(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: just use kfree

Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-15 Thread DaeSeok Youn
2014-07-15 18:21 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote: 2014-07-15 15:51 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: The p-u.board.status is allocated

[PATCH 1/8 RESEND] staging: dgap: remove redundant error value check

2014-07-15 Thread Daeseok Youn
The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check retval itself. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: Adds Mark to TO list and CC list for checking send

[PATCH 2/8 RESEND] staging: dgap: remove unused case value in dgap_parsefile()

2014-07-15 Thread Daeseok Youn
If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |4 1 files changed

[PATCH 3/8 RESEND] staging: dgap: fix a typo in dgap_gettok()

2014-07-15 Thread Daeseok Youn
The boar should be board. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/dgap

[PATCH 4/8 RESEND] staging: dgap: remove unused a parameter in dgap_gettok()

2014-07-15 Thread Daeseok Youn
The p as parameter is unused. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 5/8 RESEND] staging: dgap: remove dgap_newnode()

2014-07-15 Thread Daeseok Youn
The dgap_newnode() is useless for creating new node. So just use kzalloc and set a type in case statement. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND : Adds Mark to TO list and CC list for checking send this email properly to him. drivers/staging/dgap/dgap.c | 104

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-15 Thread DaeSeok Youn
Hi, 2014-07-16 0:29 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote: The dgap_err() is printing a message with pr_err(), so all those are replaced. Use definition pr_fmt and then all of dgap: in the beginning of print messages

[PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-14 Thread Daeseok Youn
The p->u.board.status is allocated and set a string as "No" once within allocating a node of BNODE type. But it also set again with kstrdup() in case of "STATUS" or "ID". If it is not allocated yet, use kstrdup(). If not, use just memcpy(). Signed-off-by: Daeseo

[PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-14 Thread Daeseok Youn
When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

[PATCH 6/8] staging: dgap: remove unneeded dgap_err()

2014-07-14 Thread Daeseok Youn
The dgap_err() is printing a message with pr_err(), so all those are replaced. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 226 -- 1 files changed, 108 insertions(+), 118 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers

[PATCH 5/8] staging: dgap: remove dgap_newnode()

2014-07-14 Thread Daeseok Youn
The dgap_newnode() is useless for creating new node. So just use kzalloc and set a type in case statement. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 104 ++ 1 files changed, 74 insertions(+), 30 deletions(-) diff --git a/drivers

[PATCH 4/8] staging: dgap: remove unused a parameter in dgap_gettok()

2014-07-14 Thread Daeseok Youn
The "p" as parameter is unused. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 17514c8..1e52092 100644 --- a/drivers/staging/d

[PATCH 3/8] staging: dgap: fix a typo in dgap_gettok()

2014-07-14 Thread Daeseok Youn
The "boar" should be "board". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 470ae7b..17514c8 100644 --- a/drivers/stagi

[PATCH 2/8] staging: dgap: remove unused case value in dgap_parsefile()

2014-07-14 Thread Daeseok Youn
If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

[PATCH 1/8] staging: dgap: remove redundant error value check

2014-07-14 Thread Daeseok Youn
The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |5 + 1 files changed, 1 insertions(+), 4

[PATCH 1/8] staging: dgap: remove redundant error value check

2014-07-14 Thread Daeseok Youn
The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check retval itself. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |5 + 1 files changed, 1

[PATCH 2/8] staging: dgap: remove unused case value in dgap_parsefile()

2014-07-14 Thread Daeseok Youn
If rc is zero, this function will returns with an error and cannot reach switch-case statement. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers

[PATCH 3/8] staging: dgap: fix a typo in dgap_gettok()

2014-07-14 Thread Daeseok Youn
The boar should be board. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 470ae7b..17514c8 100644 --- a/drivers/staging

[PATCH 5/8] staging: dgap: remove dgap_newnode()

2014-07-14 Thread Daeseok Youn
The dgap_newnode() is useless for creating new node. So just use kzalloc and set a type in case statement. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 104 ++ 1 files changed, 74 insertions(+), 30 deletions

[PATCH 4/8] staging: dgap: remove unused a parameter in dgap_gettok()

2014-07-14 Thread Daeseok Youn
The p as parameter is unused. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 17514c8..1e52092 100644 --- a/drivers

[PATCH 6/8] staging: dgap: remove unneeded dgap_err()

2014-07-14 Thread Daeseok Youn
The dgap_err() is printing a message with pr_err(), so all those are replaced. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 226 -- 1 files changed, 108 insertions(+), 118 deletions(-) diff --git a/drivers/staging

[PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-14 Thread Daeseok Youn
When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

[PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile()

2014-07-14 Thread Daeseok Youn
The p-u.board.status is allocated and set a string as No once within allocating a node of BNODE type. But it also set again with kstrdup() in case of STATUS or ID. If it is not allocated yet, use kstrdup(). If not, use just memcpy(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers

[PATCH] MAINTAINERS: Adds Daeseok Youn to maintainers list for dgap

2014-07-11 Thread Daeseok Youn
Adds "Daeseok Youn" to maintainers list for dgap driver. Signed-off-by: Daeseok Youn Suggested-by: Dan Carpenter Cc: Greg Kroah-Hartman --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e3a5176..053a

Re: [PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread DaeSeok Youn
2014-07-12 0:37 GMT+09:00, Dan Carpenter : > On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote: >> Can I modify the MAINTAINERS file for adding myself? > > Yes. Just send a patch to add yourself. OK. I will. Thanks. Regards, Daeseok Youn. > > git log -p MAINTAINE

Re: [PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread DaeSeok Youn
ng myself? Thank you very much!! Regards, Daeseok Youn. > regards, > dan carpenter > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

[PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digisetcustombaud() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd and "un". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 29 + 1

[PATCH 8/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digigetcustombaud()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digigetcustombaud() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "un". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 23 +-- 1 files changed, 5 insert

[PATCH 7/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetedelay()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digisetedelay() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd and "un". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 26 +- 1 files cha

[PATCH 5/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digigeta()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digigeta() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "un". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 23 +-- 1 files changed, 5 insertions(+

[PATCH 6/9] staging: dgap: removes redundant null check and change paramter for dgap_set_modem_info()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_set_modem_info() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch", "bd" and "un". Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 36 --

[PATCH 3/9] staging: dgap: removes redundant null check and change the paramter for dgap_param()

2014-07-11 Thread Daeseok Youn
it is possible to let someone know what paramters are needed for this function. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 49 +++--- 1 files changed, 13 insertions(+), 36 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/d

[PATCH 4/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digiseta()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digiseta() are already done by dgap_tty_ioctl() and change "tty" as a paramter of this function to "ch" and "bd" which are used in dgap_tty_digiseta(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 28 +-

[PATCH 2/9] staging: dgap: remove unused variable in dgap_param()

2014-07-11 Thread Daeseok Youn
The "ts" is not used in dgap_param(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 79ea116..ad7b462 100644 --- a/drivers/staging/d

[PATCH 1/9] staging: dgap: redundant NULL and magic check in dgap_get_modem_info()

2014-07-11 Thread Daeseok Youn
The "ch" is already checking in caller. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 9affc5b..79ea116 100644 --- a/drivers/st

[PATCH 1/9] staging: dgap: redundant NULL and magic check in dgap_get_modem_info()

2014-07-11 Thread Daeseok Youn
The ch is already checking in caller. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 9affc5b..79ea116 100644

[PATCH 3/9] staging: dgap: removes redundant null check and change the paramter for dgap_param()

2014-07-11 Thread Daeseok Youn
are needed for this function. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 49 +++--- 1 files changed, 13 insertions(+), 36 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index ad7b462

[PATCH 4/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digiseta()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digiseta() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch and bd which are used in dgap_tty_digiseta(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 28 +--- 1

[PATCH 2/9] staging: dgap: remove unused variable in dgap_param()

2014-07-11 Thread Daeseok Youn
The ts is not used in dgap_param(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 79ea116..ad7b462 100644 --- a/drivers

[PATCH 5/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digigeta()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digigeta() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 23 +-- 1 files changed, 5 insertions(+), 18 deletions

[PATCH 6/9] staging: dgap: removes redundant null check and change paramter for dgap_set_modem_info()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_set_modem_info() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch, bd and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 36 1 files changed, 8 insertions

[PATCH 7/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetedelay()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digisetedelay() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch, bd and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 26 +- 1 files changed, 5 insertions(+), 21

[PATCH 8/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digigetcustombaud()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digigetcustombaud() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 23 +-- 1 files changed, 5 insertions(+), 18

[PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread Daeseok Youn
Null checks in dgap_tty_digisetcustombaud() are already done by dgap_tty_ioctl() and change tty as a paramter of this function to ch, bd and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 29 + 1 files changed, 5 insertions

Re: [PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread DaeSeok Youn
myself? Thank you very much!! Regards, Daeseok Youn. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 9/9] staging: dgap: removes redundant null check and change paramter for dgap_tty_digisetcustombaud()

2014-07-11 Thread DaeSeok Youn
2014-07-12 0:37 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Sat, Jul 12, 2014 at 12:23:16AM +0900, DaeSeok Youn wrote: Can I modify the MAINTAINERS file for adding myself? Yes. Just send a patch to add yourself. OK. I will. Thanks. Regards, Daeseok Youn. git log -p MAINTAINERS

[PATCH] MAINTAINERS: Adds Daeseok Youn to maintainers list for dgap

2014-07-11 Thread Daeseok Youn
Adds Daeseok Youn to maintainers list for dgap driver. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com Suggested-by: Dan Carpenter dan.carpen...@oracle.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- MAINTAINERS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH V2] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter "tty" with "ch" and "un". Signed-off-by: Daeseok Youn --- V2: revert return type from int to void. leave it originally. drivers/staging/dgap/dgap.c | 21 - 1 file

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread DaeSeok Youn
Hi, 2014-07-10 4:02 GMT+09:00 Greg KH : > On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: >> Null checks for tty, un and ch are already done by caller, >> so replace parameter "tty" with "ch" and "un". >> >> And als

[PATCH 2/2] staging: dgap: remove redundant NULL check in dgap_tty_init()

2014-07-09 Thread Daeseok Youn
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 8e3fd87..b60995e 100644

[PATCH 1/2] staging: dgap: use kzalloc instead of kmalloc/memset

2014-07-09 Thread Daeseok Youn
Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index da11dfb..8e3fd87 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c

Re: [PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread DaeSeok Youn
Hi, 2014-07-10 4:02 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Mon, Jul 07, 2014 at 10:27:54AM +0900, Daeseok Youn wrote: Null checks for tty, un and ch are already done by caller, so replace parameter tty with ch and un. And also use a pointer for returning new bytes_available instead

[PATCH V2] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-09 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter tty with ch and un. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: revert return type from int to void. leave it originally. drivers/staging/dgap/dgap.c | 21 - 1 files changed, 4

[PATCH 1/2] staging: dgap: use kzalloc instead of kmalloc/memset

2014-07-09 Thread Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index da11dfb..8e3fd87 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers

[PATCH 2/2] staging: dgap: remove redundant NULL check in dgap_tty_init()

2014-07-09 Thread Daeseok Youn
The brd is already checked by earlier function in dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 8e3fd87

[PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-06 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter "tty" with "ch" and "un". And also use a pointer for returning new bytes_available instead of return variable. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 29 ++

[PATCH] staging: dgap: removes redundant null check and change paramter for dgap_maxcps_room()

2014-07-06 Thread Daeseok Youn
Null checks for tty, un and ch are already done by caller, so replace parameter tty with ch and un. And also use a pointer for returning new bytes_available instead of return variable. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 29

[PATCH 2/2] staging: dgap: remove unused waitqueues

2014-07-04 Thread Daeseok Youn
dgap_dl_wait and kme_wait are not used in dgap. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 drivers/staging/dgap/dgap.h |1 - 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

[PATCH 1/2] staging: dgap: remove unneccessary dgap_init_pci() function

2014-07-04 Thread Daeseok Youn
The dgap_init_pci() calls only pci_register_driver(). It doesn't need to make a function for that. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH 1/2] staging: dgap: remove unneccessary dgap_init_pci() function

2014-07-04 Thread Daeseok Youn
The dgap_init_pci() calls only pci_register_driver(). It doesn't need to make a function for that. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 2/2] staging: dgap: remove unused waitqueues

2014-07-04 Thread Daeseok Youn
dgap_dl_wait and kme_wait are not used in dgap. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 drivers/staging/dgap/dgap.h |1 - 2 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging

[PATCH 3/4] staging: dgnc: removes unreachable code

2014-07-03 Thread Daeseok Youn
dgnc_tty_ioctl() cannot reach the end of function. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index f7409d9..c07ec74 100644

[PATCH 4/4] staging: dgnc: remove redundant memset call

2014-07-03 Thread Daeseok Youn
The brd is allocated by kzalloc() in dgnc_found_board() so do not need to set 0 to member variable. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc

[PATCH 1/4] staging: dgnc: remove redundant null check for kfree()

2014-07-03 Thread Daeseok Youn
Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 4135cb0..8081621 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b

[PATCH 2/4] staging: dgnc: Fix unsigned value for less than zero

2014-07-03 Thread Daeseok Youn
The "un->un_open_count" is unsigned variable, so it cannot be less than zero. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_tty.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgn

[PATCH 2/4] staging: dgnc: Fix unsigned value for less than zero

2014-07-03 Thread Daeseok Youn
The un-un_open_count is unsigned variable, so it cannot be less than zero. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc

[PATCH 1/4] staging: dgnc: remove redundant null check for kfree()

2014-07-03 Thread Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 4135cb0..8081621 100644 --- a/drivers/staging

[PATCH 3/4] staging: dgnc: removes unreachable code

2014-07-03 Thread Daeseok Youn
dgnc_tty_ioctl() cannot reach the end of function. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index f7409d9

[PATCH 4/4] staging: dgnc: remove redundant memset call

2014-07-03 Thread Daeseok Youn
The brd is allocated by kzalloc() in dgnc_found_board() so do not need to set 0 to member variable. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgnc/dgnc_tty.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b

[PATCH 3/3] staging: dgap: Adds a blank line after declaration

2014-07-02 Thread Daeseok Youn
clean up checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index b5ea9ff

[PATCH 2/3] staging: dgap: remove "return" statement in void function

2014-07-02 Thread Daeseok Youn
clean up checkpatch warning: WARNING: void function return statements are not generally useful Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

[PATCH 1/3] staging: dgap: fixed "foo* bar should be foo * bar" in dgap.c

2014-07-02 Thread Daeseok Youn
clean up checkpatch.pl error: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index d4f

[PATCH 1/3] staging: dgap: fixed foo* bar should be foo * bar in dgap.c

2014-07-02 Thread Daeseok Youn
clean up checkpatch.pl error: ERROR: foo* bar should be foo *bar Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

[PATCH 2/3] staging: dgap: remove return statement in void function

2014-07-02 Thread Daeseok Youn
clean up checkpatch warning: WARNING: void function return statements are not generally useful Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers

[PATCH 3/3] staging: dgap: Adds a blank line after declaration

2014-07-02 Thread Daeseok Youn
clean up checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c

[PATCH 3/3 V2] staging: cxt1e1: remove OS_mem_token_xxxx interfaces in sbecom_inline_linux.h

2014-06-30 Thread Daeseok Youn
OS_mem_token_ interfaces are useless, so just replaced with sk_buff related fuctions. Signed-off-by: Daeseok Youn --- V2: rebased on changes in the first one. drivers/staging/cxt1e1/musycc.c | 45 +- drivers/staging/cxt1e1/pmcc4_drv.c | 10

[PATCH 2/3 V2] staging: cxt1e1: count fragmented packet properly.

2014-06-30 Thread Daeseok Youn
. And OS_mem_token_next() returns NULL, it will be dereferencing a NULL pointer. So it must return next fragmented packet buffer as sk_buff. Signed-off-by: Daeseok Youn --- V2: rebased on changes in the first one. drivers/staging/cxt1e1/musycc.c | 52 +++--- drivers/staging/cxt1e1

[PATCH 1/3 V2] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-06-30 Thread Daeseok Youn
OS_phystov()/OS_vtophys() are replaced with phys_to_virt()/virt_to_phys(). Signed-off-by: Daeseok Youn --- V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va(). drivers/staging/cxt1e1/musycc.c | 16 drivers/staging/cxt1e1/pmcc4_drv.c | 12

[PATCH 1/3 V2] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-06-30 Thread Daeseok Youn
OS_phystov()/OS_vtophys() are replaced with phys_to_virt()/virt_to_phys(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: use virt_to_phys()/phys_to_virt() instead of __pa()/__va(). drivers/staging/cxt1e1/musycc.c | 16 drivers/staging/cxt1e1

[PATCH 2/3 V2] staging: cxt1e1: count fragmented packet properly.

2014-06-30 Thread Daeseok Youn
. And OS_mem_token_next() returns NULL, it will be dereferencing a NULL pointer. So it must return next fragmented packet buffer as sk_buff. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: rebased on changes in the first one. drivers/staging/cxt1e1/musycc.c | 52

[PATCH 3/3 V2] staging: cxt1e1: remove OS_mem_token_xxxx interfaces in sbecom_inline_linux.h

2014-06-30 Thread Daeseok Youn
OS_mem_token_ interfaces are useless, so just replaced with sk_buff related fuctions. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: rebased on changes in the first one. drivers/staging/cxt1e1/musycc.c | 45 +- drivers/staging/cxt1e1/pmcc4_drv.c

Re: [PATCH 2/3] staging: cxt1e1: count fragmented packet properly.

2014-06-29 Thread DaeSeok Youn
2014-06-30 6:22 GMT+09:00 Greg KH : > On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote: >> OS_mem_token_tlen() is same return value as OS_mem_token_len(). >> That means packet count is always 1. So OS_mem_token_tlen() >> must be total length of packet and O

Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-06-29 Thread DaeSeok Youn
Hi, Greg. 2014-06-30 6:21 GMT+09:00 Greg KH : > On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote: >> OS_phystov()/OS_vtophys() are replaced with __va()/__pa(). > > No, you should use virt_to_phys() and phys_to_virt() instead of these > internal macros which mi

Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

2014-06-29 Thread DaeSeok Youn
Hi, Greg. 2014-06-30 6:21 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote: OS_phystov()/OS_vtophys() are replaced with __va()/__pa(). No, you should use virt_to_phys() and phys_to_virt() instead of these internal macros which might

<    1   2   3   4   5   6   7   8   9   10   >