Re: [PATCH 2/3] staging: cxt1e1: count fragmented packet properly.

2014-06-30 6:22 GMT+09:00 Greg KH gre...@linuxfoundation.org: On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote: OS_mem_token_tlen() is same return value as OS_mem_token_len(). That means packet count is always 1. So OS_mem_token_tlen() must be total length of packet

[PATCH 2/3] staging: cxt1e1: count fragmented packet properly.

. And OS_mem_token_next() returns NULL, it will be dereferencing a NULL pointer. So it must return next fragmented packet buffer as sk_buff. Signed-off-by: Daeseok Youn --- I'm not sure of this patch and not tested.(just only build test). Please review for this. Thanks. drivers/staging/cxt1e1/musycc.c

[PATCH 3/3] staging: cxt1e1: remove OS_mem_token_xxxx interfaces in sbecom_inline_linux.h

OS_mem_token_ interfaces are useless, so just replaced with sk_buff related fuctions. Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/musycc.c | 45 +- drivers/staging/cxt1e1/pmcc4_drv.c | 11 ++-- drivers/staging/cxt1e1/pmcc4_private.h

[PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

OS_phystov()/OS_vtophys() are replaced with __va()/__pa(). Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/musycc.c | 16 drivers/staging/cxt1e1/pmcc4_drv.c | 12 ++-- drivers/staging/cxt1e1/sbecom_inline_linux.h | 19

[PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()

OS_phystov()/OS_vtophys() are replaced with __va()/__pa(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/musycc.c | 16 drivers/staging/cxt1e1/pmcc4_drv.c | 12 ++-- drivers/staging/cxt1e1/sbecom_inline_linux.h

[PATCH 3/3] staging: cxt1e1: remove OS_mem_token_xxxx interfaces in sbecom_inline_linux.h

OS_mem_token_ interfaces are useless, so just replaced with sk_buff related fuctions. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/musycc.c | 45 +- drivers/staging/cxt1e1/pmcc4_drv.c | 11 ++-- drivers/staging

[PATCH 2/3] staging: cxt1e1: count fragmented packet properly.

. And OS_mem_token_next() returns NULL, it will be dereferencing a NULL pointer. So it must return next fragmented packet buffer as sk_buff. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- I'm not sure of this patch and not tested.(just only build test). Please review for this. Thanks. drivers/staging/cxt1e1

[PATCH V2] staging: dgap: make dgap_found_board() return a brd pointer

Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn --- V2: change return value properly. update error handling, if one of functions in dgap_init_one() is failed, do not need to set

Re: [PATCH] staging: dgap: make dgap_found_board() return a brd pointer

Hi, Dan. 2014-06-20 18:09 GMT+09:00 Dan Carpenter : > On Fri, Jun 20, 2014 at 02:19:58PM +0900, Daeseok Youn wrote: >> - rc = dgap_found_board(pdev, ent->driver_data, dgap_numboards); >> - if (rc) >> + brd = dgap_found_board(pdev, ent->driver_data, dgap_numb

Re: [PATCH] staging: dgap: make dgap_found_board() return a brd pointer

Hi, Dan. 2014-06-20 18:09 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Jun 20, 2014 at 02:19:58PM +0900, Daeseok Youn wrote: - rc = dgap_found_board(pdev, ent-driver_data, dgap_numboards); - if (rc) + brd = dgap_found_board(pdev, ent-driver_data, dgap_numboards

[PATCH V2] staging: dgap: make dgap_found_board() return a brd pointer

Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: change return value properly. update error handling, if one of functions in dgap_init_one() is failed, do

[PATCH] staging: dgap: make dgap_found_board() return a brd pointer

Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging

[PATCH] staging: dgap: make dgap_found_board() return a brd pointer

Make dgap_found_board() return a brd pointer and that brd pointer assign to dgap_board[] in the end of the dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff

[PATCH 7/7] staging: dgap: unwind on error in dgap_init_one()

region and unmapped memory. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 53 +++--- 1 files changed, 44 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 2ccbd54..5c8e622 100644

[PATCH 6/7] staging: dgap: move unrelated functions in dgap_firmware_load()

The dgap_firmware_load() has a lot of stuff which are unrelated with loading firmware. So just moved to dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 70 --- 1 files changed, 39 insertions(+), 31 deletions(-) diff --git

[PATCH 4/7 RESEND] staging: dgap: introduce dgap_free_irq()

dgap_free_irq() will free the irq which is requested in dgap_request_irq(). Signed-off-by: Daeseok Youn --- resend: reordering this series of patches, because some patches are merged to one. drivers/staging/dgap/dgap.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff

[PATCH 5/7 RESEND] staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()

dgap_after_config_loaded() as function name doesn't tell what it does. Signed-off-by: Daeseok Youn --- resend: reordering this series of patches, becasue some patches are merged into one. drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 3/7 RESEND] staging: dgap: introduce dgap_tty_free() for freeing channels.

It should be called after dgap_tty_register_ports() is failed. So channels which are allocated in dgap_tty_init() will be freed. Signed-off-by: Daeseok Youn --- resend: reordering this series of patches drivers/staging/dgap/dgap.c | 17 - 1 files changed, 16 insertions(+), 1

[PATCH 2/7 RESEND] staging: dgap: get rid of brd->firstminor because it is 0

firstminor in struct borad_t is always zero, so it can be removed. Signed-off-by: Daeseok Youn --- resend: reordering this series of patches drivers/staging/dgap/dgap.c |9 - drivers/staging/dgap/dgap.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 1/7 RESEND] staging: dgap: remove unused paramter in dgap_parsefile()

"remove" parameter is not used in dgap_parsefile(). Signed-off-by: Daeseok Youn --- resend: reorder this series of patches drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dg

Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

2014-06-13 17:38 GMT+09:00 Dan Carpenter : > On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote: >> Hi, Dan >> >> >> >> 2014-06-13 17:00 GMT+09:00 Dan Carpenter : >> > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote: >> >&g

Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

Hi, Dan 2014-06-13 17:00 GMT+09:00 Dan Carpenter : > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote: >> dgap_tty_unregister() will unregister serial_driver >> and print_driver, and also free related variables. >> > > Introducing a static function withou

[PATCH 9/9] staging: dgap: introduce dgap_release_remap()

The dgap_found_board() did request some memory region and call ioremap, these should be released and unmaped when one of functions which are called after dgap_found_board() in dgap_init_one() is failed. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 14 +++--- 1 files

[PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

The dgap_firmware_load() has a lot of stuff beside loding firmware. So some registering and initializing for device are moved into dgap_init_one(). And also adds unwinding on error in dgap_init_one(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 81

[PATCH 7/9] staging: dgap: introduce dgap_free_flipbuf()

dgap_free_flipbuf() will free flipbuf and flipflagbuf which are allocated in dgap_alloc_flipbuf() Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c

[PATCH 6/9] staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()

dgap_after_config_loaded() as function name doesn't tell what it does. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 4ea7a33..db8c93b

[PATCH 4/9] staging: dgap: introduce dgap_free_irq()

dgap_free_irq() will free the irq which is requested in dgap_request_irq(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index eab8fd5

[PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

dgap_tty_unregister() will unregister serial_driver and print_driver, and also free related variables. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH 3/9] staging: dgap: introduce dgap_tty_free() for freeing channels.

It should be called after dgap_tty_register_ports() is failed. So channels which are allocated in dgap_tty_init() will be freed. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/staging

[PATCH 2/9] staging: dgap: get rid of brd->firstminor because it is 0

firstminor in struct borad_t is always zero, so it can be removed. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |9 - drivers/staging/dgap/dgap.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging

[PATCH 1/9] staging: dgap: remove unused paramter in dgap_parsefile()

"remove" parameter is not used in dgap_parsefile(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 38749d0..c1f2798 100644 ---

[PATCH 1/9] staging: dgap: remove unused paramter in dgap_parsefile()

remove parameter is not used in dgap_parsefile(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 38749d0..c1f2798

[PATCH 2/9] staging: dgap: get rid of brd-firstminor because it is 0

firstminor in struct borad_t is always zero, so it can be removed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |9 - drivers/staging/dgap/dgap.h |1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c

[PATCH 3/9] staging: dgap: introduce dgap_tty_free() for freeing channels.

It should be called after dgap_tty_register_ports() is failed. So channels which are allocated in dgap_tty_init() will be freed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff

[PATCH 4/9] staging: dgap: introduce dgap_free_irq()

dgap_free_irq() will free the irq which is requested in dgap_request_irq(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

dgap_tty_unregister() will unregister serial_driver and print_driver, and also free related variables. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 6/9] staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()

dgap_after_config_loaded() as function name doesn't tell what it does. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index

[PATCH 8/9] staging: dgap: cleanup dgap_firmware_load() function

The dgap_firmware_load() has a lot of stuff beside loding firmware. So some registering and initializing for device are moved into dgap_init_one(). And also adds unwinding on error in dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 81

[PATCH 7/9] staging: dgap: introduce dgap_free_flipbuf()

dgap_free_flipbuf() will free flipbuf and flipflagbuf which are allocated in dgap_alloc_flipbuf() Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 9/9] staging: dgap: introduce dgap_release_remap()

The dgap_found_board() did request some memory region and call ioremap, these should be released and unmaped when one of functions which are called after dgap_found_board() in dgap_init_one() is failed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 14

Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

Hi, Dan 2014-06-13 17:00 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote: dgap_tty_unregister() will unregister serial_driver and print_driver, and also free related variables. Introducing a static function without a caller

Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()

2014-06-13 17:38 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote: Hi, Dan 2014-06-13 17:00 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote: dgap_tty_unregister

[PATCH 1/7 RESEND] staging: dgap: remove unused paramter in dgap_parsefile()

remove parameter is not used in dgap_parsefile(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- resend: reorder this series of patches drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging

[PATCH 2/7 RESEND] staging: dgap: get rid of brd-firstminor because it is 0

firstminor in struct borad_t is always zero, so it can be removed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- resend: reordering this series of patches drivers/staging/dgap/dgap.c |9 - drivers/staging/dgap/dgap.h |1 - 2 files changed, 4 insertions(+), 6 deletions

[PATCH 3/7 RESEND] staging: dgap: introduce dgap_tty_free() for freeing channels.

It should be called after dgap_tty_register_ports() is failed. So channels which are allocated in dgap_tty_init() will be freed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- resend: reordering this series of patches drivers/staging/dgap/dgap.c | 17 - 1 files changed

[PATCH 5/7 RESEND] staging: dgap: rename dgap_after_config_loaded() to dgap_alloc_flipbuf()

dgap_after_config_loaded() as function name doesn't tell what it does. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- resend: reordering this series of patches, becasue some patches are merged into one. drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3

[PATCH 4/7 RESEND] staging: dgap: introduce dgap_free_irq()

dgap_free_irq() will free the irq which is requested in dgap_request_irq(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- resend: reordering this series of patches, because some patches are merged to one. drivers/staging/dgap/dgap.c | 10 -- 1 files changed, 8 insertions

[PATCH 6/7] staging: dgap: move unrelated functions in dgap_firmware_load()

The dgap_firmware_load() has a lot of stuff which are unrelated with loading firmware. So just moved to dgap_init_one(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 70 --- 1 files changed, 39 insertions(+), 31

[PATCH 7/7] staging: dgap: unwind on error in dgap_init_one()

region and unmapped memory. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 53 +++--- 1 files changed, 44 insertions(+), 9 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 2ccbd54

[PATCH 2/4 V2] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

Pass "brd" to dgap_after_config_loaded() instead of passing "dgap_numboards" and looking up brd again. Signed-off-by: Daeseok Youn --- V2: replace "dgap_board[board]->" with "brd->". drivers/staging/dgap/dgap.c | 18 +- 1 files

Re: [PATCH 2/4] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

2014-06-03 16:22 GMT+09:00 Dan Carpenter : > On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote: >> -static int dgap_after_config_loaded(int board) >> +static int dgap_after_config_loaded(struct board_t *brd) >> { >> + int board = brd->boardnum; >&g

[PATCH 4/4] staging: dgap: rename dgap_tty_uninit() to dgap_cleanup_tty()

- dgap_tty_uninit() doesn't match dgap_tty_init() at all. so rename it. It is just used for cleanup when this module is exited or failed to initialize by dgap_init_module. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions

[PATCH 3/4] staging: dgap: rename dgap_finalize_board_init() to dgap_request_irq()

Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 7a07a9b..b331108 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c

[PATCH 2/4] staging: dgap: pass "brd" as a paramter to dgap_after_config_loaded()

Pass "brd" to dgap_after_config_loaded() instead of passing "dgap_numboards" and looking up brd again. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/

[PATCH 1/4] staging: dgap: pass "dgap_numboards" as a paramter to dgap_found_board()

- Pass "dgap_numboards" to dgap_found_board() instead of using a global variable. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dg

[PATCH 1/4] staging: dgap: pass dgap_numboards as a paramter to dgap_found_board()

- Pass dgap_numboards to dgap_found_board() instead of using a global variable. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging

[PATCH 2/4] staging: dgap: pass brd as a paramter to dgap_after_config_loaded()

Pass brd to dgap_after_config_loaded() instead of passing dgap_numboards and looking up brd again. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 4/4] staging: dgap: rename dgap_tty_uninit() to dgap_cleanup_tty()

- dgap_tty_uninit() doesn't match dgap_tty_init() at all. so rename it. It is just used for cleanup when this module is exited or failed to initialize by dgap_init_module. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 1 files changed, 4

[PATCH 3/4] staging: dgap: rename dgap_finalize_board_init() to dgap_request_irq()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 7a07a9b..b331108 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers

Re: [PATCH 2/4] staging: dgap: pass brd as a paramter to dgap_after_config_loaded()

2014-06-03 16:22 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote: -static int dgap_after_config_loaded(int board) +static int dgap_after_config_loaded(struct board_t *brd) { + int board = brd-boardnum; + We don't need

[PATCH 2/4 V2] staging: dgap: pass brd as a paramter to dgap_after_config_loaded()

Pass brd to dgap_after_config_loaded() instead of passing dgap_numboards and looking up brd again. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: replace dgap_board[board]- with brd-. drivers/staging/dgap/dgap.c | 18 +- 1 files changed, 9 insertions(+), 9

Re: [PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

2014-06-02 19:13 GMT+09:00 Dan Carpenter : > On Mon, Jun 02, 2014 at 06:35:15PM +0900, DaeSeok Youn wrote: >> Hi, Dan. >> >> 2014-06-02 16:30 GMT+09:00 Dan Carpenter : >> > On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote: >> >>

Re: [PATCH 2/6 RESEND V2] staging: dgap: unwind on error in dgap_found_board()

2014-06-02 17:00 GMT+09:00 Dan Carpenter : > On Mon, Jun 02, 2014 at 02:14:47PM +0900, Daeseok Youn wrote: >> Adds a label for "kfree(brd)". And also remove >> a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. >> Because "brd"

Re: [PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

Hi, Dan. 2014-06-02 16:30 GMT+09:00 Dan Carpenter : > On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote: >> The dgap_probe1() function is just calling dgap_found_board(). >> So it is removed and dgap_found_board() is called directly. >> >> Signed-off-by: Dae

Re: [PATCH] staging: vt6655: replace C99 style comments

Hi, Please check below line comments. 2014-06-02 12:06 GMT+09:00 James A Shackleford : > Signed-off-by: James A Shackleford > --- > drivers/staging/vt6655/baseband.c | 300 > ++--- > 1 file changed, 150 insertions(+), 150 deletions(-) > > diff --git

Re: [PATCH] staging: vt6655: replace C99 style comments

Hi, Please check below line comments. 2014-06-02 12:06 GMT+09:00 James A Shackleford sh...@linux.com: Signed-off-by: James A Shackleford sh...@linux.com --- drivers/staging/vt6655/baseband.c | 300 ++--- 1 file changed, 150 insertions(+), 150 deletions(-)

Re: [PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

Hi, Dan. 2014-06-02 16:30 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote: The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn

Re: [PATCH 2/6 RESEND V2] staging: dgap: unwind on error in dgap_found_board()

2014-06-02 17:00 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Jun 02, 2014 at 02:14:47PM +0900, Daeseok Youn wrote: Adds a label for kfree(brd). And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because brd will free after failure. Signed-off

Re: [PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

2014-06-02 19:13 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Jun 02, 2014 at 06:35:15PM +0900, DaeSeok Youn wrote: Hi, Dan. 2014-06-02 16:30 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote: The dgap_probe1

[PATCH 2/6 RESEND V2] staging: dgap: unwind on error in dgap_found_board()

Adds a label for "kfree(brd)". And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because "brd" will free after failure. Signed-off-by: Daeseok Youn Reviewed-by: Dan Carpenter --- RESEND: this patch is included into newly series of patche

[PATCH 6/6] staging: dgap: make dgap_config_buf a local buffer

The dgap_config_buf is only used in dgap_firmware_load(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 3e716fe..c78c8e2 100644 --- a/drivers

[PATCH 5/6] staging: dgap: unwind on error in dgap_tty_register_ports()

- The dgap_tty_register_ports() needs to handle if the tty_port_register_device() fails. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 44 +- 1 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH 4/6] staging: dgap: unwind on error in dgap_tty_init()

If the kzalloc() fails for channels, it need to handle that error. It should free channels which were already allocated. And also removes the call to dgap_tty_uninit() in dgap_firmware_load(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 18 +- 1 files

[PATCH 3/6] staging: dgap: remove bogus null test in dgap_tty_init()

- The channels array were set to NULL in dgap_found_board(). - Removes redundant null check for channels array in for loop, if one of the channel cannot be allocated, dgap_tty_init() just returns an error. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 13 - 1 files

[PATCH 2/6 RESEND] staging: dgap: unwind on error in dgap_found_board()

Adds a label for "kfree(brd)". And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because "brd" will free after failure. Signed-off-by: Daeseok Youn --- RESEND: this patch is included into newly series of patches. drivers/stagin

[PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn --- RESEND : this patch is included into newly serise of patches so renumbered and resend. drivers/staging/dgap/dgap.c |8 +--- 1 files

[PATCH 1/6 RESEND] staging: dgap: remove useless dgap_probe1() function

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND : this patch is included into newly serise of patches so renumbered and resend. drivers/staging/dgap/dgap.c

[PATCH 2/6 RESEND] staging: dgap: unwind on error in dgap_found_board()

Adds a label for kfree(brd). And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because brd will free after failure. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: this patch is included into newly series of patches. drivers/staging/dgap/dgap.c

[PATCH 3/6] staging: dgap: remove bogus null test in dgap_tty_init()

- The channels array were set to NULL in dgap_found_board(). - Removes redundant null check for channels array in for loop, if one of the channel cannot be allocated, dgap_tty_init() just returns an error. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 13

[PATCH 4/6] staging: dgap: unwind on error in dgap_tty_init()

If the kzalloc() fails for channels, it need to handle that error. It should free channels which were already allocated. And also removes the call to dgap_tty_uninit() in dgap_firmware_load(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 18

[PATCH 5/6] staging: dgap: unwind on error in dgap_tty_register_ports()

- The dgap_tty_register_ports() needs to handle if the tty_port_register_device() fails. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 44 +- 1 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 6/6] staging: dgap: make dgap_config_buf a local buffer

The dgap_config_buf is only used in dgap_firmware_load(). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 3e716fe

[PATCH 2/6 RESEND V2] staging: dgap: unwind on error in dgap_found_board()

Adds a label for kfree(brd). And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because brd will free after failure. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com Reviewed-by: Dan Carpenter dan.carpen...@oracle.com --- RESEND: this patch is included

[PATCH 2/2] staging: dgap: unwind on error in dgap_found_board()

Adds a label for "kfree(brd)". And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because "brd" will free after failure. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 19 ++- 1 files changed, 14 insert

[PATCH 1/2] staging: dgap: remove useless dgap_probe1() function

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b

[PATCH] Revert "staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()"

This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579. This patch removes kfree for serial_ports in dgap_tty_register_ports() if the "brd->printer_ports" allocation fails and serial_ports may be freed by calling dgap_tty_uninit() within other patch. That patch has an error handling but

[PATCH] Revert staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()

This reverts commit 0ade4a34fd439d62df46937e8f3e584eb0879579. This patch removes kfree for serial_ports in dgap_tty_register_ports() if the brd-printer_ports allocation fails and serial_ports may be freed by calling dgap_tty_uninit() within other patch. That patch has an error handling but

[PATCH 1/2] staging: dgap: remove useless dgap_probe1() function

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 2/2] staging: dgap: unwind on error in dgap_found_board()

Adds a label for kfree(brd). And also remove a state value as BOARD_FAILED in brd when dgap_do_remap() is failed. Because brd will free after failure. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 19 ++- 1 files changed, 14 insertions

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

Hi, Dan. 2014-05-28 19:11 GMT+09:00 Dan Carpenter : > On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote: >> > In your patch it has: >> > + dgap_tty_uninit(brd, false); >> > >> > But it should only be "false" if dgap_tty_init()

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

dgap_tty_register(). Can I call some functions for cleanup allocated resource from the earlier function in dgap_tty_init() with goto label? > > To be honest, I think once dgap the code is cleaned up this error > handling will be easy to write. We shouldn't have things like: > brd-&

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

Hi, Dan. 2014-05-28 19:11 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote: In your patch it has: + dgap_tty_uninit(brd, false); But it should only be false if dgap_tty_init() failed. If dgap_tty_register_ports

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

-dgap_major_serial_registered = TRUE; because we will know which order things were registered and unregister them in the reverse order. OK. I will look at the code with your comment. Really thanks for kind explanation. regards, Daeseok Youn regards, dan carpenter -- To unsubscribe from this list: send the line

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

t;i == 1 && (4*i+1)" statement is same as 5, so it seems to be "if (wrqu->encoding.length == 5)". Once mask value is set to zero, it doesn't need to set anymore. (I don't know what the "5" means :-) ) It is just my opinion. regards, Daeseok Youn > > T

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

et me know. Thanks. regards, Daeseok Youn. > > It's not actually that hard. The only error handling we need to do in > dgap_tty_init() is if the kzalloc() fails: > > 1374 /* > 1375 * Allocate channel memory that might not have been allocated > 1376

[PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

whether tty's ports are registered. Signed-off-by: Daeseok Youn --- V2: remove "brd->nasync = 0" for avoiding to call some destroyer for unregistering tty's ports. I'm not sure about add a parameter in dgap_tty_uninit() for checking whether tty's ports are registered. please review this

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey : > Fixed the following: > > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: need consistent spacing around '*' (ctx:WxV) > ERROR: need consistent spacing around '|' (ctx:VxW) > ERROR: space prohibited after

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey c...@24.io: Fixed the following: ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '|' (ctx:VxW) ERROR: space prohibited

[PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

whether tty's ports are registered. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2: remove brd-nasync = 0 for avoiding to call some destroyer for unregistering tty's ports. I'm not sure about add a parameter in dgap_tty_uninit() for checking whether tty's ports are registered. please

Re: [PATCH V2] staging: dgap: implement proper error handling in dgap_firmware_load()

. Thanks. regards, Daeseok Youn. It's not actually that hard. The only error handling we need to do in dgap_tty_init() is if the kzalloc() fails: 1374 /* 1375 * Allocate channel memory that might not have been allocated 1376 * when the driver was first loaded

<    2   3   4   5   6   7   8   9   10   11   >