to zero, it
doesn't need to set anymore. (I don't know what the 5 means :-) )
It is just my opinion.
regards,
Daeseok Youn
Thanks,
Chaitanya
On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn daeseok.y...@gmail.com wrote:
Hi,
2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey c...@24.io:
Fixed
Hi, Dan
2014-05-26 19:50 GMT+09:00 Dan Carpenter :
> On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote:
>> When dgap_tty_init() and dgap_tty_register_ports() are failed,
>> these are needed to free some memory properly.
>>
>> It can be handled
If printer_ports which is allocated after serial_ports is failed
to allocate, tty_port_init for serial_ports doesn't need anymore.
So move this after allocating memory for printer_ports.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |6 +++---
1 files changed, 3 insertions
When it failed to allocate for printer_ports, serial_ports
can be freed in dgap_tty_uninit().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index
off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 60b7d70..db24f70 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dga
In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 1475532
In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap
-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c | 21 -
1 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 60b7d70..db24f70 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers
When it failed to allocate for printer_ports, serial_ports
can be freed in dgap_tty_uninit().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers
If printer_ports which is allocated after serial_ports is failed
to allocate, tty_port_init for serial_ports doesn't need anymore.
So move this after allocating memory for printer_ports.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/dgap/dgap.c |6 +++---
1 files
Hi, Dan
2014-05-26 19:50 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Mon, May 26, 2014 at 07:23:47PM +0900, Daeseok Youn wrote:
When dgap_tty_init() and dgap_tty_register_ports() are failed,
these are needed to free some memory properly.
It can be handled by calling dgap_tty_uninit
be called when uio_register_device() is failed. So it is moved
into handling error for uio_register_device().
Signed-off-by: Daeseok Youn
---
drivers/uio/uio_dmem_genirq.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/u
into handling error for uio_register_device().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/uio/uio_dmem_genirq.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
index 1270f3b..8d0bba4
I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114
Regards,
Daeseok Youn.
2014-05-21 6:48 GMT+09:00 Dan Carpenter :
> On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
>> There is otherwise a risk of a possible null pointer dereference.
>>
I was already sent for this. :-)
https://lkml.org/lkml/2014/5/16/114
Regards,
Daeseok Youn.
2014-05-21 6:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Tue, May 20, 2014 at 11:28:59PM +0200, Rickard Strandqvist wrote:
There is otherwise a risk of a possible null pointer dereference
are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn
---
V2: rebased on staging-next branch
V3: removes unneeded information in e-mail
V4: removes labels for kfree() calls
2014-05-19 18:39 GMT+09:00 DaeSeok Youn :
> 2014-05-19 17:02 GMT+09:00 Dan Carpenter :
>> Nice, but it needs a couple style improvements below.
>>
>> On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
>>> + brd->dgap_major_serial_registered = TRUE;
&
2014-05-19 17:02 GMT+09:00 Dan Carpenter :
> Nice, but it needs a couple style improvements below.
>
> On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
>> + brd->dgap_major_serial_registered = TRUE;
>> + dgap_boards_by_major[brd->serial_driver-
2014-05-19 17:02 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Nice, but it needs a couple style improvements below.
On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
+ brd-dgap_major_serial_registered = TRUE;
+ dgap_boards_by_major[brd-serial_driver-major] = brd
2014-05-19 18:39 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
2014-05-19 17:02 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Nice, but it needs a couple style improvements below.
On Mon, May 19, 2014 at 11:10:30AM +0900, Daeseok Youn wrote:
+ brd-dgap_major_serial_registered = TRUE
are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: rebased on staging-next branch
V3: removes unneeded information in e-mail
V4: removes
are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn
---
V2: rebased on staging-next branch
V3: removes unneeded information in e-mail
drivers/staging/dgap/dgap.c | 49
>From 3acdda98e73a153a5fb32c2cd401d2dde1653b0a Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 25 Apr 2014 16:04:59 +0900
Subject: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Point
From 3acdda98e73a153a5fb32c2cd401d2dde1653b0a Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 25 Apr 2014 16:04:59 +0900
Subject: [PATCH] staging: dgap: implement error handling in dgap_tty_register()
- alloc_tty_driver() is deprecated so it is changed
are registered normally, and
then set TRUE to dgap_major_serial{print}_registered. If one
of drivers is failed to register, leave a default value as
FALSE.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: rebased on staging-next branch
V3: removes unneeded information in e-mail
drivers
2014-05-17 8:09 GMT+09:00, Greg KH :
> On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
>> - alloc_tty_driver() is deprecated so it is changed to
>> tty_alloc_driver()
>> - Pointers which are allocated by alloc_tty_driver() and kzalloc()
>> can be NU
2014-05-17 8:09 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need
2014-05-16 18:52 GMT+09:00 Dan Carpenter :
> On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> This patch haven't been updated over the past 3 weeks.
>> Will you check for me?
>
> Greg was trying to travel around the world in on
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Regards,
Daeseok Youn.
2014-04-28 8:21 GMT+09:00 DaeSeok Youn :
> OK. I'll make my patch based on Mark's patch.
> Thanks.
>
> Daeseok Youn.
>
> 2014-04-27 3:48 GMT+09:00 Dan Carpenter :
>&
It doesn't need to check "err" for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn
---
V2: removes unneeded lines for sending a patch
drivers/video/fbdev/i810/i810_main.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git
The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So "devs" cannot be NULL, removes NULL check for "devs".
Signed-off-by: Daeseok Youn
---
V2: remove unneeded lines for sending a patch.
drivers/staging/ozwpan/ozprot
Hi, Dan
2014-05-16 18:03 GMT+09:00 Dan Carpenter :
> On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
>> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Fri, 16 May 2014 17:02:04 +0900
>> Subject: [
>From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as
From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
The devs is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default
Hi, Dan
2014-05-16 18:03 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 16 May 2014 17:02:04 +0900
The devs is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So devs cannot be NULL, removes NULL check for devs.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: remove unneeded lines for sending a patch.
drivers/staging/ozwpan/ozproto.c |2 +-
1
It doesn't need to check err for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: removes unneeded lines for sending a patch
drivers/video/fbdev/i810/i810_main.c |7 +++
1 files changed, 3 insertions(+), 4 deletions
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Regards,
Daeseok Youn.
2014-04-28 8:21 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen
2014-05-16 18:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 16, 2014 at 06:40:28PM +0900, DaeSeok Youn wrote:
Hi,
This patch haven't been updated over the past 3 weeks.
Will you check for me?
Greg was trying to travel around the world in one month like Jackie
Chan
>From 060757f81f85babf393cc76714d49af25af7791d Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Thu, 15 May 2014 16:51:35 +0900
Subject: [PATCH] video : remove redundant error check
It doesn't need to check "err" for printing info.
And also use pr_info instead of printk.
Signed-of
From 060757f81f85babf393cc76714d49af25af7791d Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 15 May 2014 16:51:35 +0900
Subject: [PATCH] video : remove redundant error check
It doesn't need to check err for printing info.
And also use pr_info instead of printk
Removes "#if 0" blocks.
And the musycc_dump_rxbuffer_ring(ch, 0) which is commented
out puts in RLD_DEBUG block and uncommented.
Because this function may be used for debugging.
Signed-off-by: Daeseok Youn
---
V2 : fix the changelog, added a log that musycc_dump_rxbuffer_ring()
is u
2014-05-09 23:15 GMT+09:00, Dan Carpenter :
> On Fri, May 09, 2014 at 11:09:35PM +0900, DaeSeok Youn wrote:
>> 2014-05-09 19:51 GMT+09:00, Dan Carpenter :
>> > On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
>> >> Removes "#if 0" blocks.
2014-05-09 19:51 GMT+09:00, Dan Carpenter :
> On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
>> Removes "#if 0" blocks.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> Dan,
>> I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is
2014-05-09 19:42 GMT+09:00, Dan Carpenter :
> On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warning:
>> WARNING: please no spaces at the start of a line in
>>
>> Signed-off-by: Daeseok Youn
>> ---
>
>&
Signed-off-by: Daeseok Youn
---
I'm not sure about removing "RLD_DUMP_BUFDATA" and "RLD_DEBUG"
definitions.
I think these can be defined temporarily by developer who want to debugging
this module.
drivers/staging/cxt1e1/musycc.c | 211 +++-
clean up checkpatch.pl warning:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c | 312 ---
1 files changed, 196 insertions(+), 116 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers
cleanup checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1/musycc.c
index
Removes "#if 0" blocks.
Signed-off-by: Daeseok Youn
---
Dan,
I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
out and make a block as "RLD_DEBUG". Because i think this block need to debug
with define "RLD_DEBUG". If I am wrong, let me
2014-05-09 17:07 GMT+09:00 Dan Carpenter :
> This patch is ok, but here are some additional hints.
>
> On Fri, May 09, 2014 at 10:39:48AM +0900, Daeseok Youn wrote:
>> @@ -1100,7 +1102,9 @@ musycc_bh_rx_eom(mpi_t *pi, int gchan)
>>*/
>>
2014-05-09 16:59 GMT+09:00 Dan Carpenter :
> On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warning:
>> WARNING: please no spaces at the start of a line in
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> This patch
2014-05-09 16:59 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warning:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch includes
2014-05-09 17:07 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
This patch is ok, but here are some additional hints.
On Fri, May 09, 2014 at 10:39:48AM +0900, Daeseok Youn wrote:
@@ -1100,7 +1102,9 @@ musycc_bh_rx_eom(mpi_t *pi, int gchan
Removes #if 0 blocks.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
Dan,
I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
out and make a block as RLD_DEBUG. Because i think this block need to debug
with define RLD_DEBUG. If I am wrong, let me know.
drivers
clean up checkpatch.pl warning:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c | 312 ---
1 files changed, 196 insertions(+), 116 deletions(-)
diff --git a/drivers/staging
cleanup checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
I'm not sure about removing RLD_DUMP_BUFDATA and RLD_DEBUG
definitions.
I think these can be defined temporarily by developer who want to debugging
this module.
drivers/staging/cxt1e1/musycc.c | 211
2014-05-09 19:42 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:02:20PM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warning:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
-#ifdef
2014-05-09 19:51 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
Removes #if 0 blocks.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
Dan,
I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
out
2014-05-09 23:15 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 11:09:35PM +0900, DaeSeok Youn wrote:
2014-05-09 19:51 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
Removes #if 0 blocks.
Signed
Removes #if 0 blocks.
And the musycc_dump_rxbuffer_ring(ch, 0) which is commented
out puts in RLD_DEBUG block and uncommented.
Because this function may be used for debugging.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2 : fix the changelog, added a log
cleanup checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1/musycc.c
index
clean up checkpatch.pl warning
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/musycc.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1
smatch says:
drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn:
possible memory leak of 'dev'
Signed-off-by: Daeseok Youn
---
V2: use the same pattern for error handling.
drivers/media/usb/s2255/s2255drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
smatch says:
drivers/media/usb/s2255/s2255drv.c:2246 s2255_probe() warn:
possible memory leak of 'dev'
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: use the same pattern for error handling.
drivers/media/usb/s2255/s2255drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
clean up checkpatch.pl warning
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b
cleanup checkpatch.pl error:
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/musycc.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging
Signed-off-by: Daeseok Youn
---
drivers/staging/bcm/InterfaceDld.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceDld.c
b/drivers/staging/bcm/InterfaceDld.c
index 005e460..e1925bd 100644
--- a/drivers/staging/bcm/InterfaceDld.c
+++ b
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/bcm/InterfaceDld.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceDld.c
b/drivers/staging/bcm/InterfaceDld.c
index 005e460..e1925bd 100644
--- a/drivers/staging/bcm
Hello,
2014-05-05 17:38 GMT+09:00 Sakari Ailus :
> On Tue, Apr 15, 2014 at 07:54:43PM +0900, DaeSeok Youn wrote:
>> Hi, Sakari
>>
>> 2014-04-15 18:33 GMT+09:00 Sakari Ailus :
>> > Hi Daeseok,
>> >
>> > On Tue, Apr 15, 2014 at 01:49:34PM +0
Hello,
2014-05-05 17:38 GMT+09:00 Sakari Ailus sakari.ai...@iki.fi:
On Tue, Apr 15, 2014 at 07:54:43PM +0900, DaeSeok Youn wrote:
Hi, Sakari
2014-04-15 18:33 GMT+09:00 Sakari Ailus sakari.ai...@iki.fi:
Hi Daeseok,
On Tue, Apr 15, 2014 at 01:49:34PM +0900, Daeseok Youn wrote:
smatch
2014-05-01 6:19 GMT+09:00, Andrew Morton :
> On Tue, 29 Apr 2014 11:53:10 +0900 Daeseok Youn
> wrote:
>
>> "dev" cannot be NULL because it is already checked before
>> calling dma_pool_create().
>>
>> Signed-off-by: Daeseok Youn
>> ---
&g
2014-05-01 6:19 GMT+09:00, Andrew Morton a...@linux-foundation.org:
On Tue, 29 Apr 2014 11:53:10 +0900 Daeseok Youn daeseok.y...@gmail.com
wrote:
dev cannot be NULL because it is already checked before
calling dma_pool_create().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
"dev" and "net" are NULL when alloc_netdev() is failed.
So just unlock and return an error.
Signed-off-by: Daeseok Youn
---
drivers/firewire/net.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
in
smatch says:
skd_acquire_msix() info: redundant null check
on entries calling kfree()
Signed-off-by: Daeseok Youn
---
drivers/block/skd_main.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 608532d..fac4c08
smatch says:
skd_acquire_msix() info: redundant null check
on entries calling kfree()
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/block/skd_main.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
dev and net are NULL when alloc_netdev() is failed.
So just unlock and return an error.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/firewire/net.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index
"dev" cannot be NULL because it is already checked before
calling dma_pool_create().
Signed-off-by: Daeseok Youn
---
If dev can be NULL, it has NULL deferencing when kmalloc_node()
is called after enabling CONFIG_NUMA.
mm/dmapool.c | 26 +-
1 files
dev cannot be NULL because it is already checked before
calling dma_pool_create().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
If dev can be NULL, it has NULL deferencing when kmalloc_node()
is called after enabling CONFIG_NUMA.
mm/dmapool.c | 26 +-
1 files
t; @@ -287,7 +287,7 @@ c4_hdw_init(struct pci_dev *pdev, int found)
> return 1;
> }
>
> -status_t __init
> +static status_t __init
> c4hw_attach_all(void)
This function is used in "linux.c"
> {
> hdw_info_t *hi;
And when you send a pa
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter :
> On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> please check below my comments.
>>
>> 2014-04-25 23:41 GMT+09:00 Mark Houn
OK. I'll make my patch based on Mark's patch.
Thanks.
Daeseok Youn.
2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote:
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell ma
;
And when you send a patch for this, please check maintainers with
./scripts/get_maintainer.pl.
In case of this patch, my email is in CC list. :-)
Regards,
Daeseok Youn.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell :
> On 04/25/2014 08:59 AM, Dan Carpenter wrote:
>> On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
>>> On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
>>>> Hi, Dan.
>&g
2014-04-26 7:33 GMT+09:00, Greg KH :
> On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
>>
>> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> drivers/staging/silicom/bpctl_mo
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Dan Carpenter :
> Mark, maybe you should add yourself to the MAINTAINERS entry for this
> driver?
>
> On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
>> @@ -1263,7 +1277,8 @@ static int dgap_tty_register(s
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
Signed-off-by: Daeseok
- alloc_tty_driver() is deprecated so it is changed to
tty_alloc_driver()
- Pointers which are allocated by alloc_tty_driver() and kzalloc()
can be NULL so it need to check NULL for them.
- If one of those is failed, it need to add proper handler for
avoiding memory leak.
Signed-off-by: Daeseok
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
Mark, maybe you should add yourself to the MAINTAINERS entry for this
driver?
On Fri, Apr 25, 2014 at 04:04:59PM +0900, Daeseok Youn wrote:
@@ -1263,7 +1277,8 @@ static int dgap_tty_register(struct board_t *brd
2014-04-26 7:33 GMT+09:00, Greg KH gre...@linuxfoundation.org:
On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/silicom/bpctl_mod.c |5
Hi,
please check below my comments.
2014-04-25 23:41 GMT+09:00 Mark Hounschell ma...@compro.net:
On 04/25/2014 08:59 AM, Dan Carpenter wrote:
On Fri, Apr 25, 2014 at 08:29:41AM -0400, Mark Hounschell wrote:
On 04/25/2014 07:02 AM, DaeSeok Youn wrote:
Hi, Dan.
2014-04-25 18:26 GMT+09:00 Dan
2014-04-23 17:35 GMT+09:00, Dan Carpenter :
> On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
>> The pci_get_drvdata() and checking NULL for dev are
>> called twice in while loop in is_bypass_dev().
>>
>> Signed-off-by: Daeseok Youn
>> ---
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn
---
This patch has an warning from checkpatch.pl.
checkpatch.pl warning:
WARNING: Too many leading tabs - consider code refactoring
drivers/staging/silicom/bypasslib
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
This patch has an warning from checkpatch.pl.
checkpatch.pl warning:
WARNING: Too many leading tabs - consider code refactoring
drivers
2014-04-23 17:35 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Wed, Apr 23, 2014 at 05:18:42PM +0900, Daeseok Youn wrote:
The pci_get_drvdata() and checking NULL for dev are
called twice in while loop in is_bypass_dev().
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Hello,
2014-04-17 9:00 GMT+09:00 DaeSeok Youn :
> Hello,
>
> 2014-04-16 21:38 GMT+09:00 Jean-Christophe PLAGNIOL-VILLARD
> :
>>
>> On Apr 16, 2014, at 5:40 PM, Daeseok Youn wrote:
>>
>>>
>>> The spec->modedb can be NULL by fb_create_modedb().
&g
Hello,
2014-04-17 9:00 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com:
Hello,
2014-04-16 21:38 GMT+09:00 Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com:
On Apr 16, 2014, at 5:40 PM, Daeseok Youn daeseok.y...@gmail.com wrote:
The spec-modedb can be NULL by fb_create_modedb
Replace OS_kmalloc/OS_kfree with kzalloc/kfree.
And also some allocation doesn't need to use GFP_DMA
so just use GFP_KERNEL.
c4_new() function is never called, remove it.
Signed-off-by: Daeseok Youn
---
V4: update patch description, OS_kmalloc should be replaced with
kzalloc for zeroed out
by removing the conditional.
This doesn't make any functional difference.
Signed-off-by: Daeseok Youn
---
V2: update patch description and comment of code
kernel/workqueue.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index
by removing the conditional.
This doesn't make any functional difference.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: update patch description and comment of code
kernel/workqueue.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/workqueue.c b
701 - 800 of 1119 matches
Mail list logo
