[PATCH] scripts/recordmcount: support more than 64K ELF sections

2019-02-15 Thread Dan Aloni
here were taken from scripts/sortextable.c. Signed-off-by: Dan Aloni --- scripts/recordmcount.c | 5 ++ scripts/recordmcount.h | 106 - 2 files changed, 99 insertions(+), 12 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index a5

Re: [PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-28 Thread Dan Aloni
On Sun, Jan 28, 2018 at 03:43:48PM +0100, Greg KH wrote: > On Sat, Jan 27, 2018 at 10:07:41PM +0200, Dan Aloni wrote: > > commit cabfb3680f78 upstream. > > Are you sure? > $ gsr cabfb3680f78 > cabfb3680f78 ("CIFS: Enable encryption during session setup phase") >

Re: [PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-28 Thread Dan Aloni
On Sun, Jan 28, 2018 at 03:43:48PM +0100, Greg KH wrote: > On Sat, Jan 27, 2018 at 10:07:41PM +0200, Dan Aloni wrote: > > commit cabfb3680f78 upstream. > > Are you sure? > $ gsr cabfb3680f78 > cabfb3680f78 ("CIFS: Enable encryption during session setup phase") >

[PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-27 Thread Dan Aloni
to 4.9.x and older kernels. Signed-off-by: Dan Aloni <d...@kernelim.com> CC: Steve French <sfre...@samba.org> CC: sta...@vger.kernel.org # 4.4.x CC: linux-c...@vger.kernel.org CC: linux-kernel@vger.kernel.org [1] https://patchwork.kernel.org/patch/5106391/ [2] (temporary url) http://copr-di

[PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-27 Thread Dan Aloni
to 4.9.x and older kernels. Signed-off-by: Dan Aloni CC: Steve French CC: sta...@vger.kernel.org # 4.4.x CC: linux-c...@vger.kernel.org CC: linux-kernel@vger.kernel.org [1] https://patchwork.kernel.org/patch/5106391/ [2] (temporary url) http://copr-dist-git.fedorainfracloud.org/cgit/alonid/samba-for-c

Re: [PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-14 Thread Dan Aloni
On Sun, Jan 14, 2018 at 10:48:01AM +0900, Sergey Senozhatsky wrote: > Ccing Kees, Peter, Andrew, Steven > > On (01/13/18 23:34), Dan Aloni wrote: > > This commit enables the kernel to encrypt the free-form text that > > is generated by printk() before it is brought up to `dm

Re: [PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-14 Thread Dan Aloni
On Sun, Jan 14, 2018 at 10:48:01AM +0900, Sergey Senozhatsky wrote: > Ccing Kees, Peter, Andrew, Steven > > On (01/13/18 23:34), Dan Aloni wrote: > > This commit enables the kernel to encrypt the free-form text that > > is generated by printk() before it is brought up to `dm

[PATCHv2 6/7] tools: add dmesg decryption program

2018-01-13 Thread Dan Aloni
Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni <d...@kernelim.com> --- tools/Makefile | 9 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 354 +

[PATCHv2 0/7] RFC: Public key encryption of dmesg by the kernel

2018-01-13 Thread Dan Aloni
.) - checkpatch.pl linting [1] https://lwn.net/Articles/742412/ Dan Aloni (7): crypto: fix memory leak in rsa-kcs1pad encryption Move net/ceph/armor to lib/ and add docs base64-armor: add bounds checking certs: allow in-kernel access of trusted keys printk: allow kmsg to be encrypted using public key

[PATCHv2 3/7] base64-armor: add bounds checking

2018-01-13 Thread Dan Aloni
Future use of the API can benefit from bounds checking. Signed-off-by: Dan Aloni <d...@kernelim.com> --- include/linux/base64-armor.h | 17 +++-- lib/base64-armor.c | 20 ++-- net/ceph/crypto.c| 2 +- 3 files changed, 30 insertions

[PATCHv2 6/7] tools: add dmesg decryption program

2018-01-13 Thread Dan Aloni
Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni --- tools/Makefile | 9 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 354 4 files changed, 377

[PATCHv2 0/7] RFC: Public key encryption of dmesg by the kernel

2018-01-13 Thread Dan Aloni
.) - checkpatch.pl linting [1] https://lwn.net/Articles/742412/ Dan Aloni (7): crypto: fix memory leak in rsa-kcs1pad encryption Move net/ceph/armor to lib/ and add docs base64-armor: add bounds checking certs: allow in-kernel access of trusted keys printk: allow kmsg to be encrypted using public key

[PATCHv2 3/7] base64-armor: add bounds checking

2018-01-13 Thread Dan Aloni
Future use of the API can benefit from bounds checking. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 17 +++-- lib/base64-armor.c | 20 ++-- net/ceph/crypto.c| 2 +- 3 files changed, 30 insertions(+), 9 deletions(-) diff --git

[PATCHv2 2/7] Move net/ceph/armor to lib/ and add docs

2018-01-13 Thread Dan Aloni
Plus, add functions that assist in managing buffer bounds. Signed-off-by: Dan Aloni <d...@kernelim.com> --- include/linux/base64-armor.h | 65 ++ lib/Kconfig| 7 lib/Makefile | 1 + ne

[PATCHv2 2/7] Move net/ceph/armor to lib/ and add docs

2018-01-13 Thread Dan Aloni
Plus, add functions that assist in managing buffer bounds. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 65 ++ lib/Kconfig| 7 lib/Makefile | 1 + net/ceph/armor.c => lib/bas

[PATCHv2 1/7] crypto: fix memory leak in rsa-kcs1pad encryption

2018-01-13 Thread Dan Aloni
The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Dan Aloni <d...@kernelim.com> --- crypto/rsa-pkcs1pad.c | 9 - 1 fil

[PATCHv2 1/7] crypto: fix memory leak in rsa-kcs1pad encryption

2018-01-13 Thread Dan Aloni
The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu Signed-off-by: Dan Aloni --- crypto/rsa-pkcs1pad.c | 9 - 1 file changed, 9 deletions(-) diff --git a/crypto/rsa-pkcs1pad.c

[PATCHv2 4/7] certs: allow in-kernel access of trusted keys

2018-01-13 Thread Dan Aloni
CC: David Howells <dhowe...@redhat.com> Signed-off-by: Dan Aloni <d...@kernelim.com> --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system

[PATCHv2 4/7] certs: allow in-kernel access of trusted keys

2018-01-13 Thread Dan Aloni
CC: David Howells Signed-off-by: Dan Aloni --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system_keyring.c b/certs/system_keyring.c index

[PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-13 Thread Dan Aloni
kernel modules and userspace-supplied firmwares. CC: Petr Mladek <pmla...@suse.com> CC: Sergey Senozhatsky <sergey.senozhat...@gmail.com> CC: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Dan Aloni <d...@kernelim.com> --- Documentation/ioctl/ioctl-number.txt |

[PATCHv2 7/7] docs: add dmesg encryption doc

2018-01-13 Thread Dan Aloni
Reviewed-by: Randy Dunlap <rdun...@infradead.org> Signed-off-by: Dan Aloni <d...@kernelim.com> --- Documentation/admin-guide/dmesg-encryption.rst | 118 + Documentation/admin-guide/index.rst| 1 + 2 files changed, 119 insertions(+) create

[PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-13 Thread Dan Aloni
kernel modules and userspace-supplied firmwares. CC: Petr Mladek CC: Sergey Senozhatsky CC: Linus Torvalds Signed-off-by: Dan Aloni --- Documentation/ioctl/ioctl-number.txt | 1 + include/uapi/linux/kmsg.h| 18 ++ init/Kconfig | 11 + kernel/printk/printk.c

[PATCHv2 7/7] docs: add dmesg encryption doc

2018-01-13 Thread Dan Aloni
Reviewed-by: Randy Dunlap Signed-off-by: Dan Aloni --- Documentation/admin-guide/dmesg-encryption.rst | 118 + Documentation/admin-guide/index.rst| 1 + 2 files changed, 119 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst

Re: [kernel-hardening] [PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 10:42:49PM +0100, Jann Horn wrote: > On Sat, Dec 30, 2017 at 6:57 PM, Dan Aloni <d...@kernelim.com> wrote: > > From: Dan Aloni <d...@kernelim.com> > > > > Hi All, > > > > There has been a lot of progress in recent times regar

Re: [kernel-hardening] [PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 10:42:49PM +0100, Jann Horn wrote: > On Sat, Dec 30, 2017 at 6:57 PM, Dan Aloni wrote: > > From: Dan Aloni > > > > Hi All, > > > > There has been a lot of progress in recent times regarding the removal > > of sensitive information fr

Re: [PATCH 5/5] docs: add dmesg encryption doc

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 11:40:06AM -0800, Randy Dunlap wrote: > On 12/30/2017 09:58 AM, Dan Aloni wrote: > > From: Dan Aloni <d...@kernelim.com> > > > > Signed-off-by: Dan Aloni <d...@kernelim.com> > > --- > > Docume

Re: [PATCH 5/5] docs: add dmesg encryption doc

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 11:40:06AM -0800, Randy Dunlap wrote: > On 12/30/2017 09:58 AM, Dan Aloni wrote: > > From: Dan Aloni > > > > Signed-off-by: Dan Aloni > > --- > > Documentation/admin-guide/dmesg-encryption.rst | 77 > > ++

[PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> Hi All, There has been a lot of progress in recent times regarding the removal of sensitive information from dmesg (pointers, etc.), so I figured - why not encrypt it all? However, I have not found any existing discussions or references reg

[PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2017-12-30 Thread Dan Aloni
From: Dan Aloni Hi All, There has been a lot of progress in recent times regarding the removal of sensitive information from dmesg (pointers, etc.), so I figured - why not encrypt it all? However, I have not found any existing discussions or references regarding this technical direction. I am

[PATCH 4/5] tools: add dmesg decryption program

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni <d...@kernelim.com> --- tools/Makefile | 5 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-deci

[PATCH 2/5] certs: allow in-kernel access of trusted keys

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> Signed-off-by: Dan Aloni <d...@kernelim.com> --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system

[PATCH 4/5] tools: add dmesg decryption program

2017-12-30 Thread Dan Aloni
From: Dan Aloni Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni --- tools/Makefile | 5 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 316 4 files

[PATCH 2/5] certs: allow in-kernel access of trusted keys

2017-12-30 Thread Dan Aloni
From: Dan Aloni Signed-off-by: Dan Aloni --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system_keyring.c b/certs/system_keyring.c index 6251d1b27f0c

[PATCH 3/5] kernel/printk: allow kmsg to be encrypted using public key encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> This commit enables the kernel to encrypt the free-form text that is generated by printk() before it is brought up to `dmesg` in userspace. The encryption is made using one of the trusted public keys which are kept built-in inside the kernel. Thes

[PATCH 3/5] kernel/printk: allow kmsg to be encrypted using public key encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni This commit enables the kernel to encrypt the free-form text that is generated by printk() before it is brought up to `dmesg` in userspace. The encryption is made using one of the trusted public keys which are kept built-in inside the kernel. These keys are presently also used

[PATCH 5/5] docs: add dmesg encryption doc

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> Signed-off-by: Dan Aloni <d...@kernelim.com> --- Documentation/admin-guide/dmesg-encryption.rst | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst diff --git a/D

[PATCH 5/5] docs: add dmesg encryption doc

2017-12-30 Thread Dan Aloni
From: Dan Aloni Signed-off-by: Dan Aloni --- Documentation/admin-guide/dmesg-encryption.rst | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst diff --git a/Documentation/admin-guide/dmesg-encryption.rst b

[PATCH 1/5] crypto: fix memory leak in rsa-kcs1pad encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni <d...@kernelim.com> The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu <herb...@gondor.apana.org.au> Signed-off-by: Dan Aloni <d...@kernelim.com&g

[PATCH 1/5] crypto: fix memory leak in rsa-kcs1pad encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu Signed-off-by: Dan Aloni --- crypto/rsa-pkcs1pad.c | 9 - 1 file changed, 9 deletions(-) diff --git

Re: cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
On Wed, Dec 20, 2017 at 03:24:09PM -0800, Tejun Heo wrote: > On Thu, Dec 21, 2017 at 12:59:23AM +0200, Dan Aloni wrote: > > Hi, > > > > Using netconsole, I was able to capture a hard lockup that seems to be > > related to cgroups, on a Fedora kernel based on v4.14.4. &g

Re: cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
On Wed, Dec 20, 2017 at 03:24:09PM -0800, Tejun Heo wrote: > On Thu, Dec 21, 2017 at 12:59:23AM +0200, Dan Aloni wrote: > > Hi, > > > > Using netconsole, I was able to capture a hard lockup that seems to be > > related to cgroups, on a Fedora kernel based on v4.14.4. &g

cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
Hi, Using netconsole, I was able to capture a hard lockup that seems to be related to cgroups, on a Fedora kernel based on v4.14.4. By my analysis, from the 16 CPUs below, 14 are on css_set_lock, one is inside css_task_iter_advance, and the last one stuck trying to send an IPI, I guess because

cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
Hi, Using netconsole, I was able to capture a hard lockup that seems to be related to cgroups, on a Fedora kernel based on v4.14.4. By my analysis, from the 16 CPUs below, 14 are on css_set_lock, one is inside css_task_iter_advance, and the last one stuck trying to send an IPI, I guess because

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:57:55AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 11:45:20AM +0200, Dan Aloni wrote: > > git cherry-pick -x 16588f659257 # x86/tsc: Annotate printouts as firmware > > bug > > git cherry-pick -x 8c9b9d87b855 # x86/tsc: Limit the

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:57:55AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 11:45:20AM +0200, Dan Aloni wrote: > > git cherry-pick -x 16588f659257 # x86/tsc: Annotate printouts as firmware > > bug > > git cherry-pick -x 8c9b9d87b855 # x86/tsc: Limit the

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:03:35AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 10:33:52AM +0200, Dan Aloni wrote: > > Hi all, > > > > I've tested the following changes, belonging to merge commit f7dd3b1734e, > > on top of 4.9.68 after a very easy backport from 4

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:03:35AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 10:33:52AM +0200, Dan Aloni wrote: > > Hi all, > > > > I've tested the following changes, belonging to merge commit f7dd3b1734e, > > on top of 4.9.68 after a very easy backport from 4

TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
go away even after repeated ntpdate sync attempts. For further testing I've posted a branch for these changes here: https://github.com/kernelim/linux tsc-fix-for-4.9.x -- Dan Aloni

TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
go away even after repeated ntpdate sync attempts. For further testing I've posted a branch for these changes here: https://github.com/kernelim/linux tsc-fix-for-4.9.x -- Dan Aloni

Use-after-free with deferred driver probing and __initconst

2017-12-03 Thread Dan Aloni
` attributes which suppress those checks. Perhaps as a harderning measure, older kernels should be patched with a config option for not freeing init sections? -- Dan Aloni

Use-after-free with deferred driver probing and __initconst

2017-12-03 Thread Dan Aloni
` attributes which suppress those checks. Perhaps as a harderning measure, older kernels should be patched with a config option for not freeing init sections? -- Dan Aloni

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Dan Aloni
in a manner independent of CONFIG_LOCALVERSION_AUTO, using the attached patch. It will be emitted in the dmesg Linux banner (though not in /proc/version, that's more interface-ish and may break things). -- Dan Aloni >From d2d4ab995911e59ba41153fade176ca805ca2db8 Mon Sep 17 00:00:00 2001 From: Dan A

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Dan Aloni
in a manner independent of CONFIG_LOCALVERSION_AUTO, using the attached patch. It will be emitted in the dmesg Linux banner (though not in /proc/version, that's more interface-ish and may break things). -- Dan Aloni >From d2d4ab995911e59ba41153fade176ca805ca2db8 Mon Sep 17 00:00:00 2001 Fro

[PATCH] [CIFS] fix auth_key cleanup in SMB2_sess_setup() for possible crash

2014-10-20 Thread Dan Aloni
cifs] [985673.540980] [] ? cifs_small_buf_get+0x1a/0x30 [cifs] [985673.541003] [] ? small_smb2_init+0x285/0x510 [cifs] [985673.541025] [] build_ntlmssp_auth_blob+0x91/0x290 [cifs] [985673.541047] [] SMB2_sess_setup+0x1f0/0x590 [cifs] [...] Commit applies to 3.18-rc1 and various preceding stable versions.

[PATCH] [CIFS] fix auth_key cleanup in SMB2_sess_setup() for possible crash

2014-10-20 Thread Dan Aloni
] [...] Commit applies to 3.18-rc1 and various preceding stable versions. Signed-off-by: Dan Aloni d...@kernelim.com CC: Steve French smfre...@gmail.com CC: linux-c...@vger.kernel.org CC: linux-kernel@vger.kernel.org --- fs/cifs/smb2pdu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/cifs

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-24 Thread Dan Aloni
On Sun, Aug 24, 2014 at 02:05:31PM -0400, Benjamin LaHaise wrote: > On Fri, Aug 22, 2014 at 09:51:10PM +0300, Dan Aloni wrote: > > Ben, seems that the test program needs some twidling to make the bug > > appear still by setting MAX_IOS to 256 (and it still passes on a > > ker

Re: Revert aio: fix aio request leak when events are reaped by user space

2014-08-24 Thread Dan Aloni
On Sun, Aug 24, 2014 at 02:05:31PM -0400, Benjamin LaHaise wrote: On Fri, Aug 22, 2014 at 09:51:10PM +0300, Dan Aloni wrote: Ben, seems that the test program needs some twidling to make the bug appear still by setting MAX_IOS to 256 (and it still passes on a kernel with the original patch

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-22 Thread Dan Aloni
On Fri, Aug 22, 2014 at 12:26:30PM -0400, Benjamin LaHaise wrote: > On Fri, Aug 22, 2014 at 07:15:02PM +0300, Dan Aloni wrote: > > Sorry, I was waiting for a new patch from your direction, I should > > have replied earlier. What bothered me about the patch you sent is that >

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-22 Thread Dan Aloni
ms to pass your test program > when I run it in a vm... Sorry, I was waiting for a new patch from your direction, I should have replied earlier. What bothered me about the patch you sent is that completed_events is added as a new field but nothing assigns to it, so I wonder how it can be effe

Re: Revert aio: fix aio request leak when events are reaped by user space

2014-08-22 Thread Dan Aloni
your direction, I should have replied earlier. What bothered me about the patch you sent is that completed_events is added as a new field but nothing assigns to it, so I wonder how it can be effective. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Revert aio: fix aio request leak when events are reaped by user space

2014-08-22 Thread Dan Aloni
On Fri, Aug 22, 2014 at 12:26:30PM -0400, Benjamin LaHaise wrote: On Fri, Aug 22, 2014 at 07:15:02PM +0300, Dan Aloni wrote: Sorry, I was waiting for a new patch from your direction, I should have replied earlier. What bothered me about the patch you sent is that completed_events is added

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-19 Thread Dan Aloni
On Tue, Aug 19, 2014 at 12:54:04PM -0400, Benjamin LaHaise wrote: > On Tue, Aug 19, 2014 at 07:37:33PM +0300, Dan Aloni wrote: > > Some testing I've done today indicates that the original commit broke > > AIO with regard to users that overflow the maximum number of request >

Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-19 Thread Dan Aloni
. This reverts commit b34e0e1319b31202eb142dcd9688cf7145a30bf6. Signed-off-by: Dan Aloni --- fs/aio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index 6d68e01dc7ca..45b07e8a1834 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1028,7 +1028,6 @@ void aio_complete

Revert aio: fix aio request leak when events are reaped by user space

2014-08-19 Thread Dan Aloni
. This reverts commit b34e0e1319b31202eb142dcd9688cf7145a30bf6. Signed-off-by: Dan Aloni d...@kernelim.com --- fs/aio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index 6d68e01dc7ca..45b07e8a1834 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1028,7 +1028,6 @@ void

Re: Revert aio: fix aio request leak when events are reaped by user space

2014-08-19 Thread Dan Aloni
On Tue, Aug 19, 2014 at 12:54:04PM -0400, Benjamin LaHaise wrote: On Tue, Aug 19, 2014 at 07:37:33PM +0300, Dan Aloni wrote: Some testing I've done today indicates that the original commit broke AIO with regard to users that overflow the maximum number of request per IO context (where

Re: [PATCH] nfs: fix kernel warning when removing proc entry

2014-08-16 Thread Dan Aloni
uot;fs/nfsfs", NULL); > + remove_proc_entry("nfsfs", net->proc_net); > } nfs_fs_proc_net_init() has: error_1: remove_proc_entry("fs/nfsfs", NULL); I think this needs fixing too, for consistency. -- Dan Aloni -- To unsubscribe from this list: send the line "

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-16 Thread Dan Aloni
+static LIST_HEAD(phy_list); > + Just noticed this via a quick glance - Seems that this variable is not referenced by any of the compilation units, what's the purpose of it? And as a static global in a shared private, each of the including compilation units gets a copy, which I am not sure was i

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-16 Thread Dan Aloni
noticed this via a quick glance - Seems that this variable is not referenced by any of the compilation units, what's the purpose of it? And as a static global in a shared private, each of the including compilation units gets a copy, which I am not sure was intended anyway. -- Dan Aloni

Re: [PATCH] nfs: fix kernel warning when removing proc entry

2014-08-16 Thread Dan Aloni
() has: error_1: remove_proc_entry(fs/nfsfs, NULL); I think this needs fixing too, for consistency. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: net: pretty odd panic in netfilter

2014-07-02 Thread Dan Aloni
" ^^^^^ These instructions should not have been modified, even by relocation. So we only need to figure out what overwrote with '0x'. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: Fix NETDEV_CHANGE notifier usage causing spurious arp flush

2014-07-02 Thread Dan Aloni
change_info.flags_changed = 0; I think it would be safer to do: struct netdev_notifier_change_info change_info = {}; So that when future fields are added to the struct and this call-site happens to be forgotten, they will get 0 by default rather than random stack values. -- Dan Aloni -- To

Re: [PATCH] net: Fix NETDEV_CHANGE notifier usage causing spurious arp flush

2014-07-02 Thread Dan Aloni
: struct netdev_notifier_change_info change_info = {}; So that when future fields are added to the struct and this call-site happens to be forgotten, they will get 0 by default rather than random stack values. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: net: pretty odd panic in netfilter

2014-07-02 Thread Dan Aloni
21 55 55 fb 01 48 19 d2 48 83 e2 f0 What should have been according to objdump: 75 f8 21 c3 83 fb 01 48 19 d2 48 83 e2 f0 ^ These instructions should not have been modified, even by relocation. So we only need to figure out what overwrote with '0x'. -- Dan Aloni

Re: mm/sched/net: BUG when running simple code

2014-06-16 Thread Dan Aloni
7926] [] ? tracesys+0x7e/0xe6 > [ 88.837926] [] tracesys+0xe1/0xe6 > > tracesys() seems to live inside a module space here? I think it's more likely kASLR. The Documentation/x86/x86_64/mm.txt doc needs updating. -- Dan Aloni -- To unsubscribe from this list: send the line "u

Re: mm/sched/net: BUG when running simple code

2014-06-16 Thread Dan Aloni
[ 88.837926] [a0561c93] tracesys+0xe1/0xe6 tracesys() seems to live inside a module space here? I think it's more likely kASLR. The Documentation/x86/x86_64/mm.txt doc needs updating. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: > And also, the Oops code of 0003 (PF_WRITE and PF_USER) might hint at > what Dave wrote. Scrape what I wrote about that, it's PF_PROT | PF_WRITE. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe l

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: > > that theory went away. (also confirmed by not finding a netlink module.) > > > > What about the kernel .text overflowing into the modules space? The loader > > checks for that, but can something like that

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 12:01:37AM -0400, Sasha Levin wrote: > On 06/12/2014 11:27 PM, Dan Aloni wrote: > > On Thu, Jun 12, 2014 at 10:56:16PM -0400, Sasha Levin wrote: > >> > Hi all, > >> > > >> > Okay, I'm really lost. I got the following when fuz

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
IP - 0xa0f12560 is in the range (from Documentation/x86/x86_64/mm.txt): a000 - ff5f (=1525 MB) module mapping space So seems it was in a module. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
/mm.txt): a000 - ff5f (=1525 MB) module mapping space So seems it was in a module. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 12:01:37AM -0400, Sasha Levin wrote: On 06/12/2014 11:27 PM, Dan Aloni wrote: On Thu, Jun 12, 2014 at 10:56:16PM -0400, Sasha Levin wrote: Hi all, Okay, I'm really lost. I got the following when fuzzing, and can't really explain what's going on. It seems

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: that theory went away. (also confirmed by not finding a netlink module.) What about the kernel .text overflowing into the modules space? The loader checks for that, but can something like that happen after everything is up

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: And also, the Oops code of 0003 (PF_WRITE and PF_USER) might hint at what Dave wrote. Scrape what I wrote about that, it's PF_PROT | PF_WRITE. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH linux-next 1/2] kgdb-x86: allow to temporarily disable trap activation

2013-11-19 Thread Dan Aloni
by zero, and also during fwait. A second patch depending on this one addresses that issue. Signed-off-by: Dan Aloni Signed-off-by: Muli Ben-Yehuda --- arch/x86/include/asm/kgdb.h | 8 arch/x86/kernel/kgdb.c | 21 + 2 files changed, 29 insertions(+) diff --git

[no subject]

2013-11-19 Thread Dan Aloni
Hello, The following two patches address an integration issue between KVM and KGDB. The issue described in the patches can be triggered with vanilla kernels that enable KGDB and KVM together on x86 (more specifically, we bump into this with Fedora's 3.11 kernel from FC19). On a kernel enabled

[PATCH linux-next 2/2] kvm-x86: emulator: disable kgdb-x86 on fastop and fpe flush

2013-11-19 Thread Dan Aloni
We have seen that when kvm-unit-tests runs with kgdb enabled, the kernel halts on the debugger during the KVM x86 instruction emulation that performs a test of a division by zero, and also during fwait. This patch adds calls that temporarily disable the debugger trap. Signed-off-by: Dan Aloni

[PATCH linux-next 2/2] kvm-x86: emulator: disable kgdb-x86 on fastop and fpe flush

2013-11-19 Thread Dan Aloni
We have seen that when kvm-unit-tests runs with kgdb enabled, the kernel halts on the debugger during the KVM x86 instruction emulation that performs a test of a division by zero, and also during fwait. This patch adds calls that temporarily disable the debugger trap. Signed-off-by: Dan Aloni

[no subject]

2013-11-19 Thread Dan Aloni
Hello, The following two patches address an integration issue between KVM and KGDB. The issue described in the patches can be triggered with vanilla kernels that enable KGDB and KVM together on x86 (more specifically, we bump into this with Fedora's 3.11 kernel from FC19). On a kernel enabled

[PATCH linux-next 1/2] kgdb-x86: allow to temporarily disable trap activation

2013-11-19 Thread Dan Aloni
by zero, and also during fwait. A second patch depending on this one addresses that issue. Signed-off-by: Dan Aloni alo...@stratoscale.com Signed-off-by: Muli Ben-Yehuda m...@stratoscale.com --- arch/x86/include/asm/kgdb.h | 8 arch/x86/kernel/kgdb.c | 21 + 2

Re: [PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-10 Thread Dan Aloni
On Tue, Sep 10, 2013 at 04:45:32PM +0100, Gustavo Padovan wrote: > Hi Dan, > > 2013-09-03 Dan Aloni : > > > Tested with this patch and a Bluetooth mouse on 3.10.10, on ThinkPad W530. > > > > Bus 001 Device 004: ID 0a5c:21e6 Broadcom Corp. BCM20702 Bluetooth 4.0 &

Re: [PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-10 Thread Dan Aloni
On Tue, Sep 10, 2013 at 04:45:32PM +0100, Gustavo Padovan wrote: Hi Dan, 2013-09-03 Dan Aloni alo...@postram.com: Tested with this patch and a Bluetooth mouse on 3.10.10, on ThinkPad W530. Bus 001 Device 004: ID 0a5c:21e6 Broadcom Corp. BCM20702 Bluetooth 4.0 [ThinkPad] T

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
On Wed, Sep 04, 2013 at 12:49:58AM +0400, Dmitry Vyukov wrote: > On Wed, Sep 4, 2013 at 12:27 AM, Dan Aloni wrote: > > Your work and contribution is appreciated nonetheless, but your bug > > report needs to pertain closer to the work the core kernel hackers > > are doing. >

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
(*info->cleanup)(info); + info->retval = 0x12345678; kfree(info); } This should help to prove it or not, and if it does prove it would be appealing to more eyes. Please try the same approach with similar future issues. -- Dan Aloni -- To unsubscribe from this list: send

[PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-03 Thread Dan Aloni
= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) Signed-off-by: Dan Aloni --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index de4cf4d

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
. -- Dan Aloni -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
On Wed, Sep 04, 2013 at 12:49:58AM +0400, Dmitry Vyukov wrote: On Wed, Sep 4, 2013 at 12:27 AM, Dan Aloni alo...@stratoscale.com wrote: Your work and contribution is appreciated nonetheless, but your bug report needs to pertain closer to the work the core kernel hackers are doing. What

[PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-03 Thread Dan Aloni
= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) Signed-off-by: Dan Aloni alo...@postram.com --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth

Re: [PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-31 Thread Dan Aloni
On Sat, Aug 31, 2013 at 03:38:33PM +0200, Martin MOKREJŠ wrote: > Hi Dan, > thank you for your work on my issue. I would like to test it on 3.10.9 where > I faced the problem initially. Sure, see the attached patch for 3.10.9. -- Dan Aloni >From e323d3b4fdc1e61c3c39dfb3733d8b8c

[PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-31 Thread Dan Aloni
. Cc'ed Al Viro because it is trivially relies on his linux-next tree changes. Signed-off-by: Dan Aloni Cc: Al Viro Cc: Denys Vlasenko Cc: Andrew Morton Cc: Linus Torvalds --- fs/binfmt_elf.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git

[PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-31 Thread Dan Aloni
. Cc'ed Al Viro because it is trivially relies on his linux-next tree changes. Signed-off-by: Dan Aloni alo...@stratoscale.com Cc: Al Viro v...@zeniv.linux.org.uk Cc: Denys Vlasenko vda.li...@googlemail.com Cc: Andrew Morton a...@linux-foundation.org Cc: Linus Torvalds torva...@linux-foundation.org

  1   2   3   4   >