[PATCH] scripts/recordmcount: support more than 64K ELF sections

2019-02-15 Thread Dan Aloni
here were taken from scripts/sortextable.c. Signed-off-by: Dan Aloni --- scripts/recordmcount.c | 5 ++ scripts/recordmcount.h | 106 - 2 files changed, 99 insertions(+), 12 deletions(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index a5

Re: [PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-28 Thread Dan Aloni
On Sun, Jan 28, 2018 at 03:43:48PM +0100, Greg KH wrote: > On Sat, Jan 27, 2018 at 10:07:41PM +0200, Dan Aloni wrote: > > commit cabfb3680f78 upstream. > > Are you sure? > $ gsr cabfb3680f78 > cabfb3680f78 ("CIFS: Enable encryption during session setup phase") >

[PATCH stable] cifs: empty TargetInfo leads to crash on recovery

2018-01-27 Thread Dan Aloni
plied to 4.9.x and older kernels. Signed-off-by: Dan Aloni CC: Steve French CC: sta...@vger.kernel.org # 4.4.x CC: linux-c...@vger.kernel.org CC: linux-kernel@vger.kernel.org [1] https://patchwork.kernel.org/patch/5106391/ [2] (temporary url) http://copr-dist-git.fedorainfracloud.org/cgit/alonid/samba-

Re: [PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-14 Thread Dan Aloni
On Sun, Jan 14, 2018 at 10:48:01AM +0900, Sergey Senozhatsky wrote: > Ccing Kees, Peter, Andrew, Steven > > On (01/13/18 23:34), Dan Aloni wrote: > > This commit enables the kernel to encrypt the free-form text that > > is generated by printk() before it is brought up to `dm

[PATCHv2 6/7] tools: add dmesg decryption program

2018-01-13 Thread Dan Aloni
Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni --- tools/Makefile | 9 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 354 4 files changed, 377

[PATCHv2 0/7] RFC: Public key encryption of dmesg by the kernel

2018-01-13 Thread Dan Aloni
here is an openssl depdendency.) - checkpatch.pl linting [1] https://lwn.net/Articles/742412/ Dan Aloni (7): crypto: fix memory leak in rsa-kcs1pad encryption Move net/ceph/armor to lib/ and add docs base64-armor: add bounds checking certs: allow in-kernel access of trusted keys printk: allow kmsg to

[PATCHv2 3/7] base64-armor: add bounds checking

2018-01-13 Thread Dan Aloni
Future use of the API can benefit from bounds checking. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 17 +++-- lib/base64-armor.c | 20 ++-- net/ceph/crypto.c| 2 +- 3 files changed, 30 insertions(+), 9 deletions(-) diff --git a

[PATCHv2 2/7] Move net/ceph/armor to lib/ and add docs

2018-01-13 Thread Dan Aloni
Plus, add functions that assist in managing buffer bounds. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 65 ++ lib/Kconfig| 7 lib/Makefile | 1 + net/ceph/armor.c => lib/bas

[PATCHv2 1/7] crypto: fix memory leak in rsa-kcs1pad encryption

2018-01-13 Thread Dan Aloni
The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu Signed-off-by: Dan Aloni --- crypto/rsa-pkcs1pad.c | 9 - 1 file changed, 9 deletions(-) diff --git a/crypto/rsa-pkcs1

[PATCHv2 4/7] certs: allow in-kernel access of trusted keys

2018-01-13 Thread Dan Aloni
CC: David Howells Signed-off-by: Dan Aloni --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system_keyring.c b/certs/system_keyring.c index

[PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-13 Thread Dan Aloni
kernel modules and userspace-supplied firmwares. CC: Petr Mladek CC: Sergey Senozhatsky CC: Linus Torvalds Signed-off-by: Dan Aloni --- Documentation/ioctl/ioctl-number.txt | 1 + include/uapi/linux/kmsg.h| 18 ++ init/Kconfig | 11 + kernel/printk/printk.c

[PATCHv2 7/7] docs: add dmesg encryption doc

2018-01-13 Thread Dan Aloni
Reviewed-by: Randy Dunlap Signed-off-by: Dan Aloni --- Documentation/admin-guide/dmesg-encryption.rst | 118 + Documentation/admin-guide/index.rst| 1 + 2 files changed, 119 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst

Re: [kernel-hardening] [PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 10:42:49PM +0100, Jann Horn wrote: > On Sat, Dec 30, 2017 at 6:57 PM, Dan Aloni wrote: > > From: Dan Aloni > > > > Hi All, > > > > There has been a lot of progress in recent times regarding the removal > > of sensitive information fr

Re: [PATCH 5/5] docs: add dmesg encryption doc

2018-01-03 Thread Dan Aloni
On Sat, Dec 30, 2017 at 11:40:06AM -0800, Randy Dunlap wrote: > On 12/30/2017 09:58 AM, Dan Aloni wrote: > > From: Dan Aloni > > > > Signed-off-by: Dan Aloni > > --- > > Documentation/admin-guide/dmesg-encryption.rst | 77 > > ++

[PATCH 0/5] RFC: Public key encryption of dmesg by the kernel

2017-12-30 Thread Dan Aloni
From: Dan Aloni Hi All, There has been a lot of progress in recent times regarding the removal of sensitive information from dmesg (pointers, etc.), so I figured - why not encrypt it all? However, I have not found any existing discussions or references regarding this technical direction. I am

[PATCH 4/5] tools: add dmesg decryption program

2017-12-30 Thread Dan Aloni
From: Dan Aloni Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni --- tools/Makefile | 5 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 316 4 files

[PATCH 2/5] certs: allow in-kernel access of trusted keys

2017-12-30 Thread Dan Aloni
From: Dan Aloni Signed-off-by: Dan Aloni --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system_keyring.c b/certs/system_keyring.c index 6251d1b27f0c

[PATCH 3/5] kernel/printk: allow kmsg to be encrypted using public key encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni This commit enables the kernel to encrypt the free-form text that is generated by printk() before it is brought up to `dmesg` in userspace. The encryption is made using one of the trusted public keys which are kept built-in inside the kernel. These keys are presently also used

[PATCH 5/5] docs: add dmesg encryption doc

2017-12-30 Thread Dan Aloni
From: Dan Aloni Signed-off-by: Dan Aloni --- Documentation/admin-guide/dmesg-encryption.rst | 77 ++ 1 file changed, 77 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst diff --git a/Documentation/admin-guide/dmesg-encryption.rst b

[PATCH 1/5] crypto: fix memory leak in rsa-kcs1pad encryption

2017-12-30 Thread Dan Aloni
From: Dan Aloni The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu Signed-off-by: Dan Aloni --- crypto/rsa-pkcs1pad.c | 9 - 1 file changed, 9 deletions(-) diff --

Re: cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
On Wed, Dec 20, 2017 at 03:24:09PM -0800, Tejun Heo wrote: > On Thu, Dec 21, 2017 at 12:59:23AM +0200, Dan Aloni wrote: > > Hi, > > > > Using netconsole, I was able to capture a hard lockup that seems to be > > related to cgroups, on a Fedora kernel based on v4.14.4. &g

cgroups-related hard lockup in 4.14?

2017-12-20 Thread Dan Aloni
Hi, Using netconsole, I was able to capture a hard lockup that seems to be related to cgroups, on a Fedora kernel based on v4.14.4. By my analysis, from the 16 CPUs below, 14 are on css_set_lock, one is inside css_task_iter_advance, and the last one stuck trying to send an IPI, I guess because al

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:57:55AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 11:45:20AM +0200, Dan Aloni wrote: > > git cherry-pick -x 16588f659257 # x86/tsc: Annotate printouts as firmware > > bug > > git cherry-pick -x 8c9b9d87b855 # x86/tsc: Limit the

Re: TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
On Wed, Dec 13, 2017 at 10:03:35AM +0100, Greg KH wrote: > On Wed, Dec 13, 2017 at 10:33:52AM +0200, Dan Aloni wrote: > > Hi all, > > > > I've tested the following changes, belonging to merge commit f7dd3b1734e, > > on top of 4.9.68 after a very easy backport from

TSC x86 fixes for LTS kernel 4.9.x

2017-12-13 Thread Dan Aloni
t does not go away even after repeated ntpdate sync attempts. For further testing I've posted a branch for these changes here: https://github.com/kernelim/linux tsc-fix-for-4.9.x -- Dan Aloni

Use-after-free with deferred driver probing and __initconst

2017-12-03 Thread Dan Aloni
, `__refdata`, and `__refconst` attributes which suppress those checks. Perhaps as a harderning measure, older kernels should be patched with a config option for not freeing init sections? -- Dan Aloni

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Dan Aloni
ision in a manner independent of CONFIG_LOCALVERSION_AUTO, using the attached patch. It will be emitted in the dmesg Linux banner (though not in /proc/version, that's more interface-ish and may break things). -- Dan Aloni >From d2d4ab995911e59ba41153fade176ca805ca2db8 Mon Sep 17 00:00:00 2001 F

[PATCH] [CIFS] fix auth_key cleanup in SMB2_sess_setup() for possible crash

2014-10-20 Thread Dan Aloni
35/0x9d0 [cifs] [985673.540980] [] ? cifs_small_buf_get+0x1a/0x30 [cifs] [985673.541003] [] ? small_smb2_init+0x285/0x510 [cifs] [985673.541025] [] build_ntlmssp_auth_blob+0x91/0x290 [cifs] [985673.541047] [] SMB2_sess_setup+0x1f0/0x590 [cifs] [...] Commit applies to 3.18-rc1 and various preceding stable

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-24 Thread Dan Aloni
On Sun, Aug 24, 2014 at 02:05:31PM -0400, Benjamin LaHaise wrote: > On Fri, Aug 22, 2014 at 09:51:10PM +0300, Dan Aloni wrote: > > Ben, seems that the test program needs some twidling to make the bug > > appear still by setting MAX_IOS to 256 (and it still passes on a > > ker

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-22 Thread Dan Aloni
On Fri, Aug 22, 2014 at 12:26:30PM -0400, Benjamin LaHaise wrote: > On Fri, Aug 22, 2014 at 07:15:02PM +0300, Dan Aloni wrote: > > Sorry, I was waiting for a new patch from your direction, I should > > have replied earlier. What bothered me about the patch you sent is that > >

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-22 Thread Dan Aloni
ou? It seems to pass your test program > when I run it in a vm... Sorry, I was waiting for a new patch from your direction, I should have replied earlier. What bothered me about the patch you sent is that completed_events is added as a new field but nothing assigns to it, so I wonder how

Re: Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-19 Thread Dan Aloni
On Tue, Aug 19, 2014 at 12:54:04PM -0400, Benjamin LaHaise wrote: > On Tue, Aug 19, 2014 at 07:37:33PM +0300, Dan Aloni wrote: > > Some testing I've done today indicates that the original commit broke > > AIO with regard to users that overflow the maximum number of reques

Revert "aio: fix aio request leak when events are reaped by user space"

2014-08-19 Thread Dan Aloni
This reverts commit b34e0e1319b31202eb142dcd9688cf7145a30bf6. Signed-off-by: Dan Aloni --- fs/aio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index 6d68e01dc7ca..45b07e8a1834 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1028,7 +1028,6 @@ void aio_com

Re: [PATCH] nfs: fix kernel warning when removing proc entry

2014-08-16 Thread Dan Aloni
uot;fs/nfsfs", NULL); > + remove_proc_entry("nfsfs", net->proc_net); > } nfs_fs_proc_net_init() has: error_1: remove_proc_entry("fs/nfsfs", NULL); I think this needs fixing too, for consistency. -- Dan Aloni -- To unsubscribe from this list: send the line "

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-16 Thread Dan Aloni
+static LIST_HEAD(phy_list); > + Just noticed this via a quick glance - Seems that this variable is not referenced by any of the compilation units, what's the purpose of it? And as a static global in a shared private, each of the including compilation units gets a copy, which I am not sure

Re: net: pretty odd panic in netfilter

2014-07-02 Thread Dan Aloni
fb 01 48 19 48 83 e2 f0" ^ These instructions should not have been modified, even by relocation. So we only need to figure out what overwrote with '0x'. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: Fix NETDEV_CHANGE notifier usage causing spurious arp flush

2014-07-02 Thread Dan Aloni
change_info.flags_changed = 0; I think it would be safer to do: struct netdev_notifier_change_info change_info = {}; So that when future fields are added to the struct and this call-site happens to be forgotten, they will get 0 by default rather than random stack values. -- Dan Aloni -- To

Re: mm/sched/net: BUG when running simple code

2014-06-16 Thread Dan Aloni
/0x70 > [ 88.837926] [] ? tracesys+0x7e/0xe6 > [ 88.837926] [] tracesys+0xe1/0xe6 > > tracesys() seems to live inside a module space here? I think it's more likely kASLR. The Documentation/x86/x86_64/mm.txt doc needs updating. -- Dan Aloni -- To unsubscribe from this list:

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: > And also, the Oops code of 0003 (PF_WRITE and PF_USER) might hint at > what Dave wrote. Scrape what I wrote about that, it's PF_PROT | PF_WRITE. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscr

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 07:55:55AM +0300, Dan Aloni wrote: > > that theory went away. (also confirmed by not finding a netlink module.) > > > > What about the kernel .text overflowing into the modules space? The loader > > checks for that, but can something like that ha

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
On Fri, Jun 13, 2014 at 12:01:37AM -0400, Sasha Levin wrote: > On 06/12/2014 11:27 PM, Dan Aloni wrote: > > On Thu, Jun 12, 2014 at 10:56:16PM -0400, Sasha Levin wrote: > >> > Hi all, > >> > > >> > Okay, I'm really lost. I got the following whe

Re: mm/sched/net: BUG when running simple code

2014-06-12 Thread Dan Aloni
dule on my kernel. The RIP - 0xa0f12560 is in the range (from Documentation/x86/x86_64/mm.txt): a000 - ff5f (=1525 MB) module mapping space So seems it was in a module. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe li

[PATCH linux-next 1/2] kgdb-x86: allow to temporarily disable trap activation

2013-11-19 Thread Dan Aloni
by zero, and also during fwait. A second patch depending on this one addresses that issue. Signed-off-by: Dan Aloni Signed-off-by: Muli Ben-Yehuda --- arch/x86/include/asm/kgdb.h | 8 arch/x86/kernel/kgdb.c | 21 + 2 files changed, 29 insertions(+) diff --git

[no subject]

2013-11-19 Thread Dan Aloni
Hello, The following two patches address an integration issue between KVM and KGDB. The issue described in the patches can be triggered with vanilla kernels that enable KGDB and KVM together on x86 (more specifically, we bump into this with Fedora's 3.11 kernel from FC19). On a kernel enabled wit

[PATCH linux-next 2/2] kvm-x86: emulator: disable kgdb-x86 on fastop and fpe flush

2013-11-19 Thread Dan Aloni
We have seen that when kvm-unit-tests runs with kgdb enabled, the kernel halts on the debugger during the KVM x86 instruction emulation that performs a test of a division by zero, and also during fwait. This patch adds calls that temporarily disable the debugger trap. Signed-off-by: Dan Aloni

Re: [PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-10 Thread Dan Aloni
On Tue, Sep 10, 2013 at 04:45:32PM +0100, Gustavo Padovan wrote: > Hi Dan, > > 2013-09-03 Dan Aloni : > > > Tested with this patch and a Bluetooth mouse on 3.10.10, on ThinkPad W530. > > > > Bus 001 Device 004: ID 0a5c:21e6 Broadcom Corp. BCM20702 Bluetooth 4.0 &

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
On Wed, Sep 04, 2013 at 12:49:58AM +0400, Dmitry Vyukov wrote: > On Wed, Sep 4, 2013 at 12:27 AM, Dan Aloni wrote: > > Your work and contribution is appreciated nonetheless, but your bug > > report needs to pertain closer to the work the core kernel hackers > > are doing. >

Re: Potential use-after-free in ____call_usermodehelper

2013-09-03 Thread Dan Aloni
if (info->cleanup) (*info->cleanup)(info); + info->retval = 0x12345678; kfree(info); } This should help to prove it or not, and if it does prove it would be appealing to more eyes. Please try the same approach with similar future issues. -- Dan Aloni --

[PATCH bluetooth-next] Bluetooth: Add support for BCM20702A0 [0a5c, 21e6]

2013-09-03 Thread Dan Aloni
= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) Signed-off-by: Dan Aloni --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index de4cf4d

Re: [PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-31 Thread Dan Aloni
On Sat, Aug 31, 2013 at 03:38:33PM +0200, Martin MOKREJŠ wrote: > Hi Dan, > thank you for your work on my issue. I would like to test it on 3.10.9 where > I faced the problem initially. Sure, see the attached patch for 3.10.9. -- Dan Aloni >From e323d3b4fdc1e61c3c39dfb3733d8b8c

[PATCH linux-next] Prevent a coredump with a large vm_map_count from Oopsing

2013-08-30 Thread Dan Aloni
gners. Cc'ed Al Viro because it is trivially relies on his linux-next tree changes. Signed-off-by: Dan Aloni Cc: Al Viro Cc: Denys Vlasenko Cc: Andrew Morton Cc: Linus Torvalds --- fs/binfmt_elf.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) di

[PATCH net-next] netconsole: avoid a crash with multiple sysfs writers

2013-08-30 Thread Dan Aloni
9 5d d8 49 89 fc 4c 89 6d e8 4c 89 75 f0 4c 89 7d f8 48 8 [..garbled..] [52608.609559] RIP [] __netpoll_cleanup+0x27/0xe0 [52608.609563] RSP [52608.609564] CR2: 03e0 [52608.609567] ---[ end trace d25ec343349b61d2 ]--- Signed-off-by: Dan Aloni Signed-off-by: Neil Horman CC: David S.

Re: 3.10.9: Oops at elf_core_dump()

2013-08-29 Thread Dan Aloni
systems the requirements for max_map_count are really large, so we can't avoid it. So, binfmt_elf.c should be fixed. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-29 Thread Dan Aloni
cause, I think maybe grub reserved "$0" as something > special. > Replace '$' with '%' in kernel boot parameter can fix this issue. You are correct with the root cause, however I don't think the patch is needed. In order to bypass grub's variable eval

Re: [PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Dan Aloni
On Thu, Aug 8, 2013 at 8:50 AM, Neil Horman wrote: > > On Wed, Aug 07, 2013 at 12:02:44PM +0300, Dan Aloni wrote: [..] > > > When my 'ifup eth' script was fired multiple times and ran concurrent o> @@ > > -682,7 +689,11 @@ restart: > >

[PATCH] netconsole: avoid a crash with multiple sysfs writers

2013-08-07 Thread Dan Aloni
8 48 8 [52608.609559] RIP [] __netpoll_cleanup+0x27/0xe0 [52608.609563] RSP [52608.609564] CR2: 03e0 [52608.609567] ---[ end trace d25ec343349b61d2 ]--- Signed-off-by: Dan Aloni CC: David S. Miller CC: Neil Horman --- drivers/net/netconsole.c | 13 - 1 file changed, 12 insertions(+), 1

Re: [PATCH] x86_64: fix a deadlock in set_rtc_mmss()

2007-11-17 Thread Dan Aloni
> >> */ > >> > >> - spin_lock(&rtc_lock); > >> + spin_lock_irqsave(&rtc_lock, flags); > > I think it's a good idea to update or just remove the comment above. > > > > David P. Reed has sent a patch to fix this bug befor

[PATCH] x86_64: fix a deadlock in set_rtc_mmss()

2007-11-15 Thread Dan Aloni
+0x3d/0x90 [] irq_exit+0x45/0x50 [] smp_apic_timer_interrupt+0x55/0x70 [] default_idle+0x0/0x50 [] apic_timer_interrupt+0x66/0x70 [] default_idle+0x2d/0x50 [] enter_idle+0x22/0x30 [] cpu_idle+0x5c/0x80 [] start_secondary+0x258/0x360 Signed-off-by: Dan Aloni <[EMAIL PROTECTED]>

Re: [patch 3/3] mm: variable length argument support

2007-08-22 Thread Dan Aloni
to err; > + } > + That change causes a crash in khelper when overcommit_memory = 2 under 2.6.23-rc3. When a khelper execs, at __bprm_mm_init() current->mm is still NULL. insert_vm_struct() calls security_vm_enough_memory(), which calls __vm_enough_memory(), and that's where current->mm-

Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

2007-08-16 Thread Dan Aloni
ity of 99, but I have kept that small patch to myself (figured it's just too nasty). -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: Determine version of kernel that produced vmcore

2007-07-23 Thread Dan Aloni
new > >features can be made to work on older kernels. > > That sounds good. Note that currently kexec doesn't actually pass the ELF notes themselves to the kernel, but only their physical addresses as extracted from /sys. If we want to be able to pass the notes themselves from u

do_swap_page() and !CONFIG_SWAP

2007-07-22 Thread Dan Aloni
swap pte - possible page table memory corruption\n"); ? -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: Kernel 2.6.22 + ALSA + Intel HDA = hda_codec: Unknown model

2007-07-14 Thread Dan Aloni
-project.org/pipermail/alsa-devel/2007-April/000441.html It is possible to take this patch, drop the other bits and just leave out the nice print that just tells it's A-BIT AW9D-MAX. Though AFAIK, ALSA maintainers have plans to move most of the probing code to userspace somehow so I'm not

Re: Determine version of kernel that produced vmcore

2007-07-11 Thread Dan Aloni
On Wed, Jul 11, 2007 at 11:37:26AM +0530, Vivek Goyal wrote: > On Tue, Jul 10, 2007 at 07:52:01PM +0300, Dan Aloni wrote: > > On Tue, Jul 10, 2007 at 08:09:04AM -0400, Neil Horman wrote: > > > On Tue, Jul 10, 2007 at 12:18:17PM +0530, Vivek Goyal wrote: > > > > On F

Re: Determine version of kernel that produced vmcore

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 03:00:09PM -0400, Neil Horman wrote: > On Tue, Jul 10, 2007 at 08:35:41PM +0300, Dan Aloni wrote: >[...] > > > > Isn't there some sort of a circular dependency going on here? As I > > understand it the vmlinux binary already contains the in

Re: avoiding rejects

2007-07-10 Thread Dan Aloni
instead of adding context-awareness to the merger process, add context-awareness to the diff generator. The other 'more complex' code modifications hunks must remain with a context of 3 lines. 3. Another option is to come up with file formats that have '3 space lines' dilimete

Re: Determine version of kernel that produced vmcore

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 08:35:41PM +0300, Dan Aloni wrote: > On Tue, Jul 10, 2007 at 01:17:40PM -0400, Neil Horman wrote: > > On Tue, Jul 10, 2007 at 08:30:37PM +0530, Vivek Goyal wrote: > > > I am still thinking that why can't we change initrd building process > >

Re: Determine version of kernel that produced vmcore

2007-07-10 Thread Dan Aloni
ere some sort of a circular dependency going on here? As I understand it the vmlinux binary already contains the initramfs as built-in data (at least that's what I use here for initramfs). It makes more sense if you guys are creating an _initrd_ image (that's what mkinitrd original

Re: Determine version of kernel that produced vmcore

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 08:09:04AM -0400, Neil Horman wrote: > On Tue, Jul 10, 2007 at 12:18:17PM +0530, Vivek Goyal wrote: > > On Fri, Jul 06, 2007 at 05:58:04PM +0300, Dan Aloni wrote: > > > On Fri, Jul 06, 2007 at 03:28:14PM +0200, Bernhard Walle wrote: > > > >

Re: Determine version of kernel that produced vmcore

2007-07-10 Thread Dan Aloni
On Tue, Jul 10, 2007 at 12:18:17PM +0530, Vivek Goyal wrote: > On Fri, Jul 06, 2007 at 05:58:04PM +0300, Dan Aloni wrote: > > >[..] > > It contains enough information in order to make a compact kernel > > dump (makedumpinfo needs to go over the struct page arrays).

Re: Determine version of kernel that produced vmcore

2007-07-09 Thread Dan Aloni
On Mon, Jul 09, 2007 at 10:49:38PM +0200, Bernhard Walle wrote: > Hi, > > * Dan Aloni <[EMAIL PROTECTED]> [2007-07-09 13:41]: > > > > A patch that I am working on will make it possible to integrate > > > > the output of 'makedumpinfo -g' into vmlin

Re: Determine version of kernel that produced vmcore

2007-07-09 Thread Dan Aloni
On Mon, Jul 09, 2007 at 11:21:54AM +0200, Bernhard Walle wrote: > Hello, > > * Dan Aloni <[EMAIL PROTECTED]> [2007-07-06 16:58]: > > > > Redhat has a makedumpinfo util which they intend to use as slim > > kernel-version-independent utility on kdump rootfs in or

Re: [RFC][Patch] Allow not mounting a root fs

2007-07-06 Thread Dan Aloni
t. Normally, if your initramfs has a /init script your kernel would skip the entire stage where it panics in the perpare_namespace() function for trying to mount "root=" by itself (see init/main.c:init()). -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il

Re: Determine version of kernel that produced vmcore

2007-07-06 Thread Dan Aloni
n make it fail. Also, kallsyms wastes memory on memory-limited embedded setups, so you might not want to depend on it. Perhaps EXPORT_SYMBOL can be used instead.. Any comments? -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this

Re: Some NCQ numbers...

2007-07-04 Thread Dan Aloni
On Wed, Jul 04, 2007 at 08:17:35PM +0400, Michael Tokarev wrote: > Dan Aloni wrote: > > On Thu, Jun 28, 2007 at 02:51:58PM +0400, Michael Tokarev wrote: > >> [..] > >> Test machine was using MPTSAS driver for the following card: > >> SCSI storage controller

Re: Some NCQ numbers...

2007-07-04 Thread Dan Aloni
NCQ support internally in their firmware (something to do with bugs in error handling). -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

[PATCH 10/11] drivers/block/rd.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- drivers/block/rd.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/rd.c b/drivers/block/rd.c index a1512da..3b974f8 100644 --- a/drivers/block/rd.c +++ b/drivers/block/rd.c @@ -463,9 +463,9 @@ stat

[PATCH 11/11] kernel/sched.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- kernel/sched.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index 50e1a31..45e9534 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -6249,7 +6249,7 @@ stati

[PATCH 8/11] drivers/acpi/pci_link.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- drivers/acpi/pci_link.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index acc5947..3448edd 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@

[PATCH 9/11] arch/x86_64/kernel/process.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- arch/x86_64/kernel/process.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c index 5909039..cd2a3cd 100644 --- a/arch/x86_64/kernel/process.c +++ b/arch/

[PATCH 6/11] drivers/char/ipmi/ipmi_si_intf.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- drivers/char/ipmi/ipmi_si_intf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 78e1b96..4edfdda 100644 --- a/drivers/char/ipmi/ipmi_si_

[PATCH 7/11] mm/page_alloc.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- mm/page_alloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 05ace44..b324bc2 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3361,7 +3361,7 @@ void *

[PATCH 5/11] drivers/char/ipmi/ipmi_poweroff.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- drivers/char/ipmi/ipmi_poweroff.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c index e02893b..b86186d 100644 --- a/drivers/char/ipmi/ipmi_powe

[PATCH 4/11] net/ipv4/netfilter/ip_tables.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- net/ipv4/netfilter/ip_tables.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index 9bacf1a..9a6354e 100644 --- a/net/ipv4/netfilter/ip_tables.c +++

[PATCH 2/11] arch/x86_64/kernel/apic.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- arch/x86_64/kernel/apic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c index 1b0e07b..243116f 100644 --- a/arch/x86_64/kernel/apic.c +++ b/arch/x86_64/kernel/

[PATCH 3/11] arch/x86_64/kernel/e820.c: lower printk severity

2007-07-04 Thread Dan Aloni
Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- arch/x86_64/kernel/e820.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86_64/kernel/e820.c b/arch/x86_64/kernel/e820.c index 13c6c37..47a8ce6 100644 --- a/arch/x86_64/kernel/e820.c +++ b/arch/x86_64/kernel/

[PATCH 1/11] arch/x86_64/kernel/aperture.c: lower printk severity

2007-07-04 Thread Dan Aloni
Users that use kernel log filtering (e.g. via syslogd or a proprietry method) wouldn't like to see warning prints that are not really warnings. Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> --- arch/x86_64/kernel/aperture.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

Re: [RFC] automatic CC generation for patch submission

2007-06-30 Thread Dan Aloni
't succeed if it requires software at >patch-submitter's site. It'd need to run at vger. > And: c) The script will need to query vger for each file in the patch via some protocol.. Do you think it's worth the effort? -- Dan Aloni XIV LTD, http://www.xivstorage.com da

Re: [RFC] automatic CC generation for patch submission

2007-06-30 Thread Dan Aloni
ly it gets ignored if it is quite low in priority. In that case the CC is a NOP but might still be good for archiving purposes. > (For extra giggles we could parse emailed oops and bug reports and add the > appropriate cc's there too. Harder.) BTS was discussed to death already, let&#x

Re: [RFC] automatic CC generation for patch submission

2007-06-30 Thread Dan Aloni
comprehensive > patches/tests/bugs/testers/developers *tracking* system. > > And don't limit yourself to fast conclusions. Thanks. I am not proposing a comprehensive tracking system. I think you are taking my intentions quite off-course. -- Dan Aloni XIV LTD, http://www.xivstorage.com

Re: [RFC] automatic CC generation for patch submission

2007-06-30 Thread Dan Aloni
On Sat, Jun 30, 2007 at 06:01:23AM +0200, Adrian Bunk wrote: > On Sat, Jun 30, 2007 at 05:34:51AM +0300, Dan Aloni wrote: > >... > > Basically, instead of manually figuring out who to add to CC > > when sending a patch to LKML by looking at MAINTAINERS, a > > scrip

Re: [RFC] automatic CC generation for patch submission

2007-06-29 Thread Dan Aloni
gt; for a patch. > > LKML archive near you, search phrase "BTS", subjects that have > something about "the quality of the kernel". Good luck. Right, however many patches don't map to bug reports and don't need the heavy use of BTS. This suggestion is mainly for the

[RFC] automatic CC generation for patch submission

2007-06-29 Thread Dan Aloni
LKML would automatically send links about posted patches to the other mailing lists whenever someone forgets to add a CC. Any comments? -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH] Fix race condition about network device name allocation

2007-06-13 Thread Dan Aloni
On Wed, Jun 13, 2007 at 09:36:31AM -0700, Stephen Hemminger wrote: > On Wed, 13 Jun 2007 12:45:21 +0300 > Dan Aloni <[EMAIL PROTECTED]> wrote: > > > On Mon, May 14, 2007 at 08:58:40AM -0700, Stephen Hemminger wrote: > > > Kenji Kaneshige found this r

Re: [PATCH] Fix race condition about network device name allocation

2007-06-13 Thread Dan Aloni
0x214 0x81006a46deb0 0x8037c9d4 class_attr_store+0x24 [1]more> 0x81006a46dec0 0x802bbe30 sysfs_write_file+0x100 0x81006a46df10 0x80277d7e vfs_write+0xbe 0x81006a46df40 0x80278400 sys_write+0x50 0x81006a46df80 0x80209e6e system_call+0x7e -- Dan Alon

Re: [linux-usb-devel] Dealing with flaky USB storage devices and rootfs

2007-05-29 Thread Dan Aloni
On Tue, May 29, 2007 at 05:50:49PM -0400, Alan Stern wrote: > On Tue, 29 May 2007, Dan Aloni wrote: > > > Hello, > > > > We have a system where the rootfs is a partition on a USB device, > > and I've noticed upon a few rare cases where the USB controller

Dealing with flaky USB storage devices and rootfs

2007-05-29 Thread Dan Aloni
know rootfs on USB is an uncommon use-case at the moment but I do like to know if there are some improvements planned in this area. -- Dan Aloni XIV LTD, http://www.xivstorage.com da-x (at) monatomic.org, dan (at) xiv.co.il - To unsubscribe from this list: send the line "unsubscribe linux-ke

[PATCH] kexec/kdump and kdb

2007-05-24 Thread Dan Aloni
struct pt_regs fixed_regs; + + crash_setup_regs(&fixed_regs, regs); + kdb_kexec_prepare(&fixed_regs); + machine_kexec(image); + } + + locked = xchg(&kexec_lock, 0); + BU

Re: [PATCH] allow kernel module exclusion on load

2007-05-16 Thread Dan Aloni
On Wed, May 16, 2007 at 07:33:21PM +, Pavel Machek wrote: > On Wed 2007-05-16 19:51:07, Dan Aloni wrote: > > On Tue, May 15, 2007 at 08:23:11AM +, Pavel Machek wrote: > > > On Sun 2007-05-13 19:20:35, Christoph Hellwig wrote: > > > > On Sun, May 13, 200

Re: [PATCH] allow kernel module exclusion on load

2007-05-16 Thread Dan Aloni
On Tue, May 15, 2007 at 08:23:11AM +, Pavel Machek wrote: > On Sun 2007-05-13 19:20:35, Christoph Hellwig wrote: > > On Sun, May 13, 2007 at 09:23:52AM -0700, Stephen Hemminger wrote: > > > On Sun, 13 May 2007 16:25:17 +0300 > > > Dan Aloni <[EMAIL PROTECTED]

  1   2   >