[PATCH] ASoC: tas2562: Remove duplicate code for I/V sense

2020-09-22 Thread Dan Murphy
Remove duplicate code for programming the I/V sense the call to update the register was duplicated in commit 09ed395b05feb ("ASoC: tas2562: Add voltage sense slot configuration"). Fixes: 09ed395b05feb ("ASoC: tas2562: Add voltage sense slot configuration") Signed-off-by: Da

Re: [PATCH] MAINTAINERS: move Milo Kim to credits

2020-09-22 Thread Dan Murphy
this year to fix random bugs. Since I have worked in these other subsystems if replacing the Maintainer is desired over removal then my name and email can be added like I did with Andrews. Dan Murphy Dan

Re: [PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header

2020-09-21 Thread Dan Murphy
Mark On 9/21/20 2:18 PM, Dan Murphy wrote: Mark On 9/21/20 2:04 PM, Mark Brown wrote: On Fri, Sep 18, 2020 at 02:05:45PM -0500, Dan Murphy wrote: Update the hardcoded masks with the GENMASK macro. Also update some of the hardcoded bits with the BIT macro Cleanups like this should come after

Re: [PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header

2020-09-21 Thread Dan Murphy
Mark On 9/21/20 2:04 PM, Mark Brown wrote: On Fri, Sep 18, 2020 at 02:05:45PM -0500, Dan Murphy wrote: Update the hardcoded masks with the GENMASK macro. Also update some of the hardcoded bits with the BIT macro Cleanups like this should come after any fixes in the series, that way fixes can

[PATCH 2/2] ASoC: tas2562: Add the TAS2110 class-D amplifier

2020-09-21 Thread Dan Murphy
Add the TAS2110 amplifier to the TAS2562 driver. The TAS2110 is register and bitmap compatible. The chips differ in that the TAS2110 does not have the I/V Sense feedback path. Since these features do not exist the device needs to be registered without these controls. Signed-off-by: Dan Murphy

[PATCH 1/2] dt-bindings: tas2562: Add the TAS2110 amplifier

2020-09-21 Thread Dan Murphy
Add the TAS2110 amplifier compatible. Signed-off-by: Dan Murphy --- This patchset is based on top of patchset https://lore.kernel.org/patchwork/project/lkml/list/?series=463709 Documentation/devicetree/bindings/sound/tas2562.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH net-next v2 1/3] ethtool: Add 100base-FX link mode entries

2020-09-18 Thread Dan Murphy
PHYAD: 1 Transceiver: external Supports Wake-on: gs Wake-on: d SecureOn password: 00:00:00:00:00:00 Current message level: 0x (0) Link detected: yes Signed-off-by: Dan Murphy --- v2 - Updated ethtool example in the commit message

[PATCH net-next v2 0/3] 100base Fx link modes

2020-09-18 Thread Dan Murphy
100Mbps. Corresponding user land ethtool patches are available but rely on these patches to be applied first. Dan Dan Murphy (3): ethtool: Add 100base-FX link mode entries net: dp83869: Add ability to advertise Fiber connection net: phy: dp83822: Update the fiber advertisement for speed

[PATCH net-next v2 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-18 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 73 +++ 1 file changed, 73

[PATCH net-next v2 3/3] net: phy: dp83822: Update the fiber advertisement for speed

2020-09-18 Thread Dan Murphy
Update the fiber advertisement for speed and duplex modes with the 100base-FX full and half linkmode entries. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83822.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy

Re: [PATCH] dt-bindings: tas2770: Fix I2C addresses for the TAS2770

2020-09-18 Thread Dan Murphy
All On 9/18/20 11:43 AM, Dan Murphy wrote: The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description. Please ignore this patch I added this patch intp a different patch series

[PATCH 9/9] ASoC: tas2770: Refactor sample rate function

2020-09-18 Thread Dan Murphy
Refactor the tas2770_set_samplerate to simplify the code and access the I2C bus only once per rate request. The ramp rate and sample rate bits are contained in the same register so a single call to the snd_soc_update_bits function is all that is needed Signed-off-by: Dan Murphy --- sound/soc

[PATCH 4/9] ASoC: tas2770: Fix required DT properties in the code

2020-09-18 Thread Dan Murphy
in the data sheet. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas27

[PATCH 3/9] dt-bindings: tas2770: Fix I2C addresses for the TAS2770

2020-09-18 Thread Dan Murphy
The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description. Fixes: 4b7151dadfd4 ("dt-bindings: ASoC: Add tas2770 smart PA dt bindings") Signed-off-by: Dan Murphy --- Doc

[PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header

2020-09-18 Thread Dan Murphy
Update the hardcoded masks with the GENMASK macro. Also update some of the hardcoded bits with the BIT macro Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.h | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/sound/soc/codecs

[PATCH 7/9] ASoC: tas2770: Fix error handling with update_bits

2020-09-18 Thread Dan Murphy
if there is a negative. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 52 ++ 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b

[PATCH 1/9] ASoC: tas2770: Fix calling reset in probe

2020-09-18 Thread Dan Murphy
770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index c09851834395..03d7ad1885b8 100644 --- a/sound/soc/codecs/tas2770.

[PATCH 2/9] ASoC: tas2770: Add missing bias level power states

2020-09-18 Thread Dan Murphy
Add the BIAS_STANDBY and BIAS_PREPARE to the set_bias_level or else the driver will return -EINVAL which is not correct as they are valid states. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 7 +

[PATCH 5/9] ASoC: tas2770: Fix unbalanced calls to pm_runtime

2020-09-18 Thread Dan Murphy
Fix the unbalanced call to the pm_runtime_disable when removing the module. pm_runtime_enable is not called nor is the pm_runtime setup in the code. Remove the i2c_remove function and the pm_runtime_disable. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-o

[PATCH 8/9] ASoC: tas2770: Fix the spacing and new lines

2020-09-18 Thread Dan Murphy
Fix up the spacing for argument alignment and add new lines to separate code. Eliminate unneccessary goto statements when the error code could just be returned. Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 300 - 1 file changed, 131 insertions

Re: [PATCH 1/2] ASoC: tas2770: Fix calling reset in probe

2020-09-18 Thread Dan Murphy
All On 9/18/20 11:18 AM, Dan Murphy wrote: tas2770_reset is called during i2c probe. The reset calls the snd_soc_component_write which depends on the tas2770->component being available. The component pointer is not set until codec_probe so move the reset to the codec_probe after the poin

[PATCH] dt-bindings: tas2770: Fix I2C addresses for the TAS2770

2020-09-18 Thread Dan Murphy
The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description. Fixes: 4b7151dadfd4 ("dt-bindings: ASoC: Add tas2770 smart PA dt bindings") Signed-off-by: Dan Murphy --- Doc

[PATCH 2/2] ASoC: tas2770: Add missing bias level power states

2020-09-18 Thread Dan Murphy
Add the BIAS_STANDBY and BIAS_PREPARE to the set_bias_level or else the driver will return -EINVAL which is not correct as they are valid states. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 7 +

[PATCH 1/2] ASoC: tas2770: Fix calling reset in probe

2020-09-18 Thread Dan Murphy
770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index c09851834395..03d7ad1885b8 100644 --- a/sound/soc/codecs/tas2770.

[PATCH 1/2] dt-bindings: tas2562: Add TAS2564 to binding

2020-09-18 Thread Dan Murphy
Add the TAS2564 compatible and data sheet link to the binding. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tas2562.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound

[PATCH 2/2] ASoC: tas2562: Add the TAS2564 compatible

2020-09-18 Thread Dan Murphy
Add the TAS2564 as a supported amplifier. This amplifier is register, bitmap and feature compatible to the TAS2562. Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2562.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c index

Re: [PATCH leds v2 15/50] leds: lm3697: cosmetic change: use helper variable, reverse christmas tree

2020-09-18 Thread Dan Murphy
Marek On 9/17/20 5:33 PM, Marek Behún wrote: Use helper variable dev instead of always writing >dev, or >client->dev, or even >priv->client->dev. With one more line moved reverse christmas tree is also achieved. Reviewed-by: Dan Murphy

[PATCH] MAINTAINERS: Remove Andrew F Davis from list

2020-09-17 Thread Dan Murphy
Andrews TI email is no longer valid and he indicated that it is OK to remove him from the MAINTAINERS file for the DMA HEAPS FRAMEWORK. For the BQ27xxx list I replaced Andrews email with mine. Signed-off-by: Dan Murphy --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-17 Thread Dan Murphy
Andrew On 9/16/20 5:13 PM, Andrew Lunn wrote: On Wed, Sep 16, 2020 at 03:54:34PM -0500, Dan Murphy wrote: Andrew On 9/15/20 3:17 PM, Andrew Lunn wrote: + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT, +phydev->suppor

Re: [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Dan Murphy
Geert On 9/17/20 8:57 AM, Geert Uytterhoeven wrote: Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the

Re: [PATCH leds v1 09/10] leds: lm36274: use struct led_init_data when registering

2020-09-17 Thread Dan Murphy
Marek On 9/16/20 6:16 PM, Marek Behún wrote: By using struct led_init_data when registering we do not need to parse `label` DT property nor `linux,default-trigger` property. A small refactor was also done: - with using devm_led_classdev_register_ext the driver remove method is not needed -

Re: [PATCH 5/6] dt-bindings: tlv320adcx140: Add slot programming property

2020-09-17 Thread Dan Murphy
Mark On 9/17/20 8:02 AM, Mark Brown wrote: On Tue, Sep 15, 2020 at 02:06:05PM -0500, Dan Murphy wrote: + ti,slot-mapping: +type: boolean +description: | + Each channel can be assigned a specific TDM slot for either a left or + right channel. The left channel values are from

Re: [PATCH v3 2/2] ASoC: tlv320adcx140: Add support for configuring GPIO pin

2020-09-17 Thread Dan Murphy
ine ADCX140_GPIO_CFG_MAX 15 +#define ADCX140_GPIO_DRV_MAX 5 + #endif /* _TLV320ADCX140_ */ Acked-by: Dan Murphy

Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-17 Thread Dan Murphy
Andrew On 9/15/20 6:29 PM, Dan Murphy wrote: Andrew On 9/15/20 3:21 PM, Andrew Lunn wrote: On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: Add entries for the 100base-FX full and half duplex supported modes. $ ethtool eth0 Supported ports: [ TP    MII FIBRE

Re: [PATCH leds v1 03/10] leds: lm3697: use struct led_init_data when registering

2020-09-17 Thread Dan Murphy
Marek On 9/16/20 6:16 PM, Marek Behún wrote: By using struct led_init_data when registering we do not need to parse `label` DT property nor `linux,default-trigger` property. I would prefer 2 separate patches. One implementing the init_data and the other removing the default trigger Dan

Re: [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-16 Thread Dan Murphy
Andrew On 9/15/20 3:17 PM, Andrew Lunn wrote: + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT, +phydev->supported); + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT, +phydev->supported); +

Re: [PATCH v2 3/3] ASoC: tlv320adcx140: Add proper support for master mode

2020-09-16 Thread Dan Murphy

Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-15 Thread Dan Murphy
Andrew On 9/15/20 3:21 PM, Andrew Lunn wrote: On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: Add entries for the 100base-FX full and half duplex supported modes. $ ethtool eth0 Supported ports: [ TPMII FIBRE ] Supported link modes: 10baseT/Half 10baseT

Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-15 Thread Dan Murphy
Andrew On 9/15/20 3:10 PM, Andrew Lunn wrote: On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: @@ -160,6 +160,8 @@ static const struct phy_setting settings[] = { PHY_SETTING(100, FULL,100baseT_Full ), PHY_SETTING(100, FULL,100baseT1_Full

Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add support for configuring GPIO pin

2020-09-15 Thread Dan Murphy
Camel On 9/15/20 1:41 PM, Dan Murphy wrote: Camel On 9/11/20 3:07 AM, Camel Guo wrote: From: Camel Guo One other thing for the device tree you need to add Rob Herring and devicet...@vger.kernel.org

[PATCH 4/6] ASoC: tlv320adcx140: Add the config to configure Tx ASI output

2020-09-15 Thread Dan Murphy
Add code to allow the ASI Tx output to be placed into High-z mode during unused ASI cycles. This allows for other devices that may be on the bus to drive the ASI out. By default the 320adcx140 sends 0's for unused cycles. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 11

[PATCH 5/6] dt-bindings: tlv320adcx140: Add slot programming property

2020-09-15 Thread Dan Murphy
Add a property to configure the each channel to a specific TDM slot. Signed-off-by: Dan Murphy --- .../bindings/sound/tlv320adcx140.yaml | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml b/Documentation

[PATCH 6/6] ASoC: tlv320adcx140: Add channel slot programming

2020-09-15 Thread Dan Murphy
Each channel can be assigned a specific slot to transmit data. This assignment is done in the device tree. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 17 + sound/soc/codecs/tlv320adcx140.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/sound/soc

[PATCH 2/6] ASoC: tlv320adcx140: Fix BCLK inversion for DSP modes

2020-09-15 Thread Dan Murphy
he codec bclk inversion should be disabled Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c index 3909c1cf52

[PATCH 1/6] ASoC: tlv320adcx140: Idle the device while writing registers

2020-09-15 Thread Dan Murphy
update is complete. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 43 sound/soc/codecs/tlv320adcx140.h | 2 ++ 2 files changed, 34 insertions(+), 11 deletions(-) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c

[PATCH 3/6] dt-bindings: tlv320adcx140: Add ASI Tx drive

2020-09-15 Thread Dan Murphy
Add a property to indicate if the device is to go into a High-z state on the Tx ASI output pins when the device is idle. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tlv320adcx140.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH v2 3/3] ASoC: tlv320adcx140: Add proper support for master mode

2020-09-15 Thread Dan Murphy
Camel On 9/11/20 3:07 AM, Camel Guo wrote: From: Camel Guo Add setup of bclk-to-ws ratio and sample rate when in master mode, as well as MCLK input pin setup. Signed-off-by: Camel Guo --- v2: - Move GPIO setting into devicetree - Move master config register setting into a new

Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add support for configuring GPIO pin

2020-09-15 Thread Dan Murphy
Camel On 9/11/20 3:07 AM, Camel Guo wrote: From: Camel Guo Add support to configure the GPIO pin to the specific configuration. The GPIO pin can be configured as GPO, IRQ, SDOUT2, PDMCLK, MICBASE_EN, GPI, MCLK, SDIN, PDMDIN1, PDMDIN2, PDMDIN3 or PDMDIN4 and the output drive can be configured

Re: [PATCH v2 1/3] dt-bindings: tlv320adcx140: Add GPIO config and drive config

2020-09-15 Thread Dan Murphy
the configuration and output driver for the general purpose s/driver/drive You capitalized the General Purpose Input and Output in the commit message but kept it lower case here. Beyond these Acked-by: Dan Murphy

[PATCH net-next 0/3] 100base Fx link modes

2020-09-15 Thread Dan Murphy
100Mbps. Corresponding user land ethtool patches are available but rely on these patches to be applied first. Dan Dan Murphy (3): ethtool: Add 100base-FX link mode entries net: dp83869: Add ability to advertise Fiber connection net: phy: dp83822: Update the fiber advertisement for speed

[PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

2020-09-15 Thread Dan Murphy
Supports Wake-on: gs Wake-on: d SecureOn password: 00:00:00:00:00:00 Current message level: 0x (0) Link detected: yes Signed-off-by: Dan Murphy --- drivers/net/phy/phy-core.c | 4 +++- include/uapi/linux/ethtool.h | 2 ++ net/ethtool/common.c

[PATCH net-next 3/3] net: phy: dp83822: Update the fiber advertisement for speed

2020-09-15 Thread Dan Murphy
Update the fiber advertisement for speed and duplex modes with the 100base-FX full and half linkmode entries. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83822.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy

[PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-15 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 73 +++ 1 file changed, 73

Re: [PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-10 Thread Dan Murphy
Andrew On 9/10/20 1:02 PM, Andrew Lunn wrote: static int dp83869_config_port_mirroring(struct phy_device *phydev) { struct dp83869_private *dp83869 = phydev->priv; Overall this code looks quite similar to dp83867, is there no way to factor this out? Factor what out?  Yes the

Re: [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-10 Thread Dan Murphy
Hello On 9/7/20 9:29 AM, Andrew Lunn wrote: On Sat, Sep 05, 2020 at 11:17:55AM -0700, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:57 -0500 Dan Murphy wrote: Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-10 Thread Dan Murphy
Jakub On 9/8/20 12:47 PM, Jakub Kicinski wrote: On Tue, 8 Sep 2020 09:07:22 -0500 Dan Murphy wrote: On 9/5/20 1:38 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) +{ + int val, count

Re: [PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-10 Thread Dan Murphy
Jakub Thanks for the review On 9/5/20 1:34 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:58 -0500 Dan Murphy wrote: This adds WoL support on TI DP83869 for magic, magic secure, unicast and broadcast. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 128

[RFC] Device addition to the tlv320adcx140 and tas2562

2020-09-09 Thread Dan Murphy
Hello Looking for guidance on how to move forward with adding a device to existing drivers. For the TLV320adcx140 driver I have another device which is register and bitmap compatible but it does not support Analog microphones or Line In like the x140. Should I add a new driver

Re: [PATCH 2/7] power: supply: bq27xxx: report "not charging" on all types

2020-09-08 Thread Dan Murphy
Krzysztof On 9/8/20 3:13 PM, Krzysztof Kozlowski wrote: Commit 6f24ff97e323 ("power: supply: bq27xxx_battery: Add the BQ27Z561 Battery monitor") and commit d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices") added support for new device types by copying

Re: [PATCH 4/7] power: supply: bq27xxx: use BIT() for bit flags

2020-09-08 Thread Dan Murphy
Krzysztof On 9/8/20 3:13 PM, Krzysztof Kozlowski wrote: BIT() is a preferred way to toggle bit-like flags: no problems with 32/64 bit systems, less chances for mistakes. Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/bq27xxx_battery.c | 15 --- 1 file changed, 8

Re: [PATCH 2/2] power: bq27xxx: Fix spacing style and white space issues

2020-09-08 Thread Dan Murphy
Krzysztof On 9/8/20 3:32 PM, Krzysztof Kozlowski wrote: On Thu, 30 Jul 2020 at 16:32, Dan Murphy wrote: Fix spacing style issues with the chip data array. As well as fix missing new line after variable declaration. Signed-off-by: Dan Murphy --- drivers/power/supply/bq27xxx_battery.c | 63

Re: [PATCH 2/2] ASoC: tlv320adcx140: Wake up codec before accessing register

2020-09-08 Thread Dan Murphy
Camel On 9/8/20 3:35 AM, Camel Guo wrote: From: Camel Guo According to its datasheet, after reset this codec goes into sleep mode. In this mode, any register accessing should be avoided except for exiting sleep mode. Hence this commit moves SLEEP_CFG access before any register accessing.

Re: [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360

2020-09-08 Thread Dan Murphy
Gene On 9/7/20 5:27 AM, Gene Chen wrote: In-Reply-To: This patch series add MT6360 LED support contains driver and binding document I cannot find the v2 patch series for this. Dan

Re: [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED

2020-09-08 Thread Dan Murphy
then this? Other wise Reviewed-by: Dan Murphy

Re: [PATCH 1/2] ASoC: tlv320adcx140: Avoid accessing invalid gpio_reset

2020-09-08 Thread Dan Murphy

Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360

2020-09-08 Thread Dan Murphy
Gene On 9/7/20 5:27 AM, Gene Chen wrote: From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, and 4-channel RGB LED support Register/Flash/Breath Mode Signed-off-by: Gene Chen --- drivers/leds/Kconfig | 11 + drivers/leds/Makefile | 1 +

Re: [PATCH 2/2] ASoC: tlv320adcx140: Wake up codec before accessing register

2020-09-08 Thread Dan Murphy
Camel On 9/8/20 6:49 AM, Dan Murphy wrote: Camel On 9/8/20 3:35 AM, Camel Guo wrote: From: Camel Guo According to its datasheet, after reset this codec goes into sleep mode. In this mode, any register accessing should be avoided except for exiting sleep mode. Hence this commit moves

Re: [PATCH] ASoC: tlv320adcx140: Add support for master mode

2020-09-08 Thread Dan Murphy
Camel On 9/8/20 4:18 AM, Camel Guo wrote: From: Camel Guo Add setup of bclk-to-ws ratio and sample rate when in master mode, as well as MCLK input pin setup. The patches you submitted need to go on the sound/for-next branch as it does not apply cleanly.

Re: [PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-08 Thread Dan Murphy
Jakub On 9/5/20 1:38 PM, Jakub Kicinski wrote: On Thu, 3 Sep 2020 06:42:59 -0500 Dan Murphy wrote: +static int dp83869_set_downshift(struct phy_device *phydev, u8 cnt) +{ + int val, count; + + if (cnt > DP83869_DOWNSHIFT_8_COUNT) + return -E2BIG; ERA

[PATCH net-next v2] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Dan Murphy
Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Reviewed-by: Florian Fainelli Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 45 ++- 1 file changed

Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Dan Murphy
Florian On 9/3/20 11:34 AM, Florian Fainelli wrote: On 9/3/2020 7:15 AM, Dan Murphy wrote: Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-by: Dan Murphy ---   drivers/net/phy

[PATCH net-next v3 0/3] DP83869 Feature additions

2020-09-03 Thread Dan Murphy
supports Wake on Lan feature with SecureOn password. Downshift: Speed optimization or AKA downshift is also supported by this PHY. Dan Dan Murphy (3): net: dp83869: Add ability to advertise Fiber connection net: phy: dp83869: support Wake on LAN net: dp83869: Add speed optimization feature

[PATCH net-next v3 2/3] net: phy: dp83869: support Wake on LAN

2020-09-03 Thread Dan Murphy
This adds WoL support on TI DP83869 for magic, magic secure, unicast and broadcast. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 128 ++ 1 file changed, 128 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index

[PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-03 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 36 1 file changed, 36

[PATCH net] net: phy: dp83867: Fix various styling and space issues

2020-09-03 Thread Dan Murphy
Fix spacing issues reported for misaligned switch..case and extra new lines. Also updated the file header to comply with networking commet style. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 47 ++- 1 file changed, 22 insertions(+), 25 deletions

[PATCH net-next v3 3/3] net: dp83869: Add speed optimization feature

2020-09-03 Thread Dan Murphy
connected instead of the standard cabling with eight wires (four twisted pairs). The number of failed link attempts before falling back to 100M operation is configurable. By default, four failed link attempts are required before falling back to 100M. Signed-off-by: Dan Murphy --- v3 - Fixed checkpatch

Re: [PATCH net-next v2 3/3] net: dp83869: Add speed optimization feature

2020-09-03 Thread Dan Murphy
Jakub On 9/2/20 9:06 PM, Jakub Kicinski wrote: On Wed, 2 Sep 2020 15:34:44 -0500 Dan Murphy wrote: Set the speed optimization bit on the DP83869 PHY. Speed optimization, also known as link downshift, enables fallback to 100M operation after multiple consecutive failed attempts at Gigabit link

[PATCH net-next v2 3/3] net: dp83869: Add speed optimization feature

2020-09-02 Thread Dan Murphy
connected instead of the standard cabling with eight wires (four twisted pairs). The number of failed link attempts before falling back to 100M operation is configurable. By default, four failed link attempts are required before falling back to 100M. Signed-off-by: Dan Murphy --- drivers/net/phy

[PATCH net-next v2 2/3] net: phy: dp83869: support Wake on LAN

2020-09-02 Thread Dan Murphy
This adds WoL support on TI DP83869 for magic, magic secure, unicast and broadcast. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 128 ++ 1 file changed, 128 insertions(+) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index

[PATCH net-next v2 0/3] DP83869 Feature additions

2020-09-02 Thread Dan Murphy
that this PHY supports fiber. WoL: The PHY also supports Wake on Lan feature with SecureOn password. Downshift: Speed optimization or AKA downshift is also supported by this PHY. Dan Murphy (3): net: dp83869: Add ability to advertise Fiber connection net: phy: dp83869: support Wake on LAN net

[PATCH net-next v2 1/3] net: dp83869: Add ability to advertise Fiber connection

2020-09-02 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 36 1 file changed, 36

[PATCH net] net: dp83867: Fix WoL SecureOn password

2020-09-02 Thread Dan Murphy
Fix the registers being written to as the values were being over written when writing the same registers. Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH net-next] net: dp83869: Add ability to advertise Fiber connection

2020-09-02 Thread Dan Murphy
On 9/2/20 8:25 AM, Dan Murphy wrote: Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 35

[PATCH net-next] net: dp83869: Add ability to advertise Fiber connection

2020-09-02 Thread Dan Murphy
Add the ability to advertise the Fiber connection if the strap or the op-mode is configured for 100Base-FX. Auto negotiation is not supported on this PHY when in fiber mode. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 35 +++ 1 file changed, 35

Re: [PATCH v2] can: m_can: Set device to software init mode before closing

2020-09-01 Thread Dan Murphy
*/ + m_can_config_endisable(cdev, true); + /* set the state as STOPPED */ cdev->can.state = CAN_STATE_STOPPED; } Acked-by: Dan Murphy

Re: [PATCH] ASoC: tlv320adcx140: Fix accessing uninitialized abcx140->dev

2020-09-01 Thread Dan Murphy
Camel On 9/1/20 2:27 AM, Camel Guo wrote: From: Camel Guo in adcx140_i2c_probe, adcx140->dev is accessed before its initialization. This commit fixes this bug. s/abc/adc in the subject and s/in/In Also please add a Fixes tag. Otherwise Acked-by: Dan Murphy

[PATCH 1/2] dt-binding: bq25980: Add the bq25980 flash charger

2020-08-31 Thread Dan Murphy
Add yaml for the bq25980 flash charger. Signed-off-by: Dan Murphy --- .../bindings/power/supply/bq25980.yaml| 114 ++ 1 file changed, 114 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/bq25980.yaml diff --git a/Documentation/devicetree

[PATCH 2/2] power: bq25980: Add support for the BQ259xx family

2020-08-31 Thread Dan Murphy
Add support for the BQ25980, BQ25975 and BQ25960 family of flash chargers. Signed-off-by: Dan Murphy --- drivers/power/supply/Kconfig |9 + drivers/power/supply/Makefile |1 + drivers/power/supply/bq25980_charger.c | 1316 drivers/power/supply

Re: [PATCH v33 6/6] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

2020-08-28 Thread Dan Murphy
Linus On 8/27/20 5:58 PM, Linus Walleij wrote: On Wed, Aug 12, 2020 at 9:50 PM Dan Murphy wrote: Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow

[PATCH] ASoC: tlv320adcx140: Add digital mic channel enable routing

2020-08-28 Thread Dan Murphy
Add the audio routing map to enable the digital mic paths when the analog mic paths are not enabled. Signed-off-by: Dan Murphy --- sound/soc/codecs/tlv320adcx140.c | 37 1 file changed, 37 insertions(+) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc

[PATCH net-next v3 0/2] Enable Fiber on DP83822 PHY

2020-08-27 Thread Dan Murphy
be it the PHY will not perform signal loss detection. v2 review from a long time ago can be found here - https://lore.kernel.org/patchwork/patch/1270958/ Dan Dan Murphy (2): dt-bindings: net: dp83822: Add TI dp83822 phy net: phy: DP83822: Add ability to advertise Fiber connection .../devicetree

[PATCH net-next v3 2/2] net: phy: DP83822: Add ability to advertise Fiber connection

2020-08-27 Thread Dan Murphy
signal. Fiber mode is only applicable to the DP83822 so rework the PHY match table so that non-fiber PHYs can still use the same driver but not call or use any of the fiber features. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83822.c | 225 -- 1 file changed

[PATCH net-next v3 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-08-27 Thread Dan Murphy
Add a dt binding for the TI dp83822 ethernet phy device. Reviewed-by: Rob Herring Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83822.yaml | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml

Re: [PATCH 2/2] dt-bindings: leds: Add bindings for MT6360 LED

2020-08-26 Thread Dan Murphy
Gene On 8/26/20 6:37 AM, Gene Chen wrote: From: Gene Chen Add bindings document for LED support on MT6360 PMIC Usually bindings are 1/x in the patchset. And you should cc Rob Herring and the Device tree mail list other wise the maintainer will not apply this patch without their ACKs

Re: [PATCH 1/2] leds: mt6360: Add LED driver for MT6360

2020-08-26 Thread Dan Murphy
Hello On 8/26/20 6:37 AM, Gene Chen wrote: From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, and 4-channel RGB LED support Register/Flash/Breath Mode Signed-off-by: Gene Chen --- drivers/leds/Kconfig | 11 + drivers/leds/Makefile |

Re: [PATCH] dt: bindings: lp55xx: Updte yaml examples with new color ID

2020-08-18 Thread Dan Murphy
Pavel On 8/12/20 2:32 PM, Dan Murphy wrote: Update the binding examples for the color ID to LED_COLOR_ID_RGB Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree

Re: [PATCH v1 1/2] dt-bindings: power: Add the bq256xx dt bindings

2020-08-18 Thread Dan Murphy
Rob On 8/18/20 11:43 AM, Rob Herring wrote: On Mon, Aug 17, 2020 at 02:17:22PM -0500, Ricardo Rivera-Matos wrote: Add the bindings for the bq256xx series of battery charging ICs. Datasheets: - https://www.ti.com/lit/ds/symlink/bq25600.pdf - https://www.ti.com/lit/ds/symlink/bq25601.pdf -

Re: [PATCH v33 0/6] LP50xx addition and remainder Multicolor patches

2020-08-17 Thread Dan Murphy
Pavel On 8/17/20 3:35 PM, Pavel Machek wrote: Hi! These are the final patches from the original multicolor framework patchset. Changes made were to the LP50xx to rework regmap_defaults to eliminate used only once #defines. Also fixed putting the child node in the dt parsing and changed

[PATCH 2/2] dt-bindings: tas2562: Add device specification links

2020-08-17 Thread Dan Murphy
Add device specification links for the TAS2562 and TAS2563. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tas2562.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml b/Documentation/devicetree/bindings/sound

[PATCH 1/2] dt-bindings: tas2562: Remove tas2562 text file

2020-08-17 Thread Dan Murphy
Remove the tas2562 text file as the tas2562.yaml is now available. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2562.txt | 37 --- 1 file changed, 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/tas2562.txt diff --git

<    1   2   3   4   5   6   7   8   9   10   >