Re: [PATCH net-next v7 2/6] net: phy: Add a helper to return the index for of the internal delay

2020-06-18 Thread Dan Murphy
Andrew On 6/17/20 8:51 PM, Andrew Lunn wrote: On Wed, Jun 17, 2020 at 01:20:15PM -0500, Dan Murphy wrote: Add a helper function that will return the index in the array for the passed in internal delay value. The helper requires the array, size and delay value. The helper will then return

Re: [RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx

2020-06-17 Thread Dan Murphy
Jacek On 6/17/20 4:41 PM, Jacek Anaszewski wrote: Dan, On 6/17/20 9:22 PM, Dan Murphy wrote: Pavel/Jacek On 6/17/20 11:28 AM, kernel test robot wrote: Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on pavel-linux-leds/for-next] [cannot apply to j.anaszewski

Re: [RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx

2020-06-17 Thread Dan Murphy
improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v27/20200616-042217 base: git://git.kernel.org/pub/scm/linux

Re: [PATCH net-next v7 6/6] net: phy: DP83822: Add ability to advertise Fiber connection

2020-06-17 Thread Dan Murphy
All On 6/17/20 1:20 PM, Dan Murphy wrote: The DP83822 can be configured to use the RGMII interface. There are independent fixed 3.5ns clock shift (aka internal delay) for the TX and RX paths. This allow either one to be set if the MII interface is RGMII and the value is set in the firmware node

[PATCH net-next v7 2/6] net: phy: Add a helper to return the index for of the internal delay

2020-06-17 Thread Dan Murphy
Add a helper function that will return the index in the array for the passed in internal delay value. The helper requires the array, size and delay value. The helper will then return the index for the exact match or return the index for the index to the closest smaller value. Signed-off-by: Dan

[PATCH net-next v7 5/6] dt-bindings: net: dp83822: Add TI dp83822 phy

2020-06-17 Thread Dan Murphy
Add a dt binding for the TI dp83822 ethernet phy device. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83822.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ti,dp83822.yaml diff --git a/Documentation

[PATCH net-next v7 0/6] RGMII Internal delay common property

2020-06-17 Thread Dan Murphy
in the firmware is returned. This series contains examples of both a configurable delay and a fixed delay. Dan Murphy (6): dt-bindings: net: Add tx and rx internal delays net: phy: Add a helper to return the index for of the internal delay dt-bindings: net: Add RGMII internal delay

[PATCH net-next v7 4/6] net: dp83869: Add RGMII internal delay configuration

2020-06-17 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 53 --- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index 53ed3abc26c9

[PATCH net-next v7 3/6] dt-bindings: net: Add RGMII internal delay for DP83869

2020-06-17 Thread Dan Murphy
Add the internal delay values into the header and update the binding with the internal delay properties. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ti,dp83869.yaml | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree

[PATCH net-next v7 6/6] net: phy: DP83822: Add ability to advertise Fiber connection

2020-06-17 Thread Dan Murphy
The DP83822 can be configured to use the RGMII interface. There are independent fixed 3.5ns clock shift (aka internal delay) for the TX and RX paths. This allow either one to be set if the MII interface is RGMII and the value is set in the firmware node. Signed-off-by: Dan Murphy --- drivers

[PATCH net-next v7 1/6] dt-bindings: net: Add tx and rx internal delays

2020-06-17 Thread Dan Murphy
. Signed-off-by: Dan Murphy --- .../devicetree/bindings/net/ethernet-phy.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml index 9b1f1147ca36

[PATCH v28 15/15] leds: lp5523: Fix various formatting issues in the code

2020-06-17 Thread Dan Murphy
Fix checkpatch errors and warnings for the LP5523.c device driver. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/leds/leds-lp5523.c b

[PATCH v28 13/15] leds: lp5521: Add multicolor framework multicolor brightness support

2020-06-17 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers

[PATCH v28 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

2020-06-17 Thread Dan Murphy
-by: Dan Murphy CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch

[PATCH v28 10/15] leds: lp55xx: Convert LED class registration to devm_*

2020-06-17 Thread Dan Murphy
Convert the LED class registration calls to the LED devm_* registration calls. Acked-by: Jacek Anaszewski Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5521.c| 9 +++-- drivers/leds/leds-lp5523.c| 9 +++-- drivers/leds/leds-lp5562.c

[PATCH v28 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function

2020-06-17 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels in a single function. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds

[PATCH v28 11/15] leds: lp55xx: Add multicolor framework support to lp55xx

2020-06-17 Thread Dan Murphy
Add multicolor framework support for the lp55xx family. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp5521.c| 14 +- drivers/leds/leds-lp5523.c| 14

[PATCH v28 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node

2020-06-17 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy Acked

[PATCH v28 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

2020-06-17 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy CC: Linus

[PATCH v28 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros

2020-06-17 Thread Dan Murphy
documentation. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c

[PATCH v28 02/15] leds: Add multicolor ID to the color ID list

2020-06-17 Thread Dan Murphy
Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors. Signed-off-by: Dan Murphy --- drivers/leds/led-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/led

[PATCH v28 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-17 Thread Dan Murphy
to obtain different colors independent of the overall brightness of the LED grouping. Datasheet: http://www.ti.com/lit/ds/symlink/lp5012.pdf http://www.ti.com/lit/ds/symlink/lp5024.pdf http://www.ti.com/lit/ds/symlink/lp5036.pdf Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy

[PATCH v28 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml

2020-06-17 Thread Dan Murphy
Convert the leds-lp55xx.txt to yaml binding. Signed-off-by: Dan Murphy --- .../devicetree/bindings/leds/leds-lp55xx.txt | 228 -- .../devicetree/bindings/leds/leds-lp55xx.yaml | 220 + 2 files changed, 220 insertions(+), 228 deletions(-) delete mode 100644

[PATCH v28 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-06-17 Thread Dan Murphy
has the ability to group LED output into control banks so that multiple LED banks can be controlled with the same mixing and brightness. Inversely the LEDs can also be controlled independently. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 11 + drivers

[PATCH v28 01/15] dt: bindings: Add multicolor class dt bindings documention

2020-06-17 Thread Dan Murphy
Add DT bindings for the LEDs multicolor class framework. Add multicolor ID to the color ID list for device tree bindings. CC: Rob Herring Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../bindings/leds/leds-class-multicolor.yaml | 37

[PATCH v28 00/15] Multicolor Framework v28

2020-06-17 Thread Dan Murphy
of LEDs Minor changes to the lp55xx yaml for min and max of led-cur Removed if check in the multicolor file in the for loop. Dan Dan Murphy (15): dt: bindings: Add multicolor class dt bindings documention leds: Add multicolor ID to the color ID list leds: multicolor: Introduce a multicolor class

[PATCH v28 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-17 Thread Dan Murphy
. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 36 +++ Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 88 drivers/leds/Kconfig | 10 + drivers

Re: [RESEND PATCH v27 00/15] Multicolor Framework v27

2020-06-15 Thread Dan Murphy
Pavel On 6/15/20 3:27 PM, Pavel Machek wrote: Hi! This is the multi color LED framework. This framework presents clustered colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write. The individual colored LEDs intensities are

[RESEND PATCH v27 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node

2020-06-15 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy Acked

[RESEND PATCH v27 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml

2020-06-15 Thread Dan Murphy
Convert the leds-lp55xx.txt to yaml binding. Signed-off-by: Dan Murphy --- .../devicetree/bindings/leds/leds-lp55xx.txt | 228 -- .../devicetree/bindings/leds/leds-lp55xx.yaml | 218 + 2 files changed, 218 insertions(+), 228 deletions(-) delete mode 100644

[RESEND PATCH v27 15/15] leds: lp5523: Fix various formatting issues in the code

2020-06-15 Thread Dan Murphy
Fix checkpatch errors and warnings for the LP5523.c device driver. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/leds/leds-lp5523.c b

[RESEND PATCH v27 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-06-15 Thread Dan Murphy
has the ability to group LED output into control banks so that multiple LED banks can be controlled with the same mixing and brightness. Inversely the LEDs can also be controlled independently. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 11 + drivers

[RESEND PATCH v27 13/15] leds: lp5521: Add multicolor framework multicolor brightness support

2020-06-15 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers

[RESEND PATCH v27 02/15] leds: Add multicolor ID to the color ID list

2020-06-15 Thread Dan Murphy
Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors. Signed-off-by: Dan Murphy --- drivers/leds/led-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/led

[RESEND PATCH v27 01/15] dt: bindings: Add multicolor class dt bindings documention

2020-06-15 Thread Dan Murphy
Add DT bindings for the LEDs multicolor class framework. Add multicolor ID to the color ID list for device tree bindings. CC: Rob Herring Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../bindings/leds/leds-class-multicolor.yaml | 37

[RESEND PATCH v27 10/15] leds: lp55xx: Convert LED class registration to devm_*

2020-06-15 Thread Dan Murphy
Convert the LED class registration calls to the LED devm_* registration calls. Acked-by: Jacek Anaszewski Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5521.c| 9 +++-- drivers/leds/leds-lp5523.c| 9 +++-- drivers/leds/leds-lp5562.c

[RESEND PATCH v27 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros

2020-06-15 Thread Dan Murphy
documentation. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c

[RESEND PATCH v27 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-15 Thread Dan Murphy
to obtain different colors independent of the overall brightness of the LED grouping. Datasheet: http://www.ti.com/lit/ds/symlink/lp5012.pdf http://www.ti.com/lit/ds/symlink/lp5024.pdf http://www.ti.com/lit/ds/symlink/lp5036.pdf Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy

[RESEND PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function

2020-06-15 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels in a single function. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds

[RESEND PATCH v27 00/15] Multicolor Framework v27

2020-06-15 Thread Dan Murphy
of LEDs Dan Dan Murphy (15): dt: bindings: Add multicolor class dt bindings documention leds: Add multicolor ID to the color ID list leds: multicolor: Introduce a multicolor class definition dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers leds: lp50xx: Add the LP50XX family

[RESEND PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-15 Thread Dan Murphy
. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 36 +++ Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 88 drivers/leds/Kconfig | 10 + drivers

[RESEND PATCH v27 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

2020-06-15 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy CC: Linus

[RESEND PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx

2020-06-15 Thread Dan Murphy
Add multicolor framework support for the lp55xx family. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp5521.c| 14 +- drivers/leds/leds-lp5523.c| 14

[RESEND PATCH v27 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

2020-06-15 Thread Dan Murphy
-by: Dan Murphy CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch

Re: [RESEND PATCH] dt-bindings: property-units: Add picoseconds type

2020-06-12 Thread Dan Murphy
Rob On 6/12/20 5:17 PM, Rob Herring wrote: On Thu, Jun 11, 2020 at 02:46:28PM -0500, Dan Murphy wrote: Bump Merge window. Will apply when over. No worries.  Just wanted to make sure it was seen and not lost. Dan

Re: [RFC PATCH 2/2] ASoc: tas2563: DSP Firmware loading support

2020-06-12 Thread Dan Murphy
Mark On 6/9/20 12:50 PM, Mark Brown wrote: On Tue, Jun 09, 2020 at 12:28:41PM -0500, Dan Murphy wrote: .val_bits = 8, - .max_register = 5 * 128, + .max_register = 255 * 128, .cache_type = REGCACHE_RBTREE, .reg_defaults = tas2562_reg_defaults

[PATCH v4 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-12 Thread Dan Murphy
Update the shutdown GPIO property to be shutdown from shut-down. Fixes: c173dba44c2d2 ("ASoC: tas2562: Introduce the TAS2562 amplifier") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2562.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a

[PATCH 1/2] dt-bindings: tas2770: Convert tas2770 binding to yaml

2020-06-12 Thread Dan Murphy
Convert the tas2770 binding to yaml format. Add in the reset-gpio to the binding as it is in the code but not documented in the binding. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2770.txt | 37 - .../devicetree/bindings/sound/tas2770.yaml| 76

[PATCH v4 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml

2020-06-12 Thread Dan Murphy
Convert the TAS2562 text file to yaml format. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2562.txt | 34 - .../devicetree/bindings/sound/tas2562.yaml| 69 +++ 2 files changed, 69 insertions(+), 34 deletions(-) delete mode 100644 Documentation

[PATCH 2/2] ASoC: tas2770: Fix reset gpio property name

2020-06-12 Thread Dan Murphy
Fix the reset property name when allocating the GPIO descriptor. The gpiod_get_optional appends either the -gpio or -gpios suffix to the name. Fixes: 1a476abc723e6 ("tas2770: add tas2770 smart PA kernel driver") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2770.c | 3 +-- 1 file

Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-12 Thread Dan Murphy
Mark On 6/12/20 11:30 AM, Mark Brown wrote: On Fri, Jun 12, 2020 at 11:27:04AM -0500, Dan Murphy wrote: Well should we then just revert back to the non-standard name and just fix up the code? Or should we support both properties? Either option is fine for me, supporting both is a little

Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-12 Thread Dan Murphy
Mark On 6/12/20 11:22 AM, Mark Brown wrote: On Fri, Jun 12, 2020 at 11:18:57AM -0500, Dan Murphy wrote: On 6/12/20 11:09 AM, Mark Brown wrote: On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote: - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-d

Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-12 Thread Dan Murphy
Mark On 6/12/20 11:09 AM, Mark Brown wrote: On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote: - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio", + tas2562->sdz_gpio = devm_gpiod_get_optiona

[PATCH v3 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml

2020-06-12 Thread Dan Murphy
Convert the TAS2562 text file to yaml format. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2562.txt | 34 -- .../devicetree/bindings/sound/tas2562.yaml| 65 +++ 2 files changed, 65 insertions(+), 34 deletions(-) delete mode 100644 Documentation

[PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property

2020-06-12 Thread Dan Murphy
Update the shutdown GPIO property to be shutdown from shut-down. Fixes: c173dba44c2d2 ("ASoC: tas2562: Introduce the TAS2562 amplifier") Signed-off-by: Dan Murphy --- sound/soc/codecs/tas2562.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/t

Re: [PATCH v2 1/4] dt-bindings: power: Add BQ27561 compatible

2020-06-11 Thread Dan Murphy
Bump to the series On 5/28/20 7:21 AM, Dan Murphy wrote: Add the Texas Instruments bq27561 battery monitor to the bq27xxx binding. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/power/supply/bq27xxx.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

Re: [RESEND PATCH] dt-bindings: property-units: Add picoseconds type

2020-06-11 Thread Dan Murphy
Bump On 6/2/20 11:42 AM, Dan Murphy wrote: Add the '-ps' picosecond unit suffix for property names. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/property-units.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/property-units.txt b

Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563

2020-06-10 Thread Dan Murphy
Mark On 6/10/20 5:29 AM, Mark Brown wrote: On Tue, Jun 09, 2020 at 02:20:29PM -0500, Dan Murphy wrote: On 6/9/20 1:47 PM, Mark Brown wrote: That's really not very idiomatic for how Linux does stuff and seems to pretty much guarantee issues with hotplugging controls and ordering - you'd need

Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563

2020-06-09 Thread Dan Murphy
Mark On 6/9/20 1:47 PM, Mark Brown wrote: On Tue, Jun 09, 2020 at 01:06:50PM -0500, Dan Murphy wrote: I could make a default as you suggested to include i2c address and bus in the name.  But the TAS2563 does not need the firmware to operate and the 2562 does not have a DSP. That's fine

Re: [RFC PATCH 0/2] TAS2563 DSP Firmware Loader

2020-06-09 Thread Dan Murphy
Mark On 6/9/20 12:52 PM, Mark Brown wrote: On Tue, Jun 09, 2020 at 12:28:39PM -0500, Dan Murphy wrote: These programs and configurations are selectable via files under the I2C dev node. There may be a better way to select this through ALSA controls but I was unable to find a good example

Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563

2020-06-09 Thread Dan Murphy
Mark On 6/9/20 12:58 PM, Mark Brown wrote: On Tue, Jun 09, 2020 at 12:35:50PM -0500, Dan Murphy wrote: On 6/9/20 12:31 PM, Mark Brown wrote: Why not just use a standard name for the firmware? If the firmwares vary per-board then building it using the machine compatible (or DMI info) could

Re: [RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563

2020-06-09 Thread Dan Murphy
Mark On 6/9/20 12:31 PM, Mark Brown wrote: On Tue, Jun 09, 2020 at 12:28:40PM -0500, Dan Murphy wrote: Add a property called firmware-name that will be the name of the firmware that will reside in the file system or built into the kernel. Why not just use a standard name for the firmware

[RFC PATCH 2/2] ASoc: tas2563: DSP Firmware loading support

2020-06-09 Thread Dan Murphy
in real time as the binary may contain different audio profiles. If the DSP is not needed to do audio preocessing then the DSP program can be turned off and the device will effectively turn off the DSP. Signed-off-by: Dan Murphy --- sound/soc/codecs/Makefile | 2 +- sound/soc

[RFC PATCH 1/2] dt-bindings: tas2562: Add firmware support for tas2563

2020-06-09 Thread Dan Murphy
Add a property called firmware-name that will be the name of the firmware that will reside in the file system or built into the kernel. Signed-off-by: Dan Murphy --- Documentation/devicetree/bindings/sound/tas2562.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation

[RFC PATCH 0/2] TAS2563 DSP Firmware Loader

2020-06-09 Thread Dan Murphy
are selectable via files under the I2C dev node. There may be a better way to select this through ALSA controls but I was unable to find a good example of this. This is why this is an RFC patchset. Dan Dan Murphy (2): dt-bindings: tas2562: Add firmware support for tas2563 ASoc: tas2563: DSP

[PATCH v2] dt-bindings: tas2562: Convert the tas2562 binding to yaml

2020-06-09 Thread Dan Murphy
Convert the TAS2562 text file to yaml format. Signed-off-by: Dan Murphy --- .../devicetree/bindings/sound/tas2562.txt | 34 -- .../devicetree/bindings/sound/tas2562.yaml| 65 +++ 2 files changed, 65 insertions(+), 34 deletions(-) delete mode 100644 Documentation

Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-09 Thread Dan Murphy
Jacek On 6/8/20 2:41 PM, Jacek Anaszewski wrote: Dan, On 6/8/20 4:34 PM, Dan Murphy wrote: Jacek On 6/6/20 2:59 PM, Jacek Anaszewski wrote: Dan, On 6/6/20 6:39 PM, Dan Murphy wrote: Pavek Thanks for the review On 6/6/20 10:53 AM, Pavel Machek wrote: Hi! Introduce a multicolor class

[PATCH v27 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node

2020-06-08 Thread Dan Murphy
-by: Dan Murphy CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch

[PATCH v27 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros

2020-06-08 Thread Dan Murphy
documentation. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c

[PATCH v27 10/15] leds: lp55xx: Convert LED class registration to devm_*

2020-06-08 Thread Dan Murphy
Convert the LED class registration calls to the LED devm_* registration calls. Acked-by: Jacek Anaszewski Acked-by: Pavel Machek Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5521.c| 9 +++-- drivers/leds/leds-lp5523.c| 9 +++-- drivers/leds/leds-lp5562.c

[PATCH v27 13/15] leds: lp5521: Add multicolor framework multicolor brightness support

2020-06-08 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This function allows setting the brightness across grouped LED channels in a single call. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers

[PATCH v27 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml

2020-06-08 Thread Dan Murphy
Convert the leds-lp55xx.txt to yaml binding. Signed-off-by: Dan Murphy --- .../devicetree/bindings/leds/leds-lp55xx.txt | 228 -- .../devicetree/bindings/leds/leds-lp55xx.yaml | 218 + 2 files changed, 218 insertions(+), 228 deletions(-) delete mode 100644

[PATCH v27 15/15] leds: lp5523: Fix various formatting issues in the code

2020-06-08 Thread Dan Murphy
Fix checkpatch errors and warnings for the LP5523.c device driver. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/leds-lp5523.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/leds/leds-lp5523.c b

[PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function

2020-06-08 Thread Dan Murphy
Add the multicolor brightness call back to support the multicolor framework. This call back allows setting brightness on grouped channels in a single function. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds

[PATCH v27 11/15] leds: lp55xx: Add multicolor framework support to lp55xx

2020-06-08 Thread Dan Murphy
Add multicolor framework support for the lp55xx family. Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp5521.c| 14 +- drivers/leds/leds-lp5523.c| 14

[PATCH v27 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node

2020-06-08 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy Acked

[PATCH v27 01/15] dt: bindings: Add multicolor class dt bindings documention

2020-06-08 Thread Dan Murphy
Add DT bindings for the LEDs multicolor class framework. Add multicolor ID to the color ID list for device tree bindings. CC: Rob Herring Acked-by: Pavel Machek Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../bindings/leds/leds-class-multicolor.yaml | 37

[PATCH v27 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes

2020-06-08 Thread Dan Murphy
Add the reg property to each channel node. This update is to accommodate the multicolor framework. In addition to the accommodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy CC: Linus

[PATCH v27 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-08 Thread Dan Murphy
. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- .../ABI/testing/sysfs-class-led-multicolor| 36 +++ Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 88 drivers/leds/Kconfig | 10 + drivers

[PATCH v27 00/15] Multicolor Framework v27

2020-06-08 Thread Dan Murphy
of LEDs Dan Dan Murphy (15): dt: bindings: Add multicolor class dt bindings documention leds: Add multicolor ID to the color ID list leds: multicolor: Introduce a multicolor class definition dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers leds: lp50xx: Add the LP50XX family

[PATCH v27 02/15] leds: Add multicolor ID to the color ID list

2020-06-08 Thread Dan Murphy
Add a new color ID that is declared as MULTICOLOR as with the multicolor framework declaring a definitive color is not accurate as the node can contain multiple colors. Signed-off-by: Dan Murphy --- drivers/leds/led-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/led

[PATCH v27 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2020-06-08 Thread Dan Murphy
has the ability to group LED output into control banks so that multiple LED banks can be controlled with the same mixing and brightness. Inversely the LEDs can also be controlled independently. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 11 + drivers

[PATCH v27 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-08 Thread Dan Murphy
to obtain different colors independent of the overall brightness of the LED grouping. Datasheet: http://www.ti.com/lit/ds/symlink/lp5012.pdf http://www.ti.com/lit/ds/symlink/lp5024.pdf http://www.ti.com/lit/ds/symlink/lp5036.pdf Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy

Re: [PATCH v26 00/15] Multicolor Framework v26

2020-06-08 Thread Dan Murphy
Pavel On 6/6/20 10:57 AM, Pavel Machek wrote: Hi! This is the multi color LED framework. This framework presents clustered colored LEDs into an array and allows the user space to adjust the brightness of the cluster using a single file write. The individual colored LEDs intensities are

Re: [PATCH v26 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-08 Thread Dan Murphy
Rob On 6/4/20 5:59 PM, Rob Herring wrote: On Thu, Jun 04, 2020 at 07:04:53AM -0500, Dan Murphy wrote: Introduce the bindings for the Texas Instruments LP5036, LP5030, LP5024, LP5018, LP5012 and LP5009 RGB LED device driver. The LP5036/30/24/18/12/9 can control RGB LEDs individually or as part

Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-08 Thread Dan Murphy
Jacek On 6/6/20 2:59 PM, Jacek Anaszewski wrote: Dan, On 6/6/20 6:39 PM, Dan Murphy wrote: Pavek Thanks for the review On 6/6/20 10:53 AM, Pavel Machek wrote: Hi! Introduce a multicolor class that groups colored LEDs within a LED node. The multi color class groups monochrome LEDs

Re: [PATCH] can: m_can_platform: fix m_can_runtime_suspend()

2020-06-08 Thread Dan Murphy
Richard On 6/8/20 4:43 AM, Richard Genoud wrote: Since commit f524f829b75a ("can: m_can: Create a m_can platform framework"), the can peripheral on STM32MP1 wasn't working anymore. The reason was a bad copy/paste maneuver that added a call to m_can_class_suspend() in m_can_runtime_suspend().

Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition

2020-06-06 Thread Dan Murphy
is controlled via the intensity file and the latter is controlled via brightness file. Acked-by: Jacek Anaszewski Signed-off-by: Dan Murphy diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor b/Documentation/ABI/testing/sysfs-class-led-multicolor new file mode 100644 index

[PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-05 Thread Dan Murphy
positive number. Without reseting the ret value to 0 this will cause the parse DT function to return a failure. Fixes: c4566aec6e808 ("net: phy: dp83869: Update port-mirroring to read straps") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH net 3/4] net: marvell: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: cf41a51db8985 ("of/phylib: Use device tree properties to initialize Marvell PHYs.") Signed-off-by: Dan Murphy --- drivers/net/phy

[PATCH net 1/4] net: dp83869: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 01db923e83779 ("net: phy: dp83869: Add TI dp83869 phy") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 2 +- 1 file

[PATCH net 0/4] Fixes for OF_MDIO flag

2020-06-05 Thread Dan Murphy
Hello There are some residual drivers that check the CONFIG_OF_MDIO flag using the if defs. Using this check does not work when the OF_MDIO is configured as a module. Using the IS_ENABLED macro checks if the flag is declared as built-in or as a module. Dan Dan Murphy (4): net: dp83869: Fix

[PATCH net 4/4] net: mscc: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 4f58e6dceb0e4 ("net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.") Signed-off-by: Dan Murphy --- drivers/net/phy/m

[PATCH net 2/4] net: dp83867: Fix OF_MDIO config check

2020-06-05 Thread Dan Murphy
When CONFIG_OF_MDIO is set to be a module the code block is not compiled. Use the IS_ENABLED macro that checks for both built in as well as module. Fixes: 2a10154abcb75 ("net: phy: dp83867: Add TI dp83867 phy") Signed-off-by: Dan Murphy --- drivers/net/phy/dp83867.c | 2 +- 1 file

Re: [PATCH v26 01/15] dt: bindings: Add multicolor class dt bindings documention

2020-06-05 Thread Dan Murphy
Rob On 6/4/20 5:40 PM, Rob Herring wrote: On Thu, Jun 04, 2020 at 07:04:50AM -0500, Dan Murphy wrote: Add DT bindings for the LEDs multicolor class framework. Add multicolor ID to the color ID list for device tree bindings. CC: Rob Herring Acked-by: Pavel Machek Acked-by: Jacek Anaszewski

Re: [PATCH v26 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml

2020-06-04 Thread Dan Murphy
Rob On 6/4/20 6:04 PM, Rob Herring wrote: On Thu, Jun 04, 2020 at 07:04:55AM -0500, Dan Murphy wrote: Convert the leds-lp55xx.txt to yaml binding. I will fix all your comments. But why does your BOT have checkpatch warnings? https://gitlab.com/robherring/linux-dt-review/-/jobs/581282098

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Jakub On 6/4/20 11:48 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote: Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy Hi Dan

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: â

Re: [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers

2020-06-04 Thread Dan Murphy
Jacek On 6/1/20 4:34 AM, Jacek Anaszewski wrote: Hi Pavel and Dan, On 5/31/20 9:06 PM, Pavel Machek wrote: Hi! +  There can only be one instance of the ti,led-bank +  property for each device node.  This is a required node is the LED +  modules are to be backed. I

Re: [PATCH] leds: mt6360: Add LED driver for MT6360

2020-06-04 Thread Dan Murphy
Gene On 6/4/20 1:26 AM, Gene Chen wrote: From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, and 3-channel RGB LED support Register/Flash/Breath Mode Signed-off-by: Gene Chen base-commit: 098c4adf249c198519a4abebe482b1e6b8c50e47 ---

<    1   2   3   4   5   6   7   8   9   10   >