Update the LP55xx DT binding examples to the recommended node
naming convention. There are no changes to the DT properties.
Signed-off-by: Dan Murphy
CC: Rob Herring
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutronix Kerne
Fix checkpatch errors and warnings for the LP5523.c device
driver.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 287fc4756cd1
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 185 +++---
drivers/leds/leds-lp55xx-common.h | 9 ++
include/linux/platform_data/leds
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
Acked
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Shawn
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
include/dt-bindings/leds/common.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
extern is implied and is not needed in the common header file.
Remove the extern keyword and re-align the code.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp55xx-common.h | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds-lp55xx
Update the DT binding to include the properties to use the
multicolor framework for the devices that use the LP55xx
framework.
Reviewed-by: Linus Walleij
Signed-off-by: Dan Murphy
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutro
to obtain different colors independent of the overall brightness of
the LED grouping.
Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/leds/leds
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Linus
Matt
On 10/17/19 4:55 AM, Matti Vaittinen wrote:
ROHM BD71828 Power management IC integrates 7 buck converters, 7 LDOs,
a real-time clock (RTC), 3 GPO/regulator control pins, HALL input pin
and a 32.768 kHz clock gate.
Document the dt bindings drivers are using.
This should be patch 1 of X
Matt
On 10/17/19 4:53 AM, Matti Vaittinen wrote:
ROHM BD71828 power management IC has two LED outputs for charge status
and button pressing indications. The LED outputs can also be forced
bs SW so add driver allowing to use these LEDs for other indications
s/bs/by
as well.
Leds are
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Linus
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 2 +
drivers/leds/leds-lp55xx-common.c | 175 +++---
drivers/leds/leds-lp55xx-common.h | 9 ++
include/linux/platform_data/leds
.
Signed-off-by: Dan Murphy
---
.../ABI/testing/sysfs-class-led-multicolor| 36 +++
Documentation/leds/index.rst | 1 +
Documentation/leds/leds-class-multicolor.rst | 96 +++
drivers/leds/Kconfig | 10 +
drivers/leds/Makefile
Add the multicolor brightness call back to support the multicolor
framework. This call back allows setting brightness on grouped channels
in a single function.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 20
1 file changed, 20 insertions(+)
diff --git
has the ability to group LED output into control banks
so that multiple LED banks can be controlled with the same mixing and
brightness. Inversely the LEDs can also be controlled independently.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 11 +
drivers/leds/Makefile | 1
Add the multicolor brightness call back to support the multicolor
framework. This function allows setting the brightness across
grouped LED channels in a single call.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5521.c | 20
1 file changed, 20 insertions(+)
diff --git
Fix checkpatch errors and warnings for the LP5523.c device
driver.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index b5beed5bbd85
the devm_multicolor class registration
LP50xx
- Call the devm_multicolor class registration
Dan
Dan Murphy (18):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add multicolor ID to the color ID list
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
include/dt-bindings/leds/common.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Shawn
Update the DT binding to include the properties to use the
multicolor framework for the devices that use the LP55xx
framework.
Reviewed-by: Linus Walleij
Signed-off-by: Dan Murphy
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutro
Add DT bindings for the LEDs multicolor class framework.
Signed-off-by: Dan Murphy
CC: Rob Herring
---
.../bindings/leds/leds-class-multicolor.txt | 98 +++
1 file changed, 98 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
to obtain different colors independent of the overall brightness of
the LED grouping.
Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signed-off-by: Dan Murphy
CC: Rob Herring
---
.../devicetree/bindings
Update the document to be consistent in case when using "LED".
This acronym should be capital throughout the document.
Signed-off-by: Dan Murphy
CC: Rob Herring
---
Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
drivers/leds/led-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/led
Convert the LED class registration calls to the LED devm_*
registration calls.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp55xx-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp55xx-common.c
b/drivers/leds/leds-lp55xx-common.c
index
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Tony
Update the LP55xx DT binding examples to the recommended node
naming convention. There are no changes to the DT properties.
Signed-off-by: Dan Murphy
CC: Rob Herring
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutronix Kerne
documentation.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp55xx-common.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-lp55xx-common.c
b/drivers/leds/leds-lp55xx-common.c
index 026ebc2f8e18..a1d930d4f461 100644
--- a/drivers
err);
+ goto exit;
+ }
+
Reviewed-by: Dan Murphy
for (i = 0; i < chip->num_leds; i++) {
struct led_init_data init_data = {};
Chuhong
On 10/16/19 7:06 AM, Chuhong Yuan wrote:
an30259a_probe misses a check for devm_regmap_init_i2c and may cause
problems.
Add a check and print errors like other leds drivers.
Signed-off-by: Chuhong Yuan
---
drivers/leds/leds-an30259a.c | 7 +++
1 file changed, 7 insertions(+)
Jacek
On 10/11/19 3:15 PM, Jacek Anaszewski wrote:
Dan,
On 10/11/19 3:06 PM, Dan Murphy wrote:
Update the DT binding to include the properties to use the
multicolor framework for the devices that use the LP55xx
framework.
Signed-off-by: Dan Murphy
CC: Tony Lindgren
CC: "Benoît Cousson
Jacek
On 10/11/19 3:36 PM, Jacek Anaszewski wrote:
Dan,
On 10/11/19 3:06 PM, Dan Murphy wrote:
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 176
Jacek
On 10/11/19 2:40 PM, Jacek Anaszewski wrote:
Dan,
On 10/11/19 3:06 PM, Dan Murphy wrote:
Hello
Minor changes per review comments.
https://lore.kernel.org/patchwork/project/lkml/list/?series=413385
Rebased the series on top of Pavel's next branch.
Multicolor changes:
Rename
Add DT bindings for the LEDs multicolor class framework.
Signed-off-by: Dan Murphy
---
.../bindings/leds/leds-class-multicolor.txt | 98 +++
1 file changed, 98 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
diff --git
Add the intensity function call back to support the multicolor
framework. This function allows setting a specific brightness on
a specific channel.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/leds
.
Signed-off-by: Dan Murphy
---
.../ABI/testing/sysfs-class-led-multicolor| 36 +++
.../bindings/leds/leds-class-multicolor.txt | 4 +-
Documentation/leds/index.rst | 1 +
Documentation/leds/leds-class-multicolor.rst | 96 +++
drivers/leds/Kconfig
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Linus
Fix checkpatch errors and warnings for the LP5523.c device
driver.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 5d6002e4d657
Add the intensity function call back to support the multicolor
framework. This function allows setting a specific brightness on
a specific channel.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5521.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/leds
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Shawn
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
drivers/leds/led-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/led
STATUS to CHARGING
LP50xx changes:
None
LP55xx changes:
Changed color_component array allocation from COLOR_MAX_ID to
MAX_GROUPED_CHANNELS
Updated MC API to call led_mc_calc_color_components
Dan
Dan Murphy (16):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add
to obtain different colors independent of the overall brightness of
the LED grouping.
Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/leds/leds
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
include/dt-bindings/leds/common.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Update the DT binding to include the properties to use the
multicolor framework for the devices that use the LP55xx
framework.
Signed-off-by: Dan Murphy
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutronix Kernel Team
CC: Fabio E
has the ability to group LED output into control banks
so that multiple LED banks can be controlled with the same mixing and
brightness. Inversely the LEDs can also be controlled independently.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 11 +
drivers/leds/Makefile | 1
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Tony
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 176 +++---
drivers/leds/leds-lp55xx-common.h | 9 ++
include/linux/platform_data/leds
Update the document to be consistent in case when using "LED".
This acronym should be capital throughout the document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Doc
documentation.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp55xx-common.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-lp55xx-common.c
b/drivers/leds/leds-lp55xx-common.c
index 1417df6df8a7..0d8d1824ea7e 100644
--- a/drivers
Jacek
On 10/9/19 5:07 PM, Jacek Anaszewski wrote:
Dan,
On 10/8/19 10:47 PM, Dan Murphy wrote:
Add DT bindings for the LEDs multicolor class framework.
Signed-off-by: Dan Murphy
---
.../bindings/leds/leds-class-multicolor.txt | 98 +++
1 file changed, 98 insertions
Jacek
On 10/9/19 5:04 PM, Jacek Anaszewski wrote:
Dan,
On 10/8/19 10:47 PM, Dan Murphy wrote:
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 176
Bjorn
On 10/9/19 6:25 PM, Bjorn Andersson wrote:
On Wed 09 Oct 13:44 PDT 2019, Dan Murphy wrote:
Bjorn
On 10/9/19 3:11 PM, Bjorn Andersson wrote:
On Tue, Oct 8, 2019 at 1:49 PM Dan Murphy wrote:
Introduce a multicolor class that groups colored LEDs
within a LED node.
The multi color
Jacek
On 10/9/19 4:47 PM, Jacek Anaszewski wrote:
Dan,
On 10/8/19 10:47 PM, Dan Murphy wrote:
Introduce a multicolor class that groups colored LEDs
within a LED node.
The multi color class groups monochrome LEDs and allows controlling two
aspects of the final combined color: hue
Bjorn
On 10/9/19 3:11 PM, Bjorn Andersson wrote:
On Tue, Oct 8, 2019 at 1:49 PM Dan Murphy wrote:
Introduce a multicolor class that groups colored LEDs
within a LED node.
The multi color class groups monochrome LEDs and allows controlling two
aspects of the final combined color: hue
Update the document to be consistent in case when using "LED".
This acronym should be capital throughout the document.
Signed-off-by: Dan Murphy
---
Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Doc
Add DT bindings for the LEDs multicolor class framework.
Signed-off-by: Dan Murphy
---
.../bindings/leds/leds-class-multicolor.txt | 98 +++
1 file changed, 98 insertions(+)
create mode 100644
Documentation/devicetree/bindings/leds/leds-class-multicolor.txt
diff --git
has the ability to group LED output into control banks
so that multiple LED banks can be controlled with the same mixing and
brightness. Inversely the LEDs can also be controlled independently.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 11 +
drivers/leds/Makefile | 1
Update the DT binding to include the properties to use the
multicolor framework for the devices that use the LP55xx
framework.
Signed-off-by: Dan Murphy
CC: Tony Lindgren
CC: "Benoît Cousson"
CC: Linus Walleij
CC: Shawn Guo
CC: Sascha Hauer
CC: Pengutronix Kernel Team
CC: Fabio E
Add the intensity function call back to support the multicolor
framework. This function allows setting a specific brightness on
a specific channel.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/leds
Add the intensity function call back to support the multicolor
framework. This function allows setting a specific brightness on
a specific channel.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5521.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/leds
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Tony
to obtain different colors independent of the overall brightness of
the LED grouping.
Datasheet:
http://www.ti.com/lit/ds/symlink/lp5012.pdf
http://www.ti.com/lit/ds/symlink/lp5024.pdf
http://www.ti.com/lit/ds/symlink/lp5036.pdf
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/leds/leds
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
drivers/leds/led-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/led
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Linus
.
Signed-off-by: Dan Murphy
---
.../ABI/testing/sysfs-class-led-multicolor| 35 +++
Documentation/leds/index.rst | 1 +
Documentation/leds/leds-class-multicolor.rst | 96 +++
drivers/leds/Kconfig | 10 +
drivers/leds/Makefile
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 176 +++---
drivers/leds/leds-lp55xx-common.h | 11 ++
include/linux/platform_data/leds
Fix checkpatch errors and warnings for the LP5523.c device
driver.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp5523.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 5d6002e4d657
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.
Signed-off-by: Dan Murphy
---
include/dt-bindings/leds/common.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
the intensity and brightness functions have a
similar design but function different.
Dan Murphy (16):
dt: bindings: Add multicolor class dt bindings documention
dt-bindings: leds: Add multicolor ID to the color ID list
leds: Add multicolor ID to the color ID list
leds: multicolor: Introduce
documentation.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lp55xx-common.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/leds/leds-lp55xx-common.c
b/drivers/leds/leds-lp55xx-common.c
index 85629f836082..fc5224108c64 100644
--- a/drivers
Add the reg property to each channel node. This update is
to accomodate the multicolor framework. In addition to the
accomodation this allows the LEDs to be placed on any channel
and allow designs to skip channels as opposed to requiring
sequential order.
Signed-off-by: Dan Murphy
CC: Shawn
Add the DT binding for the TAS2562 amplifier.
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/sound/tas2562.txt | 34 +++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/tas2562.txt
diff --git a/Documentation/devicetree
Introduce the Texas Instruments TAS2562 amplifier driver
with I/V sense for loud speaker applications.
http://www.ti.com/lit/gpn/tas2562
Signed-off-by: Dan Murphy
---
sound/soc/codecs/Kconfig | 5 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/tas2562.c | 590
Remove the unneeded and incorrect read of the TDM_CFG3 register.
The read is done but the value is never used.
Signed-off-by: Dan Murphy
---
v2 - New patch no v1
sound/soc/codecs/tas2770.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs
Remove unused defines and structure variables that are not
referenced by the code. If these are needed for future
enhancements then they should be added at that time.
Signed-off-by: Dan Murphy
---
v2 - New patch no v1
sound/soc/codecs/tas2770.h | 21 -
1 file changed, 21
then 0 or the caller may indicate failure when the value actually
changed.
Signed-off-by: Dan Murphy
---
v2 - Missed one update_bit return issue.
sound/soc/codecs/tas2770.c | 46 +-
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/sound/soc/codecs
Jacek
On 10/6/19 2:52 PM, Jacek Anaszewski wrote:
Dan,
On 10/1/19 4:56 PM, Dan Murphy wrote:
Add multicolor framework support for the lp55xx family.
Signed-off-by: Dan Murphy
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp55xx-common.c | 169
Jacek
On 10/6/19 11:12 AM, Jacek Anaszewski wrote:
Dan,
On 10/1/19 4:56 PM, Dan Murphy wrote:
Introduce the LP5036/30/24/18/12/9 RGB LED driver.
The difference in these parts are the number of
LED outputs where the:
LP5036 can control 36 LEDs
LP5030 can control 30 LEDs
LP5024 can control 24
Jacek
Thanks for the review
On 10/6/19 10:23 AM, Jacek Anaszewski wrote:
Dan,
Thank you for the update.
On 10/1/19 4:56 PM, Dan Murphy wrote:
Introduce a multicolor class that groups colored LEDs
within a LED node.
The multi color class groups monochrome LEDs and allows controlling two
Mark
On 10/4/19 3:26 PM, Mark Brown wrote:
On Fri, Oct 04, 2019 at 03:22:45PM -0500, Dan Murphy wrote:
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -395,6 +395,7 @@ CONFIG_SND_SOC_OMAP_ABE_TWL6040=m
CONFIG_SND_SOC_OMAP_HDMI=m
then 0 or the caller may indicate failure when the value actually
changed.
Signed-off-by: Dan Murphy
---
arch/arm/configs/omap2plus_defconfig | 1 +
sound/soc/codecs/tas2770.c | 44 ++--
2 files changed, 30 insertions(+), 15 deletions(-)
diff --git a/arch/arm
Hello
On 10/2/19 1:36 PM, Pavel Machek wrote:
On Wed 2019-10-02 11:34:00, Dan Murphy wrote:
The LED_COLOR_MAX_ID is incorrect. THe MAX_ID should
be the last COLOR_ID in the list. If an array was allocate
with MAX_ID the allocation would be correct but the meaning
is wrong.
So for array
Jacek
On 10/2/19 12:46 PM, Jacek Anaszewski wrote:
Dan,
On 10/2/19 5:47 PM, Dan Murphy wrote:
Akinobu
On 10/2/19 10:13 AM, Akinobu Mita wrote:
Reading /sys/class/leds//trigger returns all available LED triggers.
However, this violates the "one value per file" rule of sysfs.
Thi
needs to validate
that the color ID is not out of bounds then the code should use
LED_COLOR_MAX_ID.
Signed-off-by: Dan Murphy
---
drivers/leds/led-core.c | 4 ++--
drivers/leds/leds.h | 2 +-
include/dt-bindings/leds/common.h | 3 ++-
3 files changed, 5 insertions(+), 4
Hello
On 10/1/19 9:56 AM, Dan Murphy wrote:
Hello
I have updated the code per v9 review comments
https://lore.kernel.org/patchwork/project/lkml/list/?series=411824
I have a v11 version ready to go would like to include any v10 comments
So v11 changes include
- Adding inline MC framework
el J. Wysocki"
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
Documentation/ABI/testing/sysfs-class-led | 13 +++
drivers/leds/led-class.c | 10
drivers/leds/led-triggers.c | 38 +++
Update the leds.h structure documentation to define the
correct arguments.
Signed-off-by: Dan Murphy
---
include/linux/leds.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/leds.h b/include/linux/leds.h
index 52e50183b963..242258f7d837 100644
Fix the devm_classdev_match pointer initilization to the correct
structure type.
Signed-off-by: Dan Murphy
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 3f04334d59ee..438774315e6c 100644
Add the missing device managed API for registration and
unregistration for the LED flash class.
Signed-off-by: Dan Murphy
---
drivers/leds/led-class-flash.c | 50 +
include/linux/led-class-flash.h | 14 +
2 files changed, 64 insertions(+)
diff --git
Convert LED flash class registration to device managed class
registration API.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lm3601x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3601x.c b/drivers/leds/leds-lm3601x.c
index b02972f1a341
extern is implied and is not needed in the header file.
Remove the extern keyword and re-align the code.
Signed-off-by: Dan Murphy
---
include/linux/leds.h | 95
1 file changed, 44 insertions(+), 51 deletions(-)
diff --git a/include/linux/leds.h b
extern is implied and is not needed in the header file.
Remove the extern keyword and re-align the code.
Signed-off-by: Dan Murphy
---
include/linux/led-class-flash.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/include/linux/led-class-flash.h b
Jacek
On 10/1/19 4:06 PM, Jacek Anaszewski wrote:
Dan,
Thank you for the patch. One funny omission caught my
eye here and in led-class.c when making visual comparison.
Please refer below.
On 10/1/19 8:04 PM, Dan Murphy wrote:
Add the missing device managed API for registration
Jacek
On 10/1/19 3:57 PM, Jacek Anaszewski wrote:
Dan,
Thank you for the patch.
Could we have similar patch for leds.h when we are at it,
if you wouldn't mind?
Sure do you want it in this patch or a separate patch?
Dan
Jacek
On 10/1/19 2:39 PM, Jacek Anaszewski wrote:
Hi Dan,
Thank you for the patch.
On 10/1/19 8:04 PM, Dan Murphy wrote:
Convert LED flash class registration to device managed class
registration API.
Signed-off-by: Dan Murphy
---
drivers/leds/leds-lm3601x.c | 3 +--
1 file changed, 1
extern is implied and is not needed in the header file.
Remove the extern keyword and re-align the code.
Signed-off-by: Dan Murphy
---
include/linux/led-class-flash.h | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/include/linux/led-class-flash.h b
801 - 900 of 2241 matches
Mail list logo
