Re: [driver-core PATCH v8 2/9] driver core: Establish order of operations for device_add and device_del via bitflag

2018-12-10 Thread Dan Williams
On Wed, Dec 5, 2018 at 9:25 AM Alexander Duyck wrote: > > Add an additional bit flag to the device struct named "dead". > > This additional flag provides a guarantee that when a device_del is > executed on a given interface an async worker will not attempt to attach > the driver following the

Re: [PATCH 3/7] doc/vm: New documentation for memory performance

2018-12-10 Thread Dan Williams
On Thu, Nov 15, 2018 at 4:59 AM Jonathan Cameron wrote: > > On Wed, 14 Nov 2018 15:49:16 -0700 > Keith Busch wrote: [..] > > +The kernel does not provide performance attributes for non-local memory > > +initiators. The performance characteristics the kernel provides for > > +the local initiators

Re: [GIT PULL] dax fixes for 4.20-rc6

2018-12-09 Thread Dan Williams
[ add Willy and Jan ] On Sun, Dec 9, 2018 at 10:02 AM Linus Torvalds wrote: > > On Sat, Dec 8, 2018 at 10:26 PM Williams, Dan J > wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm > > tags/dax-fixes-4.20-rc6 > > What's going on with the odd non-exclusive exclusive

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-08 Thread Dan Williams
On Sat, Dec 8, 2018 at 8:48 AM Christoph Hellwig wrote: > > On Sat, Dec 08, 2018 at 11:33:53AM -0500, Jerome Glisse wrote: > > Patchset to use HMM inside nouveau have already been posted, some > > of the bits have already made upstream and more are line up for > > next merge window. > > Even with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-08 Thread Dan Williams
On Sat, Dec 8, 2018 at 8:48 AM Christoph Hellwig wrote: > > On Sat, Dec 08, 2018 at 11:33:53AM -0500, Jerome Glisse wrote: > > Patchset to use HMM inside nouveau have already been posted, some > > of the bits have already made upstream and more are line up for > > next merge window. > > Even with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
On Fri, Dec 7, 2018 at 4:53 PM John Hubbard wrote: > > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: [..] > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
On Fri, Dec 7, 2018 at 4:53 PM John Hubbard wrote: > > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: [..] > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
thew Wilcox wrote: > > >>> On Tue, Dec 04, 2018 at 04:58:01PM -0800, John Hubbard wrote: > > >>>> On 12/4/18 3:03 PM, Dan Williams wrote: > > >>>>> Except the LRU fields are already in use for ZONE_DEVICE pages... how > > >>>>&g

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
thew Wilcox wrote: > > >>> On Tue, Dec 04, 2018 at 04:58:01PM -0800, John Hubbard wrote: > > >>>> On 12/4/18 3:03 PM, Dan Williams wrote: > > >>>>> Except the LRU fields are already in use for ZONE_DEVICE pages... how > > >>>>&g

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Dan Williams
On Wed, Dec 5, 2018 at 3:27 PM Jerome Glisse wrote: > > On Wed, Dec 05, 2018 at 04:23:42PM -0700, Logan Gunthorpe wrote: > > > > > > On 2018-12-05 4:20 p.m., Jerome Glisse wrote: > > > And my proposal is under /sys/bus and have symlink to all existing > > > device it agregate in there. > > > >

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-05 Thread Dan Williams
On Wed, Dec 5, 2018 at 3:27 PM Jerome Glisse wrote: > > On Wed, Dec 05, 2018 at 04:23:42PM -0700, Logan Gunthorpe wrote: > > > > > > On 2018-12-05 4:20 p.m., Jerome Glisse wrote: > > > And my proposal is under /sys/bus and have symlink to all existing > > > device it agregate in there. > > > >

[tip:x86/mm] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: ba6f508d0ec4adb09f0a939af6d5e19cdfa8667d Gitweb: https://git.kernel.org/tip/ba6f508d0ec4adb09f0a939af6d5e19cdfa8667d Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:27 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:07 +0100 x86/mm: Drop usage

[tip:x86/mm] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: ba6f508d0ec4adb09f0a939af6d5e19cdfa8667d Gitweb: https://git.kernel.org/tip/ba6f508d0ec4adb09f0a939af6d5e19cdfa8667d Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:27 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:07 +0100 x86/mm: Drop usage

[tip:x86/mm] generic/pgtable: Introduce set_pte_safe()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 4369deaa2f022ef92da45a0e7eec8a4a52e8e8a4 Gitweb: https://git.kernel.org/tip/4369deaa2f022ef92da45a0e7eec8a4a52e8e8a4 Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:16 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 generic/pgtable: Introduce

[tip:x86/mm] generic/pgtable: Introduce set_pte_safe()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 4369deaa2f022ef92da45a0e7eec8a4a52e8e8a4 Gitweb: https://git.kernel.org/tip/4369deaa2f022ef92da45a0e7eec8a4a52e8e8a4 Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:16 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 generic/pgtable: Introduce

[tip:x86/mm] x86/mm: Validate kernel_physical_mapping_init() PTE population

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 0a9fe8ca844d43f3f547f0e166122b6048121c8f Gitweb: https://git.kernel.org/tip/0a9fe8ca844d43f3f547f0e166122b6048121c8f Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:21 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 x86/mm: Validate

[tip:x86/mm] x86/mm: Validate kernel_physical_mapping_init() PTE population

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 0a9fe8ca844d43f3f547f0e166122b6048121c8f Gitweb: https://git.kernel.org/tip/0a9fe8ca844d43f3f547f0e166122b6048121c8f Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:21 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 x86/mm: Validate

[tip:x86/mm] generic/pgtable: Introduce {p4d,pgd}_same()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 0cebbb60f759a709dabb3c87b9704f9844878850 Gitweb: https://git.kernel.org/tip/0cebbb60f759a709dabb3c87b9704f9844878850 Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:11 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 generic/pgtable: Introduce

[tip:x86/mm] generic/pgtable: Introduce {p4d,pgd}_same()

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: 0cebbb60f759a709dabb3c87b9704f9844878850 Gitweb: https://git.kernel.org/tip/0cebbb60f759a709dabb3c87b9704f9844878850 Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:11 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:06 +0100 generic/pgtable: Introduce

[tip:x86/mm] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: c683c37cd13246941924c48f6c6a9863425e0cec Gitweb: https://git.kernel.org/tip/c683c37cd13246941924c48f6c6a9863425e0cec Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:06 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:05 +0100 generic/pgtable: Make {pmd

[tip:x86/mm] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-12-05 Thread tip-bot for Dan Williams
Commit-ID: c683c37cd13246941924c48f6c6a9863425e0cec Gitweb: https://git.kernel.org/tip/c683c37cd13246941924c48f6c6a9863425e0cec Author: Dan Williams AuthorDate: Tue, 4 Dec 2018 13:37:06 -0800 Committer: Ingo Molnar CommitDate: Wed, 5 Dec 2018 09:03:05 +0100 generic/pgtable: Make {pmd

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 5:15 PM Matthew Wilcox wrote: > > On Tue, Dec 04, 2018 at 04:58:01PM -0800, John Hubbard wrote: > > On 12/4/18 3:03 PM, Dan Williams wrote: > > > Except the LRU fields are already in use for ZONE_DEVICE pages... how > > > does this proposal int

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 5:15 PM Matthew Wilcox wrote: > > On Tue, Dec 04, 2018 at 04:58:01PM -0800, John Hubbard wrote: > > On 12/4/18 3:03 PM, Dan Williams wrote: > > > Except the LRU fields are already in use for ZONE_DEVICE pages... how > > > does this proposal int

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 5:15 PM Logan Gunthorpe wrote: > > > > On 2018-12-04 4:56 p.m., Jerome Glisse wrote: > > One example i have is 4 nodes (CPU socket) each nodes with 8 GPUs and > > two 8 GPUs node connected through each other with fast mesh (ie each > > GPU can peer to peer to each other at

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 5:15 PM Logan Gunthorpe wrote: > > > > On 2018-12-04 4:56 p.m., Jerome Glisse wrote: > > One example i have is 4 nodes (CPU socket) each nodes with 8 GPUs and > > two 8 GPUs node connected through each other with fast mesh (ie each > > GPU can peer to peer to each other at

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 4:58 PM John Hubbard wrote: > > On 12/4/18 3:03 PM, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: [..] > > Ok, sorry, I mis-remembered. So, you're effectively trying to capture > > the end of the page pin event sepa

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 4:58 PM John Hubbard wrote: > > On 12/4/18 3:03 PM, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: [..] > > Ok, sorry, I mis-remembered. So, you're effectively trying to capture > > the end of the page pin event sepa

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 4:37 PM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 03:03:02PM -0800, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: > > > > > > On 12/4/18 12:28 PM, Dan Williams wrote: > > > > On Mon, Dec 3, 2018

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 4:37 PM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 03:03:02PM -0800, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: > > > > > > On 12/4/18 12:28 PM, Dan Williams wrote: > > > > On Mon, Dec 3, 2018

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: > > On 12/4/18 12:28 PM, Dan Williams wrote: > > On Mon, Dec 3, 2018 at 4:17 PM wrote: > >> > >> From: John Hubbard > >> > >> Introduces put_user_page(), which simply calls put_page(). >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 1:56 PM John Hubbard wrote: > > On 12/4/18 12:28 PM, Dan Williams wrote: > > On Mon, Dec 3, 2018 at 4:17 PM wrote: > >> > >> From: John Hubbard > >> > >> Introduces put_user_page(), which simply calls put_page(). >

[PATCH v3 3/5] generic/pgtable: Introduce set_pte_safe()

2018-12-04 Thread Dan Williams
sen Acked-by: Peter Zijlstra (Intel) Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index dae7f9

[PATCH v3 1/5] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-12-04 Thread Dan Williams
: Borislav Petkov Cc: Peter Zijlstra Cc: Dave Hansen Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index 359fb935ded6

[PATCH v3 3/5] generic/pgtable: Introduce set_pte_safe()

2018-12-04 Thread Dan Williams
sen Acked-by: Peter Zijlstra (Intel) Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index dae7f9

[PATCH v3 1/5] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-12-04 Thread Dan Williams
: Borislav Petkov Cc: Peter Zijlstra Cc: Dave Hansen Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index 359fb935ded6

[PATCH v3 2/5] generic/pgtable: Introduce {p4d,pgd}_same()

2018-12-04 Thread Dan Williams
-by: Dan Williams --- include/asm-generic/pgtable.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index eea50ef8b8cd..dae7f98babed 100644 --- a/include/asm-generic/pgtable.h +++ b/include/asm-generic/pgtable.h @@ -386,6

[PATCH v3 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-04 Thread Dan Williams
nity checking implementation was resolved by Peter's suggestion to not trigger when the same pte value is being rewritten. --- Dan Williams (5): generic/pgtable: Make {pmd,pud}_same() unconditionally available generic/pgtable: Introduce {p4d,pgd}_same() generic/pgtable: Introduce

[PATCH v3 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-04 Thread Dan Williams
: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Acked-by: Peter Zijlstra (Intel) Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 3e25ac

[PATCH v3 2/5] generic/pgtable: Introduce {p4d,pgd}_same()

2018-12-04 Thread Dan Williams
-by: Dan Williams --- include/asm-generic/pgtable.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index eea50ef8b8cd..dae7f98babed 100644 --- a/include/asm-generic/pgtable.h +++ b/include/asm-generic/pgtable.h @@ -386,6

[PATCH v3 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-04 Thread Dan Williams
nity checking implementation was resolved by Peter's suggestion to not trigger when the same pte value is being rewritten. --- Dan Williams (5): generic/pgtable: Make {pmd,pud}_same() unconditionally available generic/pgtable: Introduce {p4d,pgd}_same() generic/pgtable: Introduce

[PATCH v3 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-04 Thread Dan Williams
: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Acked-by: Peter Zijlstra (Intel) Acked-by: Kirill A. Shutemov Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 3e25ac

[PATCH v3 4/5] x86/mm: Validate kernel_physical_mapping_init() pte population

2018-12-04 Thread Dan Williams
of helpers to assert that the !present assumption is true in this path. Cc: Sebastian Andrzej Siewior Cc: Thomas Gleixner Cc: Borislav Petkov Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Acked-by: Kirill A. Shutemov Acked-by: Peter Zijlstra (Intel) Signed-off-by: Dan Williams

[PATCH v3 4/5] x86/mm: Validate kernel_physical_mapping_init() pte population

2018-12-04 Thread Dan Williams
of helpers to assert that the !present assumption is true in this path. Cc: Sebastian Andrzej Siewior Cc: Thomas Gleixner Cc: Borislav Petkov Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Acked-by: Kirill A. Shutemov Acked-by: Peter Zijlstra (Intel) Signed-off-by: Dan Williams

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Mon, Dec 3, 2018 at 4:17 PM wrote: > > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). > > Also introduces put_user_pages(), and a few

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-04 Thread Dan Williams
On Mon, Dec 3, 2018 at 4:17 PM wrote: > > From: John Hubbard > > Introduces put_user_page(), which simply calls put_page(). > This provides a way to update all get_user_pages*() callers, > so that they call put_user_page(), instead of put_page(). > > Also introduces put_user_pages(), and a few

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 10:58 AM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 10:31:17AM -0800, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 10:24 AM Jerome Glisse wrote: > > > > > > On Tue, Dec 04, 2018 at 09:06:59AM -0800, Andi Kleen wrote: >

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 10:58 AM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 10:31:17AM -0800, Dan Williams wrote: > > On Tue, Dec 4, 2018 at 10:24 AM Jerome Glisse wrote: > > > > > > On Tue, Dec 04, 2018 at 09:06:59AM -0800, Andi Kleen wrote: >

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 10:24 AM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 09:06:59AM -0800, Andi Kleen wrote: > > jgli...@redhat.com writes: > > > > > + > > > +To help with forward compatibility each object as a version value and > > > +it is mandatory for user space to only use target or

Re: [RFC PATCH 02/14] mm/hms: heterogenenous memory system (HMS) documentation

2018-12-04 Thread Dan Williams
On Tue, Dec 4, 2018 at 10:24 AM Jerome Glisse wrote: > > On Tue, Dec 04, 2018 at 09:06:59AM -0800, Andi Kleen wrote: > > jgli...@redhat.com writes: > > > > > + > > > +To help with forward compatibility each object as a version value and > > > +it is mandatory for user space to only use target or

Re: [PATCH v2 3/5] generic/pgtable: Introduce set_pte_safe()

2018-12-03 Thread Dan Williams
On Mon, Dec 3, 2018 at 9:53 AM Dave Hansen wrote: > > On 11/30/18 4:35 PM, Dan Williams wrote: > > +/* > > + * The _safe versions of set_{pte,pmd,pud,p4d,pgd} validate that the > > + * entry was not populated previously. I.e. for cases where a flush-tlb > &g

Re: [PATCH v2 3/5] generic/pgtable: Introduce set_pte_safe()

2018-12-03 Thread Dan Williams
On Mon, Dec 3, 2018 at 9:53 AM Dave Hansen wrote: > > On 11/30/18 4:35 PM, Dan Williams wrote: > > +/* > > + * The _safe versions of set_{pte,pmd,pud,p4d,pgd} validate that the > > + * entry was not populated previously. I.e. for cases where a flush-tlb > &g

Re: [PATCH v2 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-02 Thread Dan Williams
On Sat, Dec 1, 2018 at 10:43 PM Sasha Levin wrote: > > On Fri, Nov 30, 2018 at 04:35:32PM -0800, Dan Williams wrote: > >Commit f77084d96355 "x86/mm/pat: Disable preemption around > >__flush_tlb_all()" addressed a case where __flush_tlb_all() is called > >without

Re: [PATCH v2 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-02 Thread Dan Williams
On Sat, Dec 1, 2018 at 10:43 PM Sasha Levin wrote: > > On Fri, Nov 30, 2018 at 04:35:32PM -0800, Dan Williams wrote: > >Commit f77084d96355 "x86/mm/pat: Disable preemption around > >__flush_tlb_all()" addressed a case where __flush_tlb_all() is called > >without

Re: [PATCH v2 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-01 Thread Dan Williams
On Sat, Dec 1, 2018 at 2:28 AM Peter Zijlstra wrote: > > On Fri, Nov 30, 2018 at 04:35:06PM -0800, Dan Williams wrote: > > > > Dan Williams (5): > > generic/pgtable: Make {pmd,pud}_same() unconditionally available > > generic/pgtable: Introduce {p4d

Re: [PATCH v2 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-12-01 Thread Dan Williams
On Sat, Dec 1, 2018 at 2:28 AM Peter Zijlstra wrote: > > On Fri, Nov 30, 2018 at 04:35:06PM -0800, Dan Williams wrote: > > > > Dan Williams (5): > > generic/pgtable: Make {pmd,pud}_same() unconditionally available > > generic/pgtable: Introduce {p4d

Re: [PATCH] PCI/P2PDMA: Match interface changes to devm_memremap_pages()

2018-11-30 Thread Dan Williams
ll site in > that code. > > Without this patch, all drivers will fail to register P2P resources > because devm_memremap_pages() will return -EINVAL due to the 'kill' > member of the pagemap structure not yet being set. > > Signed-off-by: Logan Gunthorpe > Cc: Andrew Morton > Cc: Dan Williams Reviewed-by: Dan Williams

Re: [PATCH] PCI/P2PDMA: Match interface changes to devm_memremap_pages()

2018-11-30 Thread Dan Williams
ll site in > that code. > > Without this patch, all drivers will fail to register P2P resources > because devm_memremap_pages() will return -EINVAL due to the 'kill' > member of the pagemap structure not yet being set. > > Signed-off-by: Logan Gunthorpe > Cc: Andrew Morton > Cc: Dan Williams Reviewed-by: Dan Williams

[PATCH v2 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-30 Thread Dan Williams
Gleixner Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 3e25ac2793ef..484c1b92f0

[PATCH v2 5/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-30 Thread Dan Williams
Gleixner Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 3e25ac2793ef..484c1b92f0

[PATCH v2 3/5] generic/pgtable: Introduce set_pte_safe()

2018-11-30 Thread Dan Williams
Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index dae7f98babed.

[PATCH v2 2/5] generic/pgtable: Introduce {p4d,pgd}_same()

2018-11-30 Thread Dan Williams
In preparation for introducing '_safe' versions of page table entry 'set' helpers, introduce generic versions of p4d_same() and pgd_same(). Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/asm-generic

[PATCH v2 1/5] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-11-30 Thread Dan Williams
In preparation for {pmd,pud}_same() to be used outside of transparent huge page code paths, make them unconditionally available. This enables them to be used in the definition of a new family of set_{pte,pmd,pud,p4d,pgd}_safe() helpers. Signed-off-by: Dan Williams --- include/asm-generic

[PATCH v2 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-30 Thread Dan Williams
ed by Peter's suggestion to not trigger when the same pte value is being rewritten. --- Dan Williams (5): generic/pgtable: Make {pmd,pud}_same() unconditionally available generic/pgtable: Introduce {p4d,pgd}_same() generic/pgtable: Introduce set_pte_safe() x86

[PATCH v2 4/5] x86/mm: Validate kernel_physical_mapping_init() pte population

2018-11-30 Thread Dan Williams
of helpers to assert that the !present assumption is true in this path. Cc: Kirill A. Shutemov Cc: Sebastian Andrzej Siewior Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Borislav Petkov Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/include

[PATCH v2 3/5] generic/pgtable: Introduce set_pte_safe()

2018-11-30 Thread Dan Williams
Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index dae7f98babed.

[PATCH v2 2/5] generic/pgtable: Introduce {p4d,pgd}_same()

2018-11-30 Thread Dan Williams
In preparation for introducing '_safe' versions of page table entry 'set' helpers, introduce generic versions of p4d_same() and pgd_same(). Signed-off-by: Dan Williams --- include/asm-generic/pgtable.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/asm-generic

[PATCH v2 1/5] generic/pgtable: Make {pmd, pud}_same() unconditionally available

2018-11-30 Thread Dan Williams
In preparation for {pmd,pud}_same() to be used outside of transparent huge page code paths, make them unconditionally available. This enables them to be used in the definition of a new family of set_{pte,pmd,pud,p4d,pgd}_safe() helpers. Signed-off-by: Dan Williams --- include/asm-generic

[PATCH v2 0/5] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-30 Thread Dan Williams
ed by Peter's suggestion to not trigger when the same pte value is being rewritten. --- Dan Williams (5): generic/pgtable: Make {pmd,pud}_same() unconditionally available generic/pgtable: Introduce {p4d,pgd}_same() generic/pgtable: Introduce set_pte_safe() x86

[PATCH v2 4/5] x86/mm: Validate kernel_physical_mapping_init() pte population

2018-11-30 Thread Dan Williams
of helpers to assert that the !present assumption is true in this path. Cc: Kirill A. Shutemov Cc: Sebastian Andrzej Siewior Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Borislav Petkov Suggested-by: Peter Zijlstra Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/include

[4.19-stable PATCH] dax: Avoid losing wakeup in dax_lock_mapping_entry

2018-11-28 Thread Dan Williams
Signed-off-by: Matthew Wilcox Signed-off-by: Dan Williams --- Passes the nvdimm unit test suite which exercises the lock path. fs/dax.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 0fb270f0a0ef..b0cd1364c68f 100644 --- a/fs/dax.c +++ b/fs/dax.c

[4.19-stable PATCH] dax: Avoid losing wakeup in dax_lock_mapping_entry

2018-11-28 Thread Dan Williams
Signed-off-by: Matthew Wilcox Signed-off-by: Dan Williams --- Passes the nvdimm unit test suite which exercises the lock path. fs/dax.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 0fb270f0a0ef..b0cd1364c68f 100644 --- a/fs/dax.c +++ b/fs/dax.c

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-27 Thread Dan Williams
On Mon, Nov 26, 2018 at 11:00 PM Dan Williams wrote: > > On Wed, Nov 14, 2018 at 2:53 PM Keith Busch wrote: > > > > Heterogeneous memory systems provide memory nodes with latency > > and bandwidth performance attributes that are different from other > > nodes. Crea

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-27 Thread Dan Williams
On Mon, Nov 26, 2018 at 11:00 PM Dan Williams wrote: > > On Wed, Nov 14, 2018 at 2:53 PM Keith Busch wrote: > > > > Heterogeneous memory systems provide memory nodes with latency > > and bandwidth performance attributes that are different from other > > nodes. Crea

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 2:15 AM Anshuman Khandual wrote: > > > > On 11/26/2018 11:38 PM, Dan Williams wrote: > > On Mon, Nov 26, 2018 at 8:42 AM Dave Hansen wrote: > >> > >> On 11/23/18 1:13 PM, Dan Williams wrote: > >>>> A new system cal

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-27 Thread Dan Williams
On Tue, Nov 27, 2018 at 2:15 AM Anshuman Khandual wrote: > > > > On 11/26/2018 11:38 PM, Dan Williams wrote: > > On Mon, Nov 26, 2018 at 8:42 AM Dave Hansen wrote: > >> > >> On 11/23/18 1:13 PM, Dan Williams wrote: > >>>> A new system cal

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-26 Thread Dan Williams
On Wed, Nov 14, 2018 at 2:53 PM Keith Busch wrote: > > Heterogeneous memory systems provide memory nodes with latency > and bandwidth performance attributes that are different from other > nodes. Create an interface for the kernel to register these attributes > under the node that provides the

Re: [PATCH 2/7] node: Add heterogenous memory performance

2018-11-26 Thread Dan Williams
On Wed, Nov 14, 2018 at 2:53 PM Keith Busch wrote: > > Heterogeneous memory systems provide memory nodes with latency > and bandwidth performance attributes that are different from other > nodes. Create an interface for the kernel to register these attributes > under the node that provides the

Re: [driver-core PATCH v6 7/9] driver core: Attach devices on CPU local to device node

2018-11-26 Thread Dan Williams
where we will see the biggest improvement. > > Reviewed-by: Bart Van Assche > Signed-off-by: Alexander Duyck Looks good, Reviewed-by: Dan Williams

Re: [driver-core PATCH v6 7/9] driver core: Attach devices on CPU local to device node

2018-11-26 Thread Dan Williams
where we will see the biggest improvement. > > Reviewed-by: Bart Van Assche > Signed-off-by: Alexander Duyck Looks good, Reviewed-by: Dan Williams

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-26 Thread Dan Williams
On Mon, Nov 26, 2018 at 8:42 AM Dave Hansen wrote: > > On 11/23/18 1:13 PM, Dan Williams wrote: > >> A new system call makes total sense to me. I have the same concern > >> about the completeness of what's exposed in sysfs, I just don't see a > >> _route_ to comp

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-26 Thread Dan Williams
On Mon, Nov 26, 2018 at 8:42 AM Dave Hansen wrote: > > On 11/23/18 1:13 PM, Dan Williams wrote: > >> A new system call makes total sense to me. I have the same concern > >> about the completeness of what's exposed in sysfs, I just don't see a > >> _route_ to comp

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-23 Thread Dan Williams
On Fri, Nov 23, 2018 at 11:21 AM Dave Hansen wrote: > > On 11/22/18 10:42 PM, Anshuman Khandual wrote: > > Are we willing to go in the direction for inclusion of a new system > > call, subset of it appears on sysfs etc ? My primary concern is not > > how the attribute information appears on the

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-23 Thread Dan Williams
On Fri, Nov 23, 2018 at 11:21 AM Dave Hansen wrote: > > On 11/22/18 10:42 PM, Anshuman Khandual wrote: > > Are we willing to go in the direction for inclusion of a new system > > call, subset of it appears on sysfs etc ? My primary concern is not > > how the attribute information appears on the

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-23 Thread Dan Williams
On Thu, Nov 22, 2018 at 11:11 PM Anshuman Khandual wrote: > > > > On 11/22/2018 11:38 PM, Dan Williams wrote: > > On Thu, Nov 22, 2018 at 3:52 AM Anshuman Khandual > > wrote: > >> > >> > >> > >> On 11/19/2018 11:07 PM, Dave Hans

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-23 Thread Dan Williams
On Thu, Nov 22, 2018 at 11:11 PM Anshuman Khandual wrote: > > > > On 11/22/2018 11:38 PM, Dan Williams wrote: > > On Thu, Nov 22, 2018 at 3:52 AM Anshuman Khandual > > wrote: > >> > >> > >> > >> On 11/19/2018 11:07 PM, Dave Hans

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-22 Thread Dan Williams
On Thu, Nov 22, 2018 at 3:52 AM Anshuman Khandual wrote: > > > > On 11/19/2018 11:07 PM, Dave Hansen wrote: > > On 11/18/18 9:44 PM, Anshuman Khandual wrote: > >> IIUC NUMA re-work in principle involves these functional changes > >> > >> 1. Enumerating compute and memory nodes in heterogeneous

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-22 Thread Dan Williams
On Thu, Nov 22, 2018 at 3:52 AM Anshuman Khandual wrote: > > > > On 11/19/2018 11:07 PM, Dave Hansen wrote: > > On 11/18/18 9:44 PM, Anshuman Khandual wrote: > >> IIUC NUMA re-work in principle involves these functional changes > >> > >> 1. Enumerating compute and memory nodes in heterogeneous

Re: [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-21 Thread Dan Williams
On Tue, Nov 20, 2018 at 1:03 AM Peter Zijlstra wrote: > > On Tue, Nov 20, 2018 at 02:59:32AM +, Williams, Dan J wrote: > > On Mon, 2018-11-19 at 15:43 -0800, Dave Hansen wrote: > > > On 11/19/18 3:19 PM, Dan Williams wrote: > > > > Andy wondered wh

Re: [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-21 Thread Dan Williams
On Tue, Nov 20, 2018 at 1:03 AM Peter Zijlstra wrote: > > On Tue, Nov 20, 2018 at 02:59:32AM +, Williams, Dan J wrote: > > On Mon, 2018-11-19 at 15:43 -0800, Dave Hansen wrote: > > > On 11/19/18 3:19 PM, Dan Williams wrote: > > > > Andy wondered wh

Re: [RFC PATCH 1/3] mm, proc: be more verbose about unstable VMA flags in /proc//smaps

2018-11-20 Thread Dan Williams
t; internface. While this has been worked on and it will be fixed properly, > it seems that our wording could see some refinement and be more vocal > about semantic aspect of these flags as well. > > Cc: Jan Kara > Cc: Dan Williams > Cc: David Rientjes > Signed-off-b

Re: [RFC PATCH 1/3] mm, proc: be more verbose about unstable VMA flags in /proc//smaps

2018-11-20 Thread Dan Williams
t; internface. While this has been worked on and it will be fixed properly, > it seems that our wording could see some refinement and be more vocal > about semantic aspect of these flags as well. > > Cc: Jan Kara > Cc: Dan Williams > Cc: David Rientjes > Signed-off-b

Re: [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-19 Thread Dan Williams
On Mon, Nov 19, 2018 at 3:43 PM Dave Hansen wrote: > > On 11/19/18 3:19 PM, Dan Williams wrote: > > Andy wondered why a path that can sleep was using __flush_tlb_all() [1] > > and Dave confirmed the expectation for TLB flush is for modifying / > > invalidat

Re: [PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-19 Thread Dan Williams
On Mon, Nov 19, 2018 at 3:43 PM Dave Hansen wrote: > > On 11/19/18 3:19 PM, Dan Williams wrote: > > Andy wondered why a path that can sleep was using __flush_tlb_all() [1] > > and Dave confirmed the expectation for TLB flush is for modifying / > > invalidat

[PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-19 Thread Dan Williams
etkov Cc: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 5fab264948c2..de95db8ac52f 100644 --- a/arch/x86/mm/init_64.c +++ b

[PATCH] x86/mm: Drop usage of __flush_tlb_all() in kernel_physical_mapping_init()

2018-11-19 Thread Dan Williams
etkov Cc: Reported-by: Andy Lutomirski Suggested-by: Dave Hansen Signed-off-by: Dan Williams --- arch/x86/mm/init_64.c |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c index 5fab264948c2..de95db8ac52f 100644 --- a/arch/x86/mm/init_64.c +++ b

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-16 Thread Dan Williams
On Thu, Nov 15, 2018 at 12:37 PM Matthew Wilcox wrote: > > On Thu, Nov 15, 2018 at 07:59:20AM -0700, Keith Busch wrote: > > On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > > > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > > > Memory-only nodes will often have

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-16 Thread Dan Williams
On Thu, Nov 15, 2018 at 12:37 PM Matthew Wilcox wrote: > > On Thu, Nov 15, 2018 at 07:59:20AM -0700, Keith Busch wrote: > > On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > > > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > > > Memory-only nodes will often have

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-15 Thread Dan Williams
On Thu, Nov 15, 2018 at 7:02 AM Keith Busch wrote: > > On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > > Memory-only nodes will often have affinity to a compute node, and > > > platforms have ways to express that

Re: [PATCH 1/7] node: Link memory nodes to their compute nodes

2018-11-15 Thread Dan Williams
On Thu, Nov 15, 2018 at 7:02 AM Keith Busch wrote: > > On Thu, Nov 15, 2018 at 05:57:10AM -0800, Matthew Wilcox wrote: > > On Wed, Nov 14, 2018 at 03:49:14PM -0700, Keith Busch wrote: > > > Memory-only nodes will often have affinity to a compute node, and > > > platforms have ways to express that

Re: [PATCH 2/5] mm/memory_hotplug: Create add/del_device_memory functions

2018-11-12 Thread Dan Williams
On Mon, Oct 15, 2018 at 8:31 AM Oscar Salvador wrote: > > From: Oscar Salvador > > HMM/devm have a particular handling of memory-hotplug. > They do not go through the common path, and so, they do not > call either offline_pages() or online_pages(). > > The operations they perform are the

<    12   13   14   15   16   17   18   19   20   21   >