Re: [PATCH v2 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-16 Thread Daniel Baluta
es on pre-Linux software(U-Boot) to do > M7 TCM ECC initialization. In future, we could add the support in Linux > to decouple U-Boot and Linux. > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-16 Thread Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 has a System Manager(SM) core runs the System Control Management > Interface(SCMI) firmware. Vendor extenions are implemented in the > firmware, Logical Machine Management(LMM) protocol to manage > Logical Machines

Re: [PATCH 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-04 Thread Daniel Baluta
Hi Peng, Thanks a lot for the patches. Comments inline: On Wed, Jun 4, 2025 at 5:36 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and > one Cortex-M7 core. The System Control Management Interface(SCMI) > firmware runs on the M33 core. T

Re: [PATCH 3/3] remoteproc: imx_rproc: Add support for i.MX95

2025-06-04 Thread Daniel Baluta
On Wed, Jun 4, 2025 at 5:37 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping > Add i.MX95 of_device_id entry > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v7 0/5] Configure imx8mp dsp node for rproc usage

2025-04-15 Thread Daniel Baluta
Hi Shawn, Gentle ping. On Thu, Mar 20, 2025 at 2:08 PM Daniel Baluta wrote: > > DSP found in i.MX8MP SOC can be used by multiple frameworks in order to > enable various applications: > - rproc/rpmsg framework, used to load for example Zephyr samples > - Soun

[PATCH v5 0/5] Configure imx8mp dsp node for rproc usage

2025-04-05 Thread Daniel Baluta
eset controller API (changes merged -> https://patchwork.kernel.org/project/linux-arm-kernel/cover/20250311085812.1296243-1-daniel.bal...@nxp.com/) - drop patches related to DSP run/stall/reset via syscon - picked up patch related to using run_stall via reset contr

[PATCH v6 5/5] arm64: dts: Add dsp rproc related mem regions

2025-04-04 Thread Daniel Baluta
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage, so add rproc specific memory regions. Also, enable dsp node because it is ready to be used. Reviewed-by: Ahmad Fatoum Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/

[PATCH v6 0/5] Configure imx8mp dsp node for rproc usage

2025-03-27 Thread Daniel Baluta
11085812.1296243-1-daniel.bal...@nxp.com/) - drop patches related to DSP run/stall/reset via syscon - picked up patch related to using run_stall via reset controller API. Daniel Baluta (5): arm64: dts: imx8mp: Use resets property arm64: dts: imx8mp: Add mu2 root clock

[PATCH v6 3/5] arm64: dts: imx8mp: Configure dsp node for rproc usage

2025-03-24 Thread Daniel Baluta
ware) will need to create a separate dts file (or an overlay). This change follows the approach taken for other i.MX8 boards in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node for rproc usage") Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by:

[PATCH v7 4/5] arm64: dts: imx8mp: Add DSP clocks

2025-03-20 Thread Daniel Baluta
DSP core needs ocram, core and debug clocks. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts

[PATCH v7 3/5] arm64: dts: imx8mp: Configure dsp node for rproc usage

2025-03-20 Thread Daniel Baluta
ware) will need to create a separate dts file (or an overlay). This change follows the approach taken for other i.MX8 boards in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node for rproc usage") Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by:

[PATCH v7 1/5] arm64: dts: imx8mp: Use resets property

2025-03-20 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch

[PATCH v7 5/5] arm64: dts: Enable DSP node for remoteproc usage

2025-03-20 Thread Daniel Baluta
Enable all relevant nodes to support remoteproc with imx8mp-evk board. - add rproc specific memory regions - enable dsp_reserved node - enable mu2 node - enable dsp node Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 14

[PATCH v7 2/5] arm64: dts: imx8mp: Add mu2 root clock

2025-03-20 Thread Daniel Baluta
Enable MU2 node and add mu2 root clock. MU2 is used to communicate with DSP core. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale

[PATCH v7 0/5] Configure imx8mp dsp node for rproc usage

2025-03-20 Thread Daniel Baluta
oject/linux-arm-kernel/cover/20250311085812.1296243-1-daniel.bal...@nxp.com/) - drop patches related to DSP run/stall/reset via syscon - picked up patch related to using run_stall via reset controller API. Daniel Baluta (5): arm64: dts: imx8mp: Use resets property arm6

[PATCH v6 2/5] arm64: dts: imx8mp: Add mu2 root clock

2025-03-19 Thread Daniel Baluta
Enable MU2 node and add mu2 root clock. MU2 is used to communicate with DSP core. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 4 arch/arm64/boot/dts/freescale/imx8mp.dtsi| 1 + 2 files changed, 5

[PATCH v6 1/5] arm64: dts: imx8mp: Use resets property

2025-03-19 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch

[PATCH v6 4/5] arm64: dts: imx8mp: Add DSP clocks

2025-03-19 Thread Daniel Baluta
DSP core needs ocram, core and debug clocks. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts

Re: [PATCH v2] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-03-19 Thread Daniel Baluta
lback to handle resource table parsing and to > process DSP-specific resource, to determine if waiting is needed. > > Update imx_dsp_rproc_start() to handle this condition accordingly. > > Signed-off-by: Iuliana Prodan Reviewed-by: Daniel Baluta

Re: [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-18 Thread Daniel Baluta
rved_mem_region_to_resource() which is checked for an error. > > Signed-off-by: Rob Herring (Arm) For IMX part: Reviewed-by: Daniel Baluta

Re: [PATCH 1/3] of: reserved_mem: Add functions to parse "memory-region"

2025-03-18 Thread Daniel Baluta
" and then get > the region's address and size. As this is a standard property, it should > have common functions for drivers to use. Add new functions to count the > number of regions and retrieve the region's address as a resource. > > Signed-off-by: Rob Herring (Arm) Reviewed-by: Daniel Baluta

Re: [PATCH v5 2/5] arm64: dts: imx8mp: Add mu2 root clock

2025-03-17 Thread Daniel Baluta
On Mon, Mar 17, 2025 at 5:30 PM Alexander Stein wrote: > > Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta: > > Enable MU2 node and add mu2 root clock. > > MU2 is used to communicate with DSP core. > > > > Reviewed-by: Iuliana Prodan > > Revi

[PATCH v5 2/5] arm64: dts: imx8mp: Add mu2 root clock

2025-03-17 Thread Daniel Baluta
Enable MU2 node and add mu2 root clock. MU2 is used to communicate with DSP core. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot

[PATCH v5 4/5] arm64: dts: imx8mp: Add DSP clocks

2025-03-17 Thread Daniel Baluta
DSP core needs ocram, core and debug clocks. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts

[PATCH v5 3/5] arm64: dts: imx8mp: Configure dsp node for rproc usage

2025-03-17 Thread Daniel Baluta
ware) will need to create a separate dts file (or an overlay). This change follows the approach taken for other i.MX8 boards in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node for rproc usage") Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by:

[PATCH v5 1/5] arm64: dts: imx8mp: Use resets property

2025-03-17 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch

[PATCH v5 5/5] arm64: dts: Add dsp rproc related mem regions

2025-03-17 Thread Daniel Baluta
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage, so add rproc specific memory regions. Also, enable dsp node because it is ready to be used. Reviewed-by: Ahmad Fatoum Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/

[PATCH] remoteproc: imx_dsp_rproc: Document run_stall struct member

2025-03-15 Thread Daniel Baluta
trol the DSP") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503142125.ie33scto-...@intel.com/ Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/

[PATCH v5 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

2025-03-11 Thread Daniel Baluta
https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/ Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 25 + drivers/remoteproc/imx_rproc.h | 2 ++ 2 files changed, 19 insertions(

[PATCH v5 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

2025-03-11 Thread Daniel Baluta
ff-by: Daniel Baluta --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml index ab93ffd3d2e5..b8693e4b4b0d 1

[PATCH v5 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option

2025-03-11 Thread Daniel Baluta
For EARC and EARC PHY the reset happens when clearing the reset bits. Refactor assert/deassert function in order to take into account the active_low configuration option. Reviewed-by: Philipp Zabel Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset

[PATCH v5 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-03-11 Thread Daniel Baluta
We can Run/Stall the DSP via audio block control bits found in audiomix. Implement this functionality using the reset controller and use assert for Stall and deassert for Run. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c

Re: [PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

2025-03-11 Thread Daniel Baluta
On Mon, Mar 10, 2025 at 5:43 PM Mathieu Poirier wrote: > > Good day, > > On Wed, Mar 05, 2025 at 12:00:36PM +0200, Daniel Baluta wrote: > > DSP on i.MX8MP doesn't have a direct reset line so according to hardware > > design team in order to handle assert/deassert/re

[PATCH v5 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-03-11 Thread Daniel Baluta
Current code supports EARC PHY Software Reset and EARC Software Reset but it is not easily extensible to more reset bits. So, refactor the code in order to easily allow more reset bits in the future. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset

[PATCH v5 4/8] reset: imx8mp-audiomix: Add prefix for internal macro

2025-03-11 Thread Daniel Baluta
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show that specific macros are related to audiomix. Reviewed-by: Philipp Zabel Reviewed-by: Frank Li Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 14 +++--- 1 file

[PATCH v5 3/8] arm64: dts: imx8mp: Use resets property

2025-03-11 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch

[PATCH v5 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP

2025-03-11 Thread Daniel Baluta
Add reset ids used for EARC and DSP on i.MX8MP platform. Acked-by: Rob Herring (Arm) Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 + 1 file changed, 13 insertions(+) create mode 100644 include/dt-bindings/reset

[PATCH v5 0/8] imx8mp: Add support to Run/Stall DSP via reset API

2025-03-11 Thread Daniel Baluta
- add correct include in the yaml dts snippet example Changes since v1: (https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/) - addresed comments received on v1 - picked up R-b and A-b tags Daniel Baluta (8): dt-bindings: reset: audiomix: Add reset ids for EA

[PATCH v4 4/8] reset: imx8mp-audiomix: Add prefix for internal macro

2025-03-05 Thread Daniel Baluta
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show that specific macros are related to audiomix. Reviewed-by: Philipp Zabel Reviewed-by: Frank Li Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 14 +++--- 1 file

[PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

2025-03-05 Thread Daniel Baluta
stall control now, but softreset will be added in the future when we will convert the softreset functionality to use reset controller API. [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/ Reviewed-by: Frank Li Signed-off-by: Daniel B

[PATCH v4 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

2025-03-05 Thread Daniel Baluta
07102-6-daniel.bal...@nxp.com/ Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 25 + drivers/remoteproc/imx_rproc.h | 2 ++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/remot

[PATCH v4 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-03-05 Thread Daniel Baluta
Current code supports EARC PHY Software Reset and EARC Software Reset but it is not easily extensible to more reset bits. So, refactor the code in order to easily allow more reset bits in the future. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c

[PATCH v4 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-03-05 Thread Daniel Baluta
We can Run/Stall the DSP via audio block control bits found in audiomix. Implement this functionality using the reset controller and use assert for Stall and deassert for Run. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 8 1 file

[PATCH v4 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option

2025-03-05 Thread Daniel Baluta
For EARC and EARC PHY the reset happens when clearing the reset bits. Refactor assert/deassert function in order to take into account the active_low configuration option. Reviewed-by: Philipp Zabel Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- drivers/reset

[PATCH v4 3/8] arm64: dts: imx8mp: Use resets property

2025-03-05 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/freescale

[PATCH v4 0/8] imx8mp: Add support to Run/Stall DSP via reset API

2025-03-05 Thread Daniel Baluta
emove 'resets' description as it is a common property - add correct include in the yaml dts snippet example Changes since v1: (https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/) - addresed comments received on v1 - picked up R-b and A-b tags Daniel B

[PATCH v4 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP

2025-03-05 Thread Daniel Baluta
Add reset ids used for EARC and DSP on i.MX8MP platform. Acked-by: Rob Herring (Arm) Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 + 1 file changed, 13 insertions(+) create mode 100644 include/dt-bindings/reset

Re: [PATCH v3 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

2025-02-25 Thread Daniel Baluta
Hello Philipp, Thanks for your comments! > The DAP core reset is mentioned in the commit message. Why is it > missing here? After reading the discussion in [1], I'd expect both the > stall and the (core) reset signal to be documented, something like: There is no reset controller driver for DAP a

Re: [PATCH v3 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP

2025-02-25 Thread Daniel Baluta
On Tue, Feb 25, 2025 at 3:18 PM Philipp Zabel wrote: > > On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote: > > Add reset ids used for EARC and DSP on i.MX8MP platform. > > > > Signed-off-by: Daniel Baluta > > Acked-by: Rob Herring (Arm) > > Reviewed-b

[PATCH v3 5/8] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-02-25 Thread Daniel Baluta
Current code supports EARC PHY Software Reset and EARC Software Reset but it is not easily extensible to more reset bits. So, refactor the code in order to easily allow more reset bits in the future. Signed-off-by: Daniel Baluta Reviewed-by: Frank Li --- drivers/reset/reset-imx8mp-audiomix.c

[PATCH v3 4/8] reset: imx8mp-audiomix: Add prefix for internal macro

2025-02-25 Thread Daniel Baluta
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show that specific macros are related to audiomix. Signed-off-by: Daniel Baluta Reviewed-by: Philipp Zabel Reviewed-by: Frank Li Reviewed-by: Peng Fan --- drivers/reset/reset-imx8mp-audiomix.c | 14 +++--- 1 file

[PATCH v3 8/8] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-25 Thread Daniel Baluta
07102-6-daniel.bal...@nxp.com/ Signed-off-by: Daniel Baluta Reviewed-by: Peng Fan Reviewed-by: Frank Li --- drivers/remoteproc/imx_dsp_rproc.c | 25 + drivers/remoteproc/imx_rproc.h | 2 ++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/remot

[PATCH v3 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-02-25 Thread Daniel Baluta
We can Run/Stall the DSP via audio block control bits found in audiomix. Implement this functionality using the reset controller and use assert for Stall and deassert for Run. Signed-off-by: Daniel Baluta Reviewed-by: Frank Li --- drivers/reset/reset-imx8mp-audiomix.c | 8 1 file

[PATCH v3 6/8] reset: imx8mp-audiomix: Introduce active_low configuration option

2025-02-25 Thread Daniel Baluta
For EARC and EARC PHY the reset happens when clearing the reset bits. Refactor assert/deassert function in order to take into account the active_low configuration option. Signed-off-by: Daniel Baluta Reviewed-by: Philipp Zabel Reviewed-by: Peng Fan Reviewed-by: Frank Li --- drivers/reset

[PATCH v3 1/8] dt-bindings: reset: audiomix: Add reset ids for EARC and DSP

2025-02-25 Thread Daniel Baluta
Add reset ids used for EARC and DSP on i.MX8MP platform. Signed-off-by: Daniel Baluta Acked-by: Rob Herring (Arm) Reviewed-by: Frank Li --- include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 + 1 file changed, 13 insertions(+) create mode 100644 include/dt-bindings/reset

[PATCH v3 3/8] arm64: dts: imx8mp: Use resets property

2025-02-25 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Signed-off-by: Daniel Baluta Reviewed-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/freescale

[PATCH v3 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

2025-02-25 Thread Daniel Baluta
l.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/ Signed-off-by: Daniel Baluta Reviewed-by: Frank Li --- .../devicetree/bindings/dsp/fsl,dsp.yaml | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/ds

[PATCH v3 0/8] imx8mp: Add support to Run/Stall DSP via reset API

2025-02-25 Thread Daniel Baluta
ppet example Changes since v1: (https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/) - addresed comments received on v1 - picked up R-b and A-b tags Daniel Baluta (8): dt-bindings: reset: audiomix: Add reset ids for EARC and DSP dt-bindings: dsp: fsl,dsp: Add res

Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-19 Thread Daniel Baluta
> > + case IMX_RPROC_RESET_CONTROLLER: > > + priv->reset = devm_reset_control_get_optional_exclusive(dev, > > NULL); > > Is this optional on purpose? There is no mention of it in the commit > message. Where is this resets property documented in the dt-bindings? For this particular

Re: [PATCH 2/5] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-02-19 Thread Daniel Baluta
On Tue, Feb 18, 2025 at 5:56 PM Frank Li wrote: > > On Tue, Feb 18, 2025 at 10:57:09AM +0200, Daniel Baluta wrote: > > Current code supports EARC PHY Software Reset and EARCSoftware > > Reset but it is not easily extensible to more reset bits. > > > > So,

[PATCH 3/5] reset: imx8mp-audiomix: Introduce active_low configuration option

2025-02-18 Thread Daniel Baluta
For EARC and EARC PHY the reset happens when clearing the reset bits. Refactor assert/deassert function in order to take into account the active_low configuratin option. Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 45 ++- 1 file changed, 23

[PATCH 4/5] reset: imx8mp-audiomix: Add support for DSP run/stall

2025-02-18 Thread Daniel Baluta
We can Run/Stall the DSP via audio block control bits found in audiomix. Implement this functionality using the reset controller and use assert for Stall and deassert for Run. Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 12 ++-- 1 file changed, 10 insertions

[PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

2025-02-18 Thread Daniel Baluta
Use the reset controller API to control the DSP on i.MX8MP. This way we can have a better control of the resources and avoid using a syscon to access the audiomix bits. Signed-off-by: Daniel Baluta --- drivers/remoteproc/imx_dsp_rproc.c | 25 + drivers/remoteproc

[PATCH 0/5] imx8mp: Add support to Run/Stall DSP via reset API

2025-02-18 Thread Daniel Baluta
://patchwork.kernel.org/project/imx/patch/20241210125338.104959-6-daniel.bal...@nxp.com/ Daniel Baluta (5): reset: imx8mp-audiomix: Add prefix for internal macro reset: imx8mp-audiomix: Prepare the code for more reset bits reset: imx8mp-audiomix: Introduce active_low configuration option reset

[PATCH 2/5] reset: imx8mp-audiomix: Prepare the code for more reset bits

2025-02-18 Thread Daniel Baluta
Current code supports EARC PHY Software Reset and EARC Software Reset but it is not easily extensible to more reset bits. So, refactor the code in order to easily allow more reset bits in the future. Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 53

[PATCH 1/5] reset: imx8mp-audiomix: Add prefix for internal macro

2025-02-18 Thread Daniel Baluta
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show that specific macros are related to audiomix. Signed-off-by: Daniel Baluta --- drivers/reset/reset-imx8mp-audiomix.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/reset/reset

Re: [RFC PATCH] remoteproc: core: Add support for predefined notifyids

2024-10-30 Thread Daniel Baluta
On Wed, Oct 23, 2024 at 6:32 PM Mathieu Poirier wrote: > > Hello Daniel, > > On Fri, Oct 18, 2024 at 02:09:29PM +0300, Daniel Baluta wrote: > > Currently we generate notifyids in the linux kernel and override > > those found in rsc_table. > > > > This doesn

[RFC PATCH] remoteproc: core: Add support for predefined notifyids

2024-10-18 Thread Daniel Baluta
is we also define an invalid notifid as 0xU. This should be placed as notifids if users want Linux to generate the ids. Signed-off-by: Alexandru Lastur Signed-off-by: Daniel Baluta --- drivers/remoteproc/remoteproc_core.c | 14 -- include/linux/remoteproc.h | 1 + 2

Re: [PATCH v3 2/2] remoteproc: imx_rproc: Add support for poweroff and reboot

2024-08-23 Thread Daniel Baluta
eate them as non-blocking. > > Note that power off and restart are totally different operations and are > not complementary. > > We introduce a new flag in the imx remoteproc per device data which tells > us when a device needs this special setup. For now, only imx7ulp needs it. > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v3 1/2] remoteproc: imx_rproc: Allow setting of the mailbox transmit mode

2024-08-23 Thread Daniel Baluta
x_block mode to be set (true/false) depending on usecase. > > No functional changes. > > Signed-off-by: Peng Fan Reviewed-by: Daniel Baluta

Re: [PATCH v2 2/2] remoteproc: imx_rproc: handle system off for i.MX7ULP

2024-08-21 Thread Daniel Baluta
Hello Mathieu, I've talked to Peng and if my understanding is correct I think the patch is OK. Maybe we can split the patch in two: * first, adding the power off callback with explanations. * second, adding the restart callback with explanations. And also add a more detailed explanation. Power o

Re: [PATCH v2 0/2] remoteproc: imx_rproc: support non-blocking tx for i.MX7ULP

2024-07-19 Thread Daniel Baluta
for completion. > > patch 1 is to support non-blocking tx mailbox channel > patch 2 is to switch to non-blocking tx for system poweroff or restart. > > Based on patchset: > https://lore.kernel.org/all/20240719-imx_rproc-v2-0-10d0268c7...@nxp.com/ > > Signed-off-by: Peng Fan Series looks good to me. Reviewed-by: Daniel Baluta

Re: [PATCH v2 0/4] remoteproc: imx_rproc: various patches for misc

2024-07-19 Thread Daniel Baluta
> Signed-off-by: Peng Fan Neat and clean. Reviewed-by: Daniel Baluta Thanks Peng!

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-08 Thread Daniel Baluta
On Fri, Jan 5, 2024 at 6:02 PM Ulf Hansson wrote: > > Updates in v2: > - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches to > requests help with testing. > - Fixed NULL pointer bug in patch1, pointed out by Nikunj. > - Added so

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Daniel Baluta
On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan wrote: > > On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:13, Iuliana Prodan wrote: > >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: > >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > >

[PATCH v2] ASoC: core: Don't set platform name when of_node is set

2021-03-25 Thread Daniel Baluta
From: Daniel Baluta A DAI link has 3 components: * CPU * platform * codec(s) A component is specified via: * name * of_node * dai_name In order to avoid confusion when building a sound card we disallow matching by both name and of_node (1

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-17 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 4:24 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 02:37:30PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > > > No, just the opposite! If there's an explict name configured why do you > > >

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 12:59:29PM +0200, Daniel Baluta wrote: > > On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > > > If an explicit name has been provided why would we override it with an > > > autog

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote: > > On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote: > > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > > > > + if (!dai_link->platforms->of_node) > > > > +

Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-12 Thread Daniel Baluta
On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote: > > On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote: > > From: Daniel Baluta > > > > Platform may be specified by either name or OF node but not > > both. > > > > For OF node platforms (e

[PATCH] ASoC: core: Don't set platform name when of_node is set

2021-03-09 Thread Daniel Baluta
From: Daniel Baluta Platform may be specified by either name or OF node but not both. For OF node platforms (e.g i.MX) we end up with both platform name and of_node set and sound card registration will fail with the error: asoc-simple-card sof-sound-wm8960: ASoC: Neither/both platform name

Re: [PATCH] ASoC: wm8962: Relax bit clock divider searching

2021-03-05 Thread Daniel Baluta
t; > wm8962 3-001a: Unsupported BCLK ratio 9 > > Fix this by relaxing bitclk divider searching, so that when > no exact value can be derived from sysclk pick the closest > value greater than expected bitclk. > > Signed-off-by: Shengjiu Wang Reviewed-by: Daniel Baluta

Re: [PATCH V3 1/5] firmware: imx: scu-seco: Add Secure Controller APIS

2020-11-11 Thread Daniel Baluta
On Tue, Nov 10, 2020 at 4:15 PM wrote: > > From: Franck LENORMAND Looks good to me. Thanks Franck! Reviewed-by: Daniel Baluta

[PATCH RESEND 3/3] firmware: imx-dsp: Export functions to request/free channels

2020-11-11 Thread Daniel Baluta
_sync which increments device usage count and will keep the device active. Specifically, mailbox clock will be always ON when a mailbox channel is requested. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 25 + include/linux/firmware/imx/dsp.h

[PATCH RESEND 2/3] firmware: imx: Save channel name for further use

2020-11-11 Thread Daniel Baluta
We want to request / free channels on demand later in order to save power. For this for each channel we save the name and use it to reference the channel later. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH RESEND 0/3] Allow on demand channel request / free

2020-11-11 Thread Daniel Baluta
uce a way to request/free IMX DSP channels on demand to save power when the channels are not used. First two patches are doing code refactoring preparing the path for 3rd patch which exports functions for on demand channel request/free Daniel Baluta (3): firmware: imx: Introduce imx_dsp_setup_cha

[PATCH RESEND 1/3] firmware: imx: Introduce imx_dsp_setup_channels

2020-11-11 Thread Daniel Baluta
Create a separate function that sets up DSP mailbox channels so that imx_dsp_probe function will be easier to read. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 41 +- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/drivers

Re: [PATCH] ASoC: fsl_spdif: Add support for higher sample rates

2020-10-13 Thread Daniel Baluta
On Tue, Oct 13, 2020 at 1:49 PM Shengjiu Wang wrote: > > On Tue, Oct 13, 2020 at 6:42 PM Daniel Baluta wrote: > > > > On Tue, Oct 13, 2020 at 12:29 PM Nicolin Chen > > wrote: > > > > > > Hi Shengjiu, > > > > > > On Mon, Oct 12, 2020 a

Re: [PATCH] ASoC: fsl_spdif: Add support for higher sample rates

2020-10-13 Thread Daniel Baluta
t; > Signed-off-by: Shengjiu Wang > > Signed-off-by: Viorel Suman > > Probably should put your own Signed-off at the bottom? Hi Shengjiu, Also please keep the original author of the patch. You can change that using git commit --amend --author="Viorel Suman ". With that, Reviewed-by: Daniel Baluta

[PATCH 1/2] ASoC: SOF: Activate runtime PM with SOF OF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta SOF boots the DSP at probe and keeps it up all the time. With this change, after booting if no one is using the DSP the SOF core will turn off the DSP to save power. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel

[PATCH 2/2] ASoC: SOF: Add .prepare/.complete callbacks

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta Use SOF defined callbacks (snd_sof_prepare/snd_sof_complete) in order to update internal SOF system suspend target. Reviewed-by: Kai Vehmanen Reviewed-by: Paul Olaru Reviewed-by: Pierre-Louis Bossart Signed-off-by: Daniel Baluta --- sound/soc/sof/sof-of-dev.c | 2 ++ 1

[PATCH 0/2] Enable runtime PM for SOF device

2020-09-24 Thread Daniel Baluta
From: Daniel Baluta This enables runtime PM for SOF device. Next patchseries will provide PM suspend/resume handlers for i.MX8 specific devices. Daniel Baluta (2): ASoC: SOF: Activate runtime PM with SOF OF device ASoC: SOF: Add .prepare/.complete callbacks sound/soc/sof/sof-of-dev.c | 6

[RESEND PATCH 1/3] firmware: imx: Introduce imx_dsp_setup_channels

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta Create a separate function that sets up DSP mailbox channels so that imx_dsp_probe function will be easier to read. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 41 +- 1 file changed, 26 insertions(+), 15 deletions

[RESEND PATCH 3/3] firmware: imx-dsp: Export functions to request/free channels

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta In order to save power, we only need to request a channel when the communication with the DSP active. For this we export the following functions: - imx_dsp_request_channel, gets a channel with a given index - imx_dsp_free_channel, frees a channel with a given

[RESEND PATCH 2/3] firmware: imx: Save channel name for further use

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta We want to request / free channels on demand later in order to save power. For this for each channel we save the name and use it to reference the channel later. Signed-off-by: Daniel Baluta --- drivers/firmware/imx/imx-dsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[RESEND PATCH 0/3] Allow on demand channel request / free

2020-09-14 Thread Daniel Baluta
From: Daniel Baluta Requesting an mailbox channel will call mailbox's startup function. startup function calls pm_runtime_get_sync which increments device usage count and will keep the device active. Specifically, mailbox clock will be always ON when a mailbox channel is requested. For

Re: [RFC PATCH v2 6/6] ASoC: q6asm-dai: add support to set_codec_params

2020-07-22 Thread Daniel Baluta
On Tue, Jul 21, 2020 at 8:03 PM Srinivas Kandagatla wrote: > > Make use of new set_codec_params callback to allow decoder switching > during gapless playback. > > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/qdsp6/q6asm-dai.c | 33 > 1 file changed,

[PATCH 3/7] ASoC: SOF: imx8: Fix ESAI DAI driver name for i.MX8/iMX8X

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta This must match DAI name from topology. Also, esai-port is too generic as they are 2 ESAIs on i.MX8/i.MX8X boards. SOF integration only uses ESAI0 for now. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani

[PATCH 0/7] SOF IMX fixes

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta This patchseries contains a couple of SOF IMX fixes found during our first IMX SOF release. Daniel Baluta (7): ASoC: SOF: define INFO_ flags in dsp_ops for imx8 ASoC: SOF: imx: Use ARRAY_SIZE instead of hardcoded value ASoC: SOF: imx8: Fix ESAI DAI driver name for

[PATCH 2/7] ASoC: SOF: imx: Use ARRAY_SIZE instead of hardcoded value

2020-07-20 Thread Daniel Baluta
From: Daniel Baluta With this change we no longer need to update num_drv when adding new DAI driver. Signed-off-by: Daniel Baluta Reviewed-by: Pierre-Louis Bossart Reviewed-by: Kai Vehmanen Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski --- sound/soc/sof/imx/imx8.c | 4

  1   2   3   4   5   6   7   8   9   10   >