Re: [PATCH v2 2/2] media: i2c: Add support for ov5693 sensor

2021-04-06 Thread Daniel Scally
Hi JM! On 06/04/2021 14:54, Jean-Michel Hautbois wrote: > Hello Daniel ! > > Thanks for the patch ! > > On 06/04/2021 00:56, Daniel Scally wrote: >> The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The >> chip is capable of a single lane configurat

[PATCH v2 1/2] media: ipu3-cio2: Toggle sensor streaming in pm runtime ops

2021-04-05 Thread Daniel Scally
ment those operations. Signed-off-by: Daniel Scally --- Changes in v2: Patch introduced drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel

[PATCH v2 0/2] Add support for OV5693 Sensor

2021-04-05 Thread Daniel Scally
most of the global register settings and some of the other functions from that driver, but otherwise uses the "normal" v4l2 infrastructure. Daniel Scally (2): media: ipu3-cio2: Toggle sensor streaming in pm runtime ops media: i2c: Add support for ov5693 sensor M

[PATCH v2 2/2] media: i2c: Add support for ov5693 sensor

2021-04-05 Thread Daniel Scally
s all mandatory, optional and recommended V4L2 controls for maximum compatibility with libcamera. Signed-off-by: Daniel Scally --- Changes in v2: - Removed HDR mode from the exposure configure function, as it's not necessary and seemed to be causing frame sync errors.

Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when looping over ACPI devices

2021-04-05 Thread Daniel Scally
() is called by the > caller. > > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") > Cc: Daniel Scally > Cc: Sakari Ailus > Signed-off-by: Andy Shevchenko Ah; thanks for catching those, I'm annoyed to have missed the acpi_dev_put() calls in particular Reviewed-by: Daniel Scally

Re: [PATCH v2 5/6] software node: Introduce SOFTWARE_NODE_REFERENCE() helper macro

2021-03-31 Thread Daniel Scally
tually and there it might be the case). Ah yeah I see - haven't come across phandles before but having looked them up now I see what this is meant to emulate. Consistency is good; in that case, for this and 6/6: Reviewed-by: Daniel Scally and Tested-by: Daniel Scally >

Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails

2021-03-29 Thread Daniel Scally
ng resources explicitly when swnode_register() > fails. Currently it happens only in fwnode_create_software_node(). > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Scally and Tested-by: Daniel Scally > --- > v2: no changes > drivers/base/swnode.c | 29 ++

Re: [PATCH v2 5/6] software node: Introduce SOFTWARE_NODE_REFERENCE() helper macro

2021-03-29 Thread Daniel Scally
Hi Andy On 29/03/2021 16:12, Andy Shevchenko wrote: > This is useful to assign software node reference with arguments > in a common way. Moreover, we have already couple of users that > may be converted. And by the fact, one of them is moved right here > to use the helper. > > Signed-off-by: Andy

Re: [PATCH v2 3/6] software node: Deduplicate code in fwnode_create_software_node()

2021-03-29 Thread Daniel Scally
Hi Andy On 29/03/2021 16:12, Andy Shevchenko wrote: > Deduplicate conditional and assignment in fwnode_create_software_node(), > i.e. parent is checked in two out of three cases and parent software node > is assigned by to_swnode() call. > > Signed-off-by: Andy Shevchenko Revi

Re: [PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-03-29 Thread Daniel Scally
Hi Andy On 29/03/2021 16:03, Andy Shevchenko wrote: > On Thu, Mar 04, 2021 at 01:49:14PM +0000, Daniel Scally wrote: >> On 04/03/2021 13:37, Hans de Goede wrote: >>> On 2/22/21 2:07 PM, Daniel Scally wrote: > ... > >>>> The existing mfd/tps68470.c driver

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-15 Thread Daniel Scally
Hi Laurent On 14/03/2021 23:29, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Fri, Mar 12, 2021 at 10:32:39AM +, Daniel Scally wrote: >> The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The >> chip is capable of a sin

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-14 Thread Daniel Scally
Hi Jacopo, thanks for the review On 14/03/2021 10:40, Jacopo Mondi wrote: >> +#define OV5693_REG_CHIP_ID_H0x300A >> +#define OV5693_REG_CHIP_ID_L0x300B > Please use lower case letters in hex identifiers Will do >> + >> +/* Miscellaneous */ >> +#de

[PATCH 0/1] Add support for OV5693 Sensor

2021-03-12 Thread Daniel Scally
hat library (at least, at time of writing) are supported. Daniel Scally (1): media: i2c: Add support for ov5693 sensor MAINTAINERS|7 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5693.c | 1585 ++

[PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-12 Thread Daniel Scally
s all mandatory, optional and recommended V4L2 controls for maximum compatibility with libcamera. Signed-off-by: Daniel Scally --- MAINTAINERS|7 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5693.c |

Re: [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list()

2021-03-08 Thread Daniel Scally
On Sun, Mar 7, 2021 at 9:39 PM Andy Shevchenko >>>> wrote: >>>>> On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally wrote: >>>>>> On 22/02/2021 13:34, Andy Shevchenko wrote: >>>>>>> On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally >>>>

Re: [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list()

2021-03-08 Thread Daniel Scally
Hi Rafael On 08/03/2021 17:46, Rafael J. Wysocki wrote: >> +void acpi_walk_dep_device_list(acpi_handle handle, >> + int (*callback)(struct acpi_dep_data *, void >> *), >> + void *data) >> +{ >> + struct acpi_dep_data *dep, *tmp; >> +

Re: [PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list()

2021-03-07 Thread Daniel Scally
Hi Andy On 22/02/2021 13:34, Andy Shevchenko wrote: > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally wrote: >> The acpi_walk_dep_device_list() is not as generalisable as its name >> implies, serving only to decrement the dependency count for each >> dependent device of

Re: [PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-03-04 Thread Daniel Scally
Hi Hans On 04/03/2021 13:37, Hans de Goede wrote: > Hi, > > On 2/22/21 2:07 PM, Daniel Scally wrote: >> v1 for this series was originally 14-18 of this series: >> https://lore.kernel.org/linux-media/20201130133129.1024662-1-djrsca...@gmail.com/T/#m91934e12e3d033da2e768e952ea3

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-24 Thread Daniel Scally
Hi Andy, Laurent On 24/02/2021 10:18, Andy Shevchenko wrote: > On Wed, Feb 24, 2021 at 12:16 PM Laurent Pinchart > wrote: >> On Tue, Feb 23, 2021 at 10:36:18PM +0000, Daniel Scally wrote: >>> On 23/02/2021 20:04, Laurent Pinchart wrote: > ... > >>>>> +

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-23 Thread Daniel Scally
Hi Laurent On 23/02/2021 20:04, Laurent Pinchart wrote: > + > +/* > + * Here follows platform specific mapping information that we can pass to > + * the functions mapping resources to the sensors. Where the sensors have > + * a power enable pin defined in DSDT we need to provide a supply name so >

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-23 Thread Daniel Scally
On 23/02/2021 12:01, Andy Shevchenko wrote: + if (ares->type != ACPI_RESOURCE_TYPE_GPIO || + ares->data.gpio.connection_type != ACPI_RESOURCE_GPIO_TYPE_IO) + return 1; /* Deliberately positive so parsing continues */ >>> I don't like to lose control over

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-22 Thread Daniel Scally
Hi Hans, thanks for the input On 22/02/2021 13:27, Hans de Goede wrote: > Hi, > > On 2/22/21 2:19 PM, Daniel Scally wrote: >> Hi all >> >> On 22/02/2021 13:07, Daniel Scally wrote: >>> diff --git a/drivers/platform/x86/intel-int3472/Kconfig >>>

Re: [PATCH v3 6/6] mfd: tps68470: Remove tps68470 MFD driver

2021-02-22 Thread Daniel Scally
On 22/02/2021 14:12, Andy Shevchenko wrote: > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally wrote: >> This driver only covered one scenario in which ACPI devices with _HID >> INT3472 are found, and its functionality has been taken over by the >> intel-skl-int3472 module, so

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-22 Thread Daniel Scally
Hi Andy - thanks for comments! On 22/02/2021 14:58, Andy Shevchenko wrote: > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally wrote: >> ACPI devices with _HID INT3472 are currently matched to the tps68470 >> driver, however this does not cover all situations in which that _HID &

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-22 Thread Daniel Scally
Hi all On 22/02/2021 13:07, Daniel Scally wrote: > diff --git a/drivers/platform/x86/intel-int3472/Kconfig > b/drivers/platform/x86/intel-int3472/Kconfig > new file mode 100644 > index ..b94622245c21 > --- /dev/null > +++ b/drivers/platform/x86/intel-int3472/Kconf

Re: [PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-02-22 Thread Daniel Scally
+cc Andy, who's email address I managed to screw up - sorry. On 22/02/2021 13:07, Daniel Scally wrote: > v1 for this series was originally 14-18 of this series: > https://lore.kernel.org/linux-media/20201130133129.1024662-1-djrsca...@gmail.com/T/#m91934e12e3d033da2e768e952ea3b4a125ee

[PATCH v3 6/6] mfd: tps68470: Remove tps68470 MFD driver

2021-02-22 Thread Daniel Scally
This driver only covered one scenario in which ACPI devices with _HID INT3472 are found, and its functionality has been taken over by the intel-skl-int3472 module, so remove it. Reviewed-by: Laurent Pinchart Signed-off-by: Daniel Scally --- Changes in v3: - Replaced Kconfig dependencies

[PATCH v3 3/6] i2c: core: Add a format macro for I2C device names

2021-02-22 Thread Daniel Scally
igned-off-by: Daniel Scally --- Changes in v3: - None drivers/i2c/i2c-core-base.c | 4 ++-- include/linux/i2c.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 63ebf722a424..547b8926cac8 100644 -

[PATCH v3 4/6] gpiolib: acpi: Export acpi_get_gpiod()

2021-02-22 Thread Daniel Scally
the GPIO layer, provide and export a wrapper function that additionally holds a reference to the GPIO device. Signed-off-by: Daniel Scally --- Changes in v3: - Having realised that it wasn't taking a reference to the GPIO device, I decided the best thing to do was leave the exi

[PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-22 Thread Daniel Scally
1 and #2, by querying the CLDB buffer found against INT3472 entries to determine which is most appropriate. Suggested-by: Laurent Pinchart Signed-off-by: Daniel Scally --- Changes in v3: - Added clk_recalc_rate() operation to the clk that's registered, plus some associated

[PATCH v3 1/6] ACPI: scan: Extend acpi_walk_dep_device_list()

2021-02-22 Thread Daniel Scally
calls to the function with calls to a wrapper, passing a callback that applies the same dependency reduction. Suggested-by: Rafael J. Wysocki Signed-off-by: Daniel Scally --- Changes in v3: - patch introduced drivers/acpi/ec.c | 2 +- drivers/acpi/pmic

[PATCH v3 2/6] ACPI: scan: Add function to fetch dependent of acpi device

2021-02-22 Thread Daniel Scally
p_list and return the dependent ACPI device. Signed-off-by: Daniel Scally --- Changes in v3: - Switched from a standalone function to a callback passed to acpi_walk_dep_device_list(). drivers/acpi/scan.c | 34 ++ include/acpi/acpi_bus.h | 1

[PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-02-22 Thread Daniel Scally
part of this series. The existing mfd/tps68470.c driver being thus superseded, it is removed. Thanks Dan Daniel Scally (6): ACPI: scan: Extend acpi_walk_dep_device_list() ACPI: scan: Add function to fetch dependent of acpi device i2c: core: Add a format macro for I2C device names gpiolib: ac

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-02-07 Thread Daniel Scally
Hello Andy, Laurent On 21/01/2021 00:18, Daniel Scally wrote: > On 20/01/2021 12:57, Andy Shevchenko wrote: >> On Wed, Jan 20, 2021 at 06:21:41AM +0200, Laurent Pinchart wrote: >>> On Tue, Jan 19, 2021 at 07:51:14PM +0200, Andy Shevchenko wrote: >>>> On Tue, Ja

Re: [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled

2021-02-02 Thread Daniel Scally
On 02/02/2021 20:30, Sakari Ailus wrote: > On Tue, Feb 02, 2021 at 12:24:54PM -0800, Randy Dunlap wrote: >> On 2/2/21 12:14 PM, Sakari Ailus wrote: >>> ipu3-cio2-bridge uses several features of the ACPI framework that have no >>> meaningful replacement when ACPI is disabled. Instead of adding #ifde

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-02-02 Thread Daniel Scally
Hi Rafael On 21/01/2021 21:06, Daniel Scally wrote: > > On 21/01/2021 18:08, Rafael J. Wysocki wrote: >> On Thu, Jan 21, 2021 at 5:34 PM Daniel Scally wrote: >>> >>> On 21/01/2021 14:39, Rafael J. Wysocki wrote: >>>> On Thu, Jan 21, 2021 at 1:04 PM Da

Re: [PATCH v2 4/7] i2c: i2c-core-acpi: Add i2c_acpi_dev_name()

2021-01-28 Thread Daniel Scally
On 28/01/2021 09:17, Wolfram Sang wrote: >> Just to clarify; "open-code" meaning inline it in the caller like >> Laurent said, right? > Yes. > Thanks - will do that and drop this one then

Re: [PATCH v2 4/7] i2c: i2c-core-acpi: Add i2c_acpi_dev_name()

2021-01-28 Thread Daniel Scally
On 28/01/2021 09:00, Wolfram Sang wrote: >>> There's a real danger of a memory leak, as the function name sounds very >>> similar to dev_name() or acpi_dev_name() and those don't allocate >>> memory. I'm not sure what a better name would be, but given that this >>> function is only used in patch 6/

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-21 Thread Daniel Scally
ue, Jan 19, 2021 at 11:33:58AM +0200, Andy Shevchenko wrote: >>>>> On Tue, Jan 19, 2021 at 12:11:40AM +, Daniel Scally wrote: >>>>>> On 18/01/2021 21:19, Daniel Scally wrote: > ... > >>>>> See my previous reply. TL;DR: you have to modify c

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Daniel Scally
On 21/01/2021 18:08, Rafael J. Wysocki wrote: > On Thu, Jan 21, 2021 at 5:34 PM Daniel Scally wrote: >> >> On 21/01/2021 14:39, Rafael J. Wysocki wrote: >>> On Thu, Jan 21, 2021 at 1:04 PM Daniel Scally wrote: >>>> On 21/01/2021 11:58, Rafael J. Wysocki wro

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Daniel Scally
On 21/01/2021 14:39, Rafael J. Wysocki wrote: > On Thu, Jan 21, 2021 at 1:04 PM Daniel Scally wrote: >> >> On 21/01/2021 11:58, Rafael J. Wysocki wrote: >>> On Thu, Jan 21, 2021 at 10:47 AM Daniel Scally wrote: >>>> Hi Rafael >>>> >>>>

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Daniel Scally
On 21/01/2021 11:58, Rafael J. Wysocki wrote: > On Thu, Jan 21, 2021 at 10:47 AM Daniel Scally wrote: >> Hi Rafael >> >> On 19/01/2021 13:15, Rafael J. Wysocki wrote: >>> On Mon, Jan 18, 2021 at 9:51 PM Daniel Scally wrote: >>>> On 18/01/2021 16:14,

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-21 Thread Daniel Scally
Hi Rafael On 19/01/2021 13:15, Rafael J. Wysocki wrote: > On Mon, Jan 18, 2021 at 9:51 PM Daniel Scally wrote: >> On 18/01/2021 16:14, Rafael J. Wysocki wrote: >>> On Mon, Jan 18, 2021 at 1:37 AM Daniel Scally wrote: >>>> In some ACPI tables we encounter, devices

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-20 Thread Daniel Scally
n 19, 2021 at 01:08:37PM +0200, Andy Shevchenko wrote: >>>>> On Tue, Jan 19, 2021 at 10:40:42AM +, Daniel Scally wrote: >>>>>> On 19/01/2021 09:24, Andy Shevchenko wrote: >>>>>>>>>>> +static struct i2c_driver in

Re: [PATCH v3] software_node: Add kernel-doc comments to exported symbols

2021-01-20 Thread Daniel Scally
Hi Sakari On 20/01/2021 10:35, Sakari Ailus wrote: > Hi Dan, > > On Wed, Jan 20, 2021 at 12:03:39AM +0000, Daniel Scally wrote: >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any >> kernel-doc comments; add those in so all exported symbols are docum

[PATCH v3] software_node: Add kernel-doc comments to exported symbols

2021-01-19 Thread Daniel Scally
A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any kernel-doc comments; add those in so all exported symbols are documented. Reviewed-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Reviewed-by: Randy Dunlap Reviewed-by: Sakari Ailus Signed-off-by: Daniel Scally

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-19 Thread Daniel Scally
On 19/01/2021 13:15, Rafael J. Wysocki wrote: > On Mon, Jan 18, 2021 at 9:51 PM Daniel Scally wrote: >> On 18/01/2021 16:14, Rafael J. Wysocki wrote: >>> On Mon, Jan 18, 2021 at 1:37 AM Daniel Scally wrote: >>>> In some ACPI tables we encounter, devices use th

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Daniel Scally
On 19/01/2021 11:11, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 10:56:17AM +, Kieran Bingham wrote: >> On 18/01/2021 00:34, Daniel Scally wrote: > ... > >>> +config INTEL_SKL_INT3472 >>> + tristate "Intel SkyLake ACPI INT3472 Driver" &g

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Daniel Scally
On 19/01/2021 09:24, Andy Shevchenko wrote: > +static struct i2c_driver int3472_tps68470 = { > + .driver = { > + .name = "int3472-tps68470", > + .acpi_match_table = int3472_device_id, > + }, > + .probe_new = skl_int3472_tps68470_probe, > +}; >>> I'm not

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Daniel Scally
Morning Andy On 19/01/2021 09:33, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 12:11:40AM +0000, Daniel Scally wrote: >> On 18/01/2021 21:19, Daniel Scally wrote: >> I'm more and more confident that this will work, but it has some >> knock-on effects: >> &g

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-19 Thread Daniel Scally
Hi Laurent On 19/01/2021 06:19, Laurent Pinchart wrote: > Hi Daniel, > > On Mon, Jan 18, 2021 at 08:46:34PM +0000, Daniel Scally wrote: >> Hi Laurent, thanks for the comments - really appreciate the detail. >> >> Some specific responses below but assume a general &qu

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Daniel Scally
Hi Andy, Laurent On 18/01/2021 21:19, Daniel Scally wrote: >>>> +static const struct clk_ops skl_int3472_clock_ops = { >>>> + .prepare = skl_int3472_clk_prepare, >>>> + .unprepare = skl_int3472_clk_unprepare, >>>> + .enable = skl_int3472_clk_en

Re: [PATCH v2 5/7] gpio: gpiolib-acpi: Export acpi_get_gpiod()

2021-01-18 Thread Daniel Scally
On 18/01/2021 13:45, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 12:34:26AM +0000, Daniel Scally wrote: >> I need to be able to translate GPIO resources in an acpi_device's _CRS > > ACPI device's > >> into gpio_descs. Those are represented in _CRS as a

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Daniel Scally
Hi Andy - thanks as always for the comments Some responses below, but if not mentioned I'll follow your suggestion of course On 18/01/2021 14:46, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 11:15:21AM +0200, Laurent Pinchart wrote: >> On Mon, Jan 18, 2021 at 12:34:27AM +,

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-18 Thread Daniel Scally
On 18/01/2021 16:14, Rafael J. Wysocki wrote: > On Mon, Jan 18, 2021 at 1:37 AM Daniel Scally wrote: >> In some ACPI tables we encounter, devices use the _DEP method to assert >> a dependence on other ACPI devices as opposed to the OpRegions that the >> specification intend

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Daniel Scally
Hi Laurent, thanks for the comments - really appreciate the detail. Some specific responses below but assume a general "will do" to everything you mentioned otherwise... On 18/01/2021 09:15, Laurent Pinchart wrote: >> + PMIC) and one designed for Chrome OS. > How about expanding this a bit

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-18 Thread Daniel Scally
On 18/01/2021 10:33, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 11:49:46AM +0200, Sakari Ailus wrote: >> On Wed, Jan 13, 2021 at 12:02:09AM +0000, Daniel Scally wrote: >>> + * to_software_node() - Fetch software node associated with a firmware >>> node handle &

Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-18 Thread Daniel Scally
On 18/01/2021 15:48, andriy.shevche...@linux.intel.com wrote: > On Mon, Jan 18, 2021 at 04:32:54PM +0100, Hans de Goede wrote: >> On 1/18/21 4:23 PM, andriy.shevche...@linux.intel.com wrote: > ... > >> 1. Using a folder is fine, desirable even >> 2. I've some concerns about the name, but I'm not

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-18 Thread Daniel Scally
On 18/01/2021 12:33, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 12:34:23AM +0000, Daniel Scally wrote: >> In some ACPI tables we encounter, devices use the _DEP method to assert >> a dependence on other ACPI devices as opposed to the OpRegions that the >> specificatio

Re: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils

2021-01-18 Thread Daniel Scally
On 18/01/2021 12:29, Andy Shevchenko wrote: > On Mon, Jan 18, 2021 at 09:24:10AM +0200, Laurent Pinchart wrote: >> On Mon, Jan 18, 2021 at 12:34:22AM +0000, Daniel Scally wrote: > ... > >>> +bool acpi_lpss_dep(struct acpi_device *adev, acpi_handle handle); >&g

Re: [PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-18 Thread Daniel Scally
Morning Laurent On 18/01/2021 07:34, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Mon, Jan 18, 2021 at 12:34:23AM +, Daniel Scally wrote: >> In some ACPI tables we encounter, devices use the _DEP method to assert >> a dependence on other

Re: [PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils

2021-01-18 Thread Daniel Scally
Hi Laurent On 18/01/2021 07:24, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Mon, Jan 18, 2021 at 12:34:22AM +, Daniel Scally wrote: >> I need to be able to identify devices which declare themselves to be >> dependent on other dev

[PATCH v2 1/7] acpi: utils: move acpi_lpss_dep() to utils

2021-01-17 Thread Daniel Scally
I need to be able to identify devices which declare themselves to be dependent on other devices through _DEP; add this function to utils.c and export it to the rest of the ACPI layer. Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v2: - Introduced drivers

[PATCH v2 2/7] acpi: utils: Add function to fetch dependent acpi_devices

2021-01-17 Thread Daniel Scally
he include the handle of the dependee device in their _DEP buffer. Signed-off-by: Daniel Scally --- Changes in v2: - Used acpi_lpss_dep() as Andy suggested. drivers/acpi/utils.c| 34 ++ include/acpi/acpi_bus.h | 2 ++ 2 files changed, 36 insertion

[PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver

2021-01-17 Thread Daniel Scally
nd #2, by querying the CLDB buffer found against INT3472 entries to determine which is most appropriate. Suggested-by: Laurent Pinchart Signed-off-by: Daniel Scally --- Changes in v2: - Switched to a module registering a platform driver to run the dummy ACPI devices, plus an i2c d

[PATCH v2 4/7] i2c: i2c-core-acpi: Add i2c_acpi_dev_name()

2021-01-17 Thread Daniel Scally
We want to refer to an i2c device by name before it has been created by the kernel; add a function that constructs the name from the acpi device instead. Signed-off-by: Daniel Scally --- Changes in v2: - Stopped using devm_kasprintf() drivers/i2c/i2c-core-acpi.c | 16

[PATCH v2 3/7] i2c: i2c-core-base: Use format macro in i2c_dev_set_name()

2021-01-17 Thread Daniel Scally
an i2c device by name before it has been instantiated, so create a macro for the format that's accessible outside the i2c layer and use it in i2c_dev_set_name() Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- - Used format macro in i2c_dev_set_name() instead of sub func

[PATCH v2 5/7] gpio: gpiolib-acpi: Export acpi_get_gpiod()

2021-01-17 Thread Daniel Scally
I need to be able to translate GPIO resources in an acpi_device's _CRS into gpio_descs. Those are represented in _CRS as a pathname to a GPIO device plus the pin's index number: this function is perfect for that purpose. Signed-off-by: Daniel Scally --- Changes in v2: -None

[PATCH v2 7/7] mfd: Remove tps68470 MFD driver

2021-01-17 Thread Daniel Scally
This driver only covered one scenario in which ACPI devices with _HID INT3472 are found, and its functionality has been taken over by the intel-skl-int3472 module, so remove it. Signed-off-by: Daniel Scally --- Changes in v2: - Introduced drivers/acpi/pmic/Kconfig | 1 - drivers/gpio

[PATCH v2 0/7] Introduce intel_skl_int3472 driver

2021-01-17 Thread Daniel Scally
orks. The existing mfd/tps68470.c driver being thus superseded, it is removed. This has been tested on a number of devices; but currently **not** on a ChromeOS, which we ideally need to do to ensure no regression caused by replacing the tps68470 MFD driver. Thanks Dan Daniel Scally (7): acpi: u

Re: [PATCH v3 0/4] Remove one more platform_device_add_properties() call

2021-01-17 Thread Daniel Scally
On 17/01/2021 21:05, Andy Shevchenko wrote: > On Sat, Jan 16, 2021 at 11:29 PM Daniel Scally wrote: >> On 16/01/2021 20:23, Andy Shevchenko wrote: >>> On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus >>> wrote: >>>> Hi, >>>> >>>

Re: [PATCH v3 0/4] Remove one more platform_device_add_properties() call

2021-01-16 Thread Daniel Scally
On 16/01/2021 20:23, Andy Shevchenko wrote: > On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus > wrote: >> Hi, >> >> I'm now clearing the dev_fwnode(dev)->secondary pointer in >> device_remove_software_node() as requested by Daniel and Andy. Thanks >> guys, it's much better now. I also took the li

Re: [PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-14 Thread Daniel Scally
Hi Randy On 13/01/2021 01:01, Randy Dunlap wrote: > On 1/12/21 4:02 PM, Daniel Scally wrote: >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any >> kernel-doc comments; add those in so all exported symbols are documented. >> >> Reviewed-by: Andy

[PATCH v2] software_node: Add kernel-doc comments to exported symbols

2021-01-12 Thread Daniel Scally
A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any kernel-doc comments; add those in so all exported symbols are documented. Reviewed-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Signed-off-by: Daniel Scally --- Changes in version 2: - Replaced "fwnode_h

Re: [PATCH v2 1/3] software node: Introduce device_add_software_node()

2021-01-12 Thread Daniel Scally
; Signed-off-by: Heikki Krogerus > --- I like this change. One comment below, but for what it's worth: Reviewed-by: Daniel Scally > +/** > + * device_remove_software_node - Remove device's software node > + * @dev: The device with the software node. > + * > + * This

Re: [PATCH v5 00/15] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2021-01-12 Thread Daniel Scally
Hi Rafael, Sakari On 12/01/2021 19:34, Rafael J. Wysocki wrote: > >> I'm hopeful that most or all of this series could get picked up for 5.12. >> We touch a few different areas (listed below), but I think the easiest >> approach would be to merge everything through media tree. Rafael, Greg, >> Ma

Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device

2021-01-09 Thread Daniel Scally
On 09/01/2021 09:17, Andy Shevchenko wrote: > On Saturday, January 9, 2021, Daniel Scally wrote: > >> Hi Andy >> >> On 08/01/2021 12:17, Andy Shevchenko wrote: >>> On Fri, Jan 8, 2021 at 1:56 AM Daniel Scally >> wrote: >>>> On 30/11/2020 20:07

Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device

2021-01-08 Thread Daniel Scally
Hi Laurent On 09/01/2021 00:18, Laurent Pinchart wrote: > H Andy and Daniel, > > On Fri, Jan 08, 2021 at 02:17:49PM +0200, Andy Shevchenko wrote: >> On Fri, Jan 8, 2021 at 1:56 AM Daniel Scally wrote: >>> On 30/11/2020 20:07, Andy Shevchenko wrote: >>>> On M

Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device

2021-01-08 Thread Daniel Scally
Hi Andy On 08/01/2021 12:17, Andy Shevchenko wrote: > On Fri, Jan 8, 2021 at 1:56 AM Daniel Scally wrote: >> On 30/11/2020 20:07, Andy Shevchenko wrote: >>> On Mon, Nov 30, 2020 at 01:31:29PM +0000, Daniel Scally wrote: > ... > >>> It's solely Windows dri

Re: [PATCH 18/18] ipu3: Add driver for dummy INT3472 ACPI device

2021-01-07 Thread Daniel Scally
Hi Andy, all On 30/11/2020 20:07, Andy Shevchenko wrote: > On Mon, Nov 30, 2020 at 01:31:29PM +0000, Daniel Scally wrote: >> On platforms where ACPI is designed for use with Windows, resources >> that are intended to be consumed by sensor devices are sometimes in >> the _C

Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-07 Thread Daniel Scally
Hi Heikki On 07/01/2021 14:19, Heikki Krogerus wrote: > On Tue, Jan 05, 2021 at 03:39:42PM +0000, Daniel Scally wrote: >> Hi Andy >> >> On 05/01/2021 14:53, Andy Shevchenko wrote: >>> On Mon, Jan 04, 2021 at 11:47:36PM +, Daniel Scally wrote: >>>> A

Re: [PATCH v5 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-07 Thread Daniel Scally
On 07/01/2021 13:28, Daniel Scally wrote: > Currently on platforms designed for Windows, connections between CIO2 and > sensors are not properly defined in DSDT. This patch extends the ipu3-cio2 > driver to compensate by building software_node connections, parsing the > connectio

[PATCH v5 07/15] device property: Define format macros for ports and endpoints

2021-01-07 Thread Daniel Scally
stems, provide a set of macros to define the format. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Signed-off-by: Daniel Scally --- Changes in v5: - Changed commit subject include/linux/fwnode.h | 7 +++ 1 file changed, 7 insertions(+)

[PATCH v5 06/15] software_node: unregister software_nodes in reverse order

2021-01-07 Thread Daniel Scally
Shevchenko Signed-off-by: Daniel Scally --- Changes in v5: - None drivers/base/swnode.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 166c5cc73f39..6f7443c6d3b5 100644 --- a/drivers/base/swnode.c

[PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes

2021-01-07 Thread Daniel Scally
Use the software_node_unregister_nodes() helper function to unwind this array in a cleaner way. Acked-by: Petr Mladek Reviewed-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Sergey Senozhatsky Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5

[PATCH v5 10/15] ipu3-cio2: Add T: entry to MAINTAINERS

2021-01-07 Thread Daniel Scally
Development for the ipu3-cio2 driver is taking place in media_tree, but there's no T: entry in MAINTAINERS to denote that - rectify that oversight Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5: - None MAINTAINERS | 1

[PATCH v5 14/15] media: v4l2-fwnode: Include v4l2_fwnode_bus_type

2021-01-07 Thread Daniel Scally
Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5: - Changed commit subject drivers/media/v4l2-core/v4l2-fwnode.c | 11 --- include/media/v4l2-fwnode.h | 22 ++ 2 files changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/media/v4l2

[PATCH v5 05/15] software_node: Enforce parent before child ordering of nodes arrays

2021-01-07 Thread Daniel Scally
be unregistered before their parent. To allow easy unregistering of an array of software_nodes ordered parent to child, reverse the order in which software_node_unregister_nodes() unregisters software_nodes. Suggested-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Signed-off-by: Daniel Sca

[PATCH v5 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-07 Thread Daniel Scally
ordan Hand Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Reviewed-by: Kieran Bingham Signed-off-by: Daniel Scally --- MAINTAINERS | 1 + drivers/media/pci/intel/ipu3/Kconfig | 18 + drivers/media/pci/intel/ipu3/Makefile

[PATCH v5 01/15] software_node: Fix refcounts in software_node_get_next_child()

2021-01-07 Thread Daniel Scally
d-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Sakari Ailus Signed-off-by: Daniel Scally --- Changes in v5: - None drivers/base/swnode.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 4a

[PATCH v5 08/15] software_node: Add support for fwnode_graph*() family of functions

2021-01-07 Thread Daniel Scally
d-by: Andy Shevchenko Signed-off-by: Heikki Krogerus Co-developed-by: Daniel Scally Signed-off-by: Daniel Scally --- Changes in v5: - Cosmetic changes only drivers/base/swnode.c | 115 +- 1 file changed, 114 insertions(+), 1 deletion(-) diff --

[PATCH v5 00/15] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2021-01-07 Thread Daniel Scally
o2 driver include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type Series-level changelog: - Rebased onto 5.11-rc1 Thanks Dan Andy Shevchenko (1): media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of Daniel Scally (13): software_node: Fix refcounts in software_node_get_ne

[PATCH v5 13/15] ACPI / bus: Add acpi_dev_get_next_match_dev() and helper macro

2021-01-07 Thread Daniel Scally
acpi_dev_get_first_match_dev() to simply call the new function with a NULL starting point. Add an iterator macro for convenience. Reviewed-by: Andy Shevchenko Reviewed-by: Sakari Ailus Suggested-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5: - Changed commit subject

[PATCH v5 12/15] media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in match_fwnode()

2021-01-07 Thread Daniel Scally
Laurent Pinchart Signed-off-by: Daniel Scally --- Changes in v5: - None drivers/media/v4l2-core/v4l2-async.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c index e3ab003a6c85..9dd896d085ec 1006

[PATCH v5 11/15] ipu3-cio2: Rename ipu3-cio2.c

2021-01-07 Thread Daniel Scally
ipu3-cio2 driver needs extending with multiple files; rename the main source file and specify the renamed file in Makefile to accommodate that. Suggested-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Signed-off-by: Daniel Scally --- Changes in v5

[PATCH v5 03/15] device property: Return true in fwnode_device_is_available for NULL ops

2021-01-07 Thread Daniel Scally
the "device" is present. Suggested-by: Laurent Pinchart Reviewed-by: Laurent Pinchart Reviewed-by: Andy Shevchenko Acked-by: Sakari Ailus Signed-off-by: Daniel Scally --- Changes in v5: - Changed the commit subject drivers/base/property.c | 6 ++ 1 file changed, 6 insertions

[PATCH v5 04/15] device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary

2021-01-07 Thread Daniel Scally
ondary in the event no endpoint is found for the primary. Reviewed-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Acked-by: Sakari Ailus Signed-off-by: Daniel Scally --- Changes in v5: - Changed the commit subject drivers/base/property.c | 9 - 1 file changed, 8 insertions

[PATCH v5 02/15] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of

2021-01-07 Thread Daniel Scally
From: Andy Shevchenko Add headers that ipu3-cio2.h is direct user of. Signed-off-by: Andy Shevchenko Reviewed-by: Laurent Pinchart Reviewed-by: Daniel Scally Tested-by: Daniel Scally Signed-off-by: Daniel Scally --- Changes in v5: - Added my Signed-off-by this time, apparently I

Re: [PATCH] software_node: Add kernel-doc comments to exported symbols

2021-01-05 Thread Daniel Scally
Hi Andy On 05/01/2021 14:53, Andy Shevchenko wrote: > On Mon, Jan 04, 2021 at 11:47:36PM +0000, Daniel Scally wrote: >> A number of functions which are exported via EXPORT_SYMBOL_GPL() lack any >> kernel-doc comments; add those in so all exported symbols are documented. > Th

Re: [PATCH v4 15/15] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

2021-01-05 Thread Daniel Scally
Morning Kieran On 05/01/2021 06:55, Kieran Bingham wrote: > Hi Dan, > > On 04/01/2021 22:02, Daniel Scally wrote: >>>>>> On 04/01/2021 13:35, Kieran Bingham wrote: >>>>>>>> +/* >>>>>>>> + * Extend this array with ACPI

  1   2   3   >