[PATCH v3 1/3] Documentation: ioctl-number: add ddbridge IOCTLs

From: Daniel Scheller drivers/media/pci/ddbridge exposes a few IOCTLs which are used by userspace utilities to ie. update PCIe card's FPGA firmware. The IOCTLs chosen are in the range 0xDD/0xE0 up to 0xDD/0xFF, with 0xDD as sort of gimmick for "Digital Devices". To not conflic

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

Hi Colin, Am Tue, 8 May 2018 11:39:56 +0100 schrieb Colin Ian King : > On 08/05/18 11:38, Daniel Scheller wrote: > > Hi Colin, > > > > Am Tue, 8 May 2018 00:08:42 +0100 > > schrieb Colin King : > > > >> From: Colin Ian King > >> > >&

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

er - pointing this out. While it's unlikely this will ever be an issue, I'm fine with changing the code like that, but I'd prefer to change it a bit differently (ie. DEMOD_STOPPED should be DEMOD_UNUSED, and I'd add defines for max. tuners and use/compare against them). I'll send out a different patch that will cover the potential coverityscan problem throughout the end of the week. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH] media: mxl5xx: fix get_algo()'s return type

> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe) > { > return DVBFE_ALGO_HW; > } Acked-by: Daniel Scheller Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH] media: stv0910: fix get_algo()'s return type

frontend *fe) > +static enum dvbfe_algo get_algo(struct dvb_frontend *fe) > { > return DVBFE_ALGO_HW; > } Acked-by: Daniel Scheller Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH] media: ngene: avoid unused variable warning

on 'ngene_start': > drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev' > [-Werror=unused-variable] > > Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() > to dev_*() macros") > Signed-off-by: Arnd B

Re: [PATCH] media: dvb_frontend: dvb_unregister_frontend must not call dvb_detach for fe->ops.release

for all DVB cards in my dev system, in that attached drivers like demod and tuner drivers won't usecount to zero anymore ("rmmod ddbridge" keeps the usecount of stv0367 and cxd2841er up, and "rmmod budget_av" doesn't usecount the tda10023 back to zero). Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH][media-next] media: dvb-frontends/stv0910: make various local variables static

'padc_lookup' was not declared. Should it be static? > symbol 's1_sn_lookup' was not declared. Should it be static? > symbol 's2_sn_lookup' was not declared. Should it be static? > symbol 'stvlist' was not declared. Should it be static? > > Signed-of

Re: [PATCH] ddbridge: constify i2c_algorithm structure

the whole driver to a newer version which involves lots of code shuffling. With this, quite some GIT rebasing work needs to be done, and adding this one liner at a later time (thus rebasing it) is way easier. To be sure this will not be forgotten afterwards, I've already posted a patch applying the exact change at [1]. Thank you very much! [1] https://patchwork.linuxtv.org/patch/42393/ Best regards, Daniel Scheller -- https://github.com/herrnst