From: Darrick J. Wong
Pavel Machek complained that the question about supporting deprecated
XFS v4 comes up even when XFS is disabled. This clearly makes no sense,
so fix Kconfig.
Reported-by: Pavel Machek
Signed-off-by: Darrick J. Wong
---
fs/xfs/Kconfig |1 +
1 file changed, 1
On Mon, Oct 12, 2020 at 12:20:39PM +0200, Pavel Machek wrote:
> Hi!
>
> I don't have XFS enabled, yet I'm asked if I want to support its old
> format:
>
> +config XFS_SUPPORT_V4
> + bool "Support deprecated V4 (crc=0) format"
> + default y
>
> This needs to have dependence on
On Thu, Oct 08, 2020 at 03:38:58PM -0700, Josh Triplett wrote:
> On Thu, Oct 08, 2020 at 10:54:48AM -0700, Darrick J. Wong wrote:
> > IMO, the prominent free software filesystem projects offer (at least)
> > four layers of social structures to keep everyone on the same page,
>
On Wed, Oct 07, 2020 at 10:10:17PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Oct 07, 2020 at 01:14:24PM -0700, Josh Triplett wrote:
> >
> > That sounds like a conversation that would have been a lot more
> > interesting and enjoyable if it hadn't started with "can we shoot it in
This whole
+749,7 @@ xfs_break_dax_layouts(
> return 0;
>
> *retry = true;
> - return ___wait_var_event(>_refcount,
> - atomic_read(>_refcount) == 1, TASK_INTERRUPTIBLE,
> - 0, 0, xfs_wait_dax_page(inode));
> + ret
On Mon, Oct 05, 2020 at 05:32:16PM -0700, Josh Triplett wrote:
> On Mon, Oct 05, 2020 at 10:36:39AM -0700, Darrick J. Wong wrote:
> > On Mon, Oct 05, 2020 at 01:14:54AM -0700, Josh Triplett wrote:
> > > Ran into an ext4 regression when testing upgrades to 5.9-rc kernels:
&
On Mon, Oct 05, 2020 at 01:14:54AM -0700, Josh Triplett wrote:
> Ran into an ext4 regression when testing upgrades to 5.9-rc kernels:
>
> Commit e7bfb5c9bb3d ("ext4: handle add_system_zone() failure in
> ext4_setup_system_zone()") breaks mounting of read-only ext4 filesystems
> with intentionally
aohe Lin
LGTM,
Reviewed-by: Darrick J. Wong
--D
> ---
> mm/swapfile.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index 2b0c5fc1b0e6..4522b458a814 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
>
On Wed, Sep 23, 2020 at 03:48:59AM +0100, Matthew Wilcox wrote:
> On Tue, Sep 22, 2020 at 09:06:03PM -0400, Qian Cai wrote:
> > On Tue, 2020-09-22 at 18:05 +0100, Matthew Wilcox wrote:
> > > On Tue, Sep 22, 2020 at 12:23:45PM -0400, Qian Cai wrote:
> > > > On Fri, 2020-09-11 at 00:47 +0100,
On Thu, Sep 17, 2020 at 10:30:03PM -0700, Dan Williams wrote:
> From: Jan Kara
>
> DM was calling generic_fsdax_supported() to determine whether a device
> referenced in the DM table supports DAX. However this is a helper for "leaf"
> device drivers so that
> they don't have to duplicate common
On Thu, Sep 17, 2020 at 03:48:04PM +0100, Christoph Hellwig wrote:
> On Thu, Sep 17, 2020 at 06:42:19AM -0400, Brian Foster wrote:
> > That wouldn't address the latency concern Dave brought up. That said, I
> > have no issue with this as a targeted solution for the softlockup issue.
> >
On Thu, Sep 17, 2020 at 11:11:15PM +0100, Matthew Wilcox wrote:
> On Thu, Sep 17, 2020 at 03:05:00PM -0700, Darrick J. Wong wrote:
> > > -static loff_t
> > > -iomap_zero_range_actor(struct inode *inode, loff_t pos, loff_t count,
> > > - void *data, struct ioma
On Fri, Sep 11, 2020 at 12:47:07AM +0100, Matthew Wilcox (Oracle) wrote:
> Pass the full length to iomap_zero() and dax_iomap_zero(), and have
> them return how many bytes they actually handled. This is preparatory
> work for handling THP, although it looks like DAX could actually take
>
; ever wants to support a page size larger than 2GB.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Christoph Hellwig
LGTM
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 31 ---
> 1 file changed, 12 insertions(+), 1
On Fri, Sep 11, 2020 at 12:47:04AM +0100, Matthew Wilcox (Oracle) wrote:
> Instead of counting bio segments, count the number of bytes submitted.
> This insulates us from the block layer's definition of what a 'same page'
> is, which is not necessarily clear once THPs are involved.
>
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Christoph Hellwig
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 19 ++-
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c
4kB
> per page. Add a few debugging assertions.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Dave Chinner
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 22 +-
> 1 file changed, 17 insertions(+), 5 deletions
On Tue, Aug 25, 2020 at 10:49:17AM -0400, Brian Foster wrote:
> cc Ming
>
> On Tue, Aug 25, 2020 at 10:42:03AM +1000, Dave Chinner wrote:
> > On Mon, Aug 24, 2020 at 11:48:41AM -0400, Brian Foster wrote:
> > > On Mon, Aug 24, 2020 at 04:04:17PM +0100, Christoph Hellwig wrote:
> > > > On Mon, Aug
On Tue, Sep 15, 2020 at 06:13:08PM +0800, Shiyang Ruan wrote:
> This function is used to handle errors which may cause data lost in
> filesystem. Such as memory-failure in fsdax mode.
>
> In XFS, it requires "rmapbt" feature in order to query for files or
> metadata which associated to the error
On Tue, Sep 15, 2020 at 06:13:09PM +0800, Shiyang Ruan wrote:
> When memory-failure occurs, we call this function which is implemented
> by each devices. For fsdax, pmem device implements it. Pmem device
> will find out the block device where the error page located in, gets the
> filesystem on
On Fri, Sep 11, 2020 at 12:16:33PM +0100, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has detected an issue with the following
> commit:
>
> commit 30deae31eab501f568aadea45cfb3258b9e522f5
> Author: Darrick J. Wong
> Date: Wed Aug 26 10:48:50 2020 -07
On Fri, Sep 11, 2020 at 08:03:14AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 3e88e7243277 ("xfs: don't crash with assfail")
>
> is missing a Signed-off-by from its author and committer.
DOH, I accidentally pushed the debugging patches and other crap from the
tip to kernel.org.
On Sat, Sep 05, 2020 at 01:02:33PM -0400, Mikulas Patocka wrote:
>
>
> On Sat, 5 Sep 2020, Darrick J. Wong wrote:
>
> > On Sat, Sep 05, 2020 at 08:13:02AM -0400, Mikulas Patocka wrote:
> > > When running in a dax mode, if the user maps a page with MAP_PRIVATE an
On Wed, Sep 09, 2020 at 08:07:32PM +0800, Zheng Bin wrote:
> Fixes coccicheck warning:
>
> fs/xfs/xfs_icache.c:1214:2-3: Unneeded semicolon
>
> Signed-off-by: Zheng Bin
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/xfs_icache.c | 2 +-
> 1 file ch
.
Darrick J. Wong (1):
xfs: fix xfs_bmap_validate_extent_raw when checking attr fork of rt files
fs/xfs/libxfs/xfs_bmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Sat, Sep 05, 2020 at 08:13:02AM -0400, Mikulas Patocka wrote:
> When running in a dax mode, if the user maps a page with MAP_PRIVATE and
> PROT_WRITE, the xfs filesystem would incorrectly update ctime and mtime
> when the user hits a COW fault.
>
> This breaks building of the Linux kernel.
>
On Fri, Sep 04, 2020 at 08:51:24AM -0600, Jens Axboe wrote:
> On 9/3/20 9:55 PM, Theodore Y. Ts'o wrote:
> > Hi Jens,
> >
> > Sorry, the past few months have been *crazy* insane. Between Linux
> > Plumbers Conference organizing, having to deal with some interns at
> > $WORK, performance reviews,
-ng with --thrash option]
Seems reasonable to me (at least from the iomap and "did you run QA?"
end...)
Reviewed-by: Darrick J. Wong
--D
>
> fs/ext4/inode.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 15
iteration
xfs: fix off-by-one in inode alloc block reservation calculation
Darrick J. Wong (1):
xfs: initialize the shortform attr header padding entry
Eric Sandeen (1):
xfs: fix boundary test in xfs_attr_shortform_verify
fs/xfs/libxfs/xfs_attr_leaf.c | 8 +---
fs/xfs/libxfs
ted() to let users know their workloads are racing.
> Thank Dave Chinner for the initial analysis of the racing reproducers.
>
> Signed-off-by: Qian Cai
Looks ok to me too.
Reviewed-by: Darrick J. Wong
--D
> ---
> v4: use %pD4.
> v3: Keep the default case and update the messa
On Mon, Aug 31, 2020 at 10:48:59AM -0500, Eric Sandeen wrote:
> On 8/30/20 8:45 PM, Qian Cai wrote:
> > It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
> > unprivileged users which would taint the kernel, or worse - panic if
> > panic_on_warn or panic_on_taint is set. Hence,
On Sat, Aug 29, 2020 at 09:30:57PM -0400, Qian Cai wrote:
> It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
> unprivileged users which would taint the kernel, or worse - panic if
> panic_on_warn or panic_on_taint is set. Hence, just convert it to
> pr_warn_ratelimited() to let
On Wed, Aug 26, 2020 at 03:26:23AM +0100, Matthew Wilcox wrote:
> On Tue, Aug 25, 2020 at 02:02:03PM -0700, Darrick J. Wong wrote:
> > > /*
> > > - * Structure allocated for each page when block size < PAGE_SIZE to track
> > > + * Structure allocated for each
On Mon, Aug 24, 2020 at 03:55:10PM +0100, Matthew Wilcox (Oracle) wrote:
> Pass the full length to iomap_zero() and dax_iomap_zero(), and have
> them return how many bytes they actually handled. This is preparatory
> work for handling THP, although it looks like DAX could actually take
>
On Tue, Aug 25, 2020 at 10:09:02AM +1000, Dave Chinner wrote:
> On Mon, Aug 24, 2020 at 03:55:07PM +0100, Matthew Wilcox (Oracle) wrote:
> > Instead of counting bio segments, count the number of bytes submitted.
> > This insulates us from the block layer's definition of what a 'same page'
> > is,
On Mon, Aug 24, 2020 at 03:55:06PM +0100, Matthew Wilcox (Oracle) wrote:
> Size the uptodate array dynamically to support larger pages in the
> page cache. With a 64kB page, we're only saving 8 bytes per page today,
> but with a 2MB maximum page size, we'd have to allocate more than 4kB
> per
h Hellwig
Yay!
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 639d54a4177e..dbf9572dabe9 100644
> --- a/fs/iomap/buffered
t;
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Christoph Hellwig
/me wonders what will happen when someone tries to make blocksz >
pagesize work, but as the most likely someone already rvb'd this I guess
it's fine:
Reviewed-by: Darrick J. Wong
--D
> ---
> f
page_private() handles the refcount now.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Christoph Hellwig
Looks good to me,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> d
gt; the best place. That means we can remove it from iomap_write_actor().
>
> Signed-off-by: Matthew Wilcox (Oracle)
Seems reasonable to me...
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/iomap/buffered-io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff
On Tue, Aug 18, 2020 at 05:50:19PM +0100, Matthew Wilcox wrote:
> On Tue, Aug 18, 2020 at 09:12:29AM -0700, Darrick J. Wong wrote:
> > On Tue, Aug 18, 2020 at 04:53:05PM +0100, Matthew Wilcox wrote:
> > > It would be better to use the same wording as below:
> > >
>
On Tue, Aug 18, 2020 at 04:53:05PM +0100, Matthew Wilcox wrote:
> On Tue, Aug 18, 2020 at 09:46:18PM +0800, Yu Kuai wrote:
> > changes from v1:
> > - separate set dirty and clear dirty functions
> > - don't test uptodate bit in iomap_writepage_map()
> > - use one bitmap array for uptodate and
Hi Linus,
Please pull these two small fixes that have come in during the past
week. The branch merges cleanly with upstream as of a few minutes ago,
so please let me know if anything strange happens.
--D
The following changes since commit 818d5a91559ffe1e1f2095dcbbdb96c13fdb94ec:
fs/xfs:
On Fri, Aug 07, 2020 at 09:13:29PM +0800, Shiyang Ruan wrote:
> Under the mode of both dax and reflink on, one page may be shared by
> multiple files and offsets. In order to track them in memory-failure or
> other cases, we introduce this function by finding out who is sharing
> this block(the
: remove xfs_zone_{alloc,zalloc} helpers
xfs: Refactor xfs_da_state_alloc() helper
Christoph Hellwig (1):
xfs: remove SYNC_WAIT and SYNC_TRYLOCK
Darrick J. Wong (47):
xfs: don't eat an EIO/ENOSPC writeback error when scrubbing data fork
xfs: fix reflink quota reservation
On Fri, Aug 07, 2020 at 12:05:27AM +0900, Eiichi Tsukata wrote:
> If xfs_sysfs_init is called with parent_kobj == NULL, UBSAN
> shows the following warning:
This needs to be sent to the xfs mailing list, per get_maintainers.pl.
--D
> UBSAN: null-ptr-deref in ./fs/xfs/xfs_sysfs.h:37:23
>
Hi Linus,
Please pull these new changes to the iomap code for 5.9. The most
notable changes are:
1) iomap no longer invalidate the page cache when performing a direct
read, since doing so is unnecessary and the old directio code doesn't do
that either.
2) iomap embraced the use of returning
On Wed, Aug 05, 2020 at 02:31:50PM +0800, Coly Li wrote:
> If create a loop device with a backing NVMe SSD, current loop device
> driver doesn't correctly set its queue's limits.discard_granularity and
> leaves it as 0. If a discard request at LBA 0 on this loop device, in
>
On Wed, Aug 05, 2020 at 05:54:31PM +0200, Andreas Gruenbacher wrote:
> Hi Darrick,
>
> On Wed, Aug 5, 2020 at 5:40 PM Darrick J. Wong wrote:
> >
> > Andreas Gruenbacher (1):
> > iomap: Make sur
On Wed, Aug 05, 2020 at 09:23:49AM -0700, Darrick J. Wong wrote:
> On Wed, Aug 05, 2020 at 05:54:31PM +0200, Andreas Gruenbacher wrote:
> > Hi Darrick,
> >
> > On Wed, Aug 5, 2020 at 5:40 PM D
Hi Linus,
Please pull these new changes to the iomap code for 5.9. The most
notable changes are:
1) iomap no longer invalidate the page cache when performing a direct
read, since doing so is unnecessary and the old directio code doesn't do
that either.
2) iomap embraced the use of returning
On Fri, Jul 31, 2020 at 01:27:31PM +0200, Donald Buczek wrote:
> Dear Linux people,
>
> we have a backup server with two xfs filesystems on 101.9TB md-raid6 devices
> (16 * 7.3 T disks) each, Current Linux version is 5.4.54.
>
> The server is doing lot of metadata i/o to these filesystems (two
N. Change the name
> in the documentation accordingly.
>
> Signed-off-by: Julia Lawall
D'oh. Good catch!
Reviewed-by: Darrick J. Wong
--D
>
> ---
> Documentation/filesystems/vfs.rst |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/file
On Mon, Jul 20, 2020 at 10:52:11AM -0400, Alan Stern wrote:
> On Mon, Jul 20, 2020 at 11:33:20AM +1000, Dave Chinner wrote:
> > On Sat, Jul 18, 2020 at 10:08:11AM -0400, Alan Stern wrote:
> > > > This is one of the reasons that the LKMM documetnation is so damn
> > > > difficult to read and
On Mon, Jul 20, 2020 at 11:32:03AM -0400, Waiman Long wrote:
>
>
> - Original Message -
> From: "Darrick J. Wong"
> To: "Waiman Long"
> Cc: linux-...@vger.kernel.org, linux-kernel@vger.kernel.org, "Dave Chinner"
> , "Qian Cai&q
On Sun, Jul 19, 2020 at 05:15:09PM -0700, Randy Dunlap wrote:
> Drop the repeated words "with" and "be" in comments.
>
> Signed-off-by: Randy Dunlap
> Cc: "Darrick J. Wong"
> Cc: linux-...@vger.kernel.org
Ha.
Ha.
Reviewed-by: Darrick J.
On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote:
> On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote:
> > +If that doesn't apply, you'll have to implement one-time init yourself.
> > +
> > +The simplest implementation just uses a mutex and an 'inited' flag.
> > +This
On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote:
> On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote:
> > +If that doesn't apply, you'll have to implement one-time init yourself.
> > +
> > +The simplest implementation just uses a mutex and an 'inited' flag.
> > +This
drea Parri
> Cc: Boqun Feng
> Cc: Daniel Lustig
> Cc: Darrick J. Wong
> Cc: Dave Chinner
> Cc: David Howells
> Cc: Jade Alglave
> Cc: Luc Maranget
> Cc: Nicholas Piggin
> Cc: Paul E. McKenney
> Cc: Peter Zijlstra
> Cc: Will Deacon
> Sig
On Mon, Jul 13, 2020 at 11:03:53AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 11ba468877bb23f28956a35e896356252d63c983
> commit: 4165994ac9672d91134675caa6de3645a9ace6c8 xfs: factor common AIL item
> deletion
-C 5 sb_internal
>
> After applying the patch, such sb_internal -> fs_reclaim lock dependency
> chain can no longer be found. Because of that, the locking dependency
> warning will not be shown.
>
> Suggested-by: Dave Chinner
> Signed-off-by: Waiman Long
Looks good to
On Tue, Jul 07, 2020 at 03:05:04PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
I don't see any removals, only line
quot;)
>
> Signed-off-by: Dave Chinner
Looks ok,
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/xfs_dquot.h | 1 -
> fs/xfs/xfs_quota.h | 9 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_dquot.h b/fs/xfs/xfs_dquot.h
&
On Wed, Jul 01, 2020 at 03:49:52PM +0800, Xing Zhengjun wrote:
>
>
> On 6/10/2020 11:07 AM, Xing Zhengjun wrote:
> > Hi Darrick,
> >
> > Do you have time to take a look at this? Thanks.
> >
>
>
> Ping...
Yes, that decrease is the expected end result of making the write path
take a
On Fri, Jul 03, 2020 at 08:20:20PM -0700, Randy Dunlap wrote:
> Drop the doubled word "for".
>
> Signed-off-by: Randy Dunlap
> Cc: Jonathan Corbet
> Cc: linux-...@vger.kernel.org
> Cc: Darrick J. Wong
> Cc: linux-...@vger.kernel.org
Looks good to me,
Rev
Hi Linus,
Please pull this single UAF bug fix for -rc4.
This branch merges cleanly with master as of a few minutes ago, so
please let me know if anything strange happens.
--D
The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407:
Linux 5.8-rc1 (2020-06-14 12:45:04
On Thu, Jun 25, 2020 at 12:31:16PM +0100, Matthew Wilcox (Oracle) wrote:
> I want a memalloc_nowait like we have memalloc_noio and memalloc_nofs
> for an upcoming patch series, and Jens also wants it for non-blocking
> io_uring. It turns out we already have dm-bufio which could benefit
> from
yur Patel
Looks simple enough, though I bet this will have to be rebased against
5.8...
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libx
On Thu, Jun 18, 2020 at 11:05:57AM -0400, Waiman Long wrote:
> Depending on the workloads, the following circular locking dependency
> warning between sb_internal (a percpu rwsem) and fs_reclaim (a pseudo
> lock) may show up:
>
> ==
> WARNING:
On Thu, Jun 18, 2020 at 10:45:05AM +1000, Dave Chinner wrote:
> On Wed, Jun 17, 2020 at 01:53:10PM -0400, Waiman Long wrote:
> > fs/xfs/xfs_log.c | 9 +
> > fs/xfs/xfs_trans.c | 31 +++
> > 2 files changed, 36 insertions(+), 4 deletions(-)
> >
> > diff
On Mon, Jun 15, 2020 at 04:53:38PM -0400, Waiman Long wrote:
> On 6/15/20 12:43 PM, Darrick J. Wong wrote:
> > On Mon, Jun 15, 2020 at 12:08:30PM -0400, Waiman Long wrote:
> > > Depending on the workloads, the following circular locking dependency
> > > warning between
On Mon, Jun 15, 2020 at 12:08:30PM -0400, Waiman Long wrote:
> Depending on the workloads, the following circular locking dependency
> warning between sb_internal (a percpu rwsem) and fs_reclaim (a pseudo
> lock) may show up:
>
> ==
> WARNING:
Hi Linus,
Please pull this single iomap bug fix for 5.8-rc1 that fixes a variable
type mistake on 32-bit architectures. The branch merged cleanly with
upstream head as of a few minutes ago.
--D
The following changes since commit 0e698dfa282211e414076f9dc7e83c1c288314fd:
Linux 5.7-rc4
Hi Linus,
Please pull this last merge request before -rc1. We've settled down
into the bugfix phase; this one fixes an error bailout path.
This branch merges cleanly with master as of a few minutes ago, so
please let me know if anything strange happens.
--D
The following changes since commit
On Tue, Jun 02, 2020 at 07:40:35PM -0700, Linus Torvalds wrote:
> On Tue, Jun 2, 2020 at 9:26 AM Darrick J. Wong wrote:
> >
> > fs/xfs/xfs_log_recover.c | 2561
> > ++--
> > 102 files changed, 4244 insertions(+), 4817 dele
On Thu, Jun 11, 2020 at 11:00:43AM -0700, Linus Torvalds wrote:
> On Wed, Jun 10, 2020 at 7:43 PM Darrick J. Wong wrote:
> >
> > I did a test merge of this branch against upstream this evening and
> > there weren't any conflicts. The first five patches in the series were
&
Hi Linus,
Please pull this third part of the 5.8 DAX changes. Now that the xfs
changes have landed, this third piece changes the FS_XFLAG_DAX ioctl
code in xfs to request that the inode be reloaded after the last program
closes the file, if doing so would make a S_DAX change happen. This
goal
On Mon, Jun 08, 2020 at 10:10:21PM -0400, Sasha Levin wrote:
> On Mon, Jun 08, 2020 at 06:07:27PM -0700, Darrick J. Wong wrote:
> > On Mon, Jun 08, 2020 at 07:05:37PM -0400, Sasha Levin wrote:
> > > From: "Darrick J. Wong"
> > >
> > > [ Upstream c
On Mon, Jun 08, 2020 at 07:05:37PM -0400, Sasha Levin wrote:
> From: "Darrick J. Wong"
>
> [ Upstream commit a5949d3faedf492fa7863b914da408047ab46eb0 ]
>
> When writing to a delalloc region in the data fork, commit the new
> allocations (of the da reservation) as un
On Fri, Jun 05, 2020 at 05:48:26AM -0700, Matthew Wilcox wrote:
> On Fri, Jun 05, 2020 at 01:07:58PM +1000, Dave Chinner wrote:
> > On Thu, Jun 04, 2020 at 07:24:51PM -0700, Matthew Wilcox wrote:
> > > On Fri, Jun 05, 2020 at 10:31:59AM +1000, Dave Chinner wrote:
> > > > On Thu, Jun 04, 2020 at
On Thu, Jun 04, 2020 at 03:37:42PM +0800, Ruan Shiyang wrote:
>
>
> On 2020/4/28 下午2:43, Dave Chinner wrote:
> > On Tue, Apr 28, 2020 at 06:09:47AM +, Ruan, Shiyang wrote:
> > >
> > > 在 2020/4/27 20:28:36, "Matthew Wilcox" 写道:
> > >
> > > > On Mon, Apr 27, 2020 at 04:47:42PM +0800,
On Wed, Jun 03, 2020 at 12:10:24PM +0200, Jan Kara wrote:
> On Tue 02-06-20 10:23:53, Darrick J. Wong wrote:
> > On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote:
> > > > -out_unlock:
> > > > - xfs_iunlock(ip, XFS_MMAPLOCK_EXCL | XFS_IOLOCK_EX
_buf return an error code")
> Signed-off-by: Chuhong Yuan
Yeah, that looks like a bug, will test.
Reviewed-by: Darrick J. Wong
--D
> ---
> fs/xfs/xfs_inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.
On Wed, Jun 03, 2020 at 09:56:13AM +0800, Xiao Yang wrote:
> On 2020/6/3 2:14, Darrick J. Wong wrote:
> > On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote:
> > > On 2020/4/14 0:30, Darrick J. Wong wrote:
> > > > This might be a good time
On Tue, Jun 02, 2020 at 04:51:48PM +0800, Xiao Yang wrote:
> On 2020/4/14 0:30, Darrick J. Wong wrote:
> > This might be a good time to introduce a few new helpers:
> >
> > _require_scratch_dax ("Does $SCRATCH_DEV support DAX?")
> > _require_scratch_dax_m
Hi Linus,
Please pull this second part of the 5.8 DAX changes. This time around,
we're hoisting the DONTCACHE flag from XFS into the VFS so that we can
make the incore DAX mode changes become effective sooner.
We can't change the file data access mode on a live inode because we
don't have a
On Tue, Apr 28, 2020 at 01:11:38PM -0700, Darrick J. Wong wrote:
> On Mon, Apr 27, 2020 at 05:21:42PM -0700, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > Because of the separation of FS_XFLAG_DAX from S_DAX and the delayed
> > setting of S_DAX, data i
Hi Linus,
After many years of LKML-wrangling about how to enable programs to query
and influence the file data access mode (DAX) when a filesystem resides
on storage devices such as persistent memory, Ira Weiny has emerged with
a proposed set of standard behaviors that has not been shot down by
at fields into struct xfs_ifork
xfs: cleanup xfs_idestroy_fork
Darrick J. Wong (47):
xfs: report unrecognized log item type codes during recovery
xfs: clean up the error handling in xfs_swap_extents
xfs: convert xfs_log_recover_item_t to struct xfs_log_recover_item
xfs:
ORK_Q macro
xfs: remove xfs_ifree_local_data
xfs: move the per-fork nextents fields into struct xfs_ifork
xfs: move the fork format fields into struct xfs_ifork
xfs: cleanup xfs_idestroy_fork
Darrick J. Wong (47):
xfs: report unrecognized log item type codes during recover
ng the
mm always feels murky to me:
Acked-by: Darrick J. Wong
--D
> ---
> fs/xfs/xfs_file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 4b8bdecc3863..97f44fbf17f2 100644
> --- a/fs/xfs/xfs_fi
sp.rst
> >
> > v2:
> > - rename is_hibernate_snapshot_dev() to is_hibernate_resume_dev()
> > - fix description so to correctly refer to the resume device
> >
> > Signed-off-by: Domenico Andreoli
> > Cc: "Rafael J. Wysocki"
> > Cc
a known false positive because inodes cannot simultaneously be
getting reclaimed and the target of a getxattr operation, but lockdep
doesn't know that. We can (selectively) shut up lockdep until either
it gets smarter or we change inode reclaim not to require the ILOCK by
applying a stupid GFP_NOL
On Fri, May 22, 2020 at 10:30:27AM +1000, Dave Chinner wrote:
> On Thu, May 21, 2020 at 04:13:12PM -0700, Darrick J. Wong wrote:
> > [cc linux-xfs]
> >
> > On Fri, May 22, 2020 at 08:21:50AM +1000, Dave Airlie wrote:
> > > Hi,
> > >
> > > Just upd
[cc linux-xfs]
On Fri, May 22, 2020 at 08:21:50AM +1000, Dave Airlie wrote:
> Hi,
>
> Just updated a rawhide VM to the Fedora 5.7.0-rc5 kernel, did some
> package building,
>
> got the below trace, not sure if it's known and fixed or unknown.
It's a known false-positive. An inode can't
On Wed, May 20, 2020 at 01:02:42PM -0700, Ira Weiny wrote:
> On Wed, May 20, 2020 at 01:26:44PM -0600, Andreas Dilger wrote:
> > On May 19, 2020, at 11:57 PM, ira.we...@intel.com wrote:
> > >
> > > From: Ira Weiny
> > >
> > > Add a flag to preserve FS_XFLAG_DAX in the ext4 inode.
> > >
> > >
On Wed, May 13, 2020 at 11:53:13PM -0700, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> We add 'always', 'never', and 'inode' (default). '-o dax' continue to
> operate the same.
>
> Specifically we introduce a 2nd DAX mount flag EXT4_MOUNT2_DAX_NEVER and set
> it and EXT4_MOUNT_DAX_ALWAYS
On Wed, May 13, 2020 at 04:35:26PM +0200, Jan Kara wrote:
> On Tue 12-05-20 22:43:22, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > We add 'always', 'never', and 'inode' (default). '-o dax' continue to
> > operate the same.
> >
> > Specifically we introduce a 2nd DAX mount flag
[add fsdevel to cc]
On Tue, May 12, 2020 at 08:22:08PM -0600, Jens Axboe wrote:
> On 5/12/20 8:14 PM, Xu, Yanfei wrote:
> > Hi,
> >
> > After operating the /dev/loop which losetup with an image placed in**tmpfs,
> >
> > I got the following ERROR messages:
> >
> > [cut
Hi folks,
The vfs-for-next branch of the xfs-linux repository at:
git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git
has just been updated.
Patches often get missed, so please check if your outstanding patches
were in this update. If they have not been in this update, please
resubmit
201 - 300 of 1691 matches
Mail list logo
