Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

ed for this comma > isolating buffers with non-zero b_lru_ref. > > Additionally those isolated buffers end up right back on the LRU > once they are released, because ->b_lru_ref remains elevated. > > Fix that circuitous route by leaving them on the LRU > as orig

Re: [PATCH v6] dax: introduce IS_DEVDAX() and IS_FSDAX()

lag needs to be defined, non-zero, if either DAX facility is > enabled. > > Cc: "Theodore Ts'o" <ty...@mit.edu> > Cc: Andreas Dilger <adilger.ker...@dilger.ca> > Cc: Alexander Viro <v...@zeniv.linux.org.uk> > Cc: "Darrick J. Wong" <darrick.w...@ora

Re: [PATCH v6] dax: introduce IS_DEVDAX() and IS_FSDAX()

lag needs to be defined, non-zero, if either DAX facility is > enabled. > > Cc: "Theodore Ts'o" > Cc: Andreas Dilger > Cc: Alexander Viro > Cc: "Darrick J. Wong" > Cc: linux-...@vger.kernel.org > Cc: Matthew Wilcox > Cc: Ross Zwisler > Cc: > Fixes:

Re: [PATCH v5 08/12] xfs, dax: replace IS_DAX() with IS_FSDAX()

On Thu, Mar 01, 2018 at 07:54:16PM -0800, Dan Williams wrote: > In preparation for fixing the broken definition of S_DAX in the > CONFIG_FS_DAX=n + CONFIG_DEV_DAX=y case, convert all IS_DAX() usages to > use explicit tests for FSDAX since DAX is ambiguous. > > Cc: "Darrick

Re: [PATCH v5 08/12] xfs, dax: replace IS_DAX() with IS_FSDAX()

On Thu, Mar 01, 2018 at 07:54:16PM -0800, Dan Williams wrote: > In preparation for fixing the broken definition of S_DAX in the > CONFIG_FS_DAX=n + CONFIG_DEV_DAX=y case, convert all IS_DAX() usages to > use explicit tests for FSDAX since DAX is ambiguous. > > Cc: "Darrick J

Re: [PATCH v5 02/12] dax: introduce IS_DEVDAX() and IS_FSDAX()

lag needs to be defined, non-zero, if either DAX facility is > enabled. > > Cc: "Theodore Ts'o" <ty...@mit.edu> > Cc: Andreas Dilger <adilger.ker...@dilger.ca> > Cc: Alexander Viro <v...@zeniv.linux.org.uk> > Cc: "Darrick J. Wong" <darrick.w...@ora

Re: [PATCH v5 02/12] dax: introduce IS_DEVDAX() and IS_FSDAX()

lag needs to be defined, non-zero, if either DAX facility is > enabled. > > Cc: "Theodore Ts'o" > Cc: Andreas Dilger > Cc: Alexander Viro > Cc: "Darrick J. Wong" > Cc: linux-...@vger.kernel.org > Cc: Matthew Wilcox > Cc: Ross Zwisler > Cc: > Fixes:

Re: [PATCH] xfs: Change URL for the project in xfs.txt

/xfs.wiki.kernel.org/ > for further details. This implementation is on-disk compatible > with the IRIX version of XFS. Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > > -- > 2.16.2.345.g7e31236f652a > > -- > To unsubscribe from this lis

Re: [PATCH] xfs: Change URL for the project in xfs.txt

for further details. This implementation is on-disk compatible > with the IRIX version of XFS. Looks ok, Reviewed-by: Darrick J. Wong --D > > -- > 2.16.2.345.g7e31236f652a > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > th

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

On Thu, Mar 01, 2018 at 02:48:00PM -0800, Darrick J. Wong wrote: > On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > > to determine whether a buffer should be isolated and disposed > &g

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

On Thu, Mar 01, 2018 at 02:48:00PM -0800, Darrick J. Wong wrote: > On Wed, Feb 28, 2018 at 04:49:51PM +0100, Vratislav Bendel wrote: > > The function xfs_buftarg_isolate() used by xfs buffer schrinkers > > to determine whether a buffer should be isolated and disposed > &g

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

fs_buffer with ->b_lru_ref == 0, to take another > trip around LRU, while isolating buffers with non-zero b_lru_ref. > > Signed-off-by: Vratislav Bendel <vben...@redhat.com> > CC: Brian Foster <bfos...@redhat.com> Looks ok, will test... Reviewed-by: Darrick J.

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

fs_buffer with ->b_lru_ref == 0, to take another > trip around LRU, while isolating buffers with non-zero b_lru_ref. > > Signed-off-by: Vratislav Bendel > CC: Brian Foster Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_buf.c | 2 +- > 1

[GIT PULL] xfs: fixes for 4.16-rc4

in mount option parsing Darrick J. Wong (1): xfs: reserve blocks for refcount / rmap log item recovery Eric Sandeen (1): xfs: use memset to initialize xfs_scrub_agfl_info fs/xfs/scrub/agheader.c| 3 ++- fs/xfs/xfs_refcount_item.c | 9 ++--- fs/xfs/xfs_rmap_item.c | 4

[GIT PULL] xfs: fixes for 4.16-rc4

in mount option parsing Darrick J. Wong (1): xfs: reserve blocks for refcount / rmap log item recovery Eric Sandeen (1): xfs: use memset to initialize xfs_scrub_agfl_info fs/xfs/scrub/agheader.c| 3 ++- fs/xfs/xfs_refcount_item.c | 9 ++--- fs/xfs/xfs_rmap_item.c | 4

[GIT PULL] xfs: updates for 4.16

reflink and never have. - Remove EXPERIMENTAL tag from reverse mapping btree! Darrick J. Wong (4): xfs: fix u32 type usage in sb validation function xfs: don't allow DAX on reflink filesystems xfs: don't allow reflink

[GIT PULL] xfs: updates for 4.16

reflink and never have. - Remove EXPERIMENTAL tag from reverse mapping btree! Darrick J. Wong (4): xfs: fix u32 type usage in sb validation function xfs: don't allow DAX on reflink filesystems xfs: don't allow reflink

Re: [PATCH] jbd2: set to NULL after kmem_cache_destroy

On Mon, Feb 05, 2018 at 09:39:17PM +0800, Wang Long wrote: > Signed-off-by: Wang Long > --- > fs/jbd2/journal.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 93016bb..38dc24c 100644 > ---

Re: [PATCH] jbd2: set to NULL after kmem_cache_destroy

On Mon, Feb 05, 2018 at 09:39:17PM +0800, Wang Long wrote: > Signed-off-by: Wang Long > --- > fs/jbd2/journal.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 93016bb..38dc24c 100644 > --- a/fs/jbd2/journal.c > +++

Re: [PATCH] xfs: Add missing braces around xfs_scrub_agfl_info initializer

On Thu, Feb 01, 2018 at 12:31:36PM +0100, Arnd Bergmann wrote: > On Thu, Feb 1, 2018 at 11:23 AM, Geert Uytterhoeven > wrote: > > With gcc-4.1.2: > > > > fs/xfs/scrub/agheader.c: In function ‘xfs_scrub_agfl’: > > fs/xfs/scrub/agheader.c:770: warning: missing braces

Re: [PATCH] xfs: Add missing braces around xfs_scrub_agfl_info initializer

On Thu, Feb 01, 2018 at 12:31:36PM +0100, Arnd Bergmann wrote: > On Thu, Feb 1, 2018 at 11:23 AM, Geert Uytterhoeven > wrote: > > With gcc-4.1.2: > > > > fs/xfs/scrub/agheader.c: In function ‘xfs_scrub_agfl’: > > fs/xfs/scrub/agheader.c:770: warning: missing braces around initializer > >

[GIT PULL] xfs: great scads of new stuff for 4.16

Hellwig (1): xfs: remove experimental tag for reflinks Colin Ian King (1): xfs: fix check on struct_version for versions 4 or greater Darrick J. Wong (73): xfs: scrub inode nsec fields iomap: report collisions between directio and buffered writes to userspace xfs: ignore

[GIT PULL] xfs: great scads of new stuff for 4.16

Hellwig (1): xfs: remove experimental tag for reflinks Colin Ian King (1): xfs: fix check on struct_version for versions 4 or greater Darrick J. Wong (73): xfs: scrub inode nsec fields iomap: report collisions between directio and buffered writes to userspace xfs: ignore

Re: [PATCH][xfs-next] xfs: fix check on struct_version for versions 4 or greater

ically dead code") > > Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > --- > fs/xfs/libxfs/xfs_sb.c | 2 +- &g

Re: [PATCH][xfs-next] xfs: fix check on struct_version for versions 4 or greater

ixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function") > Signed-off-by: Colin Ian King Looks ok, Reviewed-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_sb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_sb

Re: [PATCH] xfs: destroy mutex pag_ici_reclaim_lock before free xfs_perag_t structure

e > perag. > > Signed-off-by: Xiongwei Song <sxwj...@me.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > --- > fs/xfs/xfs_mount.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index

Re: [PATCH] xfs: destroy mutex pag_ici_reclaim_lock before free xfs_perag_t structure

e > perag. > > Signed-off-by: Xiongwei Song Looks ok, Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_mount.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index c879b517cc94..98fd41cbb9e1 100644 > --- a/fs/xfs

[GIT PULL] xfs: fixes for 4.15-rc7

destroy of qi_tree_lock xfs: quota: check result of register_shrinker() Darrick J. Wong (1): xfs: fix s_maxbytes overflow problems fs/xfs/xfs_aops.c | 4 ++-- fs/xfs/xfs_iomap.c | 2 +- fs/xfs/xfs_qm.c| 46 ++ 3 files changed, 33

[GIT PULL] xfs: fixes for 4.15-rc7

destroy of qi_tree_lock xfs: quota: check result of register_shrinker() Darrick J. Wong (1): xfs: fix s_maxbytes overflow problems fs/xfs/xfs_aops.c | 4 ++-- fs/xfs/xfs_iomap.c | 2 +- fs/xfs/xfs_qm.c| 46 ++ 3 files changed, 33

Re: [PATCHv6 1/1] ima: re-introduce own integrity cache lock

[might as well cc linux-xfs] On Thu, Dec 14, 2017 at 12:22:37AM +0200, Dmitry Kasatkin wrote: > Hi, > > Could I ask FS maintainers to test IMA with this patch additionally > and provide ack/tested. > We tested but may be you have and some special testing. Super-late to this party, but unless

Re: [PATCHv6 1/1] ima: re-introduce own integrity cache lock

[might as well cc linux-xfs] On Thu, Dec 14, 2017 at 12:22:37AM +0200, Dmitry Kasatkin wrote: > Hi, > > Could I ask FS maintainers to test IMA with this patch additionally > and provide ack/tested. > We tested but may be you have and some special testing. Super-late to this party, but unless

Re: [PATCH v5 01/78] xfs: Rename xa_ elements to ail_

On Fri, Dec 15, 2017 at 02:03:33PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox <mawil...@microsoft.com> > > This is a simple rename, except that xa_ail becomes ail_head. > > Signed-off-by: Matthew Wilcox <mawil...@microsoft.com> That was an eyeful, R

Re: [PATCH v5 01/78] xfs: Rename xa_ elements to ail_

On Fri, Dec 15, 2017 at 02:03:33PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > This is a simple rename, except that xa_ail becomes ail_head. > > Signed-off-by: Matthew Wilcox That was an eyeful, Reviewed-by: Darrick J. Wong > --- > fs/xfs/xfs_buf_item.c

Re: [PATCH] xfs: destroy mutex qi_tree_lock before free xfs_quotainfo_t object

On Sun, Dec 24, 2017 at 08:34:47PM +0800, Xiongwei Song wrote: > The mutex qi_tree_lock of xfs_quotainfo_t object was initialized when > calling xfs_qm_init_quotainfo, but it was not destroyed before free > xfs_quotainfo_t object when calling xfs_qm_destroy_quotainfo, this was > incorrect, so

Re: [PATCH] xfs: destroy mutex qi_tree_lock before free xfs_quotainfo_t object

On Sun, Dec 24, 2017 at 08:34:47PM +0800, Xiongwei Song wrote: > The mutex qi_tree_lock of xfs_quotainfo_t object was initialized when > calling xfs_qm_init_quotainfo, but it was not destroyed before free > xfs_quotainfo_t object when calling xfs_qm_destroy_quotainfo, this was > incorrect, so

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

analysis of this, but I can live with this as a tag-file-with-license convention, so... Acked-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > Documentation/index.rst | 12 + > Documentation/process/license-rules.rst | 370 > +

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

-by: Philippe Ombredanne > Reviewed-by: Kate Stewart > Reviewed-by: Greg Kroah-Hartman > /me hasn't done any deep dive legal analysis of this, but I can live with this as a tag-file-with-license convention, so... Acked-by: Darrick J. Wong --D > --- > Documentation/index.rst

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

On Tue, Dec 26, 2017 at 07:58:15PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 07:43:40PM -0800, Matthew Wilcox wrote: > > Also add the xa_lock() and xa_unlock() family of wrappers to make it > > easier to use the lock. If we could rely on -fplan9-extensions in > > the

Re: [PATCH v5 03/78] xarray: Add the xa_lock to the radix_tree_root

On Tue, Dec 26, 2017 at 07:58:15PM -0800, Matthew Wilcox wrote: > On Tue, Dec 26, 2017 at 07:43:40PM -0800, Matthew Wilcox wrote: > > Also add the xa_lock() and xa_unlock() family of wrappers to make it > > easier to use the lock. If we could rely on -fplan9-extensions in > > the

Re: [PATCH v4 14/19] xfs: convert to new i_version API

as I already let that horse escape I might as well clean it up separately. Looks ok, Acked-by: Darrick J. Wong <darrick.w...@oracle.com> --D > + > /* > * Check that none of the inode's in the buffer have a next > * unlinked field of 0. > @@ -264,7 +266,8 @

Re: [PATCH v4 14/19] xfs: convert to new i_version API

++ b/fs/xfs/libxfs/xfs_inode_buf.c > @@ -32,6 +32,8 @@ > #include "xfs_ialloc.h" > #include "xfs_dir2.h" > > +#include /me wonders if these ought to be in fs/xfs/xfs_linux.h since this is libxfs, but seeing as I already let that horse escape I

Re: [PATCH v4 17/19] xfs: avoid setting XFS_ILOG_CORE if i_version doesn't need incrementing

On Fri, Dec 22, 2017 at 07:05:54AM -0500, Jeff Layton wrote: > From: Jeff Layton <jlay...@redhat.com> > > If XFS_ILOG_CORE is already set then go ahead and increment it. > > Signed-off-by: Jeff Layton <jlay...@redhat.com> Looks ok, Acked-by: Darrick J. Wo

Re: [PATCH v4 17/19] xfs: avoid setting XFS_ILOG_CORE if i_version doesn't need incrementing

On Fri, Dec 22, 2017 at 07:05:54AM -0500, Jeff Layton wrote: > From: Jeff Layton > > If XFS_ILOG_CORE is already set then go ahead and increment it. > > Signed-off-by: Jeff Layton Looks ok, Acked-by: Darrick J. Wong > --- > fs/xfs/xfs_trans_inode.c | 14 --

[GIT PULL] xfs: fixes for 4.15-rc5

the extent is reallocated, leading to multiple rmaps for the same extent ------------ Darrick J. Wong (15): xfs: add the ability to join a held buffer to a defer_ops xfs: hold xfs_buf locked between shortform->leaf conversion and

[GIT PULL] xfs: fixes for 4.15-rc5

the extent is reallocated, leading to multiple rmaps for the same extent ------------ Darrick J. Wong (15): xfs: add the ability to join a held buffer to a defer_ops xfs: hold xfs_buf locked between shortform->leaf conversion and

Re: linux-next: manual merge of the xfs tree with Linus' tree

On Fri, Dec 22, 2017 at 09:50:41AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the xfs tree got a conflict in: > > fs/xfs/xfs_super.c > > between commit: > > 1751e8a6cb93 ("Rename superblock flags (MS_xyz -> SB_xyz)") > > from Linus' tree and commit: > >

Re: linux-next: manual merge of the xfs tree with Linus' tree

On Fri, Dec 22, 2017 at 09:50:41AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the xfs tree got a conflict in: > > fs/xfs/xfs_super.c > > between commit: > > 1751e8a6cb93 ("Rename superblock flags (MS_xyz -> SB_xyz)") > > from Linus' tree and commit: > >

Re: [trivial PATCH] treewide: Align function definition open/close braces

*bp) > - { > +{ > struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(>m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) > return false; > >

Re: [trivial PATCH] treewide: Align function definition open/close braces

t; struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(>m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) > return false; > > - return true

[GIT PULL] xfs: fixes for 4.15-rc4

ents Christoph Hellwig (1): xfs: remove "no-allocation" reservations for file creations Darrick J. Wong (1): xfs: make iomap_begin functions trim iomaps consistently Pravin Shedge (1): fs: xfs: remove duplicate includes fs/xfs/libxfs/xfs

[GIT PULL] xfs: fixes for 4.15-rc4

ents Christoph Hellwig (1): xfs: remove "no-allocation" reservations for file creations Darrick J. Wong (1): xfs: make iomap_begin functions trim iomaps consistently Pravin Shedge (1): fs: xfs: remove duplicate includes fs/xfs/libxfs/xfs

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Wed, Dec 13, 2017 at 01:03:57PM -0500, Josef Bacik wrote: > On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote: > > On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > > > This is the same as v8, just rebased onto the bpf tree. > > > > &g

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Wed, Dec 13, 2017 at 01:03:57PM -0500, Josef Bacik wrote: > On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote: > > On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > > > This is the same as v8, just rebased onto the bpf tree. > > > > &g

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > This is the same as v8, just rebased onto the bpf tree. > > v8->v9: > - rebased onto the bpf tree. > > v7->v8: > - removed the _ASM_KPROBE_ERROR_INJECT since it was not needed. > > v6->v7: > - moved the opt-in macro to bpf.h out of

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > This is the same as v8, just rebased onto the bpf tree. > > v8->v9: > - rebased onto the bpf tree. > > v7->v8: > - removed the _ASM_KPROBE_ERROR_INJECT since it was not needed. > > v6->v7: > - moved the opt-in macro to bpf.h out of

Re: [patch V4 02/11] LICENSES: Add the GPL 2.0 license

261+O-Nm+9HDoEn9RbFjH=5j9i1c2ggmug2g...@mail.gmail.com > > Add the required tags for reference and tooling. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > > --- > LICENSES/preferred/GPL-2.0 |

Re: [patch V4 02/11] LICENSES: Add the GPL 2.0 license

-Nm+9HDoEn9RbFjH=5j9i1c2ggmug2g...@mail.gmail.com > > Add the required tags for reference and tooling. > > Signed-off-by: Thomas Gleixner Looks ok, Reviewed-by: Darrick J. Wong > > --- > LICENSES/preferred/GPL-2.0 | 353 > +

Re: [PATCH 22/45] fs: xfs: remove duplicate includes

ooks ok, will pick this up. Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > --- > fs/xfs/scrub/scrub.c | 1 - > fs/xfs/scrub/trace.c | 1 - > fs/xfs/xfs_reflink.c | 2 -- > fs/xfs/xfs_trace.c | 1 - > 4 files changed, 5 deletions(-) > > diff --git a/fs/

Re: [PATCH 22/45] fs: xfs: remove duplicate includes

On Wed, Dec 06, 2017 at 09:46:06PM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge Looks ok, will pick this up. Reviewed-b

Re: [PATCH] treewide: remove duplicate includes

On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl

Re: [PATCH] treewide: remove duplicate includes

On Mon, Dec 04, 2017 at 03:19:39AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Unit Testing: > > - build successful > - LTP testsuite passes. > - checkpatch.pl

[GIT PULL] xfs: fixes for 4.15-rc2

Carlos Maiolino (1): xfs: Properly retry failed dquot items in case of error during buffer writeback Darrick J. Wong (5): xfs: always free inline data before resetting inode fork during ifree xfs: log recovery should replay deferred ops in order xfs: ubsan fixes

[GIT PULL] xfs: fixes for 4.15-rc2

Carlos Maiolino (1): xfs: Properly retry failed dquot items in case of error during buffer writeback Darrick J. Wong (5): xfs: always free inline data before resetting inode fork during ifree xfs: log recovery should replay deferred ops in order xfs: ubsan fixes

Re: [PATCH v2] xfs: handle register_shrinker error

On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: > On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: > [...] > > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko <mho...@suse.com> > > > Date: Thu, 2

Re: [PATCH v2] xfs: handle register_shrinker error

On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: > On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: > [...] > > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Thu, 23 Nov 2017 17:13:40

Re: [PATCH v2] xfs: handle register_shrinker error

xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -1815,22 +1815,27 @@ xfs_alloc_buftarg( > btp->bt_daxdev = dax_dev; > > if (xfs_setsize_buftarg_early(btp, bdev)) > - goto error; > + goto error_free; > > if (list_lru_init(>bt_lru)

Re: [PATCH v2] xfs: handle register_shrinker error

_buftarg_early(btp, bdev)) > - goto error; > + goto error_free; > > if (list_lru_init(>bt_lru)) > - goto error; > + goto error_free; > > if (percpu_counter_init(>bt_io_count, 0, GFP_KERNEL)) > -

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Sat, Nov 25, 2017 at 08:12:23PM +0100, Pavel Machek wrote: > Hi! > > > > This would be even better: > > > > > > /* > > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > > * > > > * Copyright (c) 2012-2013 Dongjin Kim (tobet...@gmail.com) > > > */ > > > ... > > >

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Sat, Nov 25, 2017 at 08:12:23PM +0100, Pavel Machek wrote: > Hi! > > > > This would be even better: > > > > > > /* > > > * Driver for SMSC USB3503 USB 2.0 hub controller driver > > > * > > > * Copyright (c) 2012-2013 Dongjin Kim (tobet...@gmail.com) > > > */ > > > ... > > >

[GIT PULL] xfs: more fixes for 4.15

Hi Linus, Here are a couple more patches to fix a memory leak and some refactoring to make it easier to keep xfsprogs' libxfs in sync with the kernel. --D The following changes since commit 2015a63dce8d73a439232a0d5162c88d8513101e: xfs: fix type usage (2017-11-16 12:06:45 -0800) are

[GIT PULL] xfs: more fixes for 4.15

Hi Linus, Here are a couple more patches to fix a memory leak and some refactoring to make it easier to keep xfsprogs' libxfs in sync with the kernel. --D The following changes since commit 2015a63dce8d73a439232a0d5162c88d8513101e: xfs: fix type usage (2017-11-16 12:06:45 -0800) are

[GIT PULL] xfs: fixes for 4.15

) Changes since last update: - Fix a forgotten rcu read unlock - Fix some inconsistent integer type usage. Darrick J. Wong (2): xfs: fix forgotten rcu read unlock when skipping inode reclaim xfs: fix

[GIT PULL] xfs: fixes for 4.15

) Changes since last update: - Fix a forgotten rcu read unlock - Fix some inconsistent integer type usage. Darrick J. Wong (2): xfs: fix forgotten rcu read unlock when skipping inode reclaim xfs: fix

[GIT PULL] xfs: great scads of new stuff for 4.15

for xfs_iext_remove_node xfs: add comments documenting the rebalance algorithm xfs: handle zero entries case in xfs_iext_rebalance_leaf Colin Ian King (1): xfs: remove redundant assignment to variable bit Darrick J. Wong (46): xfs: return a distinct error code value for IGET_INCORE cache

[GIT PULL] xfs: great scads of new stuff for 4.15

for xfs_iext_remove_node xfs: add comments documenting the rebalance algorithm xfs: handle zero entries case in xfs_iext_rebalance_leaf Colin Ian King (1): xfs: remove redundant assignment to variable bit Darrick J. Wong (46): xfs: return a distinct error code value for IGET_INCORE cache

Re: [btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

[cc xfs list] [We're discussing the WARN_ON in *dio_complete when invalidation fails] [yes, again] On Mon, Nov 13, 2017 at 11:21:50AM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 11:16 AM, Jens Axboe wrote: > > > > I would tend to agree with you, it's annoying to

Re: [btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

[cc xfs list] [We're discussing the WARN_ON in *dio_complete when invalidation fails] [yes, again] On Mon, Nov 13, 2017 at 11:21:50AM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 11:16 AM, Jens Axboe wrote: > > > > I would tend to agree with you, it's annoying to dump a full stack

Re: linux-next: build failure after merge of the kspp tree

On Wed, Nov 08, 2017 at 03:43:47PM -0800, Kees Cook wrote: > On Tue, Nov 7, 2017 at 9:23 PM, Stephen Rothwell > wrote: > > Hi Kees, > > > > After merging the kspp tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > In file included from

Re: linux-next: build failure after merge of the kspp tree

On Wed, Nov 08, 2017 at 03:43:47PM -0800, Kees Cook wrote: > On Tue, Nov 7, 2017 at 9:23 PM, Stephen Rothwell > wrote: > > Hi Kees, > > > > After merging the kspp tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: > > > > In file included from

Re: [PATCH] fs/xfs: Remove NULL check before kmem_cache_destroy

On Wed, Nov 08, 2017 at 01:53:10PM -0500, Tim Hansen wrote: > kmem_cache_destroy already checks for null values. > > Signed-off-by: Tim Hansen <devtimhan...@gmail.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > --- > fs/xfs/kmem.h | 3 +-- >

Re: [PATCH] fs/xfs: Remove NULL check before kmem_cache_destroy

On Wed, Nov 08, 2017 at 01:53:10PM -0500, Tim Hansen wrote: > kmem_cache_destroy already checks for null values. > > Signed-off-by: Tim Hansen Looks ok, Reviewed-by: Darrick J. Wong > --- > fs/xfs/kmem.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Tue, Nov 07, 2017 at 09:26:48PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2017 at 11:28:46AM -0800, Christoph Hellwig wrote: > > On Tue, Nov 07, 2017 at 02:15:26PM -0500, Theodore Ts'o wrote: > > > On Tue, Nov 07, 2017 at 06:46:58PM +, Alan Cox wrote: > > > > > Given that it had no

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Tue, Nov 07, 2017 at 09:26:48PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2017 at 11:28:46AM -0800, Christoph Hellwig wrote: > > On Tue, Nov 07, 2017 at 02:15:26PM -0500, Theodore Ts'o wrote: > > > On Tue, Nov 07, 2017 at 06:46:58PM +, Alan Cox wrote: > > > > > Given that it had no

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Tue, Nov 07, 2017 at 08:39:40AM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 11:20:40PM -0800, Christoph Hellwig wrote: > > NAK, for both the libxfs patch and the kernel one. > > What libxfs patch? And what "kernel one" are you referring to here? > > > I wrote the file and it

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

On Tue, Nov 07, 2017 at 08:39:40AM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 11:20:40PM -0800, Christoph Hellwig wrote: > > NAK, for both the libxfs patch and the kernel one. > > What libxfs patch? And what "kernel one" are you referring to here? > > > I wrote the file and it

[PATCH v2] xfs: scrub: avoid uninitialized return code

From: Darrick J. Wong <darrick.w...@oracle.com> The newly added xfs_scrub_da_btree_block() function has one code path that returns the 'error' variable without initializing it first, as shown by this compiler warning: fs/xfs/scrub/dabtree.c: In function 'xfs_scrub_da_btree_block': fs/xfs

[PATCH v2] xfs: scrub: avoid uninitialized return code

From: Darrick J. Wong The newly added xfs_scrub_da_btree_block() function has one code path that returns the 'error' variable without initializing it first, as shown by this compiler warning: fs/xfs/scrub/dabtree.c: In function 'xfs_scrub_da_btree_block': fs/xfs/scrub/dabtree.c:462:9: error

Re: [PATCH 2/2] xfs: fix unused variable warnings

On Thu, Nov 02, 2017 at 08:44:03AM -0400, Brian Foster wrote: > On Thu, Nov 02, 2017 at 12:11:13PM +0100, Arnd Bergmann wrote: > > fs/xfs/libxfs/xfs_bmap.c: In function 'xfs_bmap_del_extent_delay': > > fs/xfs/libxfs/xfs_bmap.c:4648:20: error: unused variable 'ifp' > > [-Werror=unused-variable] >

Re: [PATCH 2/2] xfs: fix unused variable warnings

On Thu, Nov 02, 2017 at 08:44:03AM -0400, Brian Foster wrote: > On Thu, Nov 02, 2017 at 12:11:13PM +0100, Arnd Bergmann wrote: > > fs/xfs/libxfs/xfs_bmap.c: In function 'xfs_bmap_del_extent_delay': > > fs/xfs/libxfs/xfs_bmap.c:4648:20: error: unused variable 'ifp' > > [-Werror=unused-variable] >

Re: [PATCH 1/2] xfs: scrub: avoid uninitialized return code

On Thu, Nov 02, 2017 at 08:44:00AM -0400, Brian Foster wrote: > On Thu, Nov 02, 2017 at 12:11:12PM +0100, Arnd Bergmann wrote: > > The newly added xfs_scrub_da_btree_block() function has one code path > > that returns the 'error' variable without initializing it first, as > > shown by this

Re: [PATCH 1/2] xfs: scrub: avoid uninitialized return code

On Thu, Nov 02, 2017 at 08:44:00AM -0400, Brian Foster wrote: > On Thu, Nov 02, 2017 at 12:11:12PM +0100, Arnd Bergmann wrote: > > The newly added xfs_scrub_da_btree_block() function has one code path > > that returns the 'error' variable without initializing it first, as > > shown by this

Re: [RFC] xfs: fix reporting supported extra file attributes for statx()

On Tue, Oct 31, 2017 at 03:38:32PM -0700, Luis R. Rodriguez wrote: > On Tue, Oct 31, 2017 at 3:27 PM, Darrick J. Wong > <darrick.w...@oracle.com> wrote: > > On Tue, Oct 31, 2017 at 03:13:05PM -0700, Luis R. Rodriguez wrote: > >> statx(2) notes that any attribute that is

Re: [RFC] xfs: fix reporting supported extra file attributes for statx()

On Tue, Oct 31, 2017 at 03:38:32PM -0700, Luis R. Rodriguez wrote: > On Tue, Oct 31, 2017 at 3:27 PM, Darrick J. Wong > wrote: > > On Tue, Oct 31, 2017 at 03:13:05PM -0700, Luis R. Rodriguez wrote: > >> statx(2) notes that any attribute that is not i

Re: [RFC] xfs: fix reporting supported extra file attributes for statx()

On Tue, Oct 31, 2017 at 03:13:05PM -0700, Luis R. Rodriguez wrote: > statx(2) notes that any attribute that is not indicated as supported by > stx_attributes_mask has no usable value. Commit 5f955f26f3d42d ("xfs: report > crtime and attribute flags to statx") added support for informing userspace

Re: [RFC] xfs: fix reporting supported extra file attributes for statx()

On Tue, Oct 31, 2017 at 03:13:05PM -0700, Luis R. Rodriguez wrote: > statx(2) notes that any attribute that is not indicated as supported by > stx_attributes_mask has no usable value. Commit 5f955f26f3d42d ("xfs: report > crtime and attribute flags to statx") added support for informing userspace

Re: [PATCH] xfs: remove redundant assignment to variable bit

libxfs/xfs_rtbitmap.c:675:3: warning: Value stored to > 'bit' is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> > --- > fs/xfs/libxfs/xfs_rtbitmap.c | 1 - > 1 file changed, 1 d

Re: [PATCH] xfs: remove redundant assignment to variable bit

warning: Value stored to > 'bit' is never read > > Signed-off-by: Colin Ian King Looks ok, Reviewed-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_rtbitmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitma

[GIT PULL] xfs: fixes for 4.14-rc7

Hi Linus, Here's (hopefully) the last bugfix for 4.14. --D The following changes since commit 785545c8982604fe3ba79d16409e83993be77d5e: xfs: move two more RT specific functions into CONFIG_XFS_RT (2017-10-16 12:26:50 -0700) are available in the git repository at:

[GIT PULL] xfs: fixes for 4.14-rc7

Hi Linus, Here's (hopefully) the last bugfix for 4.14. --D The following changes since commit 785545c8982604fe3ba79d16409e83993be77d5e: xfs: move two more RT specific functions into CONFIG_XFS_RT (2017-10-16 12:26:50 -0700) are available in the git repository at:

[GIT PULL] xfs: fixes for 4.14-rc6

Hi Linus, Here's a fourth round of fixes for bugs and other build problems. --D The following changes since commit 33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9: Linux 4.14-rc5 (2017-10-15 21:01:12 -0400) are available in the git repository at:

<    3   4   5   6   7   8   9   10   11   12   >