Re: [PATCH] IB/usnic: delete unneeded IS_ERR test

2015-12-22 Thread Dave Goodell
expression x,e; > @@ > > * x = kzalloc(...) > ... when != x = e > * IS_ERR_OR_NULL(x) > // > > Signed-off-by: Julia Lawall Reviewed-by: Dave Goodell -Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH] usnix: correctly handle kzalloc return value

2015-10-19 Thread Dave Goodell
changed, 4 insertions(+), 4 deletions(-) The subject says "usnix" where it should say "usnic". Otherwise: Reviewed-by: Dave Goodell If you have more of these fixes for drivers/infiniband/hw/usnic/, you can send them all through just Doug Ledford and linux-rdma@, no need to copy

Re: [PATCH] usnic: correctly check failed allocation

2015-10-15 Thread Dave Goodell
On Thu, Oct 15, 2015 at 09:15:15PM +, Insu Yun wrote: > Since ib_alloc_device returns allocated memory address, not error, > it should be checked as IS_NULL, not IS_ERR_OR_NULL. > > Signed-off-by: Insu Yun Reviewed-by: Dave Goodell -- To unsubscribe from this list: s

Re: [PATCH] usnic: corretly check failed allocation

2015-10-15 Thread Dave Goodell
On Thu, Oct 15, 2015 at 01:41:06PM -0400, Insu Yun wrote: > On Thu, Oct 15, 2015 at 1:17 PM, Dave Goodell (dgoodell) > wrote: > > > On Oct 15, 2015, at 11:27 AM, Insu Yun wrote: > > > > > > us_ibdev->ufdev = usnic_fwd_dev_alloc(dev); > >

Re: [PATCH] usnic: corretly check failed allocation

2015-10-15 Thread Dave Goodell (dgoodell)
On Oct 15, 2015, at 11:27 AM, Insu Yun wrote: > > Since ib_alloc_device returns allocated memory address, not error, > it should be checked as IS_NULL, not IS_ERR_OR_NULL. > > Signed-off-by: Insu Yun > --- > drivers/infiniband/hw/usnic/usnic_ib_main.c | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Dave Goodell (dgoodell)
On Apr 28, 2015, at 2:53 PM, Hefty, Sean wrote: >> Is the concern here about CM issues or the UDP ports used by the actual >> usNIC RQs? > > UDP port space sharing For the UDP port used by the usNIC QP, the usnic_verbs kernel driver requires user space to pass a file descriptor of a regular U

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Dave Goodell (dgoodell)
On Apr 28, 2015, at 1:14 AM, Hefty, Sean wrote: >>> Keep in mind that this enum was Liran's response to Michael's original >>> patch. In the enum in Michael's patch, there was both USNIC and >>> USNIC_UDP. >> >> Right! That's why I'm confused. Seems wrong to drop it, right? > > I think the ori

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-22 Thread Dave Goodell (dgoodell)
On Apr 21, 2015, at 6:36 PM, Liran Liss wrote: > An ib_dev (or a port of) should be distinguished by 3 qualifiers: > - The link layer: > -- Ethernet (shared by iWARP, USNIC, and ROCE) > -- Infiniband > > - The transport (*) > -- IBTA transport (shared by IB and ROCE) > -- iWARP transport > -- US