Re: [PATCH] efi: Fix the size not consistent issue when unmapping memory map

On 04/16/18 at 10:57am, Dave Young wrote: > On 04/13/18 at 02:27pm, Lee, Chun-Yi wrote: > > When using kdump, SOMETIMES the "size not consistent" warning message > > shows up when the crash kernel boots with early_ioremap_debug parameter: > > > > WARNING: C

Re: [PATCH] efi: Fix the size not consistent issue when unmapping memory map

On 04/16/18 at 10:57am, Dave Young wrote: > On 04/13/18 at 02:27pm, Lee, Chun-Yi wrote: > > When using kdump, SOMETIMES the "size not consistent" warning message > > shows up when the crash kernel boots with early_ioremap_debug parameter: > > > > WARNING: C

Re: [PATCH] efi: Fix the size not consistent issue when unmapping memory map

On 04/13/18 at 02:27pm, Lee, Chun-Yi wrote: > When using kdump, SOMETIMES the "size not consistent" warning message > shows up when the crash kernel boots with early_ioremap_debug parameter: > > WARNING: CPU: 0 PID: 0 at ../mm/early_ioremap.c:182 early_iounmap+0x4f/0x12c() >

Re: [PATCH] efi: Fix the size not consistent issue when unmapping memory map

On 04/13/18 at 02:27pm, Lee, Chun-Yi wrote: > When using kdump, SOMETIMES the "size not consistent" warning message > shows up when the crash kernel boots with early_ioremap_debug parameter: > > WARNING: CPU: 0 PID: 0 at ../mm/early_ioremap.c:182 early_iounmap+0x4f/0x12c() >

Re: [PATCH v2 00/11] kexec_file: Clean up purgatory load

On 03/23/18 at 10:41am, Philipp Rudo wrote: > Hi Andrew, > Hi Dave, > > i checked out linux-next with the patches and it looks good to me. Also made a > quick test and everything works fine. Thank you! Not sure if it is late about an ack :) Anyway, for the series: Acked-by:

Re: [PATCH v2 00/11] kexec_file: Clean up purgatory load

On 03/23/18 at 10:41am, Philipp Rudo wrote: > Hi Andrew, > Hi Dave, > > i checked out linux-next with the patches and it looks good to me. Also made a > quick test and everything works fine. Thank you! Not sure if it is late about an ack :) Anyway, for the series: Acked-by: Dave

Re: [PATCH] powerpc: kexec_file: Fix error code when trying to load kdump kernel

he patch: > > # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz > kexec_file_load failed: Operation not supported > > Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()") > Reported-by: Dave Young <dyo...@redhat.com> > Sign

Re: [PATCH] powerpc: kexec_file: Fix error code when trying to load kdump kernel

he patch: > > # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz > kexec_file_load failed: Operation not supported > > Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()") > Reported-by: Dave Young > Signed-off-by: Thiago Ju

Re: [PATCH v2 00/11] kexec_file: Clean up purgatory load

On 03/21/18 at 12:27pm, Philipp Rudo wrote: > Hi everybody > > here is the updated patch set including Dave's comments. > > Changes v1 -> v2: > * Fix missing memcpy and memset definition in x86 purgatory > introduced by moving the sha256 implementation to common code. > *

Re: [PATCH v2 00/11] kexec_file: Clean up purgatory load

On 03/21/18 at 12:27pm, Philipp Rudo wrote: > Hi everybody > > here is the updated patch set including Dave's comments. > > Changes v1 -> v2: > * Fix missing memcpy and memset definition in x86 purgatory > introduced by moving the sha256 implementation to common code. > *

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 03/20/18 at 10:39am, Philipp Rudo wrote: > Hi Dave, > > sorry for the late answer. > > > On Fri, 16 Mar 2018 14:41:02 +0800 > Dave Young <dyo...@redhat.com> wrote: > > > On 03/15/18 at 11:13am, Philipp Rudo wrote: > > > Hi Dave, &g

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 03/20/18 at 10:39am, Philipp Rudo wrote: > Hi Dave, > > sorry for the late answer. > > > On Fri, 16 Mar 2018 14:41:02 +0800 > Dave Young wrote: > > > On 03/15/18 at 11:13am, Philipp Rudo wrote: > > > Hi Dave, > > > > >

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/15/18 at 11:13am, Philipp Rudo wrote: > Hi Dave, > > On Thu, 15 Mar 2018 15:34:22 +0800 > Dave Young <dyo...@redhat.com> wrote: > > > On 03/12/18 at 03:40pm, Dave Young wrote: > > > Hi Philipp, > > > On 03/09/18 at 03:25pm, Philipp Rudo wrote:

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/15/18 at 11:13am, Philipp Rudo wrote: > Hi Dave, > > On Thu, 15 Mar 2018 15:34:22 +0800 > Dave Young wrote: > > > On 03/12/18 at 03:40pm, Dave Young wrote: > > > Hi Philipp, > > > On 03/09/18 at 03:25pm, Philipp Rudo wrote: > > > > Hi

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/12/18 at 03:40pm, Dave Young wrote: > Hi Philipp, > On 03/09/18 at 03:25pm, Philipp Rudo wrote: > > Hi Dave, > > > > On Fri, 9 Mar 2018 13:19:40 +0800 > > Dave Young <dyo...@redhat.com> wrote: > > > > > Hi Philipp, > > > On

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/12/18 at 03:40pm, Dave Young wrote: > Hi Philipp, > On 03/09/18 at 03:25pm, Philipp Rudo wrote: > > Hi Dave, > > > > On Fri, 9 Mar 2018 13:19:40 +0800 > > Dave Young wrote: > > > > > Hi Philipp, > > > On 02/26/18 at 04:1

Re: [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field

Hi Philipp, On 03/09/18 at 11:02am, Philipp Rudo wrote: > Hi Dave, > > > On Fri, 9 Mar 2018 11:14:20 +0800 > Dave Young <dyo...@redhat.com> wrote: > > > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > The current code uses the sh_offset field in

Re: [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field

Hi Philipp, On 03/09/18 at 11:02am, Philipp Rudo wrote: > Hi Dave, > > > On Fri, 9 Mar 2018 11:14:20 +0800 > Dave Young wrote: > > > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > The current code uses the sh_offset field in purgatory_info->sechdrs to

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 03/09/18 at 03:25pm, Philipp Rudo wrote: > Hi Dave, > > On Fri, 9 Mar 2018 13:19:40 +0800 > Dave Young <dyo...@redhat.com> wrote: > > > Hi Philipp, > > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > > > > Hi everybody > &g

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 03/09/18 at 03:25pm, Philipp Rudo wrote: > Hi Dave, > > On Fri, 9 Mar 2018 13:19:40 +0800 > Dave Young wrote: > > > Hi Philipp, > > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > > > > Hi everybody > > > >

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 06:33pm, AKASHI Takahiro wrote: [snip] > Oops, please apply the fix below to my first patch ("kexec_file: make > an use of purgatory optional"). My screw-up is trivial here :) Wow, human eyes sometimes can not catch such issue, thanks for the fix. It works for me. > > Please

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 06:33pm, AKASHI Takahiro wrote: [snip] > Oops, please apply the fix below to my first patch ("kexec_file: make > an use of purgatory optional"). My screw-up is trivial here :) Wow, human eyes sometimes can not catch such issue, thanks for the fix. It works for me. > > Please

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 03:46pm, Dave Young wrote: > Hi AKASHI, > > On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > > Dave, > > > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > > On 03/0

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 03:46pm, Dave Young wrote: > Hi AKASHI, > > On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > > Dave, > > > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > > On 03/0

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

Hi AKASHI, On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > Dave, > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > On 03/08/18 at 09:05am, Dave Young wrote: > > > > [Cc Andrew] > > &

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

Hi AKASHI, On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > Dave, > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > On 03/08/18 at 09:05am, Dave Young wrote: > > > > [Cc Andrew] > > &

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 02:02pm, Dave Young wrote: > On 03/08/18 at 09:05am, Dave Young wrote: > > [Cc Andrew] > > > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > > > I

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/09/18 at 02:02pm, Dave Young wrote: > On 03/08/18 at 09:05am, Dave Young wrote: > > [Cc Andrew] > > > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > > > I

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/08/18 at 09:05am, Dave Young wrote: > [Cc Andrew] > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > It was originally included in a arm64 patch set[1], but Philipp is also >

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

On 03/08/18 at 09:05am, Dave Young wrote: > [Cc Andrew] > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > It was originally included in a arm64 patch set[1], but Philipp is also >

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/09/18 at 01:19pm, Dave Young wrote: > Hi Philipp, > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > > Hi everybody > > > > following the discussion with Dave and AKASHI, here are the common code > > patches extracted from my recent patch set (Add kex

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

On 03/09/18 at 01:19pm, Dave Young wrote: > Hi Philipp, > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > > Hi everybody > > > > following the discussion with Dave and AKASHI, here are the common code > > patches extracted from my recent patch set (Add kex

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > Hi everybody > > following the discussion with Dave and AKASHI, here are the common code > patches extracted from my recent patch set (Add kexec_file_load support to > s390) [1]. The patches were extracted to allow upstream integration

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

Hi Philipp, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > Hi everybody > > following the discussion with Dave and AKASHI, here are the common code > patches extracted from my recent patch set (Add kexec_file_load support to > s390) [1]. The patches were extracted to allow upstream integration

Re: [PATCH 11/11] kexec_file: Move purgatories sha256 to common code

On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The code to verify the new kernels sha digest are applicable for all > architectures. Move it to common code. > > Signed-off-by: Philipp Rudo > --- > arch/x86/purgatory/Makefile| 3 +++ >

Re: [PATCH 11/11] kexec_file: Move purgatories sha256 to common code

On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The code to verify the new kernels sha digest are applicable for all > architectures. Move it to common code. > > Signed-off-by: Philipp Rudo > --- > arch/x86/purgatory/Makefile| 3 +++ > arch/x86/purgatory/purgatory.c

Re: [PATCH 08/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 2

Hi, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The main loop currently uses quite a lot of variables to update the section > headers. Some of them are unnecessary. So clean them up a little. > It looks better to use some patch subject eg below: "Remove unnecessary variables in

Re: [PATCH 08/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 2

Hi, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The main loop currently uses quite a lot of variables to update the section > headers. Some of them are unnecessary. So clean them up a little. > It looks better to use some patch subject eg below: "Remove unnecessary variables in

Re: [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field

On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The current code uses the sh_offset field in purgatory_info->sechdrs to > store a pointer to the current load address of the section. Depending > whether the section will be loaded or not this is either a pointer into > purgatory_info->purgatory_buf or

Re: [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field

On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The current code uses the sh_offset field in purgatory_info->sechdrs to > store a pointer to the current load address of the section. Depending > whether the section will be loaded or not this is either a pointer into > purgatory_info->purgatory_buf or

Re: [PATCH v2 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

ay. So let's factor them out. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Baoquan He <b...@redhat.com> > Cc: Michael Ellerman <m...@ellerman.id.au&

Re: [PATCH v2 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

ay. So let's factor them out. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > Cc: Michael Ellerman > Cc: Thiago Jung Bauermann > --- > arch/powerpc/include/asm/kexec.h| 2 +- > arch/powerpc/kernel/kexec_elf_64

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

| 334 > ++-- > arch/x86/kernel/kexec-bzimage64.c | 2 +- > arch/x86/kernel/machine_kexec_64.c | 45 +--- > include/linux/kexec.h | 32 ++- > kernel/kexec_file.c | 240

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

| 334 > ++-- > arch/x86/kernel/kexec-bzimage64.c | 2 +- > arch/x86/kernel/machine_kexec_64.c | 45 +--- > include/linux/kexec.h | 32 ++- > kernel/kexec_file.c | 240 +++- > 11 files changed, 338 insertions(+), 366 deletions(-) > > -- > 2.16.2 > AKASHI, thanks for another update, looks good to me: Acked-by: Dave Young Thanks Dave

Re: linux-next: build failure after merge of the printk tree

On 03/03/18 at 11:47pm, Sergey Senozhatsky wrote: > Cc-ing Tejun > > On (03/02/18 16:54), Petr Mladek wrote: > [..] > > > (Though it is not immediately obvious why.) > > > > It is a mistery to me. The error appears when I move any of > > dump_stack_print_info() or show_regs_print_info() function

Re: linux-next: build failure after merge of the printk tree

On 03/03/18 at 11:47pm, Sergey Senozhatsky wrote: > Cc-ing Tejun > > On (03/02/18 16:54), Petr Mladek wrote: > [..] > > > (Though it is not immediately obvious why.) > > > > It is a mistery to me. The error appears when I move any of > > dump_stack_print_info() or show_regs_print_info() function

Re: [PATCH 0/7] kexec_file: refactoring for other architecutres

On 03/02/18 at 01:56pm, Dave Young wrote: > Hi AKASHI, > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > subject: > > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > It was originally included in a arm64 patch set

Re: [PATCH 0/7] kexec_file: refactoring for other architecutres

On 03/02/18 at 01:56pm, Dave Young wrote: > Hi AKASHI, > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > subject: > > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > It was originally included in a arm64 patch set

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 04:16pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 02:08:57PM +0800, Dave Young wrote: > > On 03/02/18 at 01:53pm, Dave Young wrote: > > > On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > > > > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Youn

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 04:16pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 02:08:57PM +0800, Dave Young wrote: > > On 03/02/18 at 01:53pm, Dave Young wrote: > > > On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > > > > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Youn

Re: [PATCH 1/7] kexec_file: make an use of purgatory optional

On 03/02/18 at 01:58pm, Dave Young wrote: > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > On arm64, crash dump kernel's usable memory is protected by > > *unmapping* it from kernel virtual space unlike other architectures > > where the region is just made read-only.

Re: [PATCH 1/7] kexec_file: make an use of purgatory optional

On 03/02/18 at 01:58pm, Dave Young wrote: > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > On arm64, crash dump kernel's usable memory is protected by > > *unmapping* it from kernel virtual space unlike other architectures > > where the region is just made read-only.

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 01:53pm, Dave Young wrote: > On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Young wrote: > > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > > As arch_

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 01:53pm, Dave Young wrote: > On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Young wrote: > > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > > As arch_

Re: [PATCH 6/7] x86: kexec_file: clean up prepare_elf64_headers()

On 03/02/18 at 02:58pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 01:39:45PM +0800, Dave Young wrote: > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > removing bufp variable in prepare_elf64_headers() makes the code simpler > > > and more understandab

Re: [PATCH 6/7] x86: kexec_file: clean up prepare_elf64_headers()

On 03/02/18 at 02:58pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 01:39:45PM +0800, Dave Young wrote: > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > removing bufp variable in prepare_elf64_headers() makes the code simpler > > > and more understandab

Re: [PATCH 1/7] kexec_file: make an use of purgatory optional

't make sense to have trampline code between old kernel > and new kernel on arm64. > > This patch introduces a new configuration, ARCH_HAS_KEXEC_PURGATORY, and > allows related code to be compiled in only if necessary. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@li

Re: [PATCH 1/7] kexec_file: make an use of purgatory optional

't make sense to have trampline code between old kernel > and new kernel on arm64. > > This patch introduces a new configuration, ARCH_HAS_KEXEC_PURGATORY, and > allows related code to be compiled in only if necessary. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young &

Re: [PATCH 0/7] kexec_file: refactoring for other architecutres

Hi AKASHI, On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > subject: > > This is a preparatory patch set for adding kexec_file support on arm64. > > It was originally included in a arm64 patch set[1], but Philipp is also > working on their kexec_file support on s390[2] and some changes are now

Re: [PATCH 0/7] kexec_file: refactoring for other architecutres

Hi AKASHI, On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > subject: > > This is a preparatory patch set for adding kexec_file support on arm64. > > It was originally included in a arm64 patch set[1], but Philipp is also > working on their kexec_file support on s390[2] and some changes are now

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Young wrote: > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > As arch_kexec_kernel_image_{probe,load}(), > > > arch_kimage_file_post_load_cleanup() and a

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 03/02/18 at 02:24pm, AKASHI Takahiro wrote: > On Fri, Mar 02, 2018 at 01:04:26PM +0800, Dave Young wrote: > > On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > > > As arch_kexec_kernel_image_{probe,load}(), > > > arch_kimage_file_post_load_cleanup() and a

Re: [PATCH 6/7] x86: kexec_file: clean up prepare_elf64_headers()

On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > removing bufp variable in prepare_elf64_headers() makes the code simpler > and more understandable. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek

Re: [PATCH 6/7] x86: kexec_file: clean up prepare_elf64_headers()

On 02/27/18 at 01:48pm, AKASHI Takahiro wrote: > removing bufp variable in prepare_elf64_headers() makes the code simpler > and more understandable. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > a

Re: [PATCH 5/7] x86: kexec_file: lift CRASH_MAX_RANGES limit on crash_mem buffer

nge also allows removing > crash_elf_data structure. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Baoquan He <

Re: [PATCH 5/7] x86: kexec_file: lift CRASH_MAX_RANGES limit on crash_mem buffer

nge also allows removing > crash_elf_data structure. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > arch/x86/kernel/crash.c | 80 > ++--- > 1 file changed, 29 insertions(+

Re: [PATCH 4/7] x86: kexec_file: remove X86_64 dependency from prepare_elf64_headers()

added to enable/ > disable the code removing #ifdef. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Baoquan He <b...@redhat.com> > --- > arch/x86/kern

Re: [PATCH 4/7] x86: kexec_file: remove X86_64 dependency from prepare_elf64_headers()

added to enable/ > disable the code removing #ifdef. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > arch/x86/kernel/crash.c | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff -

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

ay. So let's factor them out. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Baoquan He <b...@redhat.com> > Cc: Michael Ellerman <m...@ellerman.id.au&

Re: [PATCH 2/7] kexec_file,x86,powerpc: factor out kexec_file_ops functions

ay. So let's factor them out. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > Cc: Michael Ellerman > Cc: Thiago Jung Bauermann > --- > arch/powerpc/include/asm/kexec.h| 2 +- > arch/powerpc/kernel/kexec_elf_64

Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

ton <a...@linux-foundation.org> > CC: Baoquan He <b...@redhat.com> > CC: Dave Young <dyo...@redhat.com> > CC: Dave Young <dyo...@redhat.com> Above duplicated a CC, btw, I remember both Baoquan and me acked it before, you can find the old email an

Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()

ew Morton > CC: Baoquan He > CC: Dave Young > CC: Dave Young Above duplicated a CC, btw, I remember both Baoquan and me acked it before, you can find the old email and carry the acked-by. > CC: Hari Bathini > CC: Tony Luck > CC: Vivek Goyal > Signed-off-by: Marc-And

Re: [PATCH v8 03/13] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 02/26/18 at 07:01pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 05:24:59PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > As arch_kexec_kernel_*_{probe,load}(), > >

Re: [PATCH v8 03/13] kexec_file,x86,powerpc: factor out kexec_file_ops functions

On 02/26/18 at 07:01pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 05:24:59PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > As arch_kexec_kernel_*_{probe,load}(), > >

Re: [PATCH v8 02/13] kexec_file: make an use of purgatory optional

On 02/26/18 at 07:24pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 04:49:34PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > On arm64, no trampline code between old kernel and new kernel will b

Re: [PATCH v8 02/13] kexec_file: make an use of purgatory optional

On 02/26/18 at 07:24pm, AKASHI Takahiro wrote: > On Fri, Feb 23, 2018 at 04:49:34PM +0800, Dave Young wrote: > > Hi AKASHI, > > > > On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > > > On arm64, no trampline code between old kernel and new kernel will b

Re: [PATCH v8 00/13] arm64: kexec: add kexec_file_load() support

Hi AKASHI, On 02/27/18 at 01:56pm, AKASHI Takahiro wrote: > Now my patch#2 to #5 were extracted from this patch set and put > into another separate one. Please see > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-February/562195.htmlk Thanks! Will read them > > Thanks, > -Takahiro

Re: [PATCH v8 00/13] arm64: kexec: add kexec_file_load() support

Hi AKASHI, On 02/27/18 at 01:56pm, AKASHI Takahiro wrote: > Now my patch#2 to #5 were extracted from this patch set and put > into another separate one. Please see > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-February/562195.htmlk Thanks! Will read them > > Thanks, > -Takahiro

Re: [PATCH 2/2] efi/esrt: mark ESRT memory region as nomap

On 02/23/18 at 12:42pm, Tyler Baicar wrote: > The ESRT memory region is being exposed as System RAM in /proc/iomem > which is wrong because it cannot be overwritten. This memory is needed > for kexec kernels in order to properly initialize ESRT, so if it is > overwritten it will cause ESRT

Re: [PATCH 2/2] efi/esrt: mark ESRT memory region as nomap

On 02/23/18 at 12:42pm, Tyler Baicar wrote: > The ESRT memory region is being exposed as System RAM in /proc/iomem > which is wrong because it cannot be overwritten. This memory is needed > for kexec kernels in order to properly initialize ESRT, so if it is > overwritten it will cause ESRT

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

he Code Aurora Forum, > a Linux Foundation Collaborative Project. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH 1/2] efi/esrt: fix unsupported version initialization failure

Linux Foundation Collaborative Project. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-efi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Dave Young Thanks Dave

Re: [PATCH v8 04/13] x86: kexec_file: factor out elf core header related functions

a dynamically allocated buffer. The remain parts could be splitted as well, so that they can be easier to review. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Bao

Re: [PATCH v8 04/13] x86: kexec_file: factor out elf core header related functions

a dynamically allocated buffer. The remain parts could be splitted as well, so that they can be easier to review. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > arch/x86/kernel/crash.c | 235 >

Re: [PATCH 00/17] Add kexec_file_load support to s390

On 02/23/18 at 11:01am, Philipp Rudo wrote: > Hi Dave > > On Fri, 23 Feb 2018 16:34:05 +0800 > Dave Young <dyo...@redhat.com> wrote: > > > On 02/14/18 at 10:54am, Philipp Rudo wrote: > > > Hi Dave, > > > > > > I just browsed AKASHI's patches

Re: [PATCH 00/17] Add kexec_file_load support to s390

On 02/23/18 at 11:01am, Philipp Rudo wrote: > Hi Dave > > On Fri, 23 Feb 2018 16:34:05 +0800 > Dave Young wrote: > > > On 02/14/18 at 10:54am, Philipp Rudo wrote: > > > Hi Dave, > > > > > > I just browsed AKASHI's patches (v7).

Re: [PATCH v8 03/13] kexec_file,x86,powerpc: factor out kexec_file_ops functions

them out. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > Cc: Baoquan He <b...@redhat.com> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: Thiago Jung Bauermann

Re: [PATCH v8 03/13] kexec_file,x86,powerpc: factor out kexec_file_ops functions

them out. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > Cc: Michael Ellerman > Cc: Thiago Jung Bauermann > --- > arch/powerpc/include/asm/kexec.h| 2 +- > arch/powerpc/kernel/kexec_elf_64.c | 2 +- > a

Re: [PATCH v8 02/13] kexec_file: make an use of purgatory optional

iled in only if necessary. Here also need the explanation about why no purgatory is needed, it would be required for kexec if no strong reason. > > Signed-off-by: AKASHI Takahiro <takahiro.aka...@linaro.org> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat

Re: [PATCH v8 02/13] kexec_file: make an use of purgatory optional

iled in only if necessary. Here also need the explanation about why no purgatory is needed, it would be required for kexec if no strong reason. > > Signed-off-by: AKASHI Takahiro > Cc: Dave Young > Cc: Vivek Goyal > Cc: Baoquan He > --- > arch/powerpc/Kconfig | 3 +++ > ar

Re: [PATCH v8 01/13] resource: add walk_system_ram_res_rev()

Hi AKASHI, On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > This function, being a variant of walk_system_ram_res() introduced in > commit 8c86e70acead ("resource: provide new functions to walk through > resources"), walks through a list of all the resources of System RAM > in reversed order,

Re: [PATCH v8 01/13] resource: add walk_system_ram_res_rev()

Hi AKASHI, On 02/22/18 at 08:17pm, AKASHI Takahiro wrote: > This function, being a variant of walk_system_ram_res() introduced in > commit 8c86e70acead ("resource: provide new functions to walk through > resources"), walks through a list of all the resources of System RAM > in reversed order,

Re: [PATCH 00/17] Add kexec_file_load support to s390

HI: Welcome to the list. While browsing I couldn't find any > arch_apply_relocation function for arm64. These require the biggest changes in > my patch set. Did I just miss it or does arm64 work differently? > > @Dave: Happy holiday Thank you! > > Thanks > Philipp >

Re: [PATCH 00/17] Add kexec_file_load support to s390

HI: Welcome to the list. While browsing I couldn't find any > arch_apply_relocation function for arm64. These require the biggest changes in > my patch set. Did I just miss it or does arm64 work differently? > > @Dave: Happy holiday Thank you! > > Thanks > Philipp > &g

Re: [PATCH 00/17] Add kexec_file_load support to s390

Hi Philipp, I added AKASHI in cc, he posted arm64 kexec_file series previously. I would like to read both series especially the general part, but maybe at the end of this month because of a holiday.. >From the patch log the cleanup looks nice, but still need read the details. On 02/12/18 at

Re: [PATCH 00/17] Add kexec_file_load support to s390

Hi Philipp, I added AKASHI in cc, he posted arm64 kexec_file series previously. I would like to read both series especially the general part, but maybe at the end of this month because of a holiday.. >From the patch log the cleanup looks nice, but still need read the details. On 02/12/18 at

Re: [PATCH] printk: move dump stack related code to lib/dump_stack.c

On 02/09/18 at 06:15pm, Sergey Senozhatsky wrote: > On (02/09/18 17:00), Dave Young wrote: > [..] > > > > > > I'm hesitating to add #ifdef CONFIG_PRINTK in lib/dump_stack.c. > > Agreed. > > > Maybe conditionally build dump_stack.o only when

Re: [PATCH] printk: move dump stack related code to lib/dump_stack.c

On 02/09/18 at 06:15pm, Sergey Senozhatsky wrote: > On (02/09/18 17:00), Dave Young wrote: > [..] > > > > > > I'm hesitating to add #ifdef CONFIG_PRINTK in lib/dump_stack.c. > > Agreed. > > > Maybe conditionally build dump_stack.o only when

[PATCH v2] printk: move dump stack related code to lib/dump_stack.c

dump_stack related stuff should belong to lib/dump_stack.c thus move them there. Also conditionally compile lib/dump_stack.c since dump_stack code does not make sense if printk is disabled. Signed-off-by: Dave Young <dyo...@redhat.com> Suggested-by: Steven Rostedt <rost...@goodmis.org&g

[PATCH v2] printk: move dump stack related code to lib/dump_stack.c

dump_stack related stuff should belong to lib/dump_stack.c thus move them there. Also conditionally compile lib/dump_stack.c since dump_stack code does not make sense if printk is disabled. Signed-off-by: Dave Young Suggested-by: Steven Rostedt Suggested-by: Sergey Senozhatsky --- Note: dump

<    1   2   3   4   5   6   7   8   9   10   >