Re: [PATCH] kexec: Account crashk_low_res to kexec_crash_size

2016-08-15 Thread Dave Young
Hi Xunlei, On 08/13/16 at 04:26pm, Xunlei Pang wrote: > "/sys/kernel/kexec_crash_size" only includes crashk_res, it > is fine in most cases, but sometimes we have crashk_low_res. > For example, when "crashkernel=size[KMG],high" combined with > "crashkernel=size[KMG],low" is used for 64-bit x86. >

Re: [PATCH] kexec: Account crashk_low_res to kexec_crash_size

2016-08-15 Thread Dave Young
Hi Xunlei, On 08/13/16 at 04:26pm, Xunlei Pang wrote: > "/sys/kernel/kexec_crash_size" only includes crashk_res, it > is fine in most cases, but sometimes we have crashk_low_res. > For example, when "crashkernel=size[KMG],high" combined with > "crashkernel=size[KMG],low" is used for 64-bit x86. >

Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-11 Thread Dave Young
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote: > Daniel Walker reported problems which happens when > crash_kexec_post_notifiers kernel option is enabled > (https://lkml.org/lkml/2015/6/24/44). > > In that case, smp_send_stop() is called before entering kdump routines > which assume other CPUs are

Re: [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-11 Thread Dave Young
On 08/10/16 at 05:09pm, Hidehiro Kawai wrote: > Daniel Walker reported problems which happens when > crash_kexec_post_notifiers kernel option is enabled > (https://lkml.org/lkml/2015/6/24/44). > > In that case, smp_send_stop() is called before entering kdump routines > which assume other CPUs are

Re: [V4 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-11 Thread Dave Young
lker <dwal...@fifo99.com> > Fixes: f06e5153f4ae (kernel/panic.c: add "crash_kexec_post_notifiers" option) > Signed-off-by: Hidehiro Kawai <hidehiro.kawai...@hitachi.com> > Cc: Dave Young <dyo...@redhat.com> > Cc: Baoquan He <b...@redhat.com> > Cc: Vi

Re: [V4 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-11 Thread Dave Young
er > Fixes: f06e5153f4ae (kernel/panic.c: add "crash_kexec_post_notifiers" option) > Signed-off-by: Hidehiro Kawai > Cc: Dave Young > Cc: Baoquan He > Cc: Vivek Goyal > Cc: Eric Biederman > Cc: Masami Hiramatsu > Cc: Daniel Walker > Cc: Xunlei Pang > C

Re: [PATCH v5 2/2] Documentation: kdump: add description of enable multi-cpus support

2016-08-10 Thread Dave Young
On 08/10/16 at 02:22pm, Zhou Wenjian wrote: > multi-cpu support is useful to improve the performance of kdump in > some cases. So add the description of enable multi-cpu support in > dump-capture kernel. > > Signed-off-by: Zhou Wenjian > Acked-by: Baoquan He

Re: [PATCH v5 2/2] Documentation: kdump: add description of enable multi-cpus support

2016-08-10 Thread Dave Young
On 08/10/16 at 02:22pm, Zhou Wenjian wrote: > multi-cpu support is useful to improve the performance of kdump in > some cases. So add the description of enable multi-cpu support in > dump-capture kernel. > > Signed-off-by: Zhou Wenjian > Acked-by: Baoquan He > --- >

Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-07 Thread Dave Young
On 08/03/16 at 08:59am, Zhou Wenjian wrote: > v2->v3: add description of nr_cpus. > v1->v2: change nr_cpus to maxcpus > > nr_cpus can help to save memory. So we should remind user of it. > > Signed-off-by: Zhou Wenjian > --- > Documentation/kdump/kdump.txt | 2 ++ >

Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-07 Thread Dave Young
On 08/03/16 at 08:59am, Zhou Wenjian wrote: > v2->v3: add description of nr_cpus. > v1->v2: change nr_cpus to maxcpus > > nr_cpus can help to save memory. So we should remind user of it. > > Signed-off-by: Zhou Wenjian > --- > Documentation/kdump/kdump.txt | 2 ++ > 1 file changed, 2

Re: [RESEND][PATCH v2 1/2] kexec: refactor code parsing size based on memory range

2016-08-04 Thread Dave Young
Hi Hari, On 08/04/16 at 01:03am, Hari Bathini wrote: > crashkernel parameter supports different syntaxes to specify the amount > of memory to be reserved for kdump kernel. Below is one of the supported > syntaxes that needs parsing to find the memory size to reserve, based on > memory range: > >

Re: [RESEND][PATCH v2 1/2] kexec: refactor code parsing size based on memory range

2016-08-04 Thread Dave Young
Hi Hari, On 08/04/16 at 01:03am, Hari Bathini wrote: > crashkernel parameter supports different syntaxes to specify the amount > of memory to be reserved for kdump kernel. Below is one of the supported > syntaxes that needs parsing to find the memory size to reserve, based on > memory range: > >

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-19 Thread Dave Young
On 07/19/16 at 08:49am, Borislav Petkov wrote: > On Tue, Jul 19, 2016 at 08:35:07AM +0800, Dave Young wrote: > > Ok, for example below (A and B can be any program, systemd or other logging > > utility, dracut scripts...) > > Are you even reading what I'm writing to you? >

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-19 Thread Dave Young
On 07/19/16 at 08:49am, Borislav Petkov wrote: > On Tue, Jul 19, 2016 at 08:35:07AM +0800, Dave Young wrote: > > Ok, for example below (A and B can be any program, systemd or other logging > > utility, dracut scripts...) > > Are you even reading what I'm writing to you? >

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-19 Thread 'Dave Young'
Hi, On 07/19/16 at 05:51am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi, > > > From: 'Dave Young' [mailto:dyo...@redhat.com] > > Sent: Monday, July 18, 2016 6:02 PM > > On 07/15/16 at 11:50am, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > Hi Dave, > > > > > > Tha

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-19 Thread 'Dave Young'
Hi, On 07/19/16 at 05:51am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi, > > > From: 'Dave Young' [mailto:dyo...@redhat.com] > > Sent: Monday, July 18, 2016 6:02 PM > > On 07/15/16 at 11:50am, 河合英宏 / KAWAI,HIDEHIRO wrote: > > > Hi Dave, > > > > > > Tha

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-18 Thread Dave Young
On 07/18/16 at 11:07am, Mark Rutland wrote: > On Mon, Jul 18, 2016 at 10:30:24AM +0800, Dave Young wrote: > > On 07/15/16 at 02:19pm, Mark Rutland wrote: > > > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > > > On Tue, Jul 12, 2016 at 10:42:01A

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-18 Thread Dave Young
On 07/18/16 at 11:07am, Mark Rutland wrote: > On Mon, Jul 18, 2016 at 10:30:24AM +0800, Dave Young wrote: > > On 07/15/16 at 02:19pm, Mark Rutland wrote: > > > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > > > On Tue, Jul 12, 2016 at 10:42:01A

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 11:06am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 04:17:12PM +0800, Dave Young wrote: > > Because IMHO it is wrong, they can not be ratelimited because the writing > > could > > be from different userspace programs. > > It is ratelimited

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 11:06am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 04:17:12PM +0800, Dave Young wrote: > > Because IMHO it is wrong, they can not be ratelimited because the writing > > could > > be from different userspace programs. > > It is ratelimited

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-18 Thread 'Dave Young'
Hi, On 07/15/16 at 11:50am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi Dave, > > Thanks for your reply. > > > From: 'Dave Young' [mailto:dyo...@redhat.com] > > Sent: Wednesday, July 13, 2016 11:04 AM > > > > On 07/12/16 at 02:49am, 河合英宏 / KAWAI,HIDEHIRO wrot

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-18 Thread 'Dave Young'
Hi, On 07/15/16 at 11:50am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi Dave, > > Thanks for your reply. > > > From: 'Dave Young' [mailto:dyo...@redhat.com] > > Sent: Wednesday, July 13, 2016 11:04 AM > > > > On 07/12/16 at 02:49am, 河合英宏 / KAWAI,HIDEHIRO wrot

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 10:08am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 03:38:45PM +0800, Dave Young wrote: > > no printk.devkmsg= on kernel cmdline > >-> unlocked, default is off, writing to /dev/kmsg is forbidded > > -> usespace set sysctl printk.devkmsg

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 10:08am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 03:38:45PM +0800, Dave Young wrote: > > no printk.devkmsg= on kernel cmdline > >-> unlocked, default is off, writing to /dev/kmsg is forbidded > > -> usespace set sysctl printk.devkmsg

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 09:21am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 01:20:32PM +0800, Dave Young wrote: > > Sorry, seems I do not get your point, suppose using the bis defined in your > > patch, shouldn't below work? > > When you supply "printk.devkmsg=&q

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-18 Thread Dave Young
On 07/18/16 at 09:21am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 01:20:32PM +0800, Dave Young wrote: > > Sorry, seems I do not get your point, suppose using the bis defined in your > > patch, shouldn't below work? > > When you supply "printk.devkmsg=&q

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/18/16 at 06:44am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > > I would say avoiding ratelimit during boot make no much sense. Userspace > > can not > > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init proces

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/18/16 at 06:44am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > > I would say avoiding ratelimit during boot make no much sense. Userspace > > can not > > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init proces

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 09:09am, Vivek Goyal wrote: > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > [..] > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > +SYSCALL_DEFINE6(kexec_file_load, int, kernel_fd, int, initrd_fd, > > unsigned long,

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 09:09am, Vivek Goyal wrote: > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > [..] > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > +SYSCALL_DEFINE6(kexec_file_load, int, kernel_fd, int, initrd_fd, > > unsigned long,

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 02:19pm, Mark Rutland wrote: > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > > > [..] > > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > >

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-17 Thread Dave Young
On 07/15/16 at 02:19pm, Mark Rutland wrote: > On Fri, Jul 15, 2016 at 09:09:55AM -0400, Vivek Goyal wrote: > > On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: > > > > [..] > > > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > > >

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/17/16 at 07:40am, Borislav Petkov wrote: > On Sat, Jul 16, 2016 at 06:44:25PM +0800, Dave Young wrote: > > ... > > > Mis-ratelimit cause critical userspace messages being lost, that is worse > > The current setting is quite generous so that all critical message

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/17/16 at 07:40am, Borislav Petkov wrote: > On Sat, Jul 16, 2016 at 06:44:25PM +0800, Dave Young wrote: > > ... > > > Mis-ratelimit cause critical userspace messages being lost, that is worse > > The current setting is quite generous so that all critical message

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-16 Thread Dave Young
On 07/15/16 at 02:45pm, Borislav Petkov wrote: > On Fri, Jul 15, 2016 at 02:21:09PM +0800, Dave Young wrote: > > Sorry for jumping in late. But I just see this today and I really like the > > idea to add a switch to turn off the kmsg writing from userspace because > >

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-16 Thread Dave Young
On 07/15/16 at 02:45pm, Borislav Petkov wrote: > On Fri, Jul 15, 2016 at 02:21:09PM +0800, Dave Young wrote: > > Sorry for jumping in late. But I just see this today and I really like the > > idea to add a switch to turn off the kmsg writing from userspace because > >

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-15 Thread Dave Young
On 07/08/16 at 11:18am, Borislav Petkov wrote: > From: Borislav Petkov > > Add a "printk.devkmsg" kernel command line parameter which controls how > userspace writes into /dev/kmsg. It has three options: > > * ratelimit - ratelimit logging from userspace. > * on - unlimited

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-15 Thread Dave Young
On 07/08/16 at 11:18am, Borislav Petkov wrote: > From: Borislav Petkov > > Add a "printk.devkmsg" kernel command line parameter which controls how > userspace writes into /dev/kmsg. It has three options: > > * ratelimit - ratelimit logging from userspace. > * on - unlimited logging from

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/14/16 at 02:38am, AKASHI Takahiro wrote: > Apologies for the slow response. I'm attending LinuxCon this week. > > On Wed, Jul 13, 2016 at 10:34:47AM +0100, Mark Rutland wrote: > > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > > But consider we

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/14/16 at 02:38am, AKASHI Takahiro wrote: > Apologies for the slow response. I'm attending LinuxCon this week. > > On Wed, Jul 13, 2016 at 10:34:47AM +0100, Mark Rutland wrote: > > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > > But consider we

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/13/16 at 10:34am, Mark Rutland wrote: > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > But consider we can kexec to a different kernel and a different initrd so > > there > > will be use cases to pass a total different dtb as well. > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
On 07/13/16 at 10:34am, Mark Rutland wrote: > On Wed, Jul 13, 2016 at 10:36:14AM +0800, Dave Young wrote: > > But consider we can kexec to a different kernel and a different initrd so > > there > > will be use cases to pass a total different dtb as well. > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
[snip] > Now, going back to the more fundamental issue raised in my first reply, > about the kernel command line. > > On x86, I can see that it _is_ possible for userspace to specify a > command line, and the kernel loading the image provides the command > line to the to-be-kexeced kernel with

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Dave Young
[snip] > Now, going back to the more fundamental issue raised in my first reply, > about the kernel command line. > > On x86, I can see that it _is_ possible for userspace to specify a > command line, and the kernel loading the image provides the command > line to the to-be-kexeced kernel with

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Dave Young
On 07/12/16 at 03:50pm, Mark Rutland wrote: > On Tue, Jul 12, 2016 at 04:24:10PM +0200, Arnd Bergmann wrote: > > On Tuesday, July 12, 2016 10:18:11 AM CEST Vivek Goyal wrote: > > > > > > > > On Open Firmware, the DT is extracted from running firmware and copied > > > > into dynamically allocated

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Dave Young
On 07/12/16 at 03:50pm, Mark Rutland wrote: > On Tue, Jul 12, 2016 at 04:24:10PM +0200, Arnd Bergmann wrote: > > On Tuesday, July 12, 2016 10:18:11 AM CEST Vivek Goyal wrote: > > > > > > > > On Open Firmware, the DT is extracted from running firmware and copied > > > > into dynamically allocated

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-12 Thread 'Dave Young'
On 07/12/16 at 02:49am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi Dave, > > Thanks for the comments. > > > From: Dave Young [mailto:dyo...@redhat.com] > > Sent: Monday, July 11, 2016 5:35 PM > > > > On 07/05/16 at 08:33pm, Hidehiro Kawai wrote: > > >

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-12 Thread 'Dave Young'
On 07/12/16 at 02:49am, 河合英宏 / KAWAI,HIDEHIRO wrote: > Hi Dave, > > Thanks for the comments. > > > From: Dave Young [mailto:dyo...@redhat.com] > > Sent: Monday, July 11, 2016 5:35 PM > > > > On 07/05/16 at 08:33pm, Hidehiro Kawai wrote: > > >

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-11 Thread Dave Young
l names > > Changes in V2: > - Replace smp_send_stop() call with crash_kexec version which > saves cpu states and cleans up VMX/SVM > - Drop a fix for Problem 1 at this moment > > Reported-by: Daniel Walker <dwal...@fifo99.com> > Fixes: f06e5153f4ae (kernel/panic.c: ad

Re: [V3 PATCH 1/2] x86/panic: Replace smp_send_stop() with kdump friendly version

2016-07-11 Thread Dave Young
l names > > Changes in V2: > - Replace smp_send_stop() call with crash_kexec version which > saves cpu states and cleans up VMX/SVM > - Drop a fix for Problem 1 at this moment > > Reported-by: Daniel Walker > Fixes: f06e5153f4ae (kernel/panic.c: add "crash_kexec_p

Re: [RFC] arm64: kexec_file_load support

2016-07-11 Thread Dave Young
On 07/11/16 at 04:19pm, AKASHI Takahiro wrote: > On Fri, Jul 08, 2016 at 11:48:44AM -0300, Thiago Jung Bauermann wrote: > > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > > If so maybe change a bit from your precious mentioned 7 args proposal like > > >

Re: [RFC] arm64: kexec_file_load support

2016-07-11 Thread Dave Young
On 07/11/16 at 04:19pm, AKASHI Takahiro wrote: > On Fri, Jul 08, 2016 at 11:48:44AM -0300, Thiago Jung Bauermann wrote: > > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > > If so maybe change a bit from your precious mentioned 7 args proposal like > > >

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
lt;ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > --- > include/linux/kexec.h | 1 + > kernel/kexec_file.c | 25 - > 2 files changed, 21 insertions(+), 5 deletions(-) > > diff --git a/include/linux/kexec.h b/include/l

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
On 07/07/16 at 01:23pm, Thiago Jung Bauermann wrote: > kexec_locate_mem_hole will be used by the PowerPC kexec_file_load > implementation to find free memory for the purgatory stack. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman > Cc: Dave Young > --- >

Re: [PATCH v4 2/9] kexec_file: Change kexec_add_buffer to take kexec_buf as argument.

2016-07-10 Thread Dave Young
existing casts to char * in the code. > > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Ingo Molnar <mi...

Re: [PATCH v4 2/9] kexec_file: Change kexec_add_buffer to take kexec_buf as argument.

2016-07-10 Thread Dave Young
existing casts to char * in the code. > > Signed-off-by: Thiago Jung Bauermann > Cc: Eric Biederman > Cc: Dave Young > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x...@kernel.org > --- > arch/x86/kernel/crash.c | 37 +++

Re: [PATCH v4 1/9] kexec_file: Allow arch-specific memory walking for kexec_add_buffer

2016-07-10 Thread Dave Young
auermann <bauer...@linux.vnet.ibm.com> > Cc: Eric Biederman <ebied...@xmission.com> > Cc: Dave Young <dyo...@redhat.com> > --- > include/linux/kexec.h | 29 - > kernel/kexec_file.c | 30 ++ > kernel/kexec_inte

Re: [PATCH v4 1/9] kexec_file: Allow arch-specific memory walking for kexec_add_buffer

2016-07-10 Thread Dave Young
ann > Cc: Eric Biederman > Cc: Dave Young > --- > include/linux/kexec.h | 29 - > kernel/kexec_file.c | 30 ++ > kernel/kexec_internal.h | 16 > 3 files changed, 50 insertions(+), 25 deletions(-) >

Re: [RFC] arm64: kexec_file_load support

2016-07-10 Thread Dave Young
On 07/08/16 at 11:48am, Thiago Jung Bauermann wrote: > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > If so maybe change a bit from your precious mentioned 7 args proposal like > > below? > > > > struct kexec_file_fd { > > enu

Re: [RFC] arm64: kexec_file_load support

2016-07-10 Thread Dave Young
On 07/08/16 at 11:48am, Thiago Jung Bauermann wrote: > Am Donnerstag, 07 Juli 2016, 14:12:45 schrieb Dave Young: > > If so maybe change a bit from your precious mentioned 7 args proposal like > > below? > > > > struct kexec_file_fd { > > enu

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> > > Cc: Eric Biederman <ebied...@xmission.com> > > Cc: Dave Young <dyo...@redhat.com> > > Dave are you happy with the first three patches? If so do you mind > sending an ack? I reviewed the 3 pat

Re: [PATCH v4 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-07-10 Thread Dave Young
> > Cc: Eric Biederman > > Cc: Dave Young > > Dave are you happy with the first three patches? If so do you mind > sending an ack? I reviewed the 3 patches, they look good to me. Will ack after a small test today. > > Given the series touches generic cod

Re: [RFC] arm64: kexec_file_load support

2016-07-07 Thread Dave Young
On 07/05/16 at 05:03pm, AKASHI Takahiro wrote: > Hi Dave, > > On Tue, Jul 05, 2016 at 09:25:56AM +0800, Dave Young wrote: > > On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > > > Hi, > > > > > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Ba

Re: [RFC] arm64: kexec_file_load support

2016-07-07 Thread Dave Young
On 07/05/16 at 05:03pm, AKASHI Takahiro wrote: > Hi Dave, > > On Tue, Jul 05, 2016 at 09:25:56AM +0800, Dave Young wrote: > > On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > > > Hi, > > > > > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Ba

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

2016-07-06 Thread Dave Young
return 0; > } > -- > 2.7.3.AMZN > > ___ > kexec mailing list > ke...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Acked-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size

2016-07-06 Thread Dave Young
printf("\t;\n\nconst int %s_size = %d;\n", argv[1], total); > + printf("\t;\n\n#include \n\nconst size_t %s_size > = %d;\n", > +argv[1], total); > > return 0; > } > -- > 2.7.3.AMZN > > ___ > kexec mailing list > ke...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec Acked-by: Dave Young Thanks Dave

Re: [RFC] arm64: kexec_file_load support

2016-07-04 Thread Dave Young
On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > Hi, > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Bauermann wrote: > > Am Freitag, 01 Juli 2016, 14:11:12 schrieb AKASHI Takahiro: > > > I'm not sure whether there is any demand for kexec_file_load > > > support on arm64, but anyhow I'm

Re: [RFC] arm64: kexec_file_load support

2016-07-04 Thread Dave Young
On 07/04/16 at 03:58pm, AKASHI Takahiro wrote: > Hi, > > On Fri, Jul 01, 2016 at 12:46:31PM -0300, Thiago Jung Bauermann wrote: > > Am Freitag, 01 Juli 2016, 14:11:12 schrieb AKASHI Takahiro: > > > I'm not sure whether there is any demand for kexec_file_load > > > support on arm64, but anyhow I'm

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-04 Thread Dave Young
On 07/01/16 at 05:31pm, Thiago Jung Bauermann wrote: > Am Freitag, 01 Juli 2016, 17:02:23 schrieb Thiago Jung Bauermann: > > Am Freitag, 01 Juli 2016, 14:36:02 schrieb Dave Young: > > > On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > > > > Am Donnerstag, 30 Ju

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-04 Thread Dave Young
On 07/01/16 at 05:31pm, Thiago Jung Bauermann wrote: > Am Freitag, 01 Juli 2016, 17:02:23 schrieb Thiago Jung Bauermann: > > Am Freitag, 01 Juli 2016, 14:36:02 schrieb Dave Young: > > > On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > > > > Am Donnerstag, 30 Ju

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-01 Thread Dave Young
On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > > > To be h

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-07-01 Thread Dave Young
On 07/01/16 at 02:51pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 17:43:57 schrieb Dave Young: > > On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > > > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > > > To be h

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > Am Donnerstag, 30 Juni 2016, 11:07:00 schrieb Dave Young: > > > On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > > > > I'm not foll

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:42pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 12:49:44 schrieb Thiago Jung Bauermann: > > Am Donnerstag, 30 Juni 2016, 11:07:00 schrieb Dave Young: > > > On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > > > > I'm not foll

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18p

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18p

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > On 06/27/16 at 04:21pm, Dave

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > On 06/27/16 at 04:21pm, Dave

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index e8acb2b43dd9..e16d845d587f

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-30 Thread Dave Young
On 06/29/16 at 06:18pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index e8acb2b43dd9..e16d845d587f

Re: [PATCH 00/11] efi: Permanent runtime EFI memmap support

2016-06-30 Thread Dave Young
exec_file system call. But due to a crypto issue I can not test signature verification of kexec_file, but I think that is a separate problem. For these parts: Tested-by: Dave Young <dyo...@redhat.com> Thanks Dave

Re: [PATCH 00/11] efi: Permanent runtime EFI memmap support

2016-06-30 Thread Dave Young
exec_file system call. But due to a crypto issue I can not test signature verification of kexec_file, but I think that is a separate problem. For these parts: Tested-by: Dave Young Thanks Dave

kexec_file_load signature verification failure

2016-06-30 Thread Dave Young
Hi, David kexec_file_load fails with a Bad Message error with recent kernel: kexec_file_load failed: Bad message Debug messages: [ 3463.794391] PEFILE: checksum @ da [ 3463.794395] PEFILE: header size = 200 [ 3463.794397] PEFILE: cert = 898 @4a5370 [97 08 00 00 00 02 02 00 30 82 08 8b 06 09 2a

kexec_file_load signature verification failure

2016-06-30 Thread Dave Young
Hi, David kexec_file_load fails with a Bad Message error with recent kernel: kexec_file_load failed: Bad message Debug messages: [ 3463.794391] PEFILE: checksum @ da [ 3463.794395] PEFILE: header size = 200 [ 3463.794397] PEFILE: cert = 898 @4a5370 [97 08 00 00 00 02 02 00 30 82 08 8b 06 09 2a

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Please ignore previous reply, I mistakenly send a broken mail without > > > subject, sorry abou

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > Please ignore previous reply, I mistakenly send a broken mail without > > > subject, sorry abou

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 10:25:06 schrieb Dave Young: > > On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > > > The patch looks good,

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-29 Thread Dave Young
On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 10:25:06 schrieb Dave Young: > > On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > > > The patch looks good,

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Dave Young
On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave You

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-28 Thread Dave Young
On 06/27/16 at 04:21pm, Dave Young wrote: > Please ignore previous reply, I mistakenly send a broken mail without > subject, sorry about it. Resend the reply here. > > On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave You

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
Please ignore previous reply, I mistakenly send a broken mail without subject, sorry about it. Resend the reply here. On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote:

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
Please ignore previous reply, I mistakenly send a broken mail without subject, sorry about it. Resend the reply here. On 06/27/16 at 01:37pm, Thiago Jung Bauermann wrote: > Am Dienstag, 28 Juni 2016, 00:19:48 schrieb Dave Young: > > On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote:

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > Hmm, hold on. For declaring a struct in a header file, comment should be > > just after each fields, like below, your format is for a function instead: >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-27 Thread Dave Young
On 06/23/16 at 12:37pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 23 Juni 2016, 01:44:07 schrieb Dave Young: > > Hmm, hold on. For declaring a struct in a header file, comment should be > > just after each fields, like below, your format is for a function instead: >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
- Original Message - From: "Dave Young" <dyo...@redhat.com> To: "Thiago Jung Bauermann" <bauer...@linux.vnet.ibm.com> Cc: linuxppc-...@lists.ozlabs.org, ke...@lists.infradead.org, linux-kernel@vger.kernel.org, "Eric Biederman" <ebied...@xmis

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
- Original Message - From: "Dave Young" To: "Thiago Jung Bauermann" Cc: linuxppc-...@lists.ozlabs.org, ke...@lists.infradead.org, linux-kernel@vger.kernel.org, "Eric Biederman" Sent: Thursday, June 23, 2016 10:30:52 AM Subject: Re: [PATCH

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > >

Re: [PATCH v3 3/9] kexec_file: Factor out kexec_locate_mem_hole from kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:34pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:18:01 schrieb Dave Young: > > On 06/21/16 at 04:48pm, Thiago Jung Bauermann wrote: > > > +/** > > > + * kexec_locate_mem_hole - find free memory to load segment or use in > >

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > The patch looks good, but could the subject be more specific? > > > > For example just like the first sentence of the patch descriotion: > > Allow archite

Re: [PATCH v3 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-22 Thread Dave Young
On 06/22/16 at 08:30pm, Thiago Jung Bauermann wrote: > Am Mittwoch, 22 Juni 2016, 18:20:47 schrieb Dave Young: > > The patch looks good, but could the subject be more specific? > > > > For example just like the first sentence of the patch descriotion: > > Allow archite

<    4   5   6   7   8   9   10   11   12   13   >