RE: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

> > We get 1 warning when building kernel with W=1: > drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for > 'aac_src_select_comm' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared and > don't need > a declaration, but can be made

RE: [PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

> > We get 1 warning when building kernel with W=1: > drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for > 'aac_src_select_comm' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared and > don't need > a declaration, but can be made

RE: MAINTAINERS without commits in the last 3 years

> > The email addresses below are also bcc'd here to see what bounces. > The list of the bounces will be collected. > > Thoughts? > > aacr...@adaptec.com > aacr...@microsemi.com Hi Joe, aacr...@microsemi.com is a mailing list, and is valid. I thought I had changed aacr...@adaptec.com, but

RE: MAINTAINERS without commits in the last 3 years

> > The email addresses below are also bcc'd here to see what bounces. > The list of the bounces will be collected. > > Thoughts? > > aacr...@adaptec.com > aacr...@microsemi.com Hi Joe, aacr...@microsemi.com is a mailing list, and is valid. I thought I had changed aacr...@adaptec.com, but

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

> > > > Hi Markus, > > > > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look > pretty. > > Do you eventually prefer that this source code adjustment should be combined > with the update suggestion "[2/7] aacraid: One function call less in > aac_send_raw_srb() after error

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

> > > > Hi Markus, > > > > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look > pretty. > > Do you eventually prefer that this source code adjustment should be combined > with the update suggestion "[2/7] aacraid: One function call less in > aac_send_raw_srb() after error

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

> From: Markus Elfring > Date: Sat, 20 Aug 2016 20:05:24 +0200 > > Reuse existing functionality from memdup_user() instead of keeping duplicate > source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring

RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

> From: Markus Elfring > Date: Sat, 20 Aug 2016 20:05:24 +0200 > > Reuse existing functionality from memdup_user() instead of keeping duplicate > source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- >