Re: [PATCH net] ethtool: do not print warning for applications using legacy API

Signed-off-by: David Decotigny <de...@googlers.com> On Fri, Dec 29, 2017 at 10:02 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > From: Stephen Hemminger <step...@networkplumber.org> > > In kernel log ths message appears on every boot: > "war

Re: [PATCH net] ethtool: do not print warning for applications using legacy API

Signed-off-by: David Decotigny On Fri, Dec 29, 2017 at 10:02 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > In kernel log ths message appears on every boot: > "warning: `NetworkChangeNo' uses legacy ethtool link settings API, > link modes are only partiall

[PATCH v1] mlx4: remove unused fields

From: David Decotigny <de...@googlers.com> This also can address following UBSAN warnings: [ 36.640343] [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 [ 36.

[PATCH v1] mlx4: remove unused fields

From: David Decotigny This also can address following UBSAN warnings: [ 36.640343] [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 [ 36.656853] shift exponent 64

Re: [PATCH v3 1/3] net: phy: add phy_ethtool_{get|set}_link_ksettings

ttings(struct net_device *ndev, > + const struct ethtool_link_ksettings *cmd); > > int __init mdio_bus_init(void); > void mdio_bus_exit(void); > -- > 1.7.4.4 > Acked-By: David Decotigny <de...@googlers.com>

Re: [PATCH v3 1/3] net: phy: add phy_ethtool_{get|set}_link_ksettings

id phy_ethtool_get_wol(struct phy_device *phydev, > struct ethtool_wolinfo *wol); > +int phy_ethtool_get_link_ksettings(struct net_device *ndev, > + struct ethtool_link_ksettings *cmd); > +int phy_ethtool_set_link_ksettings(struct net_device *ndev, > + const struct ethtool_link_ksettings *cmd); > > int __init mdio_bus_init(void); > void mdio_bus_exit(void); > -- > 1.7.4.4 > Acked-By: David Decotigny

Re: [PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Are you sure this belongs to ethtool.h? For one, I believe you need an #include phy.h somewhere. I would suggest instead to keep this in phy.h, presumably with a more explicit name suggesting that phydev is involved. On Sun, May 8, 2016 at 2:44 PM, Philippe Reynes wrote: >

Re: [PATCH v2 1/3] net: core: ethtool: add ethtool_op_{get|set}_link_ksettings

Are you sure this belongs to ethtool.h? For one, I believe you need an #include phy.h somewhere. I would suggest instead to keep this in phy.h, presumably with a more explicit name suggesting that phydev is involved. On Sun, May 8, 2016 at 2:44 PM, Philippe Reynes wrote: > Ethtool callbacks

Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

, 2016 at 10:31 AM, David Miller <da...@davemloft.net> wrote: > From: David Decotigny <ddeco...@gmail.com> > Date: Thu, 17 Mar 2016 17:03:54 -0700 > >> This removes the requirement that ethtool be tied to the support >> of a specific L3 protocol, also updates a comment. &

Re: [PATCH v1 0/2] basic ioctl support for netlink sockets

, 2016 at 10:31 AM, David Miller wrote: > From: David Decotigny > Date: Thu, 17 Mar 2016 17:03:54 -0700 > >> This removes the requirement that ethtool be tied to the support >> of a specific L3 protocol, also updates a comment. > > You're adding an ioctl

[PATCH net-next v2 1/2] ethtool: minor doc update

From: David Decotigny <de...@googlers.com> Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords") Signed-off-by: David Decotigny <de...@googlers.com> --- include/uapi/linux/ethtool.h | 6 +++--- 1 file chang

[PATCH net-next v2 1/2] ethtool: minor doc update

From: David Decotigny Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords") Signed-off-by: David Decotigny --- include/uapi/linux/ethtool.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/

[PATCH net-next v2 0/2] basic ioctl support for netlink sockets

From: David Decotigny <de...@googlers.com> This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. History: v2 updated commit description for the netlink ioctl patch v1 initial subm

[PATCH net-next v2 0/2] basic ioctl support for netlink sockets

From: David Decotigny This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. History: v2 updated commit description for the netlink ioctl patch v1 initial submission # Patch

[PATCH net-next v2 2/2] netlink: add support for NIC driver ioctls

From: David Decotigny <de...@googlers.com> By returning -ENOIOCTLCMD, sock_do_ioctl() falls back to calling dev_ioctl(), which provides support for NIC driver ioctls, which includes ethtool support. This is similar to the way ioctls are handled in udp.c or tcp.c. This removes the requi

[PATCH net-next v2 2/2] netlink: add support for NIC driver ioctls

From: David Decotigny By returning -ENOIOCTLCMD, sock_do_ioctl() falls back to calling dev_ioctl(), which provides support for NIC driver ioctls, which includes ethtool support. This is similar to the way ioctls are handled in udp.c or tcp.c. This removes the requirement that ethtool

[PATCH v1 0/2] basic ioctl support for netlink sockets

From: David Decotigny <de...@googlers.com> This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. # Patch Set Summary: David Decotigny (2): ethtool: minor doc update netlin

[PATCH v1 0/2] basic ioctl support for netlink sockets

From: David Decotigny This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. # Patch Set Summary: David Decotigny (2): ethtool: minor doc update netlink: add support for NIC driver

[PATCH v1 2/2] netlink: add support for NIC driver ioctls

From: David Decotigny <de...@googlers.com> This patch removes the requirement that ethtool be tied to the support of a specific L3 protocol (ethtool uses an AF_INET socket today). Signed-off-by: David Decotigny <de...@googlers.com> --- net/netlink/af_netlink.c | 10 +- 1 fil

[PATCH v1 2/2] netlink: add support for NIC driver ioctls

From: David Decotigny This patch removes the requirement that ethtool be tied to the support of a specific L3 protocol (ethtool uses an AF_INET socket today). Signed-off-by: David Decotigny --- net/netlink/af_netlink.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

[PATCH v1 1/2] ethtool: minor doc update

From: David Decotigny <de...@googlers.com> Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords") Signed-off-by: David Decotigny <de...@googlers.com> --- include/uapi/linux/ethtool.h | 6 +++--- 1 file chang

[PATCH v1 1/2] ethtool: minor doc update

From: David Decotigny Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords") Signed-off-by: David Decotigny --- include/uapi/linux/ethtool.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/

[PATCH net-next v9 07/16] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c i

[PATCH net-next v9 06/16] net: bonding: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c i

[PATCH net-next v9 07/16] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index a7ca1c5..5802b90 100644 --- a/drivers/net/ipvlan

[PATCH net-next v9 06/16] net: bonding: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index a6527d5..b6236ff 100644 --- a/drivers/net/bonding

[PATCH net-next v9 02/16] net: usnic: use __ethtool_get_settings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infinib

[PATCH net-next v9 03/16] net: ethtool: add new ETHTOOL_xLINKSETTINGS API

From: David Decotigny <de...@googlers.com> This patch defines a new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API, handled by the new get_link_ksettings/set_link_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 406

[PATCH net-next v9 03/16] net: ethtool: add new ETHTOOL_xLINKSETTINGS API

From: David Decotigny This patch defines a new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API, handled by the new get_link_ksettings/set_link_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length

[PATCH net-next v9 02/16] net: usnic: use __ethtool_get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644

[PATCH net-next v9 08/16] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 426a2cc..6e953e3 100644 --- a

[PATCH net-next v9 08/16] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 426a2cc..6e953e3 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v9 04/16] tx4939: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx

[PATCH net-next v9 04/16] tx4939: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..402ac2e 100644 --- a/arch/mips

[PATCH net-next v9 10/16] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drive

[PATCH net-next v9 10/16] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..641c60e

[PATCH net-next v9 05/16] net: usnic: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infinib

[PATCH net-next v9 05/16] net: usnic: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..a5bfbba

[PATCH net-next v9 11/16] net: rdma: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..931a47b 100644 -

[PATCH net-next v9 11/16] net: rdma: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..931a47b 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v9 13/16] net: bridge: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..b37a1cc 100644 --- a/net/bridge/br_if

[PATCH net-next v9 13/16] net: bridge: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..b37a1cc 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v9 09/16] net: team: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..2769835 100644 --- a

[PATCH net-next v9 09/16] net: team: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..2769835 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v9 14/16] net: core: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core

[PATCH net-next v9 16/16] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 357 +--- drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

[PATCH net-next v9 14/16] net: core: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 4ae17c3..2b3f76f 100644 --- a/net

[PATCH net-next v9 16/16] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 357 +--- drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 189 insertions(+), 170

[PATCH net-next v9 01/16] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_v

[PATCH net-next v9 12/16] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 055f0e9..e416a40 100644 --- a/net/8021

[PATCH net-next v9 15/16] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny <de...@googlers.com> replaced by __ethtool_get_link_ksettings. Signed-off-by: David Decotigny <de...@googlers.com> --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 inser

[PATCH net-next v9 12/16] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 055f0e9..e416a40 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -621,12

[PATCH net-next v9 15/16] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny replaced by __ethtool_get_link_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux

[PATCH net-next v9 01/16] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 6cdb4d2..ea003ec 100644 --- a/drivers

[PATCH net-next v9 00/16] new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API

From: David Decotigny <de...@googlers.com> History: v9 - add 'link' in macro, struct and function names - rename ethtool_link_ksettings::parent -> ::base - remove un-needed mlx4 en_dbg_enabled() companion patch - note: bitmap u32[] API patches were merged separately by Kan

[PATCH net-next v9 00/16] new ETHTOOL_GLINKSETTINGS/SLINKSETTINGS API

From: David Decotigny History: v9 - add 'link' in macro, struct and function names - rename ethtool_link_ksettings::parent -> ::base - remove un-needed mlx4 en_dbg_enabled() companion patch - note: bitmap u32[] API patches were merged separately by Kan Liang v8 - bitmap u32 API retu

Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

016-02-09 at 16:29 -0800, David Decotigny wrote: >> From: David Decotigny <de...@googlers.com> >> >> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by >> the new get_ksettings/set_ksettings callbacks. This API provides >> support for most legac

Re: [PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

vid Decotigny wrote: >> From: David Decotigny >> >> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by >> the new get_ksettings/set_ksettings callbacks. This API provides >> support for most legacy ethtool_cmd fields, adds support for larger >> lin

[PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c

From: David Decotigny This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib

[PATCH net-next v8 01/19] lib/bitmap.c: conversion routines to/from u32 array

From: David Decotigny Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny --- include/linux/bitmap.h | 10 ++ lib/bitmap.c | 89

[PATCH net-next v8 04/19] net: usnic: use __ethtool_get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index ea003ec..1cf19a3 100644

[PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable length), and removes

[PATCH net-next v8 08/19] net: bonding: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 705cb01..abef2a9 100644 --- a/drivers/net/bonding

[PATCH net-next v8 09/19] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 7a3b414..9703610 100644 --- a/drivers/net/ipvlan

[PATCH net-next v8 07/19] net: usnic: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 1cf19a3..e90dc64

[PATCH net-next v8 10/19] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 94e6888..a54ad4c 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c

[PATCH net-next v8 11/19] net: team: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..7f96eca7 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team

[PATCH net-next v8 13/19] net: rdma: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..f669751 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma

[PATCH net-next v8 17/19] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+), 35 deletions(-) diff --git a/include/linux/ethtool.h

[PATCH net-next v8 14/19] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index ad5e2fd..d4a6131 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -621,12

[PATCH net-next v8 16/19] net: core: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index da7dbc2..b9c8b91 100644 --- a/net

[PATCH net-next v8 18/19] net: mlx4: convenience predicate for debug messages

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h index 35de7d2..b04054d

Re: [PATCH net-next v7 01/19] lib/bitmap.c: conversion routines to/from u32 array

thanks. done in v8 I am sending right now. On Mon, Feb 8, 2016 at 3:36 PM, Andrew Morton wrote: > On Sun, 7 Feb 2016 17:08:45 -0800 David Decotigny wrote: > >> From: David Decotigny >> >> Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic >>

[PATCH net-next v8 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny Signed-off-by: David Decotigny --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h| 1 + 3 files changed, 177 insertions(+), 169

[PATCH net-next v8 12/19] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index d7597c0..2d5909f

[PATCH net-next v8 15/19] net: bridge: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..cafe4e6 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -36,10 +36,10

[PATCH net-next v8 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny Signed-off-by: David Decotigny --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index 6cdb4d2..ea003ec 100644 --- a/drivers

[PATCH net-next v8 06/19] tx4939: use __ethtool_get_ksettings

From: David Decotigny Signed-off-by: David Decotigny --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx4939.c index e3733cd..4a3ebf6 100644 --- a/arch/mips

[PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny History: v8 - bitmap u32 API returns number of bits copied, unit tests updated v7 - module_exit in test_bitmap v6 - fix copy_from_user in user/kernel handshake v5 note: please see v4 bullets for a question regarding bitmap.c - minor fix to make allyesconfig

[PATCH net-next v8 15/19] net: bridge: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/bridge/br_if.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index c367b3e..cafe4e6 100644 --- a/net/bridge/br_if

[PATCH net-next v8 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 344 drivers/net/ethernet/mellanox/mlx4/en_main.c| 1 + drivers/net/ethernet/mellanox/mlx4/mlx4_en.h

[PATCH net-next v8 12/19] net: fcoe: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/scsi/fcoe/fcoe_transport.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drive

Re: [PATCH net-next v7 01/19] lib/bitmap.c: conversion routines to/from u32 array

thanks. done in v8 I am sending right now. On Mon, Feb 8, 2016 at 3:36 PM, Andrew Morton <a...@linux-foundation.org> wrote: > On Sun, 7 Feb 2016 17:08:45 -0800 David Decotigny <ddeco...@gmail.com> wrote: > >> From: David Decotigny <de...@googlers.com> >> >

[PATCH net-next v8 18/19] net: mlx4: convenience predicate for debug messages

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ether

[PATCH net-next v8 11/19] net: team: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/team/team.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 00558e1..7f96eca7 100644 -

[PATCH net-next v8 13/19] net: rdma: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- include/rdma/ib_addr.h | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index c34c900..f669751 100644 -

[PATCH net-next v8 17/19] net: ethtool: remove unused __ethtool_get_settings

From: David Decotigny <de...@googlers.com> replaced by __ethtool_get_ksettings. Signed-off-by: David Decotigny <de...@googlers.com> --- include/linux/ethtool.h | 4 net/core/ethtool.c | 45 ++--- 2 files changed, 14 insertions(+),

[PATCH net-next v8 04/19] net: usnic: use __ethtool_get_settings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infinib

[PATCH net-next v8 01/19] lib/bitmap.c: conversion routines to/from u32 array

From: David Decotigny <de...@googlers.com> Aimed at transferring bitmaps to/from user-space in a 32/64-bit agnostic way. Tested: unit tests (next patch) on qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny <de...@googlers.com> --- include/linux/b

[PATCH net-next v8 14/19] net: 8021q: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/8021q/vlan_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index ad5e2fd..d4a6131 100644 --- a/net/8021

[PATCH net-next v8 16/19] net: core: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- net/core/net-sysfs.c | 15 +-- net/packet/af_packet.c | 11 +-- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core

[PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c

From: David Decotigny <de...@googlers.com> This is mainly testing bitmap construction and conversion to/from u32[] for now. Tested: qemu i386, x86_64, ppc, ppc64 BE and LE, ARM. Signed-off-by: David Decotigny <de...@googlers.com> --- lib/Kconfig.debug

[PATCH net-next v8 00/19] new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny <de...@googlers.com> History: v8 - bitmap u32 API returns number of bits copied, unit tests updated v7 - module_exit in test_bitmap v6 - fix copy_from_user in user/kernel handshake v5 note: please see v4 bullets for a question regarding bitmap.c - minor fix t

[PATCH net-next v8 03/19] net: usnic: remove unused call to ethtool_ops::get_settings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_v

[PATCH net-next v8 06/19] tx4939: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- arch/mips/txx9/generic/setup_tx4939.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup_tx4939.c b/arch/mips/txx9/generic/setup_tx

[PATCH net-next v8 09/19] net: ipvlan: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/ipvlan/ipvlan_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c i

[PATCH net-next v8 07/19] net: usnic: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infinib

[PATCH net-next v8 10/19] net: macvlan: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/macvlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 94e6888..a54ad4c 100644 --- a

[PATCH net-next v8 08/19] net: bonding: use __ethtool_get_ksettings

From: David Decotigny <de...@googlers.com> Signed-off-by: David Decotigny <de...@googlers.com> --- drivers/net/bonding/bond_main.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c i

[PATCH net-next v8 05/19] net: ethtool: add new ETHTOOL_GSETTINGS/SSETTINGS API

From: David Decotigny <de...@googlers.com> This patch defines a new ETHTOOL_GSETTINGS/SSETTINGS API, handled by the new get_ksettings/set_ksettings callbacks. This API provides support for most legacy ethtool_cmd fields, adds support for larger link mode masks (up to 4064 bits, variable

  1   2   3   4   5   >