On Tuesday, 2021-04-13 at 11:45:52 -07, Aaron Lewis wrote:
>>
>> > Depending on what you're trying to do with the info, maybe there's a better
>> > option. E.g. Aaron is working on a series that includes passing pass the
>> > code
>> > stream (instruction bytes) to userspace on emulation failure
On Monday, 2021-04-12 at 11:34:33 -07, Jim Mattson wrote:
> On Mon, Apr 12, 2021 at 6:09 AM David Edmondson
> wrote:
>>
>> Instruction emulation happens for a variety of reasons, yet on error
>> we have no idea exactly what triggered it. Add a cause of emulation to
>&g
On Monday, 2021-04-12 at 16:04:02 GMT, Sean Christopherson wrote:
> +Aaron
>
> On Mon, Apr 12, 2021, David Edmondson wrote:
>> From: Joao Martins
>>
>> Declare various causes of emulation and use them as appropriate.
>>
>> Signed-off-by: Joao Mar
From: Joao Martins
Make the emulation_reason available up stack when reporting an
emulation failure.
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/kvm/x86.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kvm/x86.c b
From: Joao Martins
Declare various causes of emulation and use them as appropriate.
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/include/asm/kvm_host.h | 6 ++
arch/x86/kvm/mmu/mmu.c | 4 ++--
arch/x86/kvm/x86.c | 5 +++--
3 files changed
Instruction emulation happens for a variety of reasons, yet on error
we have no idea exactly what triggered it. Add a cause of emulation to
the various originators and pass it upstream when emulation fails.
Joao originally produced the patches but is busy with other things and
I wanted to use it,
From: Joao Martins
Declare various causes of emulation and use them as appropriate.
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/include/asm/kvm_host.h | 5 +
arch/x86/kvm/vmx/vmx.c | 17 +
2 files changed, 14 insertions(+), 8
From: Joao Martins
Emulation can happen for a variety of reasons, yet on error we have no
idea exactly what triggered it. Expand x86_emulate_instruction() to
carry an @emulation_reason argument.
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/kvm/mmu/mmu.c | 4
From: Joao Martins
Declare various causes of emulation and use them as appropriate.
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/include/asm/kvm_host.h | 6 ++
arch/x86/kvm/svm/avic.c | 3 ++-
arch/x86/kvm/svm/svm.c | 26
From: Joao Martins
Allow kvm_emulate_instruction() callers to provide the cause of
instruction emulation, which is then passed along to
x86_emulation_instruction().
Signed-off-by: Joao Martins
Signed-off-by: David Edmondson
---
arch/x86/include/asm/kvm_host.h | 10 --
arch/x86/kvm
On Thursday, 2021-03-18 at 12:08:36 GMT, David Edmondson wrote:
> v2:
> - Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
> - Dump the MSR autoload/autosave lists (Paolo).
>
> v3:
> - Rebase to master.
> - Check only the load controls (Sea
list if it's there (Paulo).
- Calculate and show the effective EFER if it is not coming from
either the VMCS or the MSR autoload list (Sean).
v4:
- Ensure that each changeset builds with just the previous set.
v5:
- Rebase.
- Remove some cruft from changeset comments.
- Add S-by as approp
When dumping the current VMCS state, include the MSRs that are being
automatically loaded/stored during VM entry/exit.
Suggested-by: Paolo Bonzini
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 16
1 file changed, 16 insertions(+)
diff --git a/arch/x86/kvm/vmx
If EFER is not being loaded from the VMCS, show the effective value by
reference to the MSR autoload list or calculation.
Suggested-by: Sean Christopherson
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 20
arch/x86/kvm/vmx/vmx.h | 2 +-
2 files changed, 17
When deciding whether to dump the GUEST_IA32_EFER and GUEST_IA32_PAT
fields of the VMCS, examine only the VM entry load controls, as saving
on VM exit has no effect on whether VM entry succeeds or fails.
Suggested-by: Sean Christopherson
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx
t use GUEST_IA32_EFER to decide
whether to print the PDPTRs - always do so if the fields exist.
Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/x8
Show EFER and PAT based on their individual entry/exit controls.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index b0ee9d240f73..6ab9e4d69aac
When dumping the current VMCS state, include the MSRs that are being
automatically loaded/stored during VM entry/exit.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 16
1 file changed, 16 insertions(+)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
Show EFER and PAT based on their individual entry/exit controls.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index ea1b3a671d51..90d677d72502
t use GUEST_IA32_EFER to decide
whether to print the PDPTRs - always do so if the fields exist.
Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson
if valid
---
arch/x86/kvm/vmx/vmx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
list if it's there (Paulo).
- Calculate and show the effective EFER if it is not coming from
either the VMCS or the MSR autoload list (Sean).
v4:
- Ensure that each changeset builds with just the previous set.
David Edmondson (5):
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER i
If EFER is not being loaded from the VMCS, show the effective value by
reference to the MSR autoload list or calculation.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 20
arch/x86/kvm/vmx/vmx.h | 2 +-
2 files changed, 17 insertions(+), 5 deletions(-)
diff
When deciding whether to dump the GUEST_IA32_EFER and GUEST_IA32_PAT
fields of the VMCS, examine only the VM entry load controls, as saving
on VM exit has no effect on whether VM entry succeeds or fails.
Suggested-by: Sean Christopherson
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx
Bah, I will resend the series, as it won't build with patch 4 but
without patch 5.
On Wednesday, 2021-02-24 at 13:29:18 UTC, David Edmondson wrote:
> If EFER is not being loaded from the VMCS, show the effective value by
> reference to the MSR autoload list or calculation.
>
&
On Tuesday, 2021-02-23 at 14:58:29 -08, Sean Christopherson wrote:
> On Fri, Feb 19, 2021, David Edmondson wrote:
>> Show EFER and PAT based on their individual entry/exit controls.
>>
>> Signed-off-by: David Edmondson
>> ---
>> arch/x86/kvm/vmx/vmx.c |
On Tuesday, 2021-02-23 at 15:13:54 -08, Jim Mattson wrote:
> On Tue, Feb 23, 2021 at 2:51 PM Sean Christopherson wrote:
>>
>> On Fri, Feb 19, 2021, David Edmondson wrote:
>> > If the VM entry/exit controls for loading/saving MSR_EFER are either
>> > not
When deciding whether to dump the GUEST_IA32_EFER and GUEST_IA32_PAT
fields of the VMCS, examine only the VM entry load controls, as saving
on VM exit has no effect on whether VM entry succeeds or fails.
Suggested-by: Sean Christopherson
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx
t use GUEST_IA32_EFER to decide
whether to print the PDPTRs - always do so if the fields exist.
Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson
if valid
---
arch/x86/kvm/vmx/vmx.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git
Show EFER and PAT based on their individual entry/exit controls.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index ea1b3a671d51..90d677d72502
list if it's there (Paulo).
- Calculate and show the effective EFER if it is not coming from
either the VMCS or the MSR autoload list (Sean).
David Edmondson (5):
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
KVM: x86: dump_vmcs should not conflate EFER and PAT presence
If EFER is not being loaded from the VMCS, show the effective value by
reference to the MSR autoload list or calculation.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
When dumping the current VMCS state, include the MSRs that are being
automatically loaded/stored during VM entry/exit.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 25 +
arch/x86/kvm/vmx/vmx.h | 2 +-
2 files changed, 22 insertions(+), 5 deletions
When dumping the current VMCS state, include the MSRs that are being
automatically loaded/stored during VM entry/exit.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 25 +
arch/x86/kvm/vmx/vmx.h | 2 +-
2 files changed, 22 insertions(+), 5 deletions
Show EFER and PAT based on their individual entry/exit controls.
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 818051c9fa10..25090e3683ca
t use GUEST_IA32_EFER to decide
whether to print the PDPTRs - do so if the EPT is in use and CR4.PAE
is set.
Fixes: 4eb64dce8d0a ("KVM: x86: dump VMCS on invalid entry")
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff -
v2:
- Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo).
- Show EFER and PAT seperately, as appropriate.
- Dump the MSR autoload/autosave lists (Paolo).
David Edmondson (3):
KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid
KVM: x86: dump_vmcs sh
On Thursday, 2021-02-18 at 14:01:40 +01, Paolo Bonzini wrote:
> On 18/02/21 13:56, David Edmondson wrote:
>> On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote:
>>
>>> On 18/02/21 11:04, David Edmondson wrote:
>>>> When dumping the VMCS, retrieve
On Thursday, 2021-02-18 at 12:54:52 +01, Paolo Bonzini wrote:
> On 18/02/21 11:04, David Edmondson wrote:
>> When dumping the VMCS, retrieve the current guest value of EFER from
>> the kvm_vcpu structure if neither VM_EXIT_SAVE_IA32_EFER or
>> VM_ENTRY_LOAD_IA32_EFER is se
CS on invalid entry")
Signed-off-by: David Edmondson
---
arch/x86/kvm/vmx/vmx.c | 14 +-
arch/x86/kvm/vmx/vmx.h | 2 +-
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index eb69fef57485..74ea4fe6f35e 100644
--- a/arch/x
The instruction emulator ignores clflush instructions, yet fails to
support clflushopt. Treat both similarly.
Fixes: 13e457e0eebf ("KVM: x86: Emulator does not decode clflush well")
Signed-off-by: David Edmondson
---
arch/x86/kvm/emulate.c | 8 +++-
1 file changed, 7 insert
Use the FORCE_MULTI_INPUT class and quirk added in
commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk
for some devices")
to enable event reporting from both the trackpad and the
trackpoint/buttons in the Lenovo X1 Tab gen2.
Signed-off-by: David Edmondson
---
It se
On Thursday, 2020-06-04 at 22:15:42 -04, Yan Zhao wrote:
> On Thu, Jun 04, 2020 at 05:25:15PM +0200, Cornelia Huck wrote:
>> On Sun, 17 May 2020 22:49:44 -0400
>> Yan Zhao wrote:
>>
>> > This allows a simpler VFIO_DEVICE_GET_INFO ioctl in vendor driver
>> >
>> > Cc: Kevin Tian
>> > Signed-off-
42 matches
Mail list logo
