Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 22:09 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 03:21:49PM -0400, David Malcolm wrote: > > [Caveat: I'm a gcc developer, not a kernel expert] > > > > But it's not *quite* a global constant, or presumably you would be > >

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 20:40 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 09:48:33AM -0400, David Malcolm wrote: > > You tried __pure on arch_static_branch; did you try it on > > static_branch_unlikely? > > static_branch_unlikely() is a CPP macro that expands to a s

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 15:13 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 03:01:50PM +0200, Peter Zijlstra wrote: > > On Fri, Apr 09, 2021 at 02:03:46PM +0200, Peter Zijlstra wrote: > > > On Fri, Apr 09, 2021 at 07:55:42AM -0400, David Malcolm wrote: > > > &g

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 13:12 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 11:57:22AM +0200, Ard Biesheuvel wrote: > > On Thu, 8 Apr 2021 at 18:53, Peter Zijlstra > > wrote: > > > > Is there *any* way in which we can have the compiler recognise > > > that the > > > asm_goto only depends o

Re: [PATCH 05/11] perf parse-event: Fix memory leak in evsel->unit

2020-09-15 Thread David Malcolm
memory. > > There was a talk about GCC's -fanalyzer option doing malloc/free > checking at Linux plumbers 2 weeks ago: > https://linuxplumbersconf.org/event/7/contributions/721/attachments/542/961/2020-LPC-analyzer-talk.pdf > I added David Malcolm, the LPC presenter, as he may ha