Re: [PATCH][next] net: dsa: sja1105: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 13:10:07 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH][next] cxgb4: Use struct_size() helper

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 13:01:49 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH][next] net: stmmac: selftests: Use struct_size() in kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 12:41:54 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH][next] ethernet: ti: am65-cpsw-qos: Use struct_size() in devm_kzalloc()

2020-06-19 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 19 Jun 2020 12:37:15 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _size_. > > This code was detected with the help of Coccinelle and,

Re: [PATCH 1/1] net: ethernet: neterion: vxge: fix spelling mistake

2020-06-19 Thread David Miller
From: Flavio Suligoi Date: Fri, 19 Jun 2020 11:02:04 +0200 > Fix typo: "trigered" --> "triggered" > > Signed-off-by: Flavio Suligoi Applied.

Re: [PATCH 1/1] net: ethernet: oki-semi: pch_gbe: fix spelling mistake

2020-06-19 Thread David Miller
From: Flavio Suligoi Date: Fri, 19 Jun 2020 11:18:11 +0200 > Fix typo: "Triger" --> "Trigger" > > Signed-off-by: Flavio Suligoi Applied.

Re: [v2,net-next] net: qos offload add flow status with dropped count

2020-06-19 Thread David Miller
From: Po Liu Date: Fri, 19 Jun 2020 14:01:07 +0800 > From: Po Liu > > This patch adds a drop frames counter to tc flower offloading. > Reporting h/w dropped frames is necessary for some actions. > Some actions like police action and the coming introduced stream gate > action would produce

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread David Miller
From: Florian Fainelli Date: Wed, 17 Jun 2020 20:42:44 -0700 > of_find_node_by_name() will do an of_node_put() on the "from" argument. > With CONFIG_OF_DYNAMIC enabled which checks for device_node reference > counts, we would be getting a warning like this: ... > Fix this by adding a

Re: [PATCH 0/5] net: hns3: a bundle of minor cleanup and fixes

2020-06-18 Thread David Miller
From: Barry Song Date: Thu, 18 Jun 2020 13:02:06 +1200 > some minor changes to either improve the readability or make the code align > with linux APIs better. Series applied, thanks.

Re: [PATCH][next] mISDN: hfcsusb: Use struct_size() helper

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 17 Jun 2020 18:15:57 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH] lan743x: allow mac address to come from dt

2020-06-18 Thread David Miller
From: Tim Harvey Date: Wed, 17 Jun 2020 15:59:10 -0700 > If a valid mac address is present in dt, use that before using > CSR's or a random mac address. > > Signed-off-by: Tim Harvey Applied to net-next, thanks.

Re: [PATCH resend net] net: ethtool: add missing NETIF_F_GSO_FRAGLIST feature string

2020-06-18 Thread David Miller
From: Alexander Lobakin Date: Wed, 17 Jun 2020 20:42:47 + > Commit 3b33583265ed ("net: Add fraglist GRO/GSO feature flags") missed > an entry for NETIF_F_GSO_FRAGLIST in netdev_features_strings array. As > a result, fraglist GSO feature is not shown in 'ethtool -k' output and > can't be

Re: [PATCH][next] enetc: Use struct_size() helper in kzalloc()

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Wed, 17 Jun 2020 13:53:17 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH v2] tg3: driver sleeps indefinitely when EEH errors exceed eeh_max_freezes

2020-06-18 Thread David Miller
From: David Christensen Date: Wed, 17 Jun 2020 11:51:17 -0700 > The driver function tg3_io_error_detected() calls napi_disable twice, > without an intervening napi_enable, when the number of EEH errors exceeds > eeh_max_freezes, resulting in an indefinite sleep while holding rtnl_lock. > > Add

Re: [PATCH][next] net: stmmac: selftests: Use struct_size() helper in kzalloc()

2020-06-18 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 16 Jun 2020 18:03:28 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. > > This code was detected with the help of Coccinelle and, audited and > fixed manually. > >

Re: [PATCH v2 net 0/2] Reapply DSA fix for dpaa-eth with proper Fixes: tag

2020-06-18 Thread David Miller
From: Vladimir Oltean Date: Tue, 16 Jun 2020 18:19:08 +0300 > From: Vladimir Oltean > > Joakim notified me that this fix breaks stable trees. > It turns out that my assessment about who-broke-who was wrong. > The real Fixes: tag should have been: > > Fixes: 060ad66f9795 ("dpaa_eth: change DMA

Re: [PATCH 2/2] net: ethernet: mvneta: Add 2500BaseX support for SoCs without comphy

2020-06-18 Thread David Miller
From: Sascha Hauer Date: Tue, 16 Jun 2020 10:31:40 +0200 > The older SoCs like Armada XP support a 2500BaseX mode in the datasheets > referred to as DR-SGMII (Double rated SGMII) or HS-SGMII (High Speed > SGMII). This is an upclocked 1000BaseX mode, thus > PHY_INTERFACE_MODE_2500BASEX is the

Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-06-18 Thread David Miller
From: Sascha Hauer Date: Tue, 16 Jun 2020 10:31:39 +0200 > The MVNETA_SERDES_CFG register is only available on older SoCs like the > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > comphy. This patch moves the writes to this register next to the comphy > initialization, so

Re: [PATCH v1 3/6] serial: sunzilog: Return proper error code from console ->setup() hook

2020-06-18 Thread David Miller
From: Andy Shevchenko Date: Thu, 18 Jun 2020 19:47:48 +0300 > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: "David S. Miller" Acked-by: David S. Miller

Re: [PATCH v1 2/6] serial: sunsab: Return proper error code from console ->setup() hook

2020-06-18 Thread David Miller
From: Andy Shevchenko Date: Thu, 18 Jun 2020 19:47:47 +0300 > For unifying console ->setup() handling, which is pure documented, > return error code, rather than non-zero arbitrary number. > > Signed-off-by: Andy Shevchenko > Cc: "David S. Miller" Acked-by: David S. Miller

Re: [PATCH net] net: dsa: bcm_sf2: Fix node reference count

2020-06-18 Thread David Miller
From: Andrew Lunn Date: Thu, 18 Jun 2020 14:56:40 +0200 > That if_find_node_by_name() does a put is not very intuitive. > Maybe document that as well in the kerneldocs? > > Reviewed-by: Andrew Lunn I've been complaining about the non-intuitiveness of the various OF interfaces for a long time.

Re: [PATCH] [net/sched] Fix null pointer deref skb in tc_ctl_action

2020-06-18 Thread David Miller
From: Gaurav Singh Date: Wed, 17 Jun 2020 21:43:28 -0400 > Add null check for skb > > Signed-off-by: Gaurav Singh > --- > net/sched/act_api.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/sched/act_api.c b/net/sched/act_api.c > index

Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft

2020-06-18 Thread David Miller
From: Gaurav Singh Date: Thu, 18 Jun 2020 00:00:56 -0400 > parent cannot be NULL here since its in the else part > of the if (parent == NULL) condition. Remove the extra > check on parent pointer. > > Signed-off-by: Gaurav Singh > --- > net/sched/sch_api.c | 2 +- > 1 file changed, 1

Re: [PATCH][next] ethtool: ioctl: Use array_size() in copy_to_user()

2020-06-17 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 15 Jun 2020 18:01:07 -0500 > Use array_size() helper instead of the open-coded version in > copy_to_user(). These sorts of multiplication factors need to > be wrapped in array_size(). > > This issue was found with the help of Coccinelle and, audited and

Re: [PATCH] liquidio: Replace vmalloc_node + memset with vzalloc_node and use array_size

2020-06-17 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 15 Jun 2020 16:18:55 -0500 > Use vzalloc/vzalloc_node instead of the vmalloc/vzalloc_node and memset. > > Also, notice that vzalloc_node() function has no 2-factor argument form > to calculate the size for the allocation, so multiplication factors need >

[GIT] Networking

2020-06-16 Thread David Miller
1) Don't get per-cpu pointer with preemption enabled in nft_set_pipapo, fix from Stefano Brivio. 2) Fix memory leak in ctnetlink, from Pablo Neira Ayuso. 3) Multiple definitions of MPTCP_PM_MAX_ADDR, from Geliang Tang. 4) Accidently disabling NAPI in non-error paths of macb_open(), from

Re: [PATCH] lan743x: add MODULE_DEVICE_TABLE for module loading alias

2020-06-16 Thread David Miller
From: Tim Harvey Date: Tue, 16 Jun 2020 08:31:58 -0700 > Without a MODULE_DEVICE_TABLE the attributes are missing that create > an alias for auto-loading the module in userspace via hotplug. > > Signed-off-by: Tim Harvey Applied, thank you.

Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links

2020-06-15 Thread David Miller
From: Era Mayflower Date: Tue, 16 Jun 2020 00:41:14 +0900 > + if (tb_sa[MACSEC_SA_ATTR_PN]) { validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so you don't need to add this check here.

Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

2020-06-15 Thread David Miller
From: David Miller Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT) > Because you removed this devm_kzalloc() code, vsc8531 is never initialized. You also need to provide a proper header posting when you repost this series after fixing this bug.

Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

2020-06-15 Thread David Miller
From: Heiko Stuebner Date: Mon, 15 Jun 2020 16:44:59 +0200 > static int vsc8584_probe(struct phy_device *phydev) > { > struct vsc8531_private *vsc8531; > + int rc; > u32 default_mode[4] = {VSC8531_LINK_1000_ACTIVITY, > VSC8531_LINK_100_ACTIVITY, VSC8531_LINK_ACTIVITY,

Re: [PATCH net] net: dsa: sja1105: fix PTP timestamping with large tc-taprio cycles

2020-06-15 Thread David Miller
From: Vladimir Oltean Date: Sun, 14 Jun 2020 23:54:09 +0300 > From: Vladimir Oltean > > It isn't actually described clearly at all in UM10944.pdf, but on TX of > a management frame (such as PTP), this needs to happen: > > - The destination MAC address (i.e. 01-80-c2-00-00-0e), along with the

Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails

2020-06-15 Thread David Miller
From: Navid Emamdoost Date: Sun, 14 Jun 2020 00:38:01 -0500 > in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs, > fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of

Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-15 Thread David Miller
From: Navid Emamdoost Date: Sun, 14 Jun 2020 00:48:03 -0500 > in macb_mdio_write, macb_mdio_read, and at91ether_open, > pm_runtime_get_sync is called which increments the counter even in case of > failure, leading to incorrect ref count. > In case of failure, decrement the ref count before

Re: [PATCH] rocker: fix incorrect error handling in dma_rings_init

2020-06-15 Thread David Miller
From: Aditya Pakki Date: Fri, 12 Jun 2020 15:27:55 -0500 > In rocker_dma_rings_init, the goto blocks in case of errors > caused by the functions rocker_dma_cmd_ring_waits_alloc() and > rocker_dma_ring_create() are incorrect. The patch fixes the > order consistent with cleanup in

Re: [PATCH] test_objagg: Fix potential memory leak in error handling

2020-06-15 Thread David Miller
From: Aditya Pakki Date: Fri, 12 Jun 2020 15:01:54 -0500 > In case of failure of check_expect_hints_stats(), the resources > allocated by objagg_hints_get should be freed. The patch fixes > this issue. > > Signed-off-by: Aditya Pakki Applied.

Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-15 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 11 Jun 2020 16:01:39 +0200 > From: Bartosz Golaszewski > > During development we tried to make the interrupt handling as fine-grained > as possible with TX and RX interrupts being disabled/enabled independently > and the counter registers reset from

Re: [PATCH] mld: fix memory leak in ipv6_mc_destroy_dev()

2020-06-15 Thread David Miller
From: Wang Hai Date: Thu, 11 Jun 2020 15:57:50 +0800 > Commit a84d01647989 ("mld: fix memory leak in mld_del_delrec()") fixed > the memory leak of MLD, but missing the ipv6_mc_destroy_dev() path, in > which mca_sources are leaked after ma_put(). > > Using ip6_mc_clear_src() to take care of the

Re: [PATCH v2 net] MAINTAINERS: merge entries for felix and ocelot drivers

2020-06-15 Thread David Miller
From: Vladimir Oltean Date: Mon, 15 Jun 2020 19:42:44 +0300 > From: Vladimir Oltean > > The ocelot switchdev driver also provides a set of library functions for > the felix DSA driver, which in practice means that most of the patches > will be of interest to both groups of driver maintainers.

Re: [PATCH v2] net: alx: fix race condition in alx_remove

2020-06-15 Thread David Miller
From: Zekun Shen Date: Mon, 15 Jun 2020 11:50:29 -0400 > There is a race condition exist during termination. The path is > alx_stop and then alx_remove. An alx_schedule_link_check could be called > before alx_stop by interrupt handler and invoke alx_link_check later. > Alx_stop frees the napis,

Re: [PATCH] qlcnic: Use kobj_to_dev() instead

2020-06-15 Thread David Miller
From: Wang Qing Date: Mon, 15 Jun 2020 17:02:23 +0800 > Use kobj_to_dev() instead of container_of() > > Signed-off-by: Wang Qing Applied, thanks.

Re: [PATCH net-next v2] mptcp: use list_first_entry_or_null

2020-06-15 Thread David Miller
From: Geliang Tang Date: Mon, 15 Jun 2020 16:34:28 +0800 > Use list_first_entry_or_null to simplify the code. > > Signed-off-by: Geliang Tang Applied, thanks.

Re: [PATCH] net: axienet: fix spelling mistake in comment "Exteneded" -> "extended"

2020-06-15 Thread David Miller
From: Colin King Date: Mon, 15 Jun 2020 09:29:11 +0100 > From: Colin Ian King > > There is a spelling mistake in a comment. Fix it. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH net v2] mptcp: drop MPTCP_PM_MAX_ADDR

2020-06-15 Thread David Miller
From: Geliang Tang Date: Mon, 15 Jun 2020 16:28:03 +0800 > We have defined MPTCP_PM_ADDR_MAX in pm_netlink.c, so drop this duplicate > macro. > > Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface") > Signed-off-by: Geliang Tang > --- > Changes in v2: > - change Subject from "mptcp:

[GIT] Networking

2020-06-13 Thread David Miller
1) Fix cfg80211 deadlock, from Johannes Berg. 2) RXRPC fails to send norigications, from David Howells. 3) MPTCP RM_ADDR parsing has an off by one pointer error, fix from Geliang Tang. 4) Fix crash when using MSG_PEEK with sockmap, from Anny Hu. 5) The ucc_geth driver needs

Re: [PATCH] net: ethernet: ti: ale: fix allmulti for nu type ale

2020-06-13 Thread David Miller
From: Grygorii Strashko Date: Sat, 13 Jun 2020 17:54:14 +0300 > On AM65xx MCU CPSW2G NUSS and 66AK2E/L NUSS allmulti setting does not allow > unregistered mcast packets to pass. > > This happens, because ALE VLAN entries on these SoCs do not contain port > masks for reg/unreg mcast packets, but

Re: [PATCH] net: ethernet: ti: am65-cpsw-nuss: fix ale parameters init

2020-06-13 Thread David Miller
From: Grygorii Strashko Date: Sat, 13 Jun 2020 17:52:59 +0300 > The ALE parameters structure is created on stack, so it has to be reset > before passing to cpsw_ale_create() to avoid garbage values. > > Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth > subsystem

Re: [PATCH v3] net: atm: Remove the error message according to the atomic context

2020-06-13 Thread David Miller
From: Yi Wang Date: Sat, 13 Jun 2020 14:03:26 +0800 > From: Liao Pingfang > > Looking into the context (atomic!) and the error message should be dropped. > > Signed-off-by: Liao Pingfang > --- > Changes in v3: remove {} as there is only one statement left. Applied, thank you.

Re: [PATCH net v2 0/4] net: ipa: endpoint configuration fixes

2020-06-11 Thread David Miller
From: Alex Elder Date: Thu, 11 Jun 2020 14:48:29 -0500 > This series fixes four bugs in the configuration of IPA endpoints. > See the description of each for more information. > > In this version I have dropped the last patch from the series, and > restored a "static" keyword that had

Re: [PATCH v2 1/2] net: phy: mscc: move shared probe code into a helper

2020-06-11 Thread David Miller
From: Heiko Stuebner Date: Tue, 9 Jun 2020 15:31:39 +0200 > From: Heiko Stuebner > > The different probe functions share a lot of code, so move the > common parts into a helper to reduce duplication. > > Signed-off-by: Heiko Stuebner > --- > changes in v2: > - new patch as suggested by

Re: [PATCH net] rxrpc: Fix race between incoming ACK parser and retransmitter

2020-06-11 Thread David Miller
From: David Howells Date: Thu, 11 Jun 2020 21:57:00 +0100 > There's a race between the retransmission code and the received ACK parser. > The problem is that the retransmission loop has to drop the lock under > which it is iterating through the transmission buffer in order to transmit > a

Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling

2020-06-11 Thread David Miller
From: Bartosz Golaszewski Date: Thu, 11 Jun 2020 16:01:39 +0200 > Unfortunately after thorough testing of current mainline, we noticed the > driver has become unstable under heavy load. While this is hard to > reproduce, it's quite consistent in the driver's current form. Maybe you should work

Re: [PATCH] drivers: dpaa2: Use devm_kcalloc() in setup_dpni()

2020-06-11 Thread David Miller
From: Xu Wang Date: Thu, 11 Jun 2020 02:45:20 + > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang Applied, thanks.

Re: [PATCH v2] net: atm: Remove the error message according to the atomic context

2020-06-10 Thread David Miller
From: Yi Wang Date: Thu, 11 Jun 2020 08:38:50 +0800 > @@ -1537,7 +1537,6 @@ static struct lec_arp_table *make_entry(struct lec_priv > *priv, > > to_return = kzalloc(sizeof(struct lec_arp_table), GFP_ATOMIC); > if (!to_return) { > - pr_info("LEC: Arp entry kmalloc

Re: [PATCH v2 2/2] net: phy: mscc: handle the clkout control on some phy variants

2020-06-10 Thread David Miller
From: Heiko Stuebner Date: Tue, 9 Jun 2020 15:31:40 +0200 > From: Heiko Stuebner > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > a predefined rate of 25, 50 or 125MHz. > > This may then feed back into the network interface as source clock. > So follow the example

Re: [PATCH net 5/5] net: ipa: warn if gsi_trans structure is too big

2020-06-10 Thread David Miller
From: Alex Elder Date: Wed, 10 Jun 2020 14:53:32 -0500 > When the DEBUG_SPINLOCK and DEBUG_LOCK_ALLOC config options are > enabled, sizeof(raw_spinlock_t) grows considerably (from 4 bytes > to 56 bytes currently). As a consequence the size of the gsi_trans > structure exceeds 128 bytes, and

Re: [RFC PATCH v3 0/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-10 Thread David Miller
Please, when you post an RFC patch set, put "RFC" into the Subject lines of the patches as well as the introductory posting. This helps me categorize changes properly in patchwork. Thank you.

Re: [PATCH] net: cadence: macb: disable NAPI on error

2020-06-10 Thread David Miller
From: Corentin Labbe Date: Wed, 10 Jun 2020 09:53:44 + > When the PHY is not working, the macb driver crash on a second try to > setup it. > [ 78.545994] macb e000b000.ethernet eth0: Could not attach PHY (-19) ... > This is due to NAPI left enabled if macb_phylink_connect() fail. > >

Re: [PATCH] dccp: Fix possible memleak in dccp_init and dccp_fini

2020-06-09 Thread David Miller
From: Wang Hai Date: Tue, 9 Jun 2020 22:18:16 +0800 > There are some memory leaks in dccp_init() and dccp_fini(). > > In dccp_fini() and the error handling path in dccp_init(), free lhash2 > is missing. Add inet_hashinfo2_free_mod() to do it. > > If inet_hashinfo2_init_mod() failed in

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Kees Cook Date: Tue, 9 Jun 2020 12:49:48 -0700 > Okay, for now, how about: > > - If we're dealing with an existing spec, match the language. Yes. > - If we're dealing with a new spec, ask the authors to fix their language. Please be more specific about "new", if it's a passed and

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: "Williams, Dan J" Date: Tue, 9 Jun 2020 19:30:50 + > On Tue, 2020-06-09 at 11:36 -0700, David Miller wrote: >> From: Stephen Hemminger >> Date: Tue, 9 Jun 2020 10:19:35 -0700 >> >> > Yes, words do matter and convey a lot of implied connotati

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Kees Cook Date: Tue, 9 Jun 2020 12:29:54 -0700 > Given what I've seen from other communities and what I know of the kernel > community, I don't think we're going to get consensus on some massive > global search/replace any time soon. However, I think we can get started > on making this

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread David Miller
From: Stephen Hemminger Date: Tue, 9 Jun 2020 10:19:35 -0700 > Yes, words do matter and convey a lot of implied connotation and > meaning. What is your long term plan? Will you change all of the UAPI for bonding for example? Or will we have a partial solution to the problem?

Re: [PATCH net 0/2] rxrpc: Fix hang due to missing notification

2020-06-08 Thread David Miller
From: David Howells Date: Mon, 08 Jun 2020 19:49:47 +0100 > Here's a fix for AF_RXRPC. Occasionally calls hang because there are > circumstances in which rxrpc generate a notification when a call is > completed - primarily because initial packet transmission failed and the > call was killed off

Re: [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing

2020-06-08 Thread David Miller
From: Geliang Tang Date: Mon, 8 Jun 2020 18:47:54 +0800 > In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the > "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: > > +---+---+---+ > |Subtype|(resvd)| Address ID | >

Re: [PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error

2020-06-08 Thread David Miller
From: Heinrich Schuchardt Date: Mon, 8 Jun 2020 02:58:23 +0200 > When building without CONFIG_CHELSIO_TLS_DEVICE a build error occurs: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: error: > ‘cxgb4_uld_in_use’ defined but not used [-Werror=unused-function] > 666 | static bool

Re: [PATCH net-next 1/4] xfrm: bail early on slave pass over skb

2020-06-08 Thread David Miller
net-next is closed, thank you

[GIT] Networking

2020-06-07 Thread David Miller
I still haven't received from Johannes Berg a fix for the wireless shutdown issues you reported, but I will send that to you as soon as I have it. Meanwhile: 1) Fix the build with certain Kconfig combinations for the Chelsio inline TLS device, from Rohit Maheshwar and Vinay Kumar Yadavi.

[GIT] Sparc

2020-06-07 Thread David Miller
1) Rework the sparc32 page tables so that READ_ONCE(*pmd), as done by generic code, operates on a word sized element. From Will Deacon. 2) Some scnprintf() conversions, from Chen Zhou. 3) A pin_user_pages() conversion from John Hubbard. 4) Several 32-bit ptrace register handling fixes and

Re: [PATCH net v1] net: dsa: lantiq_gswip: fix and improve the unsupported interface error

2020-06-07 Thread David Miller
From: Martin Blumenstingl Date: Sun, 7 Jun 2020 15:02:58 +0200 > While trying to use the lantiq_gswip driver on one of my boards I made > a mistake when specifying the phy-mode (because the out-of-tree driver > wants phy-mode "gmii" or "mii" for the internal PHYs). In this case the > following

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread David Miller
From: Stephen Hemminger Date: Sun, 7 Jun 2020 15:30:19 -0700 > Open source projects have been working hard to remove the terms master and > slave > in API's and documentation. Apparently, Linux hasn't gotten the message. > It would make sense not to introduce new instances. Would you also be

Re: [git pull] a couple of sparc ptrace fixes

2020-06-07 Thread David Miller
From: Al Viro Date: Sun, 7 Jun 2020 15:41:52 +0100 > On Sun, May 31, 2020 at 02:04:14AM +0100, Al Viro wrote: >> The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: >> >> Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) >> >> are available in the git repository at: >> >>

Re: [PATCH] net/mlx5: Add a missing macro undefinition

2020-06-07 Thread David Miller
From: Hu Haowen Date: Sun, 7 Jun 2020 14:55:33 +0800 > > On 2020/6/7 2:36 PM, Leon Romanovsky wrote: >> On Sun, Jun 07, 2020 at 01:12:40PM +0800, Hu Haowen wrote: >>> The macro ODP_CAP_SET_MAX is only used in function >>> handle_hca_cap_odp() >>> in file main.c, so it should be undefined when

Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read

2020-06-06 Thread David Miller
From: Dan Murphy Date: Fri, 5 Jun 2020 15:51:03 -0500 > When the PHY's strap register is read to determine if lane swapping is > needed the phy_read_mmd returns the value back into the ret variable. > > If the call to read the strap fails the failed value is returned. If > the call to read the

Re: [PATCH] cxgb4: Use kfree() instead kvfree() where appropriate

2020-06-05 Thread David Miller
From: Denis Efremov Date: Fri, 5 Jun 2020 22:11:44 +0300 > Use kfree(buf) in blocked_fl_read() because the memory is allocated with > kzalloc(). Use kfree(t) in blocked_fl_write() because the memory is > allocated with kcalloc(). > > Signed-off-by: Denis Efremov Applied.

Re: [PATCH net] vsock/vmci: make vmci_vsock_transport_cb() static

2020-06-05 Thread David Miller
From: Stefano Garzarella Date: Fri, 5 Jun 2020 17:12:41 +0200 > Fix the following gcc-9.3 warning when building with 'make W=1': > net/vmw_vsock/vmci_transport.c:2058:6: warning: no previous prototype > for ‘vmci_vsock_transport_cb’ [-Wmissing-prototypes] > 2058 | void

Re: [PATCH] net: ethtool: Fix comment mentioning typo in IS_ENABLED()

2020-06-05 Thread David Miller
From: Kees Cook Date: Fri, 5 Jun 2020 07:21:22 -0700 > This has no code changes, but it's a typo noticed in other clean-ups, > so we might as well fix it. IS_ENABLED() takes full names, and should > have the "CONFIG_" prefix. > > Reported-by: Joe Perches > Link: >

Re: [PATCH net] net: phy: mscc: fix Serdes configuration in vsc8584_config_init

2020-06-05 Thread David Miller
From: Antoine Tenart Date: Fri, 5 Jun 2020 16:00:09 +0200 > When converting the MSCC PHY driver to shared PHY packages, the Serdes > configuration in vsc8584_config_init was modified to use 'base_addr' > instead of 'base' as the port number. But 'base_addr' isn't equal to > 'addr' for all PHYs

Re: [PATCH net 0/4] Fixes for OF_MDIO flag

2020-06-05 Thread David Miller
From: Dan Murphy Date: Fri, 5 Jun 2020 09:01:03 -0500 > There are some residual drivers that check the CONFIG_OF_MDIO flag using the > if defs. Using this check does not work when the OF_MDIO is configured as a > module. Using the IS_ENABLED macro checks if the flag is declared as built-in > or

Re: [PATCH net] net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

2020-06-05 Thread David Miller
From: Alexander Lobakin Date: Fri, 5 Jun 2020 15:53:24 +0300 > Commit ca23cb0bc50f ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero") > added headroom alignment check against 8. > Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not > aligned to cacheline size), it

Re: [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed

2020-06-04 Thread David Miller
From: Roelof Berg Date: Wed, 3 Jun 2020 23:54:14 +0200 > Corrected the MAC_CR configuration bits for 1 GBit operation. The data > sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but > only 10 works correctly. > > Devices tested: > Microchip Lan7431, fixed-phy mode > Microchip

Re: [PATCH v2 0/6] seqlock: seqcount_t call sites bugfixes

2020-06-04 Thread David Miller
From: "Ahmed S. Darwish" Date: Wed, 3 Jun 2020 16:49:43 +0200 > Since patch #7 and #8 from the series: > >[PATCH v1 00/25] seqlock: Extend seqcount API with associated locks > > https://lore.kernel.org/lkml/20200519214547.352050-1-a.darw...@linutronix.de > > are now pending on the

Re: [PATCH] yam: fix possible memory leak in yam_init_driver

2020-06-04 Thread David Miller
From: Wang Hai Date: Thu, 4 Jun 2020 20:18:51 +0800 > If register_netdev(dev) fails, free_netdev(dev) needs > to be called, otherwise a memory leak will occur. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied, thanks.

Re: [PATCH net] net: dsa: qca8k: Fix "Unexpected gfp" kernel exception

2020-06-04 Thread David Miller
From: Michal Vokáč Date: Wed, 3 Jun 2020 13:31:39 +0200 > Commit 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper") > replaced the dsa_switch_alloc helper by devm_kzalloc in all DSA > drivers. Unfortunately it introduced a typo in qca8k.c driver and > wrong argument is passed to the

Re: [net] seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds

2020-06-04 Thread David Miller
From: Ahmed Abdelsalam Date: Wed, 3 Jun 2020 06:54:42 + > The seg6_validate_srh() is used to validate SRH for three cases: > > case1: SRH of data-plane SRv6 packets to be processed by the Linux kernel. > Case2: SRH of the netlink message received from user-space (iproute2) > Case3: SRH

Re: [PATCH v3 00/10] net: eth: altera: tse: Add PTP and mSGDMA prefetcher

2020-06-04 Thread David Miller
From: "Ooi, Joyce" Date: Thu, 4 Jun 2020 15:32:46 +0800 > From: Joyce Ooi > > This patch series cleans up the Altera TSE driver and adds support > for the newer msgdma prefetcher as well as ptp support when using > the msgdma prefetcher. > > v2: Rename altera_ptp to intel_fpga_tod, modify

Re: [PATCH net-next 0/5] hinic: add some ethtool ops support

2020-06-03 Thread David Miller
net-next is closed

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-02 Thread David Miller
From: Jason Xing Date: Wed, 3 Jun 2020 09:53:10 +0800 > I'm sorry that I didn't write enough clearly. We're running the > pristine 4.19.125 linux kernel (the latest LTS version) and have been > haunted by such an issue. This patch is high-important, I think. So > I'm going to resend this email

Re: [git pull] a couple of sparc ptrace fixes

2020-06-02 Thread David Miller
From: Al Viro Date: Sun, 31 May 2020 02:04:14 +0100 > The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: > > Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git

Re: [PATCH 0/3] sparc32 SRMMU fixes for SMP

2020-06-02 Thread David Miller
From: Will Deacon Date: Tue, 26 May 2020 18:32:59 +0100 > Hi folks, > > Enabling SMP for sparc32 uncovered some issues in the SRMMU page-table > allocation code. One of these was introduced by me, but the other two > seem to have been there a while and are probably just exposed more > easily by

Re: [PATCH] sparc: remove unused header file nfs_fs.h

2020-06-02 Thread David Miller
From: Anupam Aggarwal Date: Fri, 29 May 2020 17:56:00 +0530 > Remove unused header file linux/nfs_fs.h > > Signed-off-by: Anupam Aggarwal > Signed-off-by: Vivek Trivedi > Signed-off-by: Amit Sahrawat Applied, thank you.

Re: [PATCH] net: stmmac: Drop condition with no effect

2020-06-02 Thread David Miller
From: Aishwarya Ramakrishnan Date: Tue, 2 Jun 2020 16:14:04 +0530 > As the "else if" and "else" branch body are identical the > condition has no effect. So removing "else if" condition. > > Signed-off-by: Aishwarya Ramakrishnan I'm not applying these patches, the conditional tests serve as

Re: [PATCH 12/15] amd-xgbe: use PCI_IRQ_MSI_TYPES where appropriate

2020-06-02 Thread David Miller
From: Piotr Stankiewicz Date: Tue, 2 Jun 2020 11:21:05 +0200 > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko Applied.

Re: [PATCH 13/15] aquantia: atlantic: use PCI_IRQ_ALL_TYPES where appropriate

2020-06-02 Thread David Miller
From: Piotr Stankiewicz Date: Tue, 2 Jun 2020 11:21:11 +0200 > Seeing as there is shorthand available to use when asking for any type > of interrupt, or any type of message signalled interrupt, leverage it. > > Signed-off-by: Piotr Stankiewicz > Reviewed-by: Andy Shevchenko Applied.

Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

2020-06-02 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 2 Jun 2020 10:23:09 +0300 > On 01/06/2020 21:06, David Miller wrote: >> From: patrickeigens...@gmail.com >> Date: Mon, 1 Jun 2020 13:12:01 +0200 >> >>> From: Patrick Eigensatz >>> >>> After allocating the spa

Re: [PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf()

2020-06-01 Thread David Miller
From: Jules Irenge Date: Mon, 1 Jun 2020 19:45:52 +0100 > Sparse reports a warning at efx_ef10_try_update_nic_stats_vf() > warning: context imbalance in efx_ef10_try_update_nic_stats_vf() > - unexpected unlock > The root cause is the missing annotation at >

Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-06-01 Thread David Miller
From: YueHaibing Date: Thu, 28 May 2020 22:34:07 +0800 > tipc_sendstream() may send zero length packet, then tipc_msg_append() > do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required > will trigger NULL pointer dereference. > > Reported-by:

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread David Miller
From: Victor Julien Date: Mon, 1 Jun 2020 22:49:37 +0200 > @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALID This flag indicates that at > least the transport > validated on the kernel side. If the flag is not set > then we are free to check the checksum

Re: [PATCH net-next] net: phy: broadcom: don't export RDB/legacy access methods

2020-06-01 Thread David Miller
From: Michael Walle Date: Sat, 30 May 2020 22:34:04 +0200 > Don't export __bcm_phy_enable_rdb_access() and > __bcm_phy_enable_legacy_access() functions. They aren't used outside this > module and it was forgotten to provide a prototype for these functions. > Just make them static for now. > >

Re: [PATCH net-next v2 0/3] bridge: mrp: Add support for MRA role

2020-06-01 Thread David Miller
From: Horatiu Vultur Date: Sat, 30 May 2020 18:09:45 + > This patch series extends the MRP with the MRA role. > A node that has the MRA role can behave as a MRM or as a MRC. In case there > are > multiple nodes in the topology that has the MRA role then only one node can > behave as MRM and

Re: [PATCH] net: vmxnet3: fix possible buffer overflow caused by bad DMA value in vmxnet3_get_rss()

2020-06-01 Thread David Miller
From: Jia-Ju Bai Date: Sat, 30 May 2020 10:41:50 +0800 > The value adapter->rss_conf is stored in DMA memory, and it is assigned > to rssConf, so rssConf->indTableSize can be modified at anytime by > malicious hardware. Because rssConf->indTableSize is assigned to n, > buffer overflow may occur

<    6   7   8   9   10   11   12   13   14   15   >