[GIT] Networking

2019-09-28 Thread David Miller
1) Sanity check URB networking device parameters to avoid divide by zero, from Oliver Neukum. 2) Disable global multicast filter in NCSI, otherwise LLDP and IPV6 don't work properly. Longer term this needs a better fix tho. From Vijay Khemka. 3) Small fixes to selftests (use ping when

Re: [PATCH v2] vsock/virtio: add support for MSG_PEEK

2019-09-27 Thread David Miller
This is net-next material.

Re: [PATCH] net: tap: clean up an indentation issue

2019-09-27 Thread David Miller
From: Colin King Date: Fri, 27 Sep 2019 10:40:39 +0100 > From: Colin Ian King > > There is a statement that is indented too deeply, remove > the extraneous tab. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH v3] nfp: abm: fix memory leak in nfp_abm_u32_knode_replace

2019-09-27 Thread David Miller
From: Navid Emamdoost Date: Thu, 26 Sep 2019 20:51:46 -0500 > In nfp_abm_u32_knode_replace if the allocation for match fails it should > go to the error handling instead of returning. Updated other gotos to > have correct errno returned, too. > > Signed-off-by: Navid Emamdoost Applied.

Re: [PATCH] net: ena: clean up indentation issue

2019-09-27 Thread David Miller
From: Colin King Date: Thu, 26 Sep 2019 12:22:52 +0100 > From: Colin Ian King > > There memset is indented incorrectly, remove the extraneous tabs. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] NFC: st95hf: clean up indentation issue

2019-09-27 Thread David Miller
From: Colin King Date: Thu, 26 Sep 2019 12:13:06 +0100 > From: Colin Ian King > > The return statement is indented incorrectly, add in a missing > tab and remove an extraneous space after the return > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: phy: micrel: add Asym Pause workaround for KSZ9021

2019-09-27 Thread David Miller
From: Hans Andersson Date: Thu, 26 Sep 2019 09:54:37 +0200 > From: Hans Andersson > > The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric > Pause capability is set. This issue is described in a Silicon Errata > (DS8691D or DS8692D), which advises to always disable th

Re: [PATCH net] net: socionext: ave: Avoid using netdev_err() before calling register_netdev()

2019-09-27 Thread David Miller
From: Kunihiko Hayashi Date: Thu, 26 Sep 2019 15:35:10 +0900 > Until calling register_netdev(), ndev->dev_name isn't specified, and > netdev_err() displays "(unnamed net_device)". > > ave 6500.ethernet (unnamed net_device) (uninitialized): invalid > phy-mode setting > ave: probe of

Re: [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs

2019-09-27 Thread David Miller
From: Navid Emamdoost Date: Wed, 25 Sep 2019 14:05:09 -0500 > In nfp_flower_spawn_vnic_reprs in the loop if initialization or the > allocations fail memory is leaked. Appropriate releases are added. > > Signed-off-by: Navid Emamdoost Applied.

Re: [PATCH] nfp: flower: prevent memory leak in nfp_flower_spawn_phy_reprs

2019-09-27 Thread David Miller
From: Navid Emamdoost Date: Wed, 25 Sep 2019 13:24:02 -0500 > In nfp_flower_spawn_phy_reprs, in the for loop over eth_tbl if any of > intermediate allocations or initializations fail memory is leaked. > requiered releases are added. > > Signed-off-by: Navid Emamdoost Applied.

Re: genetlink: prevent memory leak in netlbl_unlabel_defconf

2019-09-27 Thread David Miller
From: Paul Moore Date: Fri, 27 Sep 2019 10:48:54 -0400 > From what I've seen the "Fixes" tag is typically used by people who > are backporting patches, e.g. the -stable folks, to help decide what > they need to backport. Fixes: tags say what commit introduced the code being fixed, whether it man

Re: [PATCH] net/mlx5: prevent memory leak in mlx5_fpga_conn_create_cq

2019-09-27 Thread David Miller
From: Navid Emamdoost Date: Tue, 24 Sep 2019 22:20:34 -0500 > In mlx5_fpga_conn_create_cq if mlx5_vector2eqn fails the allocated > memory should be released. > > Signed-off-by: Navid Emamdoost Saeed, please queue this up.

Re: [PATCH net] of: mdio: Fix a signedness bug in of_phy_get_and_connect()

2019-09-27 Thread David Miller
From: Dan Carpenter Date: Wed, 25 Sep 2019 14:01:00 +0300 > The "iface" variable is an enum and in this context GCC treats it as > an unsigned int so the error handling is never triggered. > > Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect") > Signed-off-by: Dan Carp

Re: pull-request: wireless-drivers 2019-09-26

2019-09-27 Thread David Miller
From: Kalle Valo Date: Thu, 26 Sep 2019 15:57:33 +0300 > here's a pull request to net tree for v5.4. Please let me know if there > are any problems. Pulled, thanks Kalle.

Re: [PATCH v2] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-26 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 16:01:28 +0200 > Commit 7d9e5f422150 removed references from certain dsts, but accounting > for this never translated down into the fib6 suppression code. This bug > was triggered by WireGuard users who use wg-quick(8), which uses the > "suppress-

Re: [PATCH] net: print proper warning on dst underflow

2019-09-26 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 11:09:37 +0200 > Proper warnings with stack traces make it much easier to figure out > what's doing the double free and create more meaningful bug reports from > users. > > Signed-off-by: Jason A. Donenfeld Applied, thanks.

Re: [PATCH 1/1] MAINTAINERS: add Yanjun to FORCEDETH maintainers list

2019-09-25 Thread David Miller
From: rain.1986.08...@gmail.com Date: Mon, 23 Sep 2019 22:37:46 +0800 > From: Rain River > > Yanjun has been spending quite a lot of time fixing bugs > in FORCEDETH source code. I'd like to add Yanjun to maintainers > list. > > Signed-off-by: Rain River Applied, thank you.

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

2019-09-25 Thread David Miller
From: Ursula Braun Date: Wed, 25 Sep 2019 14:10:05 +0200 > we have to admit that it is already late for these patches. Nevertheless > we think it is better to come up with them now than never. We doubt there > exists already much userland code for it - except our own IBM-provided > package smc-to

Re: [PATCH net v2] net: stmmac: selftests: Flow Control test can also run with ASYM Pause

2019-09-25 Thread David Miller
From: Jose Abreu Date: Mon, 23 Sep 2019 09:49:08 +0200 > The Flow Control selftest is also available with ASYM Pause. Lets add > this check to the test and fix eventual false positive failures. > > Fixes: 091810dbded9 ("net: stmmac: Introduce selftests support") > Signed-off-by: Jose Abreu App

Re: [PATCH net] gianfar: Make reset_gfar static

2019-09-25 Thread David Miller
From: YueHaibing Date: Mon, 23 Sep 2019 14:16:03 +0800 > Fix sparse warning: > > drivers/net/ethernet/freescale/gianfar.c:2070:6: > warning: symbol 'reset_gfar' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Applied, thanks.

Re: [PATCH] atm: he: clean up an indentation issue

2019-09-25 Thread David Miller
From: Colin King Date: Sun, 22 Sep 2019 13:42:16 +0200 > From: Colin Ian King > > There is a statement that is indented one level too many, remove > the extraneous tab. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] hdlc: Simplify code in 'pvc_xmit()'

2019-09-25 Thread David Miller
From: Christophe JAILLET Date: Sat, 21 Sep 2019 08:17:38 +0200 > Use __skb_pad instead of rewriting it, this saves some LoC. > > Signed-off-by: Christophe JAILLET > --- > Compile tested only. Please test this code and resubmit for net-next, thank you.

Re: WireGuard to port to existing Crypto API

2019-09-25 Thread David Miller
From: Bruno Wolff III Date: Wed, 25 Sep 2019 04:17:00 -0500 > Are there going to be two branches, one for using the current API and > one using Zinc? This is inapproprate to even discuss at this point. Let's see what the crypto based stuff looks like, evaluate it, and then decide how to proceed

Re: WireGuard to port to existing Crypto API

2019-09-25 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 25 Sep 2019 10:29:45 +0200 > His viewpoint has recently solidified: in order to go upstream, > WireGuard must port to the existing crypto API, and handle the Zinc > project separately. I didn't say "must" anything, I suggested this as a more smoothe and effi

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

2019-09-24 Thread David Miller
From: Eugene Syromiatnikov Date: Fri, 20 Sep 2019 17:41:47 +0200 > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them

Re: [PATCH] dimlib: make DIMLIB a hidden symbol

2019-09-24 Thread David Miller
From: Uwe Kleine-König Date: Fri, 20 Sep 2019 15:31:15 +0200 > According to Tal Gilboa the only benefit from DIM comes from a driver > that uses it. So it doesn't make sense to make this symbol user visible, > instead all drivers that use it should select it (as is already the case > AFAICT). >

Re: [PATCH v3] bonding: force enable lacp port after link state recovery for 802.3ad

2019-09-24 Thread David Miller
From: Date: Wed, 18 Sep 2019 21:06:20 +0800 > From: Sha Zhang > > After the commit 334031219a84 ("bonding/802.3ad: fix slave link > initialization transition states") merged, > the slave's link status will be changed to BOND_LINK_FAIL > from BOND_LINK_DOWN in the following scenario: > - Driver

Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-24 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 14:55:04 +0200 > On Tue, Sep 24, 2019 at 2:53 PM David Miller wrote: >> Please make such test cases integratabe into the selftests area for >> networking >> and submit it along with this fix. > > That link

Re: [PATCH] ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule

2019-09-24 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 24 Sep 2019 09:36:15 +0200 > Commit 7d9e5f422150 removed references from certain dsts, but accounting > for this never translated down into the fib6 suppression code. This bug > was triggered by WireGuard users who use wg-quick(8), which uses the > "suppress-

Re: [PATCH v2 1/3] cifs: Add support for root file systems

2019-09-23 Thread David Miller
Please resubmit this series when the net-next tree opens back up, and also with an appropriate "[PATCH 0/N]" header posting explaining what the patch series is doing, how it is doing it, and why it is doing it that way. Thank you.

Re: [PATCH] selftests/net: replace AF_MAX with INT_MAX in socket.c

2019-09-23 Thread David Miller
From: Marcelo Henrique Cerri Date: Mon, 16 Sep 2019 12:03:37 -0300 > Use INT_MAX instead of AF_MAX, since libc might have a smaller value > of AF_MAX than the kernel, what causes the test to fail. > > Signed-off-by: Marcelo Henrique Cerri Definitely need to fix this differently.

Re: [PATCH v8 1/7] nfc: pn533: i2c: "pn532" as dt compatible string

2019-09-19 Thread David Miller
As we are in the merge window, the net-next tree is closed, as shown also at: http://vger.kernel.org/~davem/net-next.html Please resubmit this after the merge window when the net-next tree opens back up. Please also provide an appropriate "[PATCH 0/N]" header posting explaining what th

Re: [GIT] Networking

2019-09-19 Thread David Miller
From: Linus Torvalds Date: Wed, 18 Sep 2019 13:37:57 -0700 > Hmm. This adds that NET_TC_SKB_EXT config thing, and makes it "default y". > > Why? > > It's also done in a crazy way: > > + depends on NET_CLS_ACT > + default y if NET_CLS_ACT I agree. I've asked Paul Blakey, who added

Re: [GIT] Networking

2019-09-19 Thread David Miller
From: Linus Torvalds Date: Wed, 18 Sep 2019 13:37:57 -0700 > I've obviously already pulled this (and only noticed when I was > testing further on my laptop), but please explain or fix. I'll take a look, thanks.

Re: [PATCH v3] net: dsa: sja1105: prevent leaking memory

2019-09-19 Thread David Miller
From: Navid Emamdoost Date: Wed, 18 Sep 2019 15:34:06 -0500 > Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port > L2 switch") > > Fixes: 1a4c69406cc1 ("net: dsa: sja1105: Prevent PHY jabbering during > switch reset") Please: 1) Do not break Fixes: tags into multiples line

Re: [PATCH v2] net: dsa: sja1105: prevent leaking memory

2019-09-19 Thread David Miller
From: Vladimir Oltean Date: Wed, 18 Sep 2019 23:00:20 +0300 > Hi Navid, > > Thanks for the patch. > > On 9/18/19 9:04 PM, Navid Emamdoost wrote: >> In sja1105_static_config_upload, in two cases memory is leaked: when >> static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx >> f

Re: [PATCH v5 0/2] ethtool: implement Energy Detect Powerdown support via phy-tunable

2019-09-16 Thread David Miller
From: Alexandru Ardelean Date: Mon, 16 Sep 2019 10:35:24 +0300 > This changeset proposes a new control for PHY tunable to control Energy > Detect Power Down. > > The `phy_tunable_id` has been named `ETHTOOL_PHY_EDPD` since it looks like > this feature is common across other PHYs (like EEE), and

Re: [PATCH 1/1] xen-netfront: do not assume sk_buff_head list is empty in error handling

2019-09-16 Thread David Miller
From: Dongli Zhang Date: Mon, 16 Sep 2019 11:46:59 +0800 > When skb_shinfo(skb) is not able to cache extra fragment (that is, > skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS), xennet_fill_frags() assumes > the sk_buff_head list is already empty. As a result, cons is increased only > by 1 and returns

Re: [PATCH v3] net: stmmac: socfpga: re-use the `interface` parameter from platform data

2019-09-16 Thread David Miller
From: Alexandru Ardelean Date: Mon, 16 Sep 2019 10:04:00 +0300 > The socfpga sub-driver defines an `interface` field in the `socfpga_dwmac` > struct and parses it on init. > > The shared `stmmac_probe_config_dt()` function also parses this from the > device-tree and makes it available on the ret

Re: [PATCH 1/1] MAINTAINERS: update FORCEDETH MAINTAINERS info

2019-09-16 Thread David Miller
From: rain.1986.08...@gmail.com Date: Fri, 13 Sep 2019 21:43:45 +0800 > From: Rain River > > Many FORCEDETH NICs are used in our hosts. Several bugs are fixed and > some features are developed for FORCEDETH NICs. And I have been > reviewing patches for FORCEDETH NIC for several months. Mark me a

Re: [PATCH net] net: stmmac: Hold rtnl lock in suspend/resume callbacks

2019-09-16 Thread David Miller
From: Jose Abreu Date: Fri, 13 Sep 2019 11:50:32 +0200 > We need to hold rnl lock in suspend and resume callbacks because phylink > requires it. Otherwise we will get a WARN() in suspend and resume. > > Also, move phylink start and stop callbacks to inside device's internal > lock so that we pre

Re: [PATCH] qed: fix spelling mistake "fullill" -> "fulfill"

2019-09-16 Thread David Miller
From: Colin King Date: Fri, 13 Sep 2019 10:07:59 +0100 > From: Colin Ian King > > There is a spelling mistake in a DP_VERBOSE debug message. Fix it. > (Using American English spelling as this is the most common way > to spell this in the kernel). > > Signed-off-by: Colin Ian King Applied to

Re: [PATCH net-next] net: dsa: b53: Add support for port_egress_floods callback

2019-09-16 Thread David Miller
From: Florian Fainelli Date: Thu, 12 Sep 2019 20:28:39 -0700 > Add support for configuring the per-port egress flooding control for > both Unicast and Multicast traffic. > > Signed-off-by: Florian Fainelli Applied with comment typo fixed.

Re: [PATCH] net/mlx5: Remove unneeded variable in mlx5_unload_one

2019-09-15 Thread David Miller
From: zhong jiang Date: Fri, 13 Sep 2019 00:59:02 +0800 > mlx5_unload_one do not need local variable to store different value, > Hence just remove it. > > Signed-off-by: zhong jiang Saeed, just take this directly via one of your trees. Thank you.

Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter from platform data

2019-09-15 Thread David Miller
From: Alexandru Ardelean Date: Thu, 12 Sep 2019 16:28:50 +0300 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > index c141fe783e87..5b6213207c43 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/

Re: pull-request: wireless-drivers-next 2019-09-14

2019-09-15 Thread David Miller
From: Kalle Valo Date: Sun, 15 Sep 2019 13:32:49 +0300 > David Miller writes: > >> From: Kalle Valo >> Date: Sat, 14 Sep 2019 13:14:40 +0300 >> >>> here's a pull request to net-next tree for v5.4, more info below. Please >>> let me know if the

Re: pull-request: wireless-drivers-next 2019-09-14

2019-09-14 Thread David Miller
From: Kalle Valo Date: Sat, 14 Sep 2019 13:14:40 +0300 > here's a pull request to net-next tree for v5.4, more info below. Please > let me know if there are any problems. Pulled, thanks Kalle.

[GIT] Networking

2019-09-13 Thread David Miller
1) Don't corrupt xfrm_interface parms before validation, from Nicolas Dichtel. 2) Revert use of usb-wakeup in btusb, from Mario Limonciello. 3) Block ipv6 packets in bridge netfilter if ipv6 is disabled, from Leonardo Bras. 4) IPS_OFFLOAD not honored in ctnetlink, from Pablo Neira Ayuso.

Re: [PATCH v2 net 0/3] fix memory leak for sctp_do_bind

2019-09-13 Thread David Miller
From: Mao Wenan Date: Thu, 12 Sep 2019 12:02:16 +0800 > First two patches are to do cleanup, remove redundant assignment, > and change return type of sctp_get_port_local. > Third patch is to fix memory leak for sctp_do_bind if failed > to bind address. > > --- > v2: add one patch to change retu

Re: [PATCH][PATCH net-next] hv_sock: Add the support of hibernation

2019-09-13 Thread David Miller
From: Dexuan Cui Date: Wed, 11 Sep 2019 23:37:27 + > Add the necessary dummy callbacks for hibernation. > > Signed-off-by: Dexuan Cui > --- > This patch is basically a pure Hyper-V specific change and it has a > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus: Implement > s

Re: [PATCH v4 2/2] PTP: add support for one-shot output

2019-09-13 Thread David Miller
From: Felipe Balbi Date: Wed, 11 Sep 2019 09:16:22 +0300 > Some controllers allow for a one-shot output pulse, in contrast to > periodic output. Now that we have extensible versions of our IOCTLs, we > can finally make use of the 'flags' field to pass a bit telling driver > that if we want one-sh

Re: [PATCH v4 1/2] PTP: introduce new versions of IOCTLs

2019-09-13 Thread David Miller
From: Felipe Balbi Date: Wed, 11 Sep 2019 09:16:21 +0300 > The current version of the IOCTL have a small problem which prevents us > from extending the API by making use of reserved fields. In these new > IOCTLs, we are now making sure that flags and rsv fields are zero which > will allow us to e

Re: [PATCH v4 2/2] PTP: add support for one-shot output

2019-09-12 Thread David Miller
From: Richard Cochran Date: Thu, 12 Sep 2019 09:56:09 -0700 > On Wed, Sep 11, 2019 at 09:16:22AM +0300, Felipe Balbi wrote: >> Some controllers allow for a one-shot output pulse, in contrast to >> periodic output. Now that we have extensible versions of our IOCTLs, we >> can finally make use of t

Re: [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()'

2019-09-12 Thread David Miller
From: Christophe JAILLET Date: Wed, 11 Sep 2019 18:02:39 +0200 > The '.exit' functions from 'pernet_operations' structure should be marked > as __net_exit, not __net_init. > > Fixes: 8e2d61e0aed2 ("sctp: fix race on protocol/netns initialization") > Signed-off-by: Christophe JAILLET Applied an

Re: [PATCH] cxgb4: Fix spelling typos

2019-09-12 Thread David Miller
From: Arkadiusz Drabczyk Date: Tue, 10 Sep 2019 22:49:01 +0200 > Fix several spelling typos in comments in t4_hw.c. > > Signed-off-by: Arkadiusz Drabczyk Applied to net-next.

Re: [PATCH v2] net: qrtr: fix memort leak in qrtr_tun_write_iter

2019-09-12 Thread David Miller
From: Navid Emamdoost Date: Wed, 11 Sep 2019 10:09:02 -0500 > In qrtr_tun_write_iter the allocated kbuf should be release in case of > error or success return. > > v2 Update: Thanks to David Miller for pointing out the release on success > path as well. > > Signed-of

Re: [PATCH net-next v2 0/3] add ksz9567 with I2C support to ksz9477 driver

2019-09-12 Thread David Miller
From: George McCollister Date: Tue, 10 Sep 2019 08:18:33 -0500 > Resurrect KSZ9477 I2C driver support patch originally sent to the list > by Tristram Ha and resolve outstanding issues. It now works as similarly to > the ksz9477 SPI driver as possible, using the same regmap macros. > > Add suppor

Re: [PATCH] ipv6: Fix the link time qualifier of 'ping_v6_proc_exit_net()'

2019-09-12 Thread David Miller
From: Christophe JAILLET Date: Tue, 10 Sep 2019 13:29:59 +0200 > The '.exit' functions from 'pernet_operations' structure should be marked > as __net_exit, not __net_init. > > Fixes: d862e5461423 ("net: ipv6: Implement /proc/net/icmp6.") > Signed-off-by: Christophe JAILLET > --- > Untested, but

Re: [PATCH net-next] net: stmmac: pci: Add HAPS support using GMAC5

2019-09-11 Thread David Miller
From: Jose Abreu Date: Mon, 9 Sep 2019 18:54:26 +0200 > Add the support for Synopsys HAPS board that uses GMAC5. > > Signed-off-by: Jose Abreu Applied.

Re: [PATCH v4 2/2] net: phy: dp83867: Add SGMII mode type switching

2019-09-11 Thread David Miller
From: Vitaly Gaiduk Date: Mon, 9 Sep 2019 20:19:24 +0300 > This patch adds ability to switch beetween two PHY SGMII modes. > Some hardware, for example, FPGA IP designs may use 6-wire mode > which enables differential SGMII clock to MAC. > > Signed-off-by: Vitaly Gaiduk Applied.

Re: [PATCH v4 1/2] net: phy: dp83867: Add documentation for SGMII mode type

2019-09-11 Thread David Miller
From: Vitaly Gaiduk Date: Mon, 9 Sep 2019 20:19:25 +0300 > Add documentation of ti,sgmii-ref-clock-output-enable > which can be used to select SGMII mode type (4 or 6-wire). > > Signed-off-by: Vitaly Gaiduk Applied.

Re: [PATCH 2/2] dt-bindings: net: dwmac: document 'mac-mode' property

2019-09-11 Thread David Miller
From: Alexandru Ardelean Date: Fri, 6 Sep 2019 16:02:56 +0300 > This change documents the 'mac-mode' property that was introduced in the > 'stmmac' driver to support passive mode converters that can sit in-between > the MAC & PHY. > > Signed-off-by: Alexandru Ardelean Applied to net-next.

Re: [PATCH 1/2] net: stmmac: implement support for passive mode converters via dt

2019-09-11 Thread David Miller
From: Alexandru Ardelean Date: Fri, 6 Sep 2019 16:02:55 +0300 > In-between the MAC & PHY there can be a mode converter, which converts one > mode to another (e.g. GMII-to-RGMII). > > The converter, can be passive (i.e. no driver or OS/SW information > required), so the MAC & PHY need to be confi

Re: [PATCH] mlx4: fix spelling mistake "veify" -> "verify"

2019-09-11 Thread David Miller
From: Colin King Date: Wed, 11 Sep 2019 15:18:11 +0100 > From: Colin Ian King > > There is a spelling mistake in a mlx4_err error message. Fix it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: hns3: fix spelling mistake "undeflow" -> "underflow"

2019-09-11 Thread David Miller
From: Colin King Date: Wed, 11 Sep 2019 15:08:16 +0100 > From: Colin Ian King > > There is a spelling mistake in a .msg literal string. Fix it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: lmc: fix spelling mistake "runnin" -> "running"

2019-09-11 Thread David Miller
From: Colin King Date: Wed, 11 Sep 2019 12:37:34 +0100 > From: Colin Ian King > > There is a spelling mistake in the lmc_trace message. Fix it. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH] NFC: st95hf: fix spelling mistake "receieve" -> "receive"

2019-09-11 Thread David Miller
From: Colin King Date: Wed, 11 Sep 2019 11:38:48 +0100 > From: Colin Ian King > > There is a spelling mistake in a dev_err message. Fix it. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] lib/Kconfig: fix OBJAGG in lib/ menu structure

2019-09-11 Thread David Miller
From: Randy Dunlap Date: Mon, 9 Sep 2019 14:54:21 -0700 > From: Randy Dunlap > > Keep the "Library routines" menu intact by moving OBJAGG into it. > Otherwise OBJAGG is displayed/presented as an orphan in the > various config menus. > > Fixes: 0a020d416d0a ("lib: introduce initial implementati

Re: [PATCH net-next 0/6] net: stmmac: Improvements for -next

2019-09-11 Thread David Miller
From: Jose Abreu Date: Tue, 10 Sep 2019 16:41:21 +0200 > Misc patches for -next. It includes: > - Two fixes for features in -next only > - New features support for GMAC cores (which includes GMAC4 and GMAC5) Series applied, but what exactly does "ARP offload" even do?

Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability

2019-09-11 Thread David Miller
From: Lars Poeschel Date: Tue, 10 Sep 2019 11:34:12 +0200 > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg, > +struct sk_buff *resp) > +{ > + u8 nbtg; > + int rc; > + struct pn532_autopoll_resp *apr; > + struct nfc_target nfc_tgt; Nee

Re: [PATCH v7 5/7] nfc: pn533: add UART phy driver

2019-09-11 Thread David Miller
From: Lars Poeschel Date: Tue, 10 Sep 2019 11:33:50 +0200 > +static int pn532_uart_send_ack(struct pn533 *dev, gfp_t flags) > +{ > + struct pn532_uart_phy *pn532 = dev->phy; > + /* spec 7.1.1.3: Preamble, SoPC (2), ACK Code (2), Postamble */ > + static const u8 ack[PN533_STD_FRAME_AC

Re: [PATCH v2 net] net: sonic: replace dev_kfree_skb in sonic_send_packet

2019-09-11 Thread David Miller
From: Mao Wenan Date: Wed, 11 Sep 2019 09:36:23 +0800 > sonic_send_packet will be processed in irq or non-irq > context, so it would better use dev_kfree_skb_any > instead of dev_kfree_skb. > > Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National > Semi-conductor drivers") > Signed-

Re: [PATCH] net: qrtr: fix memort leak in qrtr_tun_write_iter

2019-09-11 Thread David Miller
From: Navid Emamdoost Date: Tue, 10 Sep 2019 19:37:45 -0500 > In qrtr_tun_write_iter the allocated kbuf should be release in case of > error happening. > > Signed-off-by: Navid Emamdoost Shouldn't it also be freed in case of success too?

Re: [PATCH] wimax: i2400: fix memory leak

2019-09-11 Thread David Miller
From: Navid Emamdoost Date: Tue, 10 Sep 2019 18:01:40 -0500 > In i2400m_op_rfkill_sw_toggle cmd buffer should be released along with > skb response. > > Signed-off-by: Navid Emamdoost Applied. Good thing nobody uses wimax.

Re: [PATCH V2 net-next 0/7] net: hns3: add a feature & bugfixes & cleanups

2019-09-11 Thread David Miller
From: Huazhong Tan Date: Wed, 11 Sep 2019 10:40:32 +0800 > This patch-set includes a VF feature, bugfixes and cleanups for the HNS3 > ethernet controller driver. Series applied.

Re: [PATCH] net: Remove the source address setting in connect() for UDP

2019-09-11 Thread David Miller
From: "Enke Chen (enkechen)" Date: Tue, 10 Sep 2019 23:55:59 + > Do you still have concerns about backward compatibility of the fix? I'm not convinced by your arguments and I am also completely swamped at LPC2019 running the networking track this week.

Re: [PATCH net-next 1/7] net: hns3: add ethtool_ops.set_channels support for HNS3 VF driver

2019-09-10 Thread David Miller
From: Huazhong Tan Date: Tue, 10 Sep 2019 16:58:22 +0800 > + /* Set to user value, no larger than max_rss_size. */ > + if (kinfo->req_rss_size != kinfo->rss_size && kinfo->req_rss_size && > + kinfo->req_rss_size <= max_rss_size) { > + dev_info(&hdev->pdev->dev, "rss ch

Re: [PATCH 1/1] MAINTAINERS: update FORCEDETH MAINTAINERS info

2019-09-10 Thread David Miller
From: rain.1986.08...@gmail.com Date: Sat, 7 Sep 2019 16:14:46 +0800 > From: Rain River > > Many FORCEDETH NICs are used in our hosts. Several bugs are fixed and > some features are developed for FORCEDETH NICs. And I have been > reviewing patches for FORCEDETH NIC for several months. Mark me a

Re: [PATCH] net: stmmac: socfpga: re-use the `interface` parameter from platform data

2019-09-10 Thread David Miller
From: David Miller Date: Tue, 10 Sep 2019 17:45:44 +0200 (CEST) > From: Alexandru Ardelean > Date: Fri, 6 Sep 2019 15:30:54 +0300 > >> The socfpga sub-driver defines an `interface` field in the `socfpga_dwmac` >> struct and parses it on init. >> >> T

Re: [PATCH] net: stmmac: socfpga: re-use the `interface` parameter from platform data

2019-09-10 Thread David Miller
From: Alexandru Ardelean Date: Fri, 6 Sep 2019 15:30:54 +0300 > The socfpga sub-driver defines an `interface` field in the `socfpga_dwmac` > struct and parses it on init. > > The shared `stmmac_probe_config_dt()` function also parses this from the > device-tree and makes it available on the retu

Re: [PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller

2019-09-10 Thread David Miller
From: Colin King Date: Fri, 6 Sep 2019 12:53:48 +0100 > From: Colin Ian King > > Don't populate the array modes on the stack but instead make it > static const. Makes the object code smaller by 303 bytes. > > Before: >text data bss dec hex filename > 51240

Re: [PATCH] tcp: fix tcp_disconnect() not clear tp->fastopen_rsk sometimes

2019-09-10 Thread David Miller
From: chunguo feng Date: Fri, 6 Sep 2019 17:34:29 +0800 > From: fengchunguo > > This patch avoids fastopen_rsk not be cleared every times, then occur > the below BUG_ON: > tcp_v4_destroy_sock > ->BUG_ON(tp->fastopen_rsk); > > When playback some videos from netwrok,used tcp_disconnect co

Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset

2019-09-10 Thread David Miller
From: Michal Suchanek Date: Mon, 9 Sep 2019 22:44:51 +0200 > Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from > queue") > adds a } without corresponding { causing build break. > > Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from > queue") > Si

Re: [PATCH] net: hns3: make array spec_opcode static const, makes object smaller

2019-09-07 Thread David Miller
From: Colin King Date: Fri, 6 Sep 2019 12:28:04 +0100 > From: Colin Ian King > > Don't populate the array spec_opcode on the stack but instead make it > static const. Makes the object code smaller by 48 bytes. > > Before: >text data bss dec hex filename >6914

Re: [PATCH] be2net: make two arrays static const, makes object smaller

2019-09-07 Thread David Miller
From: Colin King Date: Fri, 6 Sep 2019 12:19:43 +0100 > From: Colin Ian King > > Don't populate the arrays on the stack but instead make them > static const. Makes the object code smaller by 281 bytes. > > Before: >text data bss dec hex filename > 87553 567

Re: [PATCH net-next 0/5] net: stmmac: Improvements and fixes for -next

2019-09-07 Thread David Miller
From: Jose Abreu Date: Fri, 6 Sep 2019 09:41:12 +0200 > Improvements and fixes for recently introduced features. All for -next tree. > More info in commit logs. Series applied, thanks.

Re: [PATCH net-next,v2, 0/2] Enable sg as tunable, sync offload settings to VF NIC

2019-09-07 Thread David Miller
From: Haiyang Zhang Date: Thu, 5 Sep 2019 23:22:58 + > This patch set fixes an issue in SG tuning, and sync > offload settings from synthetic NIC to VF NIC. Series applied to net-next.

Re: [PATCH] net: phylink: Fix flow control resolution

2019-09-07 Thread David Miller
From: Date: Thu, 5 Sep 2019 19:46:18 +0300 > From: Stefan Chulski > > Regarding to IEEE 802.3-2015 standard section 2 > 28B.3 Priority resolution - Table 28-3 - Pause resolution > > In case of Local device Pause=1 AsymDir=0, Link partner > Pause=1 AsymDir=1, Local device resolution should be e

Re: [PATCH 1/2] net: phy: dp83867: Add documentation for SGMII mode type

2019-09-07 Thread David Miller
From: Vitaly Gaiduk Date: Thu, 5 Sep 2019 19:26:00 +0300 > + - ti,sgmii-type - This denotes the fact which SGMII mode is used (4 or > 6-wire). You need to document this more sufficiently as per Andrew's feedback.

Re: [PATCH] ethernet: micrel: Use DIV_ROUND_CLOSEST directly to make it readable

2019-09-07 Thread David Miller
From: zhong jiang Date: Thu, 5 Sep 2019 23:53:48 +0800 > The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d > but is perhaps more readable. > > Signed-off-by: zhong jiang Applied to net-next.

Re: [PATCH v3] ipv6: Not to probe neighbourless routes

2019-09-07 Thread David Miller
From: Cheng Lin Date: Fri, 30 Aug 2019 14:11:16 +0800 > Originally, Router Reachability Probing require a neighbour entry > existed. Commit 2152caea7196 ("ipv6: Do not depend on rt->n in > rt6_probe().") removed the requirement for a neighbour entry. And > commit f547fac624be ("ipv6: rate-limit p

Re: pull-request: wireless-drivers-next 2019-09-07

2019-09-07 Thread David Miller
From: Kalle Valo Date: Sat, 07 Sep 2019 11:01:15 +0300 > here's a pull request to net-next for v5.4, more info below. Please let > me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH] lan743x: remove redundant assignment to variable rx_process_result

2019-09-06 Thread David Miller
From: Colin King Date: Thu, 5 Sep 2019 15:01:35 +0100 > From: Colin Ian King > > The variable rx_process_result is being initialized with a value that > is never read and is being re-assigned immediately afterwards. The > assignment is redundant, so replace it with the return from function > l

Re: pull-request: wireless-drivers 2019-09-05

2019-09-06 Thread David Miller
From: Kalle Valo Date: Thu, 05 Sep 2019 16:58:01 +0300 > here's a pull request to net tree for v5.3, more info below. Please let > me know if there are any problems. Pulled, thanks Kalle.

Re: [PATCH V2 net-next 0/7] net: hns3: add some bugfixes and cleanups

2019-09-06 Thread David Miller
From: Huazhong Tan Date: Thu, 5 Sep 2019 21:31:35 +0800 > This patch-set includes bugfixes and cleanups for the HNS3 > ethernet controller driver. ... Series applied to net-next

Re: [PATCH net-next] MAINTAINERS: add myself as maintainer for xilinx axiethernet driver

2019-09-06 Thread David Miller
From: Radhey Shyam Pandey Date: Thu, 5 Sep 2019 18:26:08 +0530 > I am maintaining xilinx axiethernet driver in xilinx tree and would like > to maintain it in the mainline kernel as well. Hence adding myself as a > maintainer. Also Anirudha and John has moved to new roles, so based on > request r

Re: [PATCH 0/2] Revert and rework on the metadata accelreation

2019-09-06 Thread David Miller
From: Jason Wang Date: Fri, 6 Sep 2019 18:02:35 +0800 > On 2019/9/5 下午9:59, Jason Gunthorpe wrote: >> I think you should apply the revert this cycle and rebase the other >> patch for next.. >> >> Jason > > Yes, the plan is to revert in this release cycle. Then you should reset patch #1 all by i

Re: [PATCH net-next] net: phy: Do not check Link status when loopback is enabled

2019-09-06 Thread David Miller
From: Jose Abreu Date: Thu, 5 Sep 2019 13:43:10 +0200 > While running stmmac selftests I found that in my 1G setup some tests > were failling when running with PHY loopback enabled. > > It looks like when loopback is enabled the PHY will report that Link is > down even though there is a valid c

Re: [PATCH v2 net] net: sonic: return NETDEV_TX_OK if failed to map buffer

2019-09-06 Thread David Miller
From: Mao Wenan Date: Thu, 5 Sep 2019 09:57:12 +0800 > NETDEV_TX_BUSY really should only be used by drivers that call > netif_tx_stop_queue() at the wrong moment. If dma_map_single() is > failed to map tx DMA buffer, it might trigger an infinite loop. > This patch use NETDEV_TX_OK instead of NETD

Re: [v3] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate

2019-09-06 Thread David Miller
From: David Dai Date: Wed, 4 Sep 2019 10:03:43 -0500 > For high speed adapter like Mellanox CX-5 card, it can reach upto > 100 Gbits per second bandwidth. Currently htb already supports 64bit rate > in tc utility. However police action rate and peakrate are still limited > to 32bit value (upto 3

<    11   12   13   14   15   16   17   18   19   20   >