Re: [PATCH] epic100: switch from 'pci_' to 'dma_' API

2020-08-20 Thread David Miller
From: Christophe JAILLET Date: Thu, 20 Aug 2020 18:28:25 +0200 > should I resend the few conversion patches sent at the wrong time or > are they stored somewhere, and will be processed when some time is > available for it? Please resend, thank you.

Re: [PATCH] net: phy: mscc: Fix a couple of spelling mistakes "spcified" -> "specified"

2020-08-20 Thread David Miller
From: Kaige Li Date: Thu, 20 Aug 2020 14:47:55 +0800 > There are a couple of spelling mistakes in comment text. Fix these. > > Signed-off-by: Kaige Li Applied.

Re: [PATCH net v2] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-19 Thread David Miller
From: Wang Hai Date: Wed, 19 Aug 2020 10:33:09 +0800 > Replace alloc_etherdev_mq with devm_alloc_etherdev_mqs. In this way, > when probe fails, netdev can be freed automatically. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit > ethernet") > Reported-by: Hulk Robot > S

Re: [PATCH v2 net] ptp: ptp_clockmatrix: use i2c_master_send for i2c write

2020-08-19 Thread David Miller
From: Date: Tue, 18 Aug 2020 10:41:22 -0400 > From: Min Li > > The old code for i2c write would break on some controllers, which fails > at handling Repeated Start Condition. So we will just use i2c_master_send > to handle write in one transanction. > > Changes since v1: > - Remove indentation

Re: [PATCH v2 06/11] sparc: switch to kernel_clone()

2020-08-19 Thread David Miller
From: Christian Brauner Date: Wed, 19 Aug 2020 12:46:50 +0200 > The old _do_fork() helper is removed in favor of the new kernel_clone() > helper. > The latter adheres to naming conventions for kernel internal syscall helpers. > > Cc: "David S. Miller" > Cc: sparcli...@vger.kernel.org > Signed-

Re: [PATCH v2] net: Stop warning about SO_BSDCOMPAT usage

2020-08-19 Thread David Miller
From: Miaohe Lin Date: Wed, 19 Aug 2020 04:32:08 -0400 > We've been warning about SO_BSDCOMPAT usage for many years. We may remove > this code completely now. > > Suggested-by: David S. Miller > Signed-off-by: Miaohe Lin Applied to net-next, thank you.

Re: [PATCH] net: bypass ->sendpage for slab pages

2020-08-19 Thread David Miller
From: Christoph Hellwig Date: Wed, 19 Aug 2020 07:19:45 +0200 > Sending Slab or tail pages into ->sendpage will cause really strange > delayed oops. Prevent it right in the networking code instead of > requiring drivers to guess the exact conditions where sendpage works. > > Based on a patch fr

Re: [PATCH] net: ipv4: remove duplicate "the the" phrase in Kconfig text

2020-08-18 Thread David Miller
From: Colin King Date: Mon, 17 Aug 2020 23:44:25 +0100 > From: Colin Ian King > > The Kconfig help text contains the phrase "the the" in the help > text. Fix this and reformat the block of help text. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: mscc: ocelot: remove duplicate "the the" phrase in Kconfig text

2020-08-18 Thread David Miller
From: Colin King Date: Mon, 17 Aug 2020 23:40:42 +0100 > From: Colin Ian King > > The Kconfig help text contains the phrase "the the" in the help > text. Fix this. > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] net: handle the return value of pskb_carve_frag_list() correctly

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Sat, 15 Aug 2020 04:46:41 -0400 > pskb_carve_frag_list() may return -ENOMEM in pskb_carve_inside_nonlinear(). > we should handle this correctly or we would get wrong sk_buff. > > Fixes: 6fa01ccd8830 ("skbuff: Add pskb_extract() helper function") > Signed-off-by: Miaohe Lin

Re: [PATCH v2] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear()

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Sat, 15 Aug 2020 04:48:53 -0400 > The frags of skb_shared_info of the data is assigned in following loop. It > is meaningless to do a memcpy of frags here. > > Signed-off-by: Miaohe Lin Applied, thank you.

Re: [PATCH] net: gianfar: Add of_node_put() before goto statement

2020-08-18 Thread David Miller
From: Sumera Priyadarsini Date: Wed, 19 Aug 2020 00:22:41 +0530 > Every iteration of for_each_available_child_of_node() decrements > reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no

Re: [PATCH] ethernet: cirrus: Remove unused macros

2020-08-18 Thread David Miller
From: Alex Dewar Date: Tue, 18 Aug 2020 15:06:01 +0100 > Remove a couple of unused #defines in cs89x0.h. > > Signed-off-by: Alex Dewar Applied to net-next.

Re: [PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread David Miller
From: Wang Hai Date: Tue, 18 Aug 2020 21:44:04 +0800 > Fix the missing free_netdev() before return from > gemini_ethernet_port_probe() in the error handling case. > > Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit > ethernet") > Reported-by: Hulk Robot > Signed-off-by: Wa

Re: [PATCH] net: tipc: Convert to use the preferred fallthrough macro

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Tue, 18 Aug 2020 08:07:13 -0400 > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin Applied to net-next.

Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5

2020-08-18 Thread David Miller
From: Miaohe Lin Date: Tue, 18 Aug 2020 07:41:32 -0400 > @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char *name) > { > static int warned; > static char warncomm[TASK_COMM_LEN]; > - if (strcmp(warncomm, current->comm) && warned < 5) { > + if (warned < 5 &&

Re: [PATCH] rpl_iptunnel: simplify the return expression of rpl_do_srh()

2020-08-18 Thread David Miller
From: Xu Wang Date: Tue, 18 Aug 2020 08:54:54 + > @@ -197,11 +197,7 @@ static int rpl_do_srh(struct sk_buff *skb, const struct > rpl_lwt *rlwt) > > tinfo = rpl_encap_lwtunnel(dst->lwtstate); > > - err = rpl_do_srh_inline(skb, rlwt, tinfo->srh); > - if (err) > -

[GIT] Networking

2020-08-17 Thread David Miller
Another batch of fixes: 1) Remove nft_compat counter flush optimization, it generates warnings from the refcount infrastructure. From Florian Westphal. 2) Fix BPF to search for build id more robustly, from Jiri Olsa. 3) Handle bogus getopt lengths in ebtables, from Florian Westphal. 4) I

Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-17 Thread David Miller
From: Denys Zagorui Date: Mon, 17 Aug 2020 10:52:24 -0700 > SIOCADDMULTI API allows adding multicast/unicast mac addresses but > doesn't deferentiate them so if someone tries to add secondary > unicast mac addr it will be added to multicast netdev list which is > confusing. There is at least one

Re: [PATCH] otx2_common: Use devm_kcalloc() in otx2_config_npa()

2020-08-17 Thread David Miller
From: Xu Wang Date: Mon, 17 Aug 2020 02:04:13 + > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang Applied, thanks.

Re: [PATCH v3] net: qrtr: fix usage of idr in port assignment to socket

2020-08-17 Thread David Miller
From: Necip Fazil Yildiran Date: Mon, 17 Aug 2020 15:54:48 + > From: Necip Fazil Yildiran > > Passing large uint32 sockaddr_qrtr.port numbers for port allocation > triggers a warning within idr_alloc() since the port number is cast > to int, and thus interpreted as a negative number. This l

Re: [PATCH net] ptp: ptp_clockmatrix: use i2c_master_send for i2c write

2020-08-17 Thread David Miller
From: Date: Mon, 17 Aug 2020 11:37:35 -0400 > @@ -53,7 +53,9 @@ > > #define OUTPUT_MODULE_FROM_INDEX(index) (OUTPUT_0 + (index) * 0x10) > > -#define PEROUT_ENABLE_OUTPUT_MASK(0xdeadbeef) > +#define PEROUT_ENABLE_OUTPUT_MASK(0xdeadbeef) > + > +#define IDTCM_MAX_WRITE_COUN

Re: [PATCH 00/30] Rid W=1 warnings in Networking

2020-08-17 Thread David Miller
From: Lee Jones Date: Mon, 17 Aug 2020 10:26:11 +0100 > Are there any more sub-groups that I need to be aware of, besides > wireless? Or can everything else be grouped together? Netfilter, mac802154, usually the Intel and Mellanox driver maintainers take things in directly then send pull reques

Re: [PATCH] phylink: : fix function prototype kernel-doc warning

2020-08-17 Thread David Miller
From: Randy Dunlap Date: Sun, 16 Aug 2020 22:43:54 -0700 > On 8/16/20 9:14 PM, David Miller wrote: >> From: Randy Dunlap >> Date: Sun, 16 Aug 2020 15:25:49 -0700 >> >>> Fix a kernel-doc warning for the pcs_config() function prototype: >>> >>>

Re: [PATCH] phylink: : fix function prototype kernel-doc warning

2020-08-16 Thread David Miller
From: Randy Dunlap Date: Sun, 16 Aug 2020 15:25:49 -0700 > Fix a kernel-doc warning for the pcs_config() function prototype: > > ../include/linux/phylink.h:406: warning: Excess function parameter > 'permit_pause_to_mac' description in 'pcs_config' > > Fixes: 7137e18f6f88 ("net: phylink: add st

Re: [PATCH] net: handle the return value of pskb_carve_frag_list() correctly

2020-08-16 Thread David Miller
From: linmiaohe Date: Mon, 17 Aug 2020 02:27:23 + > David Miller wrote: >>> + /* split line is in frag list */ >>> + if (k == 0 && pskb_carve_frag_list(skb, shinfo, off - pos, gfp_mask)) { >>> + /* skb_frag_unref() is n

Re: [PATCH] net: handle the return value of pskb_carve_frag_list() correctly

2020-08-16 Thread David Miller
From: Miaohe Lin Date: Sat, 15 Aug 2020 04:46:41 -0400 > + /* split line is in frag list */ > + if (k == 0 && pskb_carve_frag_list(skb, shinfo, off - pos, gfp_mask)) { > + /* skb_frag_unref() is not needed here as shinfo->nr_frags = 0. > */ > + if (skb_has_frag_li

Re: [PATCH] net: Fix potential wrong skb->protocol in skb_vlan_untag()

2020-08-16 Thread David Miller
From: Miaohe Lin Date: Sat, 15 Aug 2020 04:44:31 -0400 > We may access the two bytes after vlan_hdr in vlan_set_encap_proto(). So > we should pull VLAN_HLEN + sizeof(unsigned short) in skb_vlan_untag() or > we may access the wrong data. > > Fixes: 0d5501c1c828 ("net: Always untag vlan-tagged tra

Re: [PATCH 00/30] Rid W=1 warnings in Networking

2020-08-15 Thread David Miller
From: Lee Jones Date: Fri, 14 Aug 2020 12:39:03 +0100 > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > There are quite a few W=1 warnings in the Networking code. My > plan is to work t

Re: [PATCH net] drivers/net/wan/hdlc_x25: Added needed_headroom and a skb->len check

2020-08-15 Thread David Miller
From: Xie He Date: Thu, 13 Aug 2020 11:17:04 -0700 > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH net v2] bonding: show saner speed for broadcast mode

2020-08-15 Thread David Miller
From: Jarod Wilson Date: Thu, 13 Aug 2020 10:09:00 -0400 > Broadcast mode bonds transmit a copy of all traffic simultaneously out of > all interfaces, so the "speed" of the bond isn't really the aggregate of > all interfaces, but rather, the speed of the slowest active interface. > > Also, the t

Re: [PATCH] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-08-14 Thread David Miller
From: Po-Hsu Lin Date: Thu, 13 Aug 2020 12:44:22 +0800 > diff --git a/tools/testing/selftests/net/config > b/tools/testing/selftests/net/config > index 3b42c06b..96d2763 100644 > --- a/tools/testing/selftests/net/config > +++ b/tools/testing/selftests/net/config > @@ -31,3 +31,4 @@ CONFIG_NET_SC

Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket

2020-08-14 Thread David Miller
From: Necip Fazil Yildiran Date: Fri, 14 Aug 2020 10:10:00 + > diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c > index b4c0db0b7d31..52d0707df776 100644 > --- a/net/qrtr/qrtr.c > +++ b/net/qrtr/qrtr.c > @@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc) > static int qrt

[GIT] Networking

2020-08-13 Thread David Miller
Some merge window fallout, some longer term fixes: 1) Handle headroom properly in lapbether and x25_asy drivers, from Xie He. 2) Fetch MAC address from correct r8152 device node, from Thierry Reding. 3) In the sw kTLS path we should allow MSG_CMSG_COMPAT in sendmsg, from Rouven Czerwi

Re: [PATCH] af_packet: TPACKET_V3: fix fill status rwlock imbalance

2020-08-13 Thread David Miller
From: John Ogness Date: Thu, 13 Aug 2020 21:45:25 +0206 > After @blk_fill_in_prog_lock is acquired there is an early out vnet > situation that can occur. In that case, the rwlock needs to be > released. > > Also, since @blk_fill_in_prog_lock is only acquired when @tp_version > is exactly TPACKET

Re: [PATCH 2/3] ipv4/icmp: l3mdev: Perform icmp error route lookup on source device routing table

2020-08-12 Thread David Miller
From: Mathieu Desnoyers Date: Tue, 11 Aug 2020 15:50:02 -0400 > @@ -465,6 +465,7 @@ static struct rtable *icmp_route_lookup(struct net *net, > int type, int code, > struct icmp_bxm *param) > { > + struct net_device *

Re: [PATCH net 0/2] net: stmmac: Fix multicast filter on IPQ806x

2020-08-12 Thread David Miller
From: Jonathan McDowell Date: Wed, 12 Aug 2020 20:36:54 +0100 > This pair of patches are the result of discovering a failure to > correctly receive IPv6 multicast packets on such a device (in particular > DHCPv6 requests and RA solicitations). Putting the device into > promiscuous mode, or allmul

Re: [PATCH net v2] vsock: fix potential null pointer dereference in vsock_poll()

2020-08-12 Thread David Miller
From: Stefano Garzarella Date: Wed, 12 Aug 2020 14:56:02 +0200 > syzbot reported this issue where in the vsock_poll() we find the > socket state at TCP_ESTABLISHED, but 'transport' is null: > general protection fault, probably for non-canonical address > 0xdc12: [#1] PREEMPT S

Re: [PATCH] net: Fix potential memory leak in proto_register()

2020-08-11 Thread David Miller
From: Cong Wang Date: Tue, 11 Aug 2020 16:02:51 -0700 >> @@ -3406,6 +3406,16 @@ static void sock_inuse_add(struct net *net, int val) >> } >> #endif >> >> +static void tw_prot_cleanup(struct timewait_sock_ops *twsk_prot) >> +{ >> + if (!twsk_prot) >> + return; >> + kfre

Re: [PATCH net v4 0/2] net: initialize fastreuse on inet_inherit_port

2020-08-11 Thread David Miller
From: Tim Froidcoeur Date: Tue, 11 Aug 2020 20:33:22 +0200 > In the case of TPROXY, bind_conflict optimizations for SO_REUSEADDR or > SO_REUSEPORT are broken, possibly resulting in O(n) instead of O(1) bind > behaviour or in the incorrect reuse of a bind. > > the kernel keeps track for each bind

Re: [PATCH] net: Fix potential memory leak in proto_register()

2020-08-11 Thread David Miller
From: Miaohe Lin Date: Mon, 10 Aug 2020 08:16:58 -0400 > If we failed to assign proto idx, we free the twsk_slab_name but forget to > free the twsk_slab. Add a helper function tw_prot_cleanup() to free these > together and also use this helper function in proto_unregister(). > > Fixes: b45ce3213

Re: [PATCH net] net: qcom/emac: add missed clk_disable_unprepare in error path of emac_clks_phase1_init

2020-08-11 Thread David Miller
From: Wang Hai Date: Mon, 10 Aug 2020 10:57:05 +0800 > Fix the missing clk_disable_unprepare() before return > from emac_clks_phase1_init() in the error handling case. > > Fixes: b9b17debc69d ("net: emac: emac gigabit ethernet controller driver") > Reported-by: Hulk Robot > Signed-off-by: Wang

Re: [PATCH] ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()

2020-08-11 Thread David Miller
From: Xu Wang Date: Mon, 10 Aug 2020 02:38:07 + > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > Signed-off-by: Xu Wang Applied, thanks.

Re: [PATCH] net/nfc/rawsock.c: add CAP_NET_RAW check.

2020-08-11 Thread David Miller
From: Qingyu Li Date: Mon, 10 Aug 2020 09:51:00 +0800 > When creating a raw AF_NFC socket, CAP_NET_RAW needs to be checked first. > > Signed-off-by: Qingyu Li Applied and queued up for -stable, thank you.

Re: [PATCH net-next v2] hinic: fix strncpy output truncated compile warnings

2020-08-11 Thread David Miller
From: Luo bin Date: Sun, 9 Aug 2020 11:53:49 +0800 > fix the compile warnings of 'strncpy' output truncated before > terminating nul copying N bytes from a string of the same length > > Signed-off-by: Luo bin > Reported-by: kernel test robot Applied.

Re: [PATCH net] drivers/net/wan/x25_asy: Added needed_headroom and a skb->len check

2020-08-11 Thread David Miller
From: Xie He Date: Sat, 8 Aug 2020 19:35:48 -0700 > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH] selftests: Add VRF icmp error route lookup test

2020-08-11 Thread David Miller
From: Michael Jeanson Date: Thu, 6 Aug 2020 14:51:21 -0400 > The objective is to check that the incoming vrf routing table is selected > to send an ICMP error back to the source when the ttl of a packet reaches 1 > while it is forwarded between different vrfs. > > The first test sends a ping wi

Re: [PATCH net v3 0/2] net: initialize fastreuse on inet_inherit_port

2020-08-11 Thread David Miller
These patches do not apply cleanly to the current net tree.

Re: [PATCH net 0/2] vsock: fix null pointer dereference and cleanup in vsock_poll()

2020-08-11 Thread David Miller
From: Stefano Garzarella Date: Tue, 11 Aug 2020 11:55:02 +0200 > The first patch fixes a potential null pointer dereference in vsock_poll() > reported by syzbot. > The second patch is a simple cleanup in the same block code. I put this later, > to make it easier to backport the first patch in the

Re: [PATCH] net/tls: Fix kmap usage

2020-08-11 Thread David Miller
From: ira.we...@intel.com Date: Mon, 10 Aug 2020 17:02:58 -0700 > From: Ira Weiny > > When MSG_OOB is specified to tls_device_sendpage() the mapped page is > never unmapped. > > Hold off mapping the page until after the flags are checked and the page > is actually needed. > > Signed-off-by: Ir

Re: [PATCH v2 net-next] vmxnet3: use correct tcp hdr length when packet is encapsulated

2020-08-10 Thread David Miller
From: Ronak Doshi Date: Mon, 10 Aug 2020 09:55:55 -0700 > Commit dacce2be3312 ("vmxnet3: add geneve and vxlan tunnel offload > support") added support for encapsulation offload. However, while > calculating tcp hdr length, it does not take into account if the > packet is encapsulated or not. > >

Re: [PATCH v2 net] bitfield.h: don't compile-time validate _val in FIELD_FIT

2020-08-10 Thread David Miller
From: Nick Desaulniers Date: Mon, 10 Aug 2020 11:21:11 -0700 > From: Jakub Kicinski > > When ur_load_imm_any() is inlined into jeq_imm(), it's possible for the > compiler to deduce a case where _val can only have the value of -1 at > compile time. Specifically, > > /* struct bpf_insn: _s32 imm

Re: [PATCH] net: Convert to use the fallthrough macro

2020-08-08 Thread David Miller
From: linmiaohe Date: Sat, 8 Aug 2020 16:23:10 +0800 > From: Miaohe Lin > > Convert the uses of fallthrough comments to fallthrough macro. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH 5/5] net: Use helper function ip_is_fragment()

2020-08-08 Thread David Miller
From: linmiaohe Date: Thu, 6 Aug 2020 19:57:18 +0800 > From: Miaohe Lin > > Use helper function ip_is_fragment() to check ip fragment. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH 4/5] net: Remove meaningless jump label out_fs

2020-08-08 Thread David Miller
From: linmiaohe Date: Thu, 6 Aug 2020 19:54:19 +0800 > From: Miaohe Lin > > The out_fs jump label has nothing to do but goto out. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH 3/5] net: Set fput_needed iff FDPUT_FPUT is set

2020-08-08 Thread David Miller
From: linmiaohe Date: Thu, 6 Aug 2020 19:53:16 +0800 > From: Miaohe Lin > > We should fput() file iff FDPUT_FPUT is set. So we should set fput_needed > accordingly. > > Fixes: 00e188ef6a7e ("sockfd_lookup_light(): switch to fdget^W^Waway from > fget_light") > Signed-off-by: Miaohe Lin Appli

Re: [PATCH 2/5] net: Use helper function fdput()

2020-08-08 Thread David Miller
From: linmiaohe Date: Thu, 6 Aug 2020 19:52:24 +0800 > From: Miaohe Lin > > Use helper function fdput() to fput() the file iff FDPUT_FPUT is set. > > Signed-off-by: Miaohe Lin Applied.

Re: [PATCH net resend] bitfield.h: don't compile-time validate _val in FIELD_FIT

2020-08-08 Thread David Miller
From: Nick Desaulniers Date: Thu, 6 Aug 2020 11:29:39 -0700 > From: Jakub Kicinski > > When ur_load_imm_any() is inlined into jeq_imm(), it's possible for the > compiler to deduce a case where _val can only have the value of -1 at > compile time. Specifically, > > /* struct bpf_insn: _s32 imm

Re: [PATCH net] net: phy: fix memory leak in device-create error path

2020-08-08 Thread David Miller
From: Johan Hovold Date: Thu, 6 Aug 2020 17:37:53 +0200 > A recent commit introduced a late error path in phy_device_create() > which fails to release the device name allocated by dev_set_name(). > > Fixes: 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver > module") > Cc:

Re: [PATCH net-next v1] hinic: fix strncpy output truncated compile warnings

2020-08-07 Thread David Miller
From: "luobin (L)" Date: Sat, 8 Aug 2020 11:36:42 +0800 > On 2020/8/7 17:32, David Laight wrote: >>> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c >>> b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c >>> index c6adc776f3c8..1ec88ebf81d6 100644 >>> --- a/drivers/net/ethernet/hu

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-07 Thread David Miller
From: Ahmed Abdelsalam Date: Thu, 6 Aug 2020 08:43:06 +0200 > SRv6 as defined in [1][2] does not mandate that the hop_limit of the > outer IPv6 header has to be copied from the inner packet. This is not an issue of seg6 RFCs, but rather generic ip6 in ip6 tunnel encapsulation. Therefore, what t

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread David Miller
From: Rouven Czerwinski Date: Thu, 6 Aug 2020 08:49:06 +0200 > Trying to use ktls on a system with 32-bit userspace and 64-bit kernel > results in a EOPNOTSUPP message during sendmsg: > > setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0 > sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation n

Re: [PATCH v5 0/2] Add 802.1AD protocol support for dsa switch and ocelot driver

2020-08-07 Thread David Miller
From: hongbo.w...@nxp.com Date: Fri, 7 Aug 2020 19:13:47 +0800 > From: "hongbo.wang" > > 1. the patch 0001* is for setting single port into 802.1AD(QinQ) mode, > before this patch, the function dsa_slave_vlan_rx_add_vid didn't pass > the parameter "proto" to next port level, so switch's port c

Re: [PATCH] drivers/net/wan/lapbether: Added needed_headroom and a skb->len check

2020-08-06 Thread David Miller
From: Xie He Date: Wed, 5 Aug 2020 18:50:40 -0700 > 1. Added a skb->len check > > This driver expects upper layers to include a pseudo header of 1 byte > when passing down a skb for transmission. This driver will read this > 1-byte header. This patch added a skb->len check before reading the >

Re: [PATCH] epic100: switch from 'pci_' to 'dma_' API

2020-08-06 Thread David Miller
From: Christophe JAILLET Date: Thu, 6 Aug 2020 22:19:35 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. Christophe, the net-next tree is closed so I'd like to ask that you defer submitting these conversion patches until the net-next tree opens back up again. Thank you.

Re: [PATCH] net: hns3: fix spelling mistake "could'nt" -> "couldn't"

2020-08-06 Thread David Miller
From: Colin King Date: Thu, 6 Aug 2020 12:42:56 +0100 > From: Colin Ian King > > There is a spelling mistake in a dev_err message. Fix it. > > Signed-off-by: Colin Ian King Applied, thanks.

Re: [PATCH net-next] hinic: fix strncpy output truncated compile warnings

2020-08-06 Thread David Miller
From: Luo bin Date: Thu, 6 Aug 2020 15:48:30 +0800 > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c > b/drivers/net/ethernet/huawei/hinic/hinic_devlink.c > index c6adc776f3c8..1dc948c07b94 100644 > --- a/drivers/net/ethernet/huawei/hinic/hinic_devlink.c > +++ b/drivers/net/ethern

Re: [PATCH -next] sparc: use for_each_child_of_node() macro

2020-08-05 Thread David Miller
aFrom: Qinglang Miao Date: Tue, 28 Jul 2020 10:28:17 +0800 > Use for_each_child_of_node() macro instead of open coding it. > > Signed-off-by: Qinglang Miao Applied, thank you.

Re: [PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-05 Thread David Miller
Neither of these patches apply cleanly to net-next. The compat handling and TLS code has been changed quite a bit lately. ALso, you must provide a proper header "[PATCH 0/N] ..." posting for your patch series which explains at a high level what your patch series is doing, how it is doing it, an

Re: [PATCH net] ptp: ptp_idt82p33: update to support adjphase

2020-08-05 Thread David Miller
From: Date: Tue, 4 Aug 2020 15:12:14 -0400 > This update includes adjphase support, more debug logs, firmware name > parameter, correct PTP_CLK_REQ_PEROUT support and use do_aux_work to > do delay work. Way too many changes in one patch, and some of them are not appropriate. > +static char *fir

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-05 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 4 Aug 2020 07:40:30 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCH RESEND net-next] ip_tunnel_core: Fix build for archs without _HAVE_ARCH_IPV6_CSUM

2020-08-05 Thread David Miller
From: Stefano Brivio Date: Wed, 5 Aug 2020 15:39:31 +0200 > On architectures defining _HAVE_ARCH_IPV6_CSUM, we get > csum_ipv6_magic() defined by means of arch checksum.h headers. On > other architectures, we actually need to include net/ip6_checksum.h > to be able to use it. > > Without this in

Re: [PATCH 0/2] selftests: rtnetlink: Fix for false-negative return values

2020-08-05 Thread David Miller
From: Po-Hsu Lin Date: Tue, 4 Aug 2020 18:18:01 +0800 > This patchset will address the false-negative return value issue > caused by the following: > 1. The return value "ret" in this script will be reset to 0 from > the beginning of each sub-test in rtnetlink.sh, therefore this > rt

Re: [PATCH net-next] ip_vti: Fix unused variable warning

2020-08-05 Thread David Miller
From: Steffen Klassert Date: Tue, 4 Aug 2020 07:53:10 +0200 > On Mon, Aug 03, 2020 at 03:13:49PM -0700, David Miller wrote: >> From: YueHaibing >> Date: Fri, 31 Jul 2020 14:49:52 +0800 >> >> > If CONFIG_INET_XFRM_TUNNEL is set but CONFIG_IPV6 is n, >> >

Re: [PATCH] net: openvswitch: silence suspicious RCU usage warning

2020-08-05 Thread David Miller
From: xiangxia.m@gmail.com Date: Wed, 5 Aug 2020 15:19:11 +0800 > From: Tonghao Zhang > > ovs_flow_tbl_destroy always is called from RCU callback > or error path. It is no need to check if rcu_read_lock > or lockdep_ovsl_is_held was held. > > ovs_dp_cmd_fill_info always is called with ovs_

Re: [PATCH] farsync: switch from 'pci_' to 'dma_' API

2020-08-04 Thread David Miller
From: Christophe JAILLET Date: Tue, 4 Aug 2020 22:19:24 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCH] wan: wanxl: switch from 'pci_' to 'dma_' API

2020-08-04 Thread David Miller
From: Christophe JAILLET Date: Tue, 4 Aug 2020 22:08:09 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > W

Re: [PATCHv2 net-next] dropwatch: Support monitoring of dropped frames

2020-08-04 Thread David Miller
From: izabela.bakoll...@gmail.com Date: Tue, 4 Aug 2020 18:09:08 +0200 > @@ -1315,6 +1334,53 @@ static int net_dm_cmd_trace(struct sk_buff *skb, > return -EOPNOTSUPP; > } > > +static int net_dm_interface_start(struct net *net, const char *ifname) > +{ > + struct net_device *nd = dev_

Re: [PATCH] dpaa2-eth: Fix passing zero to 'PTR_ERR' warning

2020-08-04 Thread David Miller
From: YueHaibing Date: Tue, 4 Aug 2020 21:26:43 +0800 > Fix smatch warning: > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2419 > alloc_channel() warn: passing zero to 'ERR_PTR' > > setup_dpcon() should return ERR_PTR(err) instead of zero in error > handling case. > > Fixes: d7f5a9d89a5

Re: [PATCH] selftests/net: skip msg_zerocopy test if we have less than 4 CPUs

2020-08-04 Thread David Miller
From: Colin King Date: Tue, 4 Aug 2020 13:30:12 +0100 > From: Colin Ian King > > The current test will exit with a failure if it cannot set affinity on > specific CPUs which is problematic when running this on single CPU > systems. Add a check for the number of CPUs and skip the test if > the

Re: [PATCH] net: core: explicitly call linkwatch_fire_event to speed up the startup of network services

2020-08-04 Thread David Miller
From: Wen Yang Date: Sat, 1 Aug 2020 16:58:45 +0800 > diff --git a/net/core/link_watch.c b/net/core/link_watch.c > index 75431ca..6b9d44b 100644 > --- a/net/core/link_watch.c > +++ b/net/core/link_watch.c > @@ -98,6 +98,9 @@ static bool linkwatch_urgent_event(struct net_device *dev) > if (

Re: [PATCH] seg6: using DSCP of inner IPv4 packets

2020-08-04 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 4 Aug 2020 07:40:30 + > This patch allows copying the DSCP from inner IPv4 header to the > outer IPv6 header, when doing SRv6 Encapsulation. > > This allows forwarding packet across the SRv6 fabric based on their > original traffic class. > > Signed-off-by

Re: [PATCH V2] via-velocity: Use more typical logging styles

2020-08-04 Thread David Miller
From: Joe Perches Date: Mon, 03 Aug 2020 20:23:13 -0700 > Use netdev_ in place of VELOCITY_PRT. > Use pr_ in place of printk(KERN_. > > Miscellanea: > > o Add pr_fmt to prefix pr_ output with "via-velocity: " > o Remove now unused functions and macros > o Realign some logging lines > o Remove d

Re: [PATCH net-next v4 0/2] hinic: mailbox channel enhancement

2020-08-04 Thread David Miller
From: Luo bin Date: Tue, 4 Aug 2020 10:19:10 +0800 > add support to generate mailbox random id for VF to ensure that > the mailbox message from VF is valid and PF should check whether > the cmd from VF is supported before passing it to hw. Series applied, thanks.

Re: [PATCH v3 0/3] drivers: ide: use generic power management

2020-08-03 Thread David Miller
From: Vaibhav Gupta Date: Mon, 13 Jul 2020 23:06:10 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from ide drivers. > > The suspend() and resume() callbacks operations are still invoking > pc

Re: [PATCH] IDE SUBSYSTEM: Replace HTTP links with HTTPS ones

2020-08-03 Thread David Miller
From: "Alexander A. Klimov" Date: Thu, 9 Jul 2020 21:28:13 +0200 > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn'

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-03 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 23:10:09 +0300 > From: Jiafei Pan > > The driver calls napi_schedule_irqoff() from a context where, in RT, > hardirqs are not disabled, since the IRQ handler is force-threaded. > > In the call path of this function, __raise_softirq_irqoff() is modif

Re: [PATCH net-next 1/2] dpaa2-eth: use napi_schedule to be compatible with PREEMPT_RT

2020-08-03 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 23:10:08 +0300 > From: Jiafei Pan > > The driver calls napi_schedule_irqoff() from a context where, in RT, > hardirqs are not disabled, since the IRQ handler is force-threaded. > > In the call path of this function, __raise_softirq_irqoff() is modif

Re: [PATCH net-next] mptcp: use mptcp_for_each_subflow in mptcp_stream_accept

2020-08-03 Thread David Miller
From: Geliang Tang Date: Mon, 3 Aug 2020 21:00:44 +0800 > Use mptcp_for_each_subflow in mptcp_stream_accept instead of > open-coding. > > Signed-off-by: Geliang Tang Applied, thank you.

Re: [PATCH net-next] fib: Fix undef compile warning

2020-08-03 Thread David Miller
From: YueHaibing Date: Mon, 3 Aug 2020 21:19:48 +0800 > net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not > defined, evaluates to 0 [-Wundef] > #elif CONFIG_IP_MULTIPLE_TABLES >^ > > Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indir

Re: [PATCH net-next] net: stmmac: fix failed to suspend if phy based WOL is enabled

2020-08-03 Thread David Miller
From: Jisheng Zhang Date: Mon, 3 Aug 2020 16:56:47 +0800 > With the latest net-next tree, if test suspend/resume after enabling > WOL, we get error as below: > > [ 487.086365] dpm_run_callback(): mdio_bus_suspend+0x0/0x30 returns -16 > [ 487.086375] PM: Device stmmac-0:00 failed to suspend: er

Re: [PATCH v3] seg6_iptunnel: Refactor seg6_lwt_headroom out of uapi header

2020-08-03 Thread David Miller
as indicated by the "#ifdef __KERNEL__". > > Suggested-by: David Miller > Signed-off-by: Ioana-Ruxandra Stăncioi Applied, thank you.

Re: [PATCH net-next] tipc: Use is_broadcast_ether_addr() instead of memcmp()

2020-08-03 Thread David Miller
From: Huang Guobin Date: Sun, 2 Aug 2020 22:00:55 -0400 > Using is_broadcast_ether_addr() instead of directly use > memcmp() to determine if the ethernet address is broadcast > address. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off

Re: [PATCH net v3 0/5] DPAA FMan driver fixes

2020-08-03 Thread David Miller
From: Florinel Iordache Date: Mon, 3 Aug 2020 10:07:29 +0300 > Here are several fixes for the DPAA FMan driver. > > v2 changes: > * corrected patch 4 by removing the line added by mistake > * used longer fixes tags with the first 12 characters of the SHA-1 ID > > v3 changes: > * remove the emp

Re: [PATCH] net: sgi: ioc3-eth: Fix the size used in some 'dma_free_coherent()' calls

2020-08-03 Thread David Miller
From: Christophe JAILLET Date: Sun, 2 Aug 2020 15:52:04 +0200 > Update the size used in 'dma_free_coherent()' in order to match the one > used in the corresponding 'dma_alloc_coherent()'. > > Fixes: 369a782af0f1 ("net: sgi: ioc3-eth: ensure tx ring is 16k aligned.") > Signed-off-by: Christophe

Re: [PATCH 2/2] net: spider_net: Remove a useless memset

2020-08-03 Thread David Miller
From: Christophe JAILLET Date: Sun, 2 Aug 2020 15:53:48 +0200 > Avoid a memset after a call to 'dma_alloc_coherent()'. > This is useless since > commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") > > Signed-off-by: Christophe JAILLET Applied.

Re: [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call

2020-08-03 Thread David Miller
From: Christophe JAILLET Date: Sun, 2 Aug 2020 15:53:33 +0200 > Update the size used in 'dma_free_coherent()' in order to match the one > used in the corresponding 'dma_alloc_coherent()', in > 'spider_net_init_chain()'. > > Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing") > Signed-off-by: Chris

Re: [PATCH] net: vmxnet3: avoid accessing the data mapped to streaming DMA

2020-08-03 Thread David Miller
From: Jia-Ju Bai Date: Sun, 2 Aug 2020 21:11:07 +0800 > In vmxnet3_probe_device(), "adapter" is mapped to streaming DMA: > adapter->adapter_pa = dma_map_single(..., adapter, ...); > > Then "adapter" is accessed at many places in this function. > > Theses accesses may cause data inconsistency

Re: [PATCH] liquidio: Fix wrong return value in cn23xx_get_pf_num()

2020-08-03 Thread David Miller
From: Tianjia Zhang Date: Sun, 2 Aug 2020 19:15:44 +0800 > On an error exit path, a negative error code should be returned > instead of a positive return value. > > Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a > virtual machine") > Cc: Rick Farrington > Signed-off-

Re: [PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()

2020-08-03 Thread David Miller
From: Tianjia Zhang Date: Sun, 2 Aug 2020 19:15:38 +0800 > In the case of invalid rule, a positive value EINVAL is returned here. > I think this is a typo error. It is necessary to return an error value. > > Cc: Po Liu > Signed-off-by: Tianjia Zhang Applied.

<    1   2   3   4   5   6   7   8   9   10   >