BTW: s/env/command line/ is true as well, i.e. running: `make
CROSS_COMPILE=cross-`
On Tue, Mar 22, 2016 at 11:22 AM, David Sharp <dhsh...@google.com> wrote:
> So, note that without allow-override:
> - The set default of "gcc" is not respected.
> - Setting CC from the e
BTW: s/env/command line/ is true as well, i.e. running: `make
CROSS_COMPILE=cross-`
On Tue, Mar 22, 2016 at 11:22 AM, David Sharp wrote:
> So, note that without allow-override:
> - The set default of "gcc" is not respected.
> - Setting CC from the env does work.
> - Sett
>> > >
>> > > [acme@jouet linux]$ grep -w ^CC Makefile
>> > > CC= $(CROSS_COMPILE)gcc
This works, but doesn't allow setting CC from env since it is
unconditionally overwritten here.
>> > > [acme@jouet linux]$
>> >
>> > St
son for allow-override in the comment above it,
>> > > > please make sure the new solution follows that
>> > >
>> > > Sure, and I'm no make guru, but what puzzles me is why isn't this
>> > > required in:
>> > >
>> > > [acme@jouet
We ran into an issue recently where a parser we have for perf.data
could not handle TRACING_DATA events. It has a default behaviour of
skipping event types it does not understand by using the header.size,
since that seems to be how perf.data files are formatted.
However, for TRACING_DATA events,
We ran into an issue recently where a parser we have for perf.data
could not handle TRACING_DATA events. It has a default behaviour of
skipping event types it does not understand by using the header.size,
since that seems to be how perf.data files are formatted.
However, for TRACING_DATA events,
tarted" memory is lost after the first read
> from tracing_read_pipe and a proper object will never be freed.
>
> The "started" is never dereferenced for trace_pipe, because trace_pipe
> can't have the TRACE_FILE_ANNOTATE options (why?).
>
> Cc: Steven Rostedt
> Cc: Frede
and a proper object will never be freed.
The started is never dereferenced for trace_pipe, because trace_pipe
can't have the TRACE_FILE_ANNOTATE options (why?).
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
Cc: David Sharp dhsh
>> the current file mode 0644.
>>
>> Signed-off-by: Wang YanQing
>
> Acked-by: Vaibhav Nagarnaik
Acked-by: David Sharp
>
> Vaibhav Nagarnaik
>
>
>> ---
>> kernel/trace/trace.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>&g
-off-by: Wang YanQing udkni...@gmail.com
Acked-by: Vaibhav Nagarnaik vnagarn...@google.com
Acked-by: David Sharp dhsh...@google.com
Vaibhav Nagarnaik
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
On Wed, Feb 27, 2013 at 9:22 AM, Steven Rostedt wrote:
> With this patch set, a new directory is created in the debug/tracing
> directory called "instances". Here you can mkdir/rmdir a new directory
> that will contain some of the files in the debug/tracing directory.
> Note, this is not totally
On Wed, Feb 27, 2013 at 9:22 AM, Steven Rostedt rost...@goodmis.org wrote:
With this patch set, a new directory is created in the debug/tracing
directory called instances. Here you can mkdir/rmdir a new directory
that will contain some of the files in the debug/tracing directory.
Note, this is
Commit-ID: 8be0709f10e3dd5d7d07933ad61a9f18c4b93ca5
Gitweb: http://git.kernel.org/tip/8be0709f10e3dd5d7d07933ad61a9f18c4b93ca5
Author: David Sharp
AuthorDate: Tue, 13 Nov 2012 12:18:22 -0800
Committer: Steven Rostedt
CommitDate: Tue, 13 Nov 2012 15:48:40 -0500
tracing: Format non
Commit-ID: 8cbd9cc6254065c97c4bac42daa55ba1abe73a8e
Gitweb: http://git.kernel.org/tip/8cbd9cc6254065c97c4bac42daa55ba1abe73a8e
Author: David Sharp
AuthorDate: Tue, 13 Nov 2012 12:18:21 -0800
Committer: Steven Rostedt
CommitDate: Tue, 13 Nov 2012 15:48:27 -0500
tracing,x86: Add a TSC
Commit-ID: 8cbd9cc6254065c97c4bac42daa55ba1abe73a8e
Gitweb: http://git.kernel.org/tip/8cbd9cc6254065c97c4bac42daa55ba1abe73a8e
Author: David Sharp dhsh...@google.com
AuthorDate: Tue, 13 Nov 2012 12:18:21 -0800
Committer: Steven Rostedt rost...@goodmis.org
CommitDate: Tue, 13 Nov 2012 15
Commit-ID: 8be0709f10e3dd5d7d07933ad61a9f18c4b93ca5
Gitweb: http://git.kernel.org/tip/8be0709f10e3dd5d7d07933ad61a9f18c4b93ca5
Author: David Sharp dhsh...@google.com
AuthorDate: Tue, 13 Nov 2012 12:18:22 -0800
Committer: Steven Rostedt rost...@goodmis.org
CommitDate: Tue, 13 Nov 2012 15
On Wed, Nov 14, 2012 at 6:27 PM, Steven Rostedt wrote:
> On Wed, 2012-11-14 at 17:51 -0800, David Sharp wrote:
>> "width" and "height" were swapped, causing the vertical marker and cursor
>> lines
>> to be drawn with the wrong height.
>
> Is this t
On Wed, Nov 14, 2012 at 6:27 PM, Steven Rostedt rost...@goodmis.org wrote:
On Wed, 2012-11-14 at 17:51 -0800, David Sharp wrote:
width and height were swapped, causing the vertical marker and cursor
lines
to be drawn with the wrong height.
Is this the fix to the strange mark bottom stays
"width" and "height" were swapped, causing the vertical marker and cursor lines
to be drawn with the wrong height.
Signed-off-by: David Sharp
---
trace-graph.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
in
sorry for the dups... typoed Steve's domain.
On Wed, Nov 14, 2012 at 5:51 PM, David Sharp wrote:
> From: Venkatesh Pallipadi
>
> Plot CPU filtering in kernelshark has the following bug:
> 1) Deselect CPU A from Plot CPU list
> 2) Plot gets updated with no CPU A
> 3) Desele
old_all_cpus != new_all_cpus before doing any
update. This condition is true on 1, but false on 2.
Removing that check fixes the problem.
Tested:
Above sequence now does expected filtering.
Google-bug-id: 4258610
Signed-off-by: Venkatesh Pallipadi
Signed-off-by: David Sharp
---
trace-plot-cpu.c
the subsystem.
Google-Bug-Id: 6333917
Signed-off-by: Vaibhav Nagarnaik
Signed-off-by: David Sharp
---
trace-graph.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index 4d81219..6f72350 100644
--- a/trace-graph.c
+++ b/trace-graph.c
@@ -1016,7
"width" and "height" were swapped, causing the vertical marker and cursor lines
to be drawn with the wrong height.
Signed-off-by: David Sharp
---
trace-graph.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
in
s and uncheck "All CPUs"
button. All the CPUs should be unchecked at that point.
Signed-off-by: Vaibhav Nagarnaik
Signed-off-by: David Sharp
---
trace-filter.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/trace-filter.c b/trace-filter.c
index c6
the subsystem.
Google-Bug-Id: 6333917
Signed-off-by: Vaibhav Nagarnaik
Signed-off-by: David Sharp
---
trace-graph.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index 4d81219..6f72350 100644
--- a/trace-graph.c
+++ b/trace-graph.c
@@ -1016,7
old_all_cpus != new_all_cpus before doing any
update. This condition is true on 1, but false on 2.
Removing that check fixes the problem.
Tested:
Above sequence now does expected filtering.
Google-bug-id: 4258610
Signed-off-by: Venkatesh Pallipadi
Signed-off-by: David Sharp
---
trace-plot-cpu.c
s and uncheck "All CPUs"
button. All the CPUs should be unchecked at that point.
Signed-off-by: Vaibhav Nagarnaik
Signed-off-by: David Sharp
---
trace-filter.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/trace-filter.c b/trace-filter.c
index c6
and uncheck All CPUs
button. All the CPUs should be unchecked at that point.
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
trace-filter.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/trace-filter.c b/trace
to be checking old_all_cpus != new_all_cpus before doing any
update. This condition is true on 1, but false on 2.
Removing that check fixes the problem.
Tested:
Above sequence now does expected filtering.
Google-bug-id: 4258610
Signed-off-by: Venkatesh Pallipadi ve...@google.com
Signed-off-by: David
that don't record the subsystem.
Google-Bug-Id: 6333917
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
trace-graph.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index 4d81219..6f72350
and uncheck All CPUs
button. All the CPUs should be unchecked at that point.
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
trace-filter.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/trace-filter.c b/trace
width and height were swapped, causing the vertical marker and cursor lines
to be drawn with the wrong height.
Signed-off-by: David Sharp dhsh...@google.com
---
trace-graph.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index
to be checking old_all_cpus != new_all_cpus before doing any
update. This condition is true on 1, but false on 2.
Removing that check fixes the problem.
Tested:
Above sequence now does expected filtering.
Google-bug-id: 4258610
Signed-off-by: Venkatesh Pallipadi ve...@google.com
Signed-off-by: David
that don't record the subsystem.
Google-Bug-Id: 6333917
Signed-off-by: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
trace-graph.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index 4d81219..6f72350
sorry for the dups... typoed Steve's domain.
On Wed, Nov 14, 2012 at 5:51 PM, David Sharp dhsh...@google.com wrote:
From: Venkatesh Pallipadi ve...@google.com
Plot CPU filtering in kernelshark has the following bug:
1) Deselect CPU A from Plot CPU list
2) Plot gets updated with no CPU A
3
width and height were swapped, causing the vertical marker and cursor lines
to be drawn with the wrong height.
Signed-off-by: David Sharp dhsh...@google.com
---
trace-graph.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index
Commit-ID: 60303ed3f4b9332b9aa9bc17c68bc174e7343e2d
Gitweb: http://git.kernel.org/tip/60303ed3f4b9332b9aa9bc17c68bc174e7343e2d
Author: David Sharp
AuthorDate: Thu, 11 Oct 2012 16:27:52 -0700
Committer: Steven Rostedt
CommitDate: Fri, 2 Nov 2012 10:21:47 -0400
tracing: Reset ring
Commit-ID: 01e3e710a9265fb7092efd67243d7b6dd6e2548a
Gitweb: http://git.kernel.org/tip/01e3e710a9265fb7092efd67243d7b6dd6e2548a
Author: David Sharp
AuthorDate: Thu, 7 Jun 2012 16:46:24 -0700
Committer: Steven Rostedt
CommitDate: Wed, 31 Oct 2012 16:45:33 -0400
tracing: Trivial cleanup
On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt wrote:
> On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote:
>
>> To merge the data like previous pattern, we apply this patch set. Then, we
>> can
>> get TSC offset of the guest as follows:
>>
>> $ dmesg | grep kvm
>> [ 57.717180] kvm:
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David S
YUNOMAE
Cc: Steven Rostedt
Cc: Frederic Weisbecker
Cc: Ingo Molnar
Signed-off-by: David Sharp
---
kernel/trace/trace.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index d943e69..b69cc38 100644
interlaced.
Tested: Enabled a tracepoint and the "tsc" trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename "x86-tsc", cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven
interlaced.
Tested: Enabled a tracepoint and the tsc trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename x86-tsc, cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt
respectively.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
Signed-off-by: David Sharp dhsh...@google.com
---
kernel/trace/trace.c | 23 +--
1 files
prev_pid=31128
prev_prio=120 prev_state=S == next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost...@goodmis.org
Cc
On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt rost...@goodmis.org wrote:
On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote:
To merge the data like previous pattern, we apply this patch set. Then, we
can
get TSC offset of the guest as follows:
$ dmesg | grep kvm
[ 57.717180]
Commit-ID: 01e3e710a9265fb7092efd67243d7b6dd6e2548a
Gitweb: http://git.kernel.org/tip/01e3e710a9265fb7092efd67243d7b6dd6e2548a
Author: David Sharp dhsh...@google.com
AuthorDate: Thu, 7 Jun 2012 16:46:24 -0700
Committer: Steven Rostedt rost...@goodmis.org
CommitDate: Wed, 31 Oct 2012 16
Commit-ID: 60303ed3f4b9332b9aa9bc17c68bc174e7343e2d
Gitweb: http://git.kernel.org/tip/60303ed3f4b9332b9aa9bc17c68bc174e7343e2d
Author: David Sharp dhsh...@google.com
AuthorDate: Thu, 11 Oct 2012 16:27:52 -0700
Committer: Steven Rostedt rost...@goodmis.org
CommitDate: Fri, 2 Nov 2012 10
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David S
prev_pid=31128
prev_prio=120 prev_state=S == next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost...@goodmis.org
Cc
Because the "tsc" clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven R
interlaced.
Tested: Enabled a tracepoint and the "tsc" trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename "x86-tsc", cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven
interlaced.
Tested: Enabled a tracepoint and the tsc trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename x86-tsc, cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt
Because the tsc clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc
interlaced.
Tested: Enabled a tracepoint and the "tsc" trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename "x86-tsc", cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven
On Tue, Oct 16, 2012 at 5:53 AM, David Howells wrote:
> David Sharp wrote:
>
>> > Please use the Kbuild infrastructure ("generic-y += ..." in
>> > arch/*/include/asm/Kbuild)
>> > instead of adding wrappers around the asm-generic version.
>>
On Tue, Oct 16, 2012 at 5:53 AM, David Howells dhowe...@redhat.com wrote:
David Sharp dhsh...@google.com wrote:
Please use the Kbuild infrastructure (generic-y += ... in
arch/*/include/asm/Kbuild)
instead of adding wrappers around the asm-generic version.
mips apparently recencly got rid
interlaced.
Tested: Enabled a tracepoint and the tsc trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename x86-tsc, cleanups
v7:
Generic arch bits in Kbuild.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt
On Thu, Oct 11, 2012 at 10:05 PM, Geert Uytterhoeven
wrote:
> On Fri, Oct 12, 2012 at 1:27 AM, David Sharp wrote:
>> +#include
>
> Please use the Kbuild infrastructure ("generic-y += ..." in
> arch/*/include/asm/Kbuild)
> instead of adding wrappers around
On Fri, Oct 12, 2012 at 4:41 AM, Steven Rostedt wrote:
> On Fri, 2012-10-12 at 07:05 +0200, Geert Uytterhoeven wrote:
>> On Fri, Oct 12, 2012 at 1:27 AM, David Sharp wrote:
>> > +#include
>>
>> Please use the Kbuild infrastructure ("generic-y += ..." in
On Fri, Oct 12, 2012 at 4:41 AM, Steven Rostedt rost...@goodmis.org wrote:
On Fri, 2012-10-12 at 07:05 +0200, Geert Uytterhoeven wrote:
On Fri, Oct 12, 2012 at 1:27 AM, David Sharp dhsh...@google.com wrote:
+#include asm-generic/trace_clock.h
Please use the Kbuild infrastructure (generic-y
On Thu, Oct 11, 2012 at 10:05 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Fri, Oct 12, 2012 at 1:27 AM, David Sharp dhsh...@google.com wrote:
+#include asm-generic/trace_clock.h
Please use the Kbuild infrastructure (generic-y += ... in
arch/*/include/asm/Kbuild)
instead of adding
On Thu, Oct 11, 2012 at 6:36 PM, Steven Rostedt wrote:
> On Thu, 2012-10-11 at 16:27 -0700, David Sharp wrote:
>> Compiler warning:
>>
>> kernel/trace/trace_events_filter.c: In function
>> 'ftrace_function_set_filter_cb':
>> kernel/trace/trace_events_filter.c
On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt wrote:
> Sorry, I know this is late, but it was pushed down in my todo list
> (never off, but something I probably wouldn't have seen for a few more
> months).
>
> On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
>&
es?
Thanks for noticing the stats issue. Added them to my series.
>
> Thanks,
>
> Yoshihiro YUNOMAE
>
> (2012/10/02 12:31), David Sharp wrote:
>> In order to promote interoperability between userspace tracers and ftrace,
>> add a trace_clock that reports raw TSC va
ext_prio=120
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-
interlaced.
Tested: Enabled a tracepoint and the "tsc" trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename "x86-tsc", cleanups
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven Rostedt
Cc: Masami Hiramatsu
Compiler warning:
kernel/trace/trace_events_filter.c: In function 'ftrace_function_set_filter_cb':
kernel/trace/trace_events_filter.c:2074:8: error: 'ret' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
Signed-off-by: David Sharp
Cc: Steven Rostedt
---
kernel/trace
YUNOMAE
Cc: Steven Rostedt
Cc: Frederic Weisbecker
Cc: Ingo Molnar
Signed-off-by: David Sharp
---
kernel/trace/trace.c | 23 +--
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index cff3427..8bfa3b7 100644
Because the "tsc" clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven R
Added Yoshihiro Yonomae's patches to change the per_cpu stats to show raw
timestamps when the clock is not in nanoseconds.
Also added a small patch to fix a warning.
David Sharp (4):
tracing,x86: Add a TSC trace_clock
tracing: Reset ring buffer when changing trace_clocks
tracing: Format
Nagarnaik
Signed-off-by: David Sharp
---
include/linux/ring_buffer.h |2 +-
kernel/trace/ring_buffer.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/ring_buffer.h b/include/linux/ring_buffer.h
index 6c8835f..c68a09a 100644
--- a/include/linux/ring_buffe
On Thu, Oct 11, 2012 at 1:43 PM, Steven Rostedt wrote:
> On Mon, 2012-10-01 at 20:31 -0700, David Sharp wrote:
>
>> static int
>> -lat_print_timestamp(struct trace_seq *s, u64 abs_usecs,
>> - unsigned long rel_usecs)
>> +lat_print_timestamp(st
On Thu, Oct 11, 2012 at 1:43 PM, Steven Rostedt rost...@goodmis.org wrote:
On Mon, 2012-10-01 at 20:31 -0700, David Sharp wrote:
static int
-lat_print_timestamp(struct trace_seq *s, u64 abs_usecs,
- unsigned long rel_usecs)
+lat_print_timestamp(struct trace_iterator *iter
...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
Cc: Vaibhav Nagarnaik vnagarn...@google.com
Signed-off-by: David Sharp dhsh...@google.com
---
include/linux/ring_buffer.h |2 +-
kernel/trace/ring_buffer.c |4 ++--
2 files changed, 3 insertions(+), 3
Added Yoshihiro Yonomae's patches to change the per_cpu stats to show raw
timestamps when the clock is not in nanoseconds.
Also added a small patch to fix a warning.
David Sharp (4):
tracing,x86: Add a TSC trace_clock
tracing: Reset ring buffer when changing trace_clocks
tracing: Format
Because the tsc clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc
respectively.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
Signed-off-by: David Sharp dhsh...@google.com
---
kernel/trace/trace.c | 23 +--
1 files
Compiler warning:
kernel/trace/trace_events_filter.c: In function 'ftrace_function_set_filter_cb':
kernel/trace/trace_events_filter.c:2074:8: error: 'ret' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt
interlaced.
Tested: Enabled a tracepoint and the tsc trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename x86-tsc, cleanups
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Masami
: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S == next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost
?
Thanks for noticing the stats issue. Added them to my series.
Thanks,
Yoshihiro YUNOMAE
(2012/10/02 12:31), David Sharp wrote:
In order to promote interoperability between userspace tracers and ftrace,
add a trace_clock that reports raw TSC values which will then be recorded
in the ring
: David Sharp dhsh...@google.com
If this is from David it needs his SOB.
Is that true even though we are working for the same company?
-- Steve
Remove ftrace_format_syscall() declaration; it is neither defined nor
used. Also update a comment and formatting.
Signed-off-by: Vaibhav Nagarnaik
On Thu, Oct 11, 2012 at 6:36 PM, Steven Rostedt rost...@goodmis.org wrote:
On Thu, 2012-10-11 at 16:27 -0700, David Sharp wrote:
Compiler warning:
kernel/trace/trace_events_filter.c: In function
'ftrace_function_set_filter_cb':
kernel/trace/trace_events_filter.c:2074:8: error: 'ret' may
ext_prio=120
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-
Because the "tsc" clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven R
interlaced.
Tested: Enabled a tracepoint and the "tsc" trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename "x86-tsc", cleanups
Google-Bug-Id: 6980623
Signed-off-by: David Sharp
Cc: Steven Rostedt
Cc: Masami Hiramatsu
On Fri, Sep 28, 2012 at 8:15 PM, Steven Rostedt wrote:
> On Thu, 2012-09-20 at 15:52 -0700, David Sharp wrote:
>
>> diff --git a/include/asm-generic/trace_clock.h
>> b/include/asm-generic/trace_clock.h
>> new file mode 100644
>> index 000..6726f1b
>>
On Fri, Sep 28, 2012 at 8:15 PM, Steven Rostedt rost...@goodmis.org wrote:
On Thu, 2012-09-20 at 15:52 -0700, David Sharp wrote:
diff --git a/include/asm-generic/trace_clock.h
b/include/asm-generic/trace_clock.h
new file mode 100644
index 000..6726f1b
--- /dev/null
+++ b/include/asm
interlaced.
Tested: Enabled a tracepoint and the tsc trace_clock and saw very large
timestamp values.
v2:
Move arch-specific bits out of generic code.
v3:
Rename x86-tsc, cleanups
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Masami
Because the tsc clock isn't in nanoseconds, the ring buffer must be
reset when changing clocks so that incomparable timestamps don't end up
in the same trace.
Tested: Confirmed switching clocks resets the trace buffer.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc
: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S == next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-off-by: David Sharp dhsh...@google.com
Cc: Steven Rostedt rost
On Wed, Sep 26, 2012 at 11:30 AM, Steven Rostedt wrote:
> On Tue, 2012-09-25 at 15:29 -0700, David Sharp wrote:
>
>> static int
>> -lat_print_timestamp(struct trace_seq *s, u64 abs_usecs,
>> - unsigned long rel_usecs)
>> +lat_print_timestamp(st
On Wed, Sep 26, 2012 at 11:30 AM, Steven Rostedt rost...@goodmis.org wrote:
On Tue, 2012-09-25 at 15:29 -0700, David Sharp wrote:
static int
-lat_print_timestamp(struct trace_seq *s, u64 abs_usecs,
- unsigned long rel_usecs)
+lat_print_timestamp(struct trace_iterator *iter
On Tue, Sep 25, 2012 at 4:36 PM, Steven Rostedt wrote:
> On Tue, 2012-09-25 at 15:29 -0700, David Sharp wrote:
>
>
>> >> + ret = trace_seq_printf(
>> >> + s, "[%08llx] %ld.%03ldms (+%ld.%03ldms): ",
>> &
ext_prio=120
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-
On Tue, Sep 25, 2012 at 2:42 PM, Steven Rostedt wrote:
> Sorry, I should have been more picky before. I haven't totally tested
> this yet.
>
> On Tue, 2012-09-25 at 13:49 -0700, David Sharp wrote:
>> With the addition of the "tsc" clock, formatting timestamps to loo
ext_prio=120
sleep-31128 0 91557843399+: sched_switch: prev_comm=bash prev_pid=31128
prev_prio=120 prev_state=S ==> next_comm=swapper next_pid=0 next_prio=120
...
v2:
Move arch-specific bits out of generic code.
v4:
Fix x86_32 build due to 64-bit division.
Google-Bug-Id: 6980623
Signed-
On Mon, Sep 24, 2012 at 8:27 PM, Steven Rostedt wrote:
> On Thu, 2012-09-20 at 15:52 -0700, David Sharp wrote:
>> With the addition of the "tsc" clock, formatting timestamps to look like
>> fractional seconds is misleading. Mark clocks as either in nanoseconds or
>>
On Mon, Sep 24, 2012 at 8:27 PM, Steven Rostedt rost...@goodmis.org wrote:
On Thu, 2012-09-20 at 15:52 -0700, David Sharp wrote:
With the addition of the tsc clock, formatting timestamps to look like
fractional seconds is misleading. Mark clocks as either in nanoseconds or
not, and format non
1 - 100 of 140 matches
Mail list logo
