On Tue, Jun 05, 2018 at 08:22:22AM -0600, Jens Axboe wrote:
> > I fucked up majorly on the bioset/mempool conversion - I forgot to check
> > that
> > everything biosets/mempools were being embedded in was actually being
> > zeroed on
> > allocation. Device mapper currently explodes, you'll probab
On Tue, Jun 05, 2018 at 04:07:15PM +0400, Ilya Matveychikov wrote:
> > On Jun 5, 2018, at 3:53 PM, Al Viro wrote:
> > On Tue, Jun 05, 2018 at 03:35:55PM +0400, Ilya Matveychikov wrote:
> >>> On Jun 5, 2018, at 3:26 PM, Al Viro wrote:
> > On Jun 5, 2018, at 6:00 AM, Ilya Matveychikov
> >
Hi,
there's one potential memory leak fix for AFFS. I'm using my main k.org
tree for that.
The branch is based on some random pre-rc7 commit I had in master and
forgot to rebase it on top of rc7 in time. Functionally it should not
matter, but I guess you'd notice.
Please pull, thanks.
-
On Tue, May 22, 2018 at 12:24:25PM +0800, Chengguang Xu wrote:
> When specifying option 'prefix' multiple times,
> current option parsing will cause memory leak.
> Hence, call kfree for previous one in this case.
>
> Signed-off-by: Chengguang Xu
Thanks, the patch and others that may queue up wil
Hi,
please consider pulling a fix for btrfs. This time it's really a
one-liner and prevents leaking an internal error value 1 out of the
ftruncate syscall.
This has been observed in practice. The steps to reproduce make a common
pattern (open/write/fync/ftruncate) but also need the application to
On Tue, May 15, 2018 at 04:54:04AM -0700, Matthew Wilcox wrote:
> > > Subject: btrfs: Allocate extents from ZONE_NORMAL
> > > From: Matthew Wilcox
> > >
> > > If anyone ever passes a GFP_DMA or GFP_MOVABLE allocation flag to
> > > allocate_extent_state, it will try to allocate memory from the wro
On Mon, May 21, 2018 at 08:19:58AM -0600, Jens Axboe wrote:
> On 5/21/18 8:03 AM, Mike Snitzer wrote:
> > On Sun, May 20 2018 at 6:25pm -0400,
> > Kent Overstreet wrote:
> >
> >> Jens - this series does the rest of the conversions that Christoph wanted,
> >> and
> >> drops bioset_create().
> >>
Hi,
we've accumulated some fixes during the last week, some of them were in
the works for a longer time but there are some newer ones too. Most of
the fixes have a reproducer and fix user visible problems, also
candidates for stable kernels. They IMHO qualify for a late rc, though I
did not expect
On Wed, May 16, 2018 at 07:43:40AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Reviewed-by: David Sterba
I can add it to the btrfs queue now, unless you need the patch for the
rest of the series.
On Thu, May 10, 2018 at 04:13:59PM -0700, Luis R. Rodriguez wrote:
> The Linux VFS does not allow a way to set append/immuttable
^^
Typo, in all 3 patches.
> attributes to symlinks, this is just not possible. If this is
> detected inform
On Wed, May 09, 2018 at 08:47:27PM +1000, Stephen Rothwell wrote:
> > True. It's currently only those -fixes branches that people have asked
> > him to merge separately which isn't as big a proportion of trees as have
> > them (perhaps fortunately given people's enthusiasm for fixes branches
> > t
On Wed, May 09, 2018 at 03:42:22PM +0200, Michal Hocko wrote:
> On Tue 24-04-18 13:25:42, Michal Hocko wrote:
> [...]
> > > As a suggestion, could you take
> > > documentation about how to convert to the memalloc_nofs_{save,restore}
> > > scope api (which I think you've written about e-mails at len
On Mon, May 07, 2018 at 05:25:47PM -0700, Matthew Wilcox wrote:
> On Mon, May 07, 2018 at 11:25:01PM +0200, David Sterba wrote:
> > On Mon, May 07, 2018 at 11:44:10AM -0700, Matthew Wilcox wrote:
> > > But something like btrfs should almost certainly be using ~GFP_ZONEMASK.
&g
On Mon, May 07, 2018 at 11:44:10AM -0700, Matthew Wilcox wrote:
> On Mon, May 07, 2018 at 05:16:50PM +, Huaisheng HS1 Ye wrote:
> > I hope it couldn't cause problem, but based on my analyzation it has the
> > potential to go wrong if users still use the flags as usual, which are
> > __GFP_DMA
On Fri, May 04, 2018 at 12:11:12PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake of function name in btrfs_err message
>
> Signed-off-by: Colin Ian King
Applied, thanks.
Hi,
please pull the following branch with 2 regression fixes and one fix for
stable. Thanks.
The following changes since commit c0872323746e11fc79344e3738b283a8cda86654:
btrfs: print-tree: debugging output enhancement (2018-04-20
On Thu, May 03, 2018 at 08:42:59AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Tue, 3 Apr 2018 12:29:19 +1000 Stephen Rothwell
> wrote:
> >
> > Ping?
>
> Ping again ...
>
> So has Chris gone missing? Or should I just remove the btrfs tree from
> linux-next?
As far as btrfs code changes
On Sat, Apr 28, 2018 at 05:33:57PM +, Linus Torvalds wrote:
> On Sat, Apr 28, 2018 at 10:07 AM David Sterba wrote:
>
> > I volunteer to act as a maintainer of AFFS to collect any fixes that
> > might show up and to guard fs/affs/ against another spring cleaning.
>
/affs/ against another spring cleaning.
Link: https://lkml.kernel.org/r/20180425154602.ga8...@bombadil.infradead.org
Link: https://lkml.kernel.org/r/1613268.lKBQxPXt8J@merkaba
CC: Martin Steigerwald
CC: John Paul Adrian Glaubitz
Signed-off-by: David Sterba
---
MAINTAINERS | 4 +++-
1 file
On Thu, Apr 26, 2018 at 12:45:41PM +0200, John Paul Adrian Glaubitz wrote:
> (adding debian-68k)
>
> Hi Matthew!
>
> On 04/26/2018 12:28 PM, Martin Steigerwald wrote:
> > You probably put your stick into a cave with ancient sleeping dragons :)
>
> Indeed.
>
> > Added in linux-m68k mailing list,
On Wed, Apr 25, 2018 at 11:55:31PM +0300, Alexey Dobriyan wrote:
> On Tue, Apr 24, 2018 at 06:54:09AM -0700, Christoph Hellwig wrote:
> > On Tue, Apr 24, 2018 at 12:35:34AM +0300, Alexey Dobriyan wrote:
> > > Bring /proc into 21st century.
> >
> > Please explain what this actually buys us except f
On Wed, Apr 25, 2018 at 08:46:02AM -0700, Matthew Wilcox wrote:
> Recently ncpfs got moved to staging. Also recently, we had some fuzzer
> developers report bugs in hfs, which they deem a security hole because
> Ubuntu attempts to automount an inserted USB device as hfs.
>
> We have no maintainer
c0872323746e11fc79344e3738b283a8cda86654:
btrfs: print-tree: debugging output enhancement (2018-04-20 19:18:16 +0200)
David Sterba (1):
btrfs: fix unaligned access in readdir
Nikolay Borisov (1):
btrfs: Fix race condition
linux/kernel/git/kdave/linux.git
for-4.17-part2-tag
for you to fetch changes up to 5d41be6f702f19f72db816c17175caf9dbdcdfa6:
btrfs: Only check first key for committed tree blocks (2018-04-13 16:16:15
+0200)
David Ster
e replaced with GFP_KERNEL,
> which can sleep and improve the possibility of sucessful allocation.
>
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
>
> Signed-off-by: Jia-Ju Bai
Reviewed-by: David Sterba
We don't h
On Mon, Apr 09, 2018 at 03:52:15PM +0200, Michal Hocko wrote:
> On Mon 09-04-18 06:41:14, Matthew Wilcox wrote:
> > On Mon, Apr 09, 2018 at 02:48:52PM +0200, Michal Hocko wrote:
> > > On Mon 09-04-18 20:25:06, Chao Yu wrote:
> > > [...]
> > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > > >
'm going to
add the patches to a 4.17 pull.
David Sterba (3):
btrfs: replace GPL boilerplate by SPDX -- headers
btrfs: replace GPL boilerplate by SPDX -- sources
btrfs: add SPDX header to Kconfig
fs/btrfs/Kconfig | 2 ++
fs/btrfs/acl.c |
Remove GPL boilerplate text (long, short, one-line) and keep the rest,
ie. personal, company or original source copyright statements. Add the
SPDX header.
Unify the include protection macros to match the file names.
Signed-off-by: David Sterba
---
fs/btrfs/async-thread.h | 21
Remove GPL boilerplate text (long, short, one-line) and keep the rest,
ie. personal, company or original source copyright statements. Add the
SPDX header.
Signed-off-by: David Sterba
---
fs/btrfs/acl.c | 15 +--
fs/btrfs/async-thread.c| 15
Signed-off-by: David Sterba
---
fs/btrfs/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 167e5dc7eadd..23537bc8c827 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0
+
config BTRFS_FS
ng (2):
btrfs: remove redundant check on ret and goto
Btrfs: extent map selftest: add missing void parameter to
btrfs_test_extent_map
David Sterba (37):
btrfs: add (the only possible) __exit annotation
btrfs: add more __cold annotations
btrfs: drop underscores from exported
On Tue, Mar 27, 2018 at 09:13:32PM +0200, Thorsten Leemhuis wrote:
> On 26.03.2018 01:37, Linus Torvalds wrote:
> > […] Anyway. Go out and test. And let's hope next week is nice and calm and
> > I can release the final 4.16 next Sunday without any extra rc's.
> >
> >Linus
>
> Hi!
On Sat, Mar 10, 2018 at 10:19:04AM -0800, Andiry Xu wrote:
> From: Andiry Xu
>
> Sysfs support allows user to get/post information of running NOVA instance.
> After mount, NOVA creates four entries under proc directory
> /proc/fs/nova/pmem#/:
>
> timing_stats IO_statsallocator gc
On Sat, Mar 17, 2018 at 06:27:15PM +0100, Christoph Biedl wrote:
> Greg Kroah-Hartman wrote...
>
> > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote:
>
> > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream.
>
> > > On big-endian systems, this change intruduces severe c
On Mon, Mar 19, 2018 at 05:09:28PM +0200, Michael S. Tsirkin wrote:
> Hello!
> The following code triggered by syzbot
>
> r = get_user_pages_fast(log, 1, 1, &page);
> if (r < 0)
> return r;
> BUG_ON(r != 1);
>
> Just looking at get_user_pages_fast's docu
accessors for super_copy" (2018-03-16
14:49:44 +0100)
--------
David Sterba (1):
Revert "btrfs: use proper endianness accessors for super_copy"
Dmitriy Gorokh (1):
btrfs: Fix NULL pointer exception in find_bio_s
On Fri, Mar 16, 2018 at 01:30:49PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote:
> > Greg Kroah-Hartman wrote...
> >
> > > 4.14-stable review patch. If anyone has any objections, please let me
> > > know.
> >
> > > commit 3c181c12c431fe33b66
On Thu, Mar 15, 2018 at 01:19:07PM +0100, Peter Zijlstra wrote:
> Convert the wait_on_atomic_t() usage to the new wait_var_event() API.
>
> Cc: Chris Mason
> Signed-off-by: Peter Zijlstra (Intel)
Acked-by: David Sterba
On Tue, Mar 13, 2018 at 08:50:22PM +0100, Salvatore Mesoraca wrote:
> Avoid a VLA[1] by using a real constant expression instead of a variable.
> The compiler should be able to optimize the original code and avoid using
> an actual VLA. Anyway this change is useful because it will avoid a false
> p
rg/lkml/2018/3/7/621
>
> Signed-off-by: Kees Cook
Acked-by: David Sterba
for whatever name you decide for the max macro.
On Tue, Mar 06, 2018 at 11:24:05AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> Signed-off-by: Matthew Wilcox
Acked-by: David Sterba
On Tue, Mar 06, 2018 at 11:23:16AM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> The current implementation of btrfs_page_exists_in_range() gives the
> wrong answer if the workingset code has stored a shadow entry in the
> page cache. The filemap_range_has_page() function does not have
Hi,
please consider the follwing btrfs updates, there are bugfixes or fixes
for user visible behaviour.
No merge conflicts. Please pull, thanks.
- when NR_CPUS is large, a SRCU structure can significantly inflate size
of the main filesystem structure that would not be possible to
allocate by
On Fri, Mar 02, 2018 at 07:37:33AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> Commit
>
> 001cafe3c03c ("Btrfs: fix unexpected -EEXIST when creating new inode")
>
> is missing a Signed-off-by from its committer.
Thanks for the notice, this is only temporary. The patch has been merged
to 4.
Hi,
we have a few assorted fixes, some of them show up during fstests so
I gave them more testing. Please pull, thanks.
The following changes since commit 3acbcbfc8f06d4ade2aab2ebba0a2542a05ce90c:
btrfs: drop devid as device_list
Hi,
On Fri, Feb 09, 2018 at 02:11:52PM +1100, Stephen Rothwell wrote:
> Commit
> 7f53a77da963 ("Btrfs: fix btrfs_evict_inode to handle abnormal inodes
> correctly")
> is missing a Signed-off-by from its committer.
thanks for the notice, this has been fixed.
On Thu, Feb 08, 2018 at 02:13:27PM +, Colin King wrote:
> From: Colin Ian King
>
> The function btrfs_test_extent_map requires a void argument to be ANSI C
> compliant and so it matches the prototype in fs/btrfs/tests/btrfs-tests.h
>
> Cleans up sparse warning:
> fs/btrfs/tests/extent-map-te
On Fri, Feb 09, 2018 at 10:40:57AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> [Seems I somehow failed to actually send the following message a couple
> of days ago, sorry.]
>
> After merging the btrfs-kdave tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/b
On Mon, Jan 08, 2018 at 11:06:32PM +, Colin King wrote:
> From: Colin Ian King
>
> Add a missing void parameter to function btrfs_test_extent_map, fixes
> sparse warning:
>
> warning: non-ANSI function declaration of function 'btrfs_test_extent_map'
>
> Signed-off-by: Colin Ian King
Added
On Fri, Jan 12, 2018 at 04:52:58PM +, Colin King wrote:
> From: Colin Ian King
>
> The check for a non-zero ret is redundant as the goto will jump to
> the very next statement anyway. Remove this extraneous code.
>
> Detected by CoverityScan, CID#1463784 ("Identical code for different
> bra
On Mon, Jan 08, 2018 at 11:45:03AM +0200, Nikolay Borisov wrote:
> So here is a small 2 patch set which removes btrfs' manual initialisation of
> the lower level crc32c module. Explanation why is ok can be found in Patch
> 2/2.
>
> Patch 1/2 just adds a function to the generic crc32c header whic
On Fri, Feb 02, 2018 at 09:46:40PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 8, 2018 at 11:45 AM, Nikolay Borisov wrote:
> > The custom crc32 init code was introduced in
> > 14a958e678cd ("Btrfs: fix btrfs boot when compiled as built-in") to
> > enable using btrfs as a built-in. However, later a
Adding linux-cry...@vger.kernel.org to CC
Link to the 2/2 patch https://patchwork.kernel.org/patch/10149203/
On Mon, Jan 08, 2018 at 11:45:04AM +0200, Nikolay Borisov wrote:
> This function returns a string with the currently in-use implementation
> of the crc32c algorithm, i.e crc32c-generic (fo
On Mon, Jan 08, 2018 at 11:45:05AM +0200, Nikolay Borisov wrote:
> The custom crc32 init code was introduced in
> 14a958e678cd ("Btrfs: fix btrfs boot when compiled as built-in") to
> enable using btrfs as a built-in. However, later as pointed out by
> 60efa5eb2e88 ("Btrfs: use late_initcall instea
list_add()
btrfs: drop devid as device_list_add() arg
Arnd Bergmann (1):
btrfs: tree-checker: use %zu format string for size_t
Colin Ian King (1):
btrfs: make function update_share_count static
David Sterba (46):
btrfs: rename device free rcu helper to free_device_rcu
On Mon, Jan 29, 2018 at 02:50:10AM +0800, kbuild test robot wrote:
> From: Fengguang Wu
>
> fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices
>
>
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
>
> Generated by: scripts/coccinelle/api/err_cast.cocci
Hi,
please consider pulling the fix to 4.15. It's been reported recently
that readdir can list stale entries under some conditions. As it is a
user visible bug I'd like to get it fix despite we're in the late rc.
Thanks.
The following changes since commit ec35e48b286959991cdbb886f1bdeda4575c80b4:
On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote:
> Thank you! I shall attempt to debug. Was this with a btrfs root
> filesystem? I'm most suspicious of those patches right now, since they've
> received next to no testing. I'm going to put together a smaller patchset
> which just
On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> This version of the XArray has no known bugs.
I've booted this patchset on 2 boxes, both had random problems during
boot. On one I was not able to diagnose what went wrong. On the other
one the system boot
On Wed, Jan 17, 2018 at 12:21:49PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> The reada_lock in struct btrfs_device was only initialised, and not
> actually used. That's good because there's another lock also called
> reada_lock in the btrfs_fs_info that was quite heavily used. Rem
th));
> + strncpy(di_args->path, name->str, sizeof(di_args->path) - 1);
> rcu_read_unlock();
> di_args->path[sizeof(di_args->path) - 1] = 0;
Reviewed-by: David Sterba
de dirty if that actually
> occurred or if one of the times was updated.
>
> Signed-off-by: Jeff Layton
Acked-by: David Sterba
On Fri, Dec 22, 2017 at 07:05:43AM -0500, Jeff Layton wrote:
> From: Jeff Layton
>
> Signed-off-by: Jeff Layton
Acked-by: David Sterba
Commit-ID: dba04eb76df982703fefc021a4d278347b6176a9
Gitweb: https://git.kernel.org/tip/dba04eb76df982703fefc021a4d278347b6176a9
Author: David Sterba
AuthorDate: Mon, 8 Jan 2018 16:27:31 +0100
Committer: Ingo Molnar
CommitDate: Mon, 8 Jan 2018 17:29:17 +0100
locking/Documentation
The cross-release lockdep functionality has been removed in
e966eaeeb623f0997 ("locking/lockdep: Remove the cross-release locking
checks"), leaving the kernel parameter docs behind. The code handling
the parameter does not exist so this is a plain documentation change.
Signed-off-by: Da
Hi,
we have two more fixes for 4.15, aimed for stable. The leak fix is
obvious, the second patch fixes a bug revealed by the refcount API, when
it behaves differently than previous atomic_t and reports refs going
from 0 to 1 in one case.
No merge conflicts. Please pull, thanks.
The following cha
On Fri, Dec 22, 2017 at 12:55:08AM +, Colin King wrote:
> From: Colin Ian King
>
> Label 'retry' is not used, remove it. Cleans up a clang build
> warning:
>
> warning: label ‘retry’ defined but not used [-Wunused-label]
>
> Fixes: b283738ab0ad ("Revert "btrfs: qgroups: Retry after commit o
On Fri, Dec 22, 2017 at 04:38:24PM +, Colin King wrote:
> From: Colin Ian King
>
> remove extraneous white space in indentation, fix misaligned
> indentation.
Pure whitespace patches are not welcome, sorry.
On Wed, Dec 20, 2017 at 08:12:11AM +0800, Qu Wenruo wrote:
> On 2017年12月20日 06:20, Stephen Rothwell wrote:
> > After merging the btrfs-kdave tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > fs/btrfs/qgroup.c: In function 'qgroup_reserve':
> > fs/btrfs/qgr
On Wed, Dec 06, 2017 at 10:14:31PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge
Added to queue, thanks.
Hi,
this update contains a few fixes (error handling, quota leak, FUA vs
nobarrier mount option). There's one one worth mentioning separately -
an off-by-one fix that leads to overwriting first byte of an adjacent
page with 0, out of bounds of the memory allocated by an ioctl. This is
under a pr
On Thu, Dec 07, 2017 at 08:32:04AM +0800, Qu Wenruo wrote:
>
>
> On 2017年12月06日 22:18, Arnd Bergmann wrote:
> > The return value of sizeof() is of type size_t, so we must print it
> > using the %z format modifier rather than %l to avoid this warning
> > on some architectures:
> >
> > fs/btrfs/tr
ir_item':
> fs/btrfs/tree-checker.c:273:50: error: format '%lu' expects argument of type
> 'long unsigned int', but argument 5 has type 'u32' {aka 'unsigned int'}
> [-Werror=format=]
>
> Fixes: 005887f2e3e0 ("btrfs: tree-checker: Add checker for dir item")
> Signed-off-by: Arnd Bergmann
Reviewed-by: David Sterba
On Fri, Dec 01, 2017 at 09:22:49AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> Commits
>
> f212bed55c85 ("Btrfs: add support for fallocate's zero range operation")
> 2d0d54302a5f ("Btrfs: use cached state when dirtying pages during buffered
> write")
>
> are missing a Signed-off-by from
On Wed, Nov 29, 2017 at 01:38:26PM -0500, Chris Mason wrote:
> On 11/29/2017 12:05 PM, Tejun Heo wrote:
> > On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote:
> >> Hello,
> >>
> >> On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote:
> >>> What has happened with this patch set?
> >>
>
19:6: warning: symbol 'update_share_count' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King
Reviewed-by: David Sterba
On Wed, Nov 29, 2017 at 02:31:24PM -0800, Linus Torvalds wrote:
> On Wed, Nov 29, 2017 at 11:28 AM, David Sterba wrote:
> >
> > With signed tag: for-4.15-rc2-tag
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-4.15-rc2
>
> Oh, please a
b20e1c4230:
Btrfs: incremental send, fix wrong unlink path after renaming file
(2017-11-28 17:15:30 +0100)
--------
David Sterba (2):
btrfs: add missing device::flush_bio puts
btrfs: dev_alloc_list is not protected by RCU, use norma
is Mason
> Cc: Josef Bacik
> Cc: David Sterba
> Cc: linux-bt...@vger.kernel.org
Acked-by: David Sterba
passed uninitialized, but it is never used by the
> callee. However, not all versions of gcc are smart enough to notice.
>
> Hence remove the unused parameter from walk_up_tree() to silence the
> compiler warning.
>
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: David Sterba
On Tue, Nov 14, 2017 at 07:39:11AM +0800, Qu Wenruo wrote:
> > - extend mount options to specify zlib compression level, -o compress=zlib:9
>
> However the support for it has a big problem, it will cause wild memory
> access for "-o compress" mount option.
>
> Kernel ASAN can detect it easily and
btrfs: avoid null pointer dereference on fs_info when calling btrfs_crit
btrfs: make array types static const, reduces object code size
David Sterba (4):
btrfs: scrub: get rid of sector_t
btrfs: rename page offset parameter in submit_extent_page
btrfs: get rid of secto
On Mon, Nov 06, 2017 at 09:04:37AM +0100, SF Markus Elfring wrote:
>
> * Adjust jump targets so that a call of the function "mutex_unlock"
> can be better reused for error cases at the end of this function.
>
> * Replace three calls by goto statements.
>
> This issue was detected by using the
On Tue, Oct 17, 2017 at 11:00:04AM +0200, Arnd Bergmann wrote:
> > 2 fs/btrfs/tree-checker.c:186:4: warning: format '%lu' expects argument of
> > type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
> > 1 fs/btrfs/tree-checker.c:186:70: warning: format '%lu' expects argumen
On Thu, Oct 12, 2017 at 02:43:27PM -0700, Omar Sandoval wrote:
> On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote:
> > Remove variables 'start' and 'end', which are set but never used.
>
> Oops.
>
> Reviewed-by: Omar Sandoval
Thanks, added to the queue.
nt of type
> 'long unsigned int', but argument 6 has type 'unsigned int' [-Werror=format=]
>
> This changes the format string to use %zu instead of %lu for size_t.
>
> Fixes: c1f6520bf360 ("btrfs: tree-checker: Enhance output for
> check_extent_data_item")
> Signed-off-by: Arnd Bergmann
Reviewed-by: David Sterba
as suggested by David
> Sterba.
>
> v2: Fixed missing @bh in submit_bh_blkcg_css() call.
>
> Signed-off-by: Tejun Heo
> Reviewed-by: Liu Bo
> Cc: David Sterba
Acked-by: David Sterba
On Tue, Oct 10, 2017 at 09:43:26AM -0700, Tejun Heo wrote:
> >From 3bbed8c7747739cda48f592f165e8839da076a3a Mon Sep 17 00:00:00 2001
>
> Issuing metdata or otherwise shared IOs from !root cgroup can lead to
> priority inversion. This patch ensures that those IOs are always
> issued from the root
On Tue, Oct 10, 2017 at 01:48:05PM +0300, Rakesh Pandit wrote:
> Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
> frozen fs to avoid deadlock.") started using internal calls and we
> replace them with more suitable ones.
>
> Signed-off-by: Rakesh Pandit
> ---
> fs/btrfs/su
On Sat, Oct 07, 2017 at 04:02:21PM +0200, Thomas Meyer wrote:
> Bool initializations should use true and false. Bool tests don't need
> comparisons.
>
> Signed-off-by: Thomas Meyer
Reviewed-by: David Sterba
On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote:
> One thing that comes up a lot every LSF is the fact that we have no general
> way
> that we do performance testing. Every fs developer has a set of scripts or
> things that they run with varying degrees of consistency, but nothing cen
Hi,
we have two more fixes for bugs introduced in 4.13. The sector_t problem with
32bit architecture and !LBDAF config seems serious but the number of affected
deployments is hopefully low. The clashing status bits could lead to a
confusing in-memory state of the whole-filesystem operations if us
Hi,
we've collected a bunch of isolated fixes, for crashes, user-visible behaviour
or missing bits from other subsystem cleanups from the past. The overall
number is not small but I was not able to make it significantly smaller. Most
of the patches are supposed to go to stable. There are no merge
dang, not meant for linux-kernel@, please ignore.
Hi,
I've updated the Status page and synced the manual pages from btrfs-progs git.
The status of various features is split to one more column, Performance.
There's a section for each 'mostly OK' status below the table and linked from
the note. This will hopefully be more understandable than just
s dec hex filename
> 90536 6552 64 97152 17b80 fs/btrfs/ioctl.o
>
> After:
>text data bss dec hex filename
> 90414 6616 64 97094 17b46 fs/btrfs/ioctl.o
>
> Signed-off-by: Colin Ian King
Reviewed-by: David Sterba
On Wed, Sep 13, 2017 at 01:02:19PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais
> ---
> fs/btrfs/check-integrity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
> index 7d5a9b5..efa4c23 100644
> --- a/fs/b
check to see if fs_info
> is null and only print the s_id if fs_info is non-null.
>
> Detected by CoverityScan CID#401973 ("Dereference after null check")
>
> Fixes: efe120a067c8 ("Btrfs: convert printk to btrfs_ and fix BTRFS prefix")
> Signed-off-by: Colin Ian King
Reviewed-by: David Sterba
On Sat, Sep 09, 2017 at 03:29:34PM +0100, Christos Gkekas wrote:
> The value of variable 'can_recover' is never used after being set, thus
> it should be removed.
Seems it has never been used since introduction in commit
68a7342c51c95042 .
Reviewed-by: David Sterba
>
> S
for the fsid
btrfs: use BTRFS_FSID_SIZE for fsid
btrfs: remove unused BTRFS_COMPRESS_LAST
Colin Ian King (1):
btrfs: remove redundant check on ret being non-zero
David Sterba (30):
btrfs: drop newlines from strings when using btrfs_* helpers
btrfs: use GFP_KERNEL in moun
301 - 400 of 698 matches
Mail list logo
