On Thu, May 09, 2013 at 09:47:45AM +1000, Stephen Rothwell wrote:
[Just forwarding to David ...]
On Wed, 08 May 2013 11:04:45 -0700 Randy Dunlap rdun...@infradead.org wrote:
on x86_64:
when CONFIG_GFS2_FS_LOCKING_DLM=y and CONFIG_DLM=m:
fs/built-in.o: In function `gfs2_lock':
activity, even when no posix
locks had been used.
This patch copies the nfs approach, and skips the full posix
unlock if there is no plock found during the vfs unlock phase.
Signed-off-by: David Teigland
---
fs/dlm/plock.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions
activity, even when no posix
locks had been used.
This patch copies the nfs approach, and skips the full posix
unlock if there is no plock found during the vfs unlock phase.
Signed-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/plock.c | 18 +++---
1 file changed, 15 insertions
On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote:
> However, we still have the problem that if the machine panics and we want
> to jump into the kdump kernel, we need to 'kick' the watchdog one more
> time. This provides us a sane sync point for determining how long we have
> to load
On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote:
However, we still have the problem that if the machine panics and we want
to jump into the kdump kernel, we need to 'kick' the watchdog one more
time. This provides us a sane sync point for determining how long we have
to load the
On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote:
> Please consider pulling the following changes,
There's some mixup here that should be cleared up first.
> David Teigland (2):
> GFS2: Fix unlock of fcntl locks during withdrawn state
>
> Steve
On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote:
Please consider pulling the following changes,
There's some mixup here that should be cleared up first.
David Teigland (2):
GFS2: Fix unlock of fcntl locks during withdrawn state
Steven Whitehouse (1):
GFS2
On Mon, Mar 11, 2013 at 01:28:18PM -0700, Tejun Heo wrote:
> Ah, right, in preloaded section, the allocation is expected to fail
> before falling back to the preload buffer and I forgot to add
> __GFP_NOWARN to the first try. Something like the following should
> make it go away. Can you please
On Mon, Mar 11, 2013 at 01:28:18PM -0700, Tejun Heo wrote:
Ah, right, in preloaded section, the allocation is expected to fail
before falling back to the preload buffer and I forgot to add
__GFP_NOWARN to the first try. Something like the following should
make it go away. Can you please test
On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
> static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
> {
> struct dlm_lkb *lkb;
> - int rv, id;
> + int rv;
>
> lkb = dlm_allocate_lkb(ls);
> if (!lkb)
> @@ -1199,19 +1199,13 @@ static int
On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
{
struct dlm_lkb *lkb;
- int rv, id;
+ int rv;
lkb = dlm_allocate_lkb(ls);
if (!lkb)
@@ -1199,19 +1199,13 @@ static int
-by: David Teigland
---
fs/dlm/dlm_internal.h | 3 +++
fs/dlm/lock.c | 15 +++
2 files changed, 18 insertions(+)
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h
index 77c0f70..e7665c3 100644
--- a/fs/dlm/dlm_internal.h
+++ b/fs/dlm/dlm_internal.h
@@ -96,10 +96,13 @@ do
-by: David Teigland teigl...@redhat.com
---
fs/dlm/dlm_internal.h | 3 +++
fs/dlm/lock.c | 15 +++
2 files changed, 18 insertions(+)
diff --git a/fs/dlm/dlm_internal.h b/fs/dlm/dlm_internal.h
index 77c0f70..e7665c3 100644
--- a/fs/dlm/dlm_internal.h
+++ b/fs/dlm/dlm_internal.h
; id += slot_distance.
> >
> > Signed-off-by: Tejun Heo
> > Reported-by: David Teigland
> > Cc: KAMEZAWA Hiroyuki
>
> David, can you please test whether the patch makes the skipped
> deletion bug go away?
Yes, I've tested, and it works fine now.
Thanks,
Dave
--
To
-off-by: Tejun Heo t...@kernel.org
Reported-by: David Teigland teigl...@redhat.com
Cc: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com
David, can you please test whether the patch makes the skipped
deletion bug go away?
Yes, I've tested, and it works fine now.
Thanks,
Dave
On Mon, Feb 04, 2013 at 12:06:55PM -0500, David Teigland wrote:
> Please pull the following fix from branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git for-linus
>
> This reverts commit 2b75bc9121e54e22537207b47b71373bcb0be41c.
Hi Linus,
You can
which could lead to OOM.
Reported-by: Sasha Levin
Signed-off-by: David Teigland
---
fs/dlm/user.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index eb4ed9b..911649a 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -503,6 +503,13 @@ static ssize_t device
of a case where
this breaks userland (clvmd) when maximum resource name
lengths are used. I am still sorting out exactly which
combinations of kernel and userland libs are a problem.
Reported-by: Jana Saout
CC: Sasha Levin
Signed-off-by: David Teigland
---
fs/dlm/user.c | 7 ---
1 file
of a case where
this breaks userland (clvmd) when maximum resource name
lengths are used. I am still sorting out exactly which
combinations of kernel and userland libs are a problem.
Reported-by: Jana Saout j...@saout.de
CC: Sasha Levin levinsasha...@gmail.com
Signed-off-by: David Teigland teigl
-by: Sasha Levin levinsasha...@gmail.com
Signed-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/user.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/fs/dlm/user.c b/fs/dlm/user.c
index eb4ed9b..911649a 100644
--- a/fs/dlm/user.c
+++ b/fs/dlm/user.c
@@ -503,6 +503,13 @@ static
On Mon, Feb 04, 2013 at 12:06:55PM -0500, David Teigland wrote:
Please pull the following fix from branch:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git for-linus
This reverts commit 2b75bc9121e54e22537207b47b71373bcb0be41c.
Hi Linus,
You can choose to pull
On Thu, Jan 31, 2013 at 04:18:41PM -0800, Tejun Heo wrote:
> It looks a bit weird to me that ls->ls_recover_list_count is also
> incremented by recover_list_add(). The two code paths don't seem to
> be interlocke at least upon my very shallow glance. Is it that only
> either the list or idr is
On Thu, Jan 31, 2013 at 04:18:41PM -0800, Tejun Heo wrote:
It looks a bit weird to me that ls-ls_recover_list_count is also
incremented by recover_list_add(). The two code paths don't seem to
be interlocke at least upon my very shallow glance. Is it that only
either the list or idr is in
On Tue, Jan 29, 2013 at 10:13:17AM -0500, David Teigland wrote:
> On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote:
> > On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote:
> > > idr_destroy() can destroy idr by itself and idr_remove_all() is bein
On Tue, Jan 29, 2013 at 10:13:17AM -0500, David Teigland wrote:
On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote:
On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote:
idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated
On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote:
> On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote:
> > idr_destroy() can destroy idr by itself and idr_remove_all() is being
> > deprecated.
> >
> > The conversion isn't completely tr
On Mon, Jan 28, 2013 at 10:57:23AM -0500, David Teigland wrote:
On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote:
idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.
The conversion isn't completely trivial for recover_idr_clear() as
it's the only
gt; idr_remove_all() w/o idr_destroy(). Replace it with idr_remove() call
> inside idr_for_each_entry() loop. It goes on top so that it matches
> the operation order in recover_idr_del().
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Christine Caulfield
).
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Christine Caulfield
> Cc: David Teigland
> Cc: cluster-de...@redhat.com
> ---
> This patch depends on an earlier idr patch and I think it would be
> best to route these together through -mm. Christi
tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Christine Caulfield ccaul...@redhat.com
Cc: David Teigland teigl...@redhat.com
Cc: cluster-de...@redhat.com
---
This patch depends on an earlier idr patch and I think it would be
best to route these together through -mm. Christine, David
idr_destroy(). Replace it with idr_remove() call
inside idr_for_each_entry() loop. It goes on top so that it matches
the operation order in recover_idr_del().
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Christine Caulfield ccaul...@redhat.com
Cc: David Teigland teigl
Hi Linus,
Please pull dlm updates from tag:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.8
This set fixes some conditions in which value blocks are invalidated,
and includes two trivial cleanups.
Thanks,
Dave
David Teigland (1):
dlm: fix lvb invalidation
Hi Linus,
Please pull dlm updates from tag:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git dlm-3.8
This set fixes some conditions in which value blocks are invalidated,
and includes two trivial cleanups.
Thanks,
Dave
David Teigland (1):
dlm: fix lvb invalidation
On Mon, Oct 29, 2012 at 12:07:10PM -0400, Mathieu Desnoyers wrote:
> I'm fine with turning a direct + modulo mapping into a dispersed hash as
> long as there are no underlying assumptions about sequentiality of value
> accesses.
>
> If the access pattern would happen to be typically sequential,
On Mon, Oct 29, 2012 at 12:07:10PM -0400, Mathieu Desnoyers wrote:
I'm fine with turning a direct + modulo mapping into a dispersed hash as
long as there are no underlying assumptions about sequentiality of value
accesses.
If the access pattern would happen to be typically sequential, then
both access configfs data simultaneously. The
second reworks some code to get around a long standing, but intentional,
unlock balance warning. The userland daemon no longer takes a lock that
is later released from the kernel. The other commits are minor fixes and
changes.
Thanks,
Dave
David
both access configfs data simultaneously. The
second reworks some code to get around a long standing, but intentional,
unlock balance warning. The userland daemon no longer takes a lock that
is later released from the kernel. The other commits are minor fixes and
changes.
Thanks,
Dave
David
On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote:
> device_write only checks whether the request size is big enough, but it
> doesn't
> check if the size is too big.
>
> At that point, it also tries to allocate as much memory as the user has
> requested
> even if it's too much. This
On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote:
device_write only checks whether the request size is big enough, but it
doesn't
check if the size is too big.
At that point, it also tries to allocate as much memory as the user has
requested
even if it's too much. This can
On Mon, Aug 13, 2012 at 02:29:55PM +0800, Ying Xue wrote:
> But I have submitted another patch:
> https://lkml.org/lkml/2012/8/9/668
Yes I got it, to see all the patches I've pushed out, check here:
On Mon, Aug 13, 2012 at 02:29:55PM +0800, Ying Xue wrote:
But I have submitted another patch:
https://lkml.org/lkml/2012/8/9/668
Yes I got it, to see all the patches I've pushed out, check here:
On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote:
> Since add_sock() always returns a success code - 0, its return
> value type should be changed from integer to void.
Thanks, I've pushed those to my next branch.
Dave
--
To unsubscribe from this list: send the line "unsubscribe
On Fri, Aug 10, 2012 at 02:58:42PM +0800, Ying Xue wrote:
Since add_sock() always returns a success code - 0, its return
value type should be changed from integer to void.
Thanks, I've pushed those to my next branch.
Dave
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
through a hash bucket.
The other commits include minor fixes and changes.
Thanks,
Dave
David Teigland (6):
dlm: use rsbtbl as resource directory
dlm: use idr instead of list for recovered rsbs
dlm: fix race between remove and lookup
dlm: use wait_event_timeout
dlm: fix
through a hash bucket.
The other commits include minor fixes and changes.
Thanks,
Dave
David Teigland (6):
dlm: use rsbtbl as resource directory
dlm: use idr instead of list for recovered rsbs
dlm: fix race between remove and lookup
dlm: use wait_event_timeout
dlm: fix
When a large number of resources are being recovered,
a linear search of the recover_list takes a long time.
Use an idr in place of a list.
Signed-off-by: David Teigland
---
fs/dlm/dlm_internal.h |3 ++
fs/dlm/lockspace.c|3 ++
fs/dlm/rcom.c |2 +-
fs/dlm/recover.c
has
been sent. A lookup checks if this in-progress
remove matches the name it is looking up.
Signed-off-by: David Teigland
---
fs/dlm/dlm_internal.h | 13
fs/dlm/lock.c | 181 +++--
fs/dlm/lockspace.c| 21 +-
3 files changed
Use wait_event_timeout to avoid using a timer
directly.
Signed-off-by: David Teigland
---
fs/dlm/recover.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c
index ff6f276..12702cc 100644
--- a/fs/dlm
The process of rebuilding locks on a new master during
recovery could re-order the locks on the convert queue,
creating an "in place" conversion deadlock that would
not be resolved. Fix this by not considering queue
order when granting conversions after recovery.
Signed-off-by: Davi
-off-by: David Teigland
---
fs/dlm/lock.c | 70 +++--
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 04e3f15..b569507 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -4000,12 +4000,70 @@ static
patch is made possible by the dirtbl removal, and
fixes a long standing race between resource removal and lookup by
reworking how removal is done. At the same time it improves the shrink
function efficiency by avoiding repeated searches through hash buckets.
David Teigland (6):
dlm: use
patch is made possible by the dirtbl removal, and
fixes a long standing race between resource removal and lookup by
reworking how removal is done. At the same time it improves the shrink
function efficiency by avoiding repeated searches through hash buckets.
David Teigland (6):
dlm: use
-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/lock.c | 70 +++--
1 file changed, 68 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 04e3f15..b569507 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -4000,12
The process of rebuilding locks on a new master during
recovery could re-order the locks on the convert queue,
creating an in place conversion deadlock that would
not be resolved. Fix this by not considering queue
order when granting conversions after recovery.
Signed-off-by: David Teigland
Use wait_event_timeout to avoid using a timer
directly.
Signed-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/recover.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/fs/dlm/recover.c b/fs/dlm/recover.c
index ff6f276..12702cc 100644
has
been sent. A lookup checks if this in-progress
remove matches the name it is looking up.
Signed-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/dlm_internal.h | 13
fs/dlm/lock.c | 181 +++--
fs/dlm/lockspace.c| 21
When a large number of resources are being recovered,
a linear search of the recover_list takes a long time.
Use an idr in place of a list.
Signed-off-by: David Teigland teigl...@redhat.com
---
fs/dlm/dlm_internal.h |3 ++
fs/dlm/lockspace.c|3 ++
fs/dlm/rcom.c |2 +-
fs
insertions(+), 2 deletions(-)
commit d7c2feaf88df39124e278b9e775b245b057ac99e
Author: David Teigland <[EMAIL PROTECTED]>
Date: Thu Feb 21 15:27:09 2008 -0600
dlm: update git tree in MAINTAINERS
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
diff --git a/MAINTAINERS b
insertions(+), 2 deletions(-)
commit d7c2feaf88df39124e278b9e775b245b057ac99e
Author: David Teigland [EMAIL PROTECTED]
Date: Thu Feb 21 15:27:09 2008 -0600
dlm: update git tree in MAINTAINERS
Signed-off-by: David Teigland [EMAIL PROTECTED]
diff --git a/MAINTAINERS b/MAINTAINERS
index
On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote:
> Hi David,
>
> On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland <[EMAIL PROTECTED]> wrote:
> >
> > dlm (distributed lock manager) tree:
> >
> > git://git.kernel.org/pub/scm/linux/kerne
On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote:
> We are up to 26 trees, more are welcome (even if they are currently empty).
dlm (distributed lock manager) tree:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next
Dave
--
To unsubscribe from this list: send
On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote:
> dlm_print_rsb() can now become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Thanks, added to dlm.git.
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL
On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
> cluster_set is only called from the macro CLUSTER_ATTR which defines
> read/write
> access functions. Make the signedness match to avoid sparse warnings every
> time
> CLUSTER_ATTR is used (lines 149-159) all of the form:
>
>
On Wed, Feb 13, 2008 at 11:29:38PM +0200, Adrian Bunk wrote:
dlm_print_rsb() can now become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Thanks, added to dlm.git.
Dave
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
cluster_set is only called from the macro CLUSTER_ATTR which defines
read/write
access functions. Make the signedness match to avoid sparse warnings every
time
CLUSTER_ATTR is used (lines 149-159) all of the form:
On Tue, Feb 19, 2008 at 06:38:25PM +1100, Stephen Rothwell wrote:
We are up to 26 trees, more are welcome (even if they are currently empty).
dlm (distributed lock manager) tree:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next
Dave
--
To unsubscribe from this list: send
On Wed, Feb 20, 2008 at 10:03:29AM +1100, Stephen Rothwell wrote:
Hi David,
On Tue, 19 Feb 2008 14:04:50 -0600 David Teigland [EMAIL PROTECTED] wrote:
dlm (distributed lock manager) tree:
git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm.git next
Thanks, added.
Does
On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote:
> On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
> > default_groups was allocated with kcalloc, so initialize to NULL
> > is unnecessary.
>
> NACK - this isn't a performance critical section of code and that line makes
>
On Mon, Feb 18, 2008 at 11:30:30AM -0800, Mark Fasheh wrote:
On Mon, Feb 11, 2008 at 06:08:31PM +0900, Joonwoo Park wrote:
default_groups was allocated with kcalloc, so initialize to NULL
is unnecessary.
NACK - this isn't a performance critical section of code and that line makes
the
dlm: receive_rcom_lock_args() overflow check
dlm: make find_rsb() fail gracefully when namelen is too large
dlm: fix overflows when copying from ->m_extra to lvb
dlm: fix dlm_dir_lookup() handling of too long names
dlm: dlm/user.c input validation fixes
David Teigland (2):
: receive_rcom_lock_args() overflow check
dlm: make find_rsb() fail gracefully when namelen is too large
dlm: fix overflows when copying from -m_extra to lvb
dlm: fix dlm_dir_lookup() handling of too long names
dlm: dlm/user.c input validation fixes
David Teigland (2):
dlm
From: Denis Cheng <[EMAIL PROTECTED]>
it moves 365 bytes from .text to .init.text, and 30 bytes from .text to
.exit.text, saves memory.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/config.c|2 +-
fs/dlm/
Put lkb_astparam in a union with a dlm_user_args pointer to
eliminate a lot of type casting.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/debug_fs.c |6 ++
fs/dlm/dlm_internal.h |5 -
fs/dlm/lock.c | 14 ++
fs/dlm/memory.c
Use proper types for ast and bast functions, and use
consistent type for ast param.
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/ast.c |9 +++
fs/dlm/dlm_internal.h | 14 +---
fs/dlm/lock.c
From: Al Viro <[EMAIL PROTECTED]>
... those can happen and BUG() from DLM_ASSERT() in allocate_direntry() is
not a good way to handle them.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c |3 +++
1 files cha
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6d98cf9..5b82187 1
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6c605fc..0593dd8 1
tually oops before
that while calculating hash of up to 64Kb worth of data - with data
actually being 64 _bytes_ in kmalloc()'ed struct.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |6 +-
1 files changed,
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c |2 +-
fs/dlm/dlm_internal.h |2 +-
fs/dlm/rcom.c | 11 ++-
fs/dlm/recover.c |4 ++--
4
gnment.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |2 +-
fs/dlm/requestqueue.c | 12 ++--
fs/dlm/requestqueue.h |2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/dlm/lock
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/lock.c |3 +++
fs/dlm/rcom.c | 12 +++-
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/f
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/rcom.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c
index 3f9b96f..a312f1d 1
From: Al Viro <[EMAIL PROTECTED]>
a) in device_write(): add sentinel NUL byte, making sure that lspace.name will
be NUL-terminated
b) in compat_input() be keep it simple about the amounts of data we are copying.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teig
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h | 22 +++---
fs/dlm/lock.c | 34 +++---
fs/dlm/rcom.c | 14
From: Al Viro <[EMAIL PROTECTED]>
* check that length is large enough to cover the non-variable part of message or
rcom resp. (after checking that it's large enough to cover the header, of
course).
* kill more pointless casts
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-o
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dlm_internal.h |6 +++---
fs/dlm/rcom.c | 15 ---
fs/dlm/util.c | 20
3 files chan
From: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: David Teigland <[EMAIL PROTECTED]>
---
fs/dlm/dir.c | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
inde
m: dlm/user.c input validation fixes
David Teigland (2):
dlm: proper types for asts and basts
dlm: eliminate astparam type casting
Denis Cheng (1):
dlm: add __init and __exit marks to init and exit functions
fs/dlm/ast.c |9 ++--
fs/dlm/config.c |2 +-
/user.c input validation fixes
David Teigland (2):
dlm: proper types for asts and basts
dlm: eliminate astparam type casting
Denis Cheng (1):
dlm: add __init and __exit marks to init and exit functions
fs/dlm/ast.c |9 ++--
fs/dlm/config.c |2 +-
fs/dlm
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dlm_internal.h |6 +++---
fs/dlm/rcom.c | 15 ---
fs/dlm/util.c | 20
3 files changed, 11 insertions(+), 30
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dir.c | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
index ce30136..831050e 100644
From: Al Viro [EMAIL PROTECTED]
* check that length is large enough to cover the non-variable part of message or
rcom resp. (after checking that it's large enough to cover the header, of
course).
* kill more pointless casts
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dlm_internal.h | 22 +++---
fs/dlm/lock.c | 34 +++---
fs/dlm/rcom.c | 14 +++---
fs/dlm
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |3 +++
fs/dlm/rcom.c | 12 +++-
2 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 75176b5
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/rcom.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c
index 3f9b96f..a312f1d 100644
--- a/fs/dlm
From: Al Viro [EMAIL PROTECTED]
a) in device_write(): add sentinel NUL byte, making sure that lspace.name will
be NUL-terminated
b) in compat_input() be keep it simple about the amounts of data we are copying.
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/dir.c |2 +-
fs/dlm/dlm_internal.h |2 +-
fs/dlm/rcom.c | 11 ++-
fs/dlm/recover.c |4 ++--
4 files changed, 10
.
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |2 +-
fs/dlm/requestqueue.c | 12 ++--
fs/dlm/requestqueue.h |2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index
From: Al Viro [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 6c605fc..0593dd8 100644
--- a/fs/dlm
oops before
that while calculating hash of up to 64Kb worth of data - with data
actually being 64 _bytes_ in kmalloc()'ed struct.
Signed-off-by: Al Viro [EMAIL PROTECTED]
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/dlm/lock.c |6 +-
1 files changed, 5 insertions(+), 1 deletions
101 - 200 of 389 matches
Mail list logo
