Re: [RFC PATCH v2] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-08 Thread David Z. Dai
On Mon, 2019-10-07 at 10:27 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to address possible race conditions that can exist > between network configuration and power management. A similar issue was > fixed for igb in commit 9474933caf21 ("igb: close/suspend race i

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread David Z. Dai
On Mon, 2019-10-07 at 10:02 -0700, Alexander Duyck wrote: > On Mon, Oct 7, 2019 at 8:51 AM David Z. Dai wrote: > > > > > > > We have tested on one of the test box. > > With this patch, it doesn't crash kernel anymore, which is good! > > > > Howeve

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread David Z. Dai
On Sat, 2019-10-05 at 10:22 -0700, Alexander Duyck wrote: > On Fri, Oct 4, 2019 at 7:18 PM David Z. Dai wrote: > > > > On Fri, 2019-10-04 at 16:36 -0700, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > This patch is meant to addre

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-04 Thread David Z. Dai
On Fri, 2019-10-04 at 16:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to address possible race conditions that can exist > between network configuration and power management. A similar issue was > fixed for igb in commit 9474933caf21 ("igb: close/suspend race i

Re: [v1] e1000e: EEH on e1000e adapter detects io perm failure can trigger crash

2019-10-04 Thread David Z. Dai
On Fri, 2019-10-04 at 07:35 -0700, Alexander Duyck wrote: > On Thu, Oct 3, 2019 at 5:02 PM David Z. Dai wrote: > > > > On Thu, 2019-10-03 at 13:39 -0700, Alexander Duyck wrote: > > > On Thu, Oct 3, 2019 at 11:51 AM David Z. Dai > > > wrote: > > > &

Re: [v1] e1000e: EEH on e1000e adapter detects io perm failure can trigger crash

2019-10-03 Thread David Z. Dai
On Thu, 2019-10-03 at 13:39 -0700, Alexander Duyck wrote: > On Thu, Oct 3, 2019 at 11:51 AM David Z. Dai wrote: > > > > On Thu, 2019-10-03 at 10:39 -0700, Alexander Duyck wrote: > > > On Thu, Oct 3, 2019 at 9:59 AM David Dai wrote: > > > > > > >

Re: [v1] e1000e: EEH on e1000e adapter detects io perm failure can trigger crash

2019-10-03 Thread David Z. Dai
On Thu, 2019-10-03 at 10:39 -0700, Alexander Duyck wrote: > On Thu, Oct 3, 2019 at 9:59 AM David Dai wrote: > > > > We see the behavior when EEH e1000e adapter detects io permanent failure, > > it will crash kernel with this stack: > > EEH: Beginning: 'error_detected(permanent failure)' > > EEH: P

Re: [v2] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate

2019-08-30 Thread David Z. Dai
On Fri, 2019-08-30 at 13:33 -0700, David Miller wrote: > From: "David Z. Dai" > Date: Fri, 30 Aug 2019 15:03:52 -0500 > > > I have the impression that last parameter num value should be larger > > than the attribute num value in 2nd parameter (TC_POLICE_RAT

Re: [v2] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate

2019-08-30 Thread David Z. Dai
On Fri, 2019-08-30 at 12:11 -0700, Cong Wang wrote: > On Fri, Aug 30, 2019 at 12:06 PM David Dai wrote: > > - if (p->peak_present) > > + if ((police->params->rate.rate_bytes_ps >= (1ULL << 32)) && > > + nla_put_u64_64bit(skb, TCA_POLICE_RATE64, > > +

Re: [v1] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate

2019-08-29 Thread David Z. Dai
On Thu, 2019-08-29 at 10:32 +0200, Eric Dumazet wrote: > > On 8/29/19 12:51 AM, David Dai wrote: > > For high speed adapter like Mellanox CX-5 card, it can reach upto > > 100 Gbits per second bandwidth. Currently htb already supports 64bit rate > > in tc utility. However police action rate and pea