Re: [PATCH] net: thunderx: prevent concurrent data re-writing by nicvf_set_rx_mode

2018-06-11 Thread Dean Nelson
On 06/10/2018 02:35 PM, David Miller wrote: From: Vadim Lomovtsev Date: Fri, 8 Jun 2018 02:27:59 -0700 + /* Save message data locally to prevent them from +* being overwritten by next ndo_set_rx_mode call(). +*/ + spin_lock(&nic->rx_mode_wq_lock); + mode = vf

Re: net: thunder: change q_len's type to handle max ring size

2018-02-09 Thread Dean Nelson
On 02/08/2018 10:29 PM, Sunil Kovvuri wrote: On Fri, Feb 9, 2018 at 3:27 AM, Dean Nelson wrote: On 02/08/2018 02:34 PM, David Miller wrote: From: Dean Nelson Date: The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 entries per. ... Another way to solve this could have

Re: net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread Dean Nelson
On 02/08/2018 02:34 PM, David Miller wrote: From: Dean Nelson Date: The Cavium thunder nicvf driver supports rx/tx rings of up to 65536 entries per. The number of entires are stored in the q_len member of struct q_desc_mem. The problem is that q_len being a u16, results in 65536 becoming 0

net: thunder: change q_len's type to handle max ring size

2018-02-08 Thread Dean Nelson
ETDEV WATCHDOG: enP2p1s0f1 (nicvf): transmit queue 7 timed out" warning. This patch remedies the problem by changing q_len to a u32. Signed-off-by: Dean Nelson --- drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[tip:perf/core] tools lib traceevent: Add checks for returned EVENT_ERROR type

2015-08-21 Thread tip-bot for Dean Nelson
Commit-ID: 6f56e9cf581c6cedcaea3eb69444b169867ccf3d Gitweb: http://git.kernel.org/tip/6f56e9cf581c6cedcaea3eb69444b169867ccf3d Author: Dean Nelson AuthorDate: Thu, 20 Aug 2015 11:16:32 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 21 Aug 2015 10:35:09 -0300 tools lib

Re: [PATCH v3] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-20 Thread Dean Nelson
On 08/20/2015 12:05 PM, Steven Rostedt wrote: On Thu, 20 Aug 2015 11:16:32 -0400 Dean Nelson wrote: Running the following perf-stat command on an arm64 system produces the following result... [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1 Warning: [kmem:mm_page_alloc

Re: [PATCH v2] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-20 Thread Dean Nelson
On 08/10/2015 07:22 AM, Dean Nelson wrote: Running the following perf-stat command on an arm64 system produces the following result... [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1 Warning: [kmem:mm_page_alloc] function sizeof not defined Warning: Error: expected

[PATCH v3] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-20 Thread Dean Nelson
addressed by this patch's first hunk. And the SIGSEGV is eliminated by its second hunk. Signed-off-by: Dean Nelson --- Changes in v3: - The desire was that a goto be used, not what I'd done in v2. Changes in v2: - Moved the second hunk's check for EVENT_ERROR to a separate li

Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-10 Thread Dean Nelson
On 08/08/2015 10:10 PM, Namhyung Kim wrote: On Fri, Aug 07, 2015 at 12:59:10PM +0200, Jiri Olsa wrote: On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: The second warning message and SIGSEGV stem from the issue expressed in the first warning message, and are the result of ignoring

[PATCH v2] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-10 Thread Dean Nelson
addressed by this patch's first hunk. And the SIGSEGV is eliminated by its second hunk. Signed-off-by: Dean Nelson --- Changes in v2: - Moved the second hunk's check for EVENT_ERROR to a separate line. tools/lib/traceevent/event-parse.c | 6 +- 1 file changed, 5 insertions(+),

Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-07 Thread Dean Nelson
On 08/07/2015 07:16 AM, Namhyung Kim wrote: Hi, On Fri, Aug 7, 2015 at 7:59 PM, Jiri Olsa wrote: On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: Running the following perf-stat command on an arm64 system produces the following result... [root@aarch64 ~]# perf stat -e

Re: [PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-07 Thread Dean Nelson
On 08/07/2015 05:59 AM, Jiri Olsa wrote: On Mon, Aug 03, 2015 at 01:08:05PM -0400, Dean Nelson wrote: Running the following perf-stat command on an arm64 system produces the following result... [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1 Warning: [kmem:mm_page_alloc

[PATCH] tools lib traceevent: add checks for returned EVENT_ERROR type

2015-08-03 Thread Dean Nelson
addressed by this patch's first hunk. And the SIGSEGV is eliminated by its second hunk. Signed-off-by: Dean Nelson --- tools/lib/traceevent/event-parse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-pa

Re: [PATCH] mm: soft-offline: fix num_poisoned_pages counting on concurrent events

2015-04-23 Thread Dean Nelson
s this wrong counting by checking TestSetPageHWPoison for > normal papes and by checking the return value of > dequeue_hwpoisoned_huge_page() > for hugepages. > > Signed-off-by: Naoya Horiguchi Acked-by: Dean Nelson > Cc: sta...@vger.kernel.org # v3.14+ > --- > # This proble

Re: [PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage

2015-04-23 Thread Dean Nelson
let's check hpage instead of p. > > Signed-off-by: Naoya Horiguchi Acked-by: Dean Nelson > --- > mm/hwpoison-inject.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c > index 2b3

Re: [PATCH 1/2] mm/hwpoison-inject: fix refcounting in no-injection case

2015-04-23 Thread Dean Nelson
adds the refcount releasing code. > > Signed-off-by: Naoya Horiguchi Acked-by: Dean Nelson > --- > mm/hwpoison-inject.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c > index 329

Re: [PATCH] mm/memory-failure: call shake_page() when error hits thp tail page

2015-04-16 Thread Dean Nelson
) > Signed-off-by: Naoya Horiguchi This looks correct to me. Thanks! Acked-by: Dean Nelson > Cc: sta...@vger.kernel.org # v3.4+ > --- > mm/memory-failure.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git v4.0.orig/mm/memory-failure.c v4.0/mm/me

Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-05-14 Thread Dean Nelson
On 05/05/2014 04:47 PM, Iyappan Subramanian wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makef

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
On Mon, Aug 27, 2007 at 07:15:44PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 01:10:56PM -0500, Dean Nelson wrote: > > On Mon, Aug 27, 2007 at 05:13:28PM +0100, Al Viro wrote: > > > On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > > > > This patch e

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
On Mon, Aug 27, 2007 at 05:13:28PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 10:59:33AM -0500, Dean Nelson wrote: > > This patch exports __put_task_struct as it is needed by XPMEM. > > > > Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> > > > >

[PATCH 4/4] add SGI Altix cross partition memory (XPMEM) driver

2007-08-27 Thread Dean Nelson
This patch has been bzip2'd and included as an attachment due to size. xpmem-module.v002.bz2 Description: application/bzip

[PATCH 3/4] add new lock ordering rule to mm/filemap.c

2007-08-27 Thread Dean Nelson
This patch adds a lock ordering rule to avoid a potential deadlock when multiple mmap_sems need to be locked. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> Index: linux-2.6/mm/filemap.c === --- linux-2.6.orig/mm/filemap.c 2

[PATCH 2/4] export zap_page_range for XPMEM

2007-08-27 Thread Dean Nelson
This patch exports zap_page_range as it is needed by XPMEM. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> --- XPMEM would have used sys_madvise() except that madvise_dontneed() madvise_dontneed() returns an -EINVAL if VM_PFNMAP is set, which is always true for the pages XPMEM import

[PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Dean Nelson
This patch exports __put_task_struct as it is needed by XPMEM. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> --- One struct file_operations registered by XPMEM, xpmem_open(), calls 'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls 'put_task

[PATCH 0/4] SGI Altix cross partition memory (XPMEM)

2007-08-27 Thread Dean Nelson
Terminology The term 'partition', adopted by the SGI hardware designers and which perculated up into the software, is used in reference to a single SSI when multiple SSIs are running on a single Altix. An Altix running multiple SSIs is said to be 'partitioned', whereas one that is running onl

Re: [RFC 3/3] SGI Altix cross partition memory (XPMEM)

2007-08-22 Thread Dean Nelson
On Wed, Aug 22, 2007 at 11:04:22AM -0700, Andrew Morton wrote: > On Wed, 22 Aug 2007 12:00:11 -0500 > Dean Nelson <[EMAIL PROTECTED]> wrote: > > > > > 3) WARNING: declaring multiple variables together should be avoided > > > > checkpatch.pl is erron

Re: [RFC 3/3] SGI Altix cross partition memory (XPMEM)

2007-08-22 Thread Dean Nelson
On Thu, Aug 09, 2007 at 11:15:42PM -0700, Andrew Morton wrote: > On Thu, 9 Aug 2007 20:14:35 -0500 Dean Nelson <[EMAIL PROTECTED]> wrote: > > > This patch provides cross partition access to user memory (XPMEM) when > > running multiple partitions on a single SGI Altix. >

[PATCH] calculation of pgoff in do_linear_fault() uses mixed units

2007-08-15 Thread Dean Nelson
eak. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> Index: linux-2.6/mm/memory.c === --- linux-2.6.orig/mm/memory.c 2007-08-14 06:42:18.322378070 -0500 +++ linux-2.6/mm/memory.c 2007-08-15 12:30:51.621604739 -0500 @@ -2465,

[PATCH] calculation of pgoff in do_linear_fault() uses mixed units

2007-08-14 Thread Dean Nelson
eak. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> Index: linux-2.6/mm/memory.c === --- linux-2.6.orig/mm/memory.c 2007-08-10 09:11:32.0 -0500 +++ linux-2.6/mm/memory.c 2007-08-14 06:26:11.731319983 -0500 @@ -2466,

[RFC 3/3] SGI Altix cross partition memory (XPMEM)

2007-08-09 Thread Dean Nelson
This patch provides cross partition access to user memory (XPMEM) when running multiple partitions on a single SGI Altix. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> xpmem-module.v002.bz2 Description: BZip2 compressed data

[RFC 2/3] SGI Altix cross partition memory (XPMEM)

2007-08-09 Thread Dean Nelson
This patch exports zap_page_range as it is needed by XPMEM. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> --- XPMEM would have used sys_madvise() except that madvise_dontneed() madvise_dontneed() returns an -EINVAL if VM_PFNMAP is set, which is always true for the pages XPMEM import

Re: [RFC 1/3] SGI Altix cross partition memory (XPMEM)

2007-08-09 Thread Dean Nelson
This patch exports __put_task_struct as it is needed by XPMEM. Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> --- One struct file_operations registered by XPMEM, xpmem_open(), calls 'get_task_struct(current->group_leader)' and another, xpmem_flush(), calls 'put_task

[RFC 0/3] SGI Altix cross partition memory (XPMEM)

2007-08-09 Thread Dean Nelson
Terminology The term 'partition', adopted by the SGI hardware designers and which perculated up into the software, is used in reference to a single SSI when multiple SSIs are running on a single Altix. An Altix running multiple SSIs is said to be 'partitioned', whereas one that is running onl

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-17 Thread Dean Nelson
On Wed, May 02, 2007 at 09:44:11AM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > On Thu, Apr 26, 2007 at 01:11:15PM -0600, Eric W. Biederman wrote: > >> > >> Ok.Because of the module unloading issue, and because we don't ha

Re: "partical" kthread conversion

2007-05-02 Thread Dean Nelson
On Wed, May 02, 2007 at 08:45:54AM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > On Tue, May 01, 2007 at 01:51:41AM -0700, Andrew Morton wrote: > >> I might send ia64-sn-xpc-convert-to-use-kthread-api.patch+fixes off to > >>

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-02 Thread Dean Nelson
On Mon, Apr 30, 2007 at 10:22:30AM -0500, Dean Nelson wrote: > On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: > > Dean Nelson <[EMAIL PROTECTED]> writes: > > > > > Taking it one step further, if you added the notion of a thread pool, > &g

Re: "partical" kthread conversion

2007-05-02 Thread Dean Nelson
On Tue, May 01, 2007 at 01:51:41AM -0700, Andrew Morton wrote: > On Tue, 1 May 2007 09:42:45 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Mon, Apr 30, 2007 at 04:20:07PM -0700, Andrew Morton wrote: > > > macintosh-mediabay-convert-to-kthread-api.patch > > > macintosh-adb-convert-t

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-30 Thread Dean Nelson
On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > >> Dean Nelson <[EMAIL PROTECTED]> writes: > >> > > >> &

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Dean Nelson
On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > > Christoph is correct in that XPC has a single thread that exists throughout > > its lifetime, another set of threads that exist for the time that active

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-27 Thread Dean Nelson
On Thu, Apr 19, 2007 at 04:51:03PM -0700, Andrew Morton wrote: > Another driver which should be fully converted to the kthread API: > kthread_stop() and kthread_should_stop(). > > And according to my logs, this driver was added to the tree more than > a year _after_ the kthread interface was made

Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-04-26 Thread Dean Nelson
ainable code. > > Cc: Jes Sorensen <[EMAIL PROTECTED]> > Cc: Tony Luck <[EMAIL PROTECTED]> > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > --- > arch/ia64/sn/kernel/xpc_main.c | 31 +-- > 1 files changed, 13 insertions(

Re: [PATCH] fix (again) MAX_USER_RT_PRIO and MAX_RT_PRIO (was: MAX_USER_RT_PRIO and MAX_RT_PRIO are wrong!)

2005-07-26 Thread Dean Nelson
Steve, your change to XPC looks good. Thanks, Dean Signed-off-by: Dean Nelson <[EMAIL PROTECTED]> On Mon, Jul 25, 2005 at 04:28:39PM -0400, Steven Rostedt wrote: > Dean, > > I've CC you since it also has the change to > linux-2.6.13-rc3/arch/ia64/sn/kernel/xpc_main.c