Re: [PULL] Re: bcache stability patches

2015-12-30 Thread Denis Bychkov
diffstat is small and we all > want someone to pull it in and get it into mainline. This would serve > many people if this can get pulled in upstream. > > More below: > > On Tue, 22 Dec 2015, Denis Bychkov wrote: >> There is a set of bcache stability patches elevating bcache sta

Re: [PULL] Re: bcache stability patches

2015-12-30 Thread Denis Bychkov
or production bcache use. The diffstat is small and we all > want someone to pull it in and get it into mainline. This would serve > many people if this can get pulled in upstream. > > More below: > > On Tue, 22 Dec 2015, Denis Bychkov wrote: >> There is a set of bca

BCACHE stability patches

2015-12-22 Thread Denis Bychkov
;, buf); - if (atomic_xchg(>running, 1)) + if (atomic_xchg(>running, 1)) { + kfree(env[1]); + kfree(env[2]); return; + } if (!d->c && BDEV_STATE(>sb) != BDEV_STATE_NONE) { From: Denis Bychkov Allows to use register, not register_quiet in udev to avoid "device_busy&q

BCACHE stability patches

2015-12-22 Thread Denis Bychkov
er.c +++ b/drivers/md/bcache/super.c @@ -847,8 +847,11 @@ void bch_cached_dev_run(struct cached_de buf[SB_LABEL_SIZE] = '\0'; env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf); - if (atomic_xchg(>running, 1)) + if (atomic_xchg(>running, 1)) { + kfree(env[1]); + kfree(env[2])

4.3 kernel panics when MMC/SDHC card is inserted on thinkpad

2015-11-08 Thread Denis Bychkov
The only started in 4.3 kernel (at least RC-5), 4.2.x does not have this problem. The kernel panic happens immediately after the SDHC card is inserted, reproducibility is 100%. If the system boots up with the card already inserted, it will crash as soon as sdhci_pci module is loaded. If the module

4.3 kernel panics when MMC/SDHC card is inserted on thinkpad

2015-11-08 Thread Denis Bychkov
The only started in 4.3 kernel (at least RC-5), 4.2.x does not have this problem. The kernel panic happens immediately after the SDHC card is inserted, reproducibility is 100%. If the system boots up with the card already inserted, it will crash as soon as sdhci_pci module is loaded. If the module

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-18 Thread Denis Bychkov
Thu, Sep 17, 2015 at 11:30:17AM -0400, Denis Bychkov wrote: >> > Well, it turns out my celebration was a bit premature. >> > >> > PLEASE, DO NOT APPLY THE PATCH POSTED BY KENT (not the one Vojtech >> > posted) ON A PRODUCTION SYSTEM, IT CAUSES DAT

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-18 Thread Denis Bychkov
800, Kent Overstreet wrote: >> On Thu, Sep 17, 2015 at 11:30:17AM -0400, Denis Bychkov wrote: >> > Well, it turns out my celebration was a bit premature. >> > >> > PLEASE, DO NOT APPLY THE PATCH POSTED BY KENT (not the one Vojtech >> > posted

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-17 Thread Denis Bychkov
, 2015 at 2:31 PM, Kent Overstreet wrote: > On Thu, Sep 17, 2015 at 08:40:54AM -0800, Kent Overstreet wrote: >> On Thu, Sep 17, 2015 at 11:30:17AM -0400, Denis Bychkov wrote: >> > Well, it turns out my celebration was a bit premature. >> > >> > PLEASE, D

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-17 Thread Denis Bychkov
, Sep 16, 2015 at 5:08 PM, Denis Bychkov wrote: > Hi Kent, Vojtech, list > > Your fix works perfectly, I can finally remove my patch that disables > the partial_stripes_expensive branch and unleash the full bcache > performance on my RAID-6 array. I was aware of this problem for

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-17 Thread Denis Bychkov
, Sep 16, 2015 at 5:08 PM, Denis Bychkov <mano...@gmail.com> wrote: > Hi Kent, Vojtech, list > > Your fix works perfectly, I can finally remove my patch that disables > the partial_stripes_expensive branch and unleash the full bcache > performance on my RAID-6 array. I was

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-17 Thread Denis Bychkov
, 2015 at 2:31 PM, Kent Overstreet <kent.overstr...@gmail.com> wrote: > On Thu, Sep 17, 2015 at 08:40:54AM -0800, Kent Overstreet wrote: >> On Thu, Sep 17, 2015 at 11:30:17AM -0400, Denis Bychkov wrote: >> > Well, it turns out my celebration was a bit premature. >&g

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-16 Thread Denis Bychkov
Hi Kent, Vojtech, list Your fix works perfectly, I can finally remove my patch that disables the partial_stripes_expensive branch and unleash the full bcache performance on my RAID-6 array. I was aware of this problem for some time now, but never got to learning the bcache codebase enough to find

Re: [PATCH] bcache: Fix writeback_thread never writing back incomplete stripes.

2015-09-16 Thread Denis Bychkov
Hi Kent, Vojtech, list Your fix works perfectly, I can finally remove my patch that disables the partial_stripes_expensive branch and unleash the full bcache performance on my RAID-6 array. I was aware of this problem for some time now, but never got to learning the bcache codebase enough to find