Re: [PATCH] KVM: x86: reinstate vendor-agnostic check on SPEC_CTRL cpuid bits

since we only care about the availability of the MSR on the > host > here and not about specific CPUID bits. > > Fixes: e7c587da1252 ("x86/speculation: Use synthetic bits for > IBRS/IBPB/STIBP") > Cc: sta...@vger.kernel.org > Reported-by: Denis V. Lunev > Signed-of

[PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get

+0x57/0xd0 cpuidle_idle_call+0xde/0x230 arch_cpu_idle+0xe/0xc0 cpu_startup_entry+0x14a/0x1e0 start_secondary+0x1f7/0x270 start_cpu+0x5/0x14 Signed-off-by: Denis V. Lunev CC: Konstantin Khorenko CC: Faisal Latif CC: Shiraz Saleem CC: Doug Ledford CC: Jason Gunthorpe C

Re: [PATCH RFC 0/2] ignore LBR-related MSRs

On 12/06/2017 07:39 PM, Jan Dakinevich wrote: > On Wed, 6 Dec 2017 10:06:48 -0500 > Konrad Rzeszutek Wilk wrote: > >> On Wed, Dec 06, 2017 at 02:43:01PM +0300, Jan Dakinevich wrote: >>> w2k16 essentials fails to boot if underlying hypervisor lacks of >>> support for LBR

Re: [PATCH RFC 0/2] ignore LBR-related MSRs

On 12/06/2017 07:39 PM, Jan Dakinevich wrote: > On Wed, 6 Dec 2017 10:06:48 -0500 > Konrad Rzeszutek Wilk wrote: > >> On Wed, Dec 06, 2017 at 02:43:01PM +0300, Jan Dakinevich wrote: >>> w2k16 essentials fails to boot if underlying hypervisor lacks of >>> support for LBR MSRs. To workaround the

Re: [PATCH] virtio_balloon: prevent uninitialized variable use

e > was originally added in 2.6.34. > > Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon > driver (V4)") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Denis V. Lunev <d...@openvz.org> > --- > drivers/virtio/vi

Re: [PATCH] virtio_balloon: prevent uninitialized variable use

e > was originally added in 2.6.34. > > Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon > driver (V4)") > Signed-off-by: Arnd Bergmann Reviewed-by: Denis V. Lunev > --- > drivers/virtio/virtio_balloon.c | 2 ++ > 1 file changed, 2

[PATCH v2 1/1] virtio: update balloon size in balloon "probe"

This patch adds balloon size check at the end of the probe to match original behaviour. Signed-off-by: Konstantin Neumoin <kneum...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> --- drivers/virtio/virtio_balloon.c |

[PATCH v2 1/1] virtio: update balloon size in balloon "probe"

size check at the end of the probe to match original behaviour. Signed-off-by: Konstantin Neumoin Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) Changes from v1: - fixed description - removed update_balloon_size() call

[PATCH 1/1] update balloon size in balloon "probe"

on. Original code with wait_event_interruptible checked the condition before start waiting and started balloon operations if necessary. Right now balloon is not inflated if ballon target is set before the driver is loaded. Signed-off-by: Konstantin Neumoin <kneum...@virtuozzo.com> Signed-off-

[PATCH 1/1] update balloon size in balloon "probe"

checked the condition before start waiting and started balloon operations if necessary. Right now balloon is not inflated if ballon target is set before the driver is loaded. Signed-off-by: Konstantin Neumoin Signed-off-by: Denis V. Lunev CC: "Michael S. Tsirkin" --- drivers/virtio/virtio

[PATCH 1/1] balloon: stop inflate balloon after oom notification

target. Signed-off-by: Konstantin Neumoin <kneum...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> --- drivers/virtio/virtio_balloon.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/virtio/vi

[PATCH 1/1] balloon: stop inflate balloon after oom notification

-by: Konstantin Neumoin Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 4e7003d..253bf05 100644 --- a/drivers/virtio

[PATCH 1/1] balloon: check the number of available pages in leak balloon

rtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> --- drivers/virtio/virtio_balloon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index 476c0e3..f

[PATCH 1/1] balloon: check the number of available pages in leak balloon

than taken, and raise a "BUG" in balloon_page_dequeue when page list will be empty. So, the simplest solution would be to check that the number of releases pages is less or equal to the number taken pages. Signed-off-by: Konstantin Neumoin Signed-off-by: Denis V. Lunev CC: Michael

Re: [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

On 02/23/2016 06:53 PM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2016 at 06:26:47PM +0300, Denis V. Lunev wrote: On 02/23/2016 06:10 PM, Michael S. Tsirkin wrote: On Tue, Feb 16, 2016 at 06:50:52PM +0300, Denis V. Lunev wrote: From: Igor Redko <red...@virtuozzo.com> Add a new

Re: [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

On 02/23/2016 06:53 PM, Michael S. Tsirkin wrote: On Tue, Feb 23, 2016 at 06:26:47PM +0300, Denis V. Lunev wrote: On 02/23/2016 06:10 PM, Michael S. Tsirkin wrote: On Tue, Feb 16, 2016 at 06:50:52PM +0300, Denis V. Lunev wrote: From: Igor Redko Add a new field, VIRTIO_BALLOON_S_AVAIL

Re: [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

On 02/23/2016 06:10 PM, Michael S. Tsirkin wrote: On Tue, Feb 16, 2016 at 06:50:52PM +0300, Denis V. Lunev wrote: From: Igor Redko <red...@virtuozzo.com> Add a new field, VIRTIO_BALLOON_S_AVAIL, to virtio_balloon memory statistics protocol, corresponding to 'Available' in /proc/m

Re: [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

On 02/23/2016 06:10 PM, Michael S. Tsirkin wrote: On Tue, Feb 16, 2016 at 06:50:52PM +0300, Denis V. Lunev wrote: From: Igor Redko Add a new field, VIRTIO_BALLOON_S_AVAIL, to virtio_balloon memory statistics protocol, corresponding to 'Available' in /proc/meminfo. It indicates

[PATCH 1/2] calculate 'available' memory in the separate function

istics interface (in a followup patch). Signed-off-by: Igor Redko <red...@virtuozzo.com> Reviewed-by: Roman Kagan <rka...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> CC: Andrew Morton <a...@linux-foundation.

[PATCH 1/2] calculate 'available' memory in the separate function

patch). Signed-off-by: Igor Redko Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Andrew Morton --- fs/proc/meminfo.c | 31 +-- include/linux/mm.h | 1 + mm/page_alloc.c| 43 +++ 3

[PATCH 0/2] export 'available' memory to virtio balloon statistics

software to improve memory management of different VMs under overcommit. Signed-off-by: Igor Redko <red...@virtuozzo.com> Reviewed-by: Roman Kagan <rka...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> CC: A

[PATCH 0/2] export 'available' memory to virtio balloon statistics

software to improve memory management of different VMs under overcommit. Signed-off-by: Igor Redko Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Andrew Morton Igor Redko (2): calculate 'available' memory in the separate function virtio_balloon: export

[PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

ed-off-by: Igor Redko <red...@virtuozzo.com> Reviewed-by: Roman Kagan <rka...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Michael S. Tsirkin <m...@redhat.com> CC: Andrew Morton <a...@linux-foundation.org> --- drivers/virtio/virtio_balloon.

[PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics

Reviewed-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Andrew Morton --- drivers/virtio/virtio_balloon.c | 6 ++ include/uapi/linux/virtio_balloon.h | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers

Re: [PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

On 11/12/2015 08:35 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Wednesday, November 11, 2015 11:16 PM To: KY Srinivasan Cc: rka...@virtuozzo.com; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; Andrey Smetanin ; Haiyang

Re: [PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

On 11/12/2015 08:35 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Wednesday, November 11, 2015 11:16 PM To: KY Srinivasan <k...@microsoft.com> Cc: rka...@virtuozzo.com; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org;

Re: [PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

On 11/02/2015 10:42 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Monday, November 2, 2015 3:34 AM Cc: rka...@virtuozzo.com; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; Andrey Smetanin ; KY Srinivasan ; Haiyang Zhang

Re: [PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

On 11/02/2015 10:42 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Monday, November 2, 2015 3:34 AM Cc: rka...@virtuozzo.com; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; Andrey Smetanin <asmeta...@virtuozzo.com&g

[PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

inux guest drivers Signed-off-by: Denis V. Lunev --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 6341be8..68d0701 100644 --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c @@ -139,7 +139,7 @@ static cycle_t read_hv_clock_

[PATCH 1/1] drivers/hv: correct tsc page sequence invalid value

icrosoft.com> CC: Haiyang Zhang <haiya...@microsoft.com> CC: Vitaly Kuznetsov <vkuzn...@redhat.com> TARGET: Microsoft Hyper-V Linux guest drivers Signed-off-by: Denis V. Lunev <d...@openvz.org> --- drivers/hv/hv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

On 10/08/2015 08:28 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Thursday, October 8, 2015 10:20 AM To: KY Srinivasan ; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

On 10/08/2015 05:01 AM, K. Y. Srinivasan wrote: From: Denis V. Lunev K.Y., there is one subtle thing in this submission. You have changed "From:" field in comparison with the original letter. I have submitted the patch with "From: Andrey Smetanin " In this case Author:

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

On 10/08/2015 05:01 AM, K. Y. Srinivasan wrote: From: Denis V. Lunev <d...@openvz.org> K.Y., there is one subtle thing in this submission. You have changed "From:" field in comparison with the original letter. I have submitted the patch with "From: Andrey Smetanin <

Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

On 10/08/2015 08:28 PM, KY Srinivasan wrote: -Original Message- From: Denis V. Lunev [mailto:d...@openvz.org] Sent: Thursday, October 8, 2015 10:20 AM To: KY Srinivasan <k...@microsoft.com>; gre...@linuxfoundation.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.

[PATCH 1/1] drivers/hv: cleanup synic msrs if vmbus connect failed

() at each vcpu to get a chance to free allocated resources by hypervisor per synic. This patch does appropriate cleanup in case of vmbus_connect() failure. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: "K. Y. Srinivasan" CC: Haiyang Zhang CC: Vitaly Kuznetsov ---

[PATCH 1/1] drivers/hv: cleanup synic msrs if vmbus connect failed

setup by call hv_synic_cleanup() at each vcpu to get a chance to free allocated resources by hypervisor per synic. This patch does appropriate cleanup in case of vmbus_connect() failure. Signed-off-by: Andrey Smetanin <asmeta...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz

[RFC PATCH 1/1] mshyperv: fix recognition of Hyper-V guest crash MSR's

. Signed-off-by: Andrey Smetanin Signed-off-by: Denis V. Lunev CC: Nick Meier CC: K. Y. Srinivasan CC: Haiyang Zhang --- arch/x86/include/asm/mshyperv.h | 1 + arch/x86/kernel/cpu/mshyperv.c | 1 + drivers/hv/vmbus_drv.c | 4 ++-- 3 files changed, 4 insertions(+), 2 deletions

[RFC PATCH 1/1] mshyperv: fix recognition of Hyper-V guest crash MSR's

register instead of EDX. Signed-off-by: Andrey Smetanin asmeta...@virtuozzo.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Nick Meier nme...@microsoft.com CC: K. Y. Srinivasan k...@microsoft.com CC: Haiyang Zhang haiya...@microsoft.com --- arch/x86/include/asm/mshyperv.h | 1 + arch/x86

[PATCH v3 0/2] shrink virtio baloon on OOM in guest

-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC: Michael S. Tsirkin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH 1/2] virtio_balloon: return the amount of freed memory from leak_balloon()

From: Raushaniya Maksudova This value would be useful in the next patch to provide the amount of the freed memory for OOM killer. Signed-off-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 5 - 1 file

[PATCH 2/2] virtio_balloon: free some memory from balloon on OOM

. Allocate virtio feature bit for this: it is not set by default, the the guest will not deflate virtio balloon on OOM without explicit permission from host. Signed-off-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c

[PATCH 2/2] virtio_balloon: free some memory from balloon on OOM

killer to run. Allocate virtio feature bit for this: it is not set by default, the the guest will not deflate virtio balloon on OOM without explicit permission from host. Signed-off-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Rusty Russell

[PATCH 1/2] virtio_balloon: return the amount of freed memory from leak_balloon()

From: Raushaniya Maksudova rmaksud...@parallels.com This value would be useful in the next patch to provide the amount of the freed memory for OOM killer. Signed-off-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Rusty Russell ru

[PATCH v3 0/2] shrink virtio baloon on OOM in guest

-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Rusty Russell ru...@rustcorp.com.au CC: Michael S. Tsirkin m...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

[PATCH 1/2] virtio_balloon: return the amount of freed memory from leak_balloon()

From: Raushaniya Maksudova This value would be useful in the next patch to provide the amount of the freed memory for OOM killer. Signed-off-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 5 - 1 file

[PATCH v2 0/2] shrink virtio baloon on OOM in guest

for implementation of virtio_balloon callback, so now leak_balloon() function returns number of freed pages. Patch 2 implements virtio_balloon callback itself. Changes from v1: - minor cosmetic tweaks suggested by rusty@ Signed-off-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC

[PATCH 2/2] virtio_balloon: free some memory from balloon on OOM

-off-by: Raushaniya Maksudova Signed-off-by: Denis V. Lunev CC: Rusty Russell CC: Michael S. Tsirkin --- drivers/virtio/virtio_balloon.c | 48 + 1 file changed, 48 insertions(+) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio

[PATCH 2/2] virtio_balloon: free some memory from balloon on OOM

killer to run. Signed-off-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Rusty Russell ru...@rustcorp.com.au CC: Michael S. Tsirkin m...@redhat.com --- drivers/virtio/virtio_balloon.c | 48 + 1 file

[PATCH 1/2] virtio_balloon: return the amount of freed memory from leak_balloon()

From: Raushaniya Maksudova rmaksud...@parallels.com This value would be useful in the next patch to provide the amount of the freed memory for OOM killer. Signed-off-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev d...@openvz.org CC: Rusty Russell ru

[PATCH v2 0/2] shrink virtio baloon on OOM in guest

for implementation of virtio_balloon callback, so now leak_balloon() function returns number of freed pages. Patch 2 implements virtio_balloon callback itself. Changes from v1: - minor cosmetic tweaks suggested by rusty@ Signed-off-by: Raushaniya Maksudova rmaksud...@parallels.com Signed-off-by: Denis V. Lunev

Re: lock_task_group_list() can be called from the atomic context

Acked-by: Denis V. Lunev <[EMAIL PROTECTED]> On Mon, 2008-02-11 at 14:33 +0100, Peter Zijlstra wrote: > On Mon, 2008-02-11 at 15:09 +0300, Denis V. Lunev wrote: > > Curious, I hadn't yet seen it... Does the below fix it? > > > BUG: sleeping function called from invalid

Re: lock_task_group_list() can be called from the atomic context

Acked-by: Denis V. Lunev [EMAIL PROTECTED] On Mon, 2008-02-11 at 14:33 +0100, Peter Zijlstra wrote: On Mon, 2008-02-11 at 15:09 +0300, Denis V. Lunev wrote: Curious, I hadn't yet seen it... Does the below fix it? BUG: sleeping function called from invalid context at /home/den/src/linux

lock_task_group_list() can be called from the atomic context

Hello, Ingo! I am seeing the following calltrace every day I am connecting to my test host by the gnome-panel: ssh -Y test.host gnome-terminal BUG: sleeping function called from invalid context at /home/den/src/linux-netns26/kernel/mutex.c:209 in_atomic():1, irqs_disabled():0 no locks held by

lock_task_group_list() can be called from the atomic context

Hello, Ingo! I am seeing the following calltrace every day I am connecting to my test host by the gnome-panel: ssh -Y test.host gnome-terminal BUG: sleeping function called from invalid context at /home/den/src/linux-netns26/kernel/mutex.c:209 in_atomic():1, irqs_disabled():0 no locks held by

[PATCH 6/6] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace.

path. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |2 +- net/ipv4/fib_frontend.c |2 +- net/ipv4/fib_semantics.c |6 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index c

[PATCH 4/6] [IPV4]: fib_sync_down rework.

fib_sync_down can be called with an address and with a device. In reality it is called either with address OR with a device. The codepath inside is completely different, so lets separate it into two calls for these two cases. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- inclu

[PATCH 3/6] [NETNS]: Process interface address manipulation routines in the namespace.

The namespace is available when required except rtm_to_ifaddr. Add namespace argument to it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/dev

[PATCH 5/6] [NETNS]: Add a namespace mark to fib_info.

This is required to make fib_info lookups namespace aware. In the other case initial namespace devices are marked as dead in the local routing table during other namespace stop. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |1 + net/ipv4/fib_seman

[PATCH 1/6] [IPV4]: Fix memory leak on error path during FIB initialization.

net->ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem has been introduced by the following commit. commit c8050bf6d84785a7edd2e81591e8f833231477e8 Author: Denis V. Lunev <[EMAIL PROTECTED]> Date: Thu Jan 10 03:28:24 2008 -0800 Signed-off-by: Denis V. Lune

[PATCH 2/6] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

Remove error code assignment inside brackets on failure. The code looks better if the error is assigned before condition check. Also, the compiler treats this better. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/devinet.c | 21 - 1 files chan

[PATCH 3/3] [RAW]: Wrong content of the /proc/net/raw6.

oticed the problem. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/raw.h |3 ++- net/ipv4/raw.c|8 net/ipv6/raw.c|2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/net/raw.h b/include/net/raw.h index c7ea7a2..18

[PATCH 1/3] [RAW]: Family check in the /proc/net/raw[6] is extra.

Different hashtables are used for IPv6 and IPv4 raw sockets, so no need to check the socket family in the iterator over hashtables. Clean this out. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/raw.h |4 +--- net/ipv4/raw.c| 12 net/ipv6/raw.c

[PATCH 2/3] [RAW]: Cleanup IPv4 raw_seq_show.

There is no need to use 128 bytes on the stack at all. Clean the code in the IPv6 style. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/raw.c | 24 +++- 1 files changed, 7 insertions(+), 17 deletions(-) diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c

[PATCH 0/3] [RAW]: proc output cleanups.

ct due to it. This series of patches fixes original problem and slightly cleanups the code around. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

[PATCH 0/3] [RAW]: proc output cleanups.

to it. This series of patches fixes original problem and slightly cleanups the code around. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH 2/3] [RAW]: Cleanup IPv4 raw_seq_show.

There is no need to use 128 bytes on the stack at all. Clean the code in the IPv6 style. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/raw.c | 24 +++- 1 files changed, 7 insertions(+), 17 deletions(-) diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c index

[PATCH 3/3] [RAW]: Wrong content of the /proc/net/raw6.

the problem. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/raw.h |3 ++- net/ipv4/raw.c|8 net/ipv6/raw.c|2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/net/raw.h b/include/net/raw.h index c7ea7a2..1828f81 100644 --- a/include

[PATCH 1/3] [RAW]: Family check in the /proc/net/raw[6] is extra.

Different hashtables are used for IPv6 and IPv4 raw sockets, so no need to check the socket family in the iterator over hashtables. Clean this out. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/raw.h |4 +--- net/ipv4/raw.c| 12 net/ipv6/raw.c|2

[PATCH 4/6] [IPV4]: fib_sync_down rework.

fib_sync_down can be called with an address and with a device. In reality it is called either with address OR with a device. The codepath inside is completely different, so lets separate it into two calls for these two cases. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net

[PATCH 3/6] [NETNS]: Process interface address manipulation routines in the namespace.

The namespace is available when required except rtm_to_ifaddr. Add namespace argument to it. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index

[PATCH 5/6] [NETNS]: Add a namespace mark to fib_info.

This is required to make fib_info lookups namespace aware. In the other case initial namespace devices are marked as dead in the local routing table during other namespace stop. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h |1 + net/ipv4/fib_semantics.c |8

[PATCH 1/6] [IPV4]: Fix memory leak on error path during FIB initialization.

net-ipv4.fib_table_hash is not freed when fib4_rules_init failed. The problem has been introduced by the following commit. commit c8050bf6d84785a7edd2e81591e8f833231477e8 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Jan 10 03:28:24 2008 -0800 Signed-off-by: Denis V. Lunev [EMAIL PROTECTED

[PATCH 2/6] [IPV4]: Small style cleanup of the error path in rtm_to_ifaddr.

Remove error code assignment inside brackets on failure. The code looks better if the error is assigned before condition check. Also, the compiler treats this better. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- net/ipv4/devinet.c | 21 - 1 files changed, 8

[PATCH 6/6] [NETNS]: Lookup in FIB semantic hashes taking into account the namespace.

path. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/ip_fib.h |2 +- net/ipv4/fib_frontend.c |2 +- net/ipv4/fib_semantics.c |6 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h index cb0df37..90d1175

Re: [PATCH] [NFS]: Lock daemon start/stop rework.

Christoph Hellwig wrote: > On Wed, Jan 30, 2008 at 02:41:34PM +0300, Denis V. Lunev wrote: >> The pid of the locking daemon can be substituted with a task struct >> without a problem. Namely, the value if filled in the context of the lockd >> thread and used i

[PATCH] [NFS]: Lock daemon start/stop rework.

is guaranteed by the RCU, i.e. task can't disappear without passing a quiscent state. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- fs/lockd/svc.c | 38 +- 1 files changed, 25 insertions(+), 13 deletions(-) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c

[PATCH] [NFS]: Lock daemon start/stop rework.

is guaranteed by the RCU, i.e. task can't disappear without passing a quiscent state. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- fs/lockd/svc.c | 38 +- 1 files changed, 25 insertions(+), 13 deletions(-) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index

[PATCH] Debugfs compile fix.

Debugfs is not compiled without CONFIG_SYSFS in net-2.6 tree. Move kobject_create_and_add under appropriate ifdef. The fix looks correct from a first glance, but may be the dependency should be added into the Kconfig. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- fs/debugfs/i

[PATCH] Debugfs compile fix.

Debugfs is not compiled without CONFIG_SYSFS in net-2.6 tree. Move kobject_create_and_add under appropriate ifdef. The fix looks correct from a first glance, but may be the dependency should be added into the Kconfig. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- fs/debugfs/inode.c |2

Re: [PATCH 2.6.24-rc4] proc: Remove/Fix proc generic d_revalidate

could you, plz, check patch sent by Eric above in this thread. I have tried it on my test node and it works for module you have provided. The problem exists without it. Regards, Den Petr Vandrovec wrote: > Eric W. Biederman wrote: >> Ultimately to implement /proc perfectly we need an

Re: [PATCH 2.6.24-rc4] proc: Remove/Fix proc generic d_revalidate

could you, plz, check patch sent by Eric above in this thread. I have tried it on my test node and it works for module you have provided. The problem exists without it. Regards, Den Petr Vandrovec wrote: Eric W. Biederman wrote: Ultimately to implement /proc perfectly we need an

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

Andrew Morton wrote: > On Fri, 07 Dec 2007 04:51:37 + David Woodhouse <[EMAIL PROTECTED]> wrote: > >> On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: >>> Well I clearly goofed when I added the initial network namespace support >>> for /proc/net. Currently things work but there

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

Andrew Morton wrote: On Fri, 07 Dec 2007 04:51:37 + David Woodhouse [EMAIL PROTECTED] wrote: On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote: Well I clearly goofed when I added the initial network namespace support for /proc/net. Currently things work but there are odd

Re: [PATCH] proc: Do not invalidate dentries with submounts

you have changed the behavior of revalidation by shadows. I think it will be better to restore it and keep new one for shadows (and below) only, which has been done by my yesterday patch. Regards, Den Eric W. Biederman wrote: > If the dcache path to a mount point is ever broken it

Re: [PATCH] proc: Do not invalidate dentries with submounts

you have changed the behavior of revalidation by shadows. I think it will be better to restore it and keep new one for shadows (and below) only, which has been done by my yesterday patch. Regards, Den Eric W. Biederman wrote: If the dcache path to a mount point is ever broken it becomes

[PATCH] lost content of /proc/sys/fs/binfmt_misc

/proc/sys/fs/binfmt_misc dentry disappeared during d_revalidate. d_revalidate only dentries from shadowed one and below. http://bugzilla.kernel.org/show_bug.cgi?id=9504 CC: Eric W. Biederman <[EMAIL PROTECTED]> CC: Marcus Better <[EMAIL PROTECTED]> Signed-off-by: Denis V. Lunev <[

[PATCH] lost content of /proc/sys/fs/binfmt_misc

/proc/sys/fs/binfmt_misc dentry disappeared during d_revalidate. d_revalidate only dentries from shadowed one and below. http://bugzilla.kernel.org/show_bug.cgi?id=9504 CC: Eric W. Biederman [EMAIL PROTECTED] CC: Marcus Better [EMAIL PROTECTED] Signed-off-by: Denis V. Lunev [EMAIL PROTECTED

Re: [PATCH] AB-BA deadlock in drop_caches sysctl (resend, the one sent was for 2.6.18)

Andrew Morton wrote: > On Mon, 3 Dec 2007 16:52:47 +0300 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > >> There is a AB-BA deadlock regarding drop_caches sysctl. Here are the code >> paths: >> >> drop_pagecache >> spin_lock(_lock); &

Re: [PATCH] AB-BA deadlock in drop_caches sysctl (resend, the one sent was for 2.6.18)

Andrew Morton wrote: On Mon, 3 Dec 2007 16:52:47 +0300 Denis V. Lunev [EMAIL PROTECTED] wrote: There is a AB-BA deadlock regarding drop_caches sysctl. Here are the code paths: drop_pagecache spin_lock(inode_lock); invalidate_mapping_pages try_to_release_page

[PATCH] AB-BA deadlock in drop_caches sysctl (resend, the one sent was for 2.6.18)

s sane as inode hold should not gone from the list and should not change its place. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> -- diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 59375ef..4ac80d8 100644 --- a/fs/drop_caches.c +++ b/fs/drop_caches.c @@ -14,15 +14,27 @@ int sysctl

[PATCH] AB-BA deadlock in drop_caches sysctl

tries to address the issue - it drops inode_lock before digging into invalidate_inode_pages. This seems sane as inode hold should not gone from the list and should not change its place. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- ./fs/drop_caches.c.marker 2006-09-20 07:42:06.000

Re: namespace support requires network modules to say "GPL"

Patrick McHardy wrote: > Adrian Bunk wrote: >> On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote: >> >>> For all I care binary modules can break, but frankly I don't see >>> how encapsulating a couple of structures and pointers in a new >>> structure and adding a new argument to

Re: namespace support requires network modules to say GPL

Patrick McHardy wrote: Adrian Bunk wrote: On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote: For all I care binary modules can break, but frankly I don't see how encapsulating a couple of structures and pointers in a new structure and adding a new argument to existing functions

[PATCH] AB-BA deadlock in drop_caches sysctl (resend, the one sent was for 2.6.18)

. This seems sane as inode hold should not gone from the list and should not change its place. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] -- diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 59375ef..4ac80d8 100644 --- a/fs/drop_caches.c +++ b/fs/drop_caches.c @@ -14,15 +14,27 @@ int

[PATCH] AB-BA deadlock in drop_caches sysctl

(inode_lock); The patch tries to address the issue - it drops inode_lock before digging into invalidate_inode_pages. This seems sane as inode hold should not gone from the list and should not change its place. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- ./fs/drop_caches.c.marker 2006-09-20 07

[PATCH] .gitignore update for x86 arch

This patch: - makes .gitignore files visible to git - makes arch/x86/kernel/vsyscall_32.lds and arch/i386/boot invisible Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> diff --git a/.gitignore b/.gitignore index 27c3e83..22fb8fa 100644 --- a/.gitignore +++ b/.gitignore @@ -26,6

[PATCH] .gitignore update for x86 arch

This patch: - makes .gitignore files visible to git - makes arch/x86/kernel/vsyscall_32.lds and arch/i386/boot invisible Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] diff --git a/.gitignore b/.gitignore index 27c3e83..22fb8fa 100644 --- a/.gitignore +++ b/.gitignore @@ -26,6 +26,7 @@ vmlinux

Re: [NET] IPv6 oops bisected

David Miller wrote: > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > Date: Mon, 08 Oct 2007 10:34:23 +0400 > >> OK. I am installing Fedora 7 right now... > > You don't need to install Fedora, just read the code! :-) > > The bug is obvious and it's

Re: [NET] IPv6 oops bisected

David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Mon, 8 Oct 2007 14:19:42 +0800 > >> On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index a7db84c..7109ad6 100644 >>> --- a/net/ipv6/route.c >>> +++

Re: [NET] IPv6 oops bisected

David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 14:19:42 +0800 On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@

  1   2   >