Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-03 Thread Denys Fedoryshchenko
On 2017-04-03 15:09, Eric Dumazet wrote: On Mon, 2017-04-03 at 11:10 +0300, Denys Fedoryshchenko wrote: I modified patch a little as: if (th->doff * 4 < sizeof(_tcph)) { par->hotdrop = true; WARN_ON_ONCE(!tcpinfo->option); return false; } And it did triggered WARN once at

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-03 Thread Denys Fedoryshchenko
On 2017-04-02 20:26, Eric Dumazet wrote: On Sun, 2017-04-02 at 10:14 -0700, Eric Dumazet wrote: Could that be that netfilter does not abort earlier if TCP header is completely wrong ? Yes, I wonder if this patch would be better, unless we replicate the th->doff sanity check in all netfilter

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 15:32, Eric Dumazet wrote: On Sun, 2017-04-02 at 15:25 +0300, Denys Fedoryshchenko wrote: > */ I will add also WARN_ON_ONCE(tcp_hdrlen >= 15 * 4) before, for curiosity, if this condition are triggered. Is it fine like that? Sure. It didnt triggered WARN_ON, and wit

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 15:19, Eric Dumazet wrote: On Sun, 2017-04-02 at 04:54 -0700, Eric Dumazet wrote: On Sun, 2017-04-02 at 13:45 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt, i)) { > > + for (i = si

Re: KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
On 2017-04-02 14:45, Florian Westphal wrote: Eric Dumazet wrote: - for (i = sizeof(struct tcphdr); i <= tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt, i)) { + for (i = sizeof(struct tcphdr); i < tcp_hdrlen - TCPOLEN_MSS; i += optlen(opt, i)) { if (opt[i] == TCPOPT_MSS && opt[i+1]

KASAN, xt_TCPMSS finally found nasty use-after-free bug? 4.10.8

2017-04-02 Thread Denys Fedoryshchenko
Repost, due being sleepy missed few important points. I am searching reasons of crashes for multiple conntrack enabled servers, usually they point to conntrack, but i suspect use after free might be somewhere else, so i tried to enable KASAN. And seems i got something after few hours, and it l

Re: probably serious conntrack/netfilter panic, 4.8.14, timers and intel turbo

2017-03-31 Thread Denys Fedoryshchenko
I am not sure if it is same issue, but panics still happen, but much less. Same server, nat. I will upgrade to latest 4.10.x build, because for this one i dont have files anymore (for symbols and etc). [864288.511464] Modules linked in: nf_conntrack_netlink nf_nat_pptp nf_nat_proto_gre xt_TCP

Re: kexec on panic

2017-02-18 Thread Denys Fedoryshchenko
On 2017-02-18 09:42, Jon Masters wrote: Hi Denys, On 02/10/2017 03:14 AM, Denys Fedoryshchenko wrote: After years of using kexec and recent unpleasant experience with modern (supposed to be blazing fast to boot) hardware that need 5-10 minutes just to pass POST tests, one question came up

Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)

2017-02-10 Thread Denys Fedoryshchenko
Hello, I noticed that sample of livepatch is not working in 4.9.9, because in include, linux/livepatch.h it is: #if IS_ENABLED(CONFIG_LIVEPATCH) while config option is: CONFIG_HAVE_LIVEPATCH=y After editing livepatch.h sample module compiles fine Probably that's just a typo?

kexec on panic

2017-02-10 Thread Denys Fedoryshchenko
Hello, After years of using kexec and recent unpleasant experience with modern (supposed to be blazing fast to boot) hardware that need 5-10 minutes just to pass POST tests, one question came up to me: Is it possible anyhow to execute regular (not special "panic" one to capture crash data) ke

Re: probably serious conntrack/netfilter panic, 4.8.14, timers and intel turbo

2017-01-11 Thread Denys Fedoryshchenko
On 2017-01-11 19:22, Guillaume Nault wrote: Cc: netfilter-de...@vger.kernel.org, I'm afraid I'll need some help for this case. On Sat, Dec 17, 2016 at 09:48:13PM +0200, Denys Fedoryshchenko wrote: Hi, I posted recently several netfilter related crashes, didn't got any answer

probably serious conntrack/netfilter panic, 4.8.14, timers and intel turbo

2016-12-17 Thread Denys Fedoryshchenko
Hi, I posted recently several netfilter related crashes, didn't got any answers, one of them started to happen quite often on loaded NAT (17Gbps), so after trying endless ways to make it stable, i found out that in backtrace i can often see timers, and this bug probably appearing on older rel

regression, 4.8.10 -> 4.9.0 totally fail on NUMA machine, ACPI issue?

2016-12-12 Thread Denys Fedoryshchenko
Hi, Just attempted to upgrade from 4.8.10 to 4.9.10 with minimal kernel changes (oldconfig, but then attempted to add few options to solve problem (such as adding NR_CPUS and PCI options, didnt helped). My filesystem are residing on USB drive, and USB where flash are located is not working, so

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-13 Thread Denys Fedoryshchenko
at least one more person with similar conntrack crashes on latest kernels. On 2015-11-04 06:46, Eric Dumazet wrote: On Wed, 2015-11-04 at 06:25 +0200, Denys Fedoryshchenko wrote: On 2015-11-04 00:06, Cong Wang wrote: > On Mon, Nov 2, 2015 at 6:11 AM, Denys Fedoryshchenko > wrote:

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-03 Thread Denys Fedoryshchenko
On 2015-11-04 06:58, Eric Dumazet wrote: On Tue, 2015-11-03 at 20:46 -0800, Eric Dumazet wrote: On Wed, 2015-11-04 at 06:25 +0200, Denys Fedoryshchenko wrote: > On 2015-11-04 00:06, Cong Wang wrote: > > On Mon, Nov 2, 2015 at 6:11 AM, Denys Fedoryshchenko > > wrote: > >>

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-03 Thread Denys Fedoryshchenko
On 2015-11-04 00:06, Cong Wang wrote: On Mon, Nov 2, 2015 at 6:11 AM, Denys Fedoryshchenko wrote: Hi! Actually seems i was getting this panic for a while (once per week) on loaded pppoe server, but just now was able to get full panic message. After checking commit logs on sch_fq.c i didnt

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-02 Thread Denys Fedoryshchenko
On 2015-11-02 18:12, Eric Dumazet wrote: On Mon, 2015-11-02 at 17:58 +0200, Denys Fedoryshchenko wrote: On 2015-11-02 17:24, Eric Dumazet wrote: > On Mon, 2015-11-02 at 16:11 +0200, Denys Fedoryshchenko wrote: >> Hi! >> >> Actually seems i was getting this panic for a whi

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-02 Thread Denys Fedoryshchenko
On 2015-11-02 17:24, Eric Dumazet wrote: On Mon, 2015-11-02 at 16:11 +0200, Denys Fedoryshchenko wrote: Hi! Actually seems i was getting this panic for a while (once per week) on loaded pppoe server, but just now was able to get full panic message. After checking commit logs on sch_fq.c i

kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-02 Thread Denys Fedoryshchenko
Hi! Actually seems i was getting this panic for a while (once per week) on loaded pppoe server, but just now was able to get full panic message. After checking commit logs on sch_fq.c i didnt seen any fixes, so probably upgrading to newer kernel wont help? [237470.633382] general protection

Re: 3.12 BUG() on ext4, kernel crash on nbd-client when nbd server rebooting

2013-11-12 Thread Denys Fedoryshchenko
Hi On 2013-11-12 23:46, Jan Kara wrote: Hello, On Tue 12-11-13 16:34:07, Denys Fedoryshchenko wrote: I just did some fault testing for test nbd setup, and found that if i reboot nbd server i will get immediately BUG() message on nbd client and filesystem that i cannot unmount, and any

3.12 BUG() on ext4, kernel crash on nbd-client when nbd server rebooting

2013-11-12 Thread Denys Fedoryshchenko
Hi I just did some fault testing for test nbd setup, and found that if i reboot nbd server i will get immediately BUG() message on nbd client and filesystem that i cannot unmount, and any operations on it will freeze and lock processes trying to access it. Kernel 3.12, x86_64 Please let me

Re: netlink, RTM_NEWTCLASS, nested attributes

2013-02-20 Thread Denys Fedoryshchenko
On 2013-02-21 01:21, Stephen Hemminger wrote: On Tue, 19 Feb 2013 23:45:25 +0200 Denys Fedoryshchenko wrote: Hi I tried recently to write my own tool based on amazing libmnl (which makes understanding of netlink - easy), written by Pablo Neira Ayuso, to manage QoS in Linux and faced problem

kernel BUG at mm/slub.c:3409, 3.8.0-rc7

2013-02-15 Thread Denys Fedoryshchenko
ng recursive fault but reboot is needed! --- Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

3.8.0-rc7, nouveau, possible recursive locking, nouveau_instobj_create_ and nv50_disp_data_ctor

2013-02-15 Thread Denys Fedoryshchenko
M] ACPI backlight interface available, not registering our own --- Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

kernel 3.7.6, l2tp, qdisc_tx circular locking

2013-02-11 Thread Denys Fedoryshchenko
0x12/0x14 [ 7575.810373] [] cpuidle_enter_state+0x10/0x39 [ 7575.810840] [] cpuidle_idle_call+0x7e/0xa4 [ 7575.811306] [] cpu_idle+0x58/0xa2 [ 7575.811770] [] start_secondary+0x188/0x18d --- Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L. -- To unsubscribe from this list: send the

Re: Latest 3.6.6 are not compiling due tg3 network driver, hwmon_device_unregister

2012-11-18 Thread Denys Fedoryshchenko
el_rules.txt? > Will do. Thank you for bringing this to our attention. Thanks for submitting the patch to stable, Greg has queued it for the kernels he maintains. Denys, expect to see this fix in 3.6.8. Thank you! --- Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L. -- To unsubscr

RE: e1000e on DH55HC stalling and kernel panic in 3.6.6

2012-11-13 Thread Denys Fedoryshchenko
On 2012-11-13 21:41, Dave, Tushar N wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Denys Fedoryshchenko Sent: Tuesday, November 13, 2012 5:59 AM To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, Carolyn

Intel management, circular locking warning

2012-11-13 Thread Denys Fedoryshchenko
2] [] path_openat+0x99/0x2c3 [4.361974] [] do_filp_open+0x26/0x67 [4.361977] [] ? alloc_fd+0xb7/0xc2 [4.361979] [] do_sys_open+0x5b/0xe6 [4.361980] [] sys_open+0x26/0x2c [4.361981] [] syscall_call+0x7/0xb --- Denys Fedoryshchenko, Network Engineer, Virtual ISP S.A.L. -- To

Re: BUG/ spinlock lockup, 2.6.24

2008-02-15 Thread Denys Fedoryshchenko
Fri, 15 Feb 2008 16:24:56 +0100, Bart Van Assche wrote > 2008/2/15 Denys Fedoryshchenko <[EMAIL PROTECTED]>: > > I have random crashes, at least once per week. It is very difficult to catch > > error message, and only recently i setup netconsole. Now i got crash, but >

BUG/ spinlock lockup, 2.6.24

2008-02-15 Thread Denys Fedoryshchenko
de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe nx lm constant_tsc pebs bts sync_rdtsc pni monitor ds_cpl vmx cid cx16 xtpr lahf_lm bogomips: 6383.76 clflush size: 64 -- Denys Fedoryshchenko Technical Manager Virtual ISP

Re: kernel panic on 2.6.24/iTCO_wdt not rebooting machine

2008-02-01 Thread Denys Fedoryshchenko
i will be able to find whats wrong there. On Fri, 1 Feb 2008 15:39:08 -0500, Len Brown wrote > On Friday 01 February 2008 14:15, Denys Fedoryshchenko wrote: > > > > On Fri, 1 Feb 2008 12:11:41 -0500, Len Brown wrote > > > > > > What do you see if you build with CONFIG

Re: kernel panic on 2.6.24/iTCO_wdt not rebooting machine

2008-02-01 Thread Denys Fedoryshchenko
2008 14:15, Denys Fedoryshchenko wrote: > > > > On Fri, 1 Feb 2008 12:11:41 -0500, Len Brown wrote > > > > > > What do you see if you build with CONFIG_HIGH_RES_TIMERS=n > > > > > > Does it work better if you boot with "acpi=off"?

Re: kernel panic on 2.6.24/iTCO_wdt not rebooting machine

2008-02-01 Thread Denys Fedoryshchenko
Maybe just registers addresses or way how TCO watchdog activated changed on this chipset? -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

kernel panic on 2.6.24/iTCO_wdt not rebooting machine

2008-02-01 Thread Denys Fedoryshchenko
12380.068978] Kernel panic - not syncing: Fatal exception in interrupt -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:/

Re: 2.6.24-rc7 to 2.6.24-rc8 possible regression

2008-01-22 Thread Denys Fedoryshchenko
No, i am using vanilla kernel. It is one of production machines, and as i know screen is not using epoll. I will try to apply on all my production machines this patch. Sorry if it is related. On Mon, 21 Jan 2008 23:45:40 +0100, Stefan Richter wrote > Denys Fedoryshchenko wrote: > &

2.6.24-rc7 to 2.6.24-rc8 possible regression

2008-01-21 Thread Denys Fedoryshchenko
esp+0x5f/0xa5 [625138.255376] ======= -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: bugreport kernel panic on early stage, with HIGHMEM4G:

2008-01-17 Thread Denys Fedoryshchenko
9188] io scheduler cfq registered (default) [ 24.289542] Boot video device is :01:00.0 [ 24.289613] PCI: Setting latency timer of device :00:01.0 to 64 On Tue, 15 Jan 2008 12:39:47 +0100, Ingo Molnar wrote > * Denys Fedoryshchenko <[EMAIL PROTECTED]> wrote: > > > Hi &

Re: TSC && HPET calibration

2008-01-15 Thread Denys Fedoryshchenko
Latest, 2.6.24-rc7, and 2.6.23 is the same. If more information required, tell me. It is btw not latest (not based on Core2) Xeon. On Tue, 15 Jan 2008 02:17:20 -0800, Andrew Morton wrote > On Thu, 10 Jan 2008 14:36:12 +0200 "Denys Fedoryshchenko" > <[EMAIL PROTECTED

native_flush_tlb_others very nasty crash

2008-01-14 Thread Denys Fedoryshchenko
Hi Correction, it is appearing from 2.6.22, oldest kernel i found on server is 2.6.22. Older kernels i didn't try, and probably will be difficult to try. -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-

native_flush_tlb_others very nasty crash

2008-01-14 Thread Denys Fedoryshchenko
r: KD7538-IFA-INTC0S another Manufacturer: 0198808980C1 Serial Number: 9C2EA25B Asset Tag: 000621 Part Number: KD7538-IFA-INTC0S -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: possible recursive locking, 2.6.24-rc7

2008-01-13 Thread Denys Fedoryshchenko
I cannot reproduce, it is happened with rtorrent just randomly. But i will patch and keep watching. On Sun, 13 Jan 2008 19:44:26 +0100, Peter Zijlstra wrote > On Sun, 2008-01-13 at 17:22 +0100, Peter Zijlstra wrote: > > On Sun, 2008-01-13 at 17:51 +0200, Denys Fedoryshchenko wrote: >

possible recursive locking, 2.6.24-rc7

2008-01-13 Thread Denys Fedoryshchenko
1/0x96 [159859.503098] [] common_interrupt+0x2e/0x34 [159859.503288] [] mwait_idle+0x12/0x14 [159859.503476] [] cpu_idle+0x7b/0x95 [159859.503662] [] rest_init+0x49/0x4b [159859.503844] [] start_kernel+0x2f9/0x301 [159859.504030] [<>] 0x0 [159859.504210] ======

TSC && HPET calibration

2008-01-10 Thread Denys Fedoryshchenko
pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe nx lm constant_tsc pebs bts sync_rdtsc pni monitor ds_cpl vmx cid cx16 xtpr lahf_lm bogomips: 6383.74 clflush size : 64 -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To

bugreport kernel panic on early stage, with HIGHMEM4G:

2008-01-06 Thread Denys Fedoryshchenko
ecode output http://www.nuclearcat.com/files/panic-07012008/dmidecode.txt lspci output http://www.nuclearcat.com/files/panic-07012008/lspci.txt -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

nmi_watchdog killing tickless feature

2007-12-24 Thread Denys Fedoryshchenko
is not bug, probably good to document, that it is killing powersaving features? -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Denys Fedoryshchenko
Thanks, it works like that. Seems in libata there is no fall-back to non-DMA mode, if DMA didn't work. On Thu, 8 Nov 2007 12:31:39 -0500, Jeff Garzik wrote > On Thu, Nov 08, 2007 at 06:44:31PM +0200, Denys Fedoryshchenko wrote: > > Doesn't help > > > > WRAP ~

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Denys Fedoryshchenko
] Buffer I/O error on device sda, logical block 0 [ 12.710123] ata1: EH complete [ 12.719187] unable to read partition table [ 12.732602] sd 0:0:0:0: [sda] Attached SCSI removable disk On Thu, 8 Nov 2007 10:48:13 +, Alan Cox wrote > On Thu, 8 Nov 2007 09:16:35 +0200 > &qu

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
Does it work as kernel parameter? I tried libata_dma_mask=0x4 and to set 0xf or 0xff - doesn't help. How to disable DMA in libata, if it is compiled in kernel? On Thu, 8 Nov 2007 01:30:53 +0100, Bartlomiej Zolnierkiewicz wrote > On Thursday 08 November 2007, Denys Fedoryshchen

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
tes DMA > support, which libata tries to use but which doesn't work. It looks > like it never tried falling back to PIO after DMA failed. Seems like > a deficiency in the speed-down logic? > > -- > Robert Hancock Saskatoon, SK, Canada > To email, remove "nospam&quo

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
ord wrote: > > That cannot be correct (??). Is this with hdparm-7.7 (latest sourceforge) > > ?? > > Can you show us the "hdparm --Istdout" output as well, please. > > If this is applicable... FWIW hdparm was only recently (in past <72 > hours) upda

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
.. FWIW hdparm was only recently (in past <72 > hours) updated from 6.9 to 7.7 in Fedora... > > Jeff -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
?? > > That cannot be correct (??). Is this with hdparm-7.7 (latest > sourceforge) ?? Can you show us the "hdparm --Istdout" output as > well, please. > > thanks. -- Denys Fedoryshchenko Technical Manager Virtual ISP S.A.L. - To unsubscribe from this list: send the

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
00 0000 000

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
On Thu, 08 Nov 2007 00:23:10 +0900, James Andrewartha wrote > Denys Fedoryshchenko wrote: > > On Tue, 6 Nov 2007 22:15:21 -0800, Andrew Morton wrote > >>> On Thu, 1 Nov 2007 23:30:13 +0200 "Denys" <[EMAIL PROTECTED]> wrote: > >>> Finally i got full

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
DRDY } > > ata1: soft resetting link > > ata1.00: configured for MWDMA1 > > sd 0:0:0:0: [sda] Result: hostbyte=0x00 driverbyte=0x08 > > sd 0:0:0:0: [sda] Sense Key : 0xb [current] [descriptor] > > Descriptor sense data with sense descriptors (in hex): > > 72