Re: [PATCH v3] perf: build reproducibility improvements

2021-04-12 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
lot of tricky code because of one file, how about we compile > tips.txt in perf binary directly? it might be even less code changes I'm not sure about changes size, but anyway i agree that it makes more sense to compile tips.txt in perf binary. F

[PATCH v3] perf: build reproducibility improvements

2021-04-08 Thread Denys Zagorui
be remapped by using --file-prefix-map option that is available starting from version 3.7.1. Signed-off-by: Denys Zagorui --- tools/perf/Build | 1 - tools/perf/Makefile.config| 9 + tools/perf/builtin-report.c | 13 +++- tools/perf/tests/Build| 2 +- tools/perf

Re: [PATCH v2] perf: build reproducibility improvements

2021-03-17 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
if (exec_path == NULL) > > + return -1; > > + > > + if (asprintf(, "%spython", exec_path) < 0) > > are we sure there's always trailing '/' in exec_path ? Yes, it should be. /proc/self/exe is a absolute symlink to running executable ___

[PATCH v2] perf: build reproducibility improvements

2021-03-15 Thread Denys Zagorui
determined in runtime. bison stores full paths in generated files. This can be remapped by using --file-prefix-map option that is available starting from version 3.7.1. Signed-off-by: Denys Zagorui --- tools/lib/subcmd/exec-cmd.c | 21 + tools/lib/subcmd/exec-cmd.h | 1

Re: [PATCH] perf: build reproducibility improvements

2021-03-15 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
lsa Sent: 15 March 2021 14:28 To: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco) Cc: pet...@infradead.org; mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; alexander.shish...@linux.intel.com; namhy...@kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: build reprod

[PATCH] perf: build reproducibility improvements

2021-03-12 Thread Denys Zagorui
determined in runtime. bison stores full paths in generated files. This can be remapped by using --file-prefix-map option that is available starting from version 3.6.3. Signed-off-by: Denys Zagorui --- tools/lib/subcmd/exec-cmd.c | 21 + tools/lib/subcmd/exec-cmd.h | 1

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-23 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> I fixed the first sentence: > > Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make > __FILE__ a relative path") commit. > > to > > Follow-up to commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to > make __FILE__ a relative path"). ok, i see > > Assembler sources also use

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-18 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> ping Any comments on this ? Thanks, Denys

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-09 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make > __FILE__ a relative path") commit. Assembler sources also use __FILE__ > macro so this flag should be also apllied to that sources. > > Signed-off-by: Denys Zagorui > --- > Makefile | 2 +- >

[PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-02 Thread Denys Zagorui
Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path") commit. Assembler sources also use __FILE__ macro so this flag should be also apllied to that sources. Signed-off-by: Denys Zagorui --- Makefile | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2] kbuild: use -fmacro-prefix-map for .S sources compilation

2020-11-02 Thread Denys Zagorui
Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path") commit. Assembler sources also use __FILE__ macro so this flag should be also apllied to that sources. Signed-off-by: Denys Zagorui --- Makefile | 2 +- 1 file changed, 1 insertion(+),

[PATCH] kbuild: use -fmacro-prefix-map for .S sources compilation

2020-10-29 Thread Denys Zagorui
Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path") commit. Assembler sources also use __FILE__ macro so this flag should be also apllied to that sources. Signed-off-by: Denys Zagorui --- Makefile | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-26 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
>This doesn't seem appropriate at all. If anything UC addresses >should be blocked and the Intel driver change reverted. We have >a well defined way to add secondary UC addresses and the MC interfaces >are not it. As I understand by ‘well defined way’ you mean macvlan feature. But macvlan is

[PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-17 Thread Denys Zagorui
. (2f41f3358672 i40e/i40evf: fix unicast mac address add) This patch adds check whether passed mac addr is uc or mc and adds this mac addr to the corresponding list. Add 'global' variant for adding/removing uc addresses similarly to mc. Signed-off-by: Denys Zagorui --- include/linux/netdevice.h| 2

[RFC][PATCH] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-14 Thread Denys Zagorui
. (2f41f3358672 i40e/i40evf: fix unicast mac address add) This patch adds check whether passed mac addr is uc or mc and adds this mac addr to the corresponding list. Add 'global' variant for adding/removing uc addresses similarly to mc. Signed-off-by: Denys Zagorui --- include/linux/netdevice.h| 2

[PATCH v3] serial: 8250: convert to threaded IRQ

2017-12-04 Thread Denys Zagorui
t;too much work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby <jsl...@suse.com> Signed-of

[PATCH v3] serial: 8250: convert to threaded IRQ

2017-12-04 Thread Denys Zagorui
t;too much work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby Signed-off-by: Denys Zagorui --- v1

[PATCH v2] serial: 8250: convert to threaded IRQ

2017-11-15 Thread Denys Zagorui
t;too much work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby <jsl...@suse.com> Signed-of

[PATCH v2] serial: 8250: convert to threaded IRQ

2017-11-15 Thread Denys Zagorui
t;too much work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby Signed-off-by: Denys Zagorui --- dri

[PATCH] serial: 8250: convert to threaded IRQ

2017-11-09 Thread Denys Zagorui
work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby <jsl...@suse.com> Signed-of

[PATCH] serial: 8250: convert to threaded IRQ

2017-11-09 Thread Denys Zagorui
work" messages First one doesn't help now, last one was reverted (12de375ec493ab1767d4a07dde823e63ae5edc21) in fact it doesn't fix anything. So procesing interrupts in kthread give us an opportunity to perform rescheduling periodically. Cc: Jiri Slaby Signed-off-by: Denys Zagorui --- dri

Re: [RFC PATCH] serial: 8250, redirect IRQ processing to kthread

2017-11-02 Thread Denys Zagorui
d opportunity to put this processing in kthread. Signed-off-by: Denys Zagorui <dzago...@cisco.com> --- drivers/tty/serial/8250/8250_core.c | 29 + drivers/tty/serial/8250/8250_port.c | 10 ++ drivers/tty/serial/8250/Kconfig | 10 ++ 3 files changed, 49

Re: [RFC PATCH] serial: 8250, redirect IRQ processing to kthread

2017-11-02 Thread Denys Zagorui
d opportunity to put this processing in kthread. Signed-off-by: Denys Zagorui --- drivers/tty/serial/8250/8250_core.c | 29 + drivers/tty/serial/8250/8250_port.c | 10 ++ drivers/tty/serial/8250/Kconfig | 10 ++ 3 files changed, 49 insertions(+) diff