lot of tricky code because of one file, how about we compile
> tips.txt in perf binary directly? it might be even less code changes
I'm not sure about changes size, but anyway i agree that it makes more
sense to compile tips.txt in perf binary.
F
if (exec_path == NULL)
> > + return -1;
> > +
> > + if (asprintf(, "%spython", exec_path) < 0)
>
> are we sure there's always trailing '/' in exec_path ?
Yes, it should be. /proc/self/exe is a absolute symlink to running executable
___
lsa
Sent: 15 March 2021 14:28
To: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
Cc: pet...@infradead.org; mi...@redhat.com; a...@kernel.org;
mark.rutl...@arm.com; alexander.shish...@linux.intel.com; namhy...@kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: build reprod
> I fixed the first sentence:
>
> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
> __FILE__ a relative path") commit.
>
> to
>
> Follow-up to commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to
> make __FILE__ a relative path").
ok, i see
> > Assembler sources also use
> ping
Any comments on this ?
Thanks,
Denys
> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make
> __FILE__ a relative path") commit. Assembler sources also use __FILE__
> macro so this flag should be also apllied to that sources.
>
> Signed-off-by: Denys Zagorui
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1
>This doesn't seem appropriate at all. If anything UC addresses
>should be blocked and the Intel driver change reverted. We have
>a well defined way to add secondary UC addresses and the MC interfaces
>are not it.
As I understand by ‘well defined way’ you mean macvlan feature. But macvlan
is
7 matches
Mail list logo
