Re: [PATCH v3] perf: build reproducibility improvements

2021-04-12 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
+ free(config_detected); > > + return ret; > > +} > > it's lot of tricky code because of one file, how about we compile > tips.txt in perf binary directly? it might be even less code changes I'm not sure about changes size, but anyway i agree that it makes more sense to compile tips.txt in perf bi

Re: [PATCH v2] perf: build reproducibility improvements

2021-03-17 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
get_exec_abs_path(); > > + if (exec_path == NULL) > > + return -1; > > + > > + if (asprintf(&pythonpath, "%spython", exec_path) < 0) > > are we sure there's always trailing '/' in exec_path ? Yes, it should be. /proc/se

Re: [PATCH] perf: build reproducibility improvements

2021-03-15 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
____________ From: Jiri Olsa Sent: 15 March 2021 14:28 To: Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco) Cc: pet...@infradead.org; mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; alexander.shish...@linux.intel.com; namhy...@kernel.org; linux-kernel@vger.kernel.org

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-23 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> I fixed the first sentence: > > Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make > __FILE__ a relative path") commit. > > to > > Follow-up to commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to > make __FILE__ a relative path"). ok, i see > > Assembler sources also use __F

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-18 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> ping Any comments on this ? Thanks, Denys

Re: [PATCH v3] kbuild: use -fmacro-prefix-map for .S sources

2020-11-09 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
> Follow-up to a73619a845d5 ("kbuild: use -fmacro-prefix-map to make > __FILE__ a relative path") commit. Assembler sources also use __FILE__ > macro so this flag should be also apllied to that sources. > > Signed-off-by: Denys Zagorui > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-26 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
>This doesn't seem appropriate at all. If anything UC addresses >should be blocked and the Intel driver change reverted. We have >a well defined way to add secondary UC addresses and the MC interfaces >are not it. As I understand by ‘well defined way’ you mean macvlan feature. But macvlan is mo