Re: cdrom: debug info changes, Beurer glucometer support

2019-10-13 Thread Diego Elio Pettenò
On Mon, Aug 26, 2019 at 4:16 PM Diego Elio Pettenò wrote: > I've been hacking around the cdrom driver so that I could get Linux to > mount and access the virtual CD device used by the Beurer GL50 evo > glucometer. The device is fairly quirky and goes into a reset cycle on a > va

[PATCH 3/4] cdrom: remove REVISION/VERSION constants that are awfully out of date.

2019-08-26 Thread Diego Elio Pettenò
This driver changed significantly since 2003, there's no point in it pretending to still be that. Signed-off-by: Diego Elio Pettenò --- drivers/cdrom/cdrom.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c

[PATCH 1/4] cdrom: remove entering/exiting debug message logs.

2019-08-26 Thread Diego Elio Pettenò
Nowadays, ftrace function and function_graph tracers provide the same level of information, in a more standard and complete format. Cc: Joe Perches Signed-off-by: Diego Elio Pettenò --- drivers/cdrom/cdrom.c | 79 ++- 1 file changed, 3 insertions(+), 76

cdrom: debug info changes, Beurer glucometer support

2019-08-26 Thread Diego Elio Pettenò
Hello, I've been hacking around the cdrom driver so that I could get Linux to mount and access the virtual CD device used by the Beurer GL50 evo glucometer. The device is fairly quirky and goes into a reset cycle on a vanilla kernel. Since I had no idea how to get to the right changes at first, I

[PATCH 2/4] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-26 Thread Diego Elio Pettenò
the driver. Signed-off-by: Diego Elio Pettenò --- drivers/cdrom/cdrom.c | 174 ++ 1 file changed, 57 insertions(+), 117 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index b9a43d0011ef..ec1267d0a5c0 100644 --- a/drivers/cdrom

[PATCH 4/4] cdrom: support Beurer GL50 evo CD-on-a-chip devices.

2019-08-26 Thread Diego Elio Pettenò
avoided at all costs. In addition to adding a new vendor entry to sr_vendor, this required gating a few functions in the cdrom driver to not even try sending the command when the capability is not present. Signed-off-by: Diego Elio Pettenò --- drivers/cdrom/cdrom.c| 13 - drivers

Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-26 Thread Diego Elio Pettenò
On Sun, Aug 25, 2019 at 11:13 PM Joe Perches wrote: > > - cd_dbg(CD_OPEN, "entering register_cdrom\n"); > > + pr_debug("entering register_cdrom\n"); > > debut output for function tracing can also be removed > and ftrace used instead. Oh, nice! I have never had to go this deep into a drive

[PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-25 Thread Diego Elio Pettenò
the driver. Signed-off-by: Diego Elio Pettenò --- drivers/cdrom/cdrom.c | 270 +- 1 file changed, 106 insertions(+), 164 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index ac42ae4651ce..7fc94b5f6556 100644 --- a/drivers/cdrom

[PATCH] mailmap: rewrite full name for Diego Elio Pettenò.

2016-01-23 Thread Diego Elio Pettenò
Current log includes at least a couple different spelling of my name, including the old one before I legally changed it. Also update to use my own controlled domain, rather than GMail. Signed-off-by: Diego Elio Pettenò --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b

[PATCH] gameport: limit the configuration to x86 architecture.

2013-06-06 Thread Diego Elio Pettenò
The gameport driver relies on features of x86/x86-64, so it's unlikely that it could work on other architectures. Furthermore the l4 driver can panic a kernel running on ARM (for instance) by trying to access the 0x204 address. Signed-off-by: Diego Elio Pettenò --- drivers/input/gam

[PATCH] Use menuconfig instead of creating menus with an enabler first entry.

2013-06-06 Thread Diego Elio Pettenò
This seems to be what most of the other drivers subdirectories do, and makes menuconfig friendlier. Signed-off-by: Diego Elio Pettenò --- drivers/bcma/Kconfig | 9 - drivers/pps/Kconfig | 8 ++-- drivers/ssb/Kconfig | 9 - 3 files changed, 10 insertions(+), 16 deletions

[RFC] gameport: limit the PDPI L4 driver to X86.

2013-03-30 Thread Diego Elio Pettenò
This driver, at least on ARM, can cause the kernel to fail with a pointer dereference to address 0x210 (which it tries to outb to). Signed-off-by: Diego Elio Pettenò --- drivers/input/gameport/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/gameport/Kconfig b/drivers