On 20/04/2021 14:56, pierre.gond...@arm.com wrote:
> From: Pierre Gondois
>
> find_energy_efficient_cpu() (feec()) searches the best energy CPU
> to place a task on. To do so, compute_energy() estimates the energy
> impact of placing the task on a CPU, based on CPU and task utilization
> signals.
On 19/04/2021 04:55, Ruifeng Zhang wrote:
> Dietmar Eggemann 于2021年4月17日周六 上午1:00写道：
>>
>> On 16/04/2021 13:04, Ruifeng Zhang wrote:
>>> Dietmar Eggemann 于2021年4月16日周五 下午6:39写道：
>>>>
>>>> On 16/04/2021 11:32, Valentin Schneider wrote:
>>>
On 16/04/2021 13:04, Ruifeng Zhang wrote:
> Dietmar Eggemann 于2021年4月16日周五 下午6:39写道：
>>
>> On 16/04/2021 11:32, Valentin Schneider wrote:
>>> On 16/04/21 15:47, Ruifeng Zhang wrote:
[...]
>> I'm confused. Do you have the MT bit set to 1 then? So the issue th
On 16/04/2021 11:32, Valentin Schneider wrote:
> On 16/04/21 15:47, Ruifeng Zhang wrote:
>> For more requirements, if all cores in one physical cluster, the
>> {aff2} of all cores are the same value.
>> i.e. the sc9863a,
>> core0: 8100
>> core1: 81000100
>> core2: 810002
On 15/04/2021 20:09, Valentin Schneider wrote:
> On 14/04/21 20:23, Ruifeng Zhang wrote:
>> From: Ruifeng Zhang
>>
>> In Unisoc, the sc9863a SoC which using cortex-a55, it has two software
>> version, one of them is the kernel running on EL1 using aarch32.
>> user(EL0)
On 15/04/2021 11:06, Peter Zijlstra wrote:
> On Tue, Apr 13, 2021 at 03:55:15PM +0100, Valentin Schneider wrote:
>> On 12/04/21 12:14, Peter Zijlstra wrote:
>>> Stop polluting sysctl, move to debugfs for SCHED_DEBUG stuff.
>>>
>>> Signed-off-by: Peter Zijlst
On 14/04/2021 13:26, Ruifeng Zhang wrote:
> Dietmar Eggemann 于2021年4月14日周三 下午5:43写道：
>>
>> On 13/04/2021 15:26, Ruifeng Zhang wrote:
>>> Thanks for your review. Patch-v2 that solve the capacity issue will be
>>> uploaded as soon as possible. : )
>>>
>
On 13/04/2021 15:26, Ruifeng Zhang wrote:
> Thanks for your review. Patch-v2 that solve the capacity issue will be
> uploaded as soon as possible. : )
>
> Valentin Schneider 于2021年4月13日周二 下午7:40写道：
>>
>> On 13/04/21 14:13, Ruifeng Zhang wrote:
>>> Valentin Schneider 于2021年4月12日周一 下午11:33写道：
On 13/04/2021 18:28, Steven Rostedt wrote:
> On Tue, 13 Apr 2021 10:36:07 +0200
> Dietmar Eggemann wrote:
[...]
>> Add a
>>
>> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
>>
>> line.
>
> It's just removing a comment.
unsigned intnr_numa_running;
I forgot to remove this snippet back then. LGTM.
Add a
Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
line.
Reviewed-by: Dietmar Eggemann
On 12/04/2021 14:20, Ruifeng Zhang wrote:
> Valentin Schneider 于2021年4月12日周一 下午7:32写道：
>>
>>
>> Hi,
>>
>> On 12/04/21 15:08, Ruifeng Zhang wrote:
>>> From: Ruifeng Zhang
>>>
>>> The arm topology still parse from the MPIDR, but it is incomplete. When
>>> the armv8.3 cpu runs in aarch32 mode, it w
t CPU makes really sense
here. Might be worth mentioning in the patch header why. There is some
of it in v3 6/7 but that's a different change.
Reviewed-by: Dietmar Eggemann
[...]
r even happens on the CPU that appended the stopper work.
>
> Add a struct lb_env flag to denote active balancing, and use it in
> can_migrate_task(). Remove the sd->nr_balance_failed write that served the
> same purpose. Cleanup the LBF_DST_PINNED active balance special case.
>
> Signed-off-by: Valentin Schneider
Reviewed-by: Dietmar Eggemann
[...]
On 01/04/2021 21:30, Valentin Schneider wrote:
> From: Lingutla Chandrasekhar
>
> During load balance, LBF_SOME_PINNED will bet set if any candidate task
nitpick; s/bet/be ?
[...]
Reviewed-by: Dietmar Eggemann
;
> - BUG_ON(newpri >= CPUPRI_NR_PRIORITIES);
> -
> if (newpri == oldpri)
> return;
>
>
LGTM. Currently, convert_prio() is never called with prio <
CPUPRI_INVALID (-1) or prio > MAX_RT_PRIO (100) but in case it would
then this would be caught much easier with this patch.
Reviewed-by: Dietmar Eggemann
+cc: Pierre Gondois
On 30/03/2021 11:45, Quentin Perret wrote:
> Hi,
>
> On Tuesday 30 Mar 2021 at 13:21:54 (+0800), Xuewen Yan wrote:
>> From: Xuewen Yan
>>
>> now the energy delta compute as follow:
>>
>> base_energy_pd = compute_energy(p, -1, pd);
>> --->Traverse all CPUs in pd
>>
2
> kernel/sched/topology.c |1
> 3 files changed, 59 insertions(+), 199 deletions(-)
Reviewed-by: Dietmar Eggemann
[...]
> +#define SDM(type, mode, member) \
> + debugfs_create_##type(#member, mode, parent, &sd->member)
>
> - WARN_ON(sd_c
On 26/03/2021 11:34, Peter Zijlstra wrote:
> The current sched_slice() seems to have issues; there's two possible
> things that could be improved:
>
> - the 'nr_running' used for __sched_period() is daft when cgroups are
>considered. Using the RQ wide h_nr_running seems like a much more
>
On 11/03/2021 13:05, Valentin Schneider wrote:
[...]
> @@ -9952,7 +9954,8 @@ static int active_load_balance_cpu_stop(void *data)
>* @dst_grpmask we need to make that test go away with
> lying
>* about DST_PINNED.
>*/
> -
On 16/03/2021 18:31, Valentin Schneider wrote:
> On 16/03/21 16:49, Dietmar Eggemann wrote:
>> On 11/03/2021 13:05, Valentin Schneider wrote:
>>> From: Lingutla Chandrasekhar
>>>
>>> In load balancing, when balancing group is unable to pull task
>>>
Hi Chandra,
On 16/03/2021 17:03, Chandra Sekhar Lingutla wrote:
> Hi Dietmar,
>
> On 3/16/2021 9:19 PM, Dietmar Eggemann wrote:
>> On 11/03/2021 13:05, Valentin Schneider wrote:
>>> From: Lingutla Chandrasekhar
[...]
>>> CPUs 2-3 as Bigs with below scen
On 11/03/2021 13:05, Valentin Schneider wrote:
> From: Lingutla Chandrasekhar
>
> In load balancing, when balancing group is unable to pull task
> due to ->cpus_ptr constraints from busy group, then it sets
> LBF_SOME_PINNED to lb env flags, as a consequence, sgc->imbalance
> is set for its paren
Hi Michal,
On 25/02/2021 17:27, Michal Koutný wrote:
> leaf_cfs_rq_list should contain cfs_rqs that have runnable entities in
> them. When we're operating under a throttled hierarchy we always update
> the leaf_cfs_rq_list in order no to break list_add_leaf_cfs_rq invariant
> of adding complete b
On 26/02/2021 17:40, Srikar Dronamraju wrote:
[...]
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8a8bd7b13634..d49bfcdc4a19 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5869,6 +5869,36 @@ wake_affine_weight(struct sched_domain *sd, struct
> task_struct
On 26/02/2021 09:41, Peter Zijlstra wrote:
> On Thu, Feb 25, 2021 at 04:58:20PM +, Vincent Donnefort wrote:
>> +#define UTIL_EST_MARGIN (SCHED_CAPACITY_SCALE / 100)
>> +
>> /*
>> - * Check if a (signed) value is within a specified (unsigned) margin,
>> + * Check if a (signed) value is within t
>*/
> if (task_cpu(p) == cpu && dst_cpu != cpu)
> - sub_positive(&util, task_util(p));
> + lsub_positive(&util, task_util(p));
> else if (task_cpu(p) != cpu && dst_cpu == cpu)
> util += task_util(p);
Reviewed-by: Dietmar Eggemann
cpu_util_est + _task_util_est)
> + */
Nit pick:
s/on @cpu/on @dst_cpu ?
s/while cpu_util_next is/while cpu_util_next(cpu, p, cpu) would be
If dst_cpu != cpu (including dst_cpu == -1) task_util and _task_util_est
are not added to util resp. util_est.
Not sure if this is clear from the source code here?
[...]
Reviewed-by: Dietmar Eggemann
On 22/02/2021 17:23, Quentin Perret wrote:
> On Monday 22 Feb 2021 at 15:58:56 (+), Quentin Perret wrote:
>> But in any case, if we're going to address this, I'm still not sure this
>> patch will be what we want. As per my first comment we need to keep the
>> frequency estimation right.
>
> To
On 22/02/2021 10:54, vincent.donnef...@arm.com wrote:
> From: Vincent Donnefort
[...]
> Also, replace sub_positive with lsub_positive which saves one explicit
> load-store.
IMHO, in case you're going to fix this now in compute_energy(), this
optimization could still be done. Maybe in an extra p
always with a (non-test) tasks migrating
from one CPU to another.
> Signed-off-by: Vincent Donnefort
Reviewed-by: Dietmar Eggemann
[...]
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 9d061ba6bc170045857f3efe0bba5def30188d4d
Gitweb:
https://git.kernel.org/tip/9d061ba6bc170045857f3efe0bba5def30188d4d
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:39 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 71e5f6644fb2f3304fcb310145ded234a37e7cc1
Gitweb:
https://git.kernel.org/tip/71e5f6644fb2f3304fcb310145ded234a37e7cc1
Author:Dietmar Eggemann
AuthorDate:Mon, 01 Feb 2021 10:53:53 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: ae18ad281e825993d190073d0ae2ea35dee27ee1
Gitweb:
https://git.kernel.org/tip/ae18ad281e825993d190073d0ae2ea35dee27ee1
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:38 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c541bb7835a306cdbbe8abbdf4e4df507e0ca27a
Gitweb:
https://git.kernel.org/tip/c541bb7835a306cdbbe8abbdf4e4df507e0ca27a
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:40 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: de40f33e788b0c016bfde512ace2f76339ef7ddb
Gitweb:
https://git.kernel.org/tip/de40f33e788b0c016bfde512ace2f76339ef7ddb
Author:Dietmar Eggemann
AuthorDate:Tue, 19 Jan 2021 09:35:42 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 3096b6fe494b7b4e45d20cb77aa6b715a3efe344
Gitweb:
https://git.kernel.org/tip/3096b6fe494b7b4e45d20cb77aa6b715a3efe344
Author:Dietmar Eggemann
AuthorDate:Tue, 19 Jan 2021 09:35:42 +01:00
On 05/02/2021 12:48, Vincent Guittot wrote:
> Instead of waking up a random and already idle CPU, we can take advantage
> of this_cpu being about to enter idle to run the ILB and update the
> blocked load.
>
> Signed-off-by: Vincent Guittot
> ---
> include/linux/sched/nohz.h | 2 ++
> kernel/sc
On 05/02/2021 12:48, Vincent Guittot wrote:
> Reorder the tests and skip prevent useless test when no load balance has
> been performed.
LGTM.
But IMHO the reason why those two if conditions can be skipped for the
'goto out' path is that we don't release the rq lock rather the actual
lb. Might be
On 05/02/2021 12:48, Vincent Guittot wrote:
> newidle_balance runs with both preempt and irq disabled which prevent
> local irq to run during this period. The duration for updating of the
> blocked load of CPUs varies according to the number of cgroups and
Maybe s/number of cgroups/number of CPU c
On 05/02/2021 12:48, Vincent Guittot wrote:
> idle load balance is the only user of update_nohz_stats and doesn't use
> force parameter. Remove it
Wasn't the 'force=true' from ilb eclipsing the jiffy resolution rate
limiting '!time_after(jiffies, rq->last_blocked_load_update_tick)' of
update_block
On 04/02/2021 12:34, Valentin Schneider wrote:
> On 04/02/21 11:49, Dietmar Eggemann wrote:
>> On 03/02/2021 16:15, Qais Yousef wrote:
>>> On 01/28/21 18:31, Valentin Schneider wrote:
[...]
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 21bd71f58
On 03/02/2021 19:43, Valentin Schneider wrote:
> Hi Qais,
>
> On 03/02/21 15:14, Qais Yousef wrote:
>> On 01/28/21 18:31, Valentin Schneider wrote:
>>> Hi folks,
>>>
>>> Here is this year's series of misfit changes. On the menu:
>>>
>>> o Patch 1 is an independent active balance cleanup
>>> o Patc
On 03/02/2021 19:43, Valentin Schneider wrote:
> On 03/02/21 15:16, Qais Yousef wrote:
>> On 01/28/21 18:31, Valentin Schneider wrote:
>>> Giving group_misfit_task a higher group_classify() priority than
>>> group_imbalance doesn't seem like the right thing to do. Instead, make
>>> need_active_bala
On 03/02/2021 16:15, Qais Yousef wrote:
> On 01/28/21 18:31, Valentin Schneider wrote:
[...]
>> @@ -10238,7 +10236,7 @@ static void nohz_balancer_kick(struct rq *rq)
>> * When ASYM_CPUCAPACITY; see if there's a higher capacity CPU
>> * to run the misfit task on.
>>
On 03/02/2021 14:12, Vincent Guittot wrote:
> On Wed, 3 Feb 2021 at 12:54, Dietmar Eggemann
> wrote:
>>
>> On 29/01/2021 18:27, Vincent Guittot wrote:
>>> Le vendredi 29 janv. 2021 � 11:33:00 (+0100), Vincent Guittot a �crit :
>>>> On Thu, 28 Jan 202
On 29/01/2021 18:27, Vincent Guittot wrote:
> Le vendredi 29 janv. 2021 � 11:33:00 (+0100), Vincent Guittot a �crit :
>> On Thu, 28 Jan 2021 at 16:09, Joel Fernandes wrote:
>>>
>>> Hi Vincent,
>>>
>>> On Thu, Jan 28, 2021 at 8:57 AM Vincent Guittot
>>> wrote:
> On Mon, Jan 25, 2021 at 03:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c18b4a67cc459fb8389f6a89ce28e404aafe562c
Gitweb:
https://git.kernel.org/tip/c18b4a67cc459fb8389f6a89ce28e404aafe562c
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:39 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: e972d92d52a1f691498add14feb2ee5902d02404
Gitweb:
https://git.kernel.org/tip/e972d92d52a1f691498add14feb2ee5902d02404
Author:Dietmar Eggemann
AuthorDate:Mon, 01 Feb 2021 10:53:53 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4d38ea6a6d93115113fb4c023d5bb15e8ce1589c
Gitweb:
https://git.kernel.org/tip/4d38ea6a6d93115113fb4c023d5bb15e8ce1589c
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:38 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 075a28439d0c8eb6d3c799e1eed24bb9bc7750cd
Gitweb:
https://git.kernel.org/tip/075a28439d0c8eb6d3c799e1eed24bb9bc7750cd
Author:Dietmar Eggemann
AuthorDate:Thu, 28 Jan 2021 14:10:40 +01:00
On 01/02/2021 08:49, kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 620a6dc40754dc218f5b6389b5d335e9a107fd29 ("sched/topology: Make
> sched_init_numa() use a set for the deduplicating sort")
> https://git.kernel.org/cgit/linux/ker
loc((i + nr_levels) *
> sizeof(struct sched_domain_topology_level), GFP_KERNEL);
> if (!tl)
> return;
This hunk creates issues during startup on my Arm64 juno board on
tip/sched/core.
---8<---
From: Dietmar Eggemann
Date: Mon, 1 Feb 2021 09:58:04 +0100
S
he
{*_}USER_PRIO defines.
Signed-off-by: Dietmar Eggemann
---
arch/powerpc/platforms/cell/spufs/sched.c | 2 +-
include/linux/sched/prio.h| 9 -
kernel/sched/sched.h | 2 +-
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/arch/powe
Get rid of MAX_USER_RT_PRIO and make everything use MAX_RT_PRIO
instead.
Signed-off-by: Dietmar Eggemann
---
include/linux/sched/prio.h | 9 +
kernel/sched/core.c| 7 +++
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/include/linux/sched/prio.h b/include/linux/sched/pr
The description of the RT offset and the values for 'normal' tasks needs
update. Moreover there are DL tasks now.
task_prio() has to stay like it is to guarantee compatibility with the
/proc//stat priority field:
# cat /proc//stat | awk '{ print $18; }'
Signed-off-
t why this range is mentioned here? Maybe
the influence of the 'sleep-bonus interactivity' feature which was
removed by commit f3479f10c5d6 ("sched: remove the sleep-bonus
interactivity code")?
Dietmar Eggemann (3):
sched: Remove MAX_USER_RT_PRIO
sched: Remove
On 25/01/2021 11:50, Song Bao Hua (Barry Song) wrote:
>
>> -Original Message-
>> From: Dietmar Eggemann [mailto:dietmar.eggem...@arm.com]
>> Sent: Wednesday, January 13, 2021 12:00 AM
>> To: Morten Rasmussen ; Tim Chen
>>
>> Cc: Song Bao Hua (Barr
On 25/01/2021 18:30, Vincent Guittot wrote:
> On Mon, 25 Jan 2021 at 11:45, Dietmar Eggemann
> wrote:
>>
>> On 22/01/2021 20:10, Joel Fernandes wrote:
>>> Hi Vincent,
>>>
>>> Thanks for reply. Please see the replies below:
>>>
>>>
On 22/01/2021 20:10, Joel Fernandes wrote:
> Hi Vincent,
>
> Thanks for reply. Please see the replies below:
>
> On Fri, Jan 22, 2021 at 05:56:22PM +0100, Vincent Guittot wrote:
>> On Fri, 22 Jan 2021 at 16:46, Joel Fernandes (Google)
>> wrote:
>>>
>>> On an octacore ARM64 device running ChromeO
On 21/01/2021 22:17, Song Bao Hua (Barry Song) wrote:
>
>
>> -Original Message-----
>> From: Dietmar Eggemann [mailto:dietmar.eggem...@arm.com]
>> Sent: Friday, January 22, 2021 7:54 AM
>> To: Valentin Schneider ; Meelis Roos
>> ; LKML
>> Cc: Pete
On 21/01/2021 19:21, Valentin Schneider wrote:
> On 21/01/21 19:39, Meelis Roos wrote:
>>> Could you paste the output of the below?
>>>
>>>$ cat /sys/devices/system/node/node*/distance
>>
>> 10 12 12 14 14 14 14 16
>> 12 10 14 12 14 14 12 14
>> 12 14 10 14 12 12 14 14
>> 14 12 14 10 12 12 14 14
On 19/01/2021 10:41, Daniel Bristot de Oliveira wrote:
> On 1/14/21 4:51 PM, Dietmar Eggemann wrote:
>> On 12/01/2021 16:53, Daniel Bristot de Oliveira wrote:
[...]
>> with this patch:
>>
>> cgroupv1:
>>
>> root@juno:/sys/fs/cgroup/cpuset# chrt -d --sch
bandwidth management.
Reviewed-by: Quentin Perret
Signed-off-by: Dietmar Eggemann
---
The use case in which this makes a noticeable difference is Android's
'CPU pause' power management feature.
It uses CPU hotplug control to clear a CPU from active state to force
all threads which are
On 12/01/2021 16:53, Daniel Bristot de Oliveira wrote:
[...]
> - %< -
> #!/bin/bash
> # Enter on the cgroup directory
> cd /sys/fs/cgroup/
>
> # Check it if is cgroup v2 and enable cpuset
> if [ -e cgroup.subtree_control ]; then
> # Enable cpuset controller on cgroup v2
>
On 12/01/2021 16:53, Daniel Bristot de Oliveira wrote:
> The current SCHED_DEADLINE design supports only global scheduler,
> or variants of it, i.e., clustered and partitioned, via cpuset config.
> To enable the partitioning of a system with clusters of CPUs, the
> documentation advises the usage o
valid CPU (>=
nr_cpu_ids) here.
> Initially, I thought about returning an error and blocking the
> operation. However, that is indeed not needed. The cpuset without
> CPUs assigned will be a non-root cpuset, hence its cpu mask will
> be the same as the root one. So, the bandwidth
On 08/01/2021 22:30, Song Bao Hua (Barry Song) wrote:
>
>> -Original Message-
>> From: Morten Rasmussen [mailto:morten.rasmus...@arm.com]
>> Sent: Saturday, January 9, 2021 4:13 AM
>> To: Tim Chen
>> Cc: Song Bao Hua (Barry Song) ;
>> valentin.schnei...@arm.com; catalin.mari...@arm.com;
On 11/01/2021 10:28, Morten Rasmussen wrote:
> On Fri, Jan 08, 2021 at 12:22:41PM -0800, Tim Chen wrote:
>>
>>
>> On 1/8/21 7:12 AM, Morten Rasmussen wrote:
>>> On Thu, Jan 07, 2021 at 03:16:47PM -0800, Tim Chen wrote:
On 1/6/21 12:30 AM, Barry Song wrote:
[...]
>> I think it is going to dep
util_est_dequeue()
(B) task_util_est update in util_est_update()
Place (A) before (1) and keep (B) where (2) is. The latter is necessary
since (B) relies on task_util update in (1).
---
What do you think?
>
> Signed-off-by: Xuewen Yan
> Signed-off-by: Dietmar Eggemann
Please remo
On 09/12/2020 11:44, Xuewen Yan wrote:
> when a task dequeued, it will update it's util, and cfs_rq_util_change
> would check rq's util, if the cfs_rq->avg.util_est.enqueued is bigger
> than cfs_rq->avg.util_avg, but because the cfs_rq->avg.util_est.enqueued
> didn't be decreased, this would cause
On 15/12/2020 13:56, Xuewen Yan wrote:
> On Tue, Dec 15, 2020 at 5:39 PM Vincent Guittot
> wrote:
>>
>> On Mon, 14 Dec 2020 at 19:46, Dietmar Eggemann
>> wrote:
>>>
>>> On 11/12/2020 13:03, Ryan Y wrote:
[...]
>>> It's true
ping) task.
If I would run with your patch cpu_util_cfs() would chose between 597 and 0
whereas without it does between 597 and 601.
Do you have a specific use case in mind? Or even test results showing a benefit
of your patch?
> Dietmar Eggemann 于2020年12月11日周五 下午7:30写道：
>
>> Hi Yan,
&
Hi Yan,
On 09/12/2020 11:44, Xuewen Yan wrote:
> when a task dequeued, it will update it's util, and cfs_rq_util_change
> would check rq's util, if the cfs_rq->avg.util_est.enqueued is bigger
> than cfs_rq->avg.util_avg, but because the cfs_rq->avg.util_est.enqueued
> didn't be decreased, this wo
On 07/12/2020 13:17, Viresh Kumar wrote:
> On 03-12-20, 12:54, Dietmar Eggemann wrote:
>> On 24/11/2020 07:26, Viresh Kumar wrote:
[...]
>> When I ran schbench (-t 16 -r 5) on hikey960 I get multiple (~50)
>> instances of ~80ms task activity phase and then ~20ms idle
On 07/12/2020 10:15, Mel Gorman wrote:
> SIS_AVG_CPU was introduced as a means of avoiding a search when the
> average search cost indicated that the search would likely fail. It
> was a blunt instrument and disabled by 4c77b18cf8b7 ("sched/fair: Make
> select_idle_cpu() more aggressive") and later
On 07/12/2020 10:15, Mel Gorman wrote:
> After select_idle_sibling, p->recent_used_cpu is set to the
> new target. However on the next wakeup, prev will be the same as
I'm confused here. Isn't current->recent_used_cpu set to 'cpu =
smp_processor_id()' after sis()? Looking at v5.10-rc6.
[...]
> d
On 24/11/2020 07:26, Viresh Kumar wrote:
> Several parts of the kernel are already using the effective CPU
> utilization (as seen by the scheduler) to get the current load on the
> CPU, do the same here instead of depending on the idle time of the CPU,
> which isn't that accurate comparatively.
>
On 01/12/2020 03:59, Barry Song wrote:
[...]
> Although I believe there is still a lot to do, sending a RFC to get feedbacks
> of community experts might be helpful for the next step.
>
> Barry Song (1):
> scheduler: add scheduler level for clusters
>
> Jonathan Cameron (1):
> topology: Rep
On 24/11/2020 14:22, Viresh Kumar wrote:
> On 24-11-20, 09:10, Quentin Perret wrote:
>> Hey Viresh,
>>
>> On Tuesday 24 Nov 2020 at 11:56:15 (+0530), Viresh Kumar wrote:
>>> There is nothing schedutil specific in schedutil_cpu_util(), rename it
>>> to effective_cpu_util(). Also create and expose an
der to predict the performance state, map the utilization of
>* the most utilized CPU of the performance domain to a requested
LGTM.
Reviewed-by: Dietmar Eggemann
On 23/11/2020 14:42, Vincent Guittot wrote:
> On Mon, 23 Nov 2020 at 12:27, Dietmar Eggemann
> wrote:
>>
>> On 23/11/2020 11:05, Vincent Guittot wrote:
>>> On Mon, 23 Nov 2020 at 10:30, Dietmar Eggemann
>>> wrote:
>>>>
>>>> On 20/11/
On 23/11/2020 11:05, Vincent Guittot wrote:
> On Mon, 23 Nov 2020 at 10:30, Dietmar Eggemann
> wrote:
>>
>> On 20/11/2020 09:56, Peter Zijlstra wrote:
>>> On Fri, Nov 20, 2020 at 08:55:27AM +0100, Peter Zijlstra wrote:
>>>> - In saturated scenarios task
On 20/11/2020 09:56, Peter Zijlstra wrote:
> On Fri, Nov 20, 2020 at 08:55:27AM +0100, Peter Zijlstra wrote:
>> - In saturated scenarios task movement will cause some transient dips,
>>suppose we have a CPU saturated with 4 tasks, then when we migrate a task
>>to an idle CPU, the old CPU w
On 20/11/2020 08:55, Peter Zijlstra wrote:
[...]
> PELT (Per Entity Load Tracking)
> ---
[...]
> Using this we track 2 key metrics: 'running' and 'runnable'. 'Running'
> reflects the time an entity spends on the CPU, while 'runnable' reflects the
> time an entity spe
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 480a6ca2dc6ed82c783faf7e4a9644769b8397d8
Gitweb:
https://git.kernel.org/tip/480a6ca2dc6ed82c783faf7e4a9644769b8397d8
Author:Dietmar Eggemann
AuthorDate:Fri, 13 Nov 2020 12:34:54 +01:00
On 12/11/2020 17:01, Dietmar Eggemann wrote:
> On 12/11/2020 15:41, Qais Yousef wrote:
>> On 11/11/20 18:41, Dietmar Eggemann wrote:
>>> On 10/11/2020 13:21, Peter Zijlstra wrote:
>>>> On Tue, Nov 03, 2020 at 10:37:56AM +0800, Yun Hsiang wrote:
[...]
>> If you
er_defined uclamp_se it is currently first reset
and then set.
Fix this by AND'ing !user_defined with !SCHED_FLAG_UTIL_CLAMP which
stands for the 'sched class change' case.
The related condition 'if (uc_se->user_defined)' moved from
__setscheduler_uclamp() into uclamp_res
On 12/11/2020 15:41, Qais Yousef wrote:
> On 11/11/20 18:41, Dietmar Eggemann wrote:
>> On 10/11/2020 13:21, Peter Zijlstra wrote:
>>> On Tue, Nov 03, 2020 at 10:37:56AM +0800, Yun Hsiang wrote:
[...]
> I assume we agree then that we don't want to explicitly document
On 11/11/2020 19:04, Peter Zijlstra wrote:
> On Wed, Nov 11, 2020 at 06:41:07PM +0100, Dietmar Eggemann wrote:
>> diff --git a/include/uapi/linux/sched/types.h
>> b/include/uapi/linux/sched/types.h
>> index c852153ddb0d..b9165f17dddc 100644
>> --- a/include/uapi/l
we can record why this isn't as nice a
> solution, dunno.
IMHO the '-1' magic value approach is cleaner. Did some light testing on it.
>From 2e6a64fac4f2f66a2c6246de33db22c467fa7d33 Mon Sep 17 00:00:00 2001
From: Dietmar Eggemann
Date: Wed, 11 Nov 2020 01:14:33 +0100
Subject
On 03/11/2020 14:48, Qais Yousef wrote:
> Oops, +Juri for real this time.
>
> On 11/03/20 13:46, Qais Yousef wrote:
>> Hi Yun
>>
>> +Juri (A question for you below)
>>
>> On 11/03/20 10:37, Yun Hsiang wrote:
[...]
>>> include/uapi/linux/sched.h | 7 +++--
>>> kernel/sched/core.c| 59 ++
+- 0.19% )
(b) w/o patch: 0.416645 +- 0.000520 seconds time elapsed ( +- 0.12% )
w/ patch: 0.358098 +- 0.000577 seconds time elapsed ( +- 0.16% )
Tested-by: Dietmar Eggemann
> According to test on hikey, the patch doesn't impact symmetric system
> compared to current imple
On 29/10/2020 14:06, Qais Yousef wrote:
> On 10/29/20 21:02, Yun Hsiang wrote:
>> Hi Qais,
>>
>> On Thu, Oct 29, 2020 at 11:08:18AM +, Qais Yousef wrote:
>>> Hi Yun
>>>
>>> Sorry for chipping in late.
>>>
>>> On 10/25/20 15:36, Yun Hsiang wrote:
[...]
#define SCHED_FLAG_UTIL_CLAMP (
On 28/10/2020 19:41, Yun Hsiang wrote:
> Hi Patrick,
>
> On Wed, Oct 28, 2020 at 11:11:07AM +0100, Patrick Bellasi wrote:
[...]
>> On Tue, Oct 27, 2020 at 16:58:13 +0100, Yun Hsiang
>> wrote...
>>
>>> Hi Diet mar,
>>> On Mon, Oct 26, 2020 at 08:0
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 5e054bca44fe92323de5e9b71478d1904b8bb1b7
Gitweb:
https://git.kernel.org/tip/5e054bca44fe92323de5e9b71478d1904b8bb1b7
Author:Dietmar Eggemann
AuthorDate:Tue, 22 Sep 2020 10:39:33 +02:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1b08782ce31f612d98e11f3e3df9a147a67d
Gitweb:
https://git.kernel.org/tip/1b08782ce31f612d98e11f3e3df9a147a67d
Author:Dietmar Eggemann
AuthorDate:Tue, 22 Sep 2020 10:39:34 +02:00
On 27/10/2020 04:32, Xuewen Yan wrote:
> the highest_flag_domain is to search the highest sched_domain
> containing flag, but if the lower sched_domain didn't contain
> the flag, but the higher sched_domain contains the flag, the
> function will return NULL instead of the higher sched_domain.
>
>
On 26/10/2020 16:45, Yun Hsiang wrote:
> Hi Dietmar,
>
> On Mon, Oct 26, 2020 at 10:47:11AM +0100, Dietmar Eggemann wrote:
>> On 25/10/2020 08:36, Yun Hsiang wrote:
>>> If the user wants to stop controlling uclamp and let the task inherit
>>> the value from the
On 25/10/2020 08:36, Yun Hsiang wrote:
> If the user wants to stop controlling uclamp and let the task inherit
> the value from the group, we need a method to reset.
>
> Add SCHED_FLAG_UTIL_CLAMP_RESET flag to allow the user to reset uclamp via
> sched_setattr syscall.
>
> The policy is
> _CLAMP_
On 22/10/2020 17:33, Vincent Guittot wrote:
> On Thu, 22 Oct 2020 at 16:53, Valentin Schneider
> wrote:
>>
>>
>> Hi Vincent,
>>
>> On 22/10/20 14:43, Vincent Guittot wrote:
[...]
>>> static int
>>> -select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int
>>> target)
>>> +selec
1 - 100 of 871 matches
Mail list logo
