Thanks Jason.
Appreciate your help and feedback for fixing this issue.
Would it be possible to access the edited version of the patch?
If yes, please share a pointer to the same.
Thanks,
Divya
On 7/2/20 12:07 PM, Jason Gunthorpe wrote:
> On Tue, Jun 23, 2020 at 07:13:09PM -0700, Divya I
Hi Leon,
Please find my comments inline -
On 6/25/20 3:09 AM, Leon Romanovsky wrote:
> On Tue, Jun 23, 2020 at 07:13:09PM -0700, Divya Indi wrote:
>> Commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list
>> before sending")'
>> -
>> 1.
ending")
Signed-off-by: Divya Indi
---
v1:
- Use flag IB_SA_NL_QUERY_SENT to prevent the use-after-free.
v2:
- Use atomic bit ops for setting and testing IB_SA_NL_QUERY_SENT.
- Rewording and adding comments.
v3:
- Change approach and remove usage of IB_SA_NL_QUERY_SENT.
- Add req to re
Hi Jason,
Thanks for taking the time to review!
On 6/17/20 11:24 AM, Jason Gunthorpe wrote:
> On Tue, Jun 16, 2020 at 10:56:53AM -0700, Divya Indi wrote:
>> The other option might be to use GFP_NOWAIT conditionally ie
>> (only use GFP_NOWAIT when GFP_ATOMIC is not specified i
Hi Leon,
Please find my comments inline -
On 6/13/20 11:41 PM, Leon Romanovsky wrote:
> On Tue, Jun 09, 2020 at 07:45:21AM -0700, Divya Indi wrote:
>> Hi Leon,
>>
>> Thanks for taking the time to review.
>>
>> Please find my comments inline -
>>
>&
e called in interrupt context, using workqueue to fix it.
Fixes:
> Signed-off-by: Kefeng Wang
Reviewed-by: Divya Indi
> ---
> v2:
> - add include of linux/workqueue.h
> - add missing cancel_work_sync() suggested by Divya Indi
>
> samples/ftrace/sample-trace-array.c | 18 +++
Reviewed-by: Divya Indi
On 6/9/20 6:52 AM, Kefeng Wang wrote:
> Remove trace_array 'sample-instance' if kthread_run fails
> in sample_trace_array_init().
>
> Signed-off-by: Kefeng Wang
> ---
> samples/ftrace/sample-trace-array.c | 6 +-
> 1 file chang
Thanks Leon, Noted!
On 6/9/20 12:03 AM, Leon Romanovsky wrote:
> On Mon, Jun 08, 2020 at 07:46:15AM -0700, Divya Indi wrote:
>> [PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg
>>
>> Hi,
>>
>> Please review the patch that follows.
> Please r
Hi Leon,
Thanks for taking the time to review.
Please find my comments inline -
On 6/9/20 12:00 AM, Leon Romanovsky wrote:
> On Mon, Jun 08, 2020 at 07:46:16AM -0700, Divya Indi wrote:
>> Commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list
>> before
Hi Kefeng,
Thanks for catching this issue.
Please find my comments line -
On 6/8/20 12:54 AM, Kefeng Wang wrote:
> BUG: sleeping function called from invalid context at
> kernel/locking/mutex.c:935
> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 0, name: swapper/5
> 1 lock held by s
Hi Steve,
Sure, I am looking into it and reviewing the patch.
Thanks,
Divya
On 6/8/20 7:37 AM, Steven Rostedt wrote:
> On Mon, 8 Jun 2020 07:54:37 +
> Kefeng Wang wrote:
>
>> BUG: sleeping function called from invalid context at
>> kernel/locking/mutex.c:935
>> in_atomic(): 1, irqs_disab
response comes in before adding request to
the request list, send(rdma_nl_multicast) and add to list while holding the
spinlock - request_lock.
3. Use GFP_NOWAIT for rdma_nl_multicast since it is called while holding
a spinlock. In case of memory allocation failure, request will go out to SA.
Signe
[PATCH v3] IB/sa: Resolving use-after-free in ib_nl_send_msg
Hi,
Please review the patch that follows.
v3 addresses the previously raised concerns. Changes include -
1. To resolve the race where the timer can kick in before request
has been sent out, we now add the request to the list after se
Hi Jason,
I wanted to follow up to see if you got a chance to review the following reply?
Let me know if it addresses your concern and if you have any questions!
Thanks,
Divya
On 5/13/20 2:02 PM, Divya Indi wrote:
> Hi Jason,
>
> Please find my comments inline -
>
> On 5/13/20
Hi Markus,
Thanks for taking the time to review.
On 5/15/20 9:25 AM, Markus Elfring wrote:
>> This patch fixes commit -
>> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list
>> before sending")'
>>
>> Above commit adds the query to the request list before ib_nl_snd_msg.
> I s
e list with the original delay.
To handle the case where a response is received before we could set this
flag, the response handler waits for the flag to be
set before proceeding with the query.
Signed-off-by: Divya Indi
---
drivers/infiniband/core/sa_query.c | 53 +++
[PATCH v2] IB/sa: Resolving use-after-free in ib_nl_send_msg.
Hi,
This is the v2 of the patch that addresses the comments received for v1 -
- Using atomic bit ops for setting and testing IB_SA_NL_QUERY_SENT.
- Rewording and adding comments.
Thanks,
Divya
Hi Jason,
Please find my comments inline -
On 5/13/20 8:00 AM, Jason Gunthorpe wrote:
> On Mon, May 11, 2020 at 02:26:30PM -0700, Divya Indi wrote:
>>>> @@ -1123,6 +1156,18 @@ int ib_nl_handle_resolve_resp(struct sk_buff *skb,
>>>>
>&g
Hi Hillf,
Please find my comments inline -
On 5/8/20 4:03 AM, Hillf Danton wrote:
> On Thu, 7 May 2020 12:36:29 Mark Bloch wrote:
>> On 5/7/2020 11:34, Divya Indi wrote:
>>> This patch fixes commit -
>>> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the
Hi Jason,
On 5/7/20 5:08 PM, Jason Gunthorpe wrote:
> On Thu, May 07, 2020 at 11:34:47AM -0700, Divya Indi wrote:
>> This patch fixes commit -
>> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list
>> before sending")'
>>
>>
Hi Mark,
Please find my comments inline -
On 5/7/20 2:40 PM, Mark Bloch wrote:
>
> On 5/7/2020 13:16, Wan, Kaike wrote:
>>
>>> -Original Message-
>>> From: Mark Bloch
>>> Sent: Thursday, May 07, 2020 3:36 PM
>>> To: Divya I
Hi,
Thanks for taking the time to review. Please find my comments inline -
On 5/7/20 1:16 PM, Wan, Kaike wrote:
>
>> -Original Message-
>> From: Mark Bloch
>> Sent: Thursday, May 07, 2020 3:36 PM
>> To: Divya Indi ; linux-kernel@vger.kernel.org; linux-
>
e list with the original delay.
To handle the case where a response is received before we could set this
flag, the response handler waits for the flag to be
set before proceeding with the query.
Signed-off-by: Divya Indi
---
drivers/infiniband/core/sa_query.c | 45 +++
[PATCH] IB/sa: Resolving use-after-free in ib_nl_send_msg.
Hi,
This patch is in reply to -
https://lkml.org/lkml/2020/4/24/1076
We have a use-after-free possibility in the ibacm code path -
when the timer(ib_nl_request_timeout) kicks in before ib_nl_snd_msg
has completed sending the query out
Hi Jason,
Thanks for taking the time to review.
On 4/24/20 11:22 AM, Jason Gunthorpe wrote:
> On Fri, Apr 24, 2020 at 08:28:09AM -0700, Divya Indi wrote:
>
>> If we look at the query, it does not appear to be a valid ib_sa_query.
>> Instead
>> looks like a pid struct fo
Hi Steven,
Please find my comments inline -
On 10/15/19 4:19 PM, Steven Rostedt wrote:
On Wed, 14 Aug 2019 10:55:27 -0700
Divya Indi wrote:
Adding 2 new functions -
1) trace_array_lookup : Look up and return a trace array, given its
name.
2) trace_array_set_clr_event : Enable/disable event
Hi Steve,
Thanks again for taking the time to review and providing feedback. Please find
my comments inline.
On 10/15/19 4:04 PM, Steven Rostedt wrote:
Sorry for taking so long to getting to these patches.
On Wed, 14 Aug 2019 10:55:26 -0700
Divya Indi wrote:
For functions returning a
teven Rostedt wrote:
On Fri, 20 Sep 2019 16:59:26 -0700
Divya Indi wrote:
This is a sample module to demostrate the use of the newly introduced and
exported APIs to access Ftrace instances from within the kernel.
Newly introduced APIs used here -
1. Create a new trace array if it do
[PATCH] tracing: Sample module to demonstrate kernel access to Ftrace
Hi,
This patch is for a sample module to demonstrate the use of APIs that
were introduced/exported in order to access Ftrace instances from within the
kernel.
Please Note: This module is dependent on -
- commit: f45d122 trac
trace_array *tr)
Signed-off-by: Divya Indi
Reviewed-by: Manjunath Patil
Reviewed-by: Joe Jin
---
samples/Kconfig | 7 ++
samples/Makefile | 1 +
samples/ftrace_instance/Makefile | 6 ++
samples/ftrace_instance/sample-trace
.
// tr no longer required
trace_array_put();
Signed-off-by: Divya Indi
---
include/linux/trace.h | 1 +
kernel/trace/trace.c | 41 -
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/include/linux/trace.h b/include/linux/trace.h
index 24fcf0
Declare the newly introduced and exported APIs in the header file -
include/linux/trace.h. Moving previous declarations from
kernel/trace/trace.h to include/linux/trace.h.
Signed-off-by: Divya Indi
---
include/linux/trace.h | 7 +++
kernel/trace/trace.h | 4 +---
2 files changed, 8
3.
Please review the patches that follow.
Divya Indi (5):
tracing: Declare newly exported APIs in include/linux/trace.h
tracing: Verify if trace array exists before destroying it.
tracing: Adding NULL checks
tracing: Handle the trace array ref counter in new functions
tracing: New fun
disable events to tr
trace_array_set_clr_event(tr, _THIS_IP,"system","event",1);
// Done using tr
trace_array_put(tr);
..
Also, use trace_array_set_clr_event to enable/disable events to a trace array.
So now we no longer need to have ftrace_set_clr_event as an exported
API.
Signed-off-by
A trace array can be destroyed from userspace or kernel. Verify if the
trace exists before proceeding to destroy/remove it.
Signed-off-by: Divya Indi
---
kernel/trace/trace.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel
As part of commit f45d1225adb0 ("tracing: Kernel access to Ftrace
instances") we exported certain functions. Here, we are adding some additional
NULL checks to ensure safe usage by users of these APIs.
Signed-off-by: Divya Indi
---
kernel/trace/trace.c| 3 +++
ke
Hi Steven,
On 8/2/19 2:25 PM, Steven Rostedt wrote:
On Fri, 2 Aug 2019 14:12:54 -0700
Divya Indi wrote:
Hi Steve,
The first patch would be like a temporary fix in case we need more
changes to the patches that add the new function - trace_array_set_clr()
and unexport ftrace_set_clr_event
this series).
If they all are to go in together as part of the same release ie if all
is good with the concerned patches (Patch 6 & Patch 7), then I think
having this patch would be meaningless.
Thanks,
Divya
On 8/2/19 1:46 PM, Steven Rostedt wrote:
On Fri, 2 Aug 2019 13:41:20 -0700
D
Hi Steven,
On 7/29/19 5:51 PM, Steven Rostedt wrote:
On Mon, 29 Jul 2019 17:02:34 -0700
Divya Indi wrote:
Use "trace_array_set_clr_event" to enable/disable events to a trace
array from other kernel modules/components.
Hence, we no longer need to have ftrace_set_clr_event as an ex
A trace array can be destroyed from userspace or kernel. Verify if the
trace array exists before proceeding to destroy/remove it.
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
kernel/trace/trace.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff
it in the header file - include/linux/trace_events.h
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
include/linux/trace_events.h | 1 +
kernel/trace/trace_events.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/trace_events.h b/include/linux/trac
Use "trace_array_set_clr_event" to enable/disable events to a trace
array from other kernel modules/components.
Hence, we no longer need to have ftrace_set_clr_event as an exported API.
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
include/linux/trace_events.h | 1
Declare the newly introduced and exported APIs in the header file -
include/linux/trace.h. Moving previous declarations from
kernel/trace/trace.h to include/linux/trace.h.
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
include/linux/trace.h | 7 +++
kernel/trace/trace.h | 4
.
// tr no longer required
trace_array_put();
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
include/linux/trace.h | 1 +
kernel/trace/trace.c | 43 ++-
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/include/linux/trace.h b/inc
As part of commit f45d1225adb0 ("tracing: Kernel access to Ftrace
instances") we exported certain functions. Here, we are adding some additional
NULL checks to ensure safe usage by users of these APIs.
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
kernel/trace/trace.c
disable events to tr
trace_array_set_clr_event(tr, _THIS_IP,"system","event",1);
// Done using tr
trace_array_put(tr);
..
Signed-off-by: Divya Indi
Reviewed-By: Aruna Ramakrishna
---
include/linux/trace.h| 2 ++
include/linux/trace_events.h | 2 ++
kernel/trace/trace.c | 28 ++
In addition to patches introduced by commit f45d1225adb0 "tracing: Kernel
access to Ftrace instances") we also need the following patches to reliably
access ftrace instances from other kernel modules or components.
Please review the patches that follow.
Divya Indi (7):
tracing
Hi Steven,
Thanks for reviewing the patch. I have made a note of all the suggested
changes, comment requirements.
Will send them out soon as v2.
(comments inline)
On 6/17/19 4:45 PM, Steven Rostedt wrote:
On Wed, 12 Jun 2019 09:34:19 -0700
Divya Indi wrote:
Adding 2 new functions -
1
associated with the trace array
they return. This is to ensure the trace array does not get freed
while in use by the newly introduced APIs.
The reference ctr is decremented in the trace_array_destroy.
Signed-off-by: Divya Indi
---
include/linux/trace_events.h | 3 +++
kernel/trace/trace.c
commit f45d1225adb0 ("tracing: Kernel access to Ftrace instances")
exported certain functions providing access to Ftrace instances from
other kernel components.
Adding some additional NULL checks to ensure safe usage by the users.
Signed-off-by: Divya Indi
---
kernel/trace/trace.c
lude/linux/trace_events.h.
Signed-off-by: Divya Indi
---
include/linux/trace_events.h | 6 ++
kernel/trace/trace_events.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 8a62731..d7b7d85 100644
--- a/include/linux/trac
Hi,
Please review the patches that follow -
[PATCH 1/3] tracing: Relevant changes for kernel access to Ftrace instances.
[PATCH 2/3] tracing: Adding additional NULL checks.
[PATCH 3/3] tracing: Add 2 new funcs. for kernel access to Ftrace instances.
This is v2 for the series with changes made to
Hi Steven,
Thanks for taking the time to review. Please find my comments inline.
On 6/8/19 2:51 PM, Steven Rostedt wrote:
On Tue, 4 Jun 2019 17:42:05 -0700
Divya Indi wrote:
Adding 2 new functions -
1) trace_array_lookup : Look up and return a trace array, given its
name.
2
Hi,
Please Review the patches that follow. These include -
[PATCH 1/3] tracing: Relevant changes for kernel access to Ftrace instances.
[PATCH 2/3] tracing: Adding additional NULL checks.
[PATCH 3/3] tracing: Add 2 new funcs. for kernel access to Ftrace instances.
Let me know if you have any con
Now that we have exported certain functions providing access to Ftrace
instances from other kernel components, we are adding some additional
NULL checks to ensure safe usage by the users.
Signed-off-by: Divya Indi
---
kernel/trace/trace.c| 3 +++
kernel/trace/trace_events.c | 2 ++
2
/trace_events.h.
Signed-off-by: Divya Indi
---
include/linux/trace_events.h | 6 ++
kernel/trace/trace_events.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 8a62731..d7b7d85 100644
--- a/include/linux
Adding 2 new functions -
1) trace_array_lookup : Look up and return a trace array, given its
name.
2) trace_array_set_clr_event : Enable/disable event recording to the
given trace array.
Signed-off-by: Divya Indi
---
include/linux/trace_events.h | 3 +++
kernel/trace/trace.c | 11
On 05/20/2019 08:23 AM, Steven Rostedt wrote:
On Wed, 15 May 2019 20:24:43 -0700
Steven Rostedt wrote:
It seems your's already in Steve's ftrace/core branch, so I think you
can make
additional patch to fix it. Steve, is that OK?
Yes. In fact I already sent a pull request to Linus. Pleas
Hi Masami,
Thanks for pointing it out.
Yes, it should not be static.
On 5/15/19 5:09 PM, Masami Hiramatsu wrote:
HI Divya,
On Wed, 20 Mar 2019 11:28:51 -0700
Divya Indi wrote:
Ftrace provides the feature “instances” that provides the capability to
create multiple Ftrace ring buffers
patch aims to extend this infrastructure to provide the
flexibility to create/log/remove/ enable-disable existing trace events
to these buffers from within the kernel.
Signed-off-by: Divya Indi
Reviewed-by: Joe Jin
---
kernel/trace/trace.c| 74
[PATCH] tracing: Kernel access to Ftrace instances.
Please review the patch that follows. Below are some details providing
the goal and justification for the patch.
===
Goal:
Ftrace provides the feature “instances” that provide
Sure, thanks for taking the time to review.
There are a few issues with the patch styling and some minor modifications. I
will shortly send the v2 for the same.
Regards,
Divya
On 03/19/2019 01:16 PM, Steven Rostedt wrote:
On Fri, 15 Mar 2019 16:35:25 -0700
Divya Indi wrote:
Ftrace
patch aims to extend this infrastructure to provide the
flexibility to create/log/remove/ enable-disable existing trace events
to these buffers from within the kernel.
Signed-off-by: Divya Indi
---
kernel/trace/trace.c| 72 +
kernel/trace
[PATCH] tracing: Kernel access to ftrace instances.
Please review the patch that follows. Below are some details providing
the goal and justification for the patch.
===
Goal:
Ftrace provides the feature “instances” that provide
64 matches
Mail list logo
