Fixes sparse warning: Using plain integer as NULL pointer
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/gasket/gasket_page_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b/drivers/staging/gasket/gasket_page_table.c
Fixes sparse warning: Using plain integer as NULL pointer
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/gasket/gasket_page_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_page_table.c
b/drivers/staging/gasket/gasket_page_table.c
On 09/16/2017 06:28 AM, Daniel Lezcano wrote:
On 16/09/2017 08:23, Dmitriy Cherkasov wrote:
On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
Where is get_cycles64() ?
This is in asm/timex.h. Should this be split into a separate asm header
ala arm64?
No, it is fine but may
On 09/16/2017 06:28 AM, Daniel Lezcano wrote:
On 16/09/2017 08:23, Dmitriy Cherkasov wrote:
On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
Where is get_cycles64() ?
This is in asm/timex.h. Should this be split into a separate asm header
ala arm64?
No, it is fine but may
On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
All this code must go in the timer side and use the TIMER_OF_DECLARE
macro with the proper wrappers.
Hi, thanks for the feedback.
Agreed. I'll clean this up.
Where is the request_per_cpu_interrupt()?
What is this riscv_timer_interrupt()
On 09/13/2017 11:15 AM, Daniel Lezcano wrote:
All this code must go in the timer side and use the TIMER_OF_DECLARE
macro with the proper wrappers.
Hi, thanks for the feedback.
Agreed. I'll clean this up.
Where is the request_per_cpu_interrupt()?
What is this riscv_timer_interrupt()
This #if 0 block has been commented out for years. Assume it is not
needed and remove it.
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
drivers/staging/lustre/lustre/lov/lov_io.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_i
This #if 0 block has been commented out for years. Assume it is not
needed and remove it.
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/lustre/lustre/lov/lov_io.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_io.c
b/drivers/staging/lustre
Add missing parameter name to fix the following checkpatch.pl warning:
WARNING: function definition argument 'struct device *' should also have
an identifier name
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++--
1 file c
Add missing parameter name to fix the following checkpatch.pl warning:
WARNING: function definition argument 'struct device *' should also have
an identifier name
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2
After removing commented out code, ksocknal_csum() becomes a useless
wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
Fixes the following checkpatch warning:
WARNING: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
After removing commented out code, ksocknal_csum() becomes a useless
wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
Fixes the following checkpatch warning:
WARNING: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov
---
v5:
- fix incomplete
On 06/29/2017 10:50 PM, Dmitriy Cherkasov wrote:
After removing code which was permanently disabled with ifdefs, the
function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
this useless wrapper and instead call crc32_le() directly.
Any feedback on v4 please?
On 06/29/2017 10:50 PM, Dmitriy Cherkasov wrote:
After removing code which was permanently disabled with ifdefs, the
function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
this useless wrapper and instead call crc32_le() directly.
Any feedback on v4 please?
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
Changes since v3:
* fixed spacing issues
* fixed typo in commit message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
.../staging/lustre/lnet/klnds/s
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov
---
Changes since v3:
* fixed spacing issues
* fixed typo in commit message
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
.../staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 20
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++---
2 files changed, 7 insertions(+), 18 del
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 14 +++---
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers
On 06/30/2017, Joe Perches wrote:
Please use checkpatch on your proposed patches before
sending them.
Whoops! Sorry about that. Fixed and re-sent.
On 06/30/2017, Joe Perches wrote:
Please use checkpatch on your proposed patches before
sending them.
Whoops! Sorry about that. Fixed and re-sent.
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 10 +-
2 files changed, 5 insertions(+), 16 deletions(-)
: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 11 ---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 10 +-
2 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers
Remove code which was permanently disabled with ifdefs.
This also resolves the following checkpatch warning which was
triggered by the dead code:
WARNING: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov <dmit...@oss-tech.org>
---
drivers/staging/lustre/lnet/klnds/s
Remove code which was permanently disabled with ifdefs.
This also resolves the following checkpatch warning which was
triggered by the dead code:
WARNING: space prohibited before semicolon
Signed-off-by: Dmitriy Cherkasov
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 --
1
24 matches
Mail list logo
